]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/log
Hunter Haugen [Wed, 10 Feb 2016 14:47:47 +0000 (06:47 -0800)]
Merge pull request #605 from jonnytpuppet/modules-2159
Updated acceptance test for modules-2159
Jonathan Tripathy [Wed, 10 Feb 2016 14:31:20 +0000 (14:31 +0000)]
Updated acceptance test for modules-2159
JT (Jonny) [Wed, 10 Feb 2016 14:16:46 +0000 (14:16 +0000)]
Merge pull request #602 from uobnetops/MODULES-2159
(MODULES-2159) ignore the --connlimit-saddr switch when parsing rules
TP Honey [Wed, 10 Feb 2016 10:57:31 +0000 (10:57 +0000)]
Merge pull request #604 from jonnytpuppet/facter_flush
Made Facter flushing specific to a single fact.
Jonathan Tripathy [Wed, 10 Feb 2016 10:49:15 +0000 (10:49 +0000)]
Made Facter flushing specific to a single fact.
Hunter Haugen [Tue, 9 Feb 2016 16:53:04 +0000 (08:53 -0800)]
Merge pull request #603 from jonnytpuppet/modules-3032
(MODULES 3932) - We need to call Facter.flush to clear Facter cache
Jonathan Tripathy [Tue, 9 Feb 2016 16:11:40 +0000 (16:11 +0000)]
(MODULES 3932) - We need to call Facter.flush to clear Facter cache to
get up to date value for :iptables_persistent_version.
TP Honey [Wed, 3 Feb 2016 15:48:59 +0000 (15:48 +0000)]
Merge pull request #583 from cristifalcas/update_iptables
allow iptables package to be updated
Cristian Falcas [Wed, 25 Nov 2015 12:26:10 +0000 (14:26 +0200)]
allow iptables package to be updated
Paul Seward [Mon, 1 Feb 2016 12:05:39 +0000 (12:05 +0000)]
(MODULES-2159) ignore the --connlimit-saddr switch when parsing rules
Workaround for https://tickets.puppetlabs.com/browse/MODULES-2159 (as described by Greg Murphy in that ticket)
On some distributions (notably on Ubuntu 14.04 and above, and Centos7 and above) the --connlimit-saddr switch is added after the rule is applied causing rule_to_hash to ignore the rule. Puppet then attempts (and failes) to re-create the rule every time it runs.
Hunter Haugen [Wed, 27 Jan 2016 16:36:48 +0000 (08:36 -0800)]
Merge pull request #599 from DavidS/fm-4049-update-msync
(FM-4049) update to modulesync_configs
David Schmitt [Mon, 25 Jan 2016 16:01:02 +0000 (16:01 +0000)]
(FM-4049) Update to current msync configs [
2c99161 ]
Helen [Fri, 22 Jan 2016 15:56:57 +0000 (15:56 +0000)]
Merge pull request #600 from jonnytpuppet/gem_version_workaround
Workaround for https://github.com/bundler/bundler/issues/3187
Jonathan Tripathy [Fri, 22 Jan 2016 14:36:40 +0000 (14:36 +0000)]
Workaround for https://github.com/bundler/bundler/issues/3187
David Schmitt [Thu, 21 Jan 2016 15:54:56 +0000 (15:54 +0000)]
Merge pull request #598 from jonnytpuppet/add_debian_8_nodesets
Added Debian 8 nodesets
Jonathan Tripathy [Thu, 21 Jan 2016 15:47:26 +0000 (15:47 +0000)]
Added Debian 8 nodesets
David Schmitt [Thu, 21 Jan 2016 14:54:33 +0000 (14:54 +0000)]
Merge pull request #597 from jonnytpuppet/rspec_core_update
Updated Gemfile to avoid BKR-537
Jonathan Tripathy [Thu, 21 Jan 2016 14:37:15 +0000 (14:37 +0000)]
Updated Gemfile to avoid BKR-537
JT (Jonny) [Fri, 15 Jan 2016 13:36:00 +0000 (13:36 +0000)]
Merge pull request #576 from nward/support_ipv6_nat
Support IPv6 NAT on Linux 3.7+
David Schmitt [Fri, 8 Jan 2016 14:16:24 +0000 (14:16 +0000)]
Merge pull request #578 from abednarik/fix/master/redhat_service_name_references
(MODULES-2783) Missing ip6tables service name
abednarik [Wed, 4 Nov 2015 22:02:56 +0000 (19:02 -0300)]
(MODULES-2783) Missing ip6tables service name
Replaced hardcoded iptables service references with $service_name
variable.
Jesse Lovelace [Thu, 17 Dec 2015 17:59:36 +0000 (11:59 -0600)]
Merge pull request #596 from bmjen/fix-ci
(maint) fixes acceptance tests
Bryan Jen [Thu, 17 Dec 2015 17:58:11 +0000 (10:58 -0700)]
(maint) fixes acceptance tests
Jesse Lovelace [Thu, 17 Dec 2015 15:39:59 +0000 (09:39 -0600)]
Merge pull request #595 from bmjen/fix-ci
(maint) fixes typo in firewall acceptance test.
Bryan Jen [Thu, 17 Dec 2015 15:38:26 +0000 (08:38 -0700)]
(maint) fixes typo in firewall acceptance test.
Bryan Jen [Tue, 15 Dec 2015 15:57:06 +0000 (08:57 -0700)]
Merge pull request #594 from mentat/fix_ci_bug
Fix for CI acceptance fail.
Jesse Lovelace [Tue, 15 Dec 2015 15:35:13 +0000 (09:35 -0600)]
Fix for CI acceptance fail.
TP Honey [Mon, 14 Dec 2015 15:02:16 +0000 (15:02 +0000)]
Merge pull request #593 from mlosapio/feature/log-uid
Adding in log_uid boolean for LOG
Michael LoSapio [Wed, 18 Nov 2015 22:18:39 +0000 (17:18 -0500)]
Adding in log_uid boolean for LOG
Jesse Lovelace [Thu, 10 Dec 2015 18:07:27 +0000 (12:07 -0600)]
Merge pull request #579 from maxvozeler/fix/chain_f_fix
(MODULES-2836) Fix handling of chains that contain '-f'
Max Vozeler [Mon, 16 Nov 2015 13:01:35 +0000 (14:01 +0100)]
Fix handling of chain names that contain -f
TP Honey [Tue, 8 Dec 2015 15:26:56 +0000 (15:26 +0000)]
Merge pull request #592 from puppetlabs/1.7.x
Mergeback 1.7.x
JT (Jonny) [Mon, 7 Dec 2015 16:48:31 +0000 (16:48 +0000)]
Merge pull request #580 from tphoney/release_1.7.2
release prep 1.7.2
David Schmitt [Fri, 4 Dec 2015 15:50:04 +0000 (15:50 +0000)]
Merge pull request #591 from jonnytpuppet/1.7.x_rel_prep_ci_fixes
1.7.x rel prep ci fixes
Jonathan Tripathy [Thu, 3 Dec 2015 15:42:48 +0000 (15:42 +0000)]
Updated logic to debian manifest file
Jonathan Tripathy [Thu, 26 Nov 2015 16:48:18 +0000 (16:48 +0000)]
(MAINT) - Commented out CLUSTERIP tests as there are suspicions that the
ipt module is causing system reboots.
Jonathan Tripathy [Thu, 26 Nov 2015 15:21:31 +0000 (15:21 +0000)]
Unit test fixes
Jonathan Tripathy [Thu, 26 Nov 2015 14:33:23 +0000 (14:33 +0000)]
More file renames
Jonathan Tripathy [Thu, 26 Nov 2015 14:14:15 +0000 (14:14 +0000)]
Rename internal custom nodeset files
Jonathan Tripathy [Wed, 25 Nov 2015 17:41:16 +0000 (17:41 +0000)]
Further nodeset changes from internal CI
Jonathan Tripathy [Tue, 24 Nov 2015 16:54:06 +0000 (16:54 +0000)]
Added nodeset files for internal Puppet CI.
David Schmitt [Thu, 3 Dec 2015 15:48:07 +0000 (15:48 +0000)]
Merge pull request #590 from jonnytpuppet/fact_variable_fix
Updated logic to debian manifest file
Jonathan Tripathy [Thu, 3 Dec 2015 15:42:48 +0000 (15:42 +0000)]
Updated logic to debian manifest file
David Schmitt [Thu, 3 Dec 2015 14:18:07 +0000 (14:18 +0000)]
Merge pull request #589 from DavidS/modules-2866-add-sctp
Add: sctp-protocol to "proto"-Parameter
Nold [Tue, 24 Nov 2015 07:27:34 +0000 (08:27 +0100)]
Add: sctp-protocol to "proto"-Parameter
Helen [Thu, 26 Nov 2015 16:51:20 +0000 (16:51 +0000)]
Merge pull request #588 from jonnytpuppet/hang_fix2
(MAINT) - Commented out CLUSTERIP tests as there are suspicions that the
Jonathan Tripathy [Thu, 26 Nov 2015 16:48:18 +0000 (16:48 +0000)]
(MAINT) - Commented out CLUSTERIP tests as there are suspicions that the
ipt module is causing system reboots.
David Schmitt [Thu, 26 Nov 2015 15:33:15 +0000 (15:33 +0000)]
Merge pull request #587 from jonnytpuppet/unit_test_fix
Unit test fixes
Jonathan Tripathy [Thu, 26 Nov 2015 15:21:31 +0000 (15:21 +0000)]
Unit test fixes
Helen [Thu, 26 Nov 2015 14:34:04 +0000 (14:34 +0000)]
Merge pull request #586 from jonnytpuppet/hang_fix2
More file renames
Jonathan Tripathy [Thu, 26 Nov 2015 14:33:23 +0000 (14:33 +0000)]
More file renames
TP Honey [Thu, 26 Nov 2015 14:16:52 +0000 (14:16 +0000)]
Merge pull request #585 from jonnytpuppet/hang_fix2
Rename internal custom nodeset files
Jonathan Tripathy [Thu, 26 Nov 2015 14:14:15 +0000 (14:14 +0000)]
Rename internal custom nodeset files
JT (Jonny) [Wed, 25 Nov 2015 17:57:10 +0000 (17:57 +0000)]
Merge pull request #584 from jonnytpuppet/hang_fix2
Further nodeset changes from internal CI
Jonathan Tripathy [Wed, 25 Nov 2015 17:41:16 +0000 (17:41 +0000)]
Further nodeset changes from internal CI
TP Honey [Wed, 25 Nov 2015 16:41:08 +0000 (16:41 +0000)]
Merge pull request #582 from jonnytpuppet/hang_fix
Added nodeset files for internal Puppet CI.
Jonathan Tripathy [Tue, 24 Nov 2015 16:54:06 +0000 (16:54 +0000)]
Added nodeset files for internal Puppet CI.
JT (Jonny) [Tue, 24 Nov 2015 15:58:00 +0000 (15:58 +0000)]
Merge pull request #577 from reidmv/modules-1341
(MODULES-1341) Recover when deleting absent rules
tphoney [Fri, 20 Nov 2015 11:59:26 +0000 (11:59 +0000)]
release prep 1.7.2
Bryan Jen [Fri, 20 Nov 2015 16:38:01 +0000 (09:38 -0700)]
Merge pull request #575 from werekraken/security_table
MODULES-2769 - Add security table for iptables.
Reid Vandewiele [Wed, 4 Nov 2015 18:40:20 +0000 (10:40 -0800)]
(MODULES-1341) Recover when deleting absent rules
Some types, specifically the resources type, will call Firewall
instances and then use generate to build and add to the catalog firewall
resources very early in a Puppet run. Later, those resources might be
removed as a side effect of another action, such as shutting down the
firewalld service.
Prior to this commit, Puppet would try to delete firewall resources
which were already absent, and throw an error. This commit adds an
exception catcher which will check to see if the rule being removed is
absent, and if so, consider the change a success even if the firewall
command failed. It will adjust the change message to reflect the
uncertainty over how the rule was removed, though it was verified
removed.
Nathan Ward [Sun, 1 Nov 2015 03:29:05 +0000 (16:29 +1300)]
Add IPv6 NAT tests for Linux 3.7+ and update existing test to be for Linux 2.6
Nathan Ward [Sun, 1 Nov 2015 03:05:56 +0000 (16:05 +1300)]
Support IPv6 NAT in kernels with major version greater than, and equal to, 3.7.
matt.cover [Fri, 30 Oct 2015 18:32:45 +0000 (11:32 -0700)]
Add security table for iptables.
Hunter Haugen [Wed, 14 Oct 2015 16:22:32 +0000 (09:22 -0700)]
Merge pull request #574 from DavidS/fix-selinux
(MAINT) RedHat 6 also uses unconfined_t
David Schmitt [Wed, 14 Oct 2015 16:19:38 +0000 (17:19 +0100)]
(MAINT) RedHat 6 also uses unconfined_t
David Schmitt [Thu, 8 Oct 2015 13:38:16 +0000 (14:38 +0100)]
Merge pull request #573 from cdenneen/patch-1
Include osrelease check in selinux case statement
cdenneen [Wed, 7 Oct 2015 13:29:26 +0000 (09:29 -0400)]
Include osrelease check in selinux case statement
David Schmitt [Tue, 1 Sep 2015 10:43:14 +0000 (11:43 +0100)]
Merge pull request #572 from roman-mueller/deprecation_warning
MODULES-2487 Improve port deprecation warning
Roman Mueller [Sat, 29 Aug 2015 12:46:33 +0000 (14:46 +0200)]
Improve deprecation warning, add module name to it
David Schmitt [Thu, 20 Aug 2015 11:58:56 +0000 (12:58 +0100)]
Merge pull request #571 from tphoney/release_1.7.1
release prep
tphoney [Thu, 20 Aug 2015 10:08:08 +0000 (11:08 +0100)]
release prep
Bryan Jen [Wed, 19 Aug 2015 18:05:18 +0000 (11:05 -0700)]
Merge pull request #570 from hunner/deprecate_port
Deprecate port parameter
Hunter Haugen [Mon, 17 Aug 2015 22:22:04 +0000 (15:22 -0700)]
Deprecate port parameter
I couldn't find any valid use case for port, and if any valid case did
exist then sport+dport could be used.
Daniel Dreier [Wed, 12 Aug 2015 21:03:30 +0000 (14:03 -0700)]
Merge pull request #569 from grigarr/patch-1
Always use dport
Rudy Grigar [Wed, 12 Aug 2015 18:25:16 +0000 (11:25 -0700)]
Always use dport
Using 'port' allows you to spoof a source port and offers a backdoor by sending a different destination port. sport 80 -> dport 11211 would be valid for 'port => 80' and give access to a memcache instance (port 11211) running on the server.
TP Honey [Tue, 28 Jul 2015 10:44:15 +0000 (11:44 +0100)]
Merge pull request #567 from puppetlabs/1.7.x
Release 1.7.0 Prep
Jonathan Tripathy [Mon, 27 Jul 2015 14:55:54 +0000 (15:55 +0100)]
Release 1.7.0 Prep
TP Honey [Fri, 24 Jul 2015 10:40:49 +0000 (11:40 +0100)]
Merge pull request #566 from jonnytpuppet/more_test_fixes
More test logic fixes for SLES 10
Jonathan Tripathy [Fri, 24 Jul 2015 10:28:35 +0000 (11:28 +0100)]
More test logic fixes for SLES 10
Bryan Jen [Fri, 24 Jul 2015 00:08:56 +0000 (17:08 -0700)]
Merge pull request #565 from jonnytpuppet/more_test_fixes
More test exclusion logic fixes
Jonathan Tripathy [Fri, 24 Jul 2015 00:03:28 +0000 (01:03 +0100)]
More test exclusion logic fixes
David Schmitt [Thu, 23 Jul 2015 10:49:09 +0000 (11:49 +0100)]
Merge pull request #564 from jonnytpuppet/more_test_fixes
Further test exclusions for SLES 10
Jonathan Tripathy [Thu, 23 Jul 2015 10:37:27 +0000 (11:37 +0100)]
Further test exclusions for SLES 10
Hunter Haugen [Wed, 22 Jul 2015 20:38:41 +0000 (13:38 -0700)]
Merge pull request #563 from jonnytpuppet/more_test_fixes
Exclude SLES 10 from some tests
Jonathan Tripathy [Wed, 22 Jul 2015 18:21:23 +0000 (19:21 +0100)]
Exclude SLES 10 from some tests
David Schmitt [Wed, 22 Jul 2015 14:45:06 +0000 (15:45 +0100)]
Merge pull request #562 from jonnytpuppet/more_test_fixes
Adding allow ssh rule to tests
Jonathan Tripathy [Wed, 22 Jul 2015 14:00:46 +0000 (15:00 +0100)]
Adding allow ssh rule to tests
David Schmitt [Mon, 20 Jul 2015 16:11:40 +0000 (17:11 +0100)]
Merge pull request #561 from jonnytpuppet/more_test_fixes
Removed reject test in acceptance test
Jonathan Tripathy [Mon, 20 Jul 2015 15:50:13 +0000 (16:50 +0100)]
Removed reject test in acceptance test
JT (Jonny) [Mon, 20 Jul 2015 11:05:48 +0000 (12:05 +0100)]
Merge pull request #559 from BlendMarketing/master
Compatibility with Puppet 4 and Facter 3
JT (Jonny) [Thu, 16 Jul 2015 11:33:14 +0000 (12:33 +0100)]
Merge pull request #560 from estonfer/add_dscp_markings
add set_dscp and set_dscp_class
Eric Stonfer [Wed, 15 Jul 2015 17:16:06 +0000 (13:16 -0400)]
add set_dscp and set_dscp_class
Jared Meyering [Tue, 14 Jul 2015 16:35:11 +0000 (11:35 -0500)]
Merge branch 'master' of git://github.com/puppetlabs/puppetlabs-firewall
Jared Meyering [Tue, 14 Jul 2015 16:35:04 +0000 (11:35 -0500)]
facter 4 compat
JT (Jonny) [Tue, 14 Jul 2015 13:03:45 +0000 (14:03 +0100)]
Merge pull request #555 from TJM/ticket/MODULES-2186-remove_fwrules_A
MODULES-2186 - iptables rules with -A in comment
JT (Jonny) [Tue, 14 Jul 2015 13:01:52 +0000 (14:01 +0100)]
Merge pull request #554 from ghoneycutt/patch-1
Style fixes in documentation's example code
TP Honey [Fri, 3 Jul 2015 16:01:11 +0000 (17:01 +0100)]
Merge pull request #558 from jonnytpuppet/test_fix
Test fixes that may prevent hanging problems during beaker tests.
Jonathan Tripathy [Fri, 3 Jul 2015 15:26:21 +0000 (16:26 +0100)]
Test fixes that may prevent hanging problems during beaker tests.
JT (Jonny) [Fri, 3 Jul 2015 10:34:51 +0000 (11:34 +0100)]
Merge pull request #557 from DavidS/modules-2155-update-docs
(MODULES-2155) Remove note about purge restrictions