Bryan D. Payne [Mon, 31 Mar 2014 22:50:43 +0000 (15:50 -0700)]
Adds ionice command permutations to rootwrap filters
When setting volume_clear_ionice, the ionice command is prepended to a dd
command before executing it. Previously, this would have failed because it
wasn't allowed through the default rootwrap filters. This commit fixes this
problem.
Note that due to the way that the RegExpFilter works, we need three different
expressions to cover all cases. This is because the various options result
in a different number of arguments. And this filter will fail immediately
if the number of arguments is incorrect.
Andreas Jaeger [Sat, 29 Mar 2014 05:38:52 +0000 (06:38 +0100)]
Fix Jenkins translation jobs
The jobs cinder-propose-translation-update and
cinder-upstream-translation-update do not update from
transifex since our po files contain duplicate entries where
obsolete entries duplicate normal entries.
Lucian Petrut [Fri, 28 Mar 2014 08:57:13 +0000 (10:57 +0200)]
Fixes cinder volume attach on Windows
The initiator name and the target name are inverted when passing
the arguments to the method which associates the iSCSI target to
an initiator. For this reason, this operation will fail.
Also, the connection to the iSCSI target cannot be initialized
properly as the method which gets portal information is missing
the return value.
Glenn M. Gobeli [Fri, 21 Mar 2014 14:05:07 +0000 (10:05 -0400)]
Changes to correct name of missing NetApp license.
Change to have the NetApp ZAPI error of "SIS clone not licensed"
refer to the correct NetApp license of "FlexClone not licensed".
This code path is encountered when the NetApp 7mode driver uses
the clone interface for snapshotting or cloning.
Alex Meade [Thu, 20 Mar 2014 19:44:44 +0000 (15:44 -0400)]
NetApp cmode nfs: Fix QOS extra spec
This patch fixes the incorrect behavior where the NetApp cmode
nfs driver will choose to create a volume on a flexVol that has
a QOS policy group that matches the specified QOS policy group
intended for the cinder volume. The correct behavior is to ignore
the QOS policy group of the flexVol and instead assign the QOS policy
group to the newly created cinder volume.
Alex Meade [Wed, 19 Mar 2014 18:03:15 +0000 (14:03 -0400)]
NetApp cmode iscsi: Fix QOS extra spec
This patch fixes the incorrect behavior where the NetApp cmode
iscsi driver will choose to create a volume on a flexVol that has
a QOS policy group that matches the specified QOS policy group
intended for the cinder volume. The correct behavior is to ignore
the QOS policy group of the flexVol and instead assign the QOS policy
group to the newly created cinder volume.
Xing Yang [Sat, 22 Mar 2014 19:05:42 +0000 (15:05 -0400)]
Fixes a problem in attach volume in EMC driver.
This patch fixes a problem in attach volume in EMC SMI-S driver.
The existing logic checks if a volume is already attached to any host,
but it doesn't check whether a volume is already attached to the specific
host that nova wants cinder to attach. As a result, initialize_connection
could return success (thinking it is already attached), but nova will
fail to discover the LUN later and fail the attach.
This patch adds a check to see if a volume is already attached to a
specific host. If not, it will do the attach. The reason that the
volume being attached already could be due to a nova live-migration
use case. Cinder doesn't support multiple attaches currently, but
allows a volume to be attached multiple times from nova during
live-migration.
john-griffith [Wed, 26 Mar 2014 22:47:21 +0000 (16:47 -0600)]
Update config generator from OSLO
Cinders sample config is out of date with recent
updates needed for keystone, however we had an
old version of the oslo generator so there was
no way to pick these changes up locally by running
the generate tool.
This pulls the latest generator.py from oslo, and
we run the update script to get us back in sync.
Jeff Applewhite [Mon, 24 Mar 2014 21:37:22 +0000 (17:37 -0400)]
Netapp iscsi: allow snapshots with unspecified block range.
Snapshots were failing to create in all cases in the NetApp iscsi
driver. The clone lun function was never issuing the zapi call
because the block count was set to 0.
An API invocation with a stale session returns an empty response. In order
to distinguish it from an API returning valid empty response, the session
is recreated and the API is retried. If an empty response is received even
after the retry, it can be assumed that the API response is actually empty.
But this behavior results in authentication error from the VMware server
when there is an active session and the API response is actually empty.
This change fix this behavior by using the SessionIsActive check to
identify stale session.
wanghong [Thu, 20 Mar 2014 02:39:37 +0000 (10:39 +0800)]
init_host should be called before RPC consumer is created
Currently, the init_host method is called after RPC consumer is
created. This behavior will lead to a bug that when a rpc request
is received the manager can not handle it because the driver has not
been initialized!
john-griffith [Wed, 19 Mar 2014 22:19:28 +0000 (16:19 -0600)]
Add RequestContextSerializer for rpc notifications
RequestContext should be serialized when sent via oslo.messaging. The
serializer is correctly used for the general RPC mechanism, but has been
forgotten in the notifier. This patch fixes that.
Thanks goes to eharney for noticing this and pointing it out!!!
Andrew Kerr [Tue, 11 Mar 2014 14:28:55 +0000 (10:28 -0400)]
Allow NetApp iSCSI driver to sub-clone large volumes
The NetApp zapi used during certain extend operations has several limits
imposed on it. Each block-range provided can only be 2^24 in size, and
there can only be 32 block-ranges per zapi call. This fix allows the
NetApp iSCSI driver to send multiple zapi calls if necessary, to allow
for extend operations on volumes of an arbitrary size.
lirenke [Tue, 4 Mar 2014 12:59:07 +0000 (04:59 -0800)]
Can't force-create snapshot by an non-exist error volume
If we create an LVM volume whose size larger than
rest space in VG, the volume would not exist with
error status.
But then we still can force create a snapshot
by this volume, and the snapshot's status is available.
In the code,I found in create_lv_snapshot,
it return False when fail to get the volume.
However, raising an exception is only way to be
handle outside.
So, we should raise exception instead of return False.
Mike Perez [Mon, 17 Mar 2014 05:24:38 +0000 (22:24 -0700)]
Simplify test force delete snapshot unit test
Make this test simple in just verifying if we have a snapshot and we do
a force delete that we get back an ok response from the controller.
Removing out RPC call and verifying snapshot was deleted since that's
out of the scope here.
Xiao Chen [Thu, 6 Mar 2014 10:13:46 +0000 (18:13 +0800)]
resolve KeyError for IBM Storwize/SVC driver
When using iSCSI protocol to conenct IBM v7000, and compression
is not enabled for the system, KeyError may occur because of the response
item's lack of 'license_compression_enclosures'. So add a check to
resolve it.
The pbm_default_policy config option is used to associate a storage
policy with the volume backing if there is no associated volume_type
or the volume_type doesn't have the storage_profile option. A better
approach is to set the storage_profile option in the default_volume_type.
This change removes the pbm_default_policy and queries the policy
using the storage_profile option in the given volume_type.
Avishay Traeger [Wed, 26 Feb 2014 09:27:06 +0000 (11:27 +0200)]
Fix create_export/remove_export in driver.py
1. There was a call to rpcapi.create_export which does not have a
matching volume manager function, causing volume migration to crash.
This call was not necessary because there is already an
initialize_connection RPC call, which calls the driver's create_export
function. Removed the create_export RPC call and function. Added better
error handling to that code in _attach_volume in driver.py as well.
2. The manager called remove_export from detach_volume, which was not
being called by these functions. I believe it makes more sense to call
it from terminate_connection. Moved it there, and fixed up the
corresponding code in _detach_volume in driver.py.
3. Remove leftovers of export code from create_volume manager flow.
Joshua Harlow [Thu, 13 Mar 2014 00:31:29 +0000 (17:31 -0700)]
Use the error_out_volume from flow common instead
Instead of a custom piece of logic that errors out
a volume due to the driver not initialized issue
just use the same one that is used in other flows
to accomplish the same update.
Jay S. Bryant [Wed, 12 Mar 2014 22:39:18 +0000 (17:39 -0500)]
Don't send untextified exc to webob
As part of commit cbe1d5f5e22e5f792128643e4cdd6afb2ff2b5bf I
accidentally removed the str() from exceptions that were being
passed out of OpenStack to webob. This broke the contract with
webob which was expecting strings (text) to be sent. This
resulted in webob doing bad things if we encountered an exception,
like trying to create a duplicate volume type.
This commit replaces the str()'s that shouldn't have been removed
with six.text_type() which should be used in place of str() to
resolve this issue. There was one instance where a message was
instead being unicoded, this also was changed to use six.text_type.
This commit also fixes one message that should have been translated
but was not.
Joe Gordon [Mon, 10 Mar 2014 18:02:13 +0000 (11:02 -0700)]
Use debug level logging during unit tests
When unit tests fail we need to debug, so we should have debug level logging on.
We use fixtures FakeLogger during testing, to enable debug logging pass
in log level as a parameter.
john-griffith [Wed, 12 Mar 2014 16:59:45 +0000 (10:59 -0600)]
Sync log.py from oslo-incubator
This pulls in the latest version of log.py from oslo-incubator
which elminates the constant user_identity key error.
Note that this sync does a full sync, in other words it uses
the oslo update script and pulls in the log.py file and all
of the associated dependendencies for that module.
Current HEAD in OSLO:
--------------------
Merge: d9ea4f0fd33d1e
Date: Wed Mar 12 17:00:13 2014 +0000
Merge "Fix gettextutil.Message handling of deep copy failures"
--------------------
This patch is a follow up to a review that merged
included and had some issues raised after it was merged.
This patch includes some hacking cleanup and some
unit test cleanup for the Fibre Channel Zone Manager.
Steven Kaufer [Fri, 7 Mar 2014 23:01:51 +0000 (23:01 +0000)]
get volumes with limit and filters does not work
The /volumes and /volumes/detail REST APIs support filtering. Currently,
all filtering is done after the volumes are retrieved from the database
in the API.get_all function in /cinder/volume/api.py. Therefore, the usage
combination of filters and limit will only work if all volumes matching
the filters are in the page of data being retrieved from the database.
For example, assume that all of the volumes with a name of "foo" would be
retrieved from the database starting at index 100 and that you query for
all volumes with a name of "foo" while specifying a limit of 50. In this
case, the query would yield 0 results since the filter did not match any of
the first 50 entries retrieved from the database.
This patch removes all filtering from the volume API layer and moves it
into the DB layer.
Test cases were added to verify filtering at the DB level.
Lucian Petrut [Fri, 7 Mar 2014 15:09:33 +0000 (17:09 +0200)]
Fixes cinder-volume service startup on Windows
The Windows service fails due to missing non-blocking IO features
in eventlet. This fix adds a conditional path on Windows to execute
the service accordingly.
This bug had already been fixed by this this commit:
https://review.openstack.org/#/c/44744/ but it had been reverted
here, causing the Windows service to fail again
https://review.openstack.org/67031
Nova bypasses the cinder checks for a volume
being available, when it tries to attach a volume
to a new host during live migration. The assumption
in cinder to this point has been that volumes can only
be attached to one host. The 3PAR driver worked under
that assumption. This assumption fell apart during detach
time as the driver was only looking for a VLUN on the
entire 3PAR, since it assumed it could only exist on one host.
This patch ensures that the driver looks for the VLUN on the
hostname it expects.
Luis A. Garcia [Tue, 11 Mar 2014 15:34:02 +0000 (09:34 -0600)]
Adding domain to context
Add support for upcoming "domain" concept in Keystone V3 API in
the context.
This fix ensures there is a user_identity in the context for the
corresponding new attribute in the log format string added in oslo. The
oslo change has the same change-id as this one.
Vincent Hou [Wed, 4 Dec 2013 08:51:20 +0000 (03:51 -0500)]
VMware: Take the volume size from the user input
When we create a volume from an image or a snapshot, we need to
take the size of the volume from the user input and validate whether
the size is appropriate instead of taking the image size as the
volume size directly.
The VMware ESX driver in Nova is now marked as deprecated and will be
removed in Juno release. This change marks the VMware ESX vmdk driver
as deprecated since it is intended for use with the ESX driver in Nova.
The plan is to remove the ESX vmdk driver in Juno release.
Flavio Percoco [Tue, 11 Mar 2014 09:33:45 +0000 (10:33 +0100)]
Generate config samples for oslo.messaging
This patch adds oslo.messaging to the
CINDER_CONFIG_GENERATOR_EXTRA_LIBRARIES env variable, which adds
oslo.messaging config options to cinder.conf.sample
Code Review / openstack-build / cinder-build.git / log