Akihiro Motoki [Sat, 7 Nov 2015 18:07:02 +0000 (03:07 +0900)]
Make command log in neutron utils.execute() a single line
command execution log from neutron.agent.linux.utils.execute()
consists of multiple lines, and the first line has less information
and it is hard to analyze logs.
Carl Baldwin [Mon, 5 Oct 2015 21:35:37 +0000 (21:35 +0000)]
Move update_fip_statuses to Router class
I noticed that ri.floating_ips was being accessed from the agent. It
didn't seem right. Also, noticed that this set gets passed around too
much between methods. It all boils down to saving the previous set
and then doing set difference to see which ones went away. This patch
set makes it simpler.
Martin Hickey [Wed, 4 Nov 2015 21:37:21 +0000 (21:37 +0000)]
Make '*' the default ml2 flat_networks configuration
Update the ml2 flat_networks configuration to set '*' as the
default because that has been effectively the default behavior due
to a bug with the empty list.
Also, fix the empty list configuration for disabling flat networks.
DocImpact
UpgradeImpact
Change-Id: I13eb22afd7c0d011154b58a1bd218fd4fa82a8d9
Closes-bug: #1437745 Co-Authored-By: Martin Hickey <martin.hickey@ie.ibm.com>
This code only landed a few days ago. Updated the deprecated
message to be after Mitaka so that external plugins will have
some grace period to clean up their code.
Change function call order in ovs_neutron_agent during the
creation or modification of a port, in order to fulfill the
VLAN OVS tag information in the "port" register before calling
the SG agent. This information is needed in some SG agent
implementations.
Cedric Brandily [Tue, 3 Nov 2015 21:54:07 +0000 (22:54 +0100)]
Optimize delete_csnat_router_interface_ports db query
Currently delete_csnat_router_interface_ports provides an iterator as
filter to core_plugin.get_ports which is used in a SQL IN argument.
SQLAlchemy is able to avoid some db queries when the IN argument is
empty BUT not when the argument is an empty iterator and raises the
warning:
SAWarning: The IN-predicate on "ports.id" was invoked with an empty
sequence. This results in a contradiction, which nonetheless can be
expensive to evaluate. Consider alternative strategies for improved
performance.
This change replaces the iterator by a list in order to optimize db
queries when the filter is empty.
Kevin Benton [Tue, 3 Nov 2015 15:31:54 +0000 (07:31 -0800)]
Make string representation of DictModel generic
The previous version was specific to a port dict and would
fail if str() was called on other models. This iterates over
and logs all values of the dict instead so it works under any
dictionary.
Sean M. Collins [Mon, 2 Nov 2015 19:47:13 +0000 (14:47 -0500)]
Docs: clarify that AnySubnetRequest is optional
The phrasing of "may not support" was a little confusing, mostly because
I read it as an imperative - "you may not do this" instead of it
being "you can do this if you want"
Martin Hickey [Wed, 21 Oct 2015 14:24:13 +0000 (15:24 +0100)]
Update neutron-debug to use stevedore aliases
Updating neutron-debug as it is importing interface driver classes
directly and not using the load_driver_interface method.
Also adds unit tests for the neutron-debug tool.
AKamyshnikova [Thu, 8 Oct 2015 15:18:21 +0000 (18:18 +0300)]
Per-branch HEAD files for conflict management
We have pep8 check for validation revisions, but it allows
outdated changes go into merge queue. To prevent this added
CONTRACT_HEAD, EXPAND_HEAD files.
Gary Kotton [Thu, 29 Oct 2015 14:40:05 +0000 (07:40 -0700)]
Removes the use of mutables as default args
Passing mutable objects as default args is a known Python pitfall.
We'd better avoid this. This commit changes mutable default args with
None, then use 'arg = arg or {}', 'arg = arg or []'. For unit code which
doesn't use the args , just set with None. This commit also adds hacking
check.
Kyle Mestery [Thu, 29 Oct 2015 01:00:24 +0000 (10:00 +0900)]
Add notes about stable merge requirements for sub-projects
It was pointed out the requirements around what is allowed to be merged
into stable Neutron sub-projects wasn't clear. This attempts to make
that a bit more refined so those who choose to participate in the Neutron
Stadium know these requirements.
Ryan Moats [Wed, 28 Oct 2015 16:01:28 +0000 (11:01 -0500)]
Log end of router updates for PD and delete branches
These execution branches call continue directly without
logging the end of the router update. This leads to
confusion about when the last router update finishes if
it is a delete or a PD update.
Change-Id: Id82e7374aa9336e0adea3042238f30f716208373 Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
Closes-bug: #1511004
Neil Jerram [Wed, 2 Sep 2015 14:14:30 +0000 (15:14 +0100)]
DHCP agent: log when reloading allocations for a new VM port
This will help us to see more clearly if failing DHCP for a new VM -
as seen in failures such as the following traceback from [1] - is
caused by DHCP configuration being too slow, as suggested by the
referenced bug.
Traceback (most recent call last):
File "/home/aqua/tempest/tempest/test.py", line 125, in wrapper
return f(self, *func_args, **func_kwargs)
File "/home/aqua/tempest/tempest/scenario/test_server_basic_ops_38.py", line 105, in test_server_basicops
self.verify_ssh()
File "/home/aqua/tempest/tempest/scenario/test_server_basic_ops_38.py", line 95, in verify_ssh
private_key=self.keypair['private_key'])
File "/home/aqua/tempest/tempest/scenario/manager.py", line 310, in get_remote_client
linux_client.validate_authentication()
File "/home/aqua/tempest/tempest/common/utils/linux/remote_client.py", line 55, in validate_authentication
self.ssh_client.test_connection_auth()
File "/home/aqua/tempest/tempest/common/ssh.py", line 150, in test_connection_auth
connection = self._get_ssh_connection()
File "/home/aqua/tempest/tempest/common/ssh.py", line 87, in _get_ssh_connection
password=self.password)
tempest.exceptions.SSHTimeout: Connection to the 172.17.205.21 via SSH timed out.
User: cirros, Password: None
Code Review / openstack-build / neutron-build.git / log