]> review.fuel-infra Code Review - openstack-build/neutron-build.git/log
openstack-build/neutron-build.git
12 years agofall back to `ip link` when `ip tuntap` unavailable
Gary Kotton [Tue, 15 May 2012 07:33:04 +0000 (03:33 -0400)]
fall back to `ip link` when `ip tuntap` unavailable
bug 989868

In the event that the command "ip tuntap" is not found then a exception will
be raised and the command "ip link" will be perfomed.

Changes following comments

More appropriate error message

Same style for log/error messages

Change-Id: Ia912e189b73dd0d112b7ef4eefbb7245ee595b54

12 years agoCisco plugin CLI call to quantumclient CLI
mat [Wed, 16 May 2012 14:16:43 +0000 (16:16 +0200)]
Cisco plugin CLI call to quantumclient CLI

when Cisco plugin CLI is used, it wil call the quantumclient CLI if the command is not in its extensions.
the version of the Quantum API must be specified when the the Cisco plugin CLI is looking for Quantum commands.

Bug 1000251

Change-Id: I3e4039edb7cb79411fc60677ef6f99fca8007dc9

12 years agoCalling Super method from QuantumPortAwareScheduler.__init__
mat [Tue, 15 May 2012 15:35:12 +0000 (17:35 +0200)]
Calling Super method from QuantumPortAwareScheduler.__init__

the quantum.plugins.cisco.nova.quantum_port_aware_scheduler.QuantumPortAwareScheduler class wasn't calling its superclass __init__.
the host_manager attribute of driver.Scheduler class wasn't initialized, and the scheduler was crashing when it was receiving a host message via amqp.

Fixes bug 994652

Change-Id: I733d80df8f87ff314f4233b10fa8afaf454eedf0

12 years agoMerge "Include AUTHORS in release package."
Jenkins [Tue, 15 May 2012 20:34:35 +0000 (20:34 +0000)]
Merge "Include AUTHORS in release package."

12 years agoOVS plugin: add tunnel ips to central database
Dan Wendlandt [Tue, 15 May 2012 19:41:52 +0000 (12:41 -0700)]
OVS plugin: add tunnel ips to central database

bp simplify-ovs-tunnel-mgmt

Makes the OVS plugin agent report its own IP address to the centralized
quantum database, and build its set of tunnels based on the contents of
this centralized database.  This removes the need for a removes need for
a 'remote-ips' file on each compute node that needs to be updated
when a new host is added.

Also:
- simplifies error handling within tunnel manager daemon_loop
- fixes issues with operational status not working for tunnel-mode
- fixes issue that not-stripping vlan of tunneled packet potentially
crashes OVS, causing flows to get wiped.

Change-Id: I4d285669e29beecf745fe620581fa6bc332a446c

12 years agoInclude AUTHORS in release package.
Bhuvan Arumugam [Mon, 7 May 2012 03:27:26 +0000 (20:27 -0700)]
Include AUTHORS in release package.

Fixes Bug #976267.

Include AUTHORS file in release package. The file is generated
automatically from git. Handle different combination for mailmap
records. Include test case to verify this fix.

* MANIFEST.in
  Include AUTHORS file in release package.

* .gitignore
  Add AUTHORS file.

* quantum/openstack/common/setup.py
  generate_authors(): New method to create AUTHORS file. If
  AUTHORS.in file exists, append it's content to AUTHORS file.
  parse_mailmap(): Handle all mailmap combination while parsing.

* setup.py
  Import the new method.
  Generate AUTHORS file before creating the package.

* quantum/tests/unit/test_setup.py
  New test script to verify different combination of records
  in mailmap file.

Change-Id: I220e8a20c96d37df3fa2ba0424e8372496e67895

12 years agoMerge "blueprint database-common bug 995438"
Jenkins [Sat, 12 May 2012 18:55:57 +0000 (18:55 +0000)]
Merge "blueprint database-common bug 995438"

12 years agoblueprint database-common
Gary Kotton [Sun, 6 May 2012 11:36:47 +0000 (07:36 -0400)]
blueprint database-common
bug 995438

Updates after comments

Updates after comments

Updates after comments

Updates after comments - fix linux bridge tests

Change-Id: Iaee24b08e07a4f4dde5e27f31d3a5f81f5101466

12 years agobug 996163
Gary Kotton [Tue, 8 May 2012 11:46:28 +0000 (07:46 -0400)]
bug 996163

Remove unnecesary imports

Return missing logging and sys imports

Change-Id: I50923c9d42b94cabc8fbf3de7391bd03d2d14f12

12 years agoMerge "Change Resource.__call__() to not leak internal errors."
Jenkins [Thu, 10 May 2012 05:50:34 +0000 (05:50 +0000)]
Merge "Change Resource.__call__() to not leak internal errors."

12 years agoBug #994758
Piotr Siwczak [Fri, 4 May 2012 18:34:57 +0000 (11:34 -0700)]
Bug #994758

Work around this bug by installing the sqlalchemy from pip installer.
(fix)

Change-Id: I464080e433b4cad71da4510fb95dd5f902da0616

12 years agoChange Resource.__call__() to not leak internal errors.
Guilherme Salgado [Wed, 2 May 2012 11:36:56 +0000 (08:36 -0300)]
Change Resource.__call__() to not leak internal errors.

That method now catches any non-expected errors raised by the controller's
action method and turn them into an HTTPServerError. Fixes bug 980033.

Change-Id: I7f71c029fae0e27a799f11de0802bde1003683e2

12 years agoLet OVSQuantumTunnelAgent sync with database
Hiroaki KAWAI [Wed, 2 May 2012 09:27:51 +0000 (18:27 +0900)]
Let OVSQuantumTunnelAgent sync with database

In daemon_loop, db.commit() is required to fetch
updated network status. Without this, ports are
stick to DEAD_VLAN_TAG.

Change-Id: I1a951d60eb75384676309e8db29ea7baa48055bc

12 years agoCleaned up log usage.
Maru Newby [Sat, 5 May 2012 04:38:29 +0000 (21:38 -0700)]
Cleaned up log usage.

 * Used __name__ where appropriate for log instantiation.
 * Removed unnecessary logging in tests.

Change-Id: I270eb627cd1d330f37707aaf7886a9cacd251031

12 years agoblueprint agent-db-ha
Gary Kotton [Tue, 24 Apr 2012 06:02:03 +0000 (02:02 -0400)]
blueprint agent-db-ha
bug 985470
bug 985646

The fixes enable the OVS and linuxbridge agenets to "keep alive" when the host running the server/plugin is down.

Fixes after comments. Better logging

Fixes after comments - added reconnect interval + cleanup

Fixes after comments - simplify code + ovs intervals moved to configuration file

Fixes after comments - move int conversion to configuration

Fixes after comments - if one of the polling interval or reconnect interval are not
defined in the relevant ini files then a default value is used.

Fixes after comments and merges with HACKING.rst fixes

Fixes after port binding comments

Fixes after comments from gongysh

Fixes after comments - align comments in agent ini files

Fixes - revert some code

Change-Id: I9194f142478b130e8ef198b019539357a9916d7f

12 years agoMerge "Update codebase for HACKING compliance."
Jenkins [Wed, 2 May 2012 06:34:12 +0000 (06:34 +0000)]
Merge "Update codebase for HACKING compliance."

12 years agoMerge "Make sample quantum.conf compliant with docs"
Jenkins [Tue, 1 May 2012 20:15:06 +0000 (20:15 +0000)]
Merge "Make sample quantum.conf compliant with docs"

12 years agoUpdate codebase for HACKING compliance.
Maru Newby [Fri, 13 Apr 2012 19:53:56 +0000 (12:53 -0700)]
Update codebase for HACKING compliance.

 * This is a massive patch that aims to clean up the codebase
   and bring it into compliance with HACKING.rst and PEP8 in one
   fell swoop.
 * Cleaned up use of gettext.
 * Updated log usage for consistency.
 * The tests run successfully against all plugins except
   cisco and nicira (due to dependency issues with these plugins).
 * Addresses bug 981208

Change-Id: I4d8c7ab138d8f7bb906d18dc34f88f8bd0581c19

12 years agoMerge "Removed simplejson from pip-requires."
Jenkins [Sun, 29 Apr 2012 22:49:38 +0000 (22:49 +0000)]
Merge "Removed simplejson from pip-requires."

12 years agoMerge "Remove dependency on python-quantumclient"
Jenkins [Fri, 27 Apr 2012 01:20:13 +0000 (01:20 +0000)]
Merge "Remove dependency on python-quantumclient"

12 years agoMake sample quantum.conf compliant with docs
Francisco Souza [Thu, 12 Apr 2012 12:32:50 +0000 (09:32 -0300)]
Make sample quantum.conf compliant with docs

The module quantum_auth_token does not exist. Also, the documentation uses
authtoken instead of authN.

The docs, for reference: http://docs.openstack.org/incubation/openstack-network/admin/content/configuring-keystone-with-quantum.html

Change-Id: I5a225dd740bb654a0b27937ebfa68f0ef6bff4f8

12 years agoMake ovs Interface option set properly.
KAWAI Hiroaki [Wed, 25 Apr 2012 12:25:32 +0000 (21:25 +0900)]
Make ovs Interface option set properly.

Multiple ovs-vsctl set Interface option call overrides the previous
settings and result in unexpected partial condition.

Change-Id: I62b3bd6ea9adac7c1f4995fc18af9838a7e25b43

12 years agoRemoved simplejson from pip-requires.
Maru Newby [Tue, 24 Apr 2012 21:01:10 +0000 (14:01 -0700)]
Removed simplejson from pip-requires.

 * Addresses bug 921295

Change-Id: Ied6015b4115a60778dffc18c18e8907d87a7c83d

12 years agoRemove dependency on python-quantumclient
Maru Newby [Wed, 11 Apr 2012 10:07:26 +0000 (03:07 -0700)]
Remove dependency on python-quantumclient

 * quantum previously depended on python-quantumclient for the
   functionality in quantum/common.  This change migrates
   the required modules to the quantum repo and removes that
   dependency.
 * Addresses bug 977711

Change-Id: Ia17a486859eb1aa993900a5f3b582b258c6a6d78

12 years agoAdd sphinx to the test build deps.
Monty Taylor [Wed, 11 Apr 2012 01:58:34 +0000 (18:58 -0700)]
Add sphinx to the test build deps.

Needed for bug 945259

Change-Id: Idf76b3d253259deff8cc894b03d26420f2de278e

12 years agoMerge "Add HACKING.rst coding style doc"
Jenkins [Tue, 10 Apr 2012 18:53:29 +0000 (18:53 +0000)]
Merge "Add HACKING.rst coding style doc"

12 years agoAdd HACKING.rst coding style doc
Maru Newby [Tue, 10 Apr 2012 03:12:49 +0000 (20:12 -0700)]
Add HACKING.rst coding style doc

 * Addresses bug 977685

Change-Id: Id04cad3021f015abe965f79b8930da55e092ada1

12 years agoreturn 404 for invalid api version request
Mark McClain [Mon, 9 Apr 2012 14:08:00 +0000 (10:08 -0400)]
return 404 for invalid api version request

fixes bug: 934115

This fix returns 404 for all non-root requests that route via the
versions app. For root requests ('/') the available api version info is
returned.

Change-Id: I701389d9239cb40426f7a47206642b56c7eeeae1

12 years agofix issue with OVS plugin VLAN allocation after a quantum-server restart
Dan Wendlandt [Tue, 3 Apr 2012 03:14:37 +0000 (20:14 -0700)]
fix issue with OVS plugin VLAN allocation after a quantum-server restart

bug 962853

Also use constants for VLAN_MIN/VLAN_MAX and clean-up VlanMap unit tests.

Change-Id: Id7b580d604092b5fc16d4c87ae866d419aad4d1f

12 years agobug 963152: add a few missing files to sdist tarball
Dan Wendlandt [Mon, 2 Apr 2012 17:38:06 +0000 (10:38 -0700)]
bug 963152: add a few missing files to sdist tarball

Change-Id: I36e98c98e09c8a91f1e2e2e15f833079ea6b377c

12 years agoAPI docs: fix typo for network delete
Dan Wendlandt [Thu, 22 Mar 2012 16:49:54 +0000 (09:49 -0700)]
API docs: fix typo for network delete

bug 962282

Change-Id: Ic7f633b59d963e8a14a993468048ccbded9aba34

12 years agoOpen Folsom
Thierry Carrez [Fri, 16 Mar 2012 22:19:22 +0000 (23:19 +0100)]
Open Folsom

Change-Id: Ic594468be5b3c79a8e3d97b6a81668a0db98885b

12 years agoMerge "plugin/ryu/agent: unbreak a06b316cb47369ef4a2c522f5240fa3f7f529135"
Jenkins [Fri, 16 Mar 2012 08:12:28 +0000 (08:12 +0000)]
Merge "plugin/ryu/agent: unbreak a06b316cb47369ef4a2c522f5240fa3f7f529135"

12 years agoBug #956559
Sumit Naiksatam [Thu, 15 Mar 2012 23:43:19 +0000 (16:43 -0700)]
Bug #956559
VIF driver and scheduler for UCS plugin are broken since the flag
configuration mechanism in nova is changed. Fixing that and also
fixing some property names, along changes to how the quantum client
code is invoked.

Change-Id: I757cc149f08673ce24d35ee0bfffae8e5b1a4afc

12 years agoplugin/ryu/agent: unbreak a06b316cb47369ef4a2c522f5240fa3f7f529135
Isaku Yamahata [Fri, 16 Mar 2012 02:47:48 +0000 (11:47 +0900)]
plugin/ryu/agent: unbreak a06b316cb47369ef4a2c522f5240fa3f7f529135

ryu quantum agent needs 'import shlex' like ovs and linuxbridge.
Otherwise it aborts as

> NameError: global name 'shlex' is not defined

Change-Id: I0d0e4a95a4628953bf44bebf54c46f74aa9eddf4
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
12 years agoFix path to python-quantumclient
Brad Hall [Thu, 15 Mar 2012 23:45:09 +0000 (16:45 -0700)]
Fix path to python-quantumclient

Change-Id: I428cfd05f8eba34efd06fc6a085e1d7272ef525a

12 years agoMerge "ryu/nova: catch up d1888a3359345acffd8d0845c137eefd88072112"
Jenkins [Thu, 15 Mar 2012 23:39:32 +0000 (23:39 +0000)]
Merge "ryu/nova: catch up d1888a3359345acffd8d0845c137eefd88072112"

12 years agoMerge "Split out pip requires and aligned tox file."
Jenkins [Thu, 15 Mar 2012 17:13:30 +0000 (17:13 +0000)]
Merge "Split out pip requires and aligned tox file."

12 years agoMerge "Add root_helper to quantum agents."
Jenkins [Thu, 15 Mar 2012 14:47:34 +0000 (14:47 +0000)]
Merge "Add root_helper to quantum agents."

12 years agoMerge "bug 954538 Fix for the cisco unit tests"
Jenkins [Thu, 15 Mar 2012 13:51:32 +0000 (13:51 +0000)]
Merge "bug 954538 Fix for the cisco unit tests"

12 years agoSplit out pip requires and aligned tox file.
Monty Taylor [Wed, 29 Feb 2012 17:39:03 +0000 (09:39 -0800)]
Split out pip requires and aligned tox file.

Align tox.ini file with standards.
Align setup.py with openstack-common standards.

Change-Id: I333bbd66648c865a5c97ec2661359ab849274446

12 years agoryu/nova: catch up d1888a3359345acffd8d0845c137eefd88072112
Isaku Yamahata [Thu, 8 Mar 2012 07:20:09 +0000 (16:20 +0900)]
ryu/nova: catch up d1888a3359345acffd8d0845c137eefd88072112

FLAGS.add_option -> FLAGS.register_opt

> commit d1888a3359345acffd8d0845c137eefd88072112
> Author: Mark McLoughlin <markmc@redhat.com>
> Date:   Fri Feb 3 00:50:58 2012 +0000
>
>     Remove the last of the gflags shim layer
>
>     Make FLAGS a ConfigOpts instance and fix up all the places where we
>     expected FlagValues behaviour.
>
>     Change-Id: I8f96f42e0d8d30ba6b362d29861e717cf0fa9e89

and removed work around for circular import as the nova change set of
1265104b873d4cd791cecc62134ef874b4656003 fixes the circular import issue.

Change-Id: I4897dc848efa7fff6c73399a72d876fb503121e7

12 years agoAdd root_helper to quantum agents.
Bob Kukura [Tue, 13 Mar 2012 21:23:06 +0000 (17:23 -0400)]
Add root_helper to quantum agents.

When running commands that require root privileges, the linuxbridge,
openvswitch, and ryu agent now prepend the commands with the value of
the root_helper config variable. This is set to "sudo" in the plugins'
.ini files, allowing the agent to run as a non-root user with
appropriate sudo privilidges.

If root_helper is changed to "sudo quantum-rootwrap",
then the command being run will be filtered against lists of each
agent's valid commands in quantum/rootwrap. See
http://wiki.openstack.org/Packager/Rootwrap for details.

Fixes bug 948467.

Change-Id: I549515068a4ce8ae480905ec5eaab6257445d0c3
Signed-off-by: Bob Kukura <rkukura@redhat.com>
12 years agoFix missing files in sdist package [bug 954906]
Brad Hall [Wed, 14 Mar 2012 17:14:27 +0000 (10:14 -0700)]
Fix missing files in sdist package [bug 954906]

Change-Id: I4736d112b004c4356731de8a37d97fc6536793db

12 years agoMerge "check connection in Listener. refer to Bug #943031"
Jenkins [Wed, 14 Mar 2012 16:51:39 +0000 (16:51 +0000)]
Merge "check connection in Listener. refer to Bug #943031"

12 years agoMerge "Fix for bug 921743 Response codes for create ops in API v1.0 not compliant...
Jenkins [Wed, 14 Mar 2012 16:47:57 +0000 (16:47 +0000)]
Merge "Fix for bug 921743 Response codes for create ops in API v1.0 not compliant with spec"

12 years agoMerge "Downgraded required version of WebOb to 1.0.8."
Jenkins [Tue, 13 Mar 2012 18:59:45 +0000 (18:59 +0000)]
Merge "Downgraded required version of WebOb to 1.0.8."

12 years agoFix for bug 921743
Salvatore Orlando [Tue, 13 Mar 2012 16:58:19 +0000 (16:58 +0000)]
Fix for bug 921743
Response codes for create ops in API v1.0 not compliant with spec

Change-Id: I7723e46b05ffd7b29940327b9c7362f843e01817

12 years agobug 954538
Shweta P [Mon, 12 Mar 2012 23:13:31 +0000 (19:13 -0400)]
bug 954538
Fix for the cisco unit tests

Change-Id: I81e95e91245ba5215f7d8b94ac7aa5ebdd58d976

12 years agoMerge "fixed incorrect duplicate title"
Jenkins [Tue, 13 Mar 2012 00:43:49 +0000 (00:43 +0000)]
Merge "fixed incorrect duplicate title"

12 years agoMerge "add git commit date / sha1 to sphinx html docs"
Jenkins [Tue, 13 Mar 2012 00:40:44 +0000 (00:40 +0000)]
Merge "add git commit date / sha1 to sphinx html docs"

12 years agoMerge "Fixed incorrect title for example 3.10"
Jenkins [Tue, 13 Mar 2012 00:37:40 +0000 (00:37 +0000)]
Merge "Fixed incorrect title for example 3.10"

12 years agoMerge "Bug #949261 Removing nova drivers for Linux Bridge Plugin"
Jenkins [Mon, 12 Mar 2012 19:26:26 +0000 (19:26 +0000)]
Merge "Bug #949261 Removing nova drivers for Linux Bridge Plugin"

12 years agocheck connection in Listener. refer to Bug #943031
Peng Yong [Sun, 11 Mar 2012 16:06:53 +0000 (00:06 +0800)]
check connection in Listener. refer to Bug #943031

Change-Id: I5a0c975ab7998627a213ac4c69c037e9e2d95bfa

12 years agofixed incorrect duplicate title
Mark McClain [Fri, 9 Mar 2012 19:50:19 +0000 (14:50 -0500)]
fixed incorrect duplicate title

Fixes bug 951089

Changed the JSON example title to label the port JSON API examples properly.

Change-Id: I0bec330256f1dd3de43bc3202cedada2f9d40c01

12 years agoFixed incorrect title for example 3.10
Mark McClain [Fri, 9 Mar 2012 05:11:02 +0000 (00:11 -0500)]
Fixed incorrect title for example 3.10

Fixes bug 950535

Changed title for Example 3.10 to correctly reflect JSON

Change-Id: I0f7fae73efa80b617da0a895b80a95f60cb12c42

12 years agoDowngraded required version of WebOb to 1.0.8.
Maru Newby [Thu, 8 Mar 2012 22:52:35 +0000 (14:52 -0800)]
Downgraded required version of WebOb to 1.0.8.

 * Maintaining version parity with other OpenStack projects is
   essential to packaging efforts and shared installation (devstack).
 * fixes bug 950374

Change-Id: I9b16f29a3641df7063ec80bc86b03b4857776b42

12 years agoBug #949261 Removing nova drivers for Linux Bridge Plugin
Sumit Naiksatam [Wed, 7 Mar 2012 18:25:18 +0000 (10:25 -0800)]
Bug #949261 Removing nova drivers for Linux Bridge Plugin

These have been added to nova, so they need not be in the Quantum
code base any more.

Change-Id: Ibbd88792bfb0f58b2d9d347298964bf0b77baa95

12 years agoRemove outdated content from OVS plugin README, point to website instead.
Dan Wendlandt [Tue, 6 Mar 2012 21:17:19 +0000 (13:17 -0800)]
Remove outdated content from OVS plugin README, point to website instead.

bug 943810

Change-Id: I12c801a83789a2c3f3b0adac4b44f2febf32c523

12 years agoMerge "remove pep8 and strict lxml version from setup.py"
Jenkins [Mon, 5 Mar 2012 16:43:13 +0000 (16:43 +0000)]
Merge "remove pep8 and strict lxml version from setup.py"

12 years agoadd git commit date / sha1 to sphinx html docs
Jesse Andrews [Sat, 3 Mar 2012 00:09:16 +0000 (16:09 -0800)]
add git commit date / sha1 to sphinx html docs

Change-Id: Ie286200e3f569d6d5b0debf66baf24229b0b86ab

12 years agomore files missing in sdist tarball
Dan Wendlandt [Thu, 1 Mar 2012 03:59:56 +0000 (19:59 -0800)]
more files missing in sdist tarball

bug 943782

Change-Id: I08df8de1280071e5a528af927d5fc1d30868b140

12 years agomake sure pip-requires is included in setup.py sdist
Dan Wendlandt [Thu, 1 Mar 2012 01:03:08 +0000 (17:03 -0800)]
make sure pip-requires is included in setup.py sdist

bug 943711

Change-Id: I21a9d047e9fe00d2fa4a47165dd4728f862fdb9f

12 years agoIntroducing the tenant owenrship checks in the Cisco plugin, changes are
Sumit Naiksatam [Wed, 29 Feb 2012 06:30:17 +0000 (22:30 -0800)]
Introducing the tenant owenrship checks in the Cisco plugin, changes are
almost identical to those in Bug#942713

Change-Id: Ia320116e73db72090d925796bb2c832f31f878de

12 years agoFix some plugins that don't check that nets + ports are owned by tenant
Dan Wendlandt [Tue, 28 Feb 2012 20:34:49 +0000 (12:34 -0800)]
Fix some plugins that don't check that nets + ports are owned by tenant

bug 942713. This bug confuses the validate_networks() method of
QuantumManager in Nova, causing it to believe that it is valid for a
tenant to plug into a particular network when in fact that network is not
owned by the tenant, nor the "provider".

The patch also adds unit tests to confirm correct plugin behavior.

This patch fixes the issue for the Sample Plugin, the OVS plugin,
the Linux Bridge plugin, and the Ryu plugin, all of which has the
same DB model.  Validated the fix with the unit tests.

I couldn't run the unit tests for the NVP plugin standalone, but by
inspection, the code seems to handle this case.  I wasn't able to run
the Cisco plugin unit tests, and that code uses its own DB model, so I
am uncertain whether this issue exists in that plugin.

Change-Id: I8c4a5f3eb151b91a1076821dc1916842510dfb90

12 years agoMerge "bug 934459: pip no longer supports -E"
Jenkins [Tue, 28 Feb 2012 05:44:34 +0000 (05:44 +0000)]
Merge "bug 934459: pip no longer supports -E"

12 years agoremove pep8 and strict lxml version from setup.py
Ionuț Arțăriși [Thu, 16 Feb 2012 12:11:04 +0000 (13:11 +0100)]
remove pep8 and strict lxml version from setup.py

Change-Id: I671f3e924641cdfdfb5d20d0b0e3c77e1dc714e2

12 years agoplugin: introduce ryu plugin
Isaku Yamahata [Sat, 19 Nov 2011 09:17:03 +0000 (18:17 +0900)]
plugin: introduce ryu plugin

blueprint ovs-driver-extention
This patch implements the blueprint ovs-driver-extention
https://blueprints.launchpad.net/quantum/+spec/ovs-driver-extension

This patch factors out ovs common logic from ovs plugin into ovscommon
and adds Ryu NOS plugin.
This patch enhances ovs plugin for generic OVS controller support and

This patch is to add ofp controller support to OVS.
Store ofp controller address in ovs quantum data base.
- nova firewall_driver
- nova linuxnet_interface_driver

There may be ports unmanaged by nova/quantum. Those ports are used
to connect vm to outside of physical machine. They needs special care.

---
Changes 12 -> 13:
- rebased to 543e150d6dc9144ebcc588b7d2bd66374a107730
  changed files are only MANIFEST.in, setup.py, tools/pip-requres

Changes 11 -> 12:
- ryu agent
  eliminated from quantum.common import exceptions as exc
- ryu.db.api
  eliminated ofp_has_servers
- ryu.nova
  eliminated from quantum.plugins.ryu.nova import ovs_utils
  and eliminate ovs_utils

Chnages 10 -> 11:
- rebased to a945d1a30478c644d307c77a8a85f3a08e5a834e
- more Maru's review
- setup.py: fix setup() argument
  This isn't directly related to ryu plugin though
- improve fake ini file when unit test
  remove fake ini file after unit tests.
  use StringIO when no file is required.
- LOG: don't use %

Chnages 8 -> 9 -> 10:
- minor fixes: forgot to commit some hunks

Chnages 7 -> 8:
- rebased to d6bf2b76162ba806b2ad1f636f6273e47e03a117
- catch up d6bf2b76162ba806b2ad1f636f6273e47e03a117 change
  introduced bin/quantum_ryu_agent
- addressed Maru's review
  - avoid custom patching, use mock for test
    and added mox and mock to pip-requires
  - more pep8
  - avoid \ for line continuation
  - avoid single char variables
  - db.api: first() -> one()
  - utilize implicit conversion
    var is not None -> var
  - and more...

Changes 6 -> 7:
- update comment in ryu/run_tests.py
- make unit tests pass without ryu installed
  i.e.
  PLUGIN_DIR=quantum/plugins/ryu/ ./run_tests.sh
  works now

Chages 5 -> 6:
- remove comment

Change 4 -> 5:
- eliminate relative imports
- copyright
- doc string
- naming (s/CONF_FILE/conf_file/g)
- add " check to ryu/nova/ovs_utils
- ryu/nova/linux_net: comment
- ryu agent: eliminated unused methods
- updated ryu/README: add http://www.osrg.net/ryu/using_with_openstack.html
- added unit tests

Changes 3 -> 4:
- reflected Dan's review
- on-OVS in ryu.ini
- update @author
- some naming

Changes 2 -> 3:
- rebased to 04d144ae0b2ad5618847d1784cea48a08d53a46a
- abandoned to share code and duplicated codes from openvswitch plugin
  for ovs plugin stability.
- dropped setup_ryu.sh and added README
- update nova driver to catch up upstream change (gflags -> cfg)

Changes 1 -> 2:
- unbreak openvswtich unit test
- MANIFEST.in

Changes 3 -> new 1:
- rebased to 1eb3c693b5f6f3f301047100c36c7915434f8be7
- factor out common loginc from openvswitch plugin into ovscommon
- Introduced a new independent ryu plugin
- try new review due to the previous effort was marked abandoned.
  > https://review.openstack.org/#change,3055
  > Change-Id: I17801a7a74d4087838a8a26c1b1f97f28c2dcef3

Changes:
- rebased to 9c5c2caef13fa58234987527ab6caff829a37050
- some clean ups

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Change-Id: Ia9fe87525cebccc87b7c18a533f48607272cd97f

12 years agobug 934459: pip no longer supports -E
Dan Wendlandt [Sat, 25 Feb 2012 18:24:34 +0000 (10:24 -0800)]
bug 934459: pip no longer supports -E

Change-Id: I2acdef113d147b7130053088d4bcf8515f61b815

12 years agoMerge "Return appropriate error for invalid-port state in create port API."
Jenkins [Sat, 25 Feb 2012 18:16:09 +0000 (18:16 +0000)]
Merge "Return appropriate error for invalid-port state in create port API."

12 years agoMerge "Initial commit: nvp plugin"
Jenkins [Sat, 25 Feb 2012 17:43:44 +0000 (17:43 +0000)]
Merge "Initial commit: nvp plugin"

12 years agoFix bug 940732 stack.sh can't match sql_connection string.
Dave Lapsley [Sat, 25 Feb 2012 01:44:46 +0000 (20:44 -0500)]
Fix bug 940732 stack.sh can't match sql_connection string.

stack.sh can't match sql_connection string in default
ovs_quantum_plugin.ini. A space is missing between sql_connection
and "=" character.

Change-Id: I001e281145c3b6ba23a84e27e3f0e9315c879d96

12 years agoReturn appropriate error for invalid-port state in create port API.
Madhav Puri [Fri, 24 Feb 2012 06:44:07 +0000 (22:44 -0800)]
Return appropriate error for invalid-port state in create port API.

Fixes ovs-plugin to return appropriate error code when create port API is passed a port state value other than ACTIVE or DOWN. Fixes bug 919265.

Also added unit-test to test the behavior and verified it using ovs-plugin with devstack.

Change-Id: Ibd4e7bfdf4483c7ad1ef4ca70a336cb164493ae1

12 years agoblueprint quantum-ovs-tunnel-agent
Dave Lapsley [Tue, 21 Feb 2012 07:41:14 +0000 (02:41 -0500)]
blueprint quantum-ovs-tunnel-agent

Enhance existing Quantum OVS Plugin with a tunneling agent that
enables Hypervisors to be connected via GRE tunnels. The new agent
can be enabled/disabled via configuration file and provides backwards
compatibility with existing non-tunneling OVS Agent.

Change-Id: Id3b79430726b162fcb84f99df152d88a5766328f

12 years agoInitial commit: nvp plugin
Brad Hall [Fri, 17 Feb 2012 18:23:04 +0000 (10:23 -0800)]
Initial commit: nvp plugin

blueprint: quantum-nvp-plugin

Change-Id: I07c5d7b305928c341ef1b35a0d9b3281abcb03ae

12 years agounittests: setup FLAGS.state_path properly: bug 938637
Isaku Yamahata [Wed, 22 Feb 2012 16:55:30 +0000 (01:55 +0900)]
unittests: setup FLAGS.state_path properly: bug 938637

This patch fixes bug 938637
Quantum unittests doesn't pass with plugin (openvswitch, linuxbridge) in venv
as follows.
This is because config file under <quantum src>/etc/ can't be find due to
FLAGS.state_path points to <python-quantumclient src> which can be different
from <quantum src>.
Set FLAGS.state_path to <quantum src> when quantum unit tests.

 $ PLUGIN_DIR=quantum/plugins/openvswitch ./run_tests.sh -V
<snip>
ActionExtensionTest
    test_extended_action_for_adding_extra_data (quantum.tests.unit.test_extensions.ActionExtensionTest)ERROR
<snip>
======================================================================
ERROR: test_extended_action_for_adding_extra_data (quantum.tests.unit.test_extensions.ActionExtensionTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/quantum/tests/unit/test_extensions.py", line 212, in setUp
    self.extension_app = setup_extensions_test_app()
  File "/quantum-src/quantum/tests/unit/test_extensions.py", line 474, in setup_extensions_test_app
    return TestApp(setup_extensions_middleware(extension_manager))
  File "/quantum-src/quantum/tests/unit/test_extensions.py", line 469, in setup_extensions_middleware
    conf, app = config.load_paste_app('extensions_test_app', options, None)
  File "/quantum-src/.venv/src/python-quantumclient/quantum/common/config.py", line 316, in load_paste_app
    conf_file, conf = load_paste_config(app_name, options, args)
  File "/quantum-src/.venv/src/python-quantumclient/quantum/common/config.py", line 286, in load_paste_config
    "Cannot load application %s" % app_name)
RuntimeError: Unable to locate any configuration file. Cannot load application extensions_test_app
-------------------- >> begin captured logging << --------------------
quantum.extensions.extensions: INFO: Initializing extension manager.
quantum.extensions.extensions: INFO: Loading extension file: foxinsocks.py
quantum.extensions.extensions: DEBUG: Ext name: Fox In Socks
quantum.extensions.extensions: DEBUG: Ext alias: FOXNSOX
quantum.extensions.extensions: DEBUG: Ext description: The Fox In Socks Extension
quantum.extensions.extensions: DEBUG: Ext namespace: http://www.fox.in.socks/api/ext/pie/v1.0
quantum.extensions.extensions: DEBUG: Ext updated: 2011-01-22T13:25:27-06:00
quantum.extensions.extensions: WARNING: Loaded extension: FOXNSOX
quantum.extensions.extensions: INFO: Loading extension file: __init__.py
quantum.extensions.extensions: INFO: Loading extension file: foxinsocks.pyc
quantum.extensions.extensions: INFO: Loading extension file: __init__.pyc
--------------------- >> end captured logging << ---------------------

Change-Id: I3b8e1414b22b1a526468488fe885ac39f2e6c420

12 years agoCleanup the source distribution.
Bob Kukura [Fri, 17 Feb 2012 22:00:52 +0000 (17:00 -0500)]
Cleanup the source distribution.

Missing text files such as LICENSE and various READMEs are now
included in the tarball source distribution. The Makefile and shell
script for installing the openvswitch agent on xen are also now
included. The openvswitch and linuxbridge agents are included, and
executable wrapper scripts for the agents are provided. The cisco and
linuxbridge nova drivers are now setup to be run from the quantum
namespace rather than copied to nova. Finally, the setup_*.py scripts
have been removed from the project. Fixes bug 925074.

Test by running "python setup.py sdist" and examining the generated
tarball.

Change-Id: I33d336a5eb13678e6d527b575958393b337b6f3d
Signed-off-by: Bob Kukura <rkukura@redhat.com>
12 years agoMerge "Fix ovs config file location"
Jenkins [Thu, 16 Feb 2012 18:59:14 +0000 (18:59 +0000)]
Merge "Fix ovs config file location"

12 years agoMerge "Bug 925372: remove deprecated webob attributes (and also specify stable webob...
Jenkins [Thu, 16 Feb 2012 18:57:11 +0000 (18:57 +0000)]
Merge "Bug 925372: remove deprecated webob attributes (and also specify stable webob version in pip-requires)"

12 years agoFix ovs config file location
Ghe Rivero [Wed, 15 Feb 2012 09:33:34 +0000 (10:33 +0100)]
Fix ovs config file location

Change-Id: I957079434e14222e48fffb00e6bc3d58af8e40c8

12 years agoblueprint quantum-linux-bridge-plugin
Sumit Naiksatam [Sun, 22 Jan 2012 09:35:45 +0000 (01:35 -0800)]
blueprint quantum-linux-bridge-plugin

Squashed commit of the following:

commit 6c4995736a56349923d34353031eb301780fc6d2
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date:   Sat Jan 21 22:31:09 2012 -0800

    Some more explanation in the README.

    Changing defaults in the conf file.

commit 924b118468d7bd21737e9e2cf468ff83d0a20764
Author: Shweta <shpadubi@cisco.com>
Date:   Sat Jan 21 20:58:39 2012 -0500

    Adding Unit Tests for LinuxBridge Agent

commit 12115650257483172c5e2bc889634dbdf3596d27
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date:   Sat Jan 21 05:21:24 2012 -0800

    Adding sqlite requirement

    Changing default mysql port number

    Fixing log statement

commit 0ad1400e5dfc445b94e9024d92321eb3cd0588a5
Merge: 1b7ba8f 9c5c2ca
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date:   Sat Jan 21 05:12:44 2012 -0800

    Merge remote branch 'upstream/master' into snaiksat/linux-bridge-plugin

commit 1b7ba8f7e7b6657734b669194ddfdcfcbfc833be
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date:   Sat Jan 21 04:04:50 2012 -0800

    Fixes to get the tests to run correctly.

    Also incorporated changes to be able to run both sqlite and mysql DBs.

commit 4cead17576c293319dfdfd363dd18e81ba196b3b
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date:   Fri Jan 20 15:32:35 2012 -0800

    Fixed inccorect calls to the DB

commit c4f325729fbd06ee3f5d3520da4d23b2cd8c353b
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date:   Fri Jan 20 12:18:18 2012 -0800

    Removing the specialized db modules (which used InnoDB engine) and
    instead using the Quantum DB now.
    Incorporated changes to setup so that the Linux Bridge plugin can be
    installed.
    Other changes to README and tests.

commit b9498939d723e353808cface87f4453e33e94b41
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date:   Mon Jan 16 20:00:14 2012 -0800

    Adding unit tests

commit a0ab990fdcbf67a950d08c6b5b6d20ceb850619a
Merge: 60e38cc f268b5e
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date:   Mon Jan 16 18:02:55 2012 -0800

    Merge remote branch 'upstream/master' into snaiksat/linux-bridge-plugin

commit 60e38cc44886b5c8c9e47d89d8912d1dee23fbd1
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date:   Mon Jan 16 13:44:37 2012 -0800

    This contains a fix for the earlier reported issue with the DHCP
    failing.

    The gateway IP address is now applied both to the bridge, and the
    gateway interface.

commit ffea86a3465b8a5ed93b13f818e0afaefa6787ee
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date:   Sun Jan 15 20:00:38 2012 -0800

    Fixing an issue in the agent, sometimes the bridges for deleted networks
    were not getting cleaned up

commit 87f76fc34f1c70cd82576b8698d704853c892422
Merge: c8b097a 60d171e
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date:   Sun Jan 15 19:40:33 2012 -0800

    Merge remote branch 'upstream/master' into snaiksat/linux-bridge-plugin

commit c8b097abc2060b2eae01d84f9fed2c89851d93fd
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date:   Sun Jan 15 19:37:08 2012 -0800

    Simplified the logic for creating the bridge on the nova network host.

commit 499dbacd4c5352c5320f3b6e5e8cd7f3629dbcc8
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date:   Fri Jan 13 16:07:53 2012 -0800

    Fix for the DHCP issue, now applying Gateway IP to the bridge

    Also MAC address from original tap device are applied to bridge
    and vlan subinterface

commit 6b4a2aea59702e2c12eeacc86101df9f6770d5ec
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date:   Sat Jan 7 14:29:00 2012 -0800

    Optimizations for processing in the loop

commit 01aa47d3572439b193077432c63bf2b85c629edb
Merge: 184f5dd 05df087
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date:   Sun Jan 1 19:04:17 2012 -0800

    Changes to incorporate Operational Status
    Merge remote branch 'origin' into snaiksat/linux-bridge-plugin

    Conflicts:
     quantum/db/api.py

commit 05df0870191fac0353fe12a33efff68ef7ed0784
Merge: 31d586b 5b23b5e
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date:   Fri Dec 30 12:30:05 2011 -0800

    Merge remote branch 'upstream/master'

commit 184f5dd8b73bc51025509792c15203ee73cd015e
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date:   Mon Dec 12 02:09:12 2011 -0800

    Initial checkin for Linux Bridge L2 plugin.

Change-Id: I5b27538be6a768a6f7eb77409197f7d8b4bbc628

12 years agoRemove quantum CLI console script.
Bob Kukura [Fri, 3 Feb 2012 21:20:28 +0000 (16:20 -0500)]
Remove quantum CLI console script.

The quantum CLI console script is now installed by the
python-quantumclient project, so remove it from the quantum project's
setup.py. Fixes bug 925596.

Test by running "python setup.py install --root <somedir>" and
checking that <somedir>/usr/bin/quantum is not created.

Change-Id: Icd7eff79c8d30511693942a859334829cbf0d9af
Signed-off-by: Bob Kukura <rkukura@redhat.com>
12 years agoBug 925372: remove deprecated webob attributes
Salvatore Orlando [Thu, 2 Feb 2012 10:54:33 +0000 (10:54 +0000)]
Bug 925372: remove deprecated webob attributes
(and also specify stable webob version in pip-requires)

Change-Id: Id8dd53368f88042b71fc73a5f94803e635c4140b

12 years agobug 923510: avoid querying all ports for non-detail GET Network call.
Dan Wendlandt [Sun, 29 Jan 2012 22:11:03 +0000 (14:11 -0800)]
bug 923510: avoid querying all ports for non-detail GET Network call.

Change-Id: I9b4a20e5f6eb22dc234dfa675e7ca4f52893707d

12 years agoMerge "Make tox config work."
Jenkins [Wed, 25 Jan 2012 09:39:15 +0000 (09:39 +0000)]
Merge "Make tox config work."

12 years agoMerge "bp/api-filters This changeset implements filters for core Quantum API and...
Jenkins [Wed, 25 Jan 2012 09:30:13 +0000 (09:30 +0000)]
Merge "bp/api-filters This changeset implements filters for core Quantum API and provides unit tests"

12 years agoMake tox config work.
Monty Taylor [Wed, 25 Jan 2012 09:23:12 +0000 (01:23 -0800)]
Make tox config work.

Change-Id: Ic81c7bb0fa2fe5c73200a9195630a0d5bb999e7d

12 years agoPin versions to standard versions.
Monty Taylor [Wed, 25 Jan 2012 09:20:20 +0000 (01:20 -0800)]
Pin versions to standard versions.

Change-Id: Id6f9d2c01caee3f4c780366d19889b7311fba8d6

12 years agobp/api-filters
Salvatore Orlando [Wed, 11 Jan 2012 17:26:47 +0000 (17:26 +0000)]
bp/api-filters
This changeset implements filters for core Quantum API and provides unit tests

Change-Id: I8247b3587c2cc8e53785781a45d1e457980261d2

12 years agoMerge "Split out quantum.client and quantum.common."
Jenkins [Wed, 25 Jan 2012 04:56:48 +0000 (04:56 +0000)]
Merge "Split out quantum.client and quantum.common."

12 years agoMerge "bp/api-error-codes Restructured API error codes for Quantum API v1.1 This...
Jenkins [Wed, 25 Jan 2012 02:57:30 +0000 (02:57 +0000)]
Merge "bp/api-error-codes Restructured API error codes for Quantum API v1.1 This changeset provides the following changes: - Only standard HTTP errors for Quantum API v1.1 - Customized fault response body formatting according to API version - Changes to unit tests to deal with version specific status codes"

12 years agoSplit out quantum.client and quantum.common.
Monty Taylor [Thu, 19 Jan 2012 00:45:25 +0000 (11:45 +1100)]
Split out quantum.client and quantum.common.

Change-Id: I1241bcd3305b6859c0cd2bb8c35b523e27aa3b18

12 years agoQuantum was missing depend on lxml.
Monty Taylor [Wed, 25 Jan 2012 01:41:51 +0000 (17:41 -0800)]
Quantum was missing depend on lxml.

Change-Id: Ie8d582018f2c5f7972f6d9ab8fcf0f79d00f6a99

12 years agobp/api-error-codes
Salvatore Orlando [Tue, 17 Jan 2012 01:23:00 +0000 (01:23 +0000)]
bp/api-error-codes
Restructured API error codes for Quantum API v1.1
This changeset provides the following changes:
- Only standard HTTP errors for Quantum API v1.1
- Customized fault response body formatting according to API version
- Changes to unit tests to deal with version specific status codes

NOTE: Client side changes are not in this branch.
They should be implemented within bp/quantum-client-1.1.
NOTE-2: Fixing references to QuantumHTTPErrors in extensions framework

Change-Id: I56f50b5c59d73fd6f02905106f0c2a3c8341a741

12 years agoblueprint ovs-portstats
Brad Hall [Wed, 21 Dec 2011 22:47:28 +0000 (14:47 -0800)]
blueprint ovs-portstats

This adds an extension to support fetching port statistics from any plugin
that supports it.

Change-Id: Id14ee3c9604878b8a06d668126452cd5a5071b10

12 years agoAdd support for dealing with 501 errors (notimplemented)
Brad Hall [Tue, 24 Jan 2012 19:12:55 +0000 (11:12 -0800)]
Add support for dealing with 501 errors (notimplemented)

This allows us to return NotImplemented() from an extension if the plugin
doesn't support a given function.

Change-Id: I73c6dec959aea7b2bde1378222b62e6fc82a5d43

12 years agoMerge "Improved VlanMap."
Jenkins [Tue, 24 Jan 2012 09:40:07 +0000 (09:40 +0000)]
Merge "Improved VlanMap."

12 years agoMerge "Getting ready for the client split."
Jenkins [Tue, 24 Jan 2012 00:13:34 +0000 (00:13 +0000)]
Merge "Getting ready for the client split."

12 years agoMerge "moving batch config out of quantum-server repo."
Jenkins [Mon, 23 Jan 2012 17:41:36 +0000 (17:41 +0000)]
Merge "moving batch config out of quantum-server repo."

12 years agoImproved VlanMap.
Ghe Rivero [Tue, 13 Dec 2011 12:14:22 +0000 (13:14 +0100)]
Improved VlanMap.

Simplified logic and less time spent creating  vlans.

Change-Id: I90fda09faa1869b38993aa0aeed64d813d29afa9