]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/log
puppet-modules/puppetlabs-firewall.git
9 years agoMerge pull request #591 from jonnytpuppet/1.7.x_rel_prep_ci_fixes
David Schmitt [Fri, 4 Dec 2015 15:50:04 +0000 (15:50 +0000)]
Merge pull request #591 from jonnytpuppet/1.7.x_rel_prep_ci_fixes

1.7.x rel prep ci fixes

9 years agoUpdated logic to debian manifest file
Jonathan Tripathy [Thu, 3 Dec 2015 15:42:48 +0000 (15:42 +0000)]
Updated logic to debian manifest file

9 years ago(MAINT) - Commented out CLUSTERIP tests as there are suspicions that the
Jonathan Tripathy [Thu, 26 Nov 2015 16:48:18 +0000 (16:48 +0000)]
(MAINT) - Commented out CLUSTERIP tests as there are suspicions that the
ipt module is causing system reboots.

9 years agoUnit test fixes
Jonathan Tripathy [Thu, 26 Nov 2015 15:21:31 +0000 (15:21 +0000)]
Unit test fixes

9 years agoMore file renames
Jonathan Tripathy [Thu, 26 Nov 2015 14:33:23 +0000 (14:33 +0000)]
More file renames

9 years agoRename internal custom nodeset files
Jonathan Tripathy [Thu, 26 Nov 2015 14:14:15 +0000 (14:14 +0000)]
Rename internal custom nodeset files

9 years agoFurther nodeset changes from internal CI
Jonathan Tripathy [Wed, 25 Nov 2015 17:41:16 +0000 (17:41 +0000)]
Further nodeset changes from internal CI

9 years agoAdded nodeset files for internal Puppet CI.
Jonathan Tripathy [Tue, 24 Nov 2015 16:54:06 +0000 (16:54 +0000)]
Added nodeset files for internal Puppet CI.

9 years agoMerge pull request #571 from tphoney/release_1.7.1 1.7.1
David Schmitt [Thu, 20 Aug 2015 11:58:56 +0000 (12:58 +0100)]
Merge pull request #571 from tphoney/release_1.7.1

release prep

9 years agorelease prep
tphoney [Thu, 20 Aug 2015 10:08:08 +0000 (11:08 +0100)]
release prep

9 years agoMerge pull request #570 from hunner/deprecate_port
Bryan Jen [Wed, 19 Aug 2015 18:05:18 +0000 (11:05 -0700)]
Merge pull request #570 from hunner/deprecate_port

Deprecate port parameter

9 years agoDeprecate port parameter
Hunter Haugen [Mon, 17 Aug 2015 22:22:04 +0000 (15:22 -0700)]
Deprecate port parameter

I couldn't find any valid use case for port, and if any valid case did
exist then sport+dport could be used.

9 years agoMerge pull request #569 from grigarr/patch-1
Daniel Dreier [Wed, 12 Aug 2015 21:03:30 +0000 (14:03 -0700)]
Merge pull request #569 from grigarr/patch-1

Always use dport

9 years agoAlways use dport
Rudy Grigar [Wed, 12 Aug 2015 18:25:16 +0000 (11:25 -0700)]
Always use dport

Using 'port' allows you to spoof a source port and offers a backdoor by sending a different destination port. sport 80 -> dport 11211 would be valid for 'port => 80' and give access to a memcache instance (port 11211) running on the server.

9 years agoMerge pull request #567 from puppetlabs/1.7.x
TP Honey [Tue, 28 Jul 2015 10:44:15 +0000 (11:44 +0100)]
Merge pull request #567 from puppetlabs/1.7.x

Release 1.7.0 Prep

9 years agoRelease 1.7.0 Prep 1.7.0
Jonathan Tripathy [Mon, 27 Jul 2015 14:55:54 +0000 (15:55 +0100)]
Release 1.7.0 Prep

9 years agoMerge pull request #566 from jonnytpuppet/more_test_fixes
TP Honey [Fri, 24 Jul 2015 10:40:49 +0000 (11:40 +0100)]
Merge pull request #566 from jonnytpuppet/more_test_fixes

More test logic fixes for SLES 10

9 years agoMore test logic fixes for SLES 10
Jonathan Tripathy [Fri, 24 Jul 2015 10:28:35 +0000 (11:28 +0100)]
More test logic fixes for SLES 10

9 years agoMerge pull request #565 from jonnytpuppet/more_test_fixes
Bryan Jen [Fri, 24 Jul 2015 00:08:56 +0000 (17:08 -0700)]
Merge pull request #565 from jonnytpuppet/more_test_fixes

More test exclusion logic fixes

9 years agoMore test exclusion logic fixes
Jonathan Tripathy [Fri, 24 Jul 2015 00:03:28 +0000 (01:03 +0100)]
More test exclusion logic fixes

9 years agoMerge pull request #564 from jonnytpuppet/more_test_fixes
David Schmitt [Thu, 23 Jul 2015 10:49:09 +0000 (11:49 +0100)]
Merge pull request #564 from jonnytpuppet/more_test_fixes

Further test exclusions for SLES 10

9 years agoFurther test exclusions for SLES 10
Jonathan Tripathy [Thu, 23 Jul 2015 10:37:27 +0000 (11:37 +0100)]
Further test exclusions for SLES 10

9 years agoMerge pull request #563 from jonnytpuppet/more_test_fixes
Hunter Haugen [Wed, 22 Jul 2015 20:38:41 +0000 (13:38 -0700)]
Merge pull request #563 from jonnytpuppet/more_test_fixes

Exclude SLES 10 from some tests

9 years agoExclude SLES 10 from some tests
Jonathan Tripathy [Wed, 22 Jul 2015 18:21:23 +0000 (19:21 +0100)]
Exclude SLES 10 from some tests

9 years agoMerge pull request #562 from jonnytpuppet/more_test_fixes
David Schmitt [Wed, 22 Jul 2015 14:45:06 +0000 (15:45 +0100)]
Merge pull request #562 from jonnytpuppet/more_test_fixes

Adding allow ssh rule to tests

9 years agoAdding allow ssh rule to tests
Jonathan Tripathy [Wed, 22 Jul 2015 14:00:46 +0000 (15:00 +0100)]
Adding allow ssh rule to tests

9 years agoMerge pull request #561 from jonnytpuppet/more_test_fixes
David Schmitt [Mon, 20 Jul 2015 16:11:40 +0000 (17:11 +0100)]
Merge pull request #561 from jonnytpuppet/more_test_fixes

Removed reject test in acceptance test

9 years agoRemoved reject test in acceptance test
Jonathan Tripathy [Mon, 20 Jul 2015 15:50:13 +0000 (16:50 +0100)]
Removed reject test in acceptance test

9 years agoMerge pull request #559 from BlendMarketing/master
JT (Jonny) [Mon, 20 Jul 2015 11:05:48 +0000 (12:05 +0100)]
Merge pull request #559 from BlendMarketing/master

Compatibility with Puppet 4 and Facter 3

9 years agoMerge pull request #560 from estonfer/add_dscp_markings
JT (Jonny) [Thu, 16 Jul 2015 11:33:14 +0000 (12:33 +0100)]
Merge pull request #560 from estonfer/add_dscp_markings

add set_dscp and set_dscp_class

9 years agoadd set_dscp and set_dscp_class
Eric Stonfer [Wed, 15 Jul 2015 17:16:06 +0000 (13:16 -0400)]
add set_dscp and set_dscp_class

9 years agoMerge branch 'master' of git://github.com/puppetlabs/puppetlabs-firewall
Jared Meyering [Tue, 14 Jul 2015 16:35:11 +0000 (11:35 -0500)]
Merge branch 'master' of git://github.com/puppetlabs/puppetlabs-firewall

9 years agofacter 4 compat
Jared Meyering [Tue, 14 Jul 2015 16:35:04 +0000 (11:35 -0500)]
facter 4 compat

9 years agoMerge pull request #555 from TJM/ticket/MODULES-2186-remove_fwrules_A
JT (Jonny) [Tue, 14 Jul 2015 13:03:45 +0000 (14:03 +0100)]
Merge pull request #555 from TJM/ticket/MODULES-2186-remove_fwrules_A

MODULES-2186 - iptables rules with -A in comment

9 years agoMerge pull request #554 from ghoneycutt/patch-1
JT (Jonny) [Tue, 14 Jul 2015 13:01:52 +0000 (14:01 +0100)]
Merge pull request #554 from ghoneycutt/patch-1

Style fixes in documentation's example code

9 years agoMerge pull request #558 from jonnytpuppet/test_fix
TP Honey [Fri, 3 Jul 2015 16:01:11 +0000 (17:01 +0100)]
Merge pull request #558 from jonnytpuppet/test_fix

Test fixes that may prevent hanging problems during beaker tests.

9 years agoTest fixes that may prevent hanging problems during beaker tests.
Jonathan Tripathy [Fri, 3 Jul 2015 15:26:21 +0000 (16:26 +0100)]
Test fixes that may prevent hanging problems during beaker tests.

9 years agoMerge pull request #557 from DavidS/modules-2155-update-docs
JT (Jonny) [Fri, 3 Jul 2015 10:34:51 +0000 (11:34 +0100)]
Merge pull request #557 from DavidS/modules-2155-update-docs

(MODULES-2155) Remove note about purge restrictions

9 years ago(MODULES-2155) Remove note about purge restrictions
David Schmitt [Fri, 3 Jul 2015 09:54:25 +0000 (10:54 +0100)]
(MODULES-2155) Remove note about purge restrictions

9 years agoMerge pull request #556 from jonnytpuppet/autorequire_service
David Schmitt [Thu, 2 Jul 2015 16:08:01 +0000 (17:08 +0100)]
Merge pull request #556 from jonnytpuppet/autorequire_service

Makes all the services autorequired by the firewall and firewallchain types.

9 years agoMakes all the services autorequired by the firewall and firewall chain types.
Jonathan Tripathy [Thu, 2 Jul 2015 15:41:03 +0000 (16:41 +0100)]
Makes all the services autorequired by the firewall and firewall chain types.

9 years agoMODULES-2186 - iptables rules with -A in comment
Tommy McNeely [Thu, 2 Jul 2015 15:16:46 +0000 (09:16 -0600)]
MODULES-2186 - iptables rules with -A in comment

9 years agoStyle fixes in documentation's example code
Garrett Honeycutt [Thu, 2 Jul 2015 02:20:00 +0000 (22:20 -0400)]
Style fixes in documentation's example code

9 years agoMerge pull request #553 from jonnytpuppet/test_fix
David Schmitt [Tue, 30 Jun 2015 13:57:56 +0000 (14:57 +0100)]
Merge pull request #553 from jonnytpuppet/test_fix

Only catch changes if not EL5 due to selinux warning issue.

9 years agoOnly catch changes if not EL5 due to selinux warning issue.
Jonathan Tripathy [Tue, 30 Jun 2015 13:43:41 +0000 (14:43 +0100)]
Only catch changes if not EL5 due to selinux warning issue.

9 years agoMerge pull request #551 from jonnytpuppet/physdev_idem_fix
David Schmitt [Thu, 25 Jun 2015 13:32:49 +0000 (14:32 +0100)]
Merge pull request #551 from jonnytpuppet/physdev_idem_fix

Fix for physdev idempotency on EL5

9 years agoFix for physdev idempotency on EL5
Jonathan Tripathy [Thu, 25 Jun 2015 13:14:18 +0000 (14:14 +0100)]
Fix for physdev idempotency on EL5

9 years agoMerge pull request #550 from hunner/undefault_seluser
Morgan Haskel [Wed, 24 Jun 2015 20:31:03 +0000 (13:31 -0700)]
Merge pull request #550 from hunner/undefault_seluser

Enforce the seluser on selinux systems

9 years agoEnforce the seluser on selinux systems
Hunter Haugen [Tue, 23 Jun 2015 23:18:00 +0000 (16:18 -0700)]
Enforce the seluser on selinux systems

iptables-save always sets unconfined_u

9 years agoMerge pull request #549 from puppetlabs/revert-548-disable_selinux
Bryan Jen [Fri, 19 Jun 2015 21:00:11 +0000 (14:00 -0700)]
Merge pull request #549 from puppetlabs/revert-548-disable_selinux

Revert "Don't enable selinux on redhat systems"

9 years agoRevert "Don't enable selinux on redhat systems"
Hunter Haugen [Fri, 19 Jun 2015 20:55:41 +0000 (13:55 -0700)]
Revert "Don't enable selinux on redhat systems"

9 years agoMerge pull request #548 from hunner/disable_selinux
Bryan Jen [Fri, 19 Jun 2015 17:27:45 +0000 (10:27 -0700)]
Merge pull request #548 from hunner/disable_selinux

Don't enable selinux on redhat systems

9 years agoDon't enable selinux on redhat systems
Hunter Haugen [Fri, 19 Jun 2015 17:24:49 +0000 (10:24 -0700)]
Don't enable selinux on redhat systems

9 years agoMerge pull request #547 from jonnytpuppet/fix_spec_helper
David Schmitt [Fri, 19 Jun 2015 13:58:53 +0000 (14:58 +0100)]
Merge pull request #547 from jonnytpuppet/fix_spec_helper

Removed Hiera config command in spec helper.

9 years agoRemoved Hiera config command in spec helper.
Jonathan Tripathy [Fri, 19 Jun 2015 13:56:37 +0000 (14:56 +0100)]
Removed Hiera config command in spec helper.

9 years agoMerge pull request #517 from karmix/tickets/master/MODULES-1976_unicode-rule-name...
JT (Jonny) [Fri, 19 Jun 2015 10:08:13 +0000 (11:08 +0100)]
Merge pull request #517 from karmix/tickets/master/MODULES-1976_unicode-rule-name-validation

(MODULES-1976) Revise rule name validation for ruby 1.9

9 years agoMerge pull request #513 from karmix/tickets/master/MODULES-1967_parse-escape-sequence...
JT (Jonny) [Thu, 18 Jun 2015 10:30:55 +0000 (11:30 +0100)]
Merge pull request #513 from karmix/tickets/master/MODULES-1967_parse-escape-sequences-from-iptables

(MODULES-1967) Parse escape sequences from iptables

9 years agoMerge pull request #539 from DavidS/remove-unused-code
JT (Jonny) [Thu, 18 Jun 2015 10:30:15 +0000 (11:30 +0100)]
Merge pull request #539 from DavidS/remove-unused-code

(maint) remove unused, wrong code

9 years agoMerge pull request #541 from fsdef/patch-1
JT (Jonny) [Thu, 18 Jun 2015 10:29:39 +0000 (11:29 +0100)]
Merge pull request #541 from fsdef/patch-1

(MODULES-2118) Fix severe installation hang on jessie.

9 years agoMerge pull request #546 from jonnytpuppet/clusterip
David Schmitt [Thu, 18 Jun 2015 10:09:24 +0000 (11:09 +0100)]
Merge pull request #546 from jonnytpuppet/clusterip

Excluding SLES from CLUSTERIP tests.

9 years agoExcluding SLES from CLUSTERIP tests.
Jonathan Tripathy [Thu, 18 Jun 2015 10:05:38 +0000 (11:05 +0100)]
Excluding SLES from CLUSTERIP tests.

9 years agoMerge pull request #545 from jonnytpuppet/clusterip
David Schmitt [Wed, 17 Jun 2015 16:56:25 +0000 (17:56 +0100)]
Merge pull request #545 from jonnytpuppet/clusterip

Comment out spec test for el7 due to unknown interface name

9 years agoComment out spec test for el7 due to unknown interface name
Jonathan Tripathy [Tue, 16 Jun 2015 13:03:13 +0000 (14:03 +0100)]
Comment out spec test for el7 due to unknown interface name

9 years agoMerge pull request #544 from jonnytpuppet/clusterip
Morgan Haskel [Wed, 17 Jun 2015 16:35:33 +0000 (09:35 -0700)]
Merge pull request #544 from jonnytpuppet/clusterip

Comment out spec test for el7 due to unknown interface name

9 years agoComment out spec test for el7 due to unknown interface name
Jonathan Tripathy [Tue, 16 Jun 2015 13:03:13 +0000 (14:03 +0100)]
Comment out spec test for el7 due to unknown interface name

9 years ago(maint) remove unused, wrong code
David Schmitt [Wed, 10 Jun 2015 12:03:59 +0000 (13:03 +0100)]
(maint) remove unused, wrong code

9 years agoMerge pull request #540 from hunner/add_helper
Bryan Jen [Mon, 15 Jun 2015 17:10:52 +0000 (10:10 -0700)]
Merge pull request #540 from hunner/add_helper

Add helper to install puppet/pe/puppet-agent

9 years agoMerge pull request #543 from jonnytpuppet/fix-addrtype-inversion
David Schmitt [Mon, 15 Jun 2015 14:32:11 +0000 (15:32 +0100)]
Merge pull request #543 from jonnytpuppet/fix-addrtype-inversion

Fix addrtype inversion

9 years ago(MODULES-1592) Allow src_type and dst_type prefixed with '! ' to pass validation
Jason Stangroome [Fri, 12 Dec 2014 10:06:34 +0000 (21:06 +1100)]
(MODULES-1592) Allow src_type and dst_type prefixed with '! ' to pass validation

9 years agoFix severe installation hang on jessie.
fsdef [Sun, 14 Jun 2015 16:05:30 +0000 (19:05 +0300)]
Fix severe installation hang on jessie.

On jessie iptables-persistent pops up debconf to ask if the current firewall setup should be saved which leads to puppet hanging and 99% of the time half configured firewall and ssh lockout.

This patch sets the value to false before the install so that debconf doesnt pop up - iptables rules shouldn't be saved automatically since they will be overridden by puppet'.

9 years agoMerge pull request #542 from jonnytpuppet/clusterip
David Schmitt [Mon, 15 Jun 2015 12:26:42 +0000 (13:26 +0100)]
Merge pull request #542 from jonnytpuppet/clusterip

Clusterip implementation

9 years agoClusterip implementation
Jonathan Tripathy [Mon, 15 Jun 2015 11:58:08 +0000 (12:58 +0100)]
Clusterip implementation

9 years agoAdd helper to install puppet/pe/puppet-agent
Hunter Haugen [Thu, 11 Jun 2015 22:29:26 +0000 (15:29 -0700)]
Add helper to install puppet/pe/puppet-agent

9 years ago(MODULES-1967) Parse escape sequences from iptables
Doug Knight [Thu, 23 Apr 2015 00:31:50 +0000 (16:31 -0800)]
(MODULES-1967) Parse escape sequences from iptables

9 years agoMerge pull request #538 from justinstoller/maint/master/set-puppet-version
David Schmitt [Tue, 9 Jun 2015 14:50:05 +0000 (15:50 +0100)]
Merge pull request #538 from justinstoller/maint/master/set-puppet-version

(maint) allow setting PUPPET_VERSION in acceptance

9 years ago(maint) allow setting PUPPET_VERSION in acceptance
Justin Stoller [Tue, 9 Jun 2015 04:55:16 +0000 (21:55 -0700)]
(maint) allow setting PUPPET_VERSION in acceptance

9 years agoMerge pull request #536 from jonnytpuppet/travis_update
David Schmitt [Mon, 8 Jun 2015 12:30:02 +0000 (13:30 +0100)]
Merge pull request #536 from jonnytpuppet/travis_update

Updated travisci file to fail on Puppet 4 failures

9 years agoUpdated travisci file to fail on Puppet 4 failures
Jonathan Tripathy [Thu, 4 Jun 2015 13:03:55 +0000 (14:03 +0100)]
Updated travisci file to fail on Puppet 4 failures

9 years agoMerge pull request #537 from tphoney/puppet4_unittest
JT (Jonny) [Fri, 5 Jun 2015 16:33:32 +0000 (17:33 +0100)]
Merge pull request #537 from tphoney/puppet4_unittest

add environmentpath

9 years agoadd environmentpath
tphoney [Fri, 5 Jun 2015 16:17:17 +0000 (17:17 +0100)]
add environmentpath

9 years agoMerge pull request #535 from ekohl/patch-1
JT (Jonny) [Wed, 3 Jun 2015 14:09:52 +0000 (15:09 +0100)]
Merge pull request #535 from ekohl/patch-1

Fix puppet lint errors in examples

9 years agoFix puppet lint errors in examples
Ewoud Kohl van Wijngaarden [Wed, 3 Jun 2015 10:40:59 +0000 (12:40 +0200)]
Fix puppet lint errors in examples

9 years agoAdd ability to unittest puppet 4
Hunter Haugen [Wed, 27 May 2015 15:11:43 +0000 (08:11 -0700)]
Add ability to unittest puppet 4

9 years agoMerge pull request #534 from puppetlabs/1.6.x
Bryan Jen [Thu, 21 May 2015 15:26:16 +0000 (08:26 -0700)]
Merge pull request #534 from puppetlabs/1.6.x

1.6.0 back to master

9 years agoMerge pull request #533 from jbondpdx/1.6.x 1.6.x 1.6.0
JT (Jonny) [Tue, 19 May 2015 18:12:32 +0000 (19:12 +0100)]
Merge pull request #533 from jbondpdx/1.6.x

DOCS: edits to firewall readme

9 years agoDOCS: edits to firewall readme
jbondpdx [Tue, 19 May 2015 18:10:11 +0000 (11:10 -0700)]
DOCS: edits to firewall readme

9 years ago1.6.0 Release Prep
Jonathan Tripathy [Tue, 12 May 2015 10:11:20 +0000 (11:11 +0100)]
1.6.0 Release Prep

10 years agoMerge pull request #532 from jonnytpuppet/jbb_issue_1766
TP Honey [Mon, 18 May 2015 13:05:22 +0000 (14:05 +0100)]
Merge pull request #532 from jonnytpuppet/jbb_issue_1766

Updated Readme for clamp_mss_to_pmtu

10 years agoUpdated readme for clamp_mss_to_pmtu
Jonathan Tripathy [Mon, 18 May 2015 13:01:05 +0000 (14:01 +0100)]
Updated readme for clamp_mss_to_pmtu

10 years agoMerge pull request #531 from jonnytpuppet/jbb_issue_1766
TP Honey [Mon, 18 May 2015 12:46:01 +0000 (13:46 +0100)]
Merge pull request #531 from jonnytpuppet/jbb_issue_1766

(MODULES-1766) Add support for clamp-mss-to-pmtu

10 years agoAdd support for clamp-mss-to-pmtu
Joshua B. Bussdieker [Thu, 14 May 2015 23:29:28 +0000 (16:29 -0700)]
Add support for clamp-mss-to-pmtu

10 years agoMerge pull request #529 from jonnytpuppet/test_fix
Morgan Haskel [Thu, 7 May 2015 18:23:38 +0000 (11:23 -0700)]
Merge pull request #529 from jonnytpuppet/test_fix

Test fixes

10 years agoTest fixes
Jonathan Tripathy [Thu, 7 May 2015 18:17:57 +0000 (19:17 +0100)]
Test fixes

10 years agoMerge pull request #527 from jonnytpuppet/add_match_mark
David Schmitt [Thu, 7 May 2015 13:25:46 +0000 (14:25 +0100)]
Merge pull request #527 from jonnytpuppet/add_match_mark

add match_mark

10 years agoadd match_mark
Chuck Schweizer [Sun, 8 Mar 2015 00:32:36 +0000 (18:32 -0600)]
add match_mark

10 years agoMerge pull request #525 from jonnytpuppet/tee-support
David Schmitt [Thu, 7 May 2015 13:13:23 +0000 (14:13 +0100)]
Merge pull request #525 from jonnytpuppet/tee-support

Tee Support

10 years agoMerge pull request #526 from elyscape/arch_linux
JT (Jonny) [Thu, 7 May 2015 13:07:24 +0000 (14:07 +0100)]
Merge pull request #526 from elyscape/arch_linux

Fix Arch Linux support

10 years agoMerge pull request #528 from puppetlabs/modulesync_updates
JT (Jonny) [Thu, 7 May 2015 13:06:43 +0000 (14:06 +0100)]
Merge pull request #528 from puppetlabs/modulesync_updates

Modulesync updates

10 years agobeaker gemfile fixes
Morgan Haskel [Wed, 6 May 2015 21:32:28 +0000 (14:32 -0700)]
beaker gemfile fixes

10 years agosync via modulesync
Morgan Haskel [Wed, 6 May 2015 21:30:39 +0000 (14:30 -0700)]
sync via modulesync