]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/log
Tomas Barton [Mon, 11 Sep 2017 15:14:16 +0000 (17:14 +0200)]
ensure dirmngr is installed on Debian Stretch
Tomas Barton [Thu, 7 Sep 2017 12:18:08 +0000 (14:18 +0200)]
(MODULES-4686) fix incorrect GPG keys parsing on Debian 9
patch from Alex P (alexpr)
Helen [Fri, 25 Aug 2017 14:25:05 +0000 (15:25 +0100)]
Merge pull request #665 from tigercomputing/master
Ignore subkeys in apt-key's output
Helen [Mon, 21 Aug 2017 09:50:13 +0000 (10:50 +0100)]
Merge pull request #695 from pmcmaw/remove_debian6
(FM-6273) - Removing Debian 6
Paula McMaw [Mon, 21 Aug 2017 08:22:22 +0000 (09:22 +0100)]
(FM-6273) - Removing Debian 6
This is not supported any longer according to the following
documentation: https://docs.puppet.com/pe/latest/sys_req_os.html
TP Honey [Thu, 17 Aug 2017 13:11:21 +0000 (14:11 +0100)]
Merge pull request #694 from pmcmaw/rm_ubuntu
(MODULES-5501) - Remove unsupported Ubuntu
Paula McMaw [Thu, 17 Aug 2017 12:49:58 +0000 (13:49 +0100)]
(MODULES-5501) - Remove unsupported Ubuntu
Removing older version of Ubuntu that are not supported by the module.
TP Honey [Fri, 4 Aug 2017 13:07:07 +0000 (14:07 +0100)]
Merge pull request #690 from tpdownes/master
Allow user to modify loglevel of apt-get update Exec resource
TP Honey [Thu, 3 Aug 2017 10:06:28 +0000 (11:06 +0100)]
Merge pull request #693 from mauricemeyer/master
Fixed typo in "Configuring Apt from hiera example"
Maurice Meyer [Wed, 2 Aug 2017 13:25:41 +0000 (15:25 +0200)]
Fixed typo
Tom Downes [Tue, 1 Aug 2017 13:01:12 +0000 (08:01 -0500)]
Allow user to modify loglevel of apt-get update Exec resource so that its
execution goes unlogged
Hunter Haugen [Thu, 27 Jul 2017 23:09:34 +0000 (16:09 -0700)]
Merge pull request #692 from puppetlabs/maint-modsync-
915cde70e20
(maint) modulesync
915cde70e20
Glenn Sarti [Thu, 27 Jul 2017 21:53:16 +0000 (14:53 -0700)]
(maint) modulesync
915cde70e20
TP Honey [Tue, 11 Jul 2017 10:19:15 +0000 (11:19 +0100)]
Merge pull request #640 from ocadotechnology/dpkg_admin_lock
(MODULES-4118) Set dpkg option NoLocking in apt_updates fact
TP Honey [Tue, 11 Jul 2017 10:13:28 +0000 (11:13 +0100)]
Merge pull request #688 from puppetlabs/msync_modules5187
(MODULES-5187) mysnc puppet 5 and ruby 2.4
TP Honey [Tue, 11 Jul 2017 10:13:00 +0000 (11:13 +0100)]
Merge pull request #686 from hunner/bump_metadata
(MODULES-5144) Prep for puppet 5
Eric Putnam [Fri, 7 Jul 2017 18:26:18 +0000 (11:26 -0700)]
(maint) update sync.yml to not manage NOTICE
Eric Putnam [Thu, 6 Jul 2017 21:40:41 +0000 (14:40 -0700)]
(MODULES-5187) mysnc puppet 5 and ruby 2.4
Okumura Takahiro [Wed, 5 Jul 2017 08:42:20 +0000 (17:42 +0900)]
Fix broken markdown of CHANGELOG.md (#687)
* Fix broken markdown of CHANGELOG.md
Hunter Haugen [Mon, 26 Jun 2017 20:57:17 +0000 (13:57 -0700)]
(MODULES-5144) Prep for puppet 5
TP Honey [Mon, 5 Jun 2017 09:38:59 +0000 (10:38 +0100)]
Merge pull request #684 from puppetlabs/release
Release 4.1.0 Mergeback
Hunter Haugen [Thu, 1 Jun 2017 17:37:20 +0000 (10:37 -0700)]
Merge pull request #679 from arioch/fix_typo
Hunter Haugen [Thu, 1 Jun 2017 17:36:29 +0000 (10:36 -0700)]
Merge pull request #682 from eputnam/fail_message
this failure is related to os.name, not os.release.full
Paula McMaw [Thu, 1 Jun 2017 13:21:18 +0000 (14:21 +0100)]
Merge pull request #683 from HelenCampbell/rpreppy
4.1.0 Release Prep
Helen Campbell [Thu, 1 Jun 2017 11:03:15 +0000 (12:03 +0100)]
4.1.0 Release Prep
Hunter Haugen [Wed, 31 May 2017 22:30:40 +0000 (15:30 -0700)]
Merge pull request #677 from syseleven/fix-4913
https://tickets.puppetlabs.com/browse/MODULES-4913
Prior to this commit, apt_key always sent auth basic header when source
came from http(s). This might fail for some webservers (e.g. Amazon S3)
when empty auth basic is sent.
Now apt_key only sends the auth basic header when userinfo can
be parsed from the URL.
Please backport this to 2.4.x, since this is the release before incompatibility changes are made.
Eric Putnam [Tue, 30 May 2017 15:13:13 +0000 (08:13 -0700)]
Merge pull request #681 from HelenCampbell/emptystringing
Ensure release allows empty strings
Tom Duckering [Tue, 31 Jan 2017 17:59:40 +0000 (17:59 +0000)]
Test to ensure empty string allowed for $release in apt::source
Test added to make sure when release is set to an empty string the
source file is rendered correctly.
Eric Putnam [Fri, 26 May 2017 16:51:10 +0000 (09:51 -0700)]
(maint) fix incorrect error message
this failure is related to os.name, not os.release.full
Hunter Haugen [Thu, 25 May 2017 23:07:59 +0000 (16:07 -0700)]
Merge pull request #680 from eputnam/remove_dim
this module is not able to find a value for `$keyserver` when it is
included in postgresql, as stated in the ticket. this changes the module
back to using the params.pp model. we can revisit data in modules once
LTS moves up from 4.7.0. for now, we need the compatibility.
Eric Putnam [Wed, 24 May 2017 17:34:25 +0000 (10:34 -0700)]
(MODULES-4973) rip out data in modules
this module is not able to find a value for `$keyserver` when it is
included in postgresql, as stated in the ticket. this changes the module
back to using the params.pp model. we can revisit data in modules once
LTS moves up from 4.7.0. for now, we need the compatibility.
Tom De Vylder [Thu, 18 May 2017 14:06:12 +0000 (16:06 +0200)]
Fix typo in hiera example
Helen [Wed, 17 May 2017 14:37:47 +0000 (15:37 +0100)]
Merge pull request #678 from DavidS/revert-attribution-removal
Revert removal of Evolving Web's attribution in NOTICE file
David Schmitt [Wed, 17 May 2017 14:02:22 +0000 (15:02 +0100)]
Revert removal of Evolving Web's attribution in NOTICE file
This reverts commit part of
26608d1ae2d2a3668a49357cd00dad97ce01d7cf .
Stefan Andres [Mon, 15 May 2017 08:21:50 +0000 (10:21 +0200)]
(#4913) apt_key now does not always send auth basic
Prior to this commit, apt_key always sent auth basic header when source
came from http(s). This might fail for some webservers (e.g. Amazon S3)
when empty auth basic is sent.
Now apt_key only sends the auth basic header when userinfo can
be parsed from the URL.
Erick Banks [Fri, 28 Apr 2017 18:11:27 +0000 (11:11 -0700)]
Merge pull request #676 from puppetlabs/release
4.0.0 Mergeback
Hunter Haugen [Wed, 26 Apr 2017 18:34:24 +0000 (11:34 -0700)]
Merge branch 'master' into release
Hunter Haugen [Wed, 26 Apr 2017 18:30:11 +0000 (11:30 -0700)]
Merge pull request #672 from domcleal/architecture-fact
Fix architecture fact overriding unset `architecture` source option
Helen [Tue, 25 Apr 2017 15:56:26 +0000 (16:56 +0100)]
Merge pull request #674 from hunner/fix_specs
(maint) Fix for different versions
Hunter Haugen [Mon, 24 Apr 2017 19:02:04 +0000 (12:02 -0700)]
(maint) Fix for different versions
Eric Putnam [Mon, 24 Apr 2017 18:29:50 +0000 (11:29 -0700)]
Merge pull request #673 from hunner/secondRelease
Rebase of #668
Hunter Haugen [Mon, 24 Apr 2017 18:05:11 +0000 (11:05 -0700)]
(maint) bump version to 4.0.0
Hunter Haugen [Mon, 24 Apr 2017 17:20:20 +0000 (10:20 -0700)]
(maint) Unit test fixes
Helen Campbell [Tue, 4 Apr 2017 10:57:35 +0000 (11:57 +0100)]
Removal of deprecated functionality
Helen Campbell [Tue, 4 Apr 2017 09:12:18 +0000 (10:12 +0100)]
Removal of compat types and validate_legacy calls
Dominic Cleal [Mon, 24 Apr 2017 07:30:15 +0000 (08:30 +0100)]
Fix architecture fact overriding unset `architecture` source option
When the `architecture` parameter to apt::source wasn't set, the
`architecture` fact would be used instead, causing the source to always
be limited by the architecture of the host.
The EPP variable has been renamed to avoid clashing with the fact name.
Hunter Haugen [Fri, 21 Apr 2017 17:03:54 +0000 (10:03 -0700)]
Merge pull request #671 from puppetlabs/release
Release Mergeback
Hunter Haugen [Mon, 17 Apr 2017 16:52:42 +0000 (09:52 -0700)]
(maint) Clear facter before to avoid parallel pollution
Hunter Haugen [Wed, 12 Apr 2017 18:19:32 +0000 (11:19 -0700)]
(maint) Stub fact exists call with argument passed
I can't replicate what's going on, but I wonder if the stub is being
bypassed and the actual underlying debian filesystem is being hit. The
timestamps returned by the unit test are from just before the unit test
ran.
Hunter Haugen [Wed, 12 Apr 2017 03:38:37 +0000 (20:38 -0700)]
(maint) Move stubs for apt update fact
I can't reproduce this, so just a guess.
Hunter Haugen [Wed, 12 Apr 2017 02:17:05 +0000 (19:17 -0700)]
(maint) Two missed failures due to parallel specs
Eric Putnam [Wed, 12 Apr 2017 01:01:10 +0000 (18:01 -0700)]
Merge pull request #670 from hunner/fix_specs
(PUP-6856) Always define facts
Hunter Haugen [Wed, 12 Apr 2017 00:18:25 +0000 (17:18 -0700)]
(PUP-6856) Always define facts
If facts are not defined for hiera lookups, the lookup will fail instead
of falling back to common on puppet < 4.9.0
Hunter Haugen [Tue, 11 Apr 2017 22:50:45 +0000 (15:50 -0700)]
Merge pull request #667 from HelenCampbell/firstRelease
First Release prep for Puppet 4 language update
Helen Campbell [Tue, 20 Dec 2016 11:34:00 +0000 (11:34 +0000)]
Puppet 4 language update
Hailee Kenney [Fri, 7 Apr 2017 14:19:33 +0000 (15:19 +0100)]
Merge pull request #669 from puppetlabs/release
Release Mergeback
Paula McMaw [Thu, 6 Apr 2017 14:39:54 +0000 (15:39 +0100)]
Merge pull request #666 from HelenCampbell/release
2.4.0 Release Prep
Helen Campbell [Thu, 6 Apr 2017 11:13:14 +0000 (12:13 +0100)]
2.4.0 Release Prep
tiger-jmw [Wed, 5 Apr 2017 12:04:54 +0000 (13:04 +0100)]
Ignore subkeys in apt-key's output
The output of `apt-key adv --list-keys --with-colons --fingerprint --fixed-list-mode` is always a `pub` line followed by one of more `fpr` lines (for subkeys, if any). This can cause the wrong pairs of `pub` and `fpr` lines to be hashed, resulting in nonsense.
The ordering `pub`, `fpr`, `pub`, `fpr` is guaranteed by `apt-key`.
Therefore, this commit clears `fpr_line` when a `pub` line is encountered, to reset the grouping. The current code ignores subkeys anyway, so this is no more bad.
Helen [Tue, 4 Apr 2017 09:43:02 +0000 (10:43 +0100)]
Merge pull request #662 from puppetlabs/modules-4506
[msync] 786266 Implement puppet-module-gems, a45803 Remove metadata.json from locales config
Wilson McCoubrey [Wed, 29 Mar 2017 14:53:54 +0000 (15:53 +0100)]
[maint] Fix puppet-lint warnings introduced with 2.2.0 puppet-lint release
Wilson McCoubrey [Wed, 29 Mar 2017 10:46:41 +0000 (11:46 +0100)]
[msync] 786266 Implement puppet-module-gems, a45803 Remove metadata.json from locales config
Helen [Fri, 24 Mar 2017 11:34:41 +0000 (11:34 +0000)]
Merge pull request #660 from puppetlabs/modules-4528
[MODULES-4528] Replace Puppet.version.to_f version comparison from spec_helper.rb
Wilson McCoubrey [Wed, 22 Mar 2017 15:06:27 +0000 (15:06 +0000)]
[MODULES-4528] Replace Puppet.version.to_f version comparison from spec_helper.rb
Hailee Kenney [Mon, 20 Mar 2017 14:02:55 +0000 (14:02 +0000)]
Merge pull request #658 from puppetlabs/MODULES-4528
[MODULES-4528] Replace Puppet.version.to_f with Puppet::Util::Package.versioncmp
Wilson McCoubrey [Thu, 16 Mar 2017 11:27:49 +0000 (11:27 +0000)]
[MODULES-4528] Replace Puppet.version.to_f with Puppet::Util::Package.versioncmp
Helen [Wed, 22 Feb 2017 11:26:36 +0000 (11:26 +0000)]
Merge pull request #653 from Cosaquee/remove-comma-from-example-in-readme
remove unnecessary comma in example
Helen [Wed, 22 Feb 2017 10:24:17 +0000 (10:24 +0000)]
Merge pull request #656 from WhatsARanjit/master
apt::key is a defined type, not a class
WhatsARanjit [Fri, 3 Feb 2017 00:48:06 +0000 (19:48 -0500)]
apt::key is a defined type, not a class
Eric Putnam [Sat, 21 Jan 2017 01:11:09 +0000 (17:11 -0800)]
Merge pull request #654 from puppetlabs/hunner_msync
(MODULES-4098) Sync the rest of the files
Hunter Haugen [Fri, 20 Jan 2017 00:11:40 +0000 (16:11 -0800)]
(MODULES-4098) Sync the rest of the files
Karol Kozakowski [Thu, 12 Jan 2017 13:24:08 +0000 (14:24 +0100)]
remove unnecessary comma in example
Eric Putnam [Wed, 11 Jan 2017 16:45:15 +0000 (11:45 -0500)]
Merge pull request #650 from puppetlabs/hunner_msync
(MODULES-4097) Sync travis.yml
Eric Putnam [Wed, 11 Jan 2017 14:48:43 +0000 (09:48 -0500)]
Merge pull request #652 from puppetlabs/implement-beaker-module_install_helper
[MODULES-4224] Implement beaker-module_install_helper
Hunter Haugen [Thu, 5 Jan 2017 23:31:01 +0000 (15:31 -0800)]
(MODULES-4097) Sync travis.yml
Wilson McCoubrey [Tue, 10 Jan 2017 10:43:54 +0000 (10:43 +0000)]
[MODULES-4224] Implement beaker-module_install_helper
Hunter Haugen [Thu, 15 Dec 2016 00:24:47 +0000 (16:24 -0800)]
Merge pull request #646 from puppetlabs/modsync
(FM-5972) gettext and spec.opts
Eric Putnam [Wed, 14 Dec 2016 21:28:43 +0000 (13:28 -0800)]
gettext and spec.opts
TP Honey [Wed, 14 Dec 2016 15:16:11 +0000 (15:16 +0000)]
Merge pull request #641 from DavidS/use-stdlib-deprecation
Use stdlib deprecation
Helen Campbell [Wed, 14 Dec 2016 14:37:54 +0000 (14:37 +0000)]
Fix for tests against PR-641
Hunter Haugen [Tue, 6 Dec 2016 23:32:39 +0000 (15:32 -0800)]
Merge pull request #644 from eputnam/spec_opts
(maint) updates spec.opts in prep for parallel_spec
Eric Putnam [Tue, 6 Dec 2016 22:20:23 +0000 (14:20 -0800)]
removes spec.opts
Eric Putnam [Fri, 2 Dec 2016 19:43:12 +0000 (11:43 -0800)]
Merge pull request #643 from puppetlabs/hunner_msync
(MODULES-3631) msync Gemfile for 1.9 frozen strings
Hunter Haugen [Thu, 1 Dec 2016 19:36:52 +0000 (11:36 -0800)]
(MODULES-3631) msync Gemfile for 1.9 frozen strings
Eric Putnam [Tue, 29 Nov 2016 00:36:43 +0000 (16:36 -0800)]
Merge pull request #638 from lrrb/master
remove port number from hostname
David Schmitt [Sun, 27 Nov 2016 17:03:26 +0000 (17:03 +0000)]
Use the stdlib deprecation() function
David Schmitt [Sun, 27 Nov 2016 16:26:20 +0000 (16:26 +0000)]
Update to require using stdlib 4.13 for deprecation function
justin.cattle [Tue, 22 Nov 2016 17:34:01 +0000 (17:34 +0000)]
(MODULES-4118) Set dpkg option NoLocking in apt_updates fact
Although the man page for apt-get indicates the --simluate means locking
will be disabled, testing indicates it isn't.
Indeed, regulary collecting facts causes it to clash with the apt_update
Exec occasionally, resulting in failures to lock /var/lib/dpkg
Spefically setting the NoLocking option fixes the issue.
lrrb [Wed, 16 Nov 2016 22:06:37 +0000 (23:06 +0100)]
remove port number from hostname
Solve the issue reported in https://tickets.puppetlabs.com/browse/MODULES-4104 : remove the port number from repository location in order to get the host name of the repository.
Eric Putnam [Thu, 10 Nov 2016 18:59:08 +0000 (10:59 -0800)]
Merge pull request #636 from puppetlabs/hunner_msync
(MODULES-3704) Update gemfile template to be identical
Hunter Haugen [Wed, 9 Nov 2016 17:58:08 +0000 (09:58 -0800)]
(MODULES-3704) Update gemfile template to be identical
Wilson McCoubrey [Wed, 9 Nov 2016 11:44:40 +0000 (11:44 +0000)]
Merge pull request #635 from lkoranda/fix_string_comparison_error
Avoid string comparison error
Lukas Koranda [Sun, 6 Nov 2016 22:01:42 +0000 (23:01 +0100)]
Avoiding string comparison error
Signed-off-by: Lukas Koranda <lkoranda@redhat.com>
Eric Putnam [Wed, 2 Nov 2016 23:00:43 +0000 (16:00 -0700)]
mocha version update for test hanging issue
Hunter Haugen [Mon, 31 Oct 2016 16:51:36 +0000 (09:51 -0700)]
Merge pull request #633 from puppetlabs/Paula_modulesync
(MODULES-3983) Update parallel_tests for ruby 2.0.0
David Schmitt [Tue, 25 Oct 2016 10:21:35 +0000 (11:21 +0100)]
Merge pull request #631 from wilson208/key-server-timeout-fix
[MODULES-3562] Implement retry for tests which require modules to pull key from keyserver
Paula McMaw [Thu, 20 Oct 2016 08:47:24 +0000 (09:47 +0100)]
(MODULES-3983) Update parallel_tests for ruby 2.0.0
Wilson McCoubrey [Wed, 19 Oct 2016 16:29:36 +0000 (17:29 +0100)]
Implement retry on tests which pull key from a key server which sometimes times out (transient error)
Wilson McCoubrey [Tue, 18 Oct 2016 10:15:38 +0000 (11:15 +0100)]
Fix tests to check for idempotency correctly.
Eric Putnam [Tue, 11 Oct 2016 22:48:40 +0000 (15:48 -0700)]
Merge pull request #629 from puppetlabs/modulesync
Update modulesync_config [
51f469d ]