]> review.fuel-infra Code Review - openstack-build/cinder-build.git/log
openstack-build/cinder-build.git
11 years agoMerge "Add Brick iSCSI attach/detach."
Jenkins [Thu, 27 Jun 2013 22:51:02 +0000 (22:51 +0000)]
Merge "Add Brick iSCSI attach/detach."

11 years agoMerge "Fix check_for_setup_error for sheepdog driver"
Jenkins [Thu, 27 Jun 2013 17:56:45 +0000 (17:56 +0000)]
Merge "Fix check_for_setup_error for sheepdog driver"

11 years agoSave some more image attributes to volume_glance_metadata.
Vincent Hou [Thu, 27 Jun 2013 07:43:00 +0000 (15:43 +0800)]
Save some more image attributes to volume_glance_metadata.

Current issue: When copying an image to a volume, attributes like size, disk_format, container_format,
checksum, min_disk and min_ram have not been copied so far. When booting a VM from a volume, we are
not able to check these atrributes without giving the image id. Furthermore, if the original
image is deleted, we will lose all the information.

This patch saves these attributes into volume_glance_metadata. We can still check these attributes
without giving the image id when booting a VM from a volume.

Fixed Bug 1159824.

Change-Id: I42ce676026d32be6e3f4bec6fd269908e2df0a8c

11 years agoMerge "Added volume backup and restore to Ceph RBD driver"
Jenkins [Thu, 27 Jun 2013 08:56:41 +0000 (08:56 +0000)]
Merge "Added volume backup and restore to Ceph RBD driver"

11 years agoFix check_for_setup_error for sheepdog driver
Kai Zhang [Thu, 27 Jun 2013 07:31:36 +0000 (00:31 -0700)]
Fix check_for_setup_error for sheepdog driver

Current implementation of check_for_setup_error() of sheepdog driver
cannot work correctly with the latest version of sheepdog cluster.
This patch fixes it and adds tests for both old and new version.

Fixes: bug #1195098
Change-Id: Ia710789e4bedd7c83cd47eff6b2fc532af39d94a

11 years agoMerge "Raise an error if iSCSI is not supported"
Jenkins [Thu, 27 Jun 2013 05:47:54 +0000 (05:47 +0000)]
Merge "Raise an error if iSCSI is not supported"

11 years agoAdd Brick iSCSI attach/detach.
Walter A. Boring IV [Tue, 11 Jun 2013 22:27:56 +0000 (15:27 -0700)]
Add Brick iSCSI attach/detach.

This patch adds the new brick initiator connector object
which contains the code to do volume attach and detach to a host
machine.  It includes hooks to work in both cinder and nova.
Nova has different exec wrapper and it also needs to talk to a
hypervisor at certain points during detach.

This patch also pulls the copy/pasted code from nova in the base
ISCSIDriver's _attach_volume method to use this new brick library.

This patch also includes a fix in the ISCSIDriver's
copy_volume_to_image code that didn't actually detach a volume
when it was done with the operation.
Bug 1194962

This patch also includes a fix for iSCSI detaches where the
iSCSI LUN wasn't being removed from the system until the very
last detach issues an iscsiadm logout.
Bug 1112483

This patch includes a fix for iSCSI multipath detaches where
the multipath device and the iSCSI LUNs for the multipath device
were never removed from the kernel.
Bug 1112483

Blueprint cinder-refactor-attach

Change-Id: Ieb181f896adb9230bbb6a2e5c42f261d61a0f140

11 years agoAdded volume backup and restore to Ceph RBD driver
Edward Hope-Morley [Wed, 26 Jun 2013 09:25:11 +0000 (10:25 +0100)]
Added volume backup and restore to Ceph RBD driver

It is now possible to backup and restore volumes
when using volume.drivers.rbd.RBDDriver

Implements: blueprint cinder-backup-to-ceph

Change-Id: Ic1b8db8f0acd7974423414171b8fb45197d05dc6

11 years agoContent-length missing in put_object
Marc Koderer [Wed, 19 Jun 2013 14:07:44 +0000 (16:07 +0200)]
Content-length missing in put_object

Radosgw returns a "411 Length Required" in case the content-length is not
specified. The parameter content_type is not set which leads to the problem
that content_length cannot be determined. Since the content length is already
computed in backup/services/swift it shouldn't be a problem to set this
parameter.

Conflicts:
cinder/backup/services/swift.py

Change-Id: I4c56823d70fcd1a801a75bfd14f474a2780dc1ac

11 years agoMerge "Update kombu requirement"
Jenkins [Wed, 26 Jun 2013 04:39:51 +0000 (04:39 +0000)]
Merge "Update kombu requirement"

11 years agoMerge "Register used CONF entries in cinder.api.common.py"
Jenkins [Tue, 25 Jun 2013 21:42:14 +0000 (21:42 +0000)]
Merge "Register used CONF entries in cinder.api.common.py"

11 years agoMerge "Replace glance_metadata check with bootable column."
Jenkins [Tue, 25 Jun 2013 20:50:35 +0000 (20:50 +0000)]
Merge "Replace glance_metadata check with bootable column."

11 years agoMerge "Imported Translations from Transifex"
OpenStack Jenkins [Tue, 25 Jun 2013 19:45:33 +0000 (19:45 +0000)]
Merge "Imported Translations from Transifex"

11 years agoReplace glance_metadata check with bootable column.
John Griffith [Wed, 19 Jun 2013 05:22:48 +0000 (23:22 -0600)]
Replace glance_metadata check with bootable column.

This patch adds a column to indicate if a volume is bootable or not.

Cinder API V1 was using get.volume_glance_metadata to determine
if a volume was bootable for translate_view.

This is fine until you put a heavy load on the system and things
can fall apart, particularly the backref of the glance meta is no longer
available and the call blows up.  Also this results in a bit of extra
unnecessary data being passed around with every create and get call.
This is especially an issue when creating hundreds or thousands of volumes.
Even better we can now reliably create thousands of volumes.

Fixes bug: 1192390

Change-Id: Idd47a0a8069ee905b81c7aae562b82767ad91930

11 years agoMerge "Added extra-spec key scoping to the 3PAR drivers"
Jenkins [Tue, 25 Jun 2013 18:50:48 +0000 (18:50 +0000)]
Merge "Added extra-spec key scoping to the 3PAR drivers"

11 years agoImported Translations from Transifex
OpenStack Jenkins [Tue, 25 Jun 2013 18:10:58 +0000 (18:10 +0000)]
Imported Translations from Transifex

Change-Id: Ib1f73f11952a60695f49cf8c6cd8fbca9946bd6f

11 years agoMerge "Do not raise NEW exceptions"
Jenkins [Tue, 25 Jun 2013 17:58:48 +0000 (17:58 +0000)]
Merge "Do not raise NEW exceptions"

11 years agoMerge " cinder.[brick,db,image] Replace 'locals()'"
Jenkins [Tue, 25 Jun 2013 17:23:10 +0000 (17:23 +0000)]
Merge "        cinder.[brick,db,image] Replace 'locals()'"

11 years agoMerge "Avoid winning the useless use of cat award"
Jenkins [Tue, 25 Jun 2013 17:23:07 +0000 (17:23 +0000)]
Merge "Avoid winning the useless use of cat award"

11 years agoMerge "Fix up trivial H103 license check mismatches"
Jenkins [Tue, 25 Jun 2013 16:29:01 +0000 (16:29 +0000)]
Merge "Fix up trivial H103 license check mismatches"

11 years agoAvoid winning the useless use of cat award
Dirk Mueller [Sun, 23 Jun 2013 12:06:55 +0000 (14:06 +0200)]
Avoid winning the useless use of cat award

We can use file operations directly, no need
to run cat(1)

Change-Id: Id8a9f615dfb11d1bd7acd4a7d6f40545c246e5cd

11 years agoFix up trivial H103 license check mismatches
Dirk Mueller [Tue, 25 Jun 2013 14:32:51 +0000 (16:32 +0200)]
Fix up trivial H103 license check mismatches

Adjust a few trivial typos in the license headers
in the source files.

Change-Id: I907df4ece8e589e930fd788e3f33201537938572

11 years agoRegister used CONF entries in cinder.api.common.py
John Griffith [Mon, 24 Jun 2013 23:38:38 +0000 (17:38 -0600)]
Register used CONF entries in cinder.api.common.py

After change: I2114d5fc45f5299c3b2011270034a3370e0ec388 we
were no longer registering defaults for cinder.api.common.py settings.

The result is that you're unable to run individual unit tests like
cinder.tests.api.test_volume_metadata.py.

Register the needed CONF options and we're all set again.

Fixes bug: 1194315

Change-Id: I6df6c5ec5687c8156a9f3794cc7f04d8d28065d9

11 years agoFix and enable gating on H401
Dirk Mueller [Tue, 25 Jun 2013 14:24:08 +0000 (16:24 +0200)]
Fix and enable gating on H401

H401  docstring should not start with a space

Change-Id: Iaf63af75b0534cae1bac3c931ef5f51f1644aec9

11 years agoDo not raise NEW exceptions
Sergey Vilgelm [Mon, 24 Jun 2013 11:19:50 +0000 (15:19 +0400)]
Do not raise NEW exceptions

Raising NEW exception is bad practice, because we lose TraceBack.
So all places like:

except SomeException as e:
    raise e

should be replaced by

except SomeException:
    raise

If we are doing some other actions before reraising we should
store information about exception then do all actions and then
reraise it. This is caused by eventlet bug. It lost information
about exception if it switch threads.

fixes bug 1191730
Change-Id: Ic2be96e9f03d2ca46d060caf6f6f7f713a1d6b82

11 years ago cinder.[brick,db,image] Replace 'locals()'
Scott DAngelo [Tue, 25 Jun 2013 13:19:51 +0000 (13:19 +0000)]
    cinder.[brick,db,image] Replace 'locals()'

        Replace use of 'locals()' with explicit values.
        Help bring source code into compliance with the
        Cinder Style Commandments:
        https://github.com/openstack/cinder/blob/master/HACKING.rst

        This change covers all affected soruce in the
        cinder brick, db, and image modules, i.e.
        cinder/brick/*.py and subdirectories
        cinder/db/*.py and subdirectories
        cinder/image/*.py and subdirectories

        Partially fixes: bug #1190758

Change-Id: Ibc111ab5ef53a2316e868c9cba8b94b323ba31c0

11 years agoMerge "Add support for swift user/key authentication"
Jenkins [Tue, 25 Jun 2013 05:46:28 +0000 (05:46 +0000)]
Merge "Add support for swift user/key authentication"

11 years agoMerge "Remove usage of locals() for formatting from cinder.tests.*"
Jenkins [Mon, 24 Jun 2013 22:26:11 +0000 (22:26 +0000)]
Merge "Remove usage of locals() for formatting from cinder.tests.*"

11 years agoUpdate kombu requirement
Doug Hellmann [Wed, 19 Jun 2013 21:16:32 +0000 (17:16 -0400)]
Update kombu requirement

The minimum version of kombu in the requirements
list has been updated to ensure that compatible
kombu and msgpack libraries are used across all
projects. This update also requires a bump for
anyjson.

Addresses bug #1134575

Change-Id: Ic33a5bbc8d1cdf1effd41c1c2aebc7ef6988c39e
Signed-off-by: Doug Hellmann <doug.hellmann@dreamhost.com>
11 years agoMerge "Add the project name into CinderKeystoneContext."
Jenkins [Mon, 24 Jun 2013 08:03:39 +0000 (08:03 +0000)]
Merge "Add the project name into CinderKeystoneContext."

11 years agoRemove usage of locals() for formatting from cinder.tests.*
Haomai Wang [Mon, 24 Jun 2013 06:03:31 +0000 (14:03 +0800)]
Remove usage of locals() for formatting from cinder.tests.*

Using of locals() for formatting string is a nasty thing because:
1) It is not so clear as using explicit dicts
2) It could produce hidden errors during refactoring
3) Changing name of variable causes change in message
4) Creating a lot of unused variables

Fix bug 1171936

Change-Id: I67aa5bff650b55484ca76adf5be8555f72a4c426

11 years agoMerge "Adds create_from_volume test cases"
Jenkins [Sun, 23 Jun 2013 11:00:35 +0000 (11:00 +0000)]
Merge "Adds create_from_volume test cases"

11 years agoMerge "NetApp:iSCSI drivers reserved percent need to change to 0."
Jenkins [Sun, 23 Jun 2013 10:07:42 +0000 (10:07 +0000)]
Merge "NetApp:iSCSI drivers reserved percent need to change to 0."

11 years agoMerge "Use list comprehensions when possible"
Jenkins [Sun, 23 Jun 2013 09:08:48 +0000 (09:08 +0000)]
Merge "Use list comprehensions when possible"

11 years agoAdds create_from_volume test cases
xiaoxi_chen [Thu, 20 Jun 2013 16:56:38 +0000 (00:56 +0800)]
Adds create_from_volume test cases

  For tests.test_volumes,
  added 3 test cases:
     create_from_volume
     create_from_volume_with_glance_metadata
     create_from_volume_failed_on_cloning
  refactored an internal api:
     _create_volume_from_image

  The reason not to test a non-exist volume as source_vol is
  the uplayer(volume api) has already checked and ensured the
  source_vol exists

Change-Id: I9c345bc29cae31f1a22236a4849f13d7289ea49e

11 years agoUse list comprehensions when possible
Seif Lotfy [Fri, 21 Jun 2013 13:22:47 +0000 (13:22 +0000)]
Use list comprehensions when possible

Replace some for loops with list comprehensions for compacting

Change-Id: Ia80a013735c595d7c4d40172b34beb18b4383ee0

11 years agoNetApp:iSCSI drivers reserved percent need to change to 0.
Navneet Singh [Fri, 21 Jun 2013 13:16:36 +0000 (18:46 +0530)]
NetApp:iSCSI drivers reserved percent need to change to 0.

The iscsi drivers reserved percent is 100 as of now. This needs
to be changed to 0 for default values. It needs to be corrected
so that filter scheduler does not discard netapp backend.

bug 1182015

Change-Id: Id80584e5d478c83de97735706994206e024f8bf6

11 years agoAdd support for swift user/key authentication
Marc Koderer [Thu, 20 Jun 2013 15:20:30 +0000 (17:20 +0200)]
Add support for swift user/key authentication

By default the swift backup service uses keystone authentication to
communicate with the swift endpoint. This patch adds three optional
parameters to allow username/key authentication

Change-Id: I54ad7d91785ade5375f317aceb80b3374b59f5fe

11 years agoRefactor the backup method of SwiftBackupService
Seif Lotfy [Fri, 21 Jun 2013 09:28:27 +0000 (09:28 +0000)]
Refactor the backup method of SwiftBackupService

Export functionalities of backup to 3 new methods:
prepare_backup backup_chunk and finalize_backup. The original
backup function calls those functions. This allows other
drivers to combine them in a different logic.
e.g for the RBDDriver

Change-Id: I4f335bfcd03cd1da52a9e5c5c689d97581614af6

11 years agoMerge "NetApp unified driver implementation."
Jenkins [Fri, 21 Jun 2013 01:42:50 +0000 (01:42 +0000)]
Merge "NetApp unified driver implementation."

11 years agoMerge "cinder.backup: Replace 'locals()' with explicit values"
Jenkins [Fri, 21 Jun 2013 00:45:13 +0000 (00:45 +0000)]
Merge "cinder.backup: Replace 'locals()' with explicit values"

11 years agoImported Translations from Transifex
OpenStack Jenkins [Thu, 20 Jun 2013 18:11:00 +0000 (18:11 +0000)]
Imported Translations from Transifex

Change-Id: I188f3cd9a415361fa07289977d35406e8f9786f3

11 years agoNetApp unified driver implementation.
Navneet Singh [Fri, 17 May 2013 11:19:50 +0000 (04:19 -0700)]
NetApp unified driver implementation.

NetApp has growing number of multiple drivers depending on storage families
and technologies. NetApp unified driver simplifies configuration
and provides single entry point for all storage technologies/drivers.
It provides new mechanism to support multiple NetApp technologies
and block drivers related to them. Deprecated 7mode dfm and c mode
webservice based drivers.

blueprint netapp-unified-driver

Change-Id: Ife3cb12ef2256e0124c9a02a968c20a580b5df93

11 years agoMerge "Add _create_volume to ThinLVMVolumeDriver"
Jenkins [Thu, 20 Jun 2013 17:28:59 +0000 (17:28 +0000)]
Merge "Add _create_volume to ThinLVMVolumeDriver"

11 years agoAdd _create_volume to ThinLVMVolumeDriver
Eric Harney [Wed, 19 Jun 2013 20:31:07 +0000 (16:31 -0400)]
Add _create_volume to ThinLVMVolumeDriver

Previously, _create_volume from LVMISCSIDriver would be called
when the volume manager calls create_volume_from_snapshot.

Fixes bug: 1192601

Change-Id: I5cca287e8204c4647a5f09df961d9a76d0b38c42

11 years agoMerge "Add build directory to flake8 ignore dirs."
Jenkins [Thu, 20 Jun 2013 09:56:59 +0000 (09:56 +0000)]
Merge "Add build directory to flake8 ignore dirs."

11 years agoMerge "Add missing extend volume test (rpcapi)."
Jenkins [Thu, 20 Jun 2013 07:05:29 +0000 (07:05 +0000)]
Merge "Add missing extend volume test (rpcapi)."

11 years agoMerge "Modify check for volume-type-id to a get w/default"
Jenkins [Thu, 20 Jun 2013 06:00:58 +0000 (06:00 +0000)]
Merge "Modify check for volume-type-id to a get w/default"

11 years agoMerge "Don't perform retry_execute in certain cases."
Jenkins [Thu, 20 Jun 2013 05:53:45 +0000 (05:53 +0000)]
Merge "Don't perform retry_execute in certain cases."

11 years agoAdd the project name into CinderKeystoneContext.
Vincent Hou [Mon, 17 Jun 2013 08:42:43 +0000 (16:42 +0800)]
Add the project name into CinderKeystoneContext.

Fixed Bug 1178576.

Change-Id: I35cbd40c6f4aba45aeb8722ae5e10db8349d4510

11 years agoAdd build directory to flake8 ignore dirs.
John Griffith [Thu, 20 Jun 2013 05:19:54 +0000 (23:19 -0600)]
Add build directory to flake8 ignore dirs.

No need to run flake8 on the build dir, so add it
to ignore list.

Change-Id: I0f6d3d3b889616f12ae2c52bbc65e528f3786996

11 years agoAdd missing extend volume test (rpcapi).
Avishay Traeger [Thu, 20 Jun 2013 04:48:51 +0000 (07:48 +0300)]
Add missing extend volume test (rpcapi).

Add test that was missing to test the volume rpcapi call for
extend_volume.

Change-Id: Idffc18cad60afe6e8864fd93d36f9ec23a402b73

11 years agofix error class path in logging sample
Yejia Xu [Wed, 19 Jun 2013 14:41:07 +0000 (22:41 +0800)]
fix error class path in logging sample

class path for NullHandler should be
cinder.openstack.common.log.NullHandler.

Fixes bug: 1192765
Change-Id: I552fe25cb89fa911dcbacb733013097b6e3c4ef3

11 years agoModify check for volume-type-id to a get w/default
John Griffith [Wed, 19 Jun 2013 23:33:59 +0000 (17:33 -0600)]
Modify check for volume-type-id to a get w/default

While implementing Fix for a previous bug to enable setting
volume type on a cloned volume and reading it's info we added
a vref['volume_type_id'], problem is that the _do_clone method
is shared for both clone and create from snapshot.

In the create from snapshot case however that key doesn't exist
in the vref (which is a snapshot object).

This change turns this into a key.get with a default return.

Fixes bug: 1192745

Change-Id: I1a6d38de614f54fcaa31ea7cc4250aacc85b0796

11 years agoDon't perform retry_execute in certain cases.
John Griffith [Tue, 18 Jun 2013 20:45:50 +0000 (14:45 -0600)]
Don't perform retry_execute in certain cases.

Certain cases like "LVM not found" and "Insufficient space"
in LVM create/delete shouldn't be retried.

Change-Id: I1a0891f769d37dc858c70b07c838f9fc4111a76c

11 years agoMerge "Use Python 3.x compatible except construct"
Jenkins [Wed, 19 Jun 2013 14:03:58 +0000 (14:03 +0000)]
Merge "Use Python 3.x compatible except construct"

11 years agoMerge "Implement capability to extend existing volume."
Jenkins [Wed, 19 Jun 2013 07:54:24 +0000 (07:54 +0000)]
Merge "Implement capability to extend existing volume."

11 years agoMerge "Update attach status when instance id invalid."
Jenkins [Wed, 19 Jun 2013 04:19:12 +0000 (04:19 +0000)]
Merge "Update attach status when instance id invalid."

11 years agoUpdate attach status when instance id invalid.
John Griffith [Tue, 18 Jun 2013 22:49:13 +0000 (16:49 -0600)]
Update attach status when instance id invalid.

In cinder.manager do_attach we have a check to make sure the
supplied instance id is a valid UUID which is great, but if it's
not we just raise and dump out, leaving the volume in an attaching
state.

We should update the status to error_attaching in this case and then
raise/return.

Fixes bug: 1192370

Change-Id: Ia759ea7a387544913953ca84e9ed927480c4edfd

11 years agoFix and enable gating on H403
Dirk Mueller [Tue, 18 Jun 2013 19:22:44 +0000 (21:22 +0200)]
Fix and enable gating on H403

Fix occurrences of
H403 - multi line docstring end on new line

Change-Id: I79a818095e9f64a18ded1686fb152b9d58f3c8b1

11 years agoUse Python 3.x compatible except construct
Dirk Mueller [Tue, 18 Jun 2013 19:09:19 +0000 (21:09 +0200)]
Use Python 3.x compatible except construct

Use except x as y:, which works with any
Python version >= 2.6

Change-Id: Ibf0f9aa8fb9725c1c9c00558ec217db96301678f

11 years agocinder.backup: Replace 'locals()' with explicit values
Andrew Forrest [Sat, 15 Jun 2013 00:09:53 +0000 (17:09 -0700)]
cinder.backup: Replace 'locals()' with explicit values

Help bring source code into compliance with the Cinder Style Commandments:
https://github.com/openstack/cinder/blob/master/HACKING.rst

This change covers all affected source in the cinder backup module, i.e.
cinder/backup/*.py and subdirectories.

Partially fixes: bug #1190748

Change-Id: I3e0f3806030f1813d055135f15e64b5a719970ed

11 years agoMerge "cinder.schedule: Replace 'locals()' with explicit values"
Jenkins [Tue, 18 Jun 2013 07:52:16 +0000 (07:52 +0000)]
Merge "cinder.schedule: Replace 'locals()' with explicit values"

11 years agoMerge "Use common.processutils.execute"
Jenkins [Tue, 18 Jun 2013 06:13:25 +0000 (06:13 +0000)]
Merge "Use common.processutils.execute"

11 years agoMerge "Use Python 3.x compatible octal numbers"
Jenkins [Mon, 17 Jun 2013 23:17:09 +0000 (23:17 +0000)]
Merge "Use Python 3.x compatible octal numbers"

11 years agoMerge "cinder/.: replace 'locals()' with explicit values"
Jenkins [Mon, 17 Jun 2013 21:21:40 +0000 (21:21 +0000)]
Merge "cinder/.: replace 'locals()' with explicit values"

11 years agoMerge "Editable default quota support for cinder"
Jenkins [Mon, 17 Jun 2013 18:00:30 +0000 (18:00 +0000)]
Merge "Editable default quota support for cinder"

11 years agoMerge "Imported Translations from Transifex"
OpenStack Jenkins [Mon, 17 Jun 2013 17:01:55 +0000 (17:01 +0000)]
Merge "Imported Translations from Transifex"

11 years agocinder/.: replace 'locals()' with explicit values
Andrew Forrest [Sat, 15 Jun 2013 18:09:33 +0000 (11:09 -0700)]
cinder/.: replace 'locals()' with explicit values

Help bring source code into compliance with the Cinder Style Commandments:
https://github.com/openstack/cinder/blob/master/HACKING.rst

This change covers all affected source directly in the top-level directory
of the cinder module, i.e. cinder/*.py

Partially fixes: bug #1190748

Change-Id: Ice5efc5eda7189969af6a9b722344fad7aa49ff0

11 years agoEditable default quota support for cinder
liyingjun [Thu, 23 May 2013 08:24:26 +0000 (16:24 +0800)]
Editable default quota support for cinder

Implement blueprint edit-default-quota

DocImpact

Using the class quotas named `default` as the default editable quotas.

We can use the following cinderclient command to update default quota:

cinder quota-class-update default <key> <value>

Change-Id: I9f97506b41157066026dd43163ec4b1827d5b9cf

11 years agoMerge "Remove usage of locals() for formatting from cinder.volume.*"
Jenkins [Sun, 16 Jun 2013 20:07:25 +0000 (20:07 +0000)]
Merge "Remove usage of locals() for formatting from cinder.volume.*"

11 years agoImported Translations from Transifex
OpenStack Jenkins [Sun, 16 Jun 2013 18:10:55 +0000 (18:10 +0000)]
Imported Translations from Transifex

Change-Id: I33655108153839dc27a906ad757e5e447a84bcce

11 years agoMerge "Imported Translations from Transifex"
OpenStack Jenkins [Sun, 16 Jun 2013 17:13:17 +0000 (17:13 +0000)]
Merge "Imported Translations from Transifex"

11 years agoUse common.processutils.execute
John Griffith [Tue, 4 Jun 2013 23:07:03 +0000 (17:07 -0600)]
Use common.processutils.execute

This patch replaces the cinder.utils.execute method
with a wrapper around openstack.common.processutils.execute.

With the wrapper I'm also converting the processutils exceptions
to maintain compatability with the existing exceptions that are
caught/raised in the code.

Change-Id: Ibc36a1e83191e7c888ea62c55d28b7023535d9fa

11 years agoMerge "Start using Pyflakes"
Jenkins [Sun, 16 Jun 2013 16:46:27 +0000 (16:46 +0000)]
Merge "Start using Pyflakes"

11 years agoRemove usage of locals() for formatting from cinder.volume.*
Haomai Wang [Sun, 16 Jun 2013 05:21:20 +0000 (13:21 +0800)]
Remove usage of locals() for formatting from cinder.volume.*

Using of locals() for formatting string is a nasty thing because:
1) It is not so clear as using explicit dicts
2) It could produce hidden errors during refactoring
3) Changing name of variable causes change in message
4) Creating a lot of unused variables

Fix bug 1171936

Change-Id: I806c530851527db9da251352be45b97c183241a8

11 years agocinder.schedule: Replace 'locals()' with explicit values
Andrew Forrest [Sat, 15 Jun 2013 18:45:15 +0000 (11:45 -0700)]
cinder.schedule: Replace 'locals()' with explicit values

Help bring source code into compliance with the Cinder Style Commandments:
https://github.com/openstack/cinder/blob/master/HACKING.rst

This change covers all affected source in the cinder scheduler module, i.e.
cinder/scheduler/*.py and subdirectories.

Partially fixes: bug #1190748

Change-Id: I75ad858ee62317bef6c59b9c0896f8a94a989d52

11 years agoMerge "Remove the 'migrate' option from cinder-manage"
Jenkins [Sun, 16 Jun 2013 13:10:30 +0000 (13:10 +0000)]
Merge "Remove the 'migrate' option from cinder-manage"

11 years agoImported Translations from Transifex
OpenStack Jenkins [Sat, 15 Jun 2013 18:10:58 +0000 (18:10 +0000)]
Imported Translations from Transifex

Change-Id: I79a7551378872d60bea0b516dd6ed59bf6cdcc39

11 years agoMerge "Update and add notifiers in create volume"
Jenkins [Sat, 15 Jun 2013 06:36:18 +0000 (06:36 +0000)]
Merge "Update and add notifiers in create volume"

11 years agoMerge "Imported Translations from Transifex"
OpenStack Jenkins [Sat, 15 Jun 2013 01:44:40 +0000 (01:44 +0000)]
Merge "Imported Translations from Transifex"

11 years agoMerge "Use Python 3.x compatible except: construct"
Jenkins [Sat, 15 Jun 2013 00:40:55 +0000 (00:40 +0000)]
Merge "Use Python 3.x compatible except: construct"

11 years agoMerge "Remove usage of locals() for formatting from cinder.api.*"
Jenkins [Sat, 15 Jun 2013 00:40:52 +0000 (00:40 +0000)]
Merge "Remove usage of locals() for formatting from cinder.api.*"

11 years agoMerge "Replace utils.to_bytes() with strutils.to_bytes()"
Jenkins [Sat, 15 Jun 2013 00:40:45 +0000 (00:40 +0000)]
Merge "Replace utils.to_bytes() with strutils.to_bytes()"

11 years agoRemove the 'migrate' option from cinder-manage
Jay S. Bryant [Fri, 14 Jun 2013 23:30:10 +0000 (18:30 -0500)]
Remove the 'migrate' option from cinder-manage

The 'migrate' option was only appropriate for use migrating
databases for volumes from Nova-Folsom-->Cinder-Folsom.  The
code hasn't been tested since.

Given the above facts, this commit removes the migrate code from
cinder-manage.  The man page for cinder-manage was already
updated to remove the option in a previous commit.

(fixes bug #1187134)

Change-Id: I7bf378cd4b0dd4f6d1bdf475b826a59a31112638

11 years agoUse Python 3.x compatible octal numbers
Dirk Mueller [Sat, 8 Jun 2013 08:59:13 +0000 (10:59 +0200)]
Use Python 3.x compatible octal numbers

Unfortunately, Python 3.x deprecated support for 0755
octal numbers. Use 0o755 instead.

Change-Id: I70403d382d6e6569445b6a99954ea24d436f29ad

11 years agoUse Python 3.x compatible except: construct
Dirk Mueller [Sat, 8 Jun 2013 08:49:57 +0000 (10:49 +0200)]
Use Python 3.x compatible except: construct

Per (proposed) H203 check, convert all uses of
the deprecated except x,y: construct to except
x as y:, which works with any Python version >= 2.6

Change-Id: I5528dc556f3ef8d356e01d59df04ba57f66c95b7

11 years agoUpdate and add notifiers in create volume
jenny-shieh [Thu, 13 Jun 2013 22:04:59 +0000 (15:04 -0700)]
Update and add notifiers in create volume

1. Change status from 'creating' to 'available' when the volume is created
2. Add a notifier when it fails to create the volume

Implements: notifiers for create volume
Fixes: bug #1190754
Change-Id: I3a7d118630b32cfa7efb6bc8984418ca9836764a

11 years agoImported Translations from Transifex
OpenStack Jenkins [Fri, 14 Jun 2013 18:10:15 +0000 (18:10 +0000)]
Imported Translations from Transifex

Change-Id: Ifdb8f90abd6ece7e3cc47e27c0c4e8fd29e89b4d

11 years agoFix up the test framework
Michael Kerrin [Thu, 16 May 2013 08:10:27 +0000 (08:10 +0000)]
Fix up the test framework

When trying to test a bug the cinder test framework was
running all the tests when I just wanted one to run.

Instead of fixing this problem in nose I tried to move cinder to
testr. I copied a fair bit of code from nova to get this to work.
This way at least if some one makes an improvement to the nova
test framework cinder can improve here also.

Note that now all the tests a thread safe. Added a concurrency argument
to run_tests.sh that defaults to 1. You can specify your own level then
and take the risk of intermittent failures. Tell jenkins to use a
concurrency level of 1 to avoid failing gate jobs.

Note One of these tests is broken and I have disabled for now. There
is a bug for this here: https://bugs.launchpad.net/cinder/+bug/1173266

Note: cinder.api.openstack.FaultWrapper is deprecated and is causing
a circular import when I try and import cinder.tests.test_wsgi. This
is fixed by only importing the openstack.FaultWrapper during the
__init__ phase of the wsgi middleware.

Fixes: bug 1183434
Fixes: bug 1177924
Change-Id: I5e10b55c5b236eb81a6a3e0e9ea56af8ca4ef8e1

11 years agoRaise an error if iSCSI is not supported
Xavier Queralt [Fri, 14 Jun 2013 13:18:23 +0000 (15:18 +0200)]
Raise an error if iSCSI is not supported

Since the compute nodes may not have iSCSI support, volume drivers
requiring it will raise an error if the connector's initiator attribute
is not set when initializing the connection.

bug #1007084

Related to: I5da472e5013fdc0c733ecb12b919c1068873bdc6

Change-Id: I95d859c11cf81bf57cecf7af8b224cdbb71592d5

11 years agoRemove usage of locals() for formatting from cinder.api.*
Haomai Wang [Fri, 14 Jun 2013 07:11:29 +0000 (15:11 +0800)]
Remove usage of locals() for formatting from cinder.api.*

Using of locals() for formatting string is a nasty thing because:
1) It is not so clear as using explicit dicts
2) It could produce hidden errors during refactoring
3) Changing name of variable causes change in message
4) Creating a lot of unused variables

Fix bug 1171936

Change-Id: Id6a900899db328be067b8139a49c12ce802dd415

11 years agoImplement capability to extend existing volume.
John Griffith [Mon, 10 Jun 2013 20:26:57 +0000 (14:26 -0600)]
Implement capability to extend existing volume.

This patch adds the core components to implement extending
the size of an existing available volume.

Volume status must be available, and the format is:
    extend <vol-id> <new-size>

where new-size must be > current size.

Adding support to drivers will be handled in follow up
patches for each of the existing drivers.

Implements blueprint: volume-resize

Change-Id: I40026083e564ea2074757e11e13cd07cdae3e6cc

11 years agoMerge "Flatten Volume from Snapshot"
Jenkins [Fri, 14 Jun 2013 05:28:17 +0000 (05:28 +0000)]
Merge "Flatten Volume from Snapshot"

11 years agoMerge "Imported Translations from Transifex"
OpenStack Jenkins [Fri, 14 Jun 2013 05:28:14 +0000 (05:28 +0000)]
Merge "Imported Translations from Transifex"

11 years agoMerge "Replace FLAGS with cfg.CONF in volume"
Jenkins [Fri, 14 Jun 2013 02:52:49 +0000 (02:52 +0000)]
Merge "Replace FLAGS with cfg.CONF in volume"

11 years agoReplace utils.to_bytes() with strutils.to_bytes()
Zhongyue Luo [Fri, 14 Jun 2013 01:43:40 +0000 (09:43 +0800)]
Replace utils.to_bytes() with strutils.to_bytes()

The to_bytes() function have moved to oslo.
Replaced/removed the to_bytes() function with the one in strutils.

Change-Id: I53947b7a333057fec738a02f5643be59e563290d

11 years agoMerge "Fix various Sphinx warnings"
Jenkins [Fri, 14 Jun 2013 00:23:11 +0000 (00:23 +0000)]
Merge "Fix various Sphinx warnings"

11 years agoFlatten Volume from Snapshot
Mandell Degerness [Mon, 10 Jun 2013 22:02:28 +0000 (22:02 +0000)]
Flatten Volume from Snapshot

Implements: blueprint flatten-volume-from-snapshot

Change-Id: I77b0a9bf8cfbe4881a75909d2749d0c3f17561c9

11 years agoMerge "Replace FLAGS with cfg.CONF in other modules, unless tests"
Jenkins [Thu, 13 Jun 2013 19:06:16 +0000 (19:06 +0000)]
Merge "Replace FLAGS with cfg.CONF in other modules, unless tests"