]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/log
Ashley Penney [Wed, 30 Jul 2014 16:06:08 +0000 (12:06 -0400)]
Merge pull request #335 from mhaskel/fix_acceptance_tests
Fix broken acceptance tests.
Morgan Haskel [Wed, 30 Jul 2014 16:03:09 +0000 (12:03 -0400)]
Fix broken acceptance tests.
New fact was added that matched a regex breaking the always_apt_update
tests. Updated the tests to check for the apt_update exec, not just the
string apt_update.
Morgan Haskel [Tue, 29 Jul 2014 23:24:30 +0000 (19:24 -0400)]
Merge pull request #329 from spuder/spuder/lsbdist
Adds check to params.pp if lab-release is not installed
Morgan Haskel [Fri, 25 Jul 2014 22:20:06 +0000 (18:20 -0400)]
Prep for 1.6.0 release.
Ashley Penney [Fri, 25 Jul 2014 15:56:43 +0000 (11:56 -0400)]
Merge pull request #334 from mhaskel/1.5.x-merge
1.5.x merge
Morgan Haskel [Fri, 25 Jul 2014 15:53:53 +0000 (11:53 -0400)]
Merge remote-tracking branch 'upstream/1.5.x'
Daniele Sluijters [Thu, 17 Jul 2014 06:42:06 +0000 (08:42 +0200)]
Merge pull request #332 from zacharyalexstern/fix_readme_typo
Fix readme typo.
Zachary Alex Stern [Wed, 16 Jul 2014 22:01:02 +0000 (15:01 -0700)]
Fix readme typo.
Travis Fields [Tue, 15 Jul 2014 16:12:52 +0000 (09:12 -0700)]
Merge pull request #331 from apenney/152-release
Prepare a 1.5.2 release.
Ashley Penney [Tue, 15 Jul 2014 15:32:58 +0000 (11:32 -0400)]
Prepare a 1.5.2 release.
Daniel Friesen [Fri, 11 Jul 2014 21:33:15 +0000 (14:33 -0700)]
Fix mistake in my
0c2329b implementation.
Daniel Friesen [Thu, 10 Jul 2014 23:38:45 +0000 (16:38 -0700)]
Fix inconsistent $proxy_host handling in apt and apt::ppa.
- The default for $proxy_host is undef
- apt considers $proxy_set to be absent if $proxy_host is undef
- apt::ppa considers proxy_env to be empty if $proxy_host is false or ''
This results in apt::ppa to consider $proxy_host to be set when the default undef is used
breaking ppa resources because $proxy_env becomes:
[http_proxy=http://:8080, https_proxy=http://:8080]
Fix this by making both apt and apt::ppa consider $proxy_host to be unset when it is
any of false, '', or undef.
Spencer Owen [Thu, 10 Jul 2014 17:48:54 +0000 (11:48 -0600)]
Adds check to params.pp if lab-release is not installed
Adds spec test
If lab-release is not installed, then the end user sees a confusing/ vague message
Error: Unsupported lsbdistid () at /modules/apt/manifests/params.pp:52
It is common for docker containers to not include this package by default
After fix, the user sees a friendlier message if lab-release is not installed
Error: Unable to determine lsbdistid, is lsb-release installed? at /modules/apt/manifests/params.pp:52
Hunter Haugen [Wed, 9 Jul 2014 23:50:42 +0000 (16:50 -0700)]
Merge pull request #328 from mhaskel/1.5.1-prep
1.5.1 prep.
Morgan Haskel [Wed, 9 Jul 2014 23:34:12 +0000 (19:34 -0400)]
1.5.1 prep.
Daniele Sluijters [Wed, 9 Jul 2014 14:15:26 +0000 (16:15 +0200)]
Merge pull request #327 from adik/master
MODULES-780 Don't blow up on unicode characters.
Arkady Smirnov [Wed, 9 Jul 2014 11:06:40 +0000 (14:06 +0300)]
MODULES-780 Don't blow up on unicode characters.
Dave [Sun, 6 Jul 2014 03:09:06 +0000 (12:09 +0900)]
Update builddep.pp
Ashley Penney [Thu, 3 Jul 2014 21:43:27 +0000 (17:43 -0400)]
Merge pull request #324 from cmurphy/master
Add validate and lint tasks to travis script
Hunter Haugen [Thu, 3 Jul 2014 17:10:10 +0000 (10:10 -0700)]
Merge pull request #325 from apenney/merge
Merge
Ashley Penney [Thu, 3 Jul 2014 17:08:11 +0000 (13:08 -0400)]
Merge branch '1.5.x' into merge
Conflicts:
Gemfile
spec/acceptance/apt_key_provider_spec.rb
Colleen Murphy [Thu, 3 Jul 2014 16:53:35 +0000 (09:53 -0700)]
Add validate and lint tasks to travis script
Hunter Haugen [Mon, 30 Jun 2014 19:07:27 +0000 (12:07 -0700)]
Merge pull request #323 from cmurphy/master
Update Gemfile for .travis.yml defaults
Colleen Murphy [Mon, 30 Jun 2014 17:57:45 +0000 (10:57 -0700)]
Update Gemfile for .travis.yml defaults
Daniele Sluijters [Mon, 30 Jun 2014 16:59:10 +0000 (18:59 +0200)]
Merge pull request #322 from cmurphy/master
Synchronize .travis.yml
Colleen Murphy [Fri, 27 Jun 2014 17:52:08 +0000 (10:52 -0700)]
Synchronize .travis.yml
Colleen Murphy [Fri, 27 Jun 2014 16:27:52 +0000 (09:27 -0700)]
Update .sync.yml to support new .travis.yml configs
Daniele Sluijters [Fri, 27 Jun 2014 15:41:50 +0000 (17:41 +0200)]
Merge pull request #321 from raoulbhatia/squeeze-lts
Enable auto-update for Debian squeeze-lts
Daniele Sluijters [Fri, 27 Jun 2014 12:28:19 +0000 (14:28 +0200)]
Merge pull request #319 from cloudbuy/master
add facts showing available updates
Damien Churchill [Thu, 26 Jun 2014 13:50:11 +0000 (14:50 +0100)]
add facts showing available updates
Making use of the apt-check command from the 'update-notifier-common'
package (if available) display the number of available updates, number of
security updates as well as the update package names.
Raoul Bhatia [Thu, 26 Jun 2014 18:03:04 +0000 (20:03 +0200)]
Enable auto-update for Debian squeeze-lts
Quoting https://wiki.debian.org/LTS
Official security support for Debian GNU/Linux 6.0
(code name "Squeeze") has ended on 31 May 2014.
However long term support for the distribution
is going to be extended until February 2016,
i.e. five years after the initial release.
See https://wiki.debian.org/LTS for more details.
Morgan Haskel [Thu, 26 Jun 2014 17:55:38 +0000 (13:55 -0400)]
Merge pull request #318 from daenney/unicode-fix
MODULES-780 Don't blow up on unicode characters.
Ashley Penney [Thu, 26 Jun 2014 17:53:18 +0000 (13:53 -0400)]
Merge pull request #316 from cmurphy/master
Start synchronizing module files
Daniele Sluijters [Thu, 26 Jun 2014 12:26:02 +0000 (14:26 +0200)]
MODULES-780 Don't blow up on unicode characters.
Gotta love the difference between Ruby 1.8.7 not caring and every
subsequent version exploding.
Daniele Sluijters [Thu, 26 Jun 2014 12:29:36 +0000 (14:29 +0200)]
Merge pull request #304 from innyso/allow_url_for_key_server
Allow url for key server
Colleen Murphy [Thu, 26 Jun 2014 00:23:12 +0000 (17:23 -0700)]
Sync files
Colleen Murphy [Wed, 25 Jun 2014 23:33:47 +0000 (16:33 -0700)]
Add configuration file for modulesync
https://github.com/puppetlabs/modulesync
Daniele Sluijters [Mon, 23 Jun 2014 06:54:38 +0000 (08:54 +0200)]
Merge pull request #315 from juniorsysadmin/apt-source-example-with-comment-parameter
Update apt::source example in README.md for #311
juniorsysadmin [Mon, 23 Jun 2014 02:47:52 +0000 (12:47 +1000)]
Update apt::source example in README.md for #311
This patch updates the apt::source example to include a comment (see #311)
Morgan Haskel [Thu, 19 Jun 2014 13:50:54 +0000 (09:50 -0400)]
Merge pull request #311 from juniorsysadmin/custom-comment-for-sources-list
Allow for custom comment in sources.list file
Hunter Haugen [Wed, 11 Jun 2014 17:38:36 +0000 (10:38 -0700)]
Merge pull request #312 from mhaskel/test_osx_graceful_failure
Test osx graceful failure
Morgan Haskel [Wed, 11 Jun 2014 17:31:53 +0000 (13:31 -0400)]
Add test case to ensure graceful failure on OSX.
juniorsysadmin [Tue, 10 Jun 2014 06:42:06 +0000 (16:42 +1000)]
Allow custom comment for sources list
innyso [Mon, 9 Jun 2014 23:09:28 +0000 (00:09 +0100)]
Adding dash to key_server validate regex
Dashes should be allow when defining domain or url for key_server. Rspec
test cases are included to make sure no malform domain name or url are
used.
Travis Fields [Mon, 9 Jun 2014 15:42:57 +0000 (08:42 -0700)]
Merge pull request #309 from apenney/pin-rspec
Pin rspec
Ashley Penney [Mon, 9 Jun 2014 15:29:29 +0000 (11:29 -0400)]
Pin rspec to 2.x.
Hunter Haugen [Wed, 4 Jun 2014 18:03:19 +0000 (11:03 -0700)]
Merge pull request #306 from apenney/fix-changelog
Remove claims of support.
Ashley Penney [Wed, 4 Jun 2014 17:54:22 +0000 (13:54 -0400)]
Remove claims of support.
Morgan Haskel [Wed, 21 May 2014 23:26:07 +0000 (19:26 -0400)]
Update PE version requirements.
innyso [Thu, 29 May 2014 00:01:37 +0000 (01:01 +0100)]
Allow url or domain name for key_server parameter
As some places dont have port 11371 open, they are required to use URL as
key_server instead of domain name therefore adding the capability to use URL or
domain name as key_server parameter
Ashley Penney [Fri, 30 May 2014 16:46:14 +0000 (12:46 -0400)]
Merge branch '1.5.x' of https://github.com/puppetlabs/puppetlabs-apt into 1.5.x
Morgan Haskel [Thu, 29 May 2014 17:07:38 +0000 (13:07 -0400)]
Merge pull request #303 from apenney/fix-ubuntu-10-tests
Fix the tests for Ubuntu 10.04.
Morgan Haskel [Thu, 29 May 2014 17:07:38 +0000 (13:07 -0400)]
Merge pull request #303 from apenney/fix-ubuntu-10-tests
Fix the tests for Ubuntu 10.04.
Ashley Penney [Thu, 29 May 2014 17:05:51 +0000 (13:05 -0400)]
Fix the tests for Ubuntu 10.04.
Ashley Penney [Thu, 22 May 2014 17:42:15 +0000 (10:42 -0700)]
Merge pull request #297 from frconil/sourceslist-comment
adding notice on top of sourceslist files
Ashley Penney [Thu, 22 May 2014 17:41:57 +0000 (10:41 -0700)]
Merge pull request #298 from frconil/fix-apt-pin-regex
Fixed regex to follow APT requirements
Ashley Penney [Wed, 21 May 2014 23:29:26 +0000 (16:29 -0700)]
Merge pull request #301 from mhaskel/1.5.0-prep
1.5.0 prep
Morgan Haskel [Wed, 21 May 2014 23:26:07 +0000 (19:26 -0400)]
Update PE version requirements.
Ashley Penney [Wed, 21 May 2014 18:19:04 +0000 (11:19 -0700)]
Merge branch '1.5.x' of https://github.com/puppetlabs/puppetlabs-apt into 1.5.x
Ashley Penney [Wed, 21 May 2014 17:39:17 +0000 (10:39 -0700)]
Merge pull request #300 from apenney/fix-tests
Block this from running on unsupported platforms.
Ashley Penney [Wed, 21 May 2014 17:39:17 +0000 (10:39 -0700)]
Merge pull request #300 from apenney/fix-tests
Block this from running on unsupported platforms.
Ashley Penney [Wed, 21 May 2014 17:38:24 +0000 (10:38 -0700)]
Block this from running on unsupported platforms.
Hunter Haugen [Tue, 20 May 2014 20:27:40 +0000 (13:27 -0700)]
Merge pull request #299 from mhaskel/1.5.0-prep
1.5.0 prep
Morgan Haskel [Tue, 20 May 2014 20:24:28 +0000 (16:24 -0400)]
Fixing lint and adding the trusty nodeset (not sure how that was missed)
François Conil [Mon, 19 May 2014 05:33:06 +0000 (15:33 +1000)]
Fixed regex to actually follow APT requirements
Previous implementation would overwrite the file name and
potentially include characters that would cause apt to ignore
the pref file
François Conil [Mon, 19 May 2014 05:12:36 +0000 (15:12 +1000)]
adding notice on top of sourceslist files
Useful to figure out what is managed by puppet and what isn't when
not setting up the option to purge sourceslist files
Ashley Penney [Thu, 15 May 2014 18:58:49 +0000 (14:58 -0400)]
Claim PE3.3 support.
Morgan Haskel [Thu, 15 May 2014 17:45:46 +0000 (13:45 -0400)]
Merge pull request #287 from oc243/master
Implement fancy progress bars configuration.
Ashley Penney [Wed, 14 May 2014 20:28:06 +0000 (16:28 -0400)]
Prepare for 1.5.0.
Ashley Penney [Wed, 14 May 2014 17:18:18 +0000 (13:18 -0400)]
Merge pull request #294 from apenney/14x-merge
14x merge
Ashley Penney [Wed, 14 May 2014 17:17:19 +0000 (13:17 -0400)]
Merge branch '1.4.x' into 14x-merge
Oliver Chick [Thu, 24 Apr 2014 07:52:12 +0000 (08:52 +0100)]
Implement fancy progress bars configuration.
Ubuntu 14.04 ships with apt 0.9.15, has a ``fancy progress bar'', which
is a green bar that shows at the bottom of the terminal showing progress
throughout install.
This patch enables the progress bar, which is usually done by running
echo 'Dpkg::Progress-Fancy "1";' > /etc/apt/apt.conf.d/99progressbar
Ashley Penney [Thu, 8 May 2014 14:44:11 +0000 (10:44 -0400)]
Merge pull request #292 from daenney/test-puppet-35
Drop testing on 3.3, add 3.5.
Daniele Sluijters [Thu, 8 May 2014 07:54:08 +0000 (09:54 +0200)]
Drop testing on 3.3, add 3.5.
Ashley Penney [Mon, 5 May 2014 15:54:52 +0000 (11:54 -0400)]
Merge pull request #290 from dpnl87/wheezy-preference-fix
Do not add bogus line to apt preference file on Debian Wheezy
Daniel Paulus [Mon, 5 May 2014 12:39:25 +0000 (14:39 +0200)]
Add dpaulus to the contributors list
Daniel Paulus [Mon, 5 May 2014 10:06:39 +0000 (12:06 +0200)]
Some code cleaning
Daniel Paulus [Mon, 5 May 2014 09:57:42 +0000 (11:57 +0200)]
Fixed acceptance spec and add debian nodeset
Daniel Paulus [Fri, 2 May 2014 22:13:17 +0000 (00:13 +0200)]
Testing if we are not touching the preference file when purge mode is off
Daniel Paulus [Fri, 2 May 2014 22:06:23 +0000 (00:06 +0200)]
Updated readme to indicate danger of setting preference purge options
Daniel Paulus [Fri, 2 May 2014 21:35:54 +0000 (23:35 +0200)]
Remove the preference file for all supported platforms when in purge mode
Daniel Paulus [Fri, 2 May 2014 15:56:06 +0000 (17:56 +0200)]
Do not add bogus line to apt preference file on Debian Wheezy
Ashley Penney [Wed, 23 Apr 2014 00:46:55 +0000 (20:46 -0400)]
Merge pull request #286 from apenney/fix-for-post-wheezy
unattended_upgrades: Fix matching security archive
Daniele Sluijters [Thu, 27 Mar 2014 12:51:08 +0000 (13:51 +0100)]
unattended_upgrades: Fix matching security archive
The default configuration we were writing for Debian was only working
for Squeeze, from Wheezy and onwards this wasn't working anymore. This
has to do with the fact that we should now be using Origins-Pattern
according to the unattended-upgrades docs. However, Ubuntu didn't
entirely get with the program yet...
This change reflects the defaults that unattended-upgrade installs on
every platform we support. In order to do so the unattended-upgrades
Debian archive for Squeeze, Wheezy, Lucid, Precise and Trusty were
downloaded and the default /etc/apt/apt.conf.d/50unattended-upgrades
checked for its content with regard to using Allow-Origins or
Origins-Pattern.
Fixes #277
Ashley Penney [Thu, 17 Apr 2014 17:00:50 +0000 (13:00 -0400)]
Merge pull request #285 from blkperl/fix_metadata
Fix metadata.json file
Ashley Penney [Mon, 3 Mar 2014 21:39:10 +0000 (21:39 +0000)]
Add back in missing fields to work around Puppet bug.
(cherry picked from commit
dc472717163d30a4463f687a577238ec2539601c )
Ashley Penney [Fri, 28 Feb 2014 15:34:08 +0000 (15:34 +0000)]
Prepare metadata for supported module release.
(cherry picked from commit
ab03a989df37df3660f0916519d0f78f7ab73a13 )
Ashley Penney [Sat, 12 Apr 2014 18:37:40 +0000 (14:37 -0400)]
Merge pull request #283 from johanfleury/master
Change proxy's configuration file to be consistent with other config files in apt.conf.d
Johan Fleury [Fri, 11 Apr 2014 06:35:25 +0000 (08:35 +0200)]
Writing proxy configuration in apt.conf.d/01proxy.
This commit changes the proxy file name to be more consistent with other files
in `apt.conf.d`. The old file (`apt.conf.d/proxy`) is removed.
Tests has been updated.
Lauren Rother [Mon, 7 Apr 2014 17:56:20 +0000 (10:56 -0700)]
Add security warning re: short keys
(cherry picked from commit
d7da1cef383663bb2ecee3d8afa612aea74219f7 )
Ashley Penney [Mon, 7 Apr 2014 18:06:47 +0000 (14:06 -0400)]
Merge pull request #282 from laurenrother/security
Add security warning re: short keys
Lauren Rother [Mon, 7 Apr 2014 17:56:20 +0000 (10:56 -0700)]
Add security warning re: short keys
Ashley Penney [Thu, 3 Apr 2014 17:59:51 +0000 (13:59 -0400)]
Merge pull request #280 from daenney/fix-pin-comments
Fix pin comments
Ashley Penney [Thu, 3 Apr 2014 17:59:15 +0000 (13:59 -0400)]
Merge pull request #281 from daenney/unattended-upgrades-squeeze-origins
unattended-upgrades: Fix origins for Squeeze.
Daniele Sluijters [Wed, 2 Apr 2014 09:17:04 +0000 (11:17 +0200)]
unattended-upgrades: Fix origins for Squeeze.
Because Squeeze is now oldstable we need to add an oldstable line too
otherwise security updates won't be picked up. This is still because we
can't match on codename.
Daniele Sluijters [Fri, 28 Mar 2014 07:49:18 +0000 (08:49 +0100)]
pin: caller_module_name is not a topscope variable
Daniele Sluijters [Fri, 28 Mar 2014 07:47:19 +0000 (08:47 +0100)]
pin: Fix the template.
In APT preferences files the only allowed comments are lines that start
with `Explanation:`, commented lines that start with a # trigger a
myriad of interesting bugs. This is considered a feature of APT.
Because we're only ever writing a single file at a time with only a #
comment at the top we were getting away with this but it shouldn't be
there in the first place.
Ashley Penney [Thu, 27 Mar 2014 16:43:27 +0000 (12:43 -0400)]
Merge pull request #279 from apenney/fix-spacing
Small patch to fix the spacing that makes lint fail.
Ashley Penney [Thu, 27 Mar 2014 16:40:36 +0000 (16:40 +0000)]
Small patch to fix the spacing that makes lint fail.
Ashley Penney [Thu, 27 Mar 2014 12:59:51 +0000 (08:59 -0400)]
Merge pull request #278 from daenney/fix-unattended-upgrades
unattended_upgrades: Fix matching security archive