]> review.fuel-infra Code Review - openstack-build/cinder-build.git/log
openstack-build/cinder-build.git
9 years agoRemoving archaic references
David Medberry [Sat, 20 Jun 2015 12:34:35 +0000 (06:34 -0600)]
Removing archaic references

This document was originally imported from Nova. Removing some of the
old references to Quickstart and Hypervisors.

http://docs.openstack.org/developer/cinder/devref/development.environment.html
has a dangling link to a ../quickstart document (removed long ago.)

Change-Id: If70f4cb45034e78304cd8c5c5d5deccb692d19e7
Closes-bug: #1225822

9 years agoMerge "Revert "Disable backup progress notifications for unit tests""
Jenkins [Sat, 20 Jun 2015 00:17:24 +0000 (00:17 +0000)]
Merge "Revert "Disable backup progress notifications for unit tests""

9 years agoMerge "Update version for Liberty"
Jenkins [Fri, 19 Jun 2015 23:52:22 +0000 (23:52 +0000)]
Merge "Update version for Liberty"

9 years agoMerge "VMware: Remove unused methods"
Jenkins [Fri, 19 Jun 2015 23:08:01 +0000 (23:08 +0000)]
Merge "VMware: Remove unused methods"

9 years agoMerge "Remove the hardcoded concurrency limit for ostestr"
Jenkins [Fri, 19 Jun 2015 21:00:13 +0000 (21:00 +0000)]
Merge "Remove the hardcoded concurrency limit for ostestr"

9 years agoMerge "Dell SC Removed _find_domain and associated tests"
Jenkins [Fri, 19 Jun 2015 19:50:15 +0000 (19:50 +0000)]
Merge "Dell SC Removed _find_domain and associated tests"

9 years agoMerge "Ceph driver support retries on rados_connect_timeout"
Jenkins [Fri, 19 Jun 2015 19:10:23 +0000 (19:10 +0000)]
Merge "Ceph driver support retries on rados_connect_timeout"

9 years agoRemove the hardcoded concurrency limit for ostestr
John Griffith [Fri, 19 Jun 2015 18:32:01 +0000 (12:32 -0600)]
Remove the hardcoded concurrency limit for ostestr

ostestr by default uses concurrency = ncpu.

This caused all sorts of things to blow up in Cinder
when one got over 6 cpus.  Since the initial merge a
patch has landed that appears to fix the issues, and
we now run reliably at 8 and even 12 cpus.

This patch removes the hard coded concurrency=6 setting
from tox.ini

Change-Id: I483e53acaf1bb71deeba20d6c81184112cbcb046

9 years agoRevert "Disable backup progress notifications for unit tests"
Eric Harney [Fri, 19 Jun 2015 14:25:50 +0000 (10:25 -0400)]
Revert "Disable backup progress notifications for unit tests"

This reverts commit e5f6ed69e0031900f97da185b5363ebd3dd60c0c.

This was an attempted workaround for the notifier issue.
It's not needed now that the fake notifier has been fixed,
so restore the default behavior.

Also remove conf imports which were added in commit d9b9ac
to fix commit e5f6ed.

Related-Bug: #1412513

Change-Id: Id0d547e3c2faa8c1a0555e28cdb2e9d83956c1ac

9 years agoMerge "Backup object"
Jenkins [Fri, 19 Jun 2015 18:00:20 +0000 (18:00 +0000)]
Merge "Backup object"

9 years agoMerge "Storwize: remove the useless method check_copy_ok"
Jenkins [Fri, 19 Jun 2015 17:20:55 +0000 (17:20 +0000)]
Merge "Storwize: remove the useless method check_copy_ok"

9 years agoMerge "Port LeftHand driver to use ABCMeta driver model"
Jenkins [Fri, 19 Jun 2015 17:13:59 +0000 (17:13 +0000)]
Merge "Port LeftHand driver to use ABCMeta driver model"

9 years agoMerge "rbd driver in cinder does not manage glance images multi-location"
Jenkins [Fri, 19 Jun 2015 16:35:55 +0000 (16:35 +0000)]
Merge "rbd driver in cinder does not manage glance images multi-location"

9 years agoMerge "Tests: Make fake_notifier per-instance"
Jenkins [Fri, 19 Jun 2015 15:38:14 +0000 (15:38 +0000)]
Merge "Tests: Make fake_notifier per-instance"

9 years agoMerge "Adds FC and ISCSI Cinder drivers for HPMSA Storage Arrays"
Jenkins [Fri, 19 Jun 2015 12:44:20 +0000 (12:44 +0000)]
Merge "Adds FC and ISCSI Cinder drivers for HPMSA Storage Arrays"

9 years agoTests: Make fake_notifier per-instance
Eric Harney [Thu, 18 Jun 2015 22:06:54 +0000 (18:06 -0400)]
Tests: Make fake_notifier per-instance

Tests have been failing because multiple threads modify the
same global NOTIFICATIONS list.  Move the notification storage
to be per-test instance, which is what the tests assume.

This has been broken for a while, but made more obvious by
recent changes to parallelize tests.

Also remove all the extra reset calls we added to work around
this problem over time.

Co-authored-by: Gorka Eguileor <geguileo@redhat.com>
Change-Id: Ib5a67c097ef548dc346751ad51b61fdceaf8e3a8
Partial-Bug: #1259463
Closes-Bug: #1412513

9 years agoPort LeftHand driver to use ABCMeta driver model
Kurt Martin [Fri, 19 Jun 2015 00:30:38 +0000 (17:30 -0700)]
Port LeftHand driver to use ABCMeta driver model

Use new ABCMeta driver model for LeftHand driver.
Implements: blueprint abc-driver-update

Change-Id: I4acd1cd711b8718340abd08fdabacb2e4b713b73

9 years agoMerge "Disable profiler for unit tests"
Jenkins [Thu, 18 Jun 2015 22:52:13 +0000 (22:52 +0000)]
Merge "Disable profiler for unit tests"

9 years agoDisable profiler for unit tests
Eric Harney [Thu, 18 Jun 2015 17:04:43 +0000 (13:04 -0400)]
Disable profiler for unit tests

osprofiler should not run for unit tests.  This makes stack
traces harder to debug, and generally complicates things, with
no benefit.

The backup tests were already doing this, so port that
method to the base Cinder test class.

Closes-Bug: #1394785
Closes-Bug: #1447400

Change-Id: Ifcaaf365aaab24c6fa2a6eca58f546860124f1fc

9 years agoUse a hard-coded project_id in racy cinder.tests.unit.test_volume tests
Matt Riedemann [Thu, 18 Jun 2015 15:16:52 +0000 (08:16 -0700)]
Use a hard-coded project_id in racy cinder.tests.unit.test_volume tests

Since concurrent unit test runs have been turned on with ostestr there
are races with the notifications causing the assertions in
test_volume.py tests to fail.

A few attempts have been made at writing an elastic-recheck query to
identify the failures but they are too generic, e.g. querying for
"fake_notifier.NOTIFICATIONS" or "MismatchError 0 != ", which could hit
on anything that fails with those, e.g. anything that uses
"self.assertEqual(0, " in the code could hit that kind of query - and we
want to avoid those types of queries running against changes in the
check queue since they could mask legitimate test failures.

So we add something unique in these tests to identify them from other
test failures in Cinder by using a hard-coded uuid for the project_id so
that if we have an assertion failure with notifications, the
notification payload is dumped (due to commit
4bbe1c87e26150c62e1dc8a2a5b8979896c1ddd9) and we can query on the
assertion failure plus the hard-coded project_id used only in these
tests.

Related-Bug: #1412513

Change-Id: I57f597a1bb2fdfeb24c17ac9020cc96f1ebf3fdd

9 years agoMerge "Add missing Jinja2 to requirements.txt"
Jenkins [Thu, 18 Jun 2015 13:27:16 +0000 (13:27 +0000)]
Merge "Add missing Jinja2 to requirements.txt"

9 years agoVMware: Remove unused methods
Vipin Balachandran [Sat, 10 Jan 2015 17:49:16 +0000 (23:19 +0530)]
VMware: Remove unused methods

Patch to remove unused datastore selection methods in vmdk module.

Change-Id: I96f651081a5f0f5747e0bb1fb49028422fd4a4f9

9 years agoMerge "Sync 'report' from oslo-incubator"
Jenkins [Thu, 18 Jun 2015 09:23:54 +0000 (09:23 +0000)]
Merge "Sync 'report' from oslo-incubator"

9 years agoBackup object
Michal Dulko [Wed, 3 Jun 2015 12:25:26 +0000 (14:25 +0200)]
Backup object

This patch adds VersionedObjects abstraction layer to volume backups.
The object derives from CinderObjectDictCompat, so it supports both
object (obj.prop) and dict (obj['prop']) syntax to access properties.
Complete move to object notation will be made in a follow up clean up
patch.

Co-Authored-By: Grzegorz Grasza <grzegorz.grasza@intel.com>
Change-Id: Icff37261b367463b71a1268be16f9c97f595bf0c
Partial-Implements: blueprint cinder-objects

9 years agoAdd missing Jinja2 to requirements.txt
Michal Dulko [Thu, 18 Jun 2015 07:27:26 +0000 (09:27 +0200)]
Add missing Jinja2 to requirements.txt

Recently merged commit I5bbdc0f97db9b0ebd7b48e50ab7869e2ca33aead got in
a dependency on Jinja2 library without adding it to requirements.txt.
The gate was running fine, because Nova already has it in it's
requirements. Problem uncovers when we install DevStack with
--use-venv=True option.

Change-Id: If053c4724d9d0264e0f3b27a995a2b619cf6f515
Closes-Bug: 1466361

9 years agoStorwize: remove the useless method check_copy_ok
Qian Gao [Thu, 18 Jun 2015 05:57:02 +0000 (22:57 -0700)]
Storwize: remove the useless method check_copy_ok

The method check_copy_ok still remains after the code refactor.
However, it is never used. This patch proposes to remove it.

Change-Id: I7cb8611fe242300d28d90520ec3c2867385f9fec
Closes-Bug: #1466321

9 years agoMerge "ScaleIO: Fix broken format string"
Jenkins [Wed, 17 Jun 2015 23:09:26 +0000 (23:09 +0000)]
Merge "ScaleIO: Fix broken format string"

9 years agoUpdate version for Liberty
Doug Hellmann [Tue, 16 Jun 2015 19:49:14 +0000 (19:49 +0000)]
Update version for Liberty

Update the version for Liberty, switching from date-based versioning
to pre-versioning using SemVer. See
http://lists.openstack.org/pipermail/openstack-dev/2015-May/065211.html
and
http://lists.openstack.org/pipermail/openstack-dev/2015-June/067082.html
for details.

Change-Id: I6a35fa0dda798fad93b804d00a46af80f08d475c

9 years agoMerge "Fix namespace issue in generate_sample.sh"
Jenkins [Wed, 17 Jun 2015 21:07:57 +0000 (21:07 +0000)]
Merge "Fix namespace issue in generate_sample.sh"

9 years agoScaleIO: Fix broken format string
Eric Harney [Wed, 17 Jun 2015 20:41:45 +0000 (16:41 -0400)]
ScaleIO: Fix broken format string

Closes-Bug: #1466219

Change-Id: I0ce2eeb2ad85e6c36adf5505ef662efdf5b14f30

9 years agoSync 'report' from oslo-incubator
Eric Harney [Wed, 17 Jun 2015 20:00:35 +0000 (16:00 -0400)]
Sync 'report' from oslo-incubator

Needed to fix guru meditation report for Windows.
We landed an outdated 'report' module recently.

Add report.[generators,models,views] to
openstack-common.conf.

Oslo source: c4c7dd28 Updated from global requirements

Closes-Bug: #1286528

Change-Id: Ib33542718176241663c0e61605acbf4e941e2ca9

9 years agoMerge "Replace basestring with six.string_types"
Jenkins [Wed, 17 Jun 2015 18:56:22 +0000 (18:56 +0000)]
Merge "Replace basestring with six.string_types"

9 years agoMerge "LVM add multiattach flag capability"
Jenkins [Wed, 17 Jun 2015 18:51:45 +0000 (18:51 +0000)]
Merge "LVM add multiattach flag capability"

9 years agoMerge "Switch to oslo.policy 0.3.0"
Jenkins [Wed, 17 Jun 2015 18:49:22 +0000 (18:49 +0000)]
Merge "Switch to oslo.policy 0.3.0"

9 years agoCeph driver support retries on rados_connect_timeout
Ivan Kolodyazhny [Thu, 11 Jun 2015 10:55:28 +0000 (13:55 +0300)]
Ceph driver support retries on rados_connect_timeout

Added retry feature when connection to Ceph cluster failed. This patch
introduces new config options rados_connection_retries and
rados_connection_interval to configure retries due to
the rados_connect_timeout.

DocImpact
Change-Id: Ice65fc40e9bd94805700f64397caf856982fa320
Closes-Bug: #1462970

9 years agoDell SC Removed _find_domain and associated tests
Tom Swanson [Tue, 16 Jun 2015 16:01:58 +0000 (11:01 -0500)]
Dell SC Removed _find_domain and associated tests

Dell StorageCenterApi._find_domain was ununsed and so removed. The
associated tests were also removed.

In addition some other tests mocked _find_domains but called the mock
mock_find_domain.  Changed that to mock_find_domains.

Change-Id: Ieee96064bbc74eae8a8c961ade5c8dfb9615eb1a

9 years agoMerge "Add volume drivers for Infortrend Storage"
Jenkins [Wed, 17 Jun 2015 17:31:10 +0000 (17:31 +0000)]
Merge "Add volume drivers for Infortrend Storage"

9 years agoMerge "Refactor API create_volume flow"
Jenkins [Wed, 17 Jun 2015 17:29:13 +0000 (17:29 +0000)]
Merge "Refactor API create_volume flow"

9 years agoMerge "Tintri driver to manage existing backend storage objects"
Jenkins [Wed, 17 Jun 2015 17:26:16 +0000 (17:26 +0000)]
Merge "Tintri driver to manage existing backend storage objects"

9 years agoMerge "Add config option to set max_volume_size_limit"
Jenkins [Wed, 17 Jun 2015 16:44:29 +0000 (16:44 +0000)]
Merge "Add config option to set max_volume_size_limit"

9 years agoLVM add multiattach flag capability
Walter A. Boring IV [Thu, 11 Jun 2015 17:07:23 +0000 (10:07 -0700)]
LVM add multiattach flag capability

This patch adds reporting of the multiattach capability
in the lvm driver.   Currently the Cinder scheduler does filtering
on hosts at create time for the --allow-multiattach option being
passed into the create request from the client.   In order for someone
to be able to create an LVM volume that can do multiattach, the LVM
driver needs to report the capability.

This patch's purpose is to allow LVM volumes to be multiattachable
for the folks working on the Nova patches to get Nova to do multiattach.
Without this patch, they can't do end to end testing.

Change-Id: I91942569a12d7c7637c7d9ffb8bbff0daeaf6a97

9 years agoMerge "Adds FC and ISCSI Cinder drivers for Lenovo Storage Arrays"
Jenkins [Wed, 17 Jun 2015 13:37:02 +0000 (13:37 +0000)]
Merge "Adds FC and ISCSI Cinder drivers for Lenovo Storage Arrays"

9 years agoAdd volume drivers for Infortrend Storage
Lee [Fri, 24 Apr 2015 07:50:20 +0000 (15:50 +0800)]
Add volume drivers for Infortrend Storage

Infortrend implement ISCSI and FC volume drivers for
EonStor DS product.
It manages storage by Infortrend CLI tool.

common_cli.py implements the basic Cinder Driver API.
infortrend_fc_cli.py and infortrend_iscsi_cli.py use them to
provide FC and iSCSI specific support.

Support features:
- Volume Create/Delete
- Volume Attach/Detach
- Snapshot Create/Delete
- Create Volume from Snapshot
- Get Volume Stats
- Copy Image to Volume
- Copy Volume to Image
- Clone Volume
- Extend Volume

Change-Id: I830c5a48a5fb85707f02396b4634825e27455e8a
Implements: blueprint infortrend-iscsi-fc-volume-driver

9 years agoMerge "Port remote_fs driver to use new driver model"
Jenkins [Wed, 17 Jun 2015 09:24:21 +0000 (09:24 +0000)]
Merge "Port remote_fs driver to use new driver model"

9 years agoUpdated from global requirements
OpenStack Proposal Bot [Wed, 17 Jun 2015 00:34:25 +0000 (00:34 +0000)]
Updated from global requirements

Change-Id: I66c535760b7948ab0b6f7a7da3a0c5f5debaa75c

9 years agoMerge "Volume driver for HP XP storage"
Jenkins [Wed, 17 Jun 2015 00:12:14 +0000 (00:12 +0000)]
Merge "Volume driver for HP XP storage"

9 years agoAdds FC and ISCSI Cinder drivers for Lenovo Storage Arrays
nikeshm [Wed, 3 Jun 2015 03:19:45 +0000 (08:49 +0530)]
Adds FC and ISCSI Cinder drivers for Lenovo Storage Arrays

These drivers depend upon DotHill Cinder drivers.
Using inheritance, we are able to reuse a lot of
DotHill cinder drivers source code.

Change-Id: Ica8631d6954898dbd90a71cc78625bb2aa3b5632
Co-Authored-By: Gauvain Pocentek<gauvain.pocentek@objectif-libre.com>
Implements: blueprint lenovo-fc-iscsi-cinder-driver

9 years agoAdds FC and ISCSI Cinder drivers for HPMSA Storage Arrays
nikeshm [Tue, 2 Jun 2015 17:18:46 +0000 (22:48 +0530)]
Adds FC and ISCSI Cinder drivers for HPMSA Storage Arrays

These drivers depend upon DotHill Cinder drivers.
Using inheritance, we are able to reuse a lot of
DotHill cinder drivers source code.

Implements: blueprint hp-msa-fc-iscsi-cinder-driver
Co-Authored-By: Gauvain Pocentek<gauvain.pocentek@objectif-libre.com>
Change-Id: I21184872d1eb3838adc47fe9027de12a1702465d

9 years agoMerge "Fix broken export commands on block_device driver"
Jenkins [Tue, 16 Jun 2015 22:34:44 +0000 (22:34 +0000)]
Merge "Fix broken export commands on block_device driver"

9 years agoReplace basestring with six.string_types
Victor Stinner [Wed, 10 Jun 2015 12:32:41 +0000 (14:32 +0200)]
Replace basestring with six.string_types

basestring type is gone in Python 3, use six.string_types to make Cinder code
compatible with Python 3.

This patch was generated by the basestring operation of the sixer tool:
https://pypi.python.org/pypi/sixer

Blueprint cinder-python3
Change-Id: Ie1aedf1cbb9d3e54a996321cd586b875e69ac85a

9 years agoMerge "Replace dit.itervalues() with dict.values()"
Jenkins [Tue, 16 Jun 2015 20:20:13 +0000 (20:20 +0000)]
Merge "Replace dit.itervalues() with dict.values()"

9 years agoMerge "Rewrite code merging two dictionaries"
Jenkins [Tue, 16 Jun 2015 20:19:57 +0000 (20:19 +0000)]
Merge "Rewrite code merging two dictionaries"

9 years agoMerge "Update SolidFire to use target driver model"
Jenkins [Tue, 16 Jun 2015 19:51:14 +0000 (19:51 +0000)]
Merge "Update SolidFire to use target driver model"

9 years agoFix broken export commands on block_device driver
John Griffith [Tue, 16 Jun 2015 19:15:43 +0000 (13:15 -0600)]
Fix broken export commands on block_device driver

When I implemented the new target driver code the
methods used for LVM were copy pasted:
 commit 9651f547147188645942466602c92cce06666483

I screwed this up because the block_device driver
doesn't use LVM at all.

This patch sets it back the way it should be and just
uses the local dev file of the whole disk.

Change-Id: Ife88d5597df27dcd668a9a361bebccbc840ca2d4
Closes-Bug: #1465819

9 years agoSwitch to oslo.policy 0.3.0
Ivan Kolodyazhny [Tue, 9 Jun 2015 11:17:30 +0000 (14:17 +0300)]
Switch to oslo.policy 0.3.0

Use graduated oslo.policy instead of sync with oslo-incubator code.

Co-Authored-By: Ivan Kolodyazhny <e0ne@e0ne.info>
Change-Id: Ibb295830ac6abde9317c2549f75c1780ac454125
Closes-Bug: #1421863
Partial-Bug: #1458945

9 years agoAdd config option to set max_volume_size_limit
Rakesh Mishra [Tue, 26 May 2015 20:54:20 +0000 (02:24 +0530)]
Add config option to set max_volume_size_limit

There is a need to limit maximum size of a volume to levels
that the storage infrastructure can handle.
Setting a maximum limit on size of a volume also prevents
a tenant from creating large volumes that have not been tested
and certified to satisfy SLA objectives.

This feature allows admin to set volume size limit for a tenant.
Get default value for volume size limit via config.
The defaults will either come from the default values
set in the quota configuration option or via cinder.conf
if the user has configured default values for quotas there.

The per_volume_size_limit defaults to -1["No Limit"] always
unless changed in cinder.conf by admin

Change-Id: Ieb5c087ca7a33d22342470ea790a0c979a6244ea
Implements: blueprint cinder-quota-define-per-volume

9 years agoMove DRBD tests into tests/unit
Eric Harney [Tue, 16 Jun 2015 17:06:47 +0000 (13:06 -0400)]
Move DRBD tests into tests/unit

We've reorganized since the original driver code was
written, move this into the right directory.

Change-Id: I88b970e2726191c8cd795c5ddbb64784a465db65

9 years agoMerge "Introduce Guru Meditation Reports into Cinder"
Jenkins [Tue, 16 Jun 2015 16:53:06 +0000 (16:53 +0000)]
Merge "Introduce Guru Meditation Reports into Cinder"

9 years agoMerge "Use correct rtslib namespace for newer versions"
Jenkins [Tue, 16 Jun 2015 16:17:05 +0000 (16:17 +0000)]
Merge "Use correct rtslib namespace for newer versions"

9 years agoMerge "Pass proxy environment variables to tox"
Jenkins [Tue, 16 Jun 2015 15:46:08 +0000 (15:46 +0000)]
Merge "Pass proxy environment variables to tox"

9 years agoMerge "Replace xrange() with six.moves.range()"
Jenkins [Tue, 16 Jun 2015 15:45:58 +0000 (15:45 +0000)]
Merge "Replace xrange() with six.moves.range()"

9 years agoMerge "Fix Python 3 issues in utils"
Jenkins [Tue, 16 Jun 2015 15:44:13 +0000 (15:44 +0000)]
Merge "Fix Python 3 issues in utils"

9 years agoMerge "Drop L suffix from long integers"
Jenkins [Tue, 16 Jun 2015 15:41:36 +0000 (15:41 +0000)]
Merge "Drop L suffix from long integers"

9 years agoMerge "Re-add DRBD driver"
Jenkins [Tue, 16 Jun 2015 14:51:36 +0000 (14:51 +0000)]
Merge "Re-add DRBD driver"

9 years agoMerge "Adds FC and ISCSI Cinder drivers for DotHill Storage Arrays"
Jenkins [Tue, 16 Jun 2015 14:37:36 +0000 (14:37 +0000)]
Merge "Adds FC and ISCSI Cinder drivers for DotHill Storage Arrays"

9 years agoVolume driver for HP XP storage
Kazumasa Nomura [Tue, 16 Jun 2015 11:24:39 +0000 (20:24 +0900)]
Volume driver for HP XP storage

Volume driver for HP XP storage, along with unit tests. The driver
imports the hp_xp_horcm_fc class, which is available separately to
HP XP customers.

Implements: blueprint hpxp-storage-driver

Change-Id: Ic28c7f3fc5d61e9c2304dca60e416b5e94b990db
Signed-off-by: Kazumasa Nomura <kazumasa.nomura.rx@hitachi.com>
9 years agoReplace xrange() with six.moves.range()
Victor Stinner [Mon, 25 May 2015 15:08:00 +0000 (17:08 +0200)]
Replace xrange() with six.moves.range()

Add "from six.moves import range" to replace the builtin range()
function with six.moves.range() to always create an iterator, instead of
creating a temporary list.

Replace "xrange" with "range".

Don't add the import for ranges of 1024 items or less.

Blueprint cinder-python3
Change-Id: If618b4e810e444f7eb6592bb2398805e9d14d548

9 years agoDrop L suffix from long integers
Victor Stinner [Wed, 10 Jun 2015 12:28:38 +0000 (14:28 +0200)]
Drop L suffix from long integers

Replace 123L with 123 to make Cinder code compatible with Python 3.

This patch was generated by the long operation of the sixer tool:
https://pypi.python.org/pypi/sixer

Manual changes:

* hp_3par_common: bump version

Blueprint cinder-python3
Change-Id: I3086d3e3d9c3ede358313bdd43d1eee9cfdafe15

9 years agoPass proxy environment variables to tox
Yuiko Takada [Mon, 15 Jun 2015 01:12:24 +0000 (10:12 +0900)]
Pass proxy environment variables to tox

When a development environment is under a proxy, tox fails even if
environment variables of the proxy are set.

This patch fixes this problem by passing (upper case and lower case)
http_proxy, https_proxy and no_proxy from environment to tox.

See: commit 2d02ebb775ec44a14e325c56d4a901c5705fbb94

Change-Id: Ib7964fd5ea4fb8398cdb4cd94a70fe7fae49f973

9 years agoRe-add DRBD driver
Philipp Marek [Tue, 16 Jun 2015 06:45:44 +0000 (08:45 +0200)]
Re-add DRBD driver

This reverts commit 37eef0b3d4d786d4b2b1a7e48f3e2339506e85e2.

We hope to have a -infra CI running by June 12th, to get included
in Liberty.

Change-Id: Icb7347d55dc5b22720269405b6d2b4053c2ad819

9 years agoRefactor API create_volume flow
Michal Dulko [Tue, 16 Jun 2015 06:21:21 +0000 (08:21 +0200)]
Refactor API create_volume flow

This commit refactors the code to be more compliant with DRY rule.
I've also changed some comments to be more readable and correct.

Partial-Implements: blueprint taskflow-refactoring
Change-Id: I0345c07ac490b6bd738c0fdac0b621bb9156f899

9 years agoMerge "Get rid of oslo-incubator copy of middleware"
Jenkins [Tue, 16 Jun 2015 04:22:38 +0000 (04:22 +0000)]
Merge "Get rid of oslo-incubator copy of middleware"

9 years agoMerge "Targets tests: Clean up long lines"
Jenkins [Tue, 16 Jun 2015 04:10:51 +0000 (04:10 +0000)]
Merge "Targets tests: Clean up long lines"

9 years agoMerge "SQL scripts should not manage transactions"
Jenkins [Tue, 16 Jun 2015 04:03:58 +0000 (04:03 +0000)]
Merge "SQL scripts should not manage transactions"

9 years agoIntroduce Guru Meditation Reports into Cinder
wanghao [Thu, 14 May 2015 07:42:44 +0000 (15:42 +0800)]
Introduce Guru Meditation Reports into Cinder

This commit integrates functionality from the
`openstack.common.report` module into Cinder.
This enables Cinder services to receive SIGUSR1
and print a Guru Meditation Report to stderr.
The required modules were added to
'openstack-common.conf' as well.

It is essentially a copy from implementation of
nova side.

Change-Id: I5bbdc0f97db9b0ebd7b48e50ab7869e2ca33aead
Implements: blueprint guru-meditation-report

9 years agoAdds FC and ISCSI Cinder drivers for DotHill Storage Arrays
nikeshm [Mon, 27 Apr 2015 06:53:11 +0000 (12:23 +0530)]
Adds FC and ISCSI Cinder drivers for DotHill Storage Arrays

DocImpact
Implements: blueprint dothill-fc-cinder-driver
Implements: blueprint dothill-iscsi-cinder-driver

Co-Authored-By: Gauvain Pocentek<gauvain.pocentek@objectif-libre.com>
Co-Authored-By: Walter A. Boring IV<walter.boring@hp.com>
Change-Id: Iaf70ade96d4ad4234cc7e88277ed7b52cf458c2a

9 years agoGet rid of oslo-incubator copy of middleware
Davanum Srinivas [Mon, 1 Jun 2015 21:43:03 +0000 (17:43 -0400)]
Get rid of oslo-incubator copy of middleware

We have already moved away from openstack/common/middleware modules
to the oslo_middlware library. Let us cleanup the remaining files
here.

Change-Id: I701b08a28884eb56d12f2829483fe94aa8d2fd1d

9 years agoMerge "Get StringIO from six for Python 3 compatibility"
Jenkins [Mon, 15 Jun 2015 23:32:31 +0000 (23:32 +0000)]
Merge "Get StringIO from six for Python 3 compatibility"

9 years agoMerge "Remove WritableLogger wrapper"
Jenkins [Mon, 15 Jun 2015 23:26:50 +0000 (23:26 +0000)]
Merge "Remove WritableLogger wrapper"

9 years agoMerge "Update 3PAR user config help strings"
Jenkins [Mon, 15 Jun 2015 22:37:48 +0000 (22:37 +0000)]
Merge "Update 3PAR user config help strings"

9 years agoMerge "Replace dict(obj.iteritems() with dict(obj)"
Jenkins [Mon, 15 Jun 2015 22:37:38 +0000 (22:37 +0000)]
Merge "Replace dict(obj.iteritems() with dict(obj)"

9 years agoMerge "Replace dict.iteritems() with dict.items()"
Jenkins [Mon, 15 Jun 2015 22:10:18 +0000 (22:10 +0000)]
Merge "Replace dict.iteritems() with dict.items()"

9 years agoMerge "Use six.reraise() for Python 3 compatibility"
Jenkins [Mon, 15 Jun 2015 22:06:26 +0000 (22:06 +0000)]
Merge "Use six.reraise() for Python 3 compatibility"

9 years agoMerge "Remove pretty_tox and use ostestr"
Jenkins [Mon, 15 Jun 2015 21:23:17 +0000 (21:23 +0000)]
Merge "Remove pretty_tox and use ostestr"

9 years agoSQL scripts should not manage transactions
John Griffith [Mon, 15 Jun 2015 20:02:28 +0000 (14:02 -0600)]
SQL scripts should not manage transactions

This bug was fixed a while back, but the migration added for
multi-attach reintroduced it for its sqlite_downgrade file.

This patch removes it.

blueprint enable-mysql-connector

Change-Id: Iaec8713bf5cf36bcc97afbca8dd025cda9c2238d
Closes-Bug: 1368391

9 years agoTargets tests: Clean up long lines
Eric Harney [Fri, 12 Jun 2015 19:47:30 +0000 (15:47 -0400)]
Targets tests: Clean up long lines

Clean up long lines in unit tests, mostly by
using a variable for volume UUID and shortening
unnecessarily long CHAP credentials.

This is not intended to be complete, just
a good start that greatly reduces #noqa and
improves readability.

Change-Id: Iddc26a5722731d76e6d9e4b0ff493ed806bf148d

9 years agoUpdate 3PAR user config help strings
Kurt Martin [Thu, 11 Jun 2015 20:29:11 +0000 (13:29 -0700)]
Update 3PAR user config help strings

The 3PAR drivers no longer requires a user to have the 'super'
access role. This patch simply updates the help strings for the
3PAR username and password to reflect that an 'edit' role will
be sufficient.

DocImpact

Change-Id: I9b546953d06072dd614f92542b77e3a1a96f2eb5

9 years agoDisallow backing files when uploading volumes to image
Eric Harney [Tue, 31 Mar 2015 23:48:17 +0000 (19:48 -0400)]
Disallow backing files when uploading volumes to image

Volumes with a header referencing a backing file can leak
file data into the destination image when uploading a
volume to an image.

Halt the upload process if the volume data references a
backing file to prevent this.

Closes-Bug: #1415087
Change-Id: Iab9718794e7f7e8444015712cfa08c46848ebf78

9 years agoRemove WritableLogger wrapper
Igor Pugovkin [Mon, 15 Jun 2015 09:10:41 +0000 (12:10 +0300)]
Remove WritableLogger wrapper

With Eventlet 0.17.2, we can directly pass the logger
instance. This allows us to deprecate/remove the WritableLogger
class from oslo.log.

Change-Id: Ib7d193435584fc3631740058ed34b4df4ab23ad6
Closes-Bug: #1440773

9 years agoGet StringIO from six for Python 3 compatibility
Victor Stinner [Tue, 9 Jun 2015 13:32:32 +0000 (15:32 +0200)]
Get StringIO from six for Python 3 compatibility

Get StringIO and cStringIO classes and modules from the six module to
make cinder compatible with Python 2 and Python 3.

This patch was generated by the stringio operation of the sixer tool
version 0.4:
https://pypi.python.org/pypi/sixer

Blueprint cinder-python3
Change-Id: Ia8a58f83a504f2d2930bf5a0dc2cbaa482c29784

9 years agoFix Python 3 issues in utils
Victor Stinner [Fri, 12 Jun 2015 11:28:38 +0000 (13:28 +0200)]
Fix Python 3 issues in utils

* Replace string.split(key_file, ',') with key_file.split(','):
  the string.split() function was removed in Python 3, use the
  str.split() method instead
* Fix conf_fixture: import backup_enable_progress_timer and
  backup_swift_enable_progress_timer options. This change is required
  to run tests using testtools (it's now possible yet to run tests on
  Python 3 using testr).
* hash_file(): use b'' (bytes) for the sentinel, not '' (unicode), when
  reading the input binary file
* test_hash_file() requires a binary file (bytes), not a text file
  (unicode)
* Get the builtin open() function from six.moves.builtins instead of
  getting it from __builtin__ to mock the open() function. The
  __builtin__ module was renamed to builtins in Python 3.
* sanitize_hostname(): on Python 3, decode back the hostname from Latin1
  to work on a native string (Unicode)
* replace reduce() with six.moves.reduce(): the Python 2 builtin
  reduce() function was moved to the functools module in Python 3
* convert_version_to_str(): fix integer division, use a//b, not a/b
* convert_version_to_str(): replace reduce() with ''.join() with map(str)

Blueprint cinder-python3
Change-Id: If7b8f50c6a8b0a5044c2c7108b2b0293dddafff3

9 years agoMerge "Wait until service thread is done on service stop"
Jenkins [Mon, 15 Jun 2015 04:03:59 +0000 (04:03 +0000)]
Merge "Wait until service thread is done on service stop"

9 years agoUpdate SolidFire to use target driver model
John Griffith [Thu, 11 Jun 2015 14:52:38 +0000 (08:52 -0600)]
Update SolidFire to use target driver model

A while back we broke the inheritance chain of transport and backend
by moving the target drivers outside of the drivers.

This means you can instantiate and use any target (data transport)
method that your device supports without requiring a separate
driver (again, if your device can support it).  This was
particularly important for the LVM ref driver and the 5 iSCSI
options that go with it.

This patch converts the SolidFire driver to use the same model.  For
the most part it's pretty simple:
* Create an internal class for the target driver
* Instantiate the target driver that you want to use
* wrap the old transport calls that come to the driver to call
  the new target driver objects

This exposed some issues with the abc work that was being done.
There are a number of items that are marked as required but are
really only necessary for LVM based drivers.  So this also
creates a san/3'rd party iSCSI subclass as well that has the
more appropriate abc settings for such devices.

Change-Id: I02ceaac58d0e4176ccad423763ae0101cfb8446b

9 years agoMerge "3PAR enable multiattach capability reporting"
Jenkins [Sun, 14 Jun 2015 23:02:12 +0000 (23:02 +0000)]
Merge "3PAR enable multiattach capability reporting"

9 years agoMerge "Use six to fix imports on Python 3"
Jenkins [Sun, 14 Jun 2015 22:43:31 +0000 (22:43 +0000)]
Merge "Use six to fix imports on Python 3"

9 years agoMerge "Add cinder volume driver for Blockbridge EPS"
Jenkins [Sat, 13 Jun 2015 17:11:27 +0000 (17:11 +0000)]
Merge "Add cinder volume driver for Blockbridge EPS"

9 years agoWait until service thread is done on service stop
Mitsuhiro Tanino [Sat, 13 Jun 2015 04:23:40 +0000 (00:23 -0400)]
Wait until service thread is done on service stop

In order to be able to perform graceful shutdown of services, we need
to wait for all the current service threads to finish before exiting
from the service process.

Oslo.service provides this facility through it's wait() method, so we
need to call it in Cinder Service stop() method which gets called when
graceful shutdown is requested by sending the process SIGINT or SIGTERM.

Partial-Bug: 1464822
Change-Id: I972b80251cebe353f9d89ff4e05db8d029ef5e73

9 years agoMerge "Add secondary account capability to SolidFire"
Jenkins [Sat, 13 Jun 2015 15:40:23 +0000 (15:40 +0000)]
Merge "Add secondary account capability to SolidFire"

9 years agoMerge "Volume manager should set filter_function and goodness_function"
Jenkins [Sat, 13 Jun 2015 01:13:06 +0000 (01:13 +0000)]
Merge "Volume manager should set filter_function and goodness_function"

9 years agoAdd cinder volume driver for Blockbridge EPS
Joshua Huber [Fri, 12 Jun 2015 01:17:13 +0000 (21:17 -0400)]
Add cinder volume driver for Blockbridge EPS

This initial commit includes support for the minimum required volume
operations:

- Volume Create/Delete
- Volume Attach/Detach
- Snapshot Create/Delete
- Create Volume from Snapshot
- Get Volume Stats
- Copy Image to Volume
- Copy Volume to Image
- Clone Volume
- Extend Volume

For more details about our storage backend, please see the blueprint.

blueprint blockbridge-eps-driver
Change-Id: I99c95243bec708c6519cb69c4cb68085ad698c83