Jenkins [Wed, 12 Sep 2012 17:40:45 +0000 (17:40 +0000)]
Merge "Fixes bug
1049446."
Avishay Traeger [Tue, 11 Sep 2012 10:31:01 +0000 (13:31 +0300)]
Fixes bug
1049446.
Removed the "vtype" option which did not work in the driver, and
added the "easytier" option. Added another check to _check_flags
and made sure -warning flag is passed properly. Added unit tests
to check all option variations.
Change-Id: I4e66436f8f62d851a079ec80209fe9d6b27fb5b4
Jenkins [Tue, 11 Sep 2012 22:58:09 +0000 (22:58 +0000)]
Merge "Remove null_kernel option."
Jenkins [Tue, 11 Sep 2012 22:15:46 +0000 (22:15 +0000)]
Merge "Revert "Don't zero out snapshot volume on snapshot_delete""
John Griffith [Tue, 11 Sep 2012 21:41:30 +0000 (21:41 +0000)]
Revert "Don't zero out snapshot volume on snapshot_delete"
This reverts commit
1b3322d45fe2c5ed72cc7f8674e5e319928065ad
Turns out that although it's less likely we can still see this issue when zeroing out regular volumes.
Jenkins [Tue, 11 Sep 2012 17:20:55 +0000 (17:20 +0000)]
Merge "Remove unused utils.wrap_exception"
Jenkins [Mon, 10 Sep 2012 18:40:17 +0000 (18:40 +0000)]
Merge "Nail the pip requirement at 1.1."
Jenkins [Mon, 10 Sep 2012 18:26:00 +0000 (18:26 +0000)]
Merge "rename nova.pot => cinder.pot, nova.po => cinder.po"
Dan Prince [Fri, 7 Sep 2012 01:54:16 +0000 (21:54 -0400)]
Nail the pip requirement at 1.1.
The most recent version of pip (1.2.1 as of a couple days ago) fails
to install the required Cinder .venv packages. Nailing the installed
pip version when using run_tests.sh seems like a reasonable solution
to this issue.
Fixes LP Bug #
1047120.
Change-Id: I8d831f747b0d25b5d0f6e74a234e764ff448965b
Jenkins [Mon, 10 Sep 2012 02:48:37 +0000 (02:48 +0000)]
Merge "Don't zero out snapshot volume on snapshot_delete"
Jenkins [Mon, 10 Sep 2012 02:19:56 +0000 (02:19 +0000)]
Merge "Recent changes to SolidFire API changed iqn format"
Jenkins [Sun, 9 Sep 2012 17:45:46 +0000 (17:45 +0000)]
Merge "Prevent from bug #
1008866 is reverted"
Rongze Zhu [Sun, 9 Sep 2012 10:49:19 +0000 (18:49 +0800)]
Clean up .gitignore
remove:
* nova.egg-info
* .nova-venv
* tools/conf/nova.conf*
Change-Id: I6578a75314b86628a5afbd4c4282fb271b9a830e
Rongze Zhu [Sun, 9 Sep 2012 07:35:26 +0000 (15:35 +0800)]
Prevent from bug #
1008866 is reverted
Fixes bug #
1047841.
Commit
2f5360753308eb8b10581fc3c026c1b66f42ebdc (Adds new volume API
extensions) reverted a part of commit
99456bd690445443ae05c0d4fe1ec43ba6090f6f (Send 'create volume from
snapshot' to the proper host), so bug #
1008866 is reproduced. I make
API.create_volume to call _cast_create_volume in cinder/volume/api.py,
it Prevent from bug #
1008866 is reverted.
Change-Id: I1bf0b7c5fc47da756bce95128f8fd770d14399b0
Hui Cheng [Sun, 9 Sep 2012 05:04:09 +0000 (13:04 +0800)]
rename nova.pot => cinder.pot, nova.po => cinder.po
Fixes Bug #
1047195
renamed: cinder/locale/bs/LC_MESSAGES/nova.po -> cinder/locale/bs/LC_MESSAGES/cinder.po
renamed: cinder/locale/nova.pot -> cinder/locale/cinder.pot
renamed: cinder/locale/cs/LC_MESSAGES/nova.po -> cinder/locale/cs/LC_MESSAGES/cinder.po
renamed: cinder/locale/da/LC_MESSAGES/nova.po -> cinder/locale/da/LC_MESSAGES/cinder.po
renamed: cinder/locale/de/LC_MESSAGES/nova.po -> cinder/locale/de/LC_MESSAGES/cinder.po
renamed: cinder/locale/en_AU/LC_MESSAGES/nova.po -> cinder/locale/en_AU/LC_MESSAGES/cinder.po
renamed: cinder/locale/en_GB/LC_MESSAGES/nova.po -> cinder/locale/en_GB/LC_MESSAGES/cinder.po
renamed: cinder/locale/es/LC_MESSAGES/nova.po -> cinder/locale/es/LC_MESSAGES/cinder.po
renamed: cinder/locale/fr/LC_MESSAGES/nova.po -> cinder/locale/fr/LC_MESSAGES/cinder.po
renamed: cinder/locale/it/LC_MESSAGES/nova.po -> cinder/locale/it/LC_MESSAGES/cinder.po
renamed: cinder/locale/ja/LC_MESSAGES/nova.po -> cinder/locale/ja/LC_MESSAGES/cinder.po
renamed: cinder/locale/ko/LC_MESSAGES/nova.po -> cinder/locale/ko/LC_MESSAGES/cinder.po
renamed: cinder/locale/pt_BR/LC_MESSAGES/nova.po -> cinder/locale/pt_BR/LC_MESSAGES/cinder.po
renamed: cinder/locale/ru/LC_MESSAGES/nova.po -> cinder/locale/ru/LC_MESSAGES/cinder.po
renamed: cinder/locale/tl/LC_MESSAGES/nova.po -> cinder/locale/tl/LC_MESSAGES/cinder.po
renamed: cinder/locale/tr/LC_MESSAGES/nova.po -> cinder/locale/tr/LC_MESSAGES/cinder.po
renamed: cinder/locale/uk/LC_MESSAGES/nova.po -> cinder/locale/uk/LC_MESSAGES/cinder.po
renamed: cinder/locale/zh_CN/LC_MESSAGES/nova.po -> cinder/locale/zh_CN/LC_MESSAGES/cinder.po
renamed: cinder/locale/zh_TW/LC_MESSAGES/nova.po -> cinder/locale/zh_TW/LC_MESSAGES/cinder.po
Change-Id: I3a7894ac90793f270fb27444034b197b7c4f2841
John Griffith [Wed, 5 Sep 2012 19:27:48 +0000 (19:27 +0000)]
Don't zero out snapshot volume on snapshot_delete
When trying to zero out an LVM snapshot on precise the kernel sometimes
hangs when performing the dd. Also the dd process itself can take
an extremely long time even when it does succesfully complete.
This can be up to 30 minutes for a 1 Gig volume/snapshot.
I believe this is a kernel specific issue with LVM snapshots. The
zeroing process is unreliable and can cause kernel hangs to let's remove it.
In order to protect against data leakage we'll implement the zeroing process
on volume creation. This doesn't seem to have a significant impact and doesn't
suffer from the same isues tha zeroing out an LVM snapshot does.
No reason to continue zero on delete, the zero on creation should
probably be sufficient.
Doesn't seem to cause any timing issues but need to keep this in mind.
Fixes bug
1023755
Change-Id: I56209d8e5973cffa997b4ec3e51c3361838386de
John Griffith [Sat, 8 Sep 2012 16:40:55 +0000 (10:40 -0600)]
Recent changes to SolidFire API changed iqn format
The SF API initially didn't supply the in prefix so we
formed it manually in the OpenStack driver.
This has been fixed in the API so we dropped the manual
build of the prefix in volume create. Unfortunatly missed
the same case needed in create-from-snapshot.
Going forward we're adding running integration tests against
SF to catch this sort of thing.
Change-Id: I7107537d586f0a7c457dcbabfc90e1bc081d28d2
Jenkins [Fri, 7 Sep 2012 18:03:06 +0000 (18:03 +0000)]
Merge "avoid the buffer cache when copying volumes"
Jenkins [Fri, 7 Sep 2012 17:15:00 +0000 (17:15 +0000)]
Merge "Update dev docs * Quick pass at implementing the basics for cinder dev docs * Remove the N/A compute related stuff * Clean up the architecture a bit to only show cinder related * Remove various modules form TOC's that aren't applicable"
Jenkins [Fri, 7 Sep 2012 15:53:08 +0000 (15:53 +0000)]
Merge "Filter volumes and snapshots by query string"
Jenkins [Fri, 7 Sep 2012 15:40:37 +0000 (15:40 +0000)]
Merge "Rename test_nova_rootwrap.py to test_cinder_rootwrap.py"
Jenkins [Fri, 7 Sep 2012 15:08:12 +0000 (15:08 +0000)]
Merge "Update SolidFire driver to reflect IQN changes"
Jenkins [Fri, 7 Sep 2012 14:47:30 +0000 (14:47 +0000)]
Merge "Remove vpn_ping function in cinder/utils.py"
Jenkins [Fri, 7 Sep 2012 14:46:54 +0000 (14:46 +0000)]
Merge "Clean up some codes about compute in VolumeTestCase"
Jenkins [Fri, 7 Sep 2012 14:46:35 +0000 (14:46 +0000)]
Merge "Typo nova => cinder"
Jenkins [Fri, 7 Sep 2012 14:46:12 +0000 (14:46 +0000)]
Merge "Remove unused db api"
Mark McLoughlin [Fri, 7 Sep 2012 10:29:00 +0000 (11:29 +0100)]
Remove unused utils.wrap_exception
Moved into utils by commit
6ad36074, but it hasn't been used in cinder
since commit
9e4242c3 which prepared for switching to common rpc.
Change-Id: I9dff70e81c0bae36f26df893ac6971e17ba46bb3
Rongze Zhu [Fri, 7 Sep 2012 06:47:51 +0000 (14:47 +0800)]
Clean up some codes about compute in VolumeTestCase
self.compute have not be assigned in VolumeTestCase, so clean up some
codes about it.
Change-Id: Ie2577065ad27b4ee5b54dec65adfe723bf93985f
Rongze Zhu [Fri, 7 Sep 2012 06:40:45 +0000 (14:40 +0800)]
Remove unused db api
service_get_all_compute_by_host and service_get_all_compute_sorted are
not be used by cinder.
Change-Id: Ie384d2666bbfea1d5fab74e4e3e021909f6c0e3f
Jenkins [Fri, 7 Sep 2012 06:36:02 +0000 (06:36 +0000)]
Merge "Fixes potential bugs found by pylint"
Rongze Zhu [Fri, 7 Sep 2012 06:25:27 +0000 (14:25 +0800)]
Typo nova => cinder
Change-Id: I715feee8ca84fb65518e750585f82e942e710ecd
Rongze Zhu [Fri, 7 Sep 2012 06:13:11 +0000 (14:13 +0800)]
Remove vpn_ping function in cinder/utils.py
vpn_ping is not be used by cinder.
Change-Id: I3ea04200360a23259ce3cce54ff88125895e217b
John Griffith [Fri, 7 Sep 2012 05:50:49 +0000 (23:50 -0600)]
Update SolidFire driver to reflect IQN changes
Prior to release the SolidFire device returned only
a partial iqn string in it's api call.
With the GA release, this was modified to return the entire
iqn string, so just drop the prefix we were using in beta.
Change-Id: I7fa9d1ec6e2639149375a1115198eee90c527ef1
Rongze Zhu [Fri, 7 Sep 2012 04:21:40 +0000 (12:21 +0800)]
Rename test_nova_rootwrap.py to test_cinder_rootwrap.py
Change-Id: I13554b7afa994ec7c68e86e27568110445d1e4ed
Rongze Zhu [Fri, 7 Sep 2012 03:16:36 +0000 (11:16 +0800)]
Fixes potential bugs found by pylint
Partial fixes bug #
1043884
* remove _ec2_volume_get_query and _ec2_snapshot_get_query in
cinder.db.sqlalchemy.api, because they no longer be used in cinder.
* import openstack.commmon.utils.timeutils, because notify_usage_exists use it.
Change-Id: I3e989b940b6a99ac7751c940fa766aa13c61607b
Dan Prince [Fri, 7 Sep 2012 02:52:35 +0000 (22:52 -0400)]
Handle missing 'provider_location' in rm_export.
Updates the remove_export function in the ISCSIDriver so that
it handles the case where provider_location isn't set on
a volume. This can occur if a volume is created but not exported.
This was a regression from a previous commit
(
9785963c841aff5ea1c159da81f93c2bf62c70c6) which changed the way iscsi
targets are created/deleted.
Fixes LP Bug #
1046484.
Change-Id: Ie762b092dd2a84fe4f3b72c46c03a97ae67c53b7
Jenkins [Thu, 6 Sep 2012 23:31:02 +0000 (23:31 +0000)]
Merge "Sync cfg changes from openstack-common"
Jenkins [Thu, 6 Sep 2012 23:30:11 +0000 (23:30 +0000)]
Merge "Sync misc changes from openstack-common"
Jenkins [Thu, 6 Sep 2012 23:29:51 +0000 (23:29 +0000)]
Merge "Sync zmq changes from openstack-common"
Jenkins [Thu, 6 Sep 2012 23:28:06 +0000 (23:28 +0000)]
Merge "Remove default_schedule_zone."
Jenkins [Thu, 6 Sep 2012 23:09:43 +0000 (23:09 +0000)]
Merge "Remove memcached_servers config option."
Jenkins [Thu, 6 Sep 2012 22:49:39 +0000 (22:49 +0000)]
Merge "Remove dependencies for netaddr."
Jenkins [Thu, 6 Sep 2012 22:49:07 +0000 (22:49 +0000)]
Merge "Fix Typo in LOG.error"
Jenkins [Thu, 6 Sep 2012 22:47:05 +0000 (22:47 +0000)]
Merge "Specify the conf file when creating a volume."
Jenkins [Thu, 6 Sep 2012 22:30:57 +0000 (22:30 +0000)]
Merge "Fix xml metadata for volumes api in cinder."
Dan Prince [Thu, 6 Sep 2012 18:50:50 +0000 (14:50 -0400)]
Specify the conf file when creating a volume.
Updates the tgt-admin command to actually use the config file
we create for the volume being created.
This fixes an issue introduced in
9785963c841aff5ea1c159da81f93c2bf62c70c6 which breaks iscsi
volume creation.
Fixes LP Bug #
1046985.
Change-Id: I06e83c9ba351c2b4846b557a3abb170a51d506c0
Pádraig Brady [Fri, 13 Jul 2012 17:22:17 +0000 (18:22 +0100)]
avoid the buffer cache when copying volumes
The dd process when clearing volumes, was seen to starve
the system when writing to an iSCSI SAN connected over GigE.
So use O_DIRECT within the dd process so that the system
buffer cache is not impacted, which is generally the
best thing to do when streaming large amounts of data.
Also one could drop the I/O priority of the dd process
by prepending "ionice -c3". That would change the priority
from "normal" (best effort) to "idle", which means zeroing
will only proceed when there is no other I/O on the system.
It was thought best to leave scheduling decisions to the
system however, rather than specifying them explicitly.
Fixes bug: 937694
Change-Id: Ic842d7b83209c41d8ff05075990ed12e6f86283a
Jenkins [Thu, 6 Sep 2012 19:24:57 +0000 (19:24 +0000)]
Merge "Add admin actions extension"
Chuck Short [Thu, 6 Sep 2012 14:50:37 +0000 (09:50 -0500)]
Fix Typo in LOG.error
Fix typo in LOG.error, it should be
vol_id rather than volume_id.
Fixes bug #
1046875
Change-Id: Id162c6f185a110b63e8f9f509f5cde75f3626cbf
Signed-off-by: Chuck Short <chuck.short@canonical.com>
Dan Prince [Tue, 4 Sep 2012 02:11:59 +0000 (22:11 -0400)]
Remove dependencies for netaddr.
Updates cinder utils.py to remove the parse_server_string and
is_valid_cidr functions. These functions aren't in use
and are the only reason we need the netaddr dependency.
Updates pip-requires to drop the netaddr dependency.
Also removes the unit tests for removed functions.
Change-Id: I521ae60b758324069fb1ffa1701b1f9deb780f65
Clay Gerrard [Fri, 31 Aug 2012 20:16:29 +0000 (20:16 +0000)]
Filter volumes and snapshots by query string
Fix query string search_opts filters in api.openstack.volume.volumes and
snapshots. Fix get_all methods in volumes.api to adequately handle
parameter matching.
The current api does not properly apply query string filters by
display_name, status, or (in the case of snapshots) volume_id. These
filters are needed both for the end user and operator to display logical
grouping of these resources.
Fixes: bug #1046353
Change-Id: Ia12ffe1bf8a27c8a78daa24c4b728b394932a2b0
Dan Prince [Wed, 5 Sep 2012 17:20:54 +0000 (13:20 -0400)]
Remove null_kernel option.
This option was only used in the image/fake.py class. In this patch
I've updated the fake to use an inline 'nokernel' string instead of
this option which we don't make use of in the runtime Cinder code.
Change-Id: I05d4f227f1278c827ace2ce3c62319f9b18d04d4
Dan Prince [Wed, 5 Sep 2012 17:17:24 +0000 (13:17 -0400)]
Remove default_schedule_zone.
We don't use this config options.
Change-Id: I94a7940dc74341580ab954ffcda1f91fb5433e3f
Dan Prince [Wed, 5 Sep 2012 17:15:58 +0000 (13:15 -0400)]
Remove memcached_servers config option.
We don't use this in Cinder.
Change-Id: Id8503ff373622a2667fe0575f79e089056677019
Dan Prince [Wed, 5 Sep 2012 17:13:08 +0000 (13:13 -0400)]
Regenerate cinder.conf.sample.
Create a new version of cinder.conf.sample using
tools/conf/generate_sample.sh.
Old version had 475 options.
New version has 133 options (more accurate).
Change-Id: Id60aec1d91179a294e1969b7ab1f54051cb7a728
Dan Prince [Wed, 5 Sep 2012 16:59:28 +0000 (12:59 -0400)]
Sync improvements to config file generator tools.
We made some improvements to the config file generator in
Nova during Folsom including spacing and formatting changes.
This patch merges these into Cinder so we can make use of
them to generate a new sample config file.
Change-Id: I1e1166ac6e2a28cc179223e5af547995f58b36e6
Jenkins [Wed, 5 Sep 2012 17:19:01 +0000 (17:19 +0000)]
Merge "Removed unnecessary call to ensure_export"
Mark McLoughlin [Wed, 5 Sep 2012 11:21:36 +0000 (12:21 +0100)]
Sync misc changes from openstack-common
Syncs the following changes from stable/folsom:
769ec65 Don't trap then re-raise ImportError.
202b8b7 Fix spelling typos
01b4f31 Support for marshalling datetime while preserving microseconds.
Change-Id: I6ed5e71ed18cdf3c528351713a42645f31fd8965
Mark McLoughlin [Wed, 5 Sep 2012 11:19:07 +0000 (12:19 +0100)]
Sync zmq changes from openstack-common
Syncs the following from stable/folsom:
9f9e14c Update zmq context cleanup to use term.
704fb8b Remove register_opts from client methods
f88d38b Rename FLAGS to CONF; Remove self.conf
Change-Id: Ic6ab732d71420aba032554c51904dd71f1d23b78
Mark McLoughlin [Wed, 5 Sep 2012 11:04:16 +0000 (12:04 +0100)]
Sync cfg changes from openstack-common
Syncs the following from stable/folsom:
4dc2043 cfg: clean up None value handling
513bd3a Allow set_default and set_override to use None
0a36c92 Tilde expansion for --config-file and --config-dir
038d597 Add import_opt() method to ConfigOpts
Change-Id: Ifa85280fdc072965f3e9ae8641bdf85268a9a6ac
Jenkins [Tue, 4 Sep 2012 17:59:05 +0000 (17:59 +0000)]
Merge "Fix bug where image size is incorrectly rejected."
Jenkins [Tue, 4 Sep 2012 17:56:21 +0000 (17:56 +0000)]
Merge "Make size optional when creating a volume from a snap"
Matthew Treinish [Tue, 4 Sep 2012 15:08:16 +0000 (11:08 -0400)]
Fix xml metadata for volumes api in cinder.
Fixes bug
1040891.
Change-Id: Idf8cc641162617ade2aeb77b666270cf1ce54c54
Signed-off-by: Matthew Treinish <treinish@linux.vnet.ibm.com>
Dermot Tynan [Thu, 30 Aug 2012 17:38:22 +0000 (17:38 +0000)]
Fix bug where image size is incorrectly rejected.
Fixes bug
1043952.
Added GB-1 (one byte less than a gig) to the numerator to
correct round-off errors.
Change-Id: I6d97f3c53ab5a8ff5a0752400fd189f23223958f
Fixed PEP8 complaints.
Change-Id: Iacecddd4e65c80964f4860d6580872d897ec2356
Jenkins [Tue, 4 Sep 2012 03:24:45 +0000 (03:24 +0000)]
Merge "Several hacking compliance fixes."
Dan Prince [Tue, 4 Sep 2012 02:17:06 +0000 (22:17 -0400)]
Several hacking compliance fixes.
Updates bin/nova-manage and the solidfire driver with several
hacking compliance fixes.
Makes it so run_tests.sh -p runs clean again.
Change-Id: Iee675cae06acda6a585a77073e773651aab9d5a1
Dan Prince [Tue, 4 Sep 2012 02:02:22 +0000 (22:02 -0400)]
Remove Cheetah from pip-requires.
We don't use Cheetah so no need to install it w/ pip.
Change-Id: I29ea1b0ec2bf2eaebe4378c15c3cfc0caebabf99
John Griffith [Mon, 3 Sep 2012 23:16:49 +0000 (17:16 -0600)]
Update dev docs
* Quick pass at implementing the basics for cinder dev docs
* Remove the N/A compute related stuff
* Clean up the architecture a bit to only show cinder related
* Remove various modules form TOC's that aren't applicable
Change-Id: I0089c388524c9def7494658e836f4ed03a61f5b5
RongzeZhu [Mon, 3 Sep 2012 04:26:35 +0000 (12:26 +0800)]
Typo fix: nova => cinder
Change-Id: I816473b3aa7de16bd2d8569c695c6ced9e1d9033
Ben Swartzlander [Thu, 30 Aug 2012 00:35:33 +0000 (20:35 -0400)]
Move newly created NFS exceptions to standard location in exception.py
Addresses bug
1037619
bug
1037619
Change-Id: I20b1c612c03ef90eeb074814b979a9bc7492109c
Jenkins [Sat, 1 Sep 2012 00:57:54 +0000 (00:57 +0000)]
Merge "Remove unused flags"
Clay Gerrard [Mon, 27 Aug 2012 07:48:32 +0000 (07:48 +0000)]
Add admin actions extension
The optional os-admin-actions extension adds new wsgi_actions to the
volumes/action resource and a new snapshots/action endpoint.
With this extension both controllers will support an os-reset_status
action to force a database update of a volume or snapshot that is stuck
in a failed/incorrect status. The os-reset_status action works
similarly to the compute api's os-reset_state action for instances.
The os-force_delete action behaves similarly to the "cinder-manage
volume delete" command and allows operators/admins to retry the delete
operation after it has gone into an error_deleting status with an admin
api call.
The os-admin-actions extension is enabled by default, but limited to the
admin api by the default policy.json rules. Individual admin actions
can be disabled with policy rules as well.
Example of os-reset_status action on a volume:
curl http://localhost:8776/v1/${PROJECT_ID}/volumes/${VOLUME_ID}/action \
-H 'x-auth-token: ${ADMIN_AUTH_TOKEN}' \
-H 'content-type: application/json' \
-d '{"os-reset_status": {"status": "error"}}'
The new admin only api can assist deployers who encounter bugs or
operational issues that result in failed actions.
It can also be used by future storage backends to support async callback
style status updates from long running actions or operations which have
encountered an error will be retried.
Also updates the api.openstack.wsgi.ControllerMetaclass to support
sub-classing wsgi.Controllers that define wsgi_actions.
Partial fix for bug #
1039706
Change-Id: I29f4b892a99108b6c24eebc3eb58033a9e01e679
Jenkins [Fri, 31 Aug 2012 16:41:24 +0000 (16:41 +0000)]
Merge "Use event.listen() instead of deprecated listeners kwarg"
Jenkins [Fri, 31 Aug 2012 16:12:07 +0000 (16:12 +0000)]
Merge "Implement volume quota support in Cinder"
Jenkins [Fri, 31 Aug 2012 15:23:45 +0000 (15:23 +0000)]
Merge "Fix creation of iscsi targets"
Jenkins [Fri, 31 Aug 2012 15:22:33 +0000 (15:22 +0000)]
Merge "Add cinder- prefix to all binaries."
Jenkins [Fri, 31 Aug 2012 15:06:31 +0000 (15:06 +0000)]
Merge "Make glance image service check base exception classes"
Unmesh Gurjar [Fri, 31 Aug 2012 14:25:39 +0000 (07:25 -0700)]
Removed unnecessary call to ensure_export
Removed the extra call to 'ensure_export' from '_copy_image_to_volume' while
creating a volume from an image.
Fixes LP: #
1044399
Change-Id: I189a4cb66b965367289c2f677147ee085e431190
Dan Prince [Fri, 31 Aug 2012 13:56:50 +0000 (09:56 -0400)]
Add cinder- prefix to all binaries.
Renames clear_rabbit_queues and volume-usuage-audit binaries
so that they are prefixed with 'cinder-'.
As part of this change the clear_rabbit_queues binary was changed
to use dashes instead of underscores for consistency with the rest
of the cinder binaries.
Fixes LP Bug #
1044386.
Change-Id: I7692a543cc67af2d342a64b84626de38c0a64f81
Duncan Thomas [Fri, 17 Aug 2012 10:15:52 +0000 (10:15 +0000)]
Make size optional when creating a volume from a snap
Changing the size of a volume when cloning a snapshot doesn't
make a great deal of sense *and isn't part of the ec2 api).
This patch makes the field optional, defaulting to the same
size as the snapshot (and therefore the origination volume).
Change-Id: I3fea7fe1c0415d10e549c66a242cf2a336a7204e
Chuck Short [Tue, 28 Aug 2012 20:06:25 +0000 (15:06 -0500)]
Fix creation of iscsi targets
Previously when creating iscsi volumes, we were using
tgt-admin -e -c <config file> --update volume-id
Unfortunately the side affect of this is that tgt-admin
removed other volumes that weren't connected to an iscsi
connector. Which is obvlously not what we want.
In order to fix this we create the targets.conf for the
volume but we call tgt-admin --update icssi qualified name.
We're dropping the use of iscsi_targets table when using TgtAdm.
Compatability for other target admin types is maintained.
Fixes LP: #
1038062
Change-Id: I9060a43208df5b79e9b17dadcab8bc0a8eeef55e
Signed-off-by: Chuck Short <chuck.short@canonical.com>
Joe Gordon [Thu, 30 Aug 2012 20:35:07 +0000 (13:35 -0700)]
Spelling: Persistant=>Persistent
Change-Id: Id8e1bef634fe66e06624b5b3bcd82f59735d76e3
John Griffith [Thu, 16 Aug 2012 21:52:52 +0000 (15:52 -0600)]
Implement volume quota support in Cinder
parital fix for bug
1023311
* To use needs cinderclient https://review.openstack.org/#/c/11509/
* Updates quota classes with changes in Nova
* Adds needed quota related DB tables
* Updates test_quota to reflect changes in Nova
* Adds absolute limits and empty rate limit functions
* Updates test/integration/test_volume to make it work w/ above changes
Change-Id: I221c7a9dc51a2bb9bf7228c056f63ba9546cf5f9
Jenkins [Thu, 30 Aug 2012 17:02:44 +0000 (17:02 +0000)]
Merge "Fix PEP8 issues."
Jenkins [Thu, 30 Aug 2012 17:01:50 +0000 (17:01 +0000)]
Merge "Add 'detaching' to volume status"
Jenkins [Thu, 30 Aug 2012 17:01:28 +0000 (17:01 +0000)]
Merge "Remove unused return values and commented out code from NFS driver"
Jenkins [Thu, 30 Aug 2012 15:43:42 +0000 (15:43 +0000)]
Merge "Remove unused exceptions from cinder/exception.py"
Ben Swartzlander [Wed, 29 Aug 2012 23:10:11 +0000 (19:10 -0400)]
Remove unused return values and commented out code from NFS driver
bug
1037622
Change-Id: Idea3005ad94fd6bfc76fd0f3969ee78e3031767e
Rongze Zhu [Wed, 29 Aug 2012 09:46:32 +0000 (09:46 +0000)]
Remove unused flags
* region_list
* aws_access_key_id
* aws_secret_access_key
* osapi_scheme
* osapi_path
* metadata_host
* metadata_port
* default_project
* default_image
* default_instance_type
* vpn_image_id
* vpn_key_suffix
* auth_token_ttl
* bandwith_poll_interval
* start_guests_on_host_boot
* resume_guests_state_on_host_boot
* default_ephemeral_format
* use_ipv6
* allow_resize_to_same_host
* zombie_instance_updated_at_window
* isolated_images
* isolated_hosts
Change-Id: Ia3d5ac7d7c983845b5411e2fc1f49eb579e3280f
lrqrun [Tue, 28 Aug 2012 15:28:48 +0000 (23:28 +0800)]
Fix PEP8 issues.
Fix some pep8 issues in doc/ext/cinder_todo.py make the code looks pretty.
Change-Id: I137c8bf5af30eb54a44cbff7f1fbc35bc2c3ed9e
Jenkins [Mon, 27 Aug 2012 16:04:14 +0000 (16:04 +0000)]
Merge "Migrate volume related quota info in db migration"
Jenkins [Sat, 25 Aug 2012 17:57:27 +0000 (17:57 +0000)]
Merge "Fix PEP8 issues."
Jenkins [Sat, 25 Aug 2012 17:49:37 +0000 (17:49 +0000)]
Merge "Typo fix in cinder: existant => existent"
Jenkins [Sat, 25 Aug 2012 17:49:02 +0000 (17:49 +0000)]
Merge "Fix incorrect tgt-admin call in create_iscsi_target"
John Griffith [Thu, 23 Aug 2012 19:23:04 +0000 (13:23 -0600)]
Fix incorrect tgt-admin call in create_iscsi_target
* Fixes bug
1039826
* Missed one of the execute cmds that was using 'val %s' as args
Change-Id: I5e6af737ada1c2bcf7a495710e2b10c8c74bb534
Rongze Zhu [Tue, 21 Aug 2012 15:07:02 +0000 (15:07 +0000)]
Add 'detaching' to volume status
Fixes bug #
1004382
When attach a volume , the volume status is "available -> attaching ->
in-use", But when detaching a volume , the volume status is "in-use ->
available". So We need 'detaching' volume status, it make the change of
state of the volume more clearly.
Change-Id: Idf8c38413135bf8e8cd025f11937f8c7250557c1
Rongze Zhu [Thu, 23 Aug 2012 03:00:08 +0000 (03:00 +0000)]
Typo fix in cinder: existant => existent
Impact:
* locale message in cinder/locale/*/LC_MESSAGES/nova.po
* locale message in cinder/locale/nova.po
* Test function names
* Test strings and comments
Change-Id: I623af176d3b556a1ea9f8bde2c609fc4f752d7da
John Griffith [Wed, 22 Aug 2012 22:26:15 +0000 (16:26 -0600)]
Make glance image service check base exception classes
Fixes bug
1039675
glanceclient can raise HTTPNotFound (as well as NotFound) it appears,
but glance image service is only converting NotFound ->
InstanceNotFound. Same applies to 'Forbidden' and other exceptions.
This patch converts 'exc_type is NotFound'-like checks to use
'isinstance' instead, which will cover HTTPNotFound, etc.
Also add missing glance/image tests that weren't in Cinder
Change-Id: I8787598daccf401a26d9397946ecd55f89ff62b3
Ray Chen [Wed, 22 Aug 2012 03:57:42 +0000 (11:57 +0800)]
Fix PEP8 issues.
Fix some pep8 issues in doc/ext/cinder_todo.py and
doc/source/conf.py and make the code looks pretty.
Change-Id: Ie164bc7328507e20b0ab5993ba97eaadbd74bf63
RongzeZhu [Wed, 22 Aug 2012 03:37:26 +0000 (11:37 +0800)]
Remove unused exceptions from cinder/exception.py
find cinder/ -type f -name "*pyc" -exec rm {} \;
exceptions=`cat cinder/exception.py| grep -E '^class' |\
awk {'print $2'} | awk -F '(' {'print $1'}`
for exc in $exceptions
do
i=`find cinder/ -type f -exec grep -R $exc {} \; |wc -l`
if [ $i -eq 1 ]
then
echo $exc
fi
done
First removed exceptions:
DecryptionFailure
ImagePaginationFailed
VirtualInterfaceCreateException
VirtualInterfaceMacAddressException
MelangeConnectionFailed
VolumeUnattached
InvalidKeypair
InvalidSignature
InvalidInstanceType
InvalidIpProtocol
InvalidCidr
InvalidAggregateAction
InvalidGroup
InstanceInvalidState
InstanceNotRunning
InstanceNotSuspended
InstanceNotInRescueMode
InstanceSuspendFailure
InstanceResumeFailure
InstanceRebootFailure
InstanceTerminationFailure
VolumeServiceUnavailable
UnableToMigrateToSelf
DestinationHostUnavailable
SourceHostUnavailable
InvalidHypervisorType
DestinationHypervisorTooOld
DestinationDiskExists
InvalidDevicePath
DeviceIsBusy
InvalidCPUInfo
InvalidIpAddressError
InvalidVLANTag
InvalidVLANPortGroup
InvalidDiskFormat
InstanceUnacceptable
FlagNotSet
NoVolumeTypesFound
VolumeDriverNotFound
ListingImageRefsNotSupported
KernelNotFoundForImage
ProjectNotFound
ProjectMembershipNotFound
UserRoleNotFound
StorageRepositoryNotFound
DatastoreNotFound
FixedIpNotFoundForAddress
FixedIpNotFoundForInstance
FixedIpNotFoundForNetworkHost
FixedIpNotFoundForSpecificInstance
FixedIpNotFoundForHost
FixedIpAlreadyInUse
FixedIpInvalid
NoMoreFixedIps
NoFixedIpsDefined
FloatingIpDNSExists
FloatingIpNotFoundForAddress
FloatingIpNotFoundForHost
NoMoreFloatingIps
FloatingIpAssociated
FloatingIpNotAssociated
NoFloatingIpsDefined
NoFloatingIpInterface
KeypairNotFound
CertificateNotFound
AuthTokenNotFound
AccessKeyNotFound
SecurityGroupNotFoundForProject
SecurityGroupNotFoundForRule
SecurityGroupExistsForInstance
SecurityGroupNotExistsForInstance
NoInstanceTypesFound
InstanceTypeNotFoundByName
FlavorNotFound
CellNotFound
SchedulerHostFilterNotFound
SchedulerCostFunctionNotFound
SchedulerWeightFlagNotFound
InstanceMetadataNotFound
InstanceTypeExtraSpecsNotFound
LDAPUserNotFound
LDAPGroupNotFound
LDAPGroupMembershipNotFound
NoFilesFound
SwitchNotFoundForNetworkAdapter
NetworkAdapterNotFound
GlobalRoleNotAllowed
ImageRotationNotAllowed
RotationRequiredForBackup
LDAPUserExists
LDAPGroupExists
LDAPMembershipExists
ProjectExists
InstanceExists
InstanceTypeExists
InvalidSharedStorage
CannotResizeToSameSize
ImageTooLarge
ZoneRequestError
InstanceTypeMemoryTooSmall
InstanceTypeDiskTooSmall
InsufficientFreeMemory
CouldNotFetchMetrics
AggregateError
AggregateNotFound
AggregateNameExists
AggregateHostNotFound
AggregateMetadataNotFound
AggregateHostConflict
AggregateHostExists
InstanceTypeCreateFailed
SolidFireAPIStatusException
DuplicateVlan
InvalidInstanceIDMalformed
CouldNotFetchImage
Search again, Second removed exceptions:
UserNotFound
FixedIpNotFoundForNetwork
FloatingIpNotFound
SecurityGroupNotFound
InstanceTypeNotFound
LDAPObjectNotFound
UserExists
Search again, Third removed exceptions:
FixedIpNotFound
Change-Id: I028122c6132340b2fef2c144da787b7c4efddccf