]> review.fuel-infra Code Review - openstack-build/neutron-build.git/log
openstack-build/neutron-build.git
12 years agoAddress problems with foreign keys with subnet and network deletion
Gary Kotton [Wed, 4 Jul 2012 10:54:10 +0000 (06:54 -0400)]
Address problems with foreign keys with subnet and network deletion

This also fixes bug 1020879 and bug 1020847

Change-Id: Ib68f9357ed65f35e56d17577b83fabe8f96388cf

12 years agoAdd 'allocation_pools' to Quantum v2 API subnets.
Salvatore Orlando [Thu, 28 Jun 2012 09:22:36 +0000 (10:22 +0100)]
Add 'allocation_pools' to Quantum v2 API subnets.

This changeset adds a new parameter, 'allocation_pools' to the 'subnet'
resource of the Quantum v2 API.
Allows for creating and validation of subnets with multiple allocation pools.
This commit only deals with POST verb (subnet creation).
PUT verb (subnet update) will be dealt with in a subsequent commit.

This is the first commit for fixing bug #1016308

Change-Id: Ic356dcb5dcfa46af8ecc7e598529881f8bcbbeed

12 years agoDelete IP allocation range for subnet when deleting subnet
Gary Kotton [Tue, 3 Jul 2012 17:11:31 +0000 (13:11 -0400)]
Delete IP allocation range for subnet when deleting subnet

Fixes bug 1020563

Change-Id: I034e490825603ab71662a0bbad9b325f419a9e43

12 years agoFix linux bridge plugin to be consistent with naming rules
Gary Kotton [Tue, 3 Jul 2012 10:34:20 +0000 (06:34 -0400)]
Fix linux bridge plugin to be consistent with naming rules

Fixes bug 1020468

Change-Id: I4a84e6c89c450032a791b9f91bc5e4dac6c9f647

12 years agov2 support for the linux bridge plugin
Gary Kotton [Thu, 28 Jun 2012 10:26:10 +0000 (06:26 -0400)]
v2 support for the linux bridge plugin

blueprint lb-api-v2-support

Plugin support for the linuxbridge using the v2 API

1. The core_plugin in quantum.conf must be set to:
quantum.plugins.linuxbridge.LinuxBridgePluginV2.LinuxBridgePluginV2
2. By default the agent is v2. A configuration file entry 'target_v2_api'
in the section 'AGENT' can be set as False to support v1.

Change-Id: I2e196859c13b28e535c6ec394ec3f5bc907bf019

12 years agoMerge "Ensure that subnet_id is on correct network."
Jenkins [Mon, 2 Jul 2012 21:49:32 +0000 (21:49 +0000)]
Merge "Ensure that subnet_id is on correct network."

12 years agoMerge "Check if interface exists in bridge prior to adding."
Jenkins [Mon, 2 Jul 2012 21:49:00 +0000 (21:49 +0000)]
Merge "Check if interface exists in bridge prior to adding."

12 years agoOVS plugin support for v2 Quantum API
Aaron Rosen [Fri, 29 Jun 2012 01:17:16 +0000 (18:17 -0700)]
OVS plugin support for v2 Quantum API

blueprint: ovs-api-v2-support

This commit allows the ovs_quantum_plugin to work with the v2 api.

change-Id: I9e332a799f6bee8a90755f961fbb9711a1ecdaca

12 years agoCheck if interface exists in bridge prior to adding.
Gary Kotton [Sun, 1 Jul 2012 07:06:07 +0000 (03:06 -0400)]
Check if interface exists in bridge prior to adding.

This fixes bug 1019730. The fix for bug 1000406 ensures that return
values of shell commands are checked. The command
    utils.execute(['brctl', 'addif', bridge_name, interface],
                   root_helper=self.root_helper)
would cause an exception if there was more than one attachment
on the network. The reason for this was the interface already existed
on the bridge.

Change-Id: I8a1f6cc7be930c04ce302d7f87814b9bd5bed129

12 years agoEnsure that subnet_id is on correct network.
Gary Kotton [Sun, 1 Jul 2012 10:46:29 +0000 (06:46 -0400)]
Ensure that subnet_id is on correct network.

Fixes bug 1019759.

Change-Id: I7a732ebf404c6fddaf6f06798411adbadd8ebb3f

12 years agoUse setuptools git plugin for file inclusion.
Monty Taylor [Thu, 28 Jun 2012 14:45:35 +0000 (07:45 -0700)]
Use setuptools git plugin for file inclusion.

Fixes bug 1018833. We're looking at this as a possible pan-project
option instead of manual MANIFEST.in inclusion and then looking for
where the tarballs differ.

Change-Id: I25287d5aca2046c6b613b05d54281533bdd6f79f

12 years agoCisco's unplug_iface refers to non existing exception
chnm-kulkarni [Sat, 30 Jun 2012 04:10:53 +0000 (09:40 +0530)]
Cisco's unplug_iface refers to non existing exception

Bug #1006226

An extra exception,InvalidDetach has been added to cisco_exception.py and
unplug_iface has been redirected to this exception

Change-Id: I5d1e4070fd0cb60a973e55e5645509aef58e8083

12 years agoImplement IP address allocation.
Gary Kotton [Thu, 21 Jun 2012 08:53:48 +0000 (04:53 -0400)]
Implement IP address allocation.

This fixes bug 1008029.

The allocation is done as follows (according to the value of
port['fixed_ips']):
- api_router.ATTR_NOT_SPECIFIED - Quantum will generate an IP address.
If a v4 subnet is defined then a v4 address will be generated. If
a v6 subnet is defined then a v6 address will be generated. If both are
defined then both v4 and v6 addresses will be generated.
- user configuration which may contain a list of the following:
   - ip_address - the specific IP address will be generated
   - subnet_id - an IP address from the subnet will be generated

Change-Id: I3bb1b83b8824364b37dbecfa140331c4a1fd2762

12 years agoEnable user to configure base mac address.
Gary Kotton [Tue, 26 Jun 2012 06:15:46 +0000 (02:15 -0400)]
Enable user to configure base mac address.

In addition to this enable the user to configure the amount of
retries to generate a unique MAC address

Change-Id: Ic109ae65993141c6dc7d63f394066a31e79e2b4c

12 years agoMerge "Bug #1012418 - quantum agent for OVS does not install properly on Xen XCP"
Jenkins [Tue, 26 Jun 2012 19:51:14 +0000 (19:51 +0000)]
Merge "Bug #1012418 - quantum agent for OVS does not install properly on Xen XCP"

12 years agoMerge "Remove paste configuration details to a seperate file. blueprint use-common...
Jenkins [Tue, 26 Jun 2012 19:49:06 +0000 (19:49 +0000)]
Merge "Remove paste configuration details to a seperate file. blueprint use-common-cfg"

12 years agoBug #1012418 - quantum agent for OVS does not install properly on Xen XCP
Juliano Martinez [Mon, 18 Jun 2012 22:30:36 +0000 (19:30 -0300)]
Bug #1012418 - quantum agent for OVS does not install properly on Xen XCP

This change added the feature to package and install the ovs-quantum-agent inside XS and XCP,
added an option on Makefile to gen and install using python2.6 ( by default it will use 2.4 )

Change-Id: I8860d7dcb7e7b74125784cb0f33c6ca03b37702b

12 years agoAdd simple file loggin to ovs_quantum_agent.
Armando Migliaccio [Thu, 21 Jun 2012 20:21:17 +0000 (21:21 +0100)]
Add simple file loggin to ovs_quantum_agent.

Default behaviour is retained. Fix bug #1016232

Change-Id: If11244d48a5c966bbbf8786e3e9f42d205a70164

12 years agoFixing pep8 warning messages
Edgar Magana [Tue, 26 Jun 2012 04:49:16 +0000 (21:49 -0700)]
Fixing pep8 warning messages
Bug #1017805

Change-Id: I3417215a7a068141b69608e0dc5abaf220ac105d

12 years agoNetwork deletion and subnet creation bug fixes
Gary Kotton [Mon, 25 Jun 2012 09:06:36 +0000 (05:06 -0400)]
Network deletion and subnet creation bug fixes
bug 1017395

1. When a subnet is created the network id is validated
2. when a network is deleted - if a subnet or port is defined then
the opertaion fails

Change-Id: I746d0f4994c539a908df0220465d753bc3eb8e04

12 years agoRemove paste configuration details to a seperate file.
Gary Kotton [Thu, 21 Jun 2012 13:06:44 +0000 (09:06 -0400)]
Remove paste configuration details to a seperate file.
blueprint use-common-cfg

In addition this ensures that the cisco extension units are working
with the common cfg code.

Change-Id: I8c1f81e295e7ed593f0b58885efeeb15339b7733

12 years agoMerge "Reorder imports by full module path"
Jenkins [Thu, 21 Jun 2012 14:22:58 +0000 (14:22 +0000)]
Merge "Reorder imports by full module path"

12 years agoMerge "Bug 1015953 - linuxbridge_quantum_agent device_exists() is buggy"
Jenkins [Thu, 21 Jun 2012 13:32:40 +0000 (13:32 +0000)]
Merge "Bug 1015953 - linuxbridge_quantum_agent device_exists() is buggy"

12 years agoMerge "Added iptables_manager ( based on openstack/linux_net.py ) This module will...
Jenkins [Thu, 21 Jun 2012 13:27:52 +0000 (13:27 +0000)]
Merge "Added iptables_manager ( based on openstack/linux_net.py ) This module will be the base library to implement security groups and generic firewall. It is an independent iptables module, made to be easy to package if used by agents and also inside quantum"

12 years agoBug 1015953 - linuxbridge_quantum_agent device_exists() is buggy
ncode [Thu, 21 Jun 2012 10:27:52 +0000 (07:27 -0300)]
Bug 1015953 - linuxbridge_quantum_agent device_exists() is buggy

Just added the check_exit_code=False to utils.execute call

Change-Id: I3105131e853d45609bc441482bf5b3c3e035a129

12 years agoReorder imports by full module path
Zhongyue Luo [Mon, 18 Jun 2012 17:52:17 +0000 (01:52 +0800)]
Reorder imports by full module path

Fixes bug #1014765

Change-Id: I849d73fc756b830b78492a6ed0e8cf2d32fde8cd

12 years agoAdded iptables_manager ( based on openstack/linux_net.py )
Juliano Martinez [Mon, 18 Jun 2012 14:00:45 +0000 (11:00 -0300)]
Added iptables_manager ( based on openstack/linux_net.py )
This module will be the base library to implement security
groups and generic firewall.
It is an independent iptables module, made to be easy to package
if used by agents and also inside quantum

Using quantum.agent.linux.utils
Added support to root_helper

Change-Id: Iaa29322477fc2e753b52dc4f01e7c4a561110638

12 years agoUnit test and Readme changes related to cisco plugin.
root [Mon, 18 Jun 2012 10:09:00 +0000 (06:09 -0400)]
Unit test and Readme changes related to cisco plugin.

Change-Id: Ica6db500a2ec8a895cb90756ca9ff304faa16519

Unit test and Readme changes related to cisco plugin.

Remove additional space in the Readme file

Remove file inadverntently checked in

Bug #1015410

Change-Id: I273255ff475b1ca6e80409fbf7f8c8571b3c456c

12 years agoImplements the blueprint use-common-cfg for the quantum service.
Gary Kotton [Sun, 3 Jun 2012 11:55:09 +0000 (07:55 -0400)]
Implements the blueprint use-common-cfg for the quantum service.
More specifically uses global CONF for the quantum.conf file.

Added support for the RYU plugin (similar to ovs and lb,
which use non-global conf for plugins)

patch 27: clean up find_config_file
patch 28: for config file use old paths (plugin unit tests)
          this hopefully will be replaced when we move to common
          config file
patch 30: rebase and merge (utils.py and policy.py)

Change-Id: Ic0bf5bdd44f24a557240f7afe4e070dee448c63c

12 years agoEnsure unique mac address allocation.
Gary Kotton [Tue, 19 Jun 2012 23:32:22 +0000 (16:32 -0700)]
Ensure unique mac address allocation.
This is the first part of bug 1008029

If the port command does not contain a MAC address then Quantum will generate
a random MAC address. The mac address will be saved in the database to ensure
that it is not used by another port on the same network.

Added mock-based test for mac exhaustion.

Change-Id: I4d3fe12fd1e3c347b8e286d920a0609d0b3c4e8c

12 years agoMerge "removed "runthis" and other unused functions from utils.py"
Jenkins [Tue, 19 Jun 2012 05:44:04 +0000 (05:44 +0000)]
Merge "removed "runthis" and other unused functions from utils.py"

12 years agoMerge "Remove unused functions in common/utils.py"
Jenkins [Mon, 18 Jun 2012 23:09:33 +0000 (23:09 +0000)]
Merge "Remove unused functions in common/utils.py"

12 years agoAdd authZ through incorporation of policy checks.
Kevin L. Mitchell [Thu, 14 Jun 2012 14:39:57 +0000 (09:39 -0500)]
Add authZ through incorporation of policy checks.

Adds the policy openstack-common module and implements policy checks
for the v2 API.  Note that this cut only addresses whole objects (i.e.,
a subnet or a network or a port), not specific fields within objects.
(This means that attributes are not filtered out based on policies.)
Implements blueprint authorization-support-for-quantum.

Change-Id: I1b52b1791a1f14f0af6508a63a40a38e440f15fe

12 years agoMerge "Fix python2.4 incompatibility"
Jenkins [Mon, 18 Jun 2012 16:33:44 +0000 (16:33 +0000)]
Merge "Fix python2.4 incompatibility"

12 years agoMerge "Use openstack.common.exception"
Jenkins [Mon, 18 Jun 2012 16:24:09 +0000 (16:24 +0000)]
Merge "Use openstack.common.exception"

12 years agoMerge "Added vlan range management for OVS plugin"
Jenkins [Mon, 18 Jun 2012 13:34:54 +0000 (13:34 +0000)]
Merge "Added vlan range management for OVS plugin"

12 years agoFix additional pep8 issues on Jenkins
Gary Kotton [Mon, 18 Jun 2012 13:16:10 +0000 (09:16 -0400)]
Fix additional pep8 issues on Jenkins
bug 1014644

Change-Id: If858d04443319d4ddd20a65bc5bf0221564860f8

12 years agoremoved "runthis" and other unused functions from utils.py
Harsh Prasad [Mon, 18 Jun 2012 08:48:24 +0000 (14:18 +0530)]
removed "runthis" and other unused functions from utils.py

Fixes Bug #1012234

Removed all unused functions and imports from common/utils.py.

Patch set 2: Submitted same code by mistake
Patch set 3: removed commented code but inappropriate commit msg.
Patch set 4: removed commented code with appropriate commit msg. Removed pep8 changes for ucs plugin.

Change-Id: I0ec33be127ef0389685a378c6f8d39ce5cbdb58c

12 years agoLinux bridge agents did not work with common linus utils
Gary Kotton [Sun, 17 Jun 2012 12:29:40 +0000 (08:29 -0400)]
Linux bridge agents did not work with common linus utils
bug 1014286

Change-Id: I66327f5414d7f08dd13208707f12291ce202e47f

12 years agoAdded vlan range management for OVS plugin
Roman Sokolkov [Fri, 15 Jun 2012 13:13:33 +0000 (17:13 +0400)]
Added vlan range management for OVS plugin

* Added integer config flags: vlan_min, vlan_max
* If vlan_min is larger than vlan_max log warn and use default values
* Changed test_vlan_map.py in favor removed definitions of VlanMap class

Change-Id: Iaba819e62d70a9c9935cae195718dbf74d13884a

12 years agoMerge "Remove wrong base class for l2network_models after v2.0 API"
Jenkins [Sun, 17 Jun 2012 05:05:29 +0000 (05:05 +0000)]
Merge "Remove wrong base class for l2network_models after v2.0 API"

12 years agoBug #1013967 - Quantum is breaking on tests with pep 1.3
Juliano Martinez [Sat, 16 Jun 2012 05:24:25 +0000 (02:24 -0300)]
Bug #1013967 - Quantum is breaking on tests with pep 1.3

Fixing files

93/93 files fixed

Change-Id: Ia30f2e2253806fa5f447d44208d13d2c0beba9cd

12 years agoRemove wrong base class for l2network_models after v2.0 API
Yong Sheng Gong [Thu, 14 Jun 2012 11:42:24 +0000 (19:42 +0800)]
Remove wrong base class for l2network_models after v2.0 API

Bug 1012557

Change-Id: I2a43d5c9334525152e5307278020bad16bf64eb3

12 years agoCisco cli cannot find argument action_prefix
Harsh Prasad [Thu, 14 Jun 2012 11:17:56 +0000 (16:47 +0530)]
Cisco cli cannot find argument action_prefix

Bug #1012502

Removed use of argument action_prefix for Client. Also, made HOST, PORT and USE_SSL global.
Signed-off-by: Harsh Prasad <prasad.tanay@gmail.com>
Change-Id: I93037b34fca89786778a2dcd8a3afc80df5687f8

12 years agoUse openstack.common.exception
Zhongyue Luo [Thu, 14 Jun 2012 08:09:34 +0000 (16:09 +0800)]
Use openstack.common.exception

Fixes bug #1013040

1. Edit openstack-common.conf and import openstack.common.exception
2. Remove redundant code

Change-Id: Ia440422e283f8e6796d9a1f720d73b3bcf2f981e

12 years agoRemove unused functions in common/utils.py
Zhongyue Luo [Thu, 14 Jun 2012 07:19:14 +0000 (15:19 +0800)]
Remove unused functions in common/utils.py

Fixes bug #1013017

Delete functions int_from_bool_as_string and bool_from_string.

Change-Id: I5e838c1659234b885429ac090db4aa49e2f90645

12 years agoAPI v2: mprove validation of post/put, rename few attributes
Dan Wendlandt [Wed, 13 Jun 2012 17:41:32 +0000 (10:41 -0700)]
API v2: mprove validation of post/put, rename few attributes

bug #1012438

Additional work for bp v2-api-melange-integration

- rename few attributes:
  op_state -> status
  additional_routes -> additional_host_routes
  prefix -> cidr

- expand request body validation to indicate whether fields can be
specified during create and or update.
- add test cases to validate defaults, and input validation.

- update db_base_plugin_v2 to generate gateway_ip for subnet and mac
for port when unspecified.

- validate that tenant-id is only specified in req by admin users

- automatically set tenant-id based on request.context.tenant_id if needed

- enable port tests in test_db_plugin.py

Change-Id: If7f5101e4974a6ef93ff8a1d945f8642dd21b16e

12 years agoBug #1000406 - Return value of shell commands is not checked by plugins
Juliano Martinez [Thu, 7 Jun 2012 20:56:07 +0000 (17:56 -0300)]
Bug #1000406 - Return value of shell commands is not checked by plugins

Added an utils library for agents and also changed agents to use
this library.

Changed to keep 2.4 compatibility

Change-Id: Ib4fc0a8dcbfc4b79a0b0e61e1fc1f24ec5da4d46

12 years agoMerge "Add build_sphinx options."
Jenkins [Wed, 13 Jun 2012 07:01:00 +0000 (07:01 +0000)]
Merge "Add build_sphinx options."

12 years agoFix python2.4 incompatibility
Piotr Siwczak [Tue, 12 Jun 2012 20:57:08 +0000 (13:57 -0700)]
Fix python2.4 incompatibility

python2.4 compatibility is needed for the agent
to work on Xen

Change-Id: Ifa81a5ddb4f2a9dcb6ce94fa0d941ba6e6c2e038

12 years agoMerge "Fix up test running to match jenkins expectation."
Jenkins [Tue, 12 Jun 2012 04:15:52 +0000 (04:15 +0000)]
Merge "Fix up test running to match jenkins expectation."

12 years agoMerge "Add API v2 support"
Jenkins [Tue, 12 Jun 2012 03:58:41 +0000 (03:58 +0000)]
Merge "Add API v2 support"

12 years agoMerge "Remove unused imports"
Jenkins [Mon, 11 Jun 2012 16:18:29 +0000 (16:18 +0000)]
Merge "Remove unused imports"

12 years agoAdd API v2 support
Jason Kölker [Wed, 9 May 2012 17:04:11 +0000 (12:04 -0500)]
Add API v2 support

* Implements BP v2-api-melange-integration
* Adds v2 Plugin specification
* Refactors SQLAlchemy usage for multiple BASE's

Change-Id: I45f008f181c18269afdfe4a9b589a7c5ae56d225

12 years agoBinaries should report versions.
Harsh Prasad [Mon, 11 Jun 2012 06:55:18 +0000 (12:25 +0530)]
Binaries should report versions.

Bug #1004966.

Added the version_string() and removed the extra '%' for the quantum-server binary.

Change-Id: Ic1f3e2eb9a742bdfb63df6f901e579349f04f3ec

12 years agoFix up test running to match jenkins expectation.
Monty Taylor [Fri, 8 Jun 2012 23:46:37 +0000 (19:46 -0400)]
Fix up test running to match jenkins expectation.

Change-Id: I215cd92d707f81ed481897704b31188017a5a8b8

12 years agoAdd build_sphinx options.
Clark Boylan [Fri, 8 Jun 2012 21:26:58 +0000 (14:26 -0700)]
Add build_sphinx options.

To better facilitate the building and publishing of sphinx
documentation by Jenkins we are moving all openstack projects with
sphinx documentation to a common doc tree structure. Documentation
goes in project/doc and build results go in project/doc/build.

Change-Id: I672fbd296e2b8f1da1eede74d6f0c7a26345cf74

12 years agoRemove unused imports
Zhongyue Luo [Fri, 8 Jun 2012 01:52:20 +0000 (09:52 +0800)]
Remove unused imports

Fixes bug #1010276

Removed unused imports found by:
find . -type f -name "*py" -exec pylint -r n {} \; | grep -E "Unused imp|^\*"

Change-Id: Ie2ca545ecfaadd033652554c9e59d6a83d44ed09

12 years agoMerge "Bug #1002605"
Jenkins [Thu, 7 Jun 2012 16:27:11 +0000 (16:27 +0000)]
Merge "Bug #1002605"

12 years agoQuantum should use openstack.common.jsonutils
Zhongyue Luo [Thu, 7 Jun 2012 02:20:25 +0000 (10:20 +0800)]
Quantum should use openstack.common.jsonutils

Implements blueprint use-common-jsonutils

1. Edit openstack-common.conf and import quantum/openstack/common/jsonutils.py
2. Remove json package imports and replace with jsonutils
3. Remove json related functions in common/utils.py

Change-Id: Id5abc49175899fa4d83e613f852aaaac539ecfcb

12 years agoMerge "Remove hardcoded version for pep8 from tools/test-requires"
Jenkins [Thu, 7 Jun 2012 02:49:10 +0000 (02:49 +0000)]
Merge "Remove hardcoded version for pep8 from tools/test-requires"

12 years agoMerge "Add common dir for shared agent code, add OVS lib."
Jenkins [Wed, 6 Jun 2012 22:16:01 +0000 (22:16 +0000)]
Merge "Add common dir for shared agent code, add OVS lib."

12 years agoMerge "fix bug lp:1007557,remove unused functions in utils.py."
Jenkins [Wed, 6 Jun 2012 20:08:41 +0000 (20:08 +0000)]
Merge "fix bug lp:1007557,remove unused functions in utils.py."

12 years agoMerge "Register enable_tunneling as bool opt."
Jenkins [Wed, 6 Jun 2012 20:08:11 +0000 (20:08 +0000)]
Merge "Register enable_tunneling as bool opt."

12 years agoRemove hardcoded version for pep8 from tools/test-requires
Dan Wendlandt [Wed, 6 Jun 2012 19:41:13 +0000 (12:41 -0700)]
Remove hardcoded version for pep8 from tools/test-requires

In email discussions we decided that the master branch should always
pull in the lastest version of the pep8 tool, which keeps us closest
to the real pep-8 document.  Therefore, I'm removing the hardcoded
version here to match the lack of a pep8 version in tox.ini (which is
what the CI infrastructure uses when running the gating pep8 checks).

Note that your pep8 version will only update when you re-run
pip install --upgrade -r tools/test-requires .

Change-Id: I242cb042cff5f5969aa50d40312f87979191c7b7

12 years agoMerge "Bug #1007153"
Jenkins [Wed, 6 Jun 2012 19:09:17 +0000 (19:09 +0000)]
Merge "Bug #1007153"

12 years agoAuthN support for Quantum
Kevin L. Mitchell [Wed, 30 May 2012 23:10:46 +0000 (18:10 -0500)]
AuthN support for Quantum

Adds authentication support for Quantum.  Generates a context object
and stuffs it into the 'quantum.context' variable in the WSGI environment.
This will be used in conjunction with authZ, later.

Partially implements blueprint authorization-support-for-quantum.

Change-Id: I8af171c2f11a08db5ee41e609d60ad203548650d

12 years agofix bug lp:1007557,remove unused functions in utils.py.
Yaguang Tang [Tue, 5 Jun 2012 05:48:01 +0000 (13:48 +0800)]
fix bug lp:1007557,remove unused functions in utils.py.

Change-Id: Ic8cfe61effd357c49f651fd6cd6e6b721f6addd1

12 years agoAdd common dir for shared agent code, add OVS lib.
Dan Wendlandt [Tue, 5 Jun 2012 05:07:27 +0000 (22:07 -0700)]
Add common dir for shared agent code, add OVS lib.

bp quantum-agent-common

Adds a common directory that can be used for code shared by agents for
different plugins.  Also seeds this directory with an OVS library,
removing that code from the openvswitch plugin itself.  This code
can then be leveraged by other plugins (e.g., Ryu) who have similar code.

Also add a suite of mox-based tests for OVS lib.

Also add more powerful OVS flow expression builder as suggested by
salv-orlando, plus additional flow expression testing.

Note: the expectation is that this directory will be used for much of the
agent functionality that is similar to what Nova's nova/network/linux_net.py
file included, such as iptables manipulation, dhcp manipulation, etc.

People should be careful about changing code in this directory in a
non-backward compatible way, as other plugins may be using the code as well.

Change-Id: I8fd15ec6b8016e85a3f02e0d756a3fd61b1cab15

12 years agoMerge "Quantum should use openstack.common.importutils"
Jenkins [Tue, 5 Jun 2012 02:03:52 +0000 (02:03 +0000)]
Merge "Quantum should use openstack.common.importutils"

12 years agoBug #1007153
Juliano Martinez [Thu, 31 May 2012 21:51:30 +0000 (18:51 -0300)]
Bug #1007153

XS should not have the centos repo enabled by quantum this can break the system, also is possible to get the sqlalchemy from epel and avoid unneeded packages on the system.

Using epel rpm and leave it disabled after use

Change-Id: If6673e59afc545e51df3625d8259ec3fca9aaefb

12 years agoMerge "Fix linux bridge section name Bug #1006684"
Jenkins [Mon, 4 Jun 2012 14:04:56 +0000 (14:04 +0000)]
Merge "Fix linux bridge section name Bug #1006684"

12 years agoRegister enable_tunneling as bool opt.
Yong Sheng Gong [Mon, 4 Jun 2012 07:18:29 +0000 (15:18 +0800)]
Register enable_tunneling as bool opt.

Bug #1008346

Register enable_tunneling as bool opt, and add test cases.

Change-Id: Ibacf18752430d5e0ed1ab9c17f5370e4fd63ede2

12 years agoQuantum should use openstack.common.importutils
Zhongyue Luo [Mon, 4 Jun 2012 03:32:17 +0000 (11:32 +0800)]
Quantum should use openstack.common.importutils

Implements blueprint use-common-importutils

Change-Id: Ib71a557ea6090d5c8d789b1e4c7b17855f7ee814

12 years agoPEP8 fixes
Jason Kölker [Fri, 1 Jun 2012 15:50:36 +0000 (10:50 -0500)]
PEP8 fixes

Change-Id: Iab4c2ada2bfcb99452f940666b25cb1f7d4d7e58

12 years agoBug #1002605
Juliano Martinez [Fri, 1 Jun 2012 14:31:40 +0000 (11:31 -0300)]
Bug #1002605

update webob to be version 1.2 or above

It's running without any issue with 1.2, the exception problem was caused
by WebTest. We should use at least version 1.3.3 (supplied by Ubuntu 12.04 and Debian Wheezy)

Version to WebTest==1.3.3

Change-Id: Ia8ef543e32ae46f503dd52e93bed4290d077c286

12 years agoAutomatically determine Quantum version from source
Jason Kölker [Thu, 31 May 2012 21:00:13 +0000 (16:00 -0500)]
Automatically determine Quantum version from source

* Fixes LP1007132
* Adds keystone link
* removes __init__.py since doc/source is not a python module

Change-Id: I6a3234fa760ca23889e352735669547ad9afedf8

12 years agoFix linux bridge section name
Yong Sheng Gong [Wed, 30 May 2012 05:59:52 +0000 (13:59 +0800)]
Fix linux bridge section name
Bug #1006684

Change-Id: Ic7a97179d6fbb90f8c7f544a5725e1ff56fd9653

12 years agoRemove the reference to non existing exception by linuxbridgeplugin.
Yong Sheng Gong [Wed, 30 May 2012 05:59:52 +0000 (13:59 +0800)]
Remove the reference to non existing exception by linuxbridgeplugin.

Bug #1006221

According to plugin api of QuantumPluginBase, unplug_interface
should only raise exception.NetworkNotFound and exception.PortNotFound.
To unplug a non-attached port should not raise Exception.
After this modification, to unplug an non-attached port will have no impact.
In addition, I remove the 'network = db.network_get(net_id)' since
 'db.validate_port_ownership(tenant_id, net_id, port_id)' statement has taken
care of the check.

patch 2: split test case to test it exclusively compared to patch 1.
patch 3: remove added test statement in previous test case

Change-Id: I437c3f13fa7a81aeabcdfca7ba03e94a0a7aa32b

12 years agobug #1006281
Edgar Magana [Wed, 30 May 2012 08:27:47 +0000 (01:27 -0700)]
bug #1006281

Removing extra switchport line for NX-OS snippet.

Change-Id: Ib3530af9aa885a719cb712554d05e7d70834186a

12 years agoMerge "Parse linuxbridge plugins using openstack.common.cfg"
Jenkins [Wed, 30 May 2012 00:13:51 +0000 (00:13 +0000)]
Merge "Parse linuxbridge plugins using openstack.common.cfg"

12 years agoMerge "Bug #1004584"
Jenkins [Tue, 29 May 2012 23:02:28 +0000 (23:02 +0000)]
Merge "Bug #1004584"

12 years agoMerge "fix errors in database test cases."
Jenkins [Tue, 29 May 2012 20:18:32 +0000 (20:18 +0000)]
Merge "fix errors in database test cases."

12 years agoParse linuxbridge plugins using openstack.common.cfg
Gary Kotton [Tue, 29 May 2012 12:19:45 +0000 (08:19 -0400)]
Parse linuxbridge plugins using openstack.common.cfg

Implements the blueprint use-common-cfg

In order for the linuxbridge plugin to use the rpc code soon to be merged into
openstack-common, we need to parse our configuration using cfg. Here we
make the most simple, backwards compatible change in that direction.

The same is relevant for the openvswitch implementation

Fixes after comments.

Change-Id: I70fc1898a802cb4198f72741453283d114added2

12 years agoBug #1004584
Aaron Rosen [Fri, 25 May 2012 22:20:55 +0000 (15:20 -0700)]
Bug #1004584

When running ovs_quantum_agent in tunneling mode and a new tunnel_ip is added while
an agent is running the following exception below occurs. This causes the agent to
no longer function since it becomes caught in a loop.

ERROR:__main__:Main-loop Exception:
Traceback (most recent call last):
  File "ovs_quantum_agent.py", line 583, in daemon_loop
    self.manage_tunnels(tunnel_ips, old_tunnel_ips, db)
  File "ovs_quantum_agent.py", line 550, in manage_tunnels
    self.add_tun_br_flows_for_local_vlan(lv_obj)
AttributeError: 'OVSQuantumTunnelAgent' object has no attribute 'add_tun_br_flows_for_local_vlan'

Change-Id: Id03dc4a12a0114c8597cb90f4eabcdd3dc9b3f5c

12 years agofix some pylint warnings.
Yong Sheng Gong [Fri, 25 May 2012 12:10:07 +0000 (20:10 +0800)]
fix some pylint warnings.

1. Parent class should have instance variables used in its method(s).
2. remove some unused imports
Patch 2: fix according to comments
Patch 4: fix problem under pep8 1.1
Change-Id: Iafd89a6017b30484fb8da50219be6b4ae073f083

12 years agofix errors in database test cases.
Yong Sheng Gong [Fri, 25 May 2012 01:51:04 +0000 (09:51 +0800)]
fix errors in database test cases.

fix errors in database test cases, add one test case to tets port update.

Change-Id: I52108a55924d3ab750a8c453a80ed6abdd62bb23

12 years agoLog the exception so app loading issues can be debuged
Jason Kölker [Thu, 24 May 2012 17:17:21 +0000 (12:17 -0500)]
Log the exception so app loading issues can be debuged

* Fixes LP1004062

Change-Id: Iae04f2789fe310a52550354463fe109c13e8ceeb

12 years agoremove unneeded import from OVS agent that break 2.4 compat
Dan Wendlandt [Tue, 22 May 2012 20:50:20 +0000 (13:50 -0700)]
remove unneeded import from OVS agent that break 2.4 compat

bug 1000809

Change-Id: I95b1143702bc8f06067969c6b7040eea861bb56b

12 years agoblueprint man-support and fix documentation build
Gary Kotton [Mon, 7 May 2012 08:45:44 +0000 (04:45 -0400)]
blueprint man-support and fix documentation build
bug 995283

Changes after initial comments

Removed spaces

Updates after comments

Remove white spaces

Fix text and remove empty files

Remove config.py

Updated to be similar to the keystone page

Updated afetr comments

Change-Id: If9240114ae31d7120c708cdcf883e8fe4c7d2bb2

12 years agoMerge "Fix print error for linux bridge bindings bug 1001941"
Jenkins [Mon, 21 May 2012 14:15:37 +0000 (14:15 +0000)]
Merge "Fix print error for linux bridge bindings bug 1001941"

12 years agoFix print error for linux bridge bindings
Gary Kotton [Tue, 15 May 2012 07:33:04 +0000 (03:33 -0400)]
Fix print error for linux bridge bindings
bug 1001941

Change-Id: I04d5fad62102d3d7f55ea511a5c14d730d003eb4

12 years agoAdd HACKING.rst to tarball generation
Gary Kotton [Tue, 15 May 2012 07:33:04 +0000 (03:33 -0400)]
Add HACKING.rst to tarball generation
bug 1001220

Change-Id: I808f8d50dc77fc633728e29708802e8292240e84

12 years agofall back to `ip link` when `ip tuntap` unavailable
Gary Kotton [Tue, 15 May 2012 07:33:04 +0000 (03:33 -0400)]
fall back to `ip link` when `ip tuntap` unavailable
bug 989868

In the event that the command "ip tuntap" is not found then a exception will
be raised and the command "ip link" will be perfomed.

Changes following comments

More appropriate error message

Same style for log/error messages

Change-Id: Ia912e189b73dd0d112b7ef4eefbb7245ee595b54

12 years agoCisco plugin CLI call to quantumclient CLI
mat [Wed, 16 May 2012 14:16:43 +0000 (16:16 +0200)]
Cisco plugin CLI call to quantumclient CLI

when Cisco plugin CLI is used, it wil call the quantumclient CLI if the command is not in its extensions.
the version of the Quantum API must be specified when the the Cisco plugin CLI is looking for Quantum commands.

Bug 1000251

Change-Id: I3e4039edb7cb79411fc60677ef6f99fca8007dc9

12 years agoCalling Super method from QuantumPortAwareScheduler.__init__
mat [Tue, 15 May 2012 15:35:12 +0000 (17:35 +0200)]
Calling Super method from QuantumPortAwareScheduler.__init__

the quantum.plugins.cisco.nova.quantum_port_aware_scheduler.QuantumPortAwareScheduler class wasn't calling its superclass __init__.
the host_manager attribute of driver.Scheduler class wasn't initialized, and the scheduler was crashing when it was receiving a host message via amqp.

Fixes bug 994652

Change-Id: I733d80df8f87ff314f4233b10fa8afaf454eedf0

12 years agoMerge "Include AUTHORS in release package."
Jenkins [Tue, 15 May 2012 20:34:35 +0000 (20:34 +0000)]
Merge "Include AUTHORS in release package."

12 years agoOVS plugin: add tunnel ips to central database
Dan Wendlandt [Tue, 15 May 2012 19:41:52 +0000 (12:41 -0700)]
OVS plugin: add tunnel ips to central database

bp simplify-ovs-tunnel-mgmt

Makes the OVS plugin agent report its own IP address to the centralized
quantum database, and build its set of tunnels based on the contents of
this centralized database.  This removes the need for a removes need for
a 'remote-ips' file on each compute node that needs to be updated
when a new host is added.

Also:
- simplifies error handling within tunnel manager daemon_loop
- fixes issues with operational status not working for tunnel-mode
- fixes issue that not-stripping vlan of tunneled packet potentially
crashes OVS, causing flows to get wiped.

Change-Id: I4d285669e29beecf745fe620581fa6bc332a446c

12 years agoInclude AUTHORS in release package.
Bhuvan Arumugam [Mon, 7 May 2012 03:27:26 +0000 (20:27 -0700)]
Include AUTHORS in release package.

Fixes Bug #976267.

Include AUTHORS file in release package. The file is generated
automatically from git. Handle different combination for mailmap
records. Include test case to verify this fix.

* MANIFEST.in
  Include AUTHORS file in release package.

* .gitignore
  Add AUTHORS file.

* quantum/openstack/common/setup.py
  generate_authors(): New method to create AUTHORS file. If
  AUTHORS.in file exists, append it's content to AUTHORS file.
  parse_mailmap(): Handle all mailmap combination while parsing.

* setup.py
  Import the new method.
  Generate AUTHORS file before creating the package.

* quantum/tests/unit/test_setup.py
  New test script to verify different combination of records
  in mailmap file.

Change-Id: I220e8a20c96d37df3fa2ba0424e8372496e67895

12 years agoMerge "blueprint database-common bug 995438"
Jenkins [Sat, 12 May 2012 18:55:57 +0000 (18:55 +0000)]
Merge "blueprint database-common bug 995438"