Walter A. Boring IV [Mon, 30 Sep 2013 22:45:28 +0000 (15:45 -0700)]
Pass through args and kwargs in brick connectors
This is a change needed to help remove CONF usage
in the brick/remotefs/RemoteFsClient.
RemoteFsClient can then pull the values from the caller.
Change-Id: Ie1ff2a39b92c4150fec4a3191367797a260b30ec
Partial-Bug: #
1230066
Walter A. Boring IV [Mon, 30 Sep 2013 18:07:46 +0000 (11:07 -0700)]
Clean CONF out of brick initiator
This is part 1 of the work needed to
remove CONF from the brick subproject.
This patch removes the CONF usage
completely from the initiator portion of brick.
Change-Id: I62cf72214db9d4296ae4c5b09bd21fb53664c117
Partial-Bug: #
1230066
Jenkins [Tue, 1 Oct 2013 21:00:49 +0000 (21:00 +0000)]
Merge "Fixes backup with multiple volume backend"
Jenkins [Tue, 1 Oct 2013 21:00:14 +0000 (21:00 +0000)]
Merge "Fix finish_volume_migration() on SQLAlchemy 0.8.x"
Jenkins [Tue, 1 Oct 2013 13:52:58 +0000 (13:52 +0000)]
Merge "Fix translation of CinderExceptions in REST API"
Jenkins [Tue, 1 Oct 2013 13:24:38 +0000 (13:24 +0000)]
Merge "Fix mandatory and optional args for create_volume"
Jenkins [Tue, 1 Oct 2013 13:20:16 +0000 (13:20 +0000)]
Merge "Fix Huawei HVS driver attaching volume error"
Jenkins [Tue, 1 Oct 2013 10:40:45 +0000 (10:40 +0000)]
Merge "Add XML response tests for qos specs manage ext"
Jenkins [Tue, 1 Oct 2013 08:50:08 +0000 (08:50 +0000)]
Merge "Set vol driver initialized before deleting volumes"
Mike Perez [Mon, 30 Sep 2013 03:18:55 +0000 (20:18 -0700)]
Add XML response tests for qos specs manage ext
Make sure XML serializing is working for qos spec index and show, as
well as association show.
Change-Id: If678cf9201c3ba218a485999e11fc034a06495d4
Edward Hope-Morley [Wed, 25 Sep 2013 23:13:42 +0000 (00:13 +0100)]
Fixes backup with multiple volume backend
The backup service now keeps a dictionary of managers
for each type of volume backend. If multi backend is
not in use (and volume_type is None) the current
volume_driver is used.
Change-Id: I66e91f3ce2cffaf2e2d07edfddc08b1480e2a37c
Fixes: bug 1228223
John Griffith [Mon, 30 Sep 2013 14:45:52 +0000 (08:45 -0600)]
Dont retry if target creation succeeds
The target creation retry loop was not breaking when
the target was succesfully created. This is "sometimes" ok,
however in other cases this will actually cause a failure in
the second create and the backing Lun will be deleted and not
created again succesfully due most likely to a busy status on the
target.
Add a break in the try block.
Change-Id: I875f6302868651b5b42d4796cd2714fba35e525e
Closes-Bug: #
1226337
Jenkins [Mon, 30 Sep 2013 14:41:12 +0000 (14:41 +0000)]
Merge "Fix chown fail for nfs file without necessary permission"
Jenkins [Mon, 30 Sep 2013 09:08:21 +0000 (09:08 +0000)]
Merge "Fix XML serializer for QoS Specs extension"
Jenkins [Mon, 30 Sep 2013 05:31:16 +0000 (05:31 +0000)]
Merge "Add debug logging for targets"
Jenkins [Mon, 30 Sep 2013 05:31:14 +0000 (05:31 +0000)]
Merge "Use module units for some drivers"
OpenStack Jenkins [Mon, 30 Sep 2013 05:31:11 +0000 (05:31 +0000)]
Merge "Imported Translations from Transifex"
Jenkins [Mon, 30 Sep 2013 05:31:09 +0000 (05:31 +0000)]
Merge "Add error logs for Huawei driver"
Jenkins [Mon, 30 Sep 2013 05:00:59 +0000 (05:00 +0000)]
Merge "Allow upgrade from Grizzly with ThinLVMVolumeDriver"
Zhiteng Huang [Wed, 25 Sep 2013 08:40:41 +0000 (16:40 +0800)]
Fix XML serializer for QoS Specs extension
This patch fixes XML serializer for QoS Specs exension calls like
list(), show(), associations(). Note that using XML as input for
create(), update() doesn't support yet.
Closes-Bug: #
1229619
Change-Id: I2eab9d69e05bb03269b51731458994d6268ac852
Jenkins [Mon, 30 Sep 2013 03:46:52 +0000 (03:46 +0000)]
Merge "Fix type change in bootable setting of volume view"
Jenkins [Sun, 29 Sep 2013 18:47:13 +0000 (18:47 +0000)]
Merge "Update OpenStack Style Commandments link"
zhangchao010 [Wed, 25 Sep 2013 15:31:04 +0000 (23:31 +0800)]
Fix Huawei HVS driver attaching volume error
If iSCSI initiator is not added to host, we will get https errors
for we find the initiator info by sending url with this initiator name.
This patch fixes the way of getting the initiator info.
First, get the all initiator info.
Then, find the one we need by name.
Closes-bug: #
1230296
Change-Id: I92620374923fa136ee71fe6eb3af6e4c78a3d66b
John Griffith [Sun, 29 Sep 2013 16:01:58 +0000 (10:01 -0600)]
Add debug logging for targets
Seems we may be failing target create silently,
the situation appears to be that the actual device
lun is not created. This has been appearing in the
gates on create from snapshot.
This change adds some logging that will help us determine
if it's the actual create, or if it's the attempted update
while the dd process is possibly holding the volume in a busy
state causing the target update to add lun 1 to fail.
Change-Id: If5d4219dedae4649982fa9c13f131bf5f38fb7c4
Jenkins [Sun, 29 Sep 2013 08:06:56 +0000 (08:06 +0000)]
Merge "Clean CONF out of brick exception"
OpenStack Jenkins [Sun, 29 Sep 2013 06:08:29 +0000 (06:08 +0000)]
Imported Translations from Transifex
Change-Id: Ie27dccba52813603799f958b122a6f6287c0e9a8
Mike Perez [Sun, 29 Sep 2013 06:01:11 +0000 (23:01 -0700)]
Update OpenStack Style Commandments link
The current link in the HACKING file is broken. This references the
correct location for contributors to view.
Change-Id: I614f78fdea32025c2c5cf9599c698dde9c81ab21
Jenkins [Sat, 28 Sep 2013 06:15:28 +0000 (06:15 +0000)]
Merge "Get host group id when Huawei driver initializing"
Bill Owen [Fri, 27 Sep 2013 18:22:57 +0000 (11:22 -0700)]
Set vol driver initialized before deleting volumes
Move the call to set_initialized before calling delete_volume in
init_host. The delete_volume method has a precondition that the
driver be initialized.
Closes-Bug: #
1232177
Change-Id: Ie73bd30e0ab80d489ab61ba8a60fac51ccb505b5
zhangchao010 [Tue, 24 Sep 2013 18:07:05 +0000 (02:07 +0800)]
Add error logs for Huawei driver
Log some errors to avoid losing the exception messages.
HVS driver do repeated judgements for JSON results, here add error
logs and replace these judgement codes with a assertion function.
fixes bug
1229877
Change-Id: Icd1e859566e07c0f02aa0b2d5c136a2048524527
Jenkins [Thu, 26 Sep 2013 00:27:45 +0000 (00:27 +0000)]
Merge "Pass correct args to vol_rpc create_volume calls"
Walter A. Boring IV [Wed, 25 Sep 2013 21:48:16 +0000 (14:48 -0700)]
Clean CONF out of brick exception
This is part 3 of the work needed to
remove CONF from the brick subproject.
This patch removes the CONF usage in
the brick exception.
Fixes bug #
1230066
Change-Id: Id1ad704a613bc7e2657a65407932a8ef3706bf92
Jenkins [Wed, 25 Sep 2013 20:58:51 +0000 (20:58 +0000)]
Merge "Sync gettextutils from oslo"
Luis A. Garcia [Tue, 24 Sep 2013 22:07:55 +0000 (22:07 +0000)]
Fix translation of CinderExceptions in REST API
When creating a Fault from a CinderException wrapped in an
HTTPException, we were converting the inner explanation to unicode
before it was able to reach the Fault's call() method which is where
translation occurs, and unicode objects can't be translated.
This patch preserves the CinderException's Message object and puts it in
another Message object as the explanation to the HTTPException so it can
be translated.
Fixes bug: #
1229967
Change-Id: Ida71908b639da32b4b85846a117ef21da2fe685b
Eric Harney [Wed, 25 Sep 2013 19:43:32 +0000 (15:43 -0400)]
Allow upgrade from Grizzly with ThinLVMVolumeDriver
In Grizzly, LVM thin provisioning was used by setting
volume_driver=...ThinLVMVolumeDriver. In Havana this
functionality has moved under the standard LVM driver
with the option "lvm_type=thin" used to enable it.
We should account for the old volume_driver class path
so that the volume service behaves as expected for users
upgrading from Grizzly ThinLVM configurations.
Closes-Bug: #
1231116
Change-Id: Ic29f0e5c1036232078af5c6d83c61c75a35cccd4
zhangchao010 [Wed, 25 Sep 2013 17:17:09 +0000 (01:17 +0800)]
Use module units for some drivers
Use module units instead of number for some drivers.
Change-Id: I429590b6955f56d7ba9687b6898808a3f3bc3796
zhangchao010 [Wed, 25 Sep 2013 16:00:20 +0000 (00:00 +0800)]
Get host group id when Huawei driver initializing
Get host group id when Huawei driver initializing to make sure
host group id won't be None after cinder node host sys reboot.
fixes bug
1230372
Change-Id: Ia3d5de116804930b2bb0035e4c991ebb9801ee76
Jenkins [Wed, 25 Sep 2013 10:11:47 +0000 (10:11 +0000)]
Merge "LVM volume_clear: error on unexpected inputs"
Avishay Traeger [Wed, 25 Sep 2013 05:41:21 +0000 (08:41 +0300)]
Fix mandatory and optional args for create_volume
Calls to create_volume (both volume_rpcapi and scheduler_rpcapi) pass
mandatory args as optional and reverse. This patch fixes the calls to be
according to the function definition.
Also, fix the call to create_volume in the migration code where
allow_reschedule defaults to True, but we don't pass request_spec so it
prints a warning and disables it.
Change-Id: I9509f88866e0ae182f90ebdfca1fcf415ca60d19
Closes-Bug: #
1230069
Jenkins [Wed, 25 Sep 2013 07:48:48 +0000 (07:48 +0000)]
Merge "Revert "Fix volume_rpcapi calls for chance/simple scheds""
Jenkins [Wed, 25 Sep 2013 06:36:57 +0000 (06:36 +0000)]
Merge "Fix processutils.execute errors on windows"
Mike Perez [Wed, 25 Sep 2013 03:55:04 +0000 (20:55 -0700)]
Pass correct args to vol_rpc create_volume calls
In the chance and simple scheduler, create volume was originally using
snapshot_id and image_id for request_spec and filter_properties. This
corrects that by passing the correct arguments and keyword arguments to
create_volume.
Change-Id: Icbcfbfb28f36e1f75519bf5ad6fcbcc12a9b4ec1
Closes-Bug: #
1212710
Jenkins [Wed, 25 Sep 2013 03:06:24 +0000 (03:06 +0000)]
Merge "VMware: Handles no datastores case"
Jenkins [Wed, 25 Sep 2013 00:08:51 +0000 (00:08 +0000)]
Merge "Fix NetApp iscsi drivers for cinder backup"
Jenkins [Wed, 25 Sep 2013 00:08:49 +0000 (00:08 +0000)]
Merge "Fix check for mount.nfs helper installation"
Jenkins [Wed, 25 Sep 2013 00:08:46 +0000 (00:08 +0000)]
Merge "Allow v2 Volume API to create volume with type name"
Jenkins [Wed, 25 Sep 2013 00:08:44 +0000 (00:08 +0000)]
Merge "Update rootwrap with code from oslo"
Alessandro Pilotti [Tue, 24 Sep 2013 23:30:33 +0000 (02:30 +0300)]
Fix processutils.execute errors on windows
Added a check for existence of geteuid.
This fix is related to oslo-incubator commit:
d6a963e911b8456c06dceb5ee3cc88a70c08bf82
Fixes bug #
1209410
Change-Id: Idd716a2104ba3fa24610825ce4bf9c8e2c6d490b
Jenkins [Tue, 24 Sep 2013 23:28:56 +0000 (23:28 +0000)]
Merge "Added mapper for update_all on snapshot_metadata"
Luis A. Garcia [Tue, 24 Sep 2013 22:17:05 +0000 (22:17 +0000)]
Sync gettextutils from oslo
Add type check for Message params when setting locale to avoid
AttributeError.
Fixes bug: #
1229364
Change-Id: I6fe55ebc4eea5fef1d335ad83a84c4879f7f06f9
OpenStack Jenkins [Tue, 24 Sep 2013 19:29:19 +0000 (19:29 +0000)]
Merge "Imported Translations from Transifex"
Eric Harney [Fri, 13 Sep 2013 20:56:44 +0000 (16:56 -0400)]
LVM volume_clear: error on unexpected inputs
Currently if a user configures
volume_clear='non_existent_volume_clearer' in cinder.conf,
the LVM driver will silently delete a volume and not wipe it.
Instead, the delete operation should fail, leaving the volume
in the 'error_deleting' state.
Also fail if the volume reference does not contain either a
'size' or 'volume_size' field.
Closes-Bug: #
1225194
Change-Id: I78fec32d7d5aeaa8e2deeac43066ca5e2e26d9ca
Dan Prince [Tue, 24 Sep 2013 17:49:26 +0000 (13:49 -0400)]
Revert "Fix volume_rpcapi calls for chance/simple scheds"
This reverts commit
d5cd6528f361979b073aabd036be0d28dc1c4b95.
Closes-Bug: #
1229867
Change-Id: Iee866ddb08d52642bc36bd6ae82bd0d7283cad8e
Jenkins [Tue, 24 Sep 2013 17:11:11 +0000 (17:11 +0000)]
Merge "Fix volume_rpcapi calls for chance/simple scheds"
Jenkins [Tue, 24 Sep 2013 17:00:32 +0000 (17:00 +0000)]
Merge "Specific /usr/local/bin/hus-cmd rootwrap filter"
Roman Podolyaka [Mon, 23 Sep 2013 14:58:54 +0000 (17:58 +0300)]
Fix finish_volume_migration() on SQLAlchemy 0.8.x
In SQAlchemy 0.8.x "Unconsumed column names" warning became
an exception, so refering to a non-existent column in insert()
or update() call raises an error.
finish_volume_migration() calls Session.update() method passing
values of two non-existent columns as arguments (volume_metadata,
volume_admin_metadata, volume_type). These two are not table columns
at all, but rather SQLAlchemy models relationships.
As SQLAlchemy ORM implements Unity of Work pattern, we should not
really track changes to a model instance manually at all, because
Session class already does it for us. finish_volume_migration()
is refactored to take benefit of this fact.
Fixes bug
1206561
Change-Id: I4513e3155a7dc6dcbd1c95aa9c14d1e1e5d02ab4
Kartik Bommepally [Tue, 24 Sep 2013 10:58:10 +0000 (03:58 -0700)]
VMware: Handles no datastores case
If the host does not have datastores mounted or is in maintenance mode
then it reports empty datastores list. Modified code to ignore such cases.
Fixes bug:
1229653
Change-Id: I8f076d7b652181988b45738664a0d549c0b5ff9b
Chang Bo Guo [Tue, 24 Sep 2013 09:05:35 +0000 (02:05 -0700)]
Fixes some typos in cinder
Just some typos
Change-Id: Ic0d99d2ec2152145e0c58b8792f630cacdb7ac87
Zhongyue Luo [Tue, 24 Sep 2013 01:39:45 +0000 (09:39 +0800)]
Update rootwrap with code from oslo
These are all minor changes bringing cinder up to commit
c03f247
c03f247 Skip hidden files while traversion rootwrap filters
3f4d1d5 Fix os.getlogin() problem with no tty
fc04531 Send rootwrap exit error message to stderr
3663010 rootwrap: improve Python 3 compatibility
28395d9 Fixes files with wrong bitmode
Change-Id: I3a37f23a2617a7c69bc4be422f3fdcab8833e498
Thierry Carrez [Tue, 24 Sep 2013 08:20:56 +0000 (10:20 +0200)]
Specific /usr/local/bin/hus-cmd rootwrap filter
Add a specific filter for /usr/local/bin/hus-cmd, rather than adding
/usr/local/bin to the list of exec_path in rootwrap.conf. This allows to
sync rootwrap directly from oslo-incubator without having to edit the
default value for exec_dirs.
Change-Id: Ic264ca248d025fb5496fe0b48e8b3ec9376fb9e2
Zhiteng Huang [Tue, 24 Sep 2013 08:09:42 +0000 (16:09 +0800)]
Allow v2 Volume API to create volume with type name
v2 API only accepts volume type ID when creating volume, while v1
API allows both volume type name and ID (volume type name is unique
in Cinder). This patch enables v2 API to accept volume type name
as create() parameter. Aslo volume type validation code block
in v1 API create() is refactored to a slimmer version.
Change-Id: I4ee98b67a0a0e98ff4d402749e12b1335d45f64d
Close-bug:
1228835
Jenkins [Tue, 24 Sep 2013 06:32:28 +0000 (06:32 +0000)]
Merge "GPFS Driver missing clone depth limit for snapshots"
OpenStack Jenkins [Tue, 24 Sep 2013 06:07:55 +0000 (06:07 +0000)]
Imported Translations from Transifex
Change-Id: I769f3f31c66ad90176bc8d9381aac2539246984f
Avishay Traeger [Mon, 23 Sep 2013 18:18:56 +0000 (21:18 +0300)]
Fix volume_rpcapi calls for chance/simple scheds
Change the chance and simple schedulers to pass the snapshot_id and
image_id parameters correctly volume_rpcapi, so that their values reach
cinder-volume.
Change-Id: I0abbca1fa0445c5233387a0f17363fc092d39b88
Closes-Bug: #
1212710
Jenkins [Tue, 24 Sep 2013 05:23:26 +0000 (05:23 +0000)]
Merge "Add delete support for volume type encryption"
Jenkins [Tue, 24 Sep 2013 03:05:16 +0000 (03:05 +0000)]
Merge "Add sg_scan filter to rootwrap"
Jenkins [Mon, 23 Sep 2013 18:40:52 +0000 (18:40 +0000)]
Merge "Fixes vol restore discard final bytes unzeroed"
Jenkins [Mon, 23 Sep 2013 18:01:51 +0000 (18:01 +0000)]
Merge "Storwize/SVC: Optional CHAP authentication"
Jenkins [Mon, 23 Sep 2013 18:01:27 +0000 (18:01 +0000)]
Merge "Require assisted_volume_snapshots from novaclient"
Eric Harney [Tue, 3 Sep 2013 18:52:03 +0000 (14:52 -0400)]
Require assisted_volume_snapshots from novaclient
The "QEMU-assisted-snapshots for GlusterFS volumes" patch currently
does a try/except ImportError for the new assisted_volume_snapshots
extension in novaclient. That functionality is now in novaclient
2.15.0, so Cinder should consider this a hard requirement rather
than allowing it to be absent.
Change-Id: I5d5b4918f17f26706bed361cbbe8b369b10b0b98
Jenkins [Mon, 23 Sep 2013 17:04:49 +0000 (17:04 +0000)]
Merge "Fix over-indent in compute/nova"
Jenkins [Mon, 23 Sep 2013 15:59:01 +0000 (15:59 +0000)]
Merge "GlusterFS: Copy snap from correct source file"
Jenkins [Mon, 23 Sep 2013 15:58:59 +0000 (15:58 +0000)]
Merge "GlusterFS: Use image_utils for qemu-img calls"
Zhiteng Huang [Mon, 23 Sep 2013 15:51:05 +0000 (23:51 +0800)]
Fix over-indent in compute/nova
There are two lines in compute/nova.py that uses 8 spaces indent,
this simple patch correct those to 4 spaces.
Change-Id: I8f7849385ef59a085b5e3cc45954a2f2a19442ee
Jenkins [Mon, 23 Sep 2013 07:28:08 +0000 (07:28 +0000)]
Merge "Add a retry to create_iscsi_target for LVM"
Jenkins [Mon, 23 Sep 2013 07:28:01 +0000 (07:28 +0000)]
Merge "Fix issues with failed lvremove"
Jenkins [Mon, 23 Sep 2013 06:58:49 +0000 (06:58 +0000)]
Merge "Add extend to reference LVM driver"
Jenkins [Mon, 23 Sep 2013 06:20:05 +0000 (06:20 +0000)]
Merge "NetApp check for 7 mode controller version"
Jenkins [Mon, 23 Sep 2013 01:37:07 +0000 (01:37 +0000)]
Merge "Soft delete tmp migration volume"
Jenkins [Sun, 22 Sep 2013 16:57:19 +0000 (16:57 +0000)]
Merge "Remove default root_helper of sudo for remotefs"
Avishay Traeger [Sun, 22 Sep 2013 11:01:25 +0000 (14:01 +0300)]
Add sg_scan filter to rootwrap
The sg_scan command was missing from rootwrap.
Change-Id: I549b51e30c53eb588b02dc0892c8e32d2c66c6bb
Closes-Bug: #
1225102
Jenkins [Sat, 21 Sep 2013 04:51:12 +0000 (04:51 +0000)]
Merge "Add volume metadata to v2"
Jenkins [Fri, 20 Sep 2013 22:15:39 +0000 (22:15 +0000)]
Merge "Fix HP3PAR iSCSI path connection"
John Griffith [Fri, 20 Sep 2013 21:30:36 +0000 (21:30 +0000)]
Add extend to reference LVM driver
Somwhere along the way we somehow dropped
or missed implementing the extend functionality
in the reference LVM driver.
Add it.
Change-Id: Ib3efe16252b5efacce253688767df426117b2a44
Closes-Bug: #
1228358
John Griffith [Fri, 20 Sep 2013 20:55:46 +0000 (20:55 +0000)]
Fix issues with failed lvremove
There are some race conditions that
can cause problems with lvremove commands. In
most cases these seem to recover nicely just
with a simple retry of the lvremove. Adding
a udev settle seems to elimate the rest of them.
This is a difficult issue to reproduce, and there's
a suspiscion that it relates to failed target
creeates.
The patch adds a catch on the lvremove failure,
followed by a udevadm settle and a retry of the
lvremove. With the setup that I've been able
to reproduce this issue these changes have eliminated
any force delete failures.
The other option that had been proposed was using dmsetup remove
but there are concerns that this may cause problems.
Change-Id: I2a2b0d0f4fefd0daf9424ab96aaf87ba53ebc171
Closes-Bug: #
1191960
Jenkins [Fri, 20 Sep 2013 18:13:09 +0000 (18:13 +0000)]
Merge "Enforce driver is initialized"
Eric Harney [Mon, 9 Sep 2013 22:47:00 +0000 (18:47 -0400)]
GlusterFS: Copy snap from correct source file
The GlusterFS driver's copy_volume_from_snapshot was previously
not parsing the snapshot information to determine which backing
file to copy from, instead copying from the active file at all
times. This would result in the wrong data being supplied when
a volume is cloned from a snapshot.
Add a test for the copy_volume_from_snapshot method.
Closes-Bug: #
1222907
Change-Id: Ib829ca1a6812b61845f3b2eb9c5507779fa6ec15
Eric Harney [Sun, 8 Sep 2013 14:18:18 +0000 (10:18 -0400)]
GlusterFS: Use image_utils for qemu-img calls
Code added for GlusterFS snapshot support in Havana included
new code to parse qemu-img output. This removes this code
and uses image_utils qemu_img_info instead.
Add test to image_utils for parsing a different style of
qemu-img info output.
Improve GlusterFS driver test coverage with tests for cloning,
create from snapshot, and initialize_connection.
Closes-Bug: #
1224030
Change-Id: I8f1811b400c06edb3cd7416c52aa297921841e54
Walter A. Boring IV [Fri, 20 Sep 2013 17:33:54 +0000 (10:33 -0700)]
Remove default root_helper of sudo for remotefs
This patch removes the default root_helper of sudo
for the RemoteFsClient. We should be using the
cinder.utils.get_root_helper()
Fixes Bug #
1223879
Change-Id: I8ba61cd6ac09b85b9ca924a9cf43c2dcea8e6c15
John Griffith [Fri, 20 Sep 2013 02:47:22 +0000 (20:47 -0600)]
Add a retry to create_iscsi_target for LVM
There's a bug in the tgt driver where under certain
conditions where a race condition is present that can
result in tgtadm attempting re-use a target ID.
Testing this it seems that a retry will address this nicely
and cause tgtd to grab a new target ID and things are ok.
This patch adds a simple check/retry mechanism around the
iscsi_target_create in the LVM driver to catch this issue and
deal with it.
There are a number of bugs that it appears can be attributed to
this, but this patch is associated with the most predominant
clear cut version.
Closes-Bug #
1223469
Change-Id: I5126009f196adcafad55e73ff99a59262dd93dfe
Jim Branen [Fri, 20 Sep 2013 15:41:44 +0000 (08:41 -0700)]
Fix HP3PAR iSCSI path connection
The iSCSI paths are not correctly identified as ‘active’
when port information is requested from the hp3parclient
because the ‘active’ value is a Boolean not the string
‘true’.
Fixes Bug #
1224594
Change-Id: Ib10563cfc31c0628dc8b1edbba246398a3a11f34
saurabh [Fri, 20 Sep 2013 10:06:09 +0000 (15:36 +0530)]
Added mapper for update_all on snapshot_metadata
Snapshot metadata controller have action 'update_all'
but API for this not exposed for both v1 & v2
Change-Id: I4dcd8878a4ed75bd44494fd175bb66df67e54ebc
Closes-Bug: #
1228066
Mike Perez [Tue, 17 Sep 2013 09:41:59 +0000 (02:41 -0700)]
Add volume metadata to v2
This exposes volume metadata in the Cinder v2 API. This already exists
in v1 and was originally suppose to exist back with Grizzly, but appears
to have slipped.
Closes-Bug: #
1227979
Change-Id: I512dad591d7d491eca54a230d3cc290d9a349e6f
Walter A. Boring IV [Tue, 17 Sep 2013 00:05:27 +0000 (17:05 -0700)]
Enforce driver is initialized
This updates the volume manager and the
backup manager to enforce that the driver
has been initialized.
The managers call the driver in many places
without ensuring that the driver has been
properly initialized. When the driver fails
inside of do_setup(), the managers shouldn't
call the driver's set_initialized() method.
The managers now dump out the exception, and
exit the init_host, leaving the driver in
an uninitialized state.
Fixes bug #
1225897
Change-Id: I77b947f2a9fbe1b38f321511dba10fcd2fe1fe90
saurabh [Thu, 19 Sep 2013 18:07:35 +0000 (23:37 +0530)]
Added mapper for snapshot_metadata
cinder/api/v2/snapshot_metadata.py exist with all actions
but mapper missing for it.
Closes-bug:
1227799
Change-Id: I9a95c68a8de620626042951fa15a555621ebbc17
Jenkins [Fri, 20 Sep 2013 00:50:13 +0000 (00:50 +0000)]
Merge "NetApp fix create vol different size than snapshot"
Jenkins [Thu, 19 Sep 2013 23:36:03 +0000 (23:36 +0000)]
Merge "Add logging to prior to raising exceptions"
John Griffith [Thu, 19 Sep 2013 19:05:05 +0000 (13:05 -0600)]
Fix type change in bootable setting of volume view
Change Idd47a0a8069ee905b81c7aae562b82767ad91930 fixed a db
query issue, by removing the image_metadata querie in the get/show
methods.
The problem however is that we just passed the setting from the volume
object directly in the summary view builder. This results in changing
the type of the value from a string "true/false" to a bool True/False
which is no good.
This patch converts the object member back to a string like it used to
be so we don't break any compat or expectations in API behavior.
Fixes bug #
1227837
Change-Id: I55c0e25134ae429802ddf313d6d26f1fad19ca94
Walter A. Boring IV [Mon, 16 Sep 2013 22:31:20 +0000 (15:31 -0700)]
Add logging to prior to raising exceptions
This patch fixes an issue where exceptions
happen in the 3PAR drivers and the exceptions
aren't being logged to the log file.
Fixes bug #
1225235
Change-Id: I8ec26fe3bee65106e01e956472e06acf1d5b9f77
Jenkins [Thu, 19 Sep 2013 16:43:06 +0000 (16:43 +0000)]
Merge "Pass down root_helper in more cases"