]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/log
puppet-modules/puppetlabs-firewall.git
9 years agoMerge pull request #576 from nward/support_ipv6_nat
JT (Jonny) [Fri, 15 Jan 2016 13:36:00 +0000 (13:36 +0000)]
Merge pull request #576 from nward/support_ipv6_nat

Support IPv6 NAT on Linux 3.7+

9 years agoMerge pull request #578 from abednarik/fix/master/redhat_service_name_references
David Schmitt [Fri, 8 Jan 2016 14:16:24 +0000 (14:16 +0000)]
Merge pull request #578 from abednarik/fix/master/redhat_service_name_references

(MODULES-2783) Missing ip6tables service name

9 years ago(MODULES-2783) Missing ip6tables service name
abednarik [Wed, 4 Nov 2015 22:02:56 +0000 (19:02 -0300)]
(MODULES-2783) Missing ip6tables service name

Replaced hardcoded iptables service references with $service_name
variable.

9 years agoMerge pull request #596 from bmjen/fix-ci
Jesse Lovelace [Thu, 17 Dec 2015 17:59:36 +0000 (11:59 -0600)]
Merge pull request #596 from bmjen/fix-ci

(maint) fixes acceptance tests

9 years ago(maint) fixes acceptance tests
Bryan Jen [Thu, 17 Dec 2015 17:58:11 +0000 (10:58 -0700)]
(maint) fixes acceptance tests

9 years agoMerge pull request #595 from bmjen/fix-ci
Jesse Lovelace [Thu, 17 Dec 2015 15:39:59 +0000 (09:39 -0600)]
Merge pull request #595 from bmjen/fix-ci

(maint) fixes typo in firewall acceptance test.

9 years ago(maint) fixes typo in firewall acceptance test.
Bryan Jen [Thu, 17 Dec 2015 15:38:26 +0000 (08:38 -0700)]
(maint) fixes typo in firewall acceptance test.

9 years agoMerge pull request #594 from mentat/fix_ci_bug
Bryan Jen [Tue, 15 Dec 2015 15:57:06 +0000 (08:57 -0700)]
Merge pull request #594 from mentat/fix_ci_bug

Fix for CI acceptance fail.

9 years agoFix for CI acceptance fail.
Jesse Lovelace [Tue, 15 Dec 2015 15:35:13 +0000 (09:35 -0600)]
Fix for CI acceptance fail.

9 years agoMerge pull request #593 from mlosapio/feature/log-uid
TP Honey [Mon, 14 Dec 2015 15:02:16 +0000 (15:02 +0000)]
Merge pull request #593 from mlosapio/feature/log-uid

Adding in log_uid boolean for LOG

9 years agoAdding in log_uid boolean for LOG
Michael LoSapio [Wed, 18 Nov 2015 22:18:39 +0000 (17:18 -0500)]
Adding in log_uid boolean for LOG

9 years agoMerge pull request #579 from maxvozeler/fix/chain_f_fix
Jesse Lovelace [Thu, 10 Dec 2015 18:07:27 +0000 (12:07 -0600)]
Merge pull request #579 from maxvozeler/fix/chain_f_fix

(MODULES-2836) Fix handling of chains that contain '-f'

9 years agoFix handling of chain names that contain -f
Max Vozeler [Mon, 16 Nov 2015 13:01:35 +0000 (14:01 +0100)]
Fix handling of chain names that contain -f

9 years agoMerge pull request #592 from puppetlabs/1.7.x
TP Honey [Tue, 8 Dec 2015 15:26:56 +0000 (15:26 +0000)]
Merge pull request #592 from puppetlabs/1.7.x

Mergeback 1.7.x

9 years agoMerge pull request #580 from tphoney/release_1.7.2 1.7.x 1.7.2
JT (Jonny) [Mon, 7 Dec 2015 16:48:31 +0000 (16:48 +0000)]
Merge pull request #580 from tphoney/release_1.7.2

release prep 1.7.2

9 years agoMerge pull request #591 from jonnytpuppet/1.7.x_rel_prep_ci_fixes
David Schmitt [Fri, 4 Dec 2015 15:50:04 +0000 (15:50 +0000)]
Merge pull request #591 from jonnytpuppet/1.7.x_rel_prep_ci_fixes

1.7.x rel prep ci fixes

9 years agoUpdated logic to debian manifest file
Jonathan Tripathy [Thu, 3 Dec 2015 15:42:48 +0000 (15:42 +0000)]
Updated logic to debian manifest file

9 years ago(MAINT) - Commented out CLUSTERIP tests as there are suspicions that the
Jonathan Tripathy [Thu, 26 Nov 2015 16:48:18 +0000 (16:48 +0000)]
(MAINT) - Commented out CLUSTERIP tests as there are suspicions that the
ipt module is causing system reboots.

9 years agoUnit test fixes
Jonathan Tripathy [Thu, 26 Nov 2015 15:21:31 +0000 (15:21 +0000)]
Unit test fixes

9 years agoMore file renames
Jonathan Tripathy [Thu, 26 Nov 2015 14:33:23 +0000 (14:33 +0000)]
More file renames

9 years agoRename internal custom nodeset files
Jonathan Tripathy [Thu, 26 Nov 2015 14:14:15 +0000 (14:14 +0000)]
Rename internal custom nodeset files

9 years agoFurther nodeset changes from internal CI
Jonathan Tripathy [Wed, 25 Nov 2015 17:41:16 +0000 (17:41 +0000)]
Further nodeset changes from internal CI

9 years agoAdded nodeset files for internal Puppet CI.
Jonathan Tripathy [Tue, 24 Nov 2015 16:54:06 +0000 (16:54 +0000)]
Added nodeset files for internal Puppet CI.

9 years agoMerge pull request #590 from jonnytpuppet/fact_variable_fix
David Schmitt [Thu, 3 Dec 2015 15:48:07 +0000 (15:48 +0000)]
Merge pull request #590 from jonnytpuppet/fact_variable_fix

Updated logic to debian manifest file

9 years agoUpdated logic to debian manifest file
Jonathan Tripathy [Thu, 3 Dec 2015 15:42:48 +0000 (15:42 +0000)]
Updated logic to debian manifest file

9 years agoMerge pull request #589 from DavidS/modules-2866-add-sctp
David Schmitt [Thu, 3 Dec 2015 14:18:07 +0000 (14:18 +0000)]
Merge pull request #589 from DavidS/modules-2866-add-sctp

Add: sctp-protocol to "proto"-Parameter

9 years agoAdd: sctp-protocol to "proto"-Parameter
Nold [Tue, 24 Nov 2015 07:27:34 +0000 (08:27 +0100)]
Add: sctp-protocol to "proto"-Parameter

9 years agoMerge pull request #588 from jonnytpuppet/hang_fix2
Helen [Thu, 26 Nov 2015 16:51:20 +0000 (16:51 +0000)]
Merge pull request #588 from jonnytpuppet/hang_fix2

(MAINT) - Commented out CLUSTERIP tests as there are suspicions that the

9 years ago(MAINT) - Commented out CLUSTERIP tests as there are suspicions that the
Jonathan Tripathy [Thu, 26 Nov 2015 16:48:18 +0000 (16:48 +0000)]
(MAINT) - Commented out CLUSTERIP tests as there are suspicions that the
ipt module is causing system reboots.

9 years agoMerge pull request #587 from jonnytpuppet/unit_test_fix
David Schmitt [Thu, 26 Nov 2015 15:33:15 +0000 (15:33 +0000)]
Merge pull request #587 from jonnytpuppet/unit_test_fix

Unit test fixes

9 years agoUnit test fixes
Jonathan Tripathy [Thu, 26 Nov 2015 15:21:31 +0000 (15:21 +0000)]
Unit test fixes

9 years agoMerge pull request #586 from jonnytpuppet/hang_fix2
Helen [Thu, 26 Nov 2015 14:34:04 +0000 (14:34 +0000)]
Merge pull request #586 from jonnytpuppet/hang_fix2

More file renames

9 years agoMore file renames
Jonathan Tripathy [Thu, 26 Nov 2015 14:33:23 +0000 (14:33 +0000)]
More file renames

9 years agoMerge pull request #585 from jonnytpuppet/hang_fix2
TP Honey [Thu, 26 Nov 2015 14:16:52 +0000 (14:16 +0000)]
Merge pull request #585 from jonnytpuppet/hang_fix2

Rename internal custom nodeset files

9 years agoRename internal custom nodeset files
Jonathan Tripathy [Thu, 26 Nov 2015 14:14:15 +0000 (14:14 +0000)]
Rename internal custom nodeset files

9 years agoMerge pull request #584 from jonnytpuppet/hang_fix2
JT (Jonny) [Wed, 25 Nov 2015 17:57:10 +0000 (17:57 +0000)]
Merge pull request #584 from jonnytpuppet/hang_fix2

Further nodeset changes from internal CI

9 years agoFurther nodeset changes from internal CI
Jonathan Tripathy [Wed, 25 Nov 2015 17:41:16 +0000 (17:41 +0000)]
Further nodeset changes from internal CI

9 years agoMerge pull request #582 from jonnytpuppet/hang_fix
TP Honey [Wed, 25 Nov 2015 16:41:08 +0000 (16:41 +0000)]
Merge pull request #582 from jonnytpuppet/hang_fix

Added nodeset files for internal Puppet CI.

9 years agoAdded nodeset files for internal Puppet CI.
Jonathan Tripathy [Tue, 24 Nov 2015 16:54:06 +0000 (16:54 +0000)]
Added nodeset files for internal Puppet CI.

9 years agoMerge pull request #577 from reidmv/modules-1341
JT (Jonny) [Tue, 24 Nov 2015 15:58:00 +0000 (15:58 +0000)]
Merge pull request #577 from reidmv/modules-1341

(MODULES-1341) Recover when deleting absent rules

9 years agorelease prep 1.7.2
tphoney [Fri, 20 Nov 2015 11:59:26 +0000 (11:59 +0000)]
release prep 1.7.2

9 years agoMerge pull request #575 from werekraken/security_table
Bryan Jen [Fri, 20 Nov 2015 16:38:01 +0000 (09:38 -0700)]
Merge pull request #575 from werekraken/security_table

MODULES-2769 - Add security table for iptables.

9 years ago(MODULES-1341) Recover when deleting absent rules
Reid Vandewiele [Wed, 4 Nov 2015 18:40:20 +0000 (10:40 -0800)]
(MODULES-1341) Recover when deleting absent rules

Some types, specifically the resources type, will call Firewall
instances and then use generate to build and add to the catalog firewall
resources very early in a Puppet run. Later, those resources might be
removed as a side effect of another action, such as shutting down the
firewalld service.

Prior to this commit, Puppet would try to delete firewall resources
which were already absent, and throw an error. This commit adds an
exception catcher which will check to see if the rule being removed is
absent, and if so, consider the change a success even if the firewall
command failed. It will adjust the change message to reflect the
uncertainty over how the rule was removed, though it was verified
removed.

9 years agoAdd IPv6 NAT tests for Linux 3.7+ and update existing test to be for Linux 2.6
Nathan Ward [Sun, 1 Nov 2015 03:29:05 +0000 (16:29 +1300)]
Add IPv6 NAT tests for Linux 3.7+ and update existing test to be for Linux 2.6

9 years agoSupport IPv6 NAT in kernels with major version greater than, and equal to, 3.7.
Nathan Ward [Sun, 1 Nov 2015 03:05:56 +0000 (16:05 +1300)]
Support IPv6 NAT in kernels with major version greater than, and equal to, 3.7.

9 years agoAdd security table for iptables.
matt.cover [Fri, 30 Oct 2015 18:32:45 +0000 (11:32 -0700)]
Add security table for iptables.

9 years agoMerge pull request #574 from DavidS/fix-selinux
Hunter Haugen [Wed, 14 Oct 2015 16:22:32 +0000 (09:22 -0700)]
Merge pull request #574 from DavidS/fix-selinux

(MAINT) RedHat 6 also uses unconfined_t

9 years ago(MAINT) RedHat 6 also uses unconfined_t
David Schmitt [Wed, 14 Oct 2015 16:19:38 +0000 (17:19 +0100)]
(MAINT) RedHat 6 also uses unconfined_t

9 years agoMerge pull request #573 from cdenneen/patch-1
David Schmitt [Thu, 8 Oct 2015 13:38:16 +0000 (14:38 +0100)]
Merge pull request #573 from cdenneen/patch-1

Include osrelease check in selinux case statement

9 years agoInclude osrelease check in selinux case statement
cdenneen [Wed, 7 Oct 2015 13:29:26 +0000 (09:29 -0400)]
Include osrelease check in selinux case statement

9 years agoMerge pull request #572 from roman-mueller/deprecation_warning
David Schmitt [Tue, 1 Sep 2015 10:43:14 +0000 (11:43 +0100)]
Merge pull request #572 from roman-mueller/deprecation_warning

MODULES-2487 Improve port deprecation warning

9 years agoImprove deprecation warning, add module name to it
Roman Mueller [Sat, 29 Aug 2015 12:46:33 +0000 (14:46 +0200)]
Improve deprecation warning, add module name to it

9 years agoMerge pull request #571 from tphoney/release_1.7.1 1.7.1
David Schmitt [Thu, 20 Aug 2015 11:58:56 +0000 (12:58 +0100)]
Merge pull request #571 from tphoney/release_1.7.1

release prep

9 years agorelease prep
tphoney [Thu, 20 Aug 2015 10:08:08 +0000 (11:08 +0100)]
release prep

9 years agoMerge pull request #570 from hunner/deprecate_port
Bryan Jen [Wed, 19 Aug 2015 18:05:18 +0000 (11:05 -0700)]
Merge pull request #570 from hunner/deprecate_port

Deprecate port parameter

9 years agoDeprecate port parameter
Hunter Haugen [Mon, 17 Aug 2015 22:22:04 +0000 (15:22 -0700)]
Deprecate port parameter

I couldn't find any valid use case for port, and if any valid case did
exist then sport+dport could be used.

9 years agoMerge pull request #569 from grigarr/patch-1
Daniel Dreier [Wed, 12 Aug 2015 21:03:30 +0000 (14:03 -0700)]
Merge pull request #569 from grigarr/patch-1

Always use dport

9 years agoAlways use dport
Rudy Grigar [Wed, 12 Aug 2015 18:25:16 +0000 (11:25 -0700)]
Always use dport

Using 'port' allows you to spoof a source port and offers a backdoor by sending a different destination port. sport 80 -> dport 11211 would be valid for 'port => 80' and give access to a memcache instance (port 11211) running on the server.

9 years agoMerge pull request #567 from puppetlabs/1.7.x
TP Honey [Tue, 28 Jul 2015 10:44:15 +0000 (11:44 +0100)]
Merge pull request #567 from puppetlabs/1.7.x

Release 1.7.0 Prep

9 years agoRelease 1.7.0 Prep 1.7.0
Jonathan Tripathy [Mon, 27 Jul 2015 14:55:54 +0000 (15:55 +0100)]
Release 1.7.0 Prep

9 years agoMerge pull request #566 from jonnytpuppet/more_test_fixes
TP Honey [Fri, 24 Jul 2015 10:40:49 +0000 (11:40 +0100)]
Merge pull request #566 from jonnytpuppet/more_test_fixes

More test logic fixes for SLES 10

9 years agoMore test logic fixes for SLES 10
Jonathan Tripathy [Fri, 24 Jul 2015 10:28:35 +0000 (11:28 +0100)]
More test logic fixes for SLES 10

9 years agoMerge pull request #565 from jonnytpuppet/more_test_fixes
Bryan Jen [Fri, 24 Jul 2015 00:08:56 +0000 (17:08 -0700)]
Merge pull request #565 from jonnytpuppet/more_test_fixes

More test exclusion logic fixes

9 years agoMore test exclusion logic fixes
Jonathan Tripathy [Fri, 24 Jul 2015 00:03:28 +0000 (01:03 +0100)]
More test exclusion logic fixes

9 years agoMerge pull request #564 from jonnytpuppet/more_test_fixes
David Schmitt [Thu, 23 Jul 2015 10:49:09 +0000 (11:49 +0100)]
Merge pull request #564 from jonnytpuppet/more_test_fixes

Further test exclusions for SLES 10

9 years agoFurther test exclusions for SLES 10
Jonathan Tripathy [Thu, 23 Jul 2015 10:37:27 +0000 (11:37 +0100)]
Further test exclusions for SLES 10

9 years agoMerge pull request #563 from jonnytpuppet/more_test_fixes
Hunter Haugen [Wed, 22 Jul 2015 20:38:41 +0000 (13:38 -0700)]
Merge pull request #563 from jonnytpuppet/more_test_fixes

Exclude SLES 10 from some tests

9 years agoExclude SLES 10 from some tests
Jonathan Tripathy [Wed, 22 Jul 2015 18:21:23 +0000 (19:21 +0100)]
Exclude SLES 10 from some tests

9 years agoMerge pull request #562 from jonnytpuppet/more_test_fixes
David Schmitt [Wed, 22 Jul 2015 14:45:06 +0000 (15:45 +0100)]
Merge pull request #562 from jonnytpuppet/more_test_fixes

Adding allow ssh rule to tests

9 years agoAdding allow ssh rule to tests
Jonathan Tripathy [Wed, 22 Jul 2015 14:00:46 +0000 (15:00 +0100)]
Adding allow ssh rule to tests

9 years agoMerge pull request #561 from jonnytpuppet/more_test_fixes
David Schmitt [Mon, 20 Jul 2015 16:11:40 +0000 (17:11 +0100)]
Merge pull request #561 from jonnytpuppet/more_test_fixes

Removed reject test in acceptance test

9 years agoRemoved reject test in acceptance test
Jonathan Tripathy [Mon, 20 Jul 2015 15:50:13 +0000 (16:50 +0100)]
Removed reject test in acceptance test

9 years agoMerge pull request #559 from BlendMarketing/master
JT (Jonny) [Mon, 20 Jul 2015 11:05:48 +0000 (12:05 +0100)]
Merge pull request #559 from BlendMarketing/master

Compatibility with Puppet 4 and Facter 3

9 years agoMerge pull request #560 from estonfer/add_dscp_markings
JT (Jonny) [Thu, 16 Jul 2015 11:33:14 +0000 (12:33 +0100)]
Merge pull request #560 from estonfer/add_dscp_markings

add set_dscp and set_dscp_class

9 years agoadd set_dscp and set_dscp_class
Eric Stonfer [Wed, 15 Jul 2015 17:16:06 +0000 (13:16 -0400)]
add set_dscp and set_dscp_class

9 years agoMerge branch 'master' of git://github.com/puppetlabs/puppetlabs-firewall
Jared Meyering [Tue, 14 Jul 2015 16:35:11 +0000 (11:35 -0500)]
Merge branch 'master' of git://github.com/puppetlabs/puppetlabs-firewall

9 years agofacter 4 compat
Jared Meyering [Tue, 14 Jul 2015 16:35:04 +0000 (11:35 -0500)]
facter 4 compat

9 years agoMerge pull request #555 from TJM/ticket/MODULES-2186-remove_fwrules_A
JT (Jonny) [Tue, 14 Jul 2015 13:03:45 +0000 (14:03 +0100)]
Merge pull request #555 from TJM/ticket/MODULES-2186-remove_fwrules_A

MODULES-2186 - iptables rules with -A in comment

9 years agoMerge pull request #554 from ghoneycutt/patch-1
JT (Jonny) [Tue, 14 Jul 2015 13:01:52 +0000 (14:01 +0100)]
Merge pull request #554 from ghoneycutt/patch-1

Style fixes in documentation's example code

9 years agoMerge pull request #558 from jonnytpuppet/test_fix
TP Honey [Fri, 3 Jul 2015 16:01:11 +0000 (17:01 +0100)]
Merge pull request #558 from jonnytpuppet/test_fix

Test fixes that may prevent hanging problems during beaker tests.

9 years agoTest fixes that may prevent hanging problems during beaker tests.
Jonathan Tripathy [Fri, 3 Jul 2015 15:26:21 +0000 (16:26 +0100)]
Test fixes that may prevent hanging problems during beaker tests.

9 years agoMerge pull request #557 from DavidS/modules-2155-update-docs
JT (Jonny) [Fri, 3 Jul 2015 10:34:51 +0000 (11:34 +0100)]
Merge pull request #557 from DavidS/modules-2155-update-docs

(MODULES-2155) Remove note about purge restrictions

9 years ago(MODULES-2155) Remove note about purge restrictions
David Schmitt [Fri, 3 Jul 2015 09:54:25 +0000 (10:54 +0100)]
(MODULES-2155) Remove note about purge restrictions

9 years agoMerge pull request #556 from jonnytpuppet/autorequire_service
David Schmitt [Thu, 2 Jul 2015 16:08:01 +0000 (17:08 +0100)]
Merge pull request #556 from jonnytpuppet/autorequire_service

Makes all the services autorequired by the firewall and firewallchain types.

9 years agoMakes all the services autorequired by the firewall and firewall chain types.
Jonathan Tripathy [Thu, 2 Jul 2015 15:41:03 +0000 (16:41 +0100)]
Makes all the services autorequired by the firewall and firewall chain types.

9 years agoMODULES-2186 - iptables rules with -A in comment
Tommy McNeely [Thu, 2 Jul 2015 15:16:46 +0000 (09:16 -0600)]
MODULES-2186 - iptables rules with -A in comment

9 years agoStyle fixes in documentation's example code
Garrett Honeycutt [Thu, 2 Jul 2015 02:20:00 +0000 (22:20 -0400)]
Style fixes in documentation's example code

9 years agoMerge pull request #553 from jonnytpuppet/test_fix
David Schmitt [Tue, 30 Jun 2015 13:57:56 +0000 (14:57 +0100)]
Merge pull request #553 from jonnytpuppet/test_fix

Only catch changes if not EL5 due to selinux warning issue.

9 years agoOnly catch changes if not EL5 due to selinux warning issue.
Jonathan Tripathy [Tue, 30 Jun 2015 13:43:41 +0000 (14:43 +0100)]
Only catch changes if not EL5 due to selinux warning issue.

9 years agoMerge pull request #551 from jonnytpuppet/physdev_idem_fix
David Schmitt [Thu, 25 Jun 2015 13:32:49 +0000 (14:32 +0100)]
Merge pull request #551 from jonnytpuppet/physdev_idem_fix

Fix for physdev idempotency on EL5

9 years agoFix for physdev idempotency on EL5
Jonathan Tripathy [Thu, 25 Jun 2015 13:14:18 +0000 (14:14 +0100)]
Fix for physdev idempotency on EL5

9 years agoMerge pull request #550 from hunner/undefault_seluser
Morgan Haskel [Wed, 24 Jun 2015 20:31:03 +0000 (13:31 -0700)]
Merge pull request #550 from hunner/undefault_seluser

Enforce the seluser on selinux systems

9 years agoEnforce the seluser on selinux systems
Hunter Haugen [Tue, 23 Jun 2015 23:18:00 +0000 (16:18 -0700)]
Enforce the seluser on selinux systems

iptables-save always sets unconfined_u

9 years agoMerge pull request #549 from puppetlabs/revert-548-disable_selinux
Bryan Jen [Fri, 19 Jun 2015 21:00:11 +0000 (14:00 -0700)]
Merge pull request #549 from puppetlabs/revert-548-disable_selinux

Revert "Don't enable selinux on redhat systems"

9 years agoRevert "Don't enable selinux on redhat systems"
Hunter Haugen [Fri, 19 Jun 2015 20:55:41 +0000 (13:55 -0700)]
Revert "Don't enable selinux on redhat systems"

9 years agoMerge pull request #548 from hunner/disable_selinux
Bryan Jen [Fri, 19 Jun 2015 17:27:45 +0000 (10:27 -0700)]
Merge pull request #548 from hunner/disable_selinux

Don't enable selinux on redhat systems

9 years agoDon't enable selinux on redhat systems
Hunter Haugen [Fri, 19 Jun 2015 17:24:49 +0000 (10:24 -0700)]
Don't enable selinux on redhat systems

9 years agoMerge pull request #547 from jonnytpuppet/fix_spec_helper
David Schmitt [Fri, 19 Jun 2015 13:58:53 +0000 (14:58 +0100)]
Merge pull request #547 from jonnytpuppet/fix_spec_helper

Removed Hiera config command in spec helper.

9 years agoRemoved Hiera config command in spec helper.
Jonathan Tripathy [Fri, 19 Jun 2015 13:56:37 +0000 (14:56 +0100)]
Removed Hiera config command in spec helper.

9 years agoMerge pull request #517 from karmix/tickets/master/MODULES-1976_unicode-rule-name...
JT (Jonny) [Fri, 19 Jun 2015 10:08:13 +0000 (11:08 +0100)]
Merge pull request #517 from karmix/tickets/master/MODULES-1976_unicode-rule-name-validation

(MODULES-1976) Revise rule name validation for ruby 1.9