]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/log
TP Honey [Fri, 14 Dec 2018 14:39:17 +0000 (14:39 +0000)]
Merge pull request #798 from eimlav/modules-8143
(MODULES-8143) - Add SLES 15 support
Eimhin Laverty [Thu, 13 Dec 2018 11:06:33 +0000 (11:06 +0000)]
(MODULES-8143) - Add SLES 15 support
Helen [Thu, 13 Dec 2018 10:07:34 +0000 (10:07 +0000)]
Merge pull request #796 from eimlav/modules-6340
(MODULES-6340) - Address failure when name begins with 9XXX
Eimhin Laverty [Wed, 12 Dec 2018 14:19:13 +0000 (14:19 +0000)]
Update test error
Eimhin Laverty [Wed, 12 Dec 2018 14:15:59 +0000 (14:15 +0000)]
Modifed error message to be more clear
Eimhin Laverty [Tue, 11 Dec 2018 15:19:10 +0000 (15:19 +0000)]
(MODULES-6340) - Address failure when name begins with 9XXX
Helen [Thu, 29 Nov 2018 15:23:09 +0000 (15:23 +0000)]
Merge pull request #794 from mwhahaha/rhel8
Add nftables wrapper support for RHEL8
Alex Schultz [Mon, 26 Nov 2018 21:41:40 +0000 (14:41 -0700)]
Add nftables wrapper support for RHEL8
In RHEL8, iptables is replaced with nftables under the covers. In order
to allow for the firewall module to continue to function, this change
updates the redhat firewall configuration to pull in the nftables
packages.
https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8-beta/html/8.0_beta_release_notes/new-features#networking_2
david22swan [Mon, 26 Nov 2018 17:03:10 +0000 (17:03 +0000)]
Merge pull request #790 from mateusz-gozdek-sociomantic/MODULES-8214-multiple-src-dst-type
(MODULES-8214) Handle src_type and dst_type as array
Helen [Mon, 26 Nov 2018 14:33:50 +0000 (14:33 +0000)]
Merge pull request #793 from erik-frontify/fix_amazon_linux2_support
Amazon linux 2 changed its major version to 2 with the last update...
Mateusz Gozdek [Tue, 6 Nov 2018 00:16:35 +0000 (01:16 +0100)]
(MODULES-8214) Handle src_type and dst_type as array
So it can be parsed when specified mutliple times, as well as being configured.
Erik Geiger [Fri, 16 Nov 2018 18:02:35 +0000 (19:02 +0100)]
Amazon linux 2 changed its major version to 2 with the last update...
david22swan [Fri, 9 Nov 2018 17:45:34 +0000 (17:45 +0000)]
Merge pull request #789 from mateusz-gozdek-sociomantic/MODULES-7990-iptables-multiple-comments
(MODULES-7990) Merge multiple comments into one while parsing rules
Mateusz Gozdek [Mon, 5 Nov 2018 16:55:22 +0000 (17:55 +0100)]
Add test for comments without quotes
Mateusz Gozdek [Mon, 5 Nov 2018 10:53:06 +0000 (11:53 +0100)]
(MODULES-7990) Merge multiple comments into one while parsing rules
As iptables/iptables-save accepts multiple '-m comment --comment' parameters,
we should find and merge them all together to avoid generating warnings.
Since puppet resource allows you to create only single comment, this should only
affect rules, which are not managed by puppet.
Paula Muir [Wed, 7 Nov 2018 13:11:35 +0000 (13:11 +0000)]
Merge pull request #792 from puppetlabs/pdksync_pdksync_heads/
master-0-gabccfb1
pdksync - pdksync_heads/
master-0-gabccfb1
David Swan [Wed, 7 Nov 2018 10:21:51 +0000 (10:21 +0000)]
david22swan [Wed, 7 Nov 2018 09:48:37 +0000 (09:48 +0000)]
Merge pull request #771 from syseleven/feature/add-bytecode-property
(MODULES-7681) Add support for bytecode property
Matthias Baur [Mon, 20 Aug 2018 11:38:46 +0000 (13:38 +0200)]
(MODULES-7681) Add support for bytecode property
This commit adds support for Berkeley Paket Filter iptables rules.
david22swan [Tue, 6 Nov 2018 12:00:47 +0000 (12:00 +0000)]
Merge pull request #791 from GeorgeCox/interface_regex_update
Changed regex for iniface and outiface to allow '@' in interface names
George Cox [Tue, 6 Nov 2018 09:50:10 +0000 (09:50 +0000)]
Changed regex for iniface and outiface to allow '@' in interface names
TP Honey [Mon, 29 Oct 2018 10:34:52 +0000 (10:34 +0000)]
Merge pull request #788 from cestith/patch-1
add -g flag handling in ip6tables.rb provider
Christopher E. Stith [Wed, 24 Oct 2018 00:52:27 +0000 (19:52 -0500)]
add -g flag handling in ip6tables.rb provider
In lib/puppet/provider/firewall/ip6tables.rb there is no goto: entry for the -g flag in @resource_map which leads to errors for rules using that feature.
lib/puppet/type/firewall.rb already handles this flag. It's a one-line change to recognize it. The right rules then get into the chains in my testing.
TP Honey [Tue, 23 Oct 2018 16:47:10 +0000 (17:47 +0100)]
Merge pull request #787 from pmcmaw/FM-7516
(FM-7516) - Removing Gentoo from metadata
Paula Muir [Tue, 23 Oct 2018 15:44:15 +0000 (16:44 +0100)]
(FM-7516) - Removing Gentoo from metadata
Gentoo is an entry in the metadata, removing this entry as we do not
have our test infrastructure set up to run acceptance test on this
OS. Removing from the metadata means that we will not support this OS,
however no code changes are being made therefore this OS may still be
compatible.
Paula Muir [Thu, 27 Sep 2018 16:25:23 +0000 (17:25 +0100)]
Merge pull request #785 from puppetlabs/release
(MODULES-7878) - 1.14.0 Merge Back
Eimhin Laverty [Thu, 27 Sep 2018 13:06:46 +0000 (14:06 +0100)]
Merge pull request #784 from puppetlabs/pdksync_puppet_6_release_prep
pdksync - Module Release Prep 1.14.0
Paula Muir [Thu, 27 Sep 2018 12:19:06 +0000 (13:19 +0100)]
Module Release Prep
Paula Muir [Thu, 27 Sep 2018 09:43:14 +0000 (10:43 +0100)]
Merge pull request #782 from puppetlabs/pdksync_MODULES-6805
pdksync - (MODULES-6805) metadata.json shows support for puppet 6
david22swan [Tue, 25 Sep 2018 08:25:26 +0000 (09:25 +0100)]
Merge pull request #783 from puppetlabs/pdksync_FM-7392_pdk_update
pdksync - (FM-7392) - Puppet 6 Testing Changes
Paula Muir [Mon, 24 Sep 2018 16:02:25 +0000 (17:02 +0100)]
(FM-7392) - Puppet 6 Testing Changes
tphoney [Thu, 20 Sep 2018 15:33:42 +0000 (16:33 +0100)]
(MODULES-6805) metadata.json shows support for puppet 6
TP Honey [Thu, 20 Sep 2018 15:19:29 +0000 (16:19 +0100)]
Merge pull request #780 from pmcmaw/ghcg_prep
(FM-7399) - Prepare for changelog generator
Paula Muir [Thu, 20 Sep 2018 14:44:41 +0000 (15:44 +0100)]
(FM-7399) - Prepare for changelog generator
Paula Muir [Wed, 19 Sep 2018 16:20:38 +0000 (17:20 +0100)]
Merge pull request #779 from puppetlabs/release
1.13.0 Mergeback
Paula Muir [Tue, 18 Sep 2018 13:35:49 +0000 (14:35 +0100)]
Merge pull request #778 from puppetlabs/clairecadman-patch-1
(MODULES-7804) - Minor README edits
clairecadman [Tue, 18 Sep 2018 10:33:14 +0000 (11:33 +0100)]
(firewall) Minor readme edits
The commit makes minor updates to the README
Paula Muir [Mon, 17 Sep 2018 14:28:01 +0000 (15:28 +0100)]
(MODULES-7803) - Release Prep 1.13.0
Eimhin Laverty [Fri, 31 Aug 2018 13:42:40 +0000 (14:42 +0100)]
Merge pull request #776 from puppetlabs/pdksync_pdksync-beaker4
pdksync - (MODULES-7658) use beaker4 in puppet-module-gems
tphoney [Thu, 30 Aug 2018 16:07:42 +0000 (17:07 +0100)]
(MODULES-7658) use beaker4 in puppet-module-gems
david22swan [Fri, 24 Aug 2018 08:07:43 +0000 (09:07 +0100)]
Merge pull request #775 from puppetlabs/pdksync_bumping_puppet_version
pdksync - (MODULES-7705) - Bumping stdlib dependency from < 5.0.0 to < 6.0.0
Paula Muir [Thu, 23 Aug 2018 17:18:59 +0000 (18:18 +0100)]
(MODULES-7705) - Bumping stdlib requirement to 6.0.0
Helen [Wed, 22 Aug 2018 15:54:46 +0000 (16:54 +0100)]
Merge pull request #773 from puppetlabs/pdksync_1
.7.0-0-g57412ed
pdksync - Update using 1.7.0
Paula Muir [Wed, 22 Aug 2018 15:28:21 +0000 (16:28 +0100)]
addressing rubocop
Paula Muir [Wed, 22 Aug 2018 13:31:14 +0000 (14:31 +0100)]
david22swan [Tue, 21 Aug 2018 15:15:46 +0000 (16:15 +0100)]
Merge pull request #772 from puppetlabs/pdksync_pdksync-beaker3
pdksync - (MODULES-7658) use beaker3 in puppet-module-gems
tphoney [Tue, 21 Aug 2018 14:27:02 +0000 (15:27 +0100)]
(MODULES-7658) use beaker3 in puppet-module-gems
Helen [Thu, 9 Aug 2018 11:01:58 +0000 (12:01 +0100)]
Merge pull request #768 from erik-frontify/amazon_linux2_support
Add support for Amazon Linux 2
Paula Muir [Thu, 9 Aug 2018 10:41:20 +0000 (11:41 +0100)]
Merge pull request #769 from eimlav/update-limitations
(MODULES-7627) - Update README Limitations section
Eimhin Laverty [Thu, 9 Aug 2018 10:03:22 +0000 (11:03 +0100)]
(MODULES-7627) - Update README Limitations section
Erik Geiger [Fri, 3 Aug 2018 14:41:29 +0000 (16:41 +0200)]
Add support for Amazon Linux 2
setting service provider explicit to systemd as pupppets default does
not work for Amazon Linux 2
Paula Muir [Mon, 30 Jul 2018 16:12:45 +0000 (17:12 +0100)]
Merge pull request #767 from david22swan/FM-7232
(FM-7232) - Update firewall to support Ubuntu 18.04
David Swan [Mon, 30 Jul 2018 15:01:59 +0000 (16:01 +0100)]
(FM-7232) - Update firewall to support Ubuntu 18.04
Helen [Thu, 21 Jun 2018 13:34:09 +0000 (14:34 +0100)]
Merge pull request #765 from david22swan/FM-7044
[FM-7044] Addition of Debian 9 support to firewall
david22swan [Wed, 20 Jun 2018 09:10:27 +0000 (10:10 +0100)]
Merge pull request #766 from alexharv074/corrections_to_readme
\b Corrections to readme
Alex Harvey [Sun, 17 Jun 2018 06:55:09 +0000 (16:55 +1000)]
(docs) Add .gitattributes
So that the language is correctly displayed as "Puppet" on GitHub.
Alex Harvey [Sun, 17 Jun 2018 06:50:28 +0000 (16:50 +1000)]
(docs) Markdown syntax updates in README.markdown
Also corrections to how to run the tests.
David Swan [Fri, 8 Jun 2018 10:01:43 +0000 (11:01 +0100)]
[FM-7044] Addition of Debian 9 support to firewall
Helen [Thu, 31 May 2018 08:49:56 +0000 (09:49 +0100)]
Merge pull request #764 from david22swan/FM-6961
[FM-6961] Removal of unsupported OS from firewall
David Swan [Wed, 30 May 2018 11:38:37 +0000 (12:38 +0100)]
[FM-6961] Removal of unsupported OS from firewall
david22swan [Fri, 18 May 2018 14:53:07 +0000 (15:53 +0100)]
Merge pull request #763 from puppetlabs/pdksync_heads/
master-0-g34e3266
pdksync - Update using 1.5.0
Helen Campbell [Fri, 18 May 2018 14:17:07 +0000 (15:17 +0100)]
david22swan [Fri, 18 May 2018 09:15:07 +0000 (10:15 +0100)]
Merge pull request #762 from puppetlabs/revert-761-pdksync_heads/
master-0-gfe44b98
Revert "pdksync - Update using 1.5.0"
Helen [Thu, 17 May 2018 15:54:55 +0000 (16:54 +0100)]
Revert "pdksync - Update using 1.5.0"
david22swan [Wed, 16 May 2018 15:16:36 +0000 (16:16 +0100)]
Merge pull request #761 from puppetlabs/pdksync_heads/
master-0-gfe44b98
pdksync - Update using 1.5.0
Helen Campbell [Wed, 16 May 2018 14:20:40 +0000 (15:20 +0100)]
david22swan [Fri, 11 May 2018 12:29:33 +0000 (13:29 +0100)]
Merge pull request #760 from pmcmaw/unmanage_gitlab
(MODULES-7153) - Unmanage gitlab-ci.yml
Paula McMaw [Fri, 11 May 2018 10:38:04 +0000 (11:38 +0100)]
(MODULES-7153) - Unmanage gitlab-ci.yml
david22swan [Fri, 27 Apr 2018 11:02:08 +0000 (12:02 +0100)]
Merge pull request #759 from pmcmaw/update_sync
(MODULES-7023) - Removing duplication in .sync.yml
Paula McMaw [Thu, 26 Apr 2018 13:46:55 +0000 (14:46 +0100)]
(MODULES-7023) - Removing duplication in .sync.yml
david22swan [Wed, 21 Feb 2018 12:00:21 +0000 (12:00 +0000)]
Merge pull request #749 from mikkergimenez/modules_2119_workaround_for_ip6tables_delete
(MODULES-2119) iptables delete -p all exception
david22swan [Wed, 21 Feb 2018 11:55:19 +0000 (11:55 +0000)]
Merge pull request #756 from mirekys/master
(MODULES-6129) negated option with address mask bugfix
Miroslav Bauer [Fri, 26 Jan 2018 21:59:39 +0000 (22:59 +0100)]
(MODULES-6129) negated option with address mask bugfix
willmeek [Thu, 25 Jan 2018 12:07:03 +0000 (12:07 +0000)]
Merge pull request #755 from puppetlabs/release
Release 1.12.0 merge back
Helen [Wed, 24 Jan 2018 14:04:08 +0000 (14:04 +0000)]
Merge pull request #754 from pmcmaw/1.12.0_release
Release prep 1.12.0
Paula McMaw [Wed, 24 Jan 2018 11:57:28 +0000 (11:57 +0000)]
Release prep 1.12.0
Paula Muir [Wed, 24 Jan 2018 11:47:43 +0000 (11:47 +0000)]
(MODULES-6455) - PDK convert firewall (#753)
* Rubocop and puppet-lint errors
* pdk convert firewall
* Remove bundler update
david22swan [Tue, 23 Jan 2018 17:28:12 +0000 (17:28 +0000)]
Merge pull request #752 from pmcmaw/convert
(maint) - Address rubocop & puppet lint errors
Paula McMaw [Tue, 23 Jan 2018 16:35:16 +0000 (16:35 +0000)]
Address rubocop and lint errors
Paula Muir [Mon, 8 Jan 2018 15:01:46 +0000 (15:01 +0000)]
Merge pull request #750 from puppetlabs/msync_MODULES-6339
(maint) modulesync
65530a4 Update Travis
Michael T Lombardi [Wed, 3 Jan 2018 22:11:41 +0000 (16:11 -0600)]
(maint) modulesync
65530a4 Update Travis
Related: https://github.com/puppetlabs/modulesync_configs/pull/177
Mikker Gimenez-Peterson [Thu, 21 Dec 2017 02:44:37 +0000 (18:44 -0800)]
(MODULES-2119) iptables delete -p all exception
This change works around a bug in ip6tables where rules will not be deleted if they attempt to match the 'all' protocol, as it does not properly handle a missing protocol field as an implicit 'all':
netfilter bug located here: https://bugzilla.netfilter.org/show_bug.cgi?id=1015
david22swan [Wed, 13 Dec 2017 15:19:09 +0000 (15:19 +0000)]
RubocopFix (#746)
david22swan [Wed, 13 Dec 2017 14:50:59 +0000 (14:50 +0000)]
Merge pull request #745 from puppetlabs/maint_modsync_384f4c1
(maint) - modulesync
384f4c1
tphoney [Wed, 13 Dec 2017 10:49:41 +0000 (10:49 +0000)]
(maint) - modulesync
384f4c1
willmeek [Tue, 12 Dec 2017 11:16:36 +0000 (11:16 +0000)]
Merge pull request #737 from mihall-primus/centos5
(MODULES-6092) Set correct seluser for CentOS/RHEL 5.x
Paula McMaw [Fri, 8 Dec 2017 12:21:34 +0000 (12:21 +0000)]
Merge pull request #744 from hantona/negation-with-dash-in-chain
MODULES-6261: Fix error parsing rules with dashes in the chain name
EC2 Default User [Thu, 7 Dec 2017 20:43:47 +0000 (20:43 +0000)]
Fix error parsing rules with dashes in the chain name
Paula McMaw [Thu, 7 Dec 2017 10:00:53 +0000 (10:00 +0000)]
Merge pull request #743 from david22swan/Rubocop
Addressing Rubocop Errors
David Swan [Wed, 6 Dec 2017 15:42:27 +0000 (15:42 +0000)]
FullFix
TP Honey [Wed, 6 Dec 2017 15:39:14 +0000 (15:39 +0000)]
Merge pull request #742 from david22swan/Rubocop
QuickFix
David Swan [Wed, 6 Dec 2017 15:37:53 +0000 (15:37 +0000)]
QuickFix
david22swan [Thu, 30 Nov 2017 10:02:12 +0000 (10:02 +0000)]
Merge pull request #741 from puppetlabs/release
Release mergeback 1.11.0
TP Honey [Wed, 29 Nov 2017 15:08:48 +0000 (15:08 +0000)]
Merge pull request #740 from david22swan/PreRelease
1.11.0PreRelease
David Swan [Wed, 29 Nov 2017 14:34:37 +0000 (14:34 +0000)]
1.11.0PreRelease
david22swan [Wed, 29 Nov 2017 10:25:11 +0000 (10:25 +0000)]
Rubocop Implemented (#735)
* Rubocop Implemented
Paula McMaw [Fri, 24 Nov 2017 12:56:51 +0000 (12:56 +0000)]
Merge pull request #739 from jistr/remove-debug-puts
Remove leftover debugging 'puts'
Jiri Stransky [Thu, 23 Nov 2017 15:37:07 +0000 (16:37 +0100)]
Remove leftover debugging 'puts'
I used the puts to figure out rspec behavior and forgot to remove it
before commiting a fix.
Paula McMaw [Thu, 23 Nov 2017 14:50:40 +0000 (14:50 +0000)]
Merge pull request #738 from jistr/skip-unparsable-iptables-rules
(MODULES-6029) Skip unparsable rules with warning
Jiri Stransky [Thu, 23 Nov 2017 14:11:03 +0000 (15:11 +0100)]
(MODULES-6029) Skip unparsable rules with warning
The iptables rules parser has very strict/simplistic expectations
about how iptables rules should look like, and can easily fail to
parse rules that weren't produced by the module itself.
We should ignore the unfitting rules when parsing and produce a
warning rather than causing a fatal error and stopping the Puppet run.