]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/log
Hunter Haugen [Wed, 26 Apr 2017 21:17:59 +0000 (14:17 -0700)]
(maint) Add bugfix to changelog
Hunter Haugen [Wed, 26 Apr 2017 18:34:24 +0000 (11:34 -0700)]
Merge branch 'master' into release
Hunter Haugen [Wed, 26 Apr 2017 18:30:11 +0000 (11:30 -0700)]
Merge pull request #672 from domcleal/architecture-fact
Fix architecture fact overriding unset `architecture` source option
Helen [Tue, 25 Apr 2017 15:56:26 +0000 (16:56 +0100)]
Merge pull request #674 from hunner/fix_specs
(maint) Fix for different versions
Hunter Haugen [Mon, 24 Apr 2017 19:02:04 +0000 (12:02 -0700)]
(maint) Fix for different versions
Eric Putnam [Mon, 24 Apr 2017 18:29:50 +0000 (11:29 -0700)]
Merge pull request #673 from hunner/secondRelease
Rebase of #668
Hunter Haugen [Mon, 24 Apr 2017 18:05:11 +0000 (11:05 -0700)]
(maint) bump version to 4.0.0
Hunter Haugen [Mon, 24 Apr 2017 17:20:20 +0000 (10:20 -0700)]
(maint) Unit test fixes
Helen Campbell [Tue, 4 Apr 2017 10:57:35 +0000 (11:57 +0100)]
Removal of deprecated functionality
Helen Campbell [Tue, 4 Apr 2017 09:12:18 +0000 (10:12 +0100)]
Removal of compat types and validate_legacy calls
Dominic Cleal [Mon, 24 Apr 2017 07:30:15 +0000 (08:30 +0100)]
Fix architecture fact overriding unset `architecture` source option
When the `architecture` parameter to apt::source wasn't set, the
`architecture` fact would be used instead, causing the source to always
be limited by the architecture of the host.
The EPP variable has been renamed to avoid clashing with the fact name.
Hunter Haugen [Fri, 21 Apr 2017 17:03:54 +0000 (10:03 -0700)]
Merge pull request #671 from puppetlabs/release
Release Mergeback
Hunter Haugen [Mon, 17 Apr 2017 16:52:42 +0000 (09:52 -0700)]
(maint) Clear facter before to avoid parallel pollution
Hunter Haugen [Wed, 12 Apr 2017 18:19:32 +0000 (11:19 -0700)]
(maint) Stub fact exists call with argument passed
I can't replicate what's going on, but I wonder if the stub is being
bypassed and the actual underlying debian filesystem is being hit. The
timestamps returned by the unit test are from just before the unit test
ran.
Hunter Haugen [Wed, 12 Apr 2017 03:38:37 +0000 (20:38 -0700)]
(maint) Move stubs for apt update fact
I can't reproduce this, so just a guess.
Hunter Haugen [Wed, 12 Apr 2017 02:17:05 +0000 (19:17 -0700)]
(maint) Two missed failures due to parallel specs
Eric Putnam [Wed, 12 Apr 2017 01:01:10 +0000 (18:01 -0700)]
Merge pull request #670 from hunner/fix_specs
(PUP-6856) Always define facts
Hunter Haugen [Wed, 12 Apr 2017 00:18:25 +0000 (17:18 -0700)]
(PUP-6856) Always define facts
If facts are not defined for hiera lookups, the lookup will fail instead
of falling back to common on puppet < 4.9.0
Hunter Haugen [Tue, 11 Apr 2017 22:50:45 +0000 (15:50 -0700)]
Merge pull request #667 from HelenCampbell/firstRelease
First Release prep for Puppet 4 language update
Helen Campbell [Tue, 20 Dec 2016 11:34:00 +0000 (11:34 +0000)]
Puppet 4 language update
Hailee Kenney [Fri, 7 Apr 2017 14:19:33 +0000 (15:19 +0100)]
Merge pull request #669 from puppetlabs/release
Release Mergeback
Paula McMaw [Thu, 6 Apr 2017 14:39:54 +0000 (15:39 +0100)]
Merge pull request #666 from HelenCampbell/release
2.4.0 Release Prep
Helen Campbell [Thu, 6 Apr 2017 11:13:14 +0000 (12:13 +0100)]
2.4.0 Release Prep
Helen [Tue, 4 Apr 2017 09:43:02 +0000 (10:43 +0100)]
Merge pull request #662 from puppetlabs/modules-4506
[msync] 786266 Implement puppet-module-gems, a45803 Remove metadata.json from locales config
Wilson McCoubrey [Wed, 29 Mar 2017 14:53:54 +0000 (15:53 +0100)]
[maint] Fix puppet-lint warnings introduced with 2.2.0 puppet-lint release
Wilson McCoubrey [Wed, 29 Mar 2017 10:46:41 +0000 (11:46 +0100)]
[msync] 786266 Implement puppet-module-gems, a45803 Remove metadata.json from locales config
Helen [Fri, 24 Mar 2017 11:34:41 +0000 (11:34 +0000)]
Merge pull request #660 from puppetlabs/modules-4528
[MODULES-4528] Replace Puppet.version.to_f version comparison from spec_helper.rb
Wilson McCoubrey [Wed, 22 Mar 2017 15:06:27 +0000 (15:06 +0000)]
[MODULES-4528] Replace Puppet.version.to_f version comparison from spec_helper.rb
Hailee Kenney [Mon, 20 Mar 2017 14:02:55 +0000 (14:02 +0000)]
Merge pull request #658 from puppetlabs/MODULES-4528
[MODULES-4528] Replace Puppet.version.to_f with Puppet::Util::Package.versioncmp
Wilson McCoubrey [Thu, 16 Mar 2017 11:27:49 +0000 (11:27 +0000)]
[MODULES-4528] Replace Puppet.version.to_f with Puppet::Util::Package.versioncmp
Helen [Wed, 22 Feb 2017 11:26:36 +0000 (11:26 +0000)]
Merge pull request #653 from Cosaquee/remove-comma-from-example-in-readme
remove unnecessary comma in example
Helen [Wed, 22 Feb 2017 10:24:17 +0000 (10:24 +0000)]
Merge pull request #656 from WhatsARanjit/master
apt::key is a defined type, not a class
WhatsARanjit [Fri, 3 Feb 2017 00:48:06 +0000 (19:48 -0500)]
apt::key is a defined type, not a class
Eric Putnam [Sat, 21 Jan 2017 01:11:09 +0000 (17:11 -0800)]
Merge pull request #654 from puppetlabs/hunner_msync
(MODULES-4098) Sync the rest of the files
Hunter Haugen [Fri, 20 Jan 2017 00:11:40 +0000 (16:11 -0800)]
(MODULES-4098) Sync the rest of the files
Karol Kozakowski [Thu, 12 Jan 2017 13:24:08 +0000 (14:24 +0100)]
remove unnecessary comma in example
Eric Putnam [Wed, 11 Jan 2017 16:45:15 +0000 (11:45 -0500)]
Merge pull request #650 from puppetlabs/hunner_msync
(MODULES-4097) Sync travis.yml
Eric Putnam [Wed, 11 Jan 2017 14:48:43 +0000 (09:48 -0500)]
Merge pull request #652 from puppetlabs/implement-beaker-module_install_helper
[MODULES-4224] Implement beaker-module_install_helper
Hunter Haugen [Thu, 5 Jan 2017 23:31:01 +0000 (15:31 -0800)]
(MODULES-4097) Sync travis.yml
Wilson McCoubrey [Tue, 10 Jan 2017 10:43:54 +0000 (10:43 +0000)]
[MODULES-4224] Implement beaker-module_install_helper
Hunter Haugen [Thu, 15 Dec 2016 00:24:47 +0000 (16:24 -0800)]
Merge pull request #646 from puppetlabs/modsync
(FM-5972) gettext and spec.opts
Eric Putnam [Wed, 14 Dec 2016 21:28:43 +0000 (13:28 -0800)]
gettext and spec.opts
TP Honey [Wed, 14 Dec 2016 15:16:11 +0000 (15:16 +0000)]
Merge pull request #641 from DavidS/use-stdlib-deprecation
Use stdlib deprecation
Helen Campbell [Wed, 14 Dec 2016 14:37:54 +0000 (14:37 +0000)]
Fix for tests against PR-641
Hunter Haugen [Tue, 6 Dec 2016 23:32:39 +0000 (15:32 -0800)]
Merge pull request #644 from eputnam/spec_opts
(maint) updates spec.opts in prep for parallel_spec
Eric Putnam [Tue, 6 Dec 2016 22:20:23 +0000 (14:20 -0800)]
removes spec.opts
Eric Putnam [Fri, 2 Dec 2016 19:43:12 +0000 (11:43 -0800)]
Merge pull request #643 from puppetlabs/hunner_msync
(MODULES-3631) msync Gemfile for 1.9 frozen strings
Hunter Haugen [Thu, 1 Dec 2016 19:36:52 +0000 (11:36 -0800)]
(MODULES-3631) msync Gemfile for 1.9 frozen strings
Eric Putnam [Tue, 29 Nov 2016 00:36:43 +0000 (16:36 -0800)]
Merge pull request #638 from lrrb/master
remove port number from hostname
David Schmitt [Sun, 27 Nov 2016 17:03:26 +0000 (17:03 +0000)]
Use the stdlib deprecation() function
David Schmitt [Sun, 27 Nov 2016 16:26:20 +0000 (16:26 +0000)]
Update to require using stdlib 4.13 for deprecation function
lrrb [Wed, 16 Nov 2016 22:06:37 +0000 (23:06 +0100)]
remove port number from hostname
Solve the issue reported in https://tickets.puppetlabs.com/browse/MODULES-4104 : remove the port number from repository location in order to get the host name of the repository.
Eric Putnam [Thu, 10 Nov 2016 18:59:08 +0000 (10:59 -0800)]
Merge pull request #636 from puppetlabs/hunner_msync
(MODULES-3704) Update gemfile template to be identical
Hunter Haugen [Wed, 9 Nov 2016 17:58:08 +0000 (09:58 -0800)]
(MODULES-3704) Update gemfile template to be identical
Wilson McCoubrey [Wed, 9 Nov 2016 11:44:40 +0000 (11:44 +0000)]
Merge pull request #635 from lkoranda/fix_string_comparison_error
Avoid string comparison error
Lukas Koranda [Sun, 6 Nov 2016 22:01:42 +0000 (23:01 +0100)]
Avoiding string comparison error
Signed-off-by: Lukas Koranda <lkoranda@redhat.com>
Eric Putnam [Wed, 2 Nov 2016 23:00:43 +0000 (16:00 -0700)]
mocha version update for test hanging issue
Hunter Haugen [Mon, 31 Oct 2016 16:51:36 +0000 (09:51 -0700)]
Merge pull request #633 from puppetlabs/Paula_modulesync
(MODULES-3983) Update parallel_tests for ruby 2.0.0
David Schmitt [Tue, 25 Oct 2016 10:21:35 +0000 (11:21 +0100)]
Merge pull request #631 from wilson208/key-server-timeout-fix
[MODULES-3562] Implement retry for tests which require modules to pull key from keyserver
Paula McMaw [Thu, 20 Oct 2016 08:47:24 +0000 (09:47 +0100)]
(MODULES-3983) Update parallel_tests for ruby 2.0.0
Wilson McCoubrey [Wed, 19 Oct 2016 16:29:36 +0000 (17:29 +0100)]
Implement retry on tests which pull key from a key server which sometimes times out (transient error)
Wilson McCoubrey [Tue, 18 Oct 2016 10:15:38 +0000 (11:15 +0100)]
Fix tests to check for idempotency correctly.
Eric Putnam [Tue, 11 Oct 2016 22:48:40 +0000 (15:48 -0700)]
Merge pull request #629 from puppetlabs/modulesync
Update modulesync_config [
51f469d ]
David Schmitt [Tue, 11 Oct 2016 09:42:45 +0000 (10:42 +0100)]
Merge pull request #628 from cpavanrun/master
Undef default for $notify_update in source.pp results in problem with Puppet 3.7.2
David Schmitt [Mon, 10 Oct 2016 13:18:46 +0000 (14:18 +0100)]
Update modulesync_config [
51f469d ]
Bryan Jen [Mon, 26 Sep 2016 16:25:23 +0000 (17:25 +0100)]
Merge pull request #624 from seffenberg-naspers/fix_apt_key_with_userinfo
apt_key now really works with userinfo for http(s)
C.P.A van Run [Tue, 20 Sep 2016 15:17:00 +0000 (17:17 +0200)]
On Puppet 3.7.2 the undef default for $notify_update will overwrite the default boolean setting for $notify_update in apt::settings resulting in an error 400: "" is not a boolean
Bryan Jen [Tue, 20 Sep 2016 13:35:58 +0000 (14:35 +0100)]
Merge pull request #627 from puppetlabs/release
Release Mergeback
Daniele Sluijters [Mon, 19 Sep 2016 20:15:50 +0000 (22:15 +0200)]
Merge pull request #626 from underscorgan/maint/master/update-gpg-key
(maint) Update the gpg key
Morgan Rhodes [Fri, 16 Sep 2016 00:29:49 +0000 (17:29 -0700)]
(maint) Update the gpg key
David Schmitt [Wed, 14 Sep 2016 14:55:15 +0000 (15:55 +0100)]
Merge pull request #625 from HelenCampbell/rprep
Release prep 2.3.0
Helen Campbell [Tue, 13 Sep 2016 16:44:30 +0000 (17:44 +0100)]
Release prep
Simon Effenberg [Tue, 13 Sep 2016 13:21:15 +0000 (15:21 +0200)]
apt_key now really works with userinfo for http(s)
now http and https sources for apt_key can take a userinfo
as it should be already since #384
```
apt_key { '...':
source => 'https://username:password@myhost.com/mypath/key.gpg'
..
}
```
Daniele Sluijters [Thu, 1 Sep 2016 09:03:59 +0000 (12:03 +0300)]
Merge pull request #616 from ghoneycutt/add_confs
Add ability to specify a hash of apt::conf defines
Garrett Honeycutt [Fri, 15 Jul 2016 18:34:28 +0000 (11:34 -0700)]
Add ability to specify a hash of apt::conf defines
TP Honey [Tue, 30 Aug 2016 09:27:09 +0000 (10:27 +0100)]
Merge pull request #622 from puppetlabs/modulesync
Update modulesync_config [
a3fe424 ]
David Schmitt [Fri, 26 Aug 2016 07:28:58 +0000 (09:28 +0200)]
Update modulesync_config [
a3fe424 ]
Bryan Jen [Thu, 25 Aug 2016 15:33:09 +0000 (08:33 -0700)]
Merge pull request #621 from puppetlabs/modulesync
Update modulesync_config [
0d59329 ]
David Schmitt [Thu, 25 Aug 2016 14:13:18 +0000 (16:13 +0200)]
Update modulesync_config [
0d59329 ]
Helen [Thu, 28 Jul 2016 14:46:41 +0000 (15:46 +0100)]
Merge pull request #618 from puppetlabs/update-modulesync
(MAINT) Update for modulesync_config
72d19f184
David Schmitt [Thu, 28 Jul 2016 09:50:23 +0000 (10:50 +0100)]
(MAINT) Update for modulesync_config
72d19f184
Hunter Haugen [Wed, 27 Jul 2016 22:13:32 +0000 (15:13 -0700)]
Merge pull request #619 from DavidS/fix
Fix syntax error
David Schmitt [Wed, 27 Jul 2016 17:35:58 +0000 (18:35 +0100)]
Fix syntax error
David Schmitt [Wed, 27 Jul 2016 15:54:36 +0000 (16:54 +0100)]
Merge pull request #617 from hunner/strict_error
(MODULES-3414) Limit non-strict parsing to pre-3.5.0 only
Hunter Haugen [Wed, 27 Jul 2016 04:23:12 +0000 (21:23 -0700)]
(MODULES-3414) Limit non-strict parsing to pre-3.5.0 only
Puppet 3.5.0 introduced strict variables and the module handles strict
variables by using the defined() function. This does not work on prior
versions of puppet so we must gate based on that version.
Puppet 4 series has a new setting `strict` that may be set to enforce
strict variables while `strict_variables` remains unset (see PUP-6358)
which causes this conditional to erroniously use non-strict 3.5-era
parsing and fail.
The new conditional corrects the cases such that strict variable
behavior happens on versions 3.5.0 and later.
TP Honey [Fri, 8 Jul 2016 13:44:44 +0000 (14:44 +0100)]
Merge pull request #615 from DavidS/modulesync
(MODULES-3581) modulesync [
067d08a ]
David Schmitt [Fri, 8 Jul 2016 12:34:01 +0000 (13:34 +0100)]
(MODULES-3581) modulesync [
067d08a ]
TP Honey [Thu, 7 Jul 2016 13:36:11 +0000 (14:36 +0100)]
Merge pull request #613 from nicobn/master
Fixed "unless" test condition for ppa repository
Nick Berard [Wed, 6 Jul 2016 00:30:23 +0000 (17:30 -0700)]
Replaced `-s` with `-f` in ppa rspec tests
See
38263ac768349bf0eab56194aa70f4a78fb664af . The previous commit makes the tests fail.
Nick Berard [Sat, 2 Jul 2016 00:31:05 +0000 (17:31 -0700)]
After the repository is added, the ${::apt::sources_list_d}/${sources_list_d_filename} file is created as an empty file.
The unless condition of Exec["add-apt-repository-${name}"] calls test -s, which returns 1 if the file is empty. Because
the file is empty, the unless condition is never true and the repository is added on every execution. This commit
replaces the -s test condition with -f, which is true if the file exists or false otherwise.
David Schmitt [Thu, 30 Jun 2016 12:43:26 +0000 (13:43 +0100)]
Merge pull request #612 from puppetlabs/modulesync
{maint} modulesync
0794b2c
tphoney [Thu, 30 Jun 2016 10:53:46 +0000 (11:53 +0100)]
{maint} modulesync
0794b2c
TP Honey [Tue, 28 Jun 2016 10:41:43 +0000 (11:41 +0100)]
Merge pull request #611 from mattkenn4545/master
Fix TYPO
Matthew Kennedy [Mon, 27 Jun 2016 21:39:43 +0000 (15:39 -0600)]
Fix TYPO
Ubuntu not Ubunto
Bryan Jen [Tue, 7 Jun 2016 16:20:12 +0000 (09:20 -0700)]
Merge pull request #610 from puppetlabs/unused-lsb
apt/params: Remove unused LSB facts
Bryan Jen [Mon, 6 Jun 2016 16:25:07 +0000 (09:25 -0700)]
Merge pull request #609 from hfm/fix-regexp
Fix regexp for $ensure params
Daniele Sluijters [Sun, 5 Jun 2016 10:29:00 +0000 (12:29 +0200)]
apt/params: Remove unused LSB facts
OKUMURA Takahiro [Sat, 4 Jun 2016 18:09:31 +0000 (03:09 +0900)]
Fix regexp for $ensure params
/\Aabsent|present\Z/ match wrong values like 'absentaaa' or 'aaapresent'.
And add tests to the context of 'invalid ensure'.
Hunter Haugen [Tue, 24 May 2016 19:40:20 +0000 (12:40 -0700)]
Merge pull request #608 from DavidS/use-more-pool
Update tests to use the pool servers instead of ubuntu's
David Schmitt [Tue, 24 May 2016 18:59:51 +0000 (19:59 +0100)]
Update tests to use the pool servers instead of ubuntu's
Using the ubuntu keyserver causes stability issues during CI runs,
hopefully the pool servers are less fragile.