]> review.fuel-infra Code Review - openstack-build/neutron-build.git/log
openstack-build/neutron-build.git
12 years agoEnsures that the Linux Bridge Plugin runs with L3 agent
Gary Kotton [Tue, 11 Sep 2012 06:32:12 +0000 (06:32 +0000)]
Ensures that the Linux Bridge Plugin runs with L3 agent

Fixes bug 1048968

1. The external interface for the linux bridge will be created at run time.
The configuration parameter external_network_bridge should be set as empty.
That is, "external_network_bridge = ". The link between the network and
the physical interface should be done via the provider network parameters.
2. The plug operation for the linux bridge replaces the interface name
prefix with tap. We need to ensure that the prefix length is 3 characters.

Change-Id: Ib8e26bc1f603a1aff9560b4a40110a6824db5921

12 years agoMerge "Add enable_tunneling openvswitch configuration variable"
Jenkins [Tue, 11 Sep 2012 06:27:13 +0000 (06:27 +0000)]
Merge "Add enable_tunneling openvswitch configuration variable"

12 years agoMerge "Update metaplugin with l3 extension update"
Jenkins [Tue, 11 Sep 2012 05:48:29 +0000 (05:48 +0000)]
Merge "Update metaplugin with l3 extension update"

12 years agoRemove an external port when an error occurs during FIP creation.
Akihiro MOTOKI [Tue, 11 Sep 2012 04:44:57 +0000 (13:44 +0900)]
Remove an external port when an error occurs during FIP creation.

Fixes bug 1048140

To remove an external port, we need to use the same context used
when it is created.

Change-Id: Ia89b086b420741e7e0e92625b62e46fcfe9dbbba

12 years agoMerge "Remove the exeception handler since it makes no sense."
Jenkins [Tue, 11 Sep 2012 04:49:15 +0000 (04:49 +0000)]
Merge "Remove the exeception handler since it makes no sense."

12 years agoMerge "Add periodic check resync check to DHCP agent"
Jenkins [Tue, 11 Sep 2012 03:41:23 +0000 (03:41 +0000)]
Merge "Add periodic check resync check to DHCP agent"

12 years agoRemove the exeception handler since it makes no sense.
gongysh [Tue, 11 Sep 2012 03:03:58 +0000 (11:03 +0800)]
Remove the exeception handler since it makes no sense.

Bug #1048906

Change-Id: Idd4d20bb066a73b790155a8886bceea94f19805c

12 years agoAdd enable_tunneling openvswitch configuration variable
Bob Kukura [Sun, 9 Sep 2012 15:49:25 +0000 (11:49 -0400)]
Add enable_tunneling openvswitch configuration variable

Not all systems that support Open vSwitch support its GRE tunneling
feature that is not in the Linux kernel source tree. Therefore, a new
configuration variable, enable_tunneling, applies to both the server
and agent. Its default value is False, so it must be set to True to
enable tunneling for tenant and/or provider networks. If
enable_tunneling is False, the server will not allow creation of GRE
networks, and the agent will not initialize the tunnel bridge and will
log an error if there is an attempt to provision a GRE network. If it
is True, the agent now logs an error and exits if it fails to
initialize the patch ports used for the tunnel bridge. Fixes bug
1045610.

When there is an attempt to provision a flat or VLAN network and the
agent has no bridge mapping configured for a the specified physical
network, the agent will now log an error rather than crash.

An undefined variable in a logging statement has been corrected.

Logging levels for openvswitch have been checked and updated where
necessary, and logging statements now avoid the % string substitution
syntax. Fixes bug 1045592.

The corresponding devstack update has already been merged.

Change-Id: I149db182dd132cc05802dcb20c6b552e293664a5

12 years agoAdd periodic check resync check to DHCP agent
Mark McClain [Mon, 10 Sep 2012 19:28:56 +0000 (15:28 -0400)]
Add periodic check resync check to DHCP agent

fixes bug 1047605

This patch adds a periodic resync check to the DHCP agent that will
resync state with the Quantum server if any notification or rpc errors
have occurred since the last check.

Change-Id: I879662ff44f2991cd2ff07062bb4e770a2981528

12 years agoMerge "Remove an external interface when router-gateway is removed."
Jenkins [Tue, 11 Sep 2012 01:12:11 +0000 (01:12 +0000)]
Merge "Remove an external interface when router-gateway is removed."

12 years agoUpdate metaplugin with l3 extension update
Nachi Ueno [Sat, 8 Sep 2012 01:34:44 +0000 (01:34 +0000)]
Update metaplugin with l3 extension update

Fixes bug 1047587
Added l3 handling for api call
Add l3 test for metaplugin

Change-Id: I4cc189f68630ee2b5428b1aae45840934786be81

12 years agoMerge "openvswitch plugin does not remove inbound unicast flow in br-tun"
Jenkins [Mon, 10 Sep 2012 15:58:54 +0000 (15:58 +0000)]
Merge "openvswitch plugin does not remove inbound unicast flow in br-tun"

12 years agoAdd DHCP RPC API support to NEC OpenFlow plugin
Akihiro MOTOKI [Mon, 10 Sep 2012 12:45:33 +0000 (21:45 +0900)]
Add DHCP RPC API support to NEC OpenFlow plugin

It is necessary to use DHCP with NEC OpenFlow plugin.

Fixes bug 1048622

Change-Id: Ia33e1157644232504c1d4683bbc83d678fb58409

12 years agoRemove an external interface when router-gateway is removed.
Akihiro MOTOKI [Mon, 10 Sep 2012 12:35:29 +0000 (21:35 +0900)]
Remove an external interface when router-gateway is removed.

Fixes bug 1048617

Change-Id: Ib7e80fcd6b7e2ffd974067a8039dd74f25005856

12 years agoMerge "Added policy checks for add interface and remove interface"
Jenkins [Mon, 10 Sep 2012 00:21:07 +0000 (00:21 +0000)]
Merge "Added policy checks for add interface and remove interface"

12 years agoopenvswitch plugin does not remove inbound unicast flow in br-tun
Aaron Rosen [Thu, 6 Sep 2012 04:32:04 +0000 (00:32 -0400)]
openvswitch plugin does not remove inbound unicast flow in br-tun

Fixes bug 1044565 In addition to adding port_unbound call when using rpc

Change-Id: Ie924f94bcedebbe24f3aa0a52d1682bc944a0aec

12 years agoRemove default name for DHCP port.
Mark McClain [Sun, 9 Sep 2012 19:19:46 +0000 (15:19 -0400)]
Remove default name for DHCP port.

fixes bug 1048357

This patch removes the code that set the port name for the DHCP agent.

Change-Id: Icd769486c5f335d533349ac5e94ac9771c8ca450

12 years agoMerge "allow multiple l3-agents to run, each with one external gateway net"
Jenkins [Sun, 9 Sep 2012 17:16:05 +0000 (17:16 +0000)]
Merge "allow multiple l3-agents to run, each with one external gateway net"

12 years agoAdded policy checks for add interface and remove interface
Nachi Ueno [Wed, 5 Sep 2012 20:29:27 +0000 (20:29 +0000)]
Added policy checks for add interface and remove interface

Fixes bug 1042037
admin_only policy didn't works, so policy checks
for add interface and remove interface needed.
Also updated policy.json

Change-Id: Ifec281250ccbe1680a3e634f4efdb7ba7ef3ec94

12 years agoMerge "Prevent floating-ip and ex-gateway ports should prevent net deletion"
Jenkins [Sun, 9 Sep 2012 15:35:48 +0000 (15:35 +0000)]
Merge "Prevent floating-ip and ex-gateway ports should prevent net deletion"

12 years agoMerge "Fix broken L3 support of Ryu plugin"
Jenkins [Sun, 9 Sep 2012 15:04:36 +0000 (15:04 +0000)]
Merge "Fix broken L3 support of Ryu plugin"

12 years agoallow multiple l3-agents to run, each with one external gateway net
Dan Wendlandt [Sun, 9 Sep 2012 14:55:52 +0000 (07:55 -0700)]
allow multiple l3-agents to run, each with one external gateway net

bug #1042028

Allows user to invoke L3-agent in a way that limits the agent to
implementing only routers associated with a particular external network.
Thus, it is possible to have a deployment with multiple external networks,
since you can run one agent per external network.

Also makes l3-agent pay attention to router admin_state_up field.

Change-Id: Ia79d29301530718bc381c8e5a9d197de9452bce2

12 years agoPrevent floating-ip and ex-gateway ports should prevent net deletion
Dan Wendlandt [Sun, 9 Sep 2012 14:53:37 +0000 (07:53 -0700)]
Prevent floating-ip and ex-gateway ports should prevent net deletion

bug 1044331

Old behavior meant that any port with device owner starting with
"network:" would be auto-deleted when a network was deleted.  We don't
want that behavior for floating IPs or external network gateways.
This provides a model where we explicitly list the set of owners that
should be auto-deleted.

- Also clean up NetworkInUse message to no longer mention 'attachment',
since that is API v1 terminology.

Change-Id: Icb727ae86d490456ec1ebc55cec1bf98ae6490c9

12 years agoMerge "add local network type and use by default for tenant networks"
Jenkins [Sun, 9 Sep 2012 12:07:13 +0000 (12:07 +0000)]
Merge "add local network type and use by default for tenant networks"

12 years agoMerge "Change 422 error to 400 error"
Jenkins [Sun, 9 Sep 2012 09:52:22 +0000 (09:52 +0000)]
Merge "Change 422 error to 400 error"

12 years agoMerge "fix generation of exception for mismatched floating ip tenant-ids"
Jenkins [Sun, 9 Sep 2012 07:09:16 +0000 (07:09 +0000)]
Merge "fix generation of exception for mismatched floating ip tenant-ids"

12 years agoMerge "Give better error to client on server 500 error"
Jenkins [Sun, 9 Sep 2012 05:46:57 +0000 (05:46 +0000)]
Merge "Give better error to client on server 500 error"

12 years agoMerge "Modified code Pyflakes warning."
Jenkins [Sun, 9 Sep 2012 05:35:54 +0000 (05:35 +0000)]
Merge "Modified code Pyflakes warning."

12 years agoMerge "Modified code Pyflakes warning."
Jenkins [Sun, 9 Sep 2012 05:35:14 +0000 (05:35 +0000)]
Merge "Modified code Pyflakes warning."

12 years agoMerge "Modified code Pyflakes warning."
Jenkins [Sun, 9 Sep 2012 05:34:10 +0000 (05:34 +0000)]
Merge "Modified code Pyflakes warning."

12 years agofix generation of exception for mismatched floating ip tenant-ids
Dan Wendlandt [Sun, 9 Sep 2012 05:25:19 +0000 (22:25 -0700)]
fix generation of exception for mismatched floating ip tenant-ids

bug 1048104

There was a KeyError in the case where we tried to throw an exception
to inform the user that a newly created floating ip could not be
associated with the requested port because they belonged to different
tenants.

Change-Id: I387e5f166761da78b941b62a9a396809491b8f09

12 years agoGive better error to client on server 500 error
Dan Wendlandt [Sun, 9 Sep 2012 05:18:39 +0000 (22:18 -0700)]
Give better error to client on server 500 error

bug 1048109

Change-Id: Iaaa187a7868ee6227315b9c3354b424fe7c42508

12 years agoMerge "Add IP version check for IP address fields."
Jenkins [Sun, 9 Sep 2012 05:08:48 +0000 (05:08 +0000)]
Merge "Add IP version check for IP address fields."

12 years agoChange 422 error to 400 error
Nachi Ueno [Sun, 9 Sep 2012 04:58:07 +0000 (04:58 +0000)]
Change 422 error to 400 error

Fixes bug 1046956
For error code consistency, change 422 error to 400 error

Change-Id: I1d150c883e204af8a32de61f91392a46d8397ae1

12 years agoAdd IP version check for IP address fields.
Akihiro MOTOKI [Fri, 7 Sep 2012 10:31:10 +0000 (19:31 +0900)]
Add IP version check for IP address fields.

Fixes bug 1046952

In create/update_subnet(), IP address fields (cidr, gateway_ip, host_routes,
dns_nameserver) should be checked whether they are consistent with IP version
specified. IP version check for allocation_pools is already implemented,
so this commit adds IP version checks for other IP fields.

Change-Id: Ic02f5a1fd8ec4c1c363599c906ba0c818dd22268

12 years agoPolicies for external networks
Salvatore Orlando [Mon, 3 Sep 2012 21:17:20 +0000 (14:17 -0700)]
Policies for external networks

Bug #1042030 , part 2

Also reworks model queries in order to allow plugins and extensions
to augment them as required through hooks.

Change-Id: Ice72fc6d3b1c613d596c037818ed66d7e9ed841d

12 years agoMerge "remove incorrect mock assert_called in unit tests"
Jenkins [Sat, 8 Sep 2012 20:37:19 +0000 (20:37 +0000)]
Merge "remove incorrect mock assert_called in unit tests"

12 years agoMerge "Add IP commands to rootwrap fileter for OVS agent"
Jenkins [Sat, 8 Sep 2012 19:58:09 +0000 (19:58 +0000)]
Merge "Add IP commands to rootwrap fileter for OVS agent"

12 years agoAdd IP commands to rootwrap fileter for OVS agent
Gary Kotton [Sat, 8 Sep 2012 17:02:29 +0000 (13:02 -0400)]
Add IP commands to rootwrap fileter for OVS agent

Fixes bug 1045598

Change-Id: I97151030e5f3a71202b583dea6797ca16bd34f7c

12 years agoModified code Pyflakes warning.
siyingchun [Sat, 8 Sep 2012 14:06:54 +0000 (22:06 +0800)]
Modified code Pyflakes warning.

File dhcp_rpc_base.py:
W402 'db' imported but unused

Change-Id: Ie376f3b9bf4745b33d57a47f520ea8a4cb58be10

12 years agoModified code Pyflakes warning.
siyingchun [Sat, 8 Sep 2012 14:01:07 +0000 (22:01 +0800)]
Modified code Pyflakes warning.

File api.py:
W402 'q_exc' imported but unused

Change-Id: Ibe8fa9c3b3607165bcd30867ef0df71aea04806b

12 years agoModified code Pyflakes warning.
siyingchun [Sat, 8 Sep 2012 13:54:05 +0000 (21:54 +0800)]
Modified code Pyflakes warning.

File utils.py:
W402 'datetime' imported but unused
W402 'inspect' imported but unused
W402 'exception' imported but unused

Change-Id: I07ad88653e1b0a98ea80a6206890428de3f24865

12 years agoModified code Pyflakes warning.
siyingchun [Sat, 8 Sep 2012 13:49:17 +0000 (21:49 +0800)]
Modified code Pyflakes warning.

File api_common.py:
W402 'wsgi' imported but unused

Change-Id: If475bae879d2f0412d48fed5eb5c819c7d941f14

12 years agoModified code Pyflakes warning.
siyingchun [Sat, 8 Sep 2012 13:42:27 +0000 (21:42 +0800)]
Modified code Pyflakes warning.

File netns_cleanup_util.py:
W402 'os' imported but unused
W402 'traceback' imported but unused

Change-Id: I439341d82198895412b1610cab607396c559ccb0

12 years agoModified code Pyflakes warning.
siyingchun [Sat, 8 Sep 2012 13:35:26 +0000 (21:35 +0800)]
Modified code Pyflakes warning.

File l3_agent.py:
W402 'linux_utils' imported but unused

Change-Id: I774cb00c2d55ffdd1184694810bb7a7f6e3de724

12 years agoModified code Pyflakes warning.
siyingchun [Sat, 8 Sep 2012 13:24:51 +0000 (21:24 +0800)]
Modified code Pyflakes warning.

File ovs_lib.py:
W402 'shlex' imported but unused
W402 'signal' imported but unused
W402 'subprocess' imported but unused

Change-Id: I10132c42390f1ea4b1a6171146d7bee0e1b0d8fa

12 years agoModified code Pyflakes warning.
siyingchun [Sat, 8 Sep 2012 11:45:17 +0000 (19:45 +0800)]
Modified code Pyflakes warning.

File iptables_manager.py:
W402 'ConfigParse' imported but unused
W402 'subprocess' imported but unused

Change-Id: Ib364835518c0517dbe9e95d1ac6445bfbd704860

12 years agoModified code Pyflakes warning.
siyingchun [Sat, 8 Sep 2012 11:37:03 +0000 (19:37 +0800)]
Modified code Pyflakes warning.

File config.py:
W402 'os' imported but unused

Change-Id: Ie6e728183638312ccfa09e62626e05a49289009b

12 years agoMerge "Fix dhcp agent rpc exception handling"
Jenkins [Sat, 8 Sep 2012 14:35:29 +0000 (14:35 +0000)]
Merge "Fix dhcp agent rpc exception handling"

12 years agoFix broken L3 support of Ryu plugin
Yoshihiro Kaneko [Sat, 8 Sep 2012 09:15:04 +0000 (18:15 +0900)]
Fix broken L3 support of Ryu plugin

Fixes bug 1047230

This patch adds support for the router:external attribute of a network
to Ryu plugin.

Change-Id: I135fe0a4e90fe049cabbaa1b87e9294ec0613530

12 years agoMerge "check subnet overlapping when adding interface to router"
Jenkins [Sat, 8 Sep 2012 07:49:08 +0000 (07:49 +0000)]
Merge "check subnet overlapping when adding interface to router"

12 years agocheck subnet overlapping when adding interface to router
Hisaharu Ishii [Fri, 7 Sep 2012 00:32:56 +0000 (17:32 -0700)]
check subnet overlapping when adding interface to router

Fixes bug 1046061

Add logic in _check_for_dup_router_subnet to check subnets are not overlapped.
Add testcase test_router_add_interface_overlapped_cidr.

Change-Id: I71b6cce07273686cc5e4636ce640b7201ce00b32

12 years agoadd local network type and use by default for tenant networks
Bob Kukura [Tue, 4 Sep 2012 16:30:34 +0000 (12:30 -0400)]
add local network type and use by default for tenant networks

Fixes bug 1045142.

This patch adds 'local' as a new value for provider:network_type,
supported by the openvswitch and linuxbridge plugins. Networks of this
type provide connectivity through a bridge for VMs and agents local to
the host, but no external connectivity. They do not require
provider:physical_network or provider:segmentation_id values. These
local networks are intended mainly to support single-box
zero-configuration testing (including quantum gating), but may have
other uses as well.

For openvswitch, the new OVS.tenant_network_type configuration
variable selects what type of networks are allocated as tenant
(i.e. non-provider) networks. It defaults to 'local', but must be
changed to 'vlan' or 'gre' for openvswitch tenant networks to have
external connectivity. The default value is intended to support
single-box zero-configuration testing without any need to allocate
physical network resources or configure bridges, and without requiring
the operating system to support OVS GRE tunneling. It can also be set
to 'none' to completely disable creation of tenant networks.

For linuxbridge, the new VLANS.tenant_network_type configuration
variable works similarly, with a value of 'vlan' supporting tenant
networks with external connectivity.

With either plugin, administrators can create provider local networks
by specifying "--provider:network_type local". Additionally, with
openvswitch, provider GRE networks can now be created by specifying
"--provider:network_type gre --provider:segmentation_id <tunnel-id>".

A corresponding devstack patch is available at
https://review.openstack.org/#/c/12456/. With this patch, the
openvswitch and linuxbridge plugins are by default configured to
support only local networks. A set of shell variables, documented in
stack.sh, can be set in localrc to configure remote connectivity,
including bridges/interfaces available for provider networks.

Change-Id: I2812548326141d2212d04f34d5448fb974d298e0

12 years agoFix data passed to policy engine on update
Salvatore Orlando [Fri, 7 Sep 2012 23:45:48 +0000 (16:45 -0700)]
Fix data passed to policy engine on update

fix bug 1044218

The original resource status fetched to the db was not being
properly updated with the request body before feeding it to the
policy engine

Change-Id: I9f71e40edf44136a40fad1ef272696d6b3ea352d

12 years agoremove incorrect mock assert_called in unit tests
Mark McClain [Fri, 7 Sep 2012 18:52:12 +0000 (14:52 -0400)]
remove incorrect mock assert_called in unit tests

fixes bug 1047569

The unit tests were calling a nonexistent assert_called() on the
mocks.  This patch fixes the problem by using the correct assert for
checking that the mocked method was invoked.

Note: This patch does not fix the error in test_call_driver() because a
separate bug fix revises the test.

Change-Id: Ie62e2e64f314f9ba34761e63cd5d0d6e44c5d094

12 years agoFix dhcp agent rpc exception handling
Mark McClain [Fri, 7 Sep 2012 16:39:39 +0000 (12:39 -0400)]
Fix dhcp agent rpc exception handling

fixes bug 1046904

This patch adds exception handling to log rpc exceptions.  Previously,
the agent would terminate due to uncaught errors during initialization.

Change-Id: I4835c1616e2ccfc9c42c591e8c7446db50721d01

12 years agoMerge "Add missing include for logging when log_config is used"
Jenkins [Fri, 7 Sep 2012 12:14:25 +0000 (12:14 +0000)]
Merge "Add missing include for logging when log_config is used"

12 years agoMerge "Modified code Pyflakes warning."
Jenkins [Fri, 7 Sep 2012 10:39:24 +0000 (10:39 +0000)]
Merge "Modified code Pyflakes warning."

12 years agoAdd missing include for logging when log_config is used
Gary Kotton [Fri, 7 Sep 2012 10:37:06 +0000 (06:37 -0400)]
Add missing include for logging when log_config is used

Fixes bug 1047273

Change-Id: I7fb8a504acf8fa910100d9798e2a35274aa5a103

12 years agoMerge "Improve error message when flat network already exists"
Jenkins [Fri, 7 Sep 2012 10:23:38 +0000 (10:23 +0000)]
Merge "Improve error message when flat network already exists"

12 years agoModified code Pyflakes warning.
siyingchun [Fri, 7 Sep 2012 09:46:32 +0000 (17:46 +0800)]
Modified code Pyflakes warning.

File dhcp.py:
W402 'textwrap' imported but unused
W402 'importutils' imported but unused

Change-Id: I5b3cee932ad224486ba3fbf4bbd44005b1200bfb

12 years agoModified code pyflakes warning.
siyingchun [Fri, 7 Sep 2012 09:30:31 +0000 (17:30 +0800)]
Modified code pyflakes warning.

W402 'version_string' imported but unused

Change-Id: I6dad8661c2dc0358821f76b911b13b21e788d738

12 years agoImprove error message when flat network already exists
Bob Kukura [Fri, 7 Sep 2012 01:42:54 +0000 (21:42 -0400)]
Improve error message when flat network already exists

Fixes bug 1045601.

When attempting to create a flat network on a physical_network on
which a flat network is already allocated, the openvswitch and
linuxbridge plugins return a FlatNetworkInUse exception rather than a
VlanIdInUse exception referencing VLAN -1.

Change-Id: Id79e917e1376ebbb199efc3f14d9f378c6a04050

12 years agoMerge "Lower webob dep from v1.2.0 to v1.0.8"
Jenkins [Thu, 6 Sep 2012 18:58:17 +0000 (18:58 +0000)]
Merge "Lower webob dep from v1.2.0 to v1.0.8"

12 years agoLower webob dep from v1.2.0 to v1.0.8
Brian Waldon [Thu, 6 Sep 2012 17:43:05 +0000 (10:43 -0700)]
Lower webob dep from v1.2.0 to v1.0.8

All other OpenStack projects expect webob v1.0.8 yet Quantum expects
v1.2.0. This discrepancy causes problems for certain projects that
can't actually support v1.2.0 yet. This patch aligns the required
version with that which the other OpenStack projects expect.

Change-Id: I21b4c6c79a0382f241131f22edbeba22388a688d

12 years agoMerge "Allocation pool creation should check if gateway is in subnet"
Jenkins [Thu, 6 Sep 2012 12:53:49 +0000 (12:53 +0000)]
Merge "Allocation pool creation should check if gateway is in subnet"

12 years agoAllocation pool creation should check if gateway is in subnet
Gary Kotton [Wed, 5 Sep 2012 08:19:40 +0000 (04:19 -0400)]
Allocation pool creation should check if gateway is in subnet

Fixes bug 1046192

If the configured gateway is not in the subnet then it should not be
used for the allocation pool creation.

Change-Id: Ifba766a13d860b58d21034db278c6b24d4c126e7

12 years agoMake sure floating IPs + gateways must be on external nets
Dan Wendlandt [Thu, 6 Sep 2012 05:43:22 +0000 (22:43 -0700)]
Make sure floating IPs  + gateways must be on external nets

bug #1042030

- adds admin-writable, world-readable router:external attribute to
the network object if L3 extension is loaded.
- prevents floating ips from being created unless network is external
- shortens L3 extensions alias from 'os-quantum-router' to 'router' to
make attribute extensions more readable.

WIP:
- Need to add policy logic so non-admin users can always see external
networks without requiring that these networks are shared (since VMs can
always create ports on shared networks, but provider may want to have
externals networks that VMs cannot directly plug into.

Random clean-up:
- prevent delete_network in plugins from implying it returns something
- modify extensions.py so that exceptions during calls to
get_extended_resources() will actually be logged if unexpected.
- unset executable bit on test_iptables_manager.py to make sure tox
actually runs it.

Change-Id: I5bbf063927b93458da7cb467d9ad5c92ebabbbf7

12 years agoMerge "add rootwrap filters to wrap ip netns exec"
Jenkins [Thu, 6 Sep 2012 01:41:38 +0000 (01:41 +0000)]
Merge "add rootwrap filters to wrap ip netns exec"

12 years agoMerge "restart dnsmasq when subnet cidr set changes"
Jenkins [Wed, 5 Sep 2012 22:45:37 +0000 (22:45 +0000)]
Merge "restart dnsmasq when subnet cidr set changes"

12 years agorestart dnsmasq when subnet cidr set changes
Mark McClain [Wed, 5 Sep 2012 04:52:21 +0000 (00:52 -0400)]
restart dnsmasq when subnet cidr set changes

fixes bug 1045828

The original bug occurred because the set of subnet cidrs changed
without a restart of dnsmasq.  As a result, dnsmasq would not respond
with offers for fixed_ips assigned in the unknown cidr ranges even when
the underlying host file had properly updated.

This patch addresses the bug by restarting dnsmasq when the set of
subnet cidrs changes.  When the set does not change, it will reload the
options and allocations.

Change-Id: I0e257208750703f4a32c51d1323786e76e676bb6

12 years agosupress dhcp router opt for subnets with null gw
Mark McClain [Wed, 5 Sep 2012 04:27:27 +0000 (00:27 -0400)]
supress dhcp router opt for subnets with null gw

fixes bug 1045617

This patch supresses the default gateway for subnets without gateway
defined.

Change-Id: I29d84863e51f613d8529153870eb7542d992be0e

12 years agoadd rootwrap filters to wrap ip netns exec
Mark McClain [Tue, 4 Sep 2012 23:50:00 +0000 (19:50 -0400)]
add rootwrap filters to wrap ip netns exec

fixes bug 1044083

This patch adds specific filters for the ip command. The first filter
matches ip with any subcomand except netns exec.  The second filter
matches "ip netns exec" and then relies on the caller (match_filter) to
verify the sub-command against the other filters. Matching the
subcommand separately allows for a single set of filter definitions that
work with and without namespaces.

Change-Id: Ifd0378dc3461f84867efb3cb60396d9cfa9e582d

12 years agoMerge "Create utility to clean-up netns."
Jenkins [Wed, 5 Sep 2012 00:27:24 +0000 (00:27 +0000)]
Merge "Create utility to clean-up netns."

12 years agoMerge "Fix lack of L3 support of Ryu plugin"
Jenkins [Tue, 4 Sep 2012 21:19:06 +0000 (21:19 +0000)]
Merge "Fix lack of L3 support of Ryu plugin"

12 years agoMerge "Implements agent for Quantum Networking testing"
Jenkins [Tue, 4 Sep 2012 17:55:13 +0000 (17:55 +0000)]
Merge "Implements agent for Quantum Networking testing"

12 years agoMerge "Quantum dhcp crashes if no networks exist"
Jenkins [Tue, 4 Sep 2012 17:52:40 +0000 (17:52 +0000)]
Merge "Quantum dhcp crashes if no networks exist"

12 years agoMerge "Update with latest code from openstack-common (stable/folsom)"
Jenkins [Tue, 4 Sep 2012 17:23:49 +0000 (17:23 +0000)]
Merge "Update with latest code from openstack-common (stable/folsom)"

12 years agoImplements agent for Quantum Networking testing
Nachi Ueno [Fri, 10 Aug 2012 22:15:32 +0000 (22:15 +0000)]
Implements agent for Quantum Networking testing

This agent client plugs itself into each network.
Then tries to ping each fixed_ips.
Implements blueprint test-agent

Change-Id: I3908e37401272e9e091ceae66e72cfcdd13b7898

12 years agoQuantum dhcp crashes if no networks exist
Aaron Rosen [Fri, 31 Aug 2012 22:34:49 +0000 (15:34 -0700)]
Quantum dhcp crashes if no networks exist

Fixes bug 1043583

Change-Id: Ibdfeb98c094b80ea63e79b23f14811e00525d96b

12 years agoUpdate with latest code from openstack-common (stable/folsom)
Gary Kotton [Tue, 4 Sep 2012 11:04:26 +0000 (07:04 -0400)]
Update with latest code from openstack-common (stable/folsom)

Fixes bug 1039777

Due to changes in quantum/openstack/common/cfg.py,
quantum/plugins/nicira/nicira_nvp_plugin/common/config.py
also needed to be updated.

Change-Id: Id240f8b5e2d80dde168b6d7c0eebeb9c5c398e42

12 years agoFixes undefined variable 'network_type' in OVS agent
Akihiro MOTOKI [Tue, 4 Sep 2012 11:13:18 +0000 (20:13 +0900)]
Fixes undefined variable 'network_type' in OVS agent

bug 1045749

Change-Id: Icd2e79722cfcb816bfdfa85bd8b8ab5198908474

12 years agoCreate utility to clean-up netns.
Mark McClain [Mon, 20 Aug 2012 14:18:01 +0000 (10:18 -0400)]
Create utility to clean-up netns.

Fixes bug 1035366

Adds namespace clean up utility called quantum-netns-cleanup which can be used
to remove old namespaces.

The --force option can be used to remove all Quantum namespaces and any
remaining devices.  The force option is should not be run on a live Quantum
systems.  It is intended for cleaning up devstack a after running
unstack.sh (ideally this will be added to unstack.sh in the future).

Example cmd line when cleaning up a devstack install:
quantum-netns-cleanup --config-file /etc/quantum/quantum.conf \
--config-file /etc/quantum/dhcp_agent.ini --force

Change-Id: I6cf153df21e83bff2cde816db12b22102d1ba698

12 years agoMerge "ovs_lib unable to parse return when port == -1"
Jenkins [Tue, 4 Sep 2012 05:34:01 +0000 (05:34 +0000)]
Merge "ovs_lib unable to parse return when port == -1"

12 years agoFix lack of L3 support of Ryu plugin
Yoshihiro Kaneko [Thu, 30 Aug 2012 14:50:06 +0000 (23:50 +0900)]
Fix lack of L3 support of Ryu plugin

VMs cannot access the external network without l3 support.

Fixes bug 1043746

Change-Id: I6bd2cb69ba80ce3c799f346ca67c17ff77244ba4

12 years agoMerge "L3: make use of namespaces by agent configurable"
Jenkins [Tue, 4 Sep 2012 00:07:27 +0000 (00:07 +0000)]
Merge "L3: make use of namespaces by agent configurable"

12 years agoEnsure that port update set correct tag in OVS
Gary Kotton [Sat, 1 Sep 2012 05:53:59 +0000 (01:53 -0400)]
Ensure that port update set correct tag in OVS

Fixes bug 1044556.

This patch also ensures that the local vlan mapping is updated correctly.
This was problematic in the event that the OVS agent would start and a port
was in administrative state down.

Change-Id: I4e5145547e73a58fee3f08a129fda6bc0ec42b72

12 years agoovs_lib unable to parse return when port == -1
Aaron Rosen [Mon, 3 Sep 2012 22:00:48 +0000 (15:00 -0700)]
ovs_lib unable to parse return when port == -1

Fixes bug 1045536

Change-Id: I463dd31d67dff74caae1a0230df5d78c21beaf04

12 years agoL3: make use of namespaces by agent configurable
Gary Kotton [Mon, 27 Aug 2012 11:30:22 +0000 (07:30 -0400)]
L3: make use of namespaces by agent configurable

Fixes bug 1042104

The fix follows the patch that was done on the DHCP agent to enable
the user to configure the usage of namespaces. In the event that
namspaces are disabled the agent is limited to running only one
router. The agent needs to define the router_id that is supported.
The process in this case is:
1. create router
2. start agent with router id

Change-Id: I2a71dc009c5aea285ff9f903b3faa99b0c9f820f

12 years agoMerge "Fix programming error of ryu-plugin"
Jenkins [Mon, 3 Sep 2012 19:59:12 +0000 (19:59 +0000)]
Merge "Fix programming error of ryu-plugin"

12 years agoFix error in rule for metadata server dnat
Salvatore Orlando [Mon, 3 Sep 2012 12:43:29 +0000 (05:43 -0700)]
Fix error in rule for metadata server dnat

Fixes bug 1045312

Change-Id: Ie0e2aa7e638a7cd50c87ae6d4fa807cb7733c3d1

12 years agoMerge "Ensure network delete is handled by OVS agent"
Jenkins [Mon, 3 Sep 2012 12:41:43 +0000 (12:41 +0000)]
Merge "Ensure network delete is handled by OVS agent"

12 years agoMerge "Implement L3 support in Metaplugin"
Jenkins [Mon, 3 Sep 2012 12:41:38 +0000 (12:41 +0000)]
Merge "Implement L3 support in Metaplugin"

12 years agoFix programming error of ryu-plugin
Yoshihiro Kaneko [Mon, 3 Sep 2012 11:07:25 +0000 (20:07 +0900)]
Fix programming error of ryu-plugin

Fixes bug 1045275

This patch fixes a programming error of the ryu-plugin.

Change-Id: I4226e3bdf9611ce25298b37b7ba9e6be8a9e3cba

12 years agoMerge "netns commands should always run in the root ns"
Jenkins [Mon, 3 Sep 2012 09:53:12 +0000 (09:53 +0000)]
Merge "netns commands should always run in the root ns"

12 years agoEnsure network delete is handled by OVS agent
Gary Kotton [Sat, 1 Sep 2012 07:27:14 +0000 (03:27 -0400)]
Ensure network delete is handled by OVS agent

Fixes bug 1044574

The class OVSRpcCallbacks was deleted and the treatment of the RPC
callbacks moved into OVSQuantumAgent.

Change-Id: I1c5f5185e3f7e0f27aba6d254f2bb3b6edf6a385

12 years agoImplement L3 support in Metaplugin
Nachi Ueno [Mon, 20 Aug 2012 05:00:14 +0000 (05:00 +0000)]
Implement L3 support in Metaplugin

Added flavor:route property for router
Rename flavor:id to flavor:network
Fixes bug 1038778

Change-Id: Ia358b4f03c1b96ade2d1b7323298b117b2cbe52a

12 years agoFixes agent problem with RPC
Gary Kotton [Sun, 2 Sep 2012 15:15:32 +0000 (11:15 -0400)]
Fixes agent problem with RPC

Fixed bug 1044135

When quantum-openvswitch-agent or quantum-linuxbridge-agent were
called the eventlet monkey patch was not invoked.

Change-Id: Iafb7fd02d37415c3466213d28280bcb4573de4a8

12 years agonetns commands should always run in the root ns
Mark McClain [Fri, 31 Aug 2012 19:48:27 +0000 (15:48 -0400)]
netns commands should always run in the root ns

fixes bug 1044542

Previously, some netns commands were executed in the context of the
namespace defined in the wrapper. These commands should be be executed in
the root namespace for the most reliable results.

Change-Id: I4915aa6f75af3f65ce2adb40360bcd841f549239

12 years agoMerge "Plugin aware extensions should also be reset at each test setup"
Jenkins [Sat, 1 Sep 2012 17:50:06 +0000 (17:50 +0000)]
Merge "Plugin aware extensions should also be reset at each test setup"