]> review.fuel-infra Code Review - openstack-build/cinder-build.git/log
openstack-build/cinder-build.git
12 years agoUpdate dev docs
John Griffith [Mon, 3 Sep 2012 23:16:49 +0000 (17:16 -0600)]
Update dev docs
  * Quick pass at implementing the basics for cinder dev docs
  * Remove the N/A compute related stuff
  * Clean up the architecture a bit to only show cinder related
  * Remove various modules form TOC's that aren't applicable

Change-Id: I0089c388524c9def7494658e836f4ed03a61f5b5

12 years agoTypo fix: nova => cinder
RongzeZhu [Mon, 3 Sep 2012 04:26:35 +0000 (12:26 +0800)]
Typo fix: nova => cinder

Change-Id: I816473b3aa7de16bd2d8569c695c6ced9e1d9033

12 years agoMove newly created NFS exceptions to standard location in exception.py
Ben Swartzlander [Thu, 30 Aug 2012 00:35:33 +0000 (20:35 -0400)]
Move newly created NFS exceptions to standard location in exception.py
Addresses bug 1037619

bug 1037619

Change-Id: I20b1c612c03ef90eeb074814b979a9bc7492109c

12 years agoMerge "Remove unused flags"
Jenkins [Sat, 1 Sep 2012 00:57:54 +0000 (00:57 +0000)]
Merge "Remove unused flags"

12 years agoMerge "Use event.listen() instead of deprecated listeners kwarg"
Jenkins [Fri, 31 Aug 2012 16:41:24 +0000 (16:41 +0000)]
Merge "Use event.listen() instead of deprecated listeners kwarg"

12 years agoMerge "Implement volume quota support in Cinder"
Jenkins [Fri, 31 Aug 2012 16:12:07 +0000 (16:12 +0000)]
Merge "Implement volume quota support in Cinder"

12 years agoMerge "Fix creation of iscsi targets"
Jenkins [Fri, 31 Aug 2012 15:23:45 +0000 (15:23 +0000)]
Merge "Fix creation of iscsi targets"

12 years agoMerge "Add cinder- prefix to all binaries."
Jenkins [Fri, 31 Aug 2012 15:22:33 +0000 (15:22 +0000)]
Merge "Add cinder- prefix to all binaries."

12 years agoMerge "Make glance image service check base exception classes"
Jenkins [Fri, 31 Aug 2012 15:06:31 +0000 (15:06 +0000)]
Merge "Make glance image service check base exception classes"

12 years agoAdd cinder- prefix to all binaries.
Dan Prince [Fri, 31 Aug 2012 13:56:50 +0000 (09:56 -0400)]
Add cinder- prefix to all binaries.

Renames clear_rabbit_queues and volume-usuage-audit binaries
so that they are prefixed with 'cinder-'.

As part of this change the clear_rabbit_queues binary was changed
to use dashes instead of underscores for consistency with the rest
of the cinder binaries.

Fixes LP Bug #1044386.

Change-Id: I7692a543cc67af2d342a64b84626de38c0a64f81

12 years agoFix creation of iscsi targets
Chuck Short [Tue, 28 Aug 2012 20:06:25 +0000 (15:06 -0500)]
Fix creation of iscsi targets

Previously when creating iscsi volumes, we were using

tgt-admin -e -c <config file> --update volume-id

Unfortunately the side affect of this is that tgt-admin
removed other volumes that weren't connected to an iscsi
connector. Which is obvlously not what we want.

In order to fix this we create the targets.conf for the
volume but we call tgt-admin --update icssi qualified name.

We're dropping the use of iscsi_targets table when using TgtAdm.
Compatability for other target admin types is maintained.

Fixes LP: #1038062

Change-Id: I9060a43208df5b79e9b17dadcab8bc0a8eeef55e
Signed-off-by: Chuck Short <chuck.short@canonical.com>
12 years agoSpelling: Persistant=>Persistent
Joe Gordon [Thu, 30 Aug 2012 20:35:07 +0000 (13:35 -0700)]
Spelling: Persistant=>Persistent

Change-Id: Id8e1bef634fe66e06624b5b3bcd82f59735d76e3

12 years agoImplement volume quota support in Cinder
John Griffith [Thu, 16 Aug 2012 21:52:52 +0000 (15:52 -0600)]
Implement volume quota support in Cinder

parital fix for bug 1023311
  * To use needs cinderclient https://review.openstack.org/#/c/11509/
  * Updates quota classes with changes in Nova
  * Adds needed quota related DB tables
  * Updates test_quota to reflect changes in Nova
  * Adds absolute limits and empty rate limit functions
  * Updates test/integration/test_volume to make it work w/ above changes

Change-Id: I221c7a9dc51a2bb9bf7228c056f63ba9546cf5f9

12 years agoMerge "Fix PEP8 issues."
Jenkins [Thu, 30 Aug 2012 17:02:44 +0000 (17:02 +0000)]
Merge "Fix PEP8 issues."

12 years agoMerge "Add 'detaching' to volume status"
Jenkins [Thu, 30 Aug 2012 17:01:50 +0000 (17:01 +0000)]
Merge "Add 'detaching' to volume status"

12 years agoMerge "Remove unused return values and commented out code from NFS driver"
Jenkins [Thu, 30 Aug 2012 17:01:28 +0000 (17:01 +0000)]
Merge "Remove unused return values and commented out code from NFS driver"

12 years agoMerge "Remove unused exceptions from cinder/exception.py"
Jenkins [Thu, 30 Aug 2012 15:43:42 +0000 (15:43 +0000)]
Merge "Remove unused exceptions from cinder/exception.py"

12 years agoRemove unused return values and commented out code from NFS driver
Ben Swartzlander [Wed, 29 Aug 2012 23:10:11 +0000 (19:10 -0400)]
Remove unused return values and commented out code from NFS driver

bug 1037622

Change-Id: Idea3005ad94fd6bfc76fd0f3969ee78e3031767e

12 years agoRemove unused flags
Rongze Zhu [Wed, 29 Aug 2012 09:46:32 +0000 (09:46 +0000)]
Remove unused flags

* region_list
* aws_access_key_id
* aws_secret_access_key
* osapi_scheme
* osapi_path
* metadata_host
* metadata_port
* default_project
* default_image
* default_instance_type
* vpn_image_id
* vpn_key_suffix
* auth_token_ttl
* bandwith_poll_interval
* start_guests_on_host_boot
* resume_guests_state_on_host_boot
* default_ephemeral_format
* use_ipv6
* allow_resize_to_same_host
* zombie_instance_updated_at_window
* isolated_images
* isolated_hosts

Change-Id: Ia3d5ac7d7c983845b5411e2fc1f49eb579e3280f

12 years agoFix PEP8 issues.
lrqrun [Tue, 28 Aug 2012 15:28:48 +0000 (23:28 +0800)]
Fix PEP8 issues.

Fix some pep8 issues in doc/ext/cinder_todo.py make the code looks pretty.

Change-Id: I137c8bf5af30eb54a44cbff7f1fbc35bc2c3ed9e

12 years agoMerge "Migrate volume related quota info in db migration"
Jenkins [Mon, 27 Aug 2012 16:04:14 +0000 (16:04 +0000)]
Merge "Migrate volume related quota info in db migration"

12 years agoMerge "Fix PEP8 issues."
Jenkins [Sat, 25 Aug 2012 17:57:27 +0000 (17:57 +0000)]
Merge "Fix PEP8 issues."

12 years agoMerge "Typo fix in cinder: existant => existent"
Jenkins [Sat, 25 Aug 2012 17:49:37 +0000 (17:49 +0000)]
Merge "Typo fix in cinder: existant => existent"

12 years agoMerge "Fix incorrect tgt-admin call in create_iscsi_target"
Jenkins [Sat, 25 Aug 2012 17:49:02 +0000 (17:49 +0000)]
Merge "Fix incorrect tgt-admin call in create_iscsi_target"

12 years agoFix incorrect tgt-admin call in create_iscsi_target
John Griffith [Thu, 23 Aug 2012 19:23:04 +0000 (13:23 -0600)]
Fix incorrect tgt-admin call in create_iscsi_target

  * Fixes bug 1039826
  * Missed one of the execute cmds that was using 'val %s' as args

Change-Id: I5e6af737ada1c2bcf7a495710e2b10c8c74bb534

12 years agoAdd 'detaching' to volume status
Rongze Zhu [Tue, 21 Aug 2012 15:07:02 +0000 (15:07 +0000)]
Add 'detaching' to volume status

Fixes bug #1004382

When attach a volume , the volume status is "available -> attaching ->
in-use", But when detaching a volume , the volume status is "in-use ->
available". So We need 'detaching' volume status, it make the change of
state of the volume more clearly.

Change-Id: Idf8c38413135bf8e8cd025f11937f8c7250557c1

12 years agoTypo fix in cinder: existant => existent
Rongze Zhu [Thu, 23 Aug 2012 03:00:08 +0000 (03:00 +0000)]
Typo fix in cinder: existant => existent

Impact:
* locale message in cinder/locale/*/LC_MESSAGES/nova.po
* locale message in cinder/locale/nova.po
* Test function names
* Test strings and comments

Change-Id: I623af176d3b556a1ea9f8bde2c609fc4f752d7da

12 years agoMake glance image service check base exception classes
John Griffith [Wed, 22 Aug 2012 22:26:15 +0000 (16:26 -0600)]
Make glance image service check base exception classes

Fixes bug 1039675

glanceclient can raise HTTPNotFound (as well as NotFound) it appears,
but glance image service is only converting NotFound ->
InstanceNotFound.  Same applies to 'Forbidden' and other exceptions.

This patch converts 'exc_type is NotFound'-like checks to use
'isinstance' instead, which will cover HTTPNotFound, etc.

Also add missing glance/image tests that weren't in Cinder

Change-Id: I8787598daccf401a26d9397946ecd55f89ff62b3

12 years agoFix PEP8 issues.
Ray Chen [Wed, 22 Aug 2012 03:57:42 +0000 (11:57 +0800)]
Fix PEP8 issues.

Fix some pep8 issues in doc/ext/cinder_todo.py and
doc/source/conf.py and make the code looks pretty.

Change-Id: Ie164bc7328507e20b0ab5993ba97eaadbd74bf63

12 years agoRemove unused exceptions from cinder/exception.py
RongzeZhu [Wed, 22 Aug 2012 03:37:26 +0000 (11:37 +0800)]
Remove unused exceptions from cinder/exception.py

find cinder/ -type f -name "*pyc" -exec rm {} \;
exceptions=`cat cinder/exception.py| grep -E '^class' |\
 awk {'print $2'} | awk -F '(' {'print $1'}`
for exc in $exceptions
do
    i=`find cinder/ -type f -exec grep -R $exc {} \; |wc -l`
    if [ $i -eq 1 ]
    then
        echo $exc
    fi
done

First removed exceptions:

DecryptionFailure
ImagePaginationFailed
VirtualInterfaceCreateException
VirtualInterfaceMacAddressException
MelangeConnectionFailed
VolumeUnattached
InvalidKeypair
InvalidSignature
InvalidInstanceType
InvalidIpProtocol
InvalidCidr
InvalidAggregateAction
InvalidGroup
InstanceInvalidState
InstanceNotRunning
InstanceNotSuspended
InstanceNotInRescueMode
InstanceSuspendFailure
InstanceResumeFailure
InstanceRebootFailure
InstanceTerminationFailure
VolumeServiceUnavailable
UnableToMigrateToSelf
DestinationHostUnavailable
SourceHostUnavailable
InvalidHypervisorType
DestinationHypervisorTooOld
DestinationDiskExists
InvalidDevicePath
DeviceIsBusy
InvalidCPUInfo
InvalidIpAddressError
InvalidVLANTag
InvalidVLANPortGroup
InvalidDiskFormat
InstanceUnacceptable
FlagNotSet
NoVolumeTypesFound
VolumeDriverNotFound
ListingImageRefsNotSupported
KernelNotFoundForImage
ProjectNotFound
ProjectMembershipNotFound
UserRoleNotFound
StorageRepositoryNotFound
DatastoreNotFound
FixedIpNotFoundForAddress
FixedIpNotFoundForInstance
FixedIpNotFoundForNetworkHost
FixedIpNotFoundForSpecificInstance
FixedIpNotFoundForHost
FixedIpAlreadyInUse
FixedIpInvalid
NoMoreFixedIps
NoFixedIpsDefined
FloatingIpDNSExists
FloatingIpNotFoundForAddress
FloatingIpNotFoundForHost
NoMoreFloatingIps
FloatingIpAssociated
FloatingIpNotAssociated
NoFloatingIpsDefined
NoFloatingIpInterface
KeypairNotFound
CertificateNotFound
AuthTokenNotFound
AccessKeyNotFound
SecurityGroupNotFoundForProject
SecurityGroupNotFoundForRule
SecurityGroupExistsForInstance
SecurityGroupNotExistsForInstance
NoInstanceTypesFound
InstanceTypeNotFoundByName
FlavorNotFound
CellNotFound
SchedulerHostFilterNotFound
SchedulerCostFunctionNotFound
SchedulerWeightFlagNotFound
InstanceMetadataNotFound
InstanceTypeExtraSpecsNotFound
LDAPUserNotFound
LDAPGroupNotFound
LDAPGroupMembershipNotFound
NoFilesFound
SwitchNotFoundForNetworkAdapter
NetworkAdapterNotFound
GlobalRoleNotAllowed
ImageRotationNotAllowed
RotationRequiredForBackup
LDAPUserExists
LDAPGroupExists
LDAPMembershipExists
ProjectExists
InstanceExists
InstanceTypeExists
InvalidSharedStorage
CannotResizeToSameSize
ImageTooLarge
ZoneRequestError
InstanceTypeMemoryTooSmall
InstanceTypeDiskTooSmall
InsufficientFreeMemory
CouldNotFetchMetrics
AggregateError
AggregateNotFound
AggregateNameExists
AggregateHostNotFound
AggregateMetadataNotFound
AggregateHostConflict
AggregateHostExists
InstanceTypeCreateFailed
SolidFireAPIStatusException
DuplicateVlan
InvalidInstanceIDMalformed
CouldNotFetchImage

Search again, Second removed exceptions:

UserNotFound
FixedIpNotFoundForNetwork
FloatingIpNotFound
SecurityGroupNotFound
InstanceTypeNotFound
LDAPObjectNotFound
UserExists

Search again, Third removed exceptions:

FixedIpNotFound

Change-Id: I028122c6132340b2fef2c144da787b7c4efddccf

12 years agoAdd nosehtmloutput as a test dependency.
Clark Boylan [Tue, 21 Aug 2012 21:08:57 +0000 (14:08 -0700)]
Add nosehtmloutput as a test dependency.

Adding nosehtmloutput as a test dependency allows nose to output its
results to an html file. This will be used by Jenkins to save logs
on a different server.

Change-Id: I03f61fe4a8f0daa4a43fc9e7d41456b65018cf66

12 years agoMigrate volume related quota info in db migration
John Griffith [Tue, 21 Aug 2012 20:00:18 +0000 (14:00 -0600)]
Migrate volume related quota info in db migration

  * Fixes bug 1039615
  * Now that quotas are back we need to handle migration
    of volume related quota data in the cinder-manage migrate helper
  * Only resource types transferred are volumes and gigabytes

Change-Id: Idd9aab834612e929683491f47fa1e1861bdbd0d1

12 years agoMerge "Add declare for xiv driver in fake_flags"
Jenkins [Tue, 21 Aug 2012 00:19:27 +0000 (00:19 +0000)]
Merge "Add declare for xiv driver in fake_flags"

12 years agoMerge "Remove logging in volume tests"
Jenkins [Mon, 20 Aug 2012 17:12:40 +0000 (17:12 +0000)]
Merge "Remove logging in volume tests"

12 years agoUse event.listen() instead of deprecated listeners kwarg
unicell [Mon, 20 Aug 2012 11:34:19 +0000 (19:34 +0800)]
Use event.listen() instead of deprecated listeners kwarg

Fixes bug 1031405

The listeners kwarg is deprecated in SQLAlchemy 0.7.0. Since 0.7.3 is
the minimum required version of SQLAlchemy, use the new event.listen()
API instead.

Change-Id: I1b851e197c04b131ae96e814780b04e6dcdeeb1a

12 years agoAdd declare for xiv driver in fake_flags
John Griffith [Fri, 17 Aug 2012 17:27:21 +0000 (11:27 -0600)]
Add declare for xiv driver in fake_flags

  fixes bug 1038183

Change-Id: I324a8e4df61782c903146cc8e0bb1d1bbae46c2f

12 years agoMerge "Call driver for attach/detach_volume."
Jenkins [Fri, 17 Aug 2012 16:34:33 +0000 (16:34 +0000)]
Merge "Call driver for attach/detach_volume."

12 years agoMerge "Remove unused function"
Jenkins [Fri, 17 Aug 2012 15:35:03 +0000 (15:35 +0000)]
Merge "Remove unused function"

12 years agoRemove logging in volume tests
RongzeZhu [Fri, 17 Aug 2012 14:24:43 +0000 (22:24 +0800)]
Remove logging in volume tests

Fixes bug #932137

Usage of logging seems to be limited to the check_for_export() tests and
should be to cleanup. check_for_export() raises an exception if there's
a problem and it does nothing if it succeeds. The tests should just
check whether an exception was raised.

Change-Id: I72bc3d97aa75950c7f31fae03535c541059501c2

12 years agoCall driver for attach/detach_volume.
Cory Stone [Fri, 17 Aug 2012 14:18:52 +0000 (09:18 -0500)]
Call driver for attach/detach_volume.

The volume driver may want to know which guest is going to be
attached to a volume. The manager now calls down into the driver
on attach_volume and detach_volume.

Fixes bug 1038109.

Change-Id: I084c2d09a1871fa158312f9ba479abb474da1d28

12 years agoFix spelling typos
RongzeZhu [Fri, 17 Aug 2012 03:20:09 +0000 (11:20 +0800)]
Fix spelling typos

Fixes for:
* cinder/locale/*/LC_MESSAGES/nova.po
* cinder/locale/nova.pot
* cinder/testing/README.rst

Change-Id: Ib50432a72b2300742169ebe4c77584466be7bfba

12 years agoRemove unused function
RongzeZhu [Fri, 17 Aug 2012 02:07:05 +0000 (10:07 +0800)]
Remove unused function

'wait_creation' function in cinder.volume.api.API is unused.

Change-Id: I4062e026b3e227513321be18ee920a4e5882cbd7

12 years agoMerge "Remove unused imports"
Jenkins [Thu, 16 Aug 2012 04:58:27 +0000 (04:58 +0000)]
Merge "Remove unused imports"

12 years agoMerge "Implements bp migrate-nova-volumes-to-cinder"
Jenkins [Thu, 16 Aug 2012 04:48:41 +0000 (04:48 +0000)]
Merge "Implements bp migrate-nova-volumes-to-cinder"

12 years agoMerge "blueprint zadara-volume-driver"
Jenkins [Thu, 16 Aug 2012 04:01:24 +0000 (04:01 +0000)]
Merge "blueprint zadara-volume-driver"

12 years agoMerge "Add driver for using files on a generic NFS server as virtual block devices...
Jenkins [Thu, 16 Aug 2012 04:01:23 +0000 (04:01 +0000)]
Merge "Add driver for using files on a generic NFS server as virtual block devices Add NetApp-specific NFS virtual block driver"

12 years agoMerge "Update SolidFire volume driver"
Jenkins [Thu, 16 Aug 2012 03:23:24 +0000 (03:23 +0000)]
Merge "Update SolidFire volume driver"

12 years agoblueprint zadara-volume-driver
Vladimir Popovski [Fri, 10 Aug 2012 07:14:26 +0000 (00:14 -0700)]
blueprint zadara-volume-driver

Adds support for Zadara VPSA storage arrays as a BackEnd for Cinder

Change-Id: I8c2a163079853d4003223eb2c156cfd2ccef3129

12 years agoMerge "add ability to clone images"
Jenkins [Thu, 16 Aug 2012 01:37:28 +0000 (01:37 +0000)]
Merge "add ability to clone images"

12 years agoMerge "Add proper support for deprecation messages"
Jenkins [Thu, 16 Aug 2012 01:23:36 +0000 (01:23 +0000)]
Merge "Add proper support for deprecation messages"

12 years agoAdding the volume notifications to cinder
Craig Vyvial [Wed, 15 Aug 2012 20:50:29 +0000 (15:50 -0500)]
Adding the volume notifications to cinder

adding the volume notifications
added unit tests for notifications
added context for notify with rabbit

blueprint cinder-notifications

Change-Id: I5aef1e718eebb9a61e0670d524fcd5f438dee016

12 years agoadd ability to clone images
Josh Durgin [Tue, 14 Aug 2012 19:27:48 +0000 (12:27 -0700)]
add ability to clone images

Given the backend location from Glance, drivers can determine
whether they can clone or otherwise efficiently create a volume
from the image without downloading all the data from Glance.

For now implement cloning for the RBD driver. There's already a
Glance backend that stores images as RBD snapshots, so they're
ready to be cloned into volumes. Fall back to copying all the
data if cloning is not possible.

Change-Id: I71a8172bd22a5bbf64d4c68631630125fcc7fd34
Implements: blueprint efficient-volumes-from-images
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
12 years agoUpdate SolidFire volume driver
John Griffith [Tue, 14 Aug 2012 00:35:35 +0000 (18:35 -0600)]
Update SolidFire volume driver

Implements blueprint update-solidfire-driver

* Updates driver to reflect changes in the release version of SF API
* Modify SF naming scheme
* Implement snapshot functionality
* Implement setting qos on create via metadata
* Update/Add tests

Change-Id: I08f7aac31e9d95f971d297a19c285dfa7151b931

12 years agoMerge "add get_location method for images"
Jenkins [Wed, 15 Aug 2012 20:15:21 +0000 (20:15 +0000)]
Merge "add get_location method for images"

12 years agoAdd proper support for deprecation messages
Thierry Carrez [Wed, 8 Aug 2012 15:49:44 +0000 (17:49 +0200)]
Add proper support for deprecation messages

Add support for warning once about deprecated options. Use that in
the rootwrap options deprecation message, and move it to run_as_root
so that the deprecated message is emitted once and only if used.

Change-Id: I29e39c662b4456256f4c9397f305bfa857972c46

12 years agoRemove utils.deprecated functions.
Dan Prince [Sat, 11 Aug 2012 03:10:18 +0000 (23:10 -0400)]
Remove utils.deprecated functions.

We don't seem to use utils.deprecated at all... so lets
remove it and save ourselves 200 lines of code.

Also moves a couple misc. test cases in utils.py out of the
DeprecationTest suite and into the GenericUtilsTestCase
suite.

Change-Id: I96e93d8fa056110057c8855f2ce52c9f55cd4a9b

12 years agoMerge "Move volume size validation to api layer."
Jenkins [Wed, 15 Aug 2012 17:40:35 +0000 (17:40 +0000)]
Merge "Move volume size validation to api layer."

12 years agoMove volume size validation to api layer.
Eoghan Glynn [Wed, 15 Aug 2012 13:10:03 +0000 (14:10 +0100)]
Move volume size validation to api layer.

As per the discussion on this patch:

  ihttps://review.openstack.org/10540

Change-Id: I5d3031a08aa1e2d17b5fb233ebaec938c66fa88b

12 years agoMap internal exceptions in the nova style.
Eoghan Glynn [Wed, 15 Aug 2012 10:36:09 +0000 (10:36 +0000)]
Map internal exceptions in the nova style.

Fixes LP 1014687.

Adopt the nova idiom of internal exceptions mapped to their
corresponding HTTP reponse code in the FaultWrapper middleware,
and also inclusion of their detail message if declared safe for
external exposure.

Change-Id: I95a3c30466f6951e02f7a182545ff8db8fbecee8

12 years agoAdd driver for using files on a generic NFS server as virtual block devices
Ben Swartzlander [Mon, 13 Aug 2012 20:57:50 +0000 (16:57 -0400)]
Add driver for using files on a generic NFS server as virtual block devices
Add NetApp-specific NFS virtual block driver

blueprint nfs-files-as-virtual-block-devices
blueprint netapp-nfs-cinder-driver

Change-Id: I10ef6f3e230fcea2748152313d341db46bffce55

12 years agoImplements bp migrate-nova-volumes-to-cinder
John Griffith [Wed, 8 Aug 2012 19:33:08 +0000 (13:33 -0600)]
Implements bp migrate-nova-volumes-to-cinder

  Helper cmds to transition from nova to cinder

  Implements an import section in cinder-manage to transfer
  applicable tables from local or remote Nova database into a
  fresh Cinder database.

  Also implements optional method to copy persistent target files.

Change-Id: I2e655e26c55f1986f3b1554726cead9e73ee9bd6

12 years agoMerge "Add C-mode driver for NetApp."
Jenkins [Tue, 14 Aug 2012 20:33:53 +0000 (20:33 +0000)]
Merge "Add C-mode driver for NetApp."

12 years agoadd get_location method for images
Josh Durgin [Tue, 14 Aug 2012 19:26:19 +0000 (12:26 -0700)]
add get_location method for images

This is useful for determining whether the backend storage for the
image in Glance is the same as the storage used in a volume driver.

The direct_url is only available in the v2 images API, so add a
version parameter to each request. As more parts of the v2 API are
used, this parameter will become more useful.

Change-Id: I5ca06b6d80ffe4118f8dd381ed11283573bce71f
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
12 years agoMerge "Driver for IBM XIV storage."
Jenkins [Tue, 14 Aug 2012 17:24:38 +0000 (17:24 +0000)]
Merge "Driver for IBM XIV storage."

12 years agorbd: implement create_volume_from_snapshot
Josh Durgin [Mon, 13 Aug 2012 22:13:06 +0000 (15:13 -0700)]
rbd: implement create_volume_from_snapshot

In an upcoming release, rbd will support creating volumes from
snapshots ('cloning'). To clone a snapshot, it must first be
'protected', which means it cannot be deleted until it is unprotected.
A snapshot can only be unprotected if no clones depend on it. Thus,
translate a failure to unprotect into a SnapshotIsBusy exception.

Also check for remaining snapshots before deleting a volume,
and raise VolumeIsBusy if any exist. While we're here, tidy up
the shell arguments to be more readable.

This is backwards compatible since it does not use the new features
unless they are available in the installed version of rbd.

Change-Id: If4105e7af7ba33f09a15103b53ad675aceb2ebb4
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
12 years agoReplace deprecated client with python-glanceclient
Josh Durgin [Sun, 12 Aug 2012 09:21:00 +0000 (02:21 -0700)]
Replace deprecated client with python-glanceclient

This is a copy of the code that was merged into Nova.
python-glanceclient is required for Folsom, and for using
the v2 API.

Implementing blueprint efficient-volumes-from-images
requires this since it needs to access the v2 API.

Change-Id: Ia088517abab61e824a641d4adf616e08a53a94bc

12 years agoRemove unused imports
RongzeZhu [Tue, 14 Aug 2012 14:07:42 +0000 (22:07 +0800)]
Remove unused imports

Fixes bug #1036666

Removed unused imports found by:
find . -type f -name "*py" -exec pylint -r n {} \; | grep -E "Unused imp|^\*"

Change-Id: Iad69354dd47c2a0dfa3a23a95c1a23eb66773b8d

12 years agoMerge "Adds new volume API extensions"
Jenkins [Tue, 14 Aug 2012 13:29:46 +0000 (13:29 +0000)]
Merge "Adds new volume API extensions"

12 years agoFix check_for_export() in non-exporting drivers
Josh Durgin [Mon, 13 Aug 2012 17:42:27 +0000 (10:42 -0700)]
Fix check_for_export() in non-exporting drivers

This overrides the default check_for_export so that drivers that don't
need to export block devices on the host like Sheepdog and RBD don't
raise a NotImplemented exception when this is called.

Reported-by: Mark Moseley <moseleymark@gmail.com>
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
Change-Id: Icf72f51904e7bdc368bfaf0a91dd0433ce3b1cf6

12 years agoAdds new volume API extensions
Unmesh Gurjar [Sat, 11 Aug 2012 17:31:51 +0000 (10:31 -0700)]
Adds new volume API extensions

Adds following extensions:
1. Create volume from image
2. Copy volume to image

Added unit tests.

Implements: blueprint create-volume-from-image
Change-Id: I9c73bd3fa2fa2e0648c01ff3f4fc66f757d7bc3f

12 years agoDriver for IBM XIV storage.
Avishay Traeger [Sun, 12 Aug 2012 11:55:04 +0000 (14:55 +0300)]
Driver for IBM XIV storage.

Volume driver for IBM XIV storage systems, along with unit tests. The
driver imports the xiv_openstack_box class, which is a closed-source
proxy available separately to IBM XIV customers.

Change-Id: I3a3ec8b1d3e3adf1895b4a0bbd86993010d2e447

12 years agoMerge "Fake requests in tests should be to v1"
Jenkins [Mon, 13 Aug 2012 07:51:09 +0000 (07:51 +0000)]
Merge "Fake requests in tests should be to v1"

12 years agoFake requests in tests should be to v1
Mike Perez [Sun, 12 Aug 2012 23:20:53 +0000 (16:20 -0700)]
Fake requests in tests should be to v1

v2 does not exist, yet.

Change-Id: Id3a332c4d78c87882a7db1a8b98479a3881b0a5f

12 years agoAdd C-mode driver for NetApp.
Ben Swartzlander [Sun, 12 Aug 2012 04:43:05 +0000 (00:43 -0400)]
Add C-mode driver for NetApp.

blueprint netapp-volume-driver-cmode

Change-Id: I1eb418d05f557068bc0d4f359e19721c9c61068b

12 years agostorwize-svc: improved test coverage and fixes.
Avishay Traeger [Sun, 12 Aug 2012 08:31:26 +0000 (11:31 +0300)]
storwize-svc: improved test coverage and fixes.

Added test cases to cover more error paths, now providing 97% test
coverage of the storwize-svc driver. Some tests uncovered bugs in the
driver, which are fixed by this patch. In addition, there are some
fixes to the code included which address comments from the submission
of this driver to nova-volume and sync the two versions.

Change-Id: I7c646885a7f2b1e761725c14940f1d741996beb4

12 years agoMerge "Add iscsiadm path for qauntal."
Jenkins [Fri, 10 Aug 2012 20:34:01 +0000 (20:34 +0000)]
Merge "Add iscsiadm path for qauntal."

12 years agoMerge "Use openstack.common.notifier."
Jenkins [Fri, 10 Aug 2012 20:25:10 +0000 (20:25 +0000)]
Merge "Use openstack.common.notifier."

12 years agoUse setuptools-git.
Monty Taylor [Fri, 10 Aug 2012 15:55:48 +0000 (11:55 -0400)]
Use setuptools-git.

Change-Id: I6861a29d65b809362949f2c54197940fd0988785

12 years agoAdd iscsiadm path for qauntal.
Chuck Short [Fri, 10 Aug 2012 15:06:50 +0000 (10:06 -0500)]
Add iscsiadm path for qauntal.

Resynchronize with nova/etc/nova/rootwrap.d/nova.volumes.

Change-Id: I9737454bb2f48bbd97fe14bca163059e93ef825b
Signed-off-by: Chuck Short <chuck.short@canonical.com>
12 years agoCreate unique volumes_dir for testing.
Dan Prince [Tue, 7 Aug 2012 20:25:52 +0000 (16:25 -0400)]
Create unique volumes_dir for testing.

Updates test_volume.py so that we create a uniq volumes_dir for testing.
This avoids polluting the source tree with fake volume UUID's when running
tests.

Change-Id: I3c37083915effec0eff7c8d9bfffb9f7674fe6f5

12 years agoMerge "Straight port of the NetApp driver updates from nova-volume to cinder."
Jenkins [Thu, 9 Aug 2012 21:33:28 +0000 (21:33 +0000)]
Merge "Straight port of the NetApp driver updates from nova-volume to cinder."

12 years agoMerge "Remove redundant 'availability_zone' config options."
Jenkins [Thu, 9 Aug 2012 17:34:50 +0000 (17:34 +0000)]
Merge "Remove redundant 'availability_zone' config options."

12 years agoMerge "Admin users should be restricted from seeing all snapshots by default."
Jenkins [Thu, 9 Aug 2012 17:33:21 +0000 (17:33 +0000)]
Merge "Admin users should be restricted from seeing all snapshots by default."

12 years agoRemove redundant 'availability_zone' config options.
Zhiteng Huang [Wed, 8 Aug 2012 16:41:28 +0000 (00:41 +0800)]
Remove redundant 'availability_zone' config options.

There are two availability_zone related config options now:
  node_availability_zone and storage_availability_zone
While volume API uses node_availability_zone, the scheduler uses
the other, which causes failure in scheduler when these two options
have different values.

This patch removes 'node_availability_zone' so that end user
can specify 'availability zone' when create volumes using
Simple scheduler.

Partially implement blueprint implement-availability-zones

Change-Id: Ia2f0710908495ec64dacd2ee9bd10d7f8cd415df

12 years agoStraight port of the NetApp driver updates from nova-volume to cinder.
Ben Swartzlander [Wed, 8 Aug 2012 18:27:44 +0000 (14:27 -0400)]
Straight port of the NetApp driver updates from nova-volume to cinder.

These changes were already accepted into nova-volume, and I have only
altered the exception classes to match the new cinder classes.

blueprint netapp-volume-driver

Change-Id: I0d59db64e00bc7e93223a24dabadbcbd0b290fb9

12 years agoMerge "Deprecate root_helper in favor of rootwrap_config"
Jenkins [Tue, 7 Aug 2012 23:49:59 +0000 (23:49 +0000)]
Merge "Deprecate root_helper in favor of rootwrap_config"

12 years agoUse volume driver specific execeptions.
Ronen Kat [Mon, 6 Aug 2012 07:11:10 +0000 (10:11 +0300)]
Use volume driver specific execeptions.

Change generic use of exception.Error in the cinder/volume directory
to specific exceptions. The exceptions used in this patch are:
exception.VolumeBackendAPIException
exception.InvalidInput
exception.InvalidVolume
exceptio.VolumeAtatched
Patch includes updates to the appropriate tests as well.

Change-Id: I10407ff3f5babe64e88f445d3529269b7665ee16

12 years agoMerge "Add persistent volumes for tgtd."
Jenkins [Tue, 7 Aug 2012 04:09:00 +0000 (04:09 +0000)]
Merge "Add persistent volumes for tgtd."

12 years agoMerge "Send 'create volume from snapshot' to the proper host"
Jenkins [Tue, 7 Aug 2012 03:50:25 +0000 (03:50 +0000)]
Merge "Send 'create volume from snapshot' to the proper host"

12 years agoAdmin users should be restricted from seeing all
jakedahn [Sun, 5 Aug 2012 21:32:07 +0000 (14:32 -0700)]
Admin users should be restricted from seeing all
snapshots by default.

  * Now to view all snapshots across all tenants you need
    to include the all_tenants=1 GET param in your api request.
  * Fixes remaining issues blocking bug #967882

Change-Id: I2a8338d77badc70201bb315198183f2091df43fb

12 years agoUse openstack.common.notifier.
Chmouel Boudjnah [Mon, 6 Aug 2012 08:25:31 +0000 (10:25 +0200)]
Use openstack.common.notifier.

- Update openstack.common.log to use it (and fixes #1030078 for cinder as
  well so we can get review I9d4251b4292188c0174ebac1dcd98318df44c0e3
  working).
- Don't use openstack.common.context but our own just yet.

Change-Id: I10feda623788a3b2418cad6bf55cbdb860ba8ee7

12 years agoAdmin users should be restricted from seeing all
jakedahn [Tue, 31 Jul 2012 23:35:26 +0000 (16:35 -0700)]
Admin users should be restricted from seeing all
volumes by default.

  * Now to view all volumes across all tenants you need
    to include the all_tenants=1 GET param in your api request.
  * Fixes remaining issues blocking bug #967882

Change-Id: Ie9d74e9c09fa0c192ab6257b5fb02d65b593cbfb

12 years agoDeprecate root_helper in favor of rootwrap_config
Thierry Carrez [Fri, 3 Aug 2012 13:35:03 +0000 (15:35 +0200)]
Deprecate root_helper in favor of rootwrap_config

Align with recent changes in nova-rootwrap by marking the
root_helper option deprecated and introduce usage of the
rootwrap_config option instead. The root_helper option will still
fully be supported in Folsom, but will be removed in Grizzly.

Transition notes: you should replace:
root_helper=sudo cinder-rootwrap /etc/cinder/rootwrap.conf

by:
rootwrap_config=/etc/cinder/rootwrap.conf

Change-Id: I22a6d2bdee6ad2c5ad587ceec574cec4b2887f22

12 years agoSend 'create volume from snapshot' to the proper host
ZhuRongze [Fri, 13 Jul 2012 12:07:13 +0000 (12:07 +0000)]
Send 'create volume from snapshot' to the proper host

A simple solution for bug 1008866. When creating volume from snapshot on
multicluster, in volume it will check if snapshot_id is set. If snapshot_id
is set, make the call create volume directly to the volume host where the
snapshot resides instead of passing it through the scheduler. So snapshot can
be copy to new volume.

Change-Id: Ie9c1a77f62abc40e294b1d0c604cf885652728da

12 years agoAdd persistent volumes for tgtd.
Chuck Short [Fri, 27 Jul 2012 17:05:55 +0000 (12:05 -0500)]
Add persistent volumes for tgtd.

Currently if you restart the server running nova-volume
or restart tgt, you will loose your iscsi targets that
have been created. This is not good.

In order for iscsi targets to be persistent across
reboots or restarts, one has to have the target's configuration
information in /etc/tgt/targets.conf or /etc/tgt/conf.d.
So when tgtd is restarted then the iscsi targets will be there
as expected.

This patch will add a configuration file to $state_path/volumes
when the volume is created. The configuration file is identified by
the volume uuid. It creates a logicalunit when the volume is created
as well. The iscsi target and configuration file
will be removed once the volume has been removed as well.

In order to use this, you have to include the following in
your /etc/tgt/targets.conf

include $state_path/volumes/*

For upgrades, it will just re-create the volumes
already in the volumes table.

Fixes LP: #1011159

Change-Id: Ib74dcc1efa0332842041b4c045ca5fa85d4a32ca
Signed-off-by: Chuck Short <chuck.short@canonical.com>
12 years agoMerge "Include AUTHORS file in MANIFEST.in"
Jenkins [Wed, 1 Aug 2012 18:40:04 +0000 (18:40 +0000)]
Merge "Include AUTHORS file in MANIFEST.in"

12 years agoMerge "Scheduler-clean-up"
Jenkins [Wed, 1 Aug 2012 18:40:01 +0000 (18:40 +0000)]
Merge "Scheduler-clean-up"

12 years agoMerge "Add authors for IBM Storwize and SVC driver."
Jenkins [Wed, 1 Aug 2012 18:40:00 +0000 (18:40 +0000)]
Merge "Add authors for IBM Storwize and SVC driver."

12 years agoScheduler-clean-up
ZhuRongze [Sat, 28 Jul 2012 08:14:03 +0000 (08:14 +0000)]
Scheduler-clean-up

Some instance related functions and opts were still present in Cinder
Scheduler.

Remove the functions and opts and modify some computer related comments.

Change-Id: Ia01099e66bcbb129493870dfbf212d5e6669ebe1

12 years agoInclude AUTHORS file in MANIFEST.in
Chmouel Boudjnah [Wed, 1 Aug 2012 07:05:24 +0000 (09:05 +0200)]
Include AUTHORS file in MANIFEST.in

Change-Id: I4b2ddeaaaa5f58eafd25cba6bd613c6fe477ad4d