]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/log
puppet-modules/puppetlabs-firewall.git
10 years agoMerge pull request #525 from jonnytpuppet/tee-support
David Schmitt [Thu, 7 May 2015 13:13:23 +0000 (14:13 +0100)]
Merge pull request #525 from jonnytpuppet/tee-support

Tee Support

10 years agoMerge pull request #526 from elyscape/arch_linux
JT (Jonny) [Thu, 7 May 2015 13:07:24 +0000 (14:07 +0100)]
Merge pull request #526 from elyscape/arch_linux

Fix Arch Linux support

10 years agoMerge pull request #528 from puppetlabs/modulesync_updates
JT (Jonny) [Thu, 7 May 2015 13:06:43 +0000 (14:06 +0100)]
Merge pull request #528 from puppetlabs/modulesync_updates

Modulesync updates

10 years agobeaker gemfile fixes
Morgan Haskel [Wed, 6 May 2015 21:32:28 +0000 (14:32 -0700)]
beaker gemfile fixes

10 years agosync via modulesync
Morgan Haskel [Wed, 6 May 2015 21:30:39 +0000 (14:30 -0700)]
sync via modulesync

10 years agosync via modulesync
Morgan Haskel [Wed, 6 May 2015 21:10:01 +0000 (14:10 -0700)]
sync via modulesync

10 years agoGentoo is not Arch Linux
Eli Young [Wed, 6 May 2015 18:38:50 +0000 (11:38 -0700)]
Gentoo is not Arch Linux

10 years agoArch Linux is not a Red Hat distro
Eli Young [Wed, 6 May 2015 18:36:51 +0000 (11:36 -0700)]
Arch Linux is not a Red Hat distro

Previously, Arch Linux was incorrectly assumed to be part of the RedHat
osfamily. It actually has its own osfamily: Archlinux. However, this was
added in Facter 1.7.0, and previous versions use an osfamily of Linux,
so we just check the value of operatingsystem.

10 years agoMerge pull request #515 from peikk0/add-icmpv6-types-neighbour
JT (Jonny) [Wed, 6 May 2015 18:37:40 +0000 (19:37 +0100)]
Merge pull request #515 from peikk0/add-icmpv6-types-neighbour

Add support for ICMPv6 types neighbour-{solicitation,advertisement}

10 years agoTEE Feature
Jonathan Davies [Sun, 22 Feb 2015 21:45:45 +0000 (21:45 +0000)]
TEE Feature

10 years agoMerge pull request #524 from jonnytpuppet/mssfix
David Schmitt [Wed, 6 May 2015 18:09:02 +0000 (19:09 +0100)]
Merge pull request #524 from jonnytpuppet/mssfix

MSS feature

10 years agoMerge pull request #514 from peikk0/add-icmpv6-type-too-big
JT (Jonny) [Wed, 6 May 2015 17:45:17 +0000 (18:45 +0100)]
Merge pull request #514 from peikk0/add-icmpv6-type-too-big

Add support for ICMPv6 type too-big (2)

10 years agoMSS test fixes
Jonathan Tripathy [Wed, 6 May 2015 17:33:18 +0000 (18:33 +0100)]
MSS test fixes

10 years agoFix tcp-mss acceptance test
Erik Dalén [Thu, 23 Apr 2015 13:51:26 +0000 (15:51 +0200)]
Fix tcp-mss acceptance test

The acceptance test needed to set the tcp_flags to SYN,RST SYN as MSS
only works on TCP SYN packets. Otherwise iptables will exit with an
error.

10 years agoAdded support for setting the MSS of a packet.
Jonathan Davies [Sun, 22 Feb 2015 17:57:30 +0000 (17:57 +0000)]
Added support for setting the MSS of a packet.

10 years agoMerge pull request #523 from jonnytpuppet/debian_8_ubuntu_1410_fixes
David Schmitt [Wed, 6 May 2015 16:31:43 +0000 (17:31 +0100)]
Merge pull request #523 from jonnytpuppet/debian_8_ubuntu_1410_fixes

Added iptables-persistent fix for Debian 8 and Ubuntu 14.10

10 years agoMerge pull request #522 from jonnytpuppet/time_iptmodule
David Schmitt [Wed, 6 May 2015 16:30:43 +0000 (17:30 +0100)]
Merge pull request #522 from jonnytpuppet/time_iptmodule

Added support for time ipt_module

10 years agoAdded iptables-persistent fix for Debian 8 and Ubuntu 14.10
Jonathan Tripathy [Wed, 6 May 2015 15:49:08 +0000 (16:49 +0100)]
Added iptables-persistent fix for Debian 8 and Ubuntu 14.10

10 years agoAdded support for time ipt_module
Jonathan Tripathy [Tue, 5 May 2015 18:20:52 +0000 (19:20 +0100)]
Added support for time ipt_module

10 years agoMerge pull request #521 from jonnytpuppet/idemp_fix
TP Honey [Wed, 6 May 2015 10:59:37 +0000 (11:59 +0100)]
Merge pull request #521 from jonnytpuppet/idemp_fix

Fixed lint issue

10 years agoFixed lint issue
Jonathan Tripathy [Wed, 6 May 2015 10:54:09 +0000 (11:54 +0100)]
Fixed lint issue

10 years agoMerge pull request #520 from jonnytpuppet/idemp_fix
Hunter Haugen [Tue, 5 May 2015 15:55:29 +0000 (08:55 -0700)]
Merge pull request #520 from jonnytpuppet/idemp_fix

Fixed idempotency bug relating to MODULES-1984

10 years agoFixed idempotency bug relating to MODULES-1984
Jonathan Tripathy [Tue, 5 May 2015 15:52:55 +0000 (16:52 +0100)]
Fixed idempotency bug relating to MODULES-1984

10 years agoMerge pull request #518 from johnduarte/1984-patch-for-centos7
JT (Jonny) [Tue, 5 May 2015 10:40:13 +0000 (11:40 +0100)]
Merge pull request #518 from johnduarte/1984-patch-for-centos7

(MODULES-1984) Perform daemon-reload on systemd

10 years ago(MODULES-1984) Perform daemon-reload on systemd
John Duarte [Tue, 28 Apr 2015 20:07:31 +0000 (13:07 -0700)]
(MODULES-1984) Perform daemon-reload on systemd

This commit patches the `manifests/linux/redhat.pp` manifest to
perform a `systemctl daemon-reload` exec on platforms that also
contain firewalld.

Prior to this commit, Specifically on Centos 7, if the systemd
deamon is not reloaded then the iptables service fails to start
because it cannot see the systemd Unit for that service.

This patch refreshes the daemon's list of Units and allows the
service to start as expected.

10 years agoAdd support for ICMPv6 types neighbour-{solicitation,advertisement}
Pierre GUINOISEAU [Thu, 23 Apr 2015 09:29:30 +0000 (11:29 +0200)]
Add support for ICMPv6 types neighbour-{solicitation,advertisement}

10 years agoAdd ICMPv6 type too-big in specs
Pierre GUINOISEAU [Thu, 23 Apr 2015 08:53:51 +0000 (10:53 +0200)]
Add ICMPv6 type too-big in specs

10 years agoAdd support for ICMPv6 type too-big (2)
Pierre Guinoiseau [Thu, 23 Apr 2015 08:35:35 +0000 (10:35 +0200)]
Add support for ICMPv6 type too-big (2)

10 years agoMerge pull request #505 from jpds/ipv4-encap
JT (Jonny) [Wed, 1 Apr 2015 13:51:51 +0000 (14:51 +0100)]
Merge pull request #505 from jpds/ipv4-encap

Added ipv{4,6} to protocol list

10 years agoMerge pull request #506 from jpds/firewallchains-drop-readme
JT (Jonny) [Wed, 1 Apr 2015 13:50:11 +0000 (14:50 +0100)]
Merge pull request #506 from jpds/firewallchains-drop-readme

README: Added example of firewallchain for drop policy on input.

10 years agoMerge pull request #511 from puppetlabs/1.5.x
Morgan Haskel [Tue, 31 Mar 2015 20:32:56 +0000 (16:32 -0400)]
Merge pull request #511 from puppetlabs/1.5.x

Merge 1.5.0 back to master

10 years agoMerge pull request #510 from mhaskel/readme_clarifications
Colleen Murphy [Tue, 31 Mar 2015 15:34:02 +0000 (08:34 -0700)]
Merge pull request #510 from mhaskel/readme_clarifications

purge clarifications

10 years agopurge clarifications
Morgan Haskel [Tue, 31 Mar 2015 15:26:06 +0000 (11:26 -0400)]
purge clarifications

10 years agoMerge pull request #509 from mhaskel/MODULES-1866
TP Honey [Tue, 31 Mar 2015 14:51:48 +0000 (15:51 +0100)]
Merge pull request #509 from mhaskel/MODULES-1866

(MODULES-1866) Update documentation for purging firewall chains

10 years ago(MODULES-1866) Update documentation for purging firewall chains
Morgan Haskel [Tue, 31 Mar 2015 14:43:06 +0000 (10:43 -0400)]
(MODULES-1866) Update documentation for purging firewall chains

10 years agoMerge pull request #508 from jonnytpuppet/1.5.0-prep 1.5.x 1.5.0
Morgan Haskel [Tue, 31 Mar 2015 14:23:39 +0000 (10:23 -0400)]
Merge pull request #508 from jonnytpuppet/1.5.0-prep

Updated CHANGELOG and metadata for 1.5.0 release

10 years agoUpdated CHANGELOG and metadata for 1.5.0 release
Jonathan Tripathy [Tue, 31 Mar 2015 10:11:17 +0000 (11:11 +0100)]
Updated CHANGELOG and metadata for 1.5.0 release

10 years agoMerge pull request #507 from jonnytpuppet/test_fix
TP Honey [Mon, 30 Mar 2015 16:11:50 +0000 (17:11 +0100)]
Merge pull request #507 from jonnytpuppet/test_fix

Fix acceptance tests

10 years agoFix acceptance tests
Jonathan Tripathy [Mon, 30 Mar 2015 16:04:14 +0000 (17:04 +0100)]
Fix acceptance tests

10 years agoREADME: Added example of firewallchain for drop policy on input.
Jonathan Davies [Sun, 8 Feb 2015 21:07:21 +0000 (21:07 +0000)]
README: Added example of firewallchain for drop policy on input.

10 years agoREADME.markdown: Added ipv{4,6} to proto list.
Jonathan Davies [Sun, 29 Mar 2015 16:40:44 +0000 (16:40 +0000)]
README.markdown: Added ipv{4,6} to proto list.

10 years agofirewall.rb: Added ipv4 and ipv6 to protocol list.
Jonathan Davies [Sun, 29 Mar 2015 16:39:03 +0000 (16:39 +0000)]
firewall.rb: Added ipv4 and ipv6 to protocol list.

10 years agoMerge pull request #460 from Zlo/MODULES-1636
JT (Jonny) [Thu, 26 Mar 2015 14:49:50 +0000 (14:49 +0000)]
Merge pull request #460 from Zlo/MODULES-1636

MODULES-1636: Add --checksum-fill support.

10 years agoMerge pull request #503 from anodelman/master
JT (Jonny) [Thu, 26 Mar 2015 14:40:32 +0000 (14:40 +0000)]
Merge pull request #503 from anodelman/master

(BKR-147) add Gemfile setting for BEAKER_VERSION for puppet...

10 years agoMerge pull request #500 from petems/MAINT-add_redhat_7_acceptance_test
JT (Jonny) [Thu, 26 Mar 2015 14:35:56 +0000 (14:35 +0000)]
Merge pull request #500 from petems/MAINT-add_redhat_7_acceptance_test

(MAINT) Adds an acceptance test for RHEL 7

10 years agoMerge pull request #502 from cmurphy/rspec-puppet-2
Morgan Haskel [Tue, 24 Mar 2015 19:45:09 +0000 (15:45 -0400)]
Merge pull request #502 from cmurphy/rspec-puppet-2

Testing updates

10 years ago(BKR-147) add Gemfile setting for BEAKER_VERSION for puppet...
Alice Nodelman [Tue, 24 Mar 2015 18:49:20 +0000 (11:49 -0700)]
(BKR-147) add Gemfile setting for BEAKER_VERSION for puppet...

puppetdb, etc

- support for BEAKER_VERSION and BEAKER_RSPEC_VERSION in gemfile

10 years agoUpdate .travis.yml
Colleen Murphy [Mon, 23 Mar 2015 19:22:03 +0000 (12:22 -0700)]
Update .travis.yml

This commit makes the following changes to the test matrix:

- Runs tests on ruby 2.1.5 instead of 2.0.0
- Runs tests on ruby 1.8.7 with puppet 3.x
- Adds an environment to run on an intermediate 3.x puppet version
  instead of latest (specifically 3.4.x)
- Adds an environment to run with the future parser on latest puppet.
  This would affect the test runs for the validate and spec checks.
- Runs the tests on docker

10 years agoKeep testing on puppet 2.7
Colleen Murphy [Mon, 23 Mar 2015 19:05:42 +0000 (12:05 -0700)]
Keep testing on puppet 2.7

The modulesync config repo is dropping universal support for puppet
2.7, but individual repos should still keep support until the next
naturally-occuring major release.

10 years agoEnsure lint fail on warnings
Colleen Murphy [Wed, 18 Mar 2015 21:39:04 +0000 (14:39 -0700)]
Ensure lint fail on warnings

10 years agoUnpin rspec gems and remove unneeded dependencies
Colleen Murphy [Fri, 13 Mar 2015 04:07:45 +0000 (21:07 -0700)]
Unpin rspec gems and remove unneeded dependencies

puppetlabs_spec_helper handles these dependencies for us.

10 years ago(MAINT) Adds an acceptance test for RHEL 7
Peter Souter [Wed, 11 Mar 2015 18:06:43 +0000 (18:06 +0000)]
(MAINT) Adds an acceptance test for RHEL 7

Lets us check the logic around making sure RHEL 7 changing service is working

10 years agoMerge pull request #498 from derdanne/gentoo-compatibility
TP Honey [Wed, 11 Mar 2015 12:13:30 +0000 (12:13 +0000)]
Merge pull request #498 from derdanne/gentoo-compatibility

MODULES-1832 - add Gentoo support

10 years agoMODULES-1636: add iptables --checksum-fill support
Marc Olzheim [Thu, 5 Mar 2015 14:32:35 +0000 (15:32 +0100)]
MODULES-1636: add iptables --checksum-fill support

10 years agoMerge pull request #499 from jonnytpuppet/fix_test
TP Honey [Tue, 10 Mar 2015 13:10:24 +0000 (13:10 +0000)]
Merge pull request #499 from jonnytpuppet/fix_test

Fix iptmodules test

10 years agoFixing iptmodules test
Jonathan Tripathy [Tue, 10 Mar 2015 13:00:14 +0000 (13:00 +0000)]
Fixing iptmodules test

10 years agoMerge pull request #496 from jonnytpuppet/munge_resource_map
Hunter Haugen [Mon, 9 Mar 2015 16:53:48 +0000 (09:53 -0700)]
Merge pull request #496 from jonnytpuppet/munge_resource_map

MODULES-1808 - Implemented code for resource map munging to allow a single ipt module to be used multiple times in a single rule

10 years agoadd Gentoo support
derdanne [Mon, 9 Mar 2015 13:09:00 +0000 (14:09 +0100)]
add Gentoo support

10 years agoMODULES-1808 - Implemented code for resource map munging to allow a single ipt module...
Jonathan Tripathy [Wed, 4 Mar 2015 12:20:00 +0000 (12:20 +0000)]
MODULES-1808 - Implemented code for resource map munging to allow a single ipt module to be used multiple times in a single rule on older versions of iptables

10 years agoMerge pull request #495 from eLobato/patch-1
JT (Jonny) [Tue, 3 Mar 2015 15:53:15 +0000 (15:53 +0000)]
Merge pull request #495 from eLobato/patch-1

Typo in metadata ('iptable')

10 years agoTypo in metadata ('iptable')
Daniel Lobato García [Tue, 3 Mar 2015 11:24:20 +0000 (13:24 +0200)]
Typo in metadata ('iptable')

10 years agoMerge pull request #494 from jonnytpuppet/ipv6-example-readme
TP Honey [Fri, 27 Feb 2015 16:00:04 +0000 (16:00 +0000)]
Merge pull request #494 from jonnytpuppet/ipv6-example-readme

README: Added an example of an IPv6-based rule.

10 years agoREADME: Added an example of an IPv6-based rule.
Jonathan Davies [Sun, 8 Feb 2015 21:19:43 +0000 (21:19 +0000)]
README: Added an example of an IPv6-based rule.

10 years agoMerge pull request #491 from jonnytpuppet/physdev_is_bridged
Morgan Haskel [Sat, 14 Feb 2015 00:01:06 +0000 (16:01 -0800)]
Merge pull request #491 from jonnytpuppet/physdev_is_bridged

Added code for physdev_is_bridged

10 years agoAdded code for physdev_is_bridged
Jonathan Tripathy [Fri, 13 Feb 2015 18:41:29 +0000 (18:41 +0000)]
Added code for physdev_is_bridged

10 years agoMerge pull request #487 from cmurphy/rspec
Hunter Haugen [Wed, 4 Feb 2015 20:03:45 +0000 (12:03 -0800)]
Merge pull request #487 from cmurphy/rspec

Pin rspec gems

10 years agoPin rspec gems
Colleen Murphy [Wed, 4 Feb 2015 16:02:03 +0000 (17:02 +0100)]
Pin rspec gems

10 years agoMerge pull request #485 from mhaskel/merge_1.4.x_to_master
Colleen Murphy [Tue, 27 Jan 2015 19:43:37 +0000 (11:43 -0800)]
Merge pull request #485 from mhaskel/merge_1.4.x_to_master

Merge 1.4.x to master

10 years agoMerge pull request #484 from mhaskel/readme_fix 1.4.x 1.4.0
Lauren [Mon, 26 Jan 2015 21:44:20 +0000 (13:44 -0800)]
Merge pull request #484 from mhaskel/readme_fix

README updates

10 years agoREADME updates
Morgan Haskel [Mon, 26 Jan 2015 21:35:43 +0000 (13:35 -0800)]
README updates

Feature lists for `firewall` providers were out of date, and
`physdev_in` and `physdev_out` were listed as features instead of
parameters.

10 years agoMerge pull request #483 from mhaskel/1.4.0-prep
Travis Fields [Mon, 26 Jan 2015 19:24:21 +0000 (11:24 -0800)]
Merge pull request #483 from mhaskel/1.4.0-prep

1.4.0 prep

10 years ago1.4.0 prep
Morgan Haskel [Mon, 26 Jan 2015 19:22:05 +0000 (11:22 -0800)]
1.4.0 prep

10 years agoMerge pull request #482 from mhaskel/test_typo
Colleen Murphy [Mon, 26 Jan 2015 18:22:05 +0000 (10:22 -0800)]
Merge pull request #482 from mhaskel/test_typo

MODULES-1453 - typo in test

10 years agoMODULES-1453 - typo in test
Morgan Haskel [Mon, 26 Jan 2015 18:14:12 +0000 (10:14 -0800)]
MODULES-1453 - typo in test

10 years agoMerge pull request #481 from mhaskel/typo_fix
Colleen Murphy [Mon, 26 Jan 2015 17:58:14 +0000 (09:58 -0800)]
Merge pull request #481 from mhaskel/typo_fix

This looks like a typo.

10 years agoMerge pull request #477 from mhaskel/MODULES-633
Colleen Murphy [Mon, 26 Jan 2015 17:55:30 +0000 (09:55 -0800)]
Merge pull request #477 from mhaskel/MODULES-633

Modules 633

10 years agoAdd unit test for ip6tables provider against version 1.3.10
Travis Fields [Fri, 23 Jan 2015 21:23:02 +0000 (13:23 -0800)]
Add unit test for ip6tables provider against version 1.3.10

10 years agoMODULES-633 - Fix for ip6tables
Morgan Haskel [Fri, 23 Jan 2015 18:15:01 +0000 (10:15 -0800)]
MODULES-633 - Fix for ip6tables

If the packages for ip6tables aren't installed, the provider will throw
an exception. Fix the provider to check to make sure the variable exists
first, and update params.pp to include the required package for EL6.

10 years agoThis looks like a typo.
Morgan Haskel [Fri, 23 Jan 2015 00:21:28 +0000 (16:21 -0800)]
This looks like a typo.

10 years agoMerge pull request #479 from mhaskel/MODULES-1453
Colleen Murphy [Mon, 26 Jan 2015 17:36:39 +0000 (09:36 -0800)]
Merge pull request #479 from mhaskel/MODULES-1453

MODULES-1453 - overly aggressive gsub

10 years agoMerge pull request #480 from jonnytpuppet/fix_unit_tests
Travis Fields [Sat, 24 Jan 2015 21:19:35 +0000 (13:19 -0800)]
Merge pull request #480 from jonnytpuppet/fix_unit_tests

Fixed unit tests to stub out ip6tables version.

10 years agoFixed unit tests to stub out ip6tables version.
Jonathan Tripathy [Sat, 24 Jan 2015 01:49:55 +0000 (17:49 -0800)]
Fixed unit tests to stub out ip6tables version.

10 years agoMODULES-1453 - overly aggressive gsub
Morgan Haskel [Fri, 23 Jan 2015 23:36:54 +0000 (15:36 -0800)]
MODULES-1453 - overly aggressive gsub

Make sure there's a space after '-A' before gsubbing with '-D'. Was
causing issues with `ensure => absent` and `log_prefix =>
'FW-A-<whatever>'`

10 years agoMerge pull request #478 from cyberious/FirewallChain
Morgan Haskel [Fri, 23 Jan 2015 23:04:25 +0000 (15:04 -0800)]
Merge pull request #478 from cyberious/FirewallChain

Fix issue with firewallchain unit tests

10 years agoFix issue with local testing firewallchain
Travis Fields [Fri, 23 Jan 2015 22:52:01 +0000 (14:52 -0800)]
Fix issue with local testing firewallchain

10 years agoMerge pull request #476 from jonnytpuppet/fix_recent_os
Morgan Haskel [Fri, 23 Jan 2015 21:09:13 +0000 (13:09 -0800)]
Merge pull request #476 from jonnytpuppet/fix_recent_os

Fix recent os

10 years agoMODULES-1029
Jonathan Tripathy [Thu, 22 Jan 2015 23:39:40 +0000 (15:39 -0800)]
MODULES-1029

Fixed issues with Ubuntu 14.10

10 years agofixed package name on Ubuntu 14.10
pcheliniy [Thu, 25 Dec 2014 07:32:50 +0000 (10:32 +0300)]
fixed package name on Ubuntu 14.10

10 years agoMerge pull request #471 from mlehner616/master
Morgan Haskel [Thu, 22 Jan 2015 21:58:28 +0000 (13:58 -0800)]
Merge pull request #471 from mlehner616/master

Fixing regressions for Amazon Linux since RH7 support was added

10 years agoMerge pull request #475 from jonnytpuppet/uid_negation_fix
Hunter Haugen [Thu, 22 Jan 2015 19:50:11 +0000 (11:50 -0800)]
Merge pull request #475 from jonnytpuppet/uid_negation_fix

MODULES-753 further fixes

10 years agoRemoving Amazon from the list OSs that are grouped with Red Hat 7.
Mike Lehner [Fri, 16 Jan 2015 21:21:59 +0000 (13:21 -0800)]
Removing Amazon from the list OSs that are grouped with Red Hat 7.
Red Hat 7 has diverged from the Amazon system architecture and Amazon
uses a different versioning scheme. It's possible Amazon may re-align
with Red Hat 7 in later releases. Additional logic may be required
when that happens.

Description: Adding an exception for Amazon as the conditions for
RH7 were incorrectly catching Amazon because the version YYYY.MM
will always evaluate to true

10 years agoMODULES-753
Jonathan Tripathy [Wed, 21 Jan 2015 23:48:22 +0000 (15:48 -0800)]
MODULES-753

Fixes user adding and removing using either UID or string username.
Tested with both negated and non-negated values and works on all
supported operating systems.

Remote whitespace

10 years agoMerge pull request #474 from jonnytpuppet/uid_negation_fix
Travis Fields [Wed, 21 Jan 2015 19:06:01 +0000 (11:06 -0800)]
Merge pull request #474 from jonnytpuppet/uid_negation_fix

Uid negation fix

10 years agoFix for MODULES-1688
Jonathan Tripathy [Wed, 21 Jan 2015 08:48:12 +0000 (00:48 -0800)]
Fix for MODULES-1688

Re-applying a manifest with an unchanged UID will now not re-apply
the rule unnecessarily.

10 years agoLookup username from uuid
Dan Bode [Thu, 8 Jan 2015 17:06:10 +0000 (18:06 +0100)]
Lookup username from uuid

When using the uid feature of the firewall module,
it did not work with string based usernames as
documented.

The uid propery always synchronized with a message of
<number> does not match <username>.

This code overrides the uid getter method to perform
a check of both the data from the property hash as well
as using that data (assuming it is a uid) to resolve the
username.

While this patch is pretty simple, I have only tested it
on Ubuntu 14.04. I am not sure if it could be problematic
with other versions.

I have not yet written tests b/c I wanted to submit
my proposed fix for discussion while I get those
written.

10 years agoMerge pull request #473 from jonnytpuppet/physdev
Hunter Haugen [Tue, 20 Jan 2015 21:53:04 +0000 (13:53 -0800)]
Merge pull request #473 from jonnytpuppet/physdev

Added support for iptables physdev_in and physdev_out parameters

10 years agoAdded support for seperate physdev-in and physdev-out parameters.
Jonathan Tripathy [Sun, 18 Jan 2015 22:11:58 +0000 (14:11 -0800)]
Added support for seperate physdev-in and physdev-out parameters.

10 years agofix bridge value validation
Aron Parsons [Mon, 29 Sep 2014 00:17:07 +0000 (20:17 -0400)]
fix bridge value validation

10 years agoadd physdev support
Aron Parsons [Fri, 26 Sep 2014 20:58:05 +0000 (16:58 -0400)]
add physdev support

rebased from https://github.com/puppetlabs/puppetlabs-firewall/pull/82

10 years agoMerge pull request #472 from mhaskel/QENG-1678
Travis Fields [Fri, 16 Jan 2015 21:38:11 +0000 (13:38 -0800)]
Merge pull request #472 from mhaskel/QENG-1678

QENG-1678 - Need to stop iptables to install ipset