]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/log
justin.cattle [Tue, 22 Nov 2016 17:34:01 +0000 (17:34 +0000)]
(MODULES-4118) Set dpkg option NoLocking in apt_updates fact
Although the man page for apt-get indicates the --simluate means locking
will be disabled, testing indicates it isn't.
Indeed, regulary collecting facts causes it to clash with the apt_update
Exec occasionally, resulting in failures to lock /var/lib/dpkg
Spefically setting the NoLocking option fixes the issue.
Eric Putnam [Thu, 10 Nov 2016 18:59:08 +0000 (10:59 -0800)]
Merge pull request #636 from puppetlabs/hunner_msync
(MODULES-3704) Update gemfile template to be identical
Hunter Haugen [Wed, 9 Nov 2016 17:58:08 +0000 (09:58 -0800)]
(MODULES-3704) Update gemfile template to be identical
Wilson McCoubrey [Wed, 9 Nov 2016 11:44:40 +0000 (11:44 +0000)]
Merge pull request #635 from lkoranda/fix_string_comparison_error
Avoid string comparison error
Lukas Koranda [Sun, 6 Nov 2016 22:01:42 +0000 (23:01 +0100)]
Avoiding string comparison error
Signed-off-by: Lukas Koranda <lkoranda@redhat.com>
Eric Putnam [Wed, 2 Nov 2016 23:00:43 +0000 (16:00 -0700)]
mocha version update for test hanging issue
Hunter Haugen [Mon, 31 Oct 2016 16:51:36 +0000 (09:51 -0700)]
Merge pull request #633 from puppetlabs/Paula_modulesync
(MODULES-3983) Update parallel_tests for ruby 2.0.0
David Schmitt [Tue, 25 Oct 2016 10:21:35 +0000 (11:21 +0100)]
Merge pull request #631 from wilson208/key-server-timeout-fix
[MODULES-3562] Implement retry for tests which require modules to pull key from keyserver
Paula McMaw [Thu, 20 Oct 2016 08:47:24 +0000 (09:47 +0100)]
(MODULES-3983) Update parallel_tests for ruby 2.0.0
Wilson McCoubrey [Wed, 19 Oct 2016 16:29:36 +0000 (17:29 +0100)]
Implement retry on tests which pull key from a key server which sometimes times out (transient error)
Wilson McCoubrey [Tue, 18 Oct 2016 10:15:38 +0000 (11:15 +0100)]
Fix tests to check for idempotency correctly.
Eric Putnam [Tue, 11 Oct 2016 22:48:40 +0000 (15:48 -0700)]
Merge pull request #629 from puppetlabs/modulesync
Update modulesync_config [
51f469d ]
David Schmitt [Tue, 11 Oct 2016 09:42:45 +0000 (10:42 +0100)]
Merge pull request #628 from cpavanrun/master
Undef default for $notify_update in source.pp results in problem with Puppet 3.7.2
David Schmitt [Mon, 10 Oct 2016 13:18:46 +0000 (14:18 +0100)]
Update modulesync_config [
51f469d ]
Bryan Jen [Mon, 26 Sep 2016 16:25:23 +0000 (17:25 +0100)]
Merge pull request #624 from seffenberg-naspers/fix_apt_key_with_userinfo
apt_key now really works with userinfo for http(s)
C.P.A van Run [Tue, 20 Sep 2016 15:17:00 +0000 (17:17 +0200)]
On Puppet 3.7.2 the undef default for $notify_update will overwrite the default boolean setting for $notify_update in apt::settings resulting in an error 400: "" is not a boolean
Bryan Jen [Tue, 20 Sep 2016 13:35:58 +0000 (14:35 +0100)]
Merge pull request #627 from puppetlabs/release
Release Mergeback
Daniele Sluijters [Mon, 19 Sep 2016 20:15:50 +0000 (22:15 +0200)]
Merge pull request #626 from underscorgan/maint/master/update-gpg-key
(maint) Update the gpg key
Morgan Rhodes [Fri, 16 Sep 2016 00:29:49 +0000 (17:29 -0700)]
(maint) Update the gpg key
David Schmitt [Wed, 14 Sep 2016 14:55:15 +0000 (15:55 +0100)]
Merge pull request #625 from HelenCampbell/rprep
Release prep 2.3.0
Helen Campbell [Tue, 13 Sep 2016 16:44:30 +0000 (17:44 +0100)]
Release prep
Simon Effenberg [Tue, 13 Sep 2016 13:21:15 +0000 (15:21 +0200)]
apt_key now really works with userinfo for http(s)
now http and https sources for apt_key can take a userinfo
as it should be already since #384
```
apt_key { '...':
source => 'https://username:password@myhost.com/mypath/key.gpg'
..
}
```
Daniele Sluijters [Thu, 1 Sep 2016 09:03:59 +0000 (12:03 +0300)]
Merge pull request #616 from ghoneycutt/add_confs
Add ability to specify a hash of apt::conf defines
Garrett Honeycutt [Fri, 15 Jul 2016 18:34:28 +0000 (11:34 -0700)]
Add ability to specify a hash of apt::conf defines
TP Honey [Tue, 30 Aug 2016 09:27:09 +0000 (10:27 +0100)]
Merge pull request #622 from puppetlabs/modulesync
Update modulesync_config [
a3fe424 ]
David Schmitt [Fri, 26 Aug 2016 07:28:58 +0000 (09:28 +0200)]
Update modulesync_config [
a3fe424 ]
Bryan Jen [Thu, 25 Aug 2016 15:33:09 +0000 (08:33 -0700)]
Merge pull request #621 from puppetlabs/modulesync
Update modulesync_config [
0d59329 ]
David Schmitt [Thu, 25 Aug 2016 14:13:18 +0000 (16:13 +0200)]
Update modulesync_config [
0d59329 ]
Helen [Thu, 28 Jul 2016 14:46:41 +0000 (15:46 +0100)]
Merge pull request #618 from puppetlabs/update-modulesync
(MAINT) Update for modulesync_config
72d19f184
David Schmitt [Thu, 28 Jul 2016 09:50:23 +0000 (10:50 +0100)]
(MAINT) Update for modulesync_config
72d19f184
Hunter Haugen [Wed, 27 Jul 2016 22:13:32 +0000 (15:13 -0700)]
Merge pull request #619 from DavidS/fix
Fix syntax error
David Schmitt [Wed, 27 Jul 2016 17:35:58 +0000 (18:35 +0100)]
Fix syntax error
David Schmitt [Wed, 27 Jul 2016 15:54:36 +0000 (16:54 +0100)]
Merge pull request #617 from hunner/strict_error
(MODULES-3414) Limit non-strict parsing to pre-3.5.0 only
Hunter Haugen [Wed, 27 Jul 2016 04:23:12 +0000 (21:23 -0700)]
(MODULES-3414) Limit non-strict parsing to pre-3.5.0 only
Puppet 3.5.0 introduced strict variables and the module handles strict
variables by using the defined() function. This does not work on prior
versions of puppet so we must gate based on that version.
Puppet 4 series has a new setting `strict` that may be set to enforce
strict variables while `strict_variables` remains unset (see PUP-6358)
which causes this conditional to erroniously use non-strict 3.5-era
parsing and fail.
The new conditional corrects the cases such that strict variable
behavior happens on versions 3.5.0 and later.
TP Honey [Fri, 8 Jul 2016 13:44:44 +0000 (14:44 +0100)]
Merge pull request #615 from DavidS/modulesync
(MODULES-3581) modulesync [
067d08a ]
David Schmitt [Fri, 8 Jul 2016 12:34:01 +0000 (13:34 +0100)]
(MODULES-3581) modulesync [
067d08a ]
TP Honey [Thu, 7 Jul 2016 13:36:11 +0000 (14:36 +0100)]
Merge pull request #613 from nicobn/master
Fixed "unless" test condition for ppa repository
Nick Berard [Wed, 6 Jul 2016 00:30:23 +0000 (17:30 -0700)]
Replaced `-s` with `-f` in ppa rspec tests
See
38263ac768349bf0eab56194aa70f4a78fb664af . The previous commit makes the tests fail.
Nick Berard [Sat, 2 Jul 2016 00:31:05 +0000 (17:31 -0700)]
After the repository is added, the ${::apt::sources_list_d}/${sources_list_d_filename} file is created as an empty file.
The unless condition of Exec["add-apt-repository-${name}"] calls test -s, which returns 1 if the file is empty. Because
the file is empty, the unless condition is never true and the repository is added on every execution. This commit
replaces the -s test condition with -f, which is true if the file exists or false otherwise.
David Schmitt [Thu, 30 Jun 2016 12:43:26 +0000 (13:43 +0100)]
Merge pull request #612 from puppetlabs/modulesync
{maint} modulesync
0794b2c
tphoney [Thu, 30 Jun 2016 10:53:46 +0000 (11:53 +0100)]
{maint} modulesync
0794b2c
TP Honey [Tue, 28 Jun 2016 10:41:43 +0000 (11:41 +0100)]
Merge pull request #611 from mattkenn4545/master
Fix TYPO
Matthew Kennedy [Mon, 27 Jun 2016 21:39:43 +0000 (15:39 -0600)]
Fix TYPO
Ubuntu not Ubunto
Bryan Jen [Tue, 7 Jun 2016 16:20:12 +0000 (09:20 -0700)]
Merge pull request #610 from puppetlabs/unused-lsb
apt/params: Remove unused LSB facts
Bryan Jen [Mon, 6 Jun 2016 16:25:07 +0000 (09:25 -0700)]
Merge pull request #609 from hfm/fix-regexp
Fix regexp for $ensure params
Daniele Sluijters [Sun, 5 Jun 2016 10:29:00 +0000 (12:29 +0200)]
apt/params: Remove unused LSB facts
OKUMURA Takahiro [Sat, 4 Jun 2016 18:09:31 +0000 (03:09 +0900)]
Fix regexp for $ensure params
/\Aabsent|present\Z/ match wrong values like 'absentaaa' or 'aaapresent'.
And add tests to the context of 'invalid ensure'.
Hunter Haugen [Tue, 24 May 2016 19:40:20 +0000 (12:40 -0700)]
Merge pull request #608 from DavidS/use-more-pool
Update tests to use the pool servers instead of ubuntu's
David Schmitt [Tue, 24 May 2016 18:59:51 +0000 (19:59 +0100)]
Update tests to use the pool servers instead of ubuntu's
Using the ubuntu keyserver causes stability issues during CI runs,
hopefully the pool servers are less fragile.
TP Honey [Tue, 24 May 2016 13:32:58 +0000 (14:32 +0100)]
Merge pull request #606 from DavidS/use-key-server-pool
Use hkps.pool.sks-keyservers.net instead of pgp.mit.edu
David Schmitt [Tue, 24 May 2016 11:20:33 +0000 (12:20 +0100)]
Remove useless, failing test; cleanup whitespace
David Schmitt [Fri, 20 May 2016 16:54:29 +0000 (17:54 +0100)]
Use hkps.pool.sks-keyservers.net instead of pgp.mit.edu
The MIT server is sometimes unreliable during tests. The pool should
provide a much stabler service.
David Schmitt [Tue, 24 May 2016 10:44:46 +0000 (11:44 +0100)]
Merge pull request #607 from HelenCampbell/XenialTestFix
Removal of a breaking test for Xenial
Helen Campbell [Mon, 23 May 2016 16:02:26 +0000 (17:02 +0100)]
Removal of a breaking test for Xenial
TP Honey [Tue, 3 May 2016 10:36:27 +0000 (11:36 +0100)]
Merge pull request #605 from imphil/master
Install software-properties-common for xenial
Philipp Wagner [Fri, 29 Apr 2016 12:20:53 +0000 (14:20 +0200)]
Install software-properties-common for xenial
Instead of adding every newer release of Ubuntu, let's assume that the
package name that is used today will be used in the future, until the
next change is necessary.
TP Honey [Thu, 28 Apr 2016 10:40:52 +0000 (11:40 +0100)]
Merge pull request #604 from tdb/fix_version_check
Fix version check on 16.04.
Tim Bishop [Wed, 27 Apr 2016 15:26:25 +0000 (16:26 +0100)]
Fix version check on 16.04.
The old test obviously broke on 16.04. Switch to using versioncmp
since it does the right thing for us.
David Schmitt [Tue, 19 Apr 2016 13:22:38 +0000 (14:22 +0100)]
Merge pull request #602 from DG-i/master
apt::setting expects priority to be an integer, set defaults accordingly
Mathias Merscher [Tue, 19 Apr 2016 10:28:45 +0000 (12:28 +0200)]
apt::setting expects priority to be an integer, set defaults accordingly
Signed-off-by: Mathias Merscher <Mathias.Merscher@dg-i.net>
Greg Hardy [Tue, 19 Apr 2016 10:03:12 +0000 (11:03 +0100)]
Merge pull request #600 from puppetlabs/update-msync
Update to newest modulesync_configs [
9ca280f ]
David Schmitt [Wed, 13 Apr 2016 19:49:37 +0000 (20:49 +0100)]
Update to newest modulesync_configs [
9ca280f ]
TP Honey [Tue, 12 Apr 2016 09:46:39 +0000 (10:46 +0100)]
Merge pull request #596 from danielhoherd/master
Expose notify_update to apt::source
TP Honey [Thu, 7 Apr 2016 18:09:05 +0000 (19:09 +0100)]
Merge pull request #599 from DavidS/fix-strict-var-testing
Fix STRICT_VARIABLE testing
David Schmitt [Thu, 7 Apr 2016 17:33:55 +0000 (18:33 +0100)]
(maint) clean up key_compat_specs
David Schmitt [Thu, 7 Apr 2016 17:31:58 +0000 (18:31 +0100)]
(maint) Update ke_compat_spec to run under STRICT_VARIABLES
Hunter Haugen [Thu, 7 Apr 2016 17:13:46 +0000 (10:13 -0700)]
Merge pull request #581 from robinelfrink/master
Make apt_updates facts use /usr/bin/apt-get.
Daniel Hoherd [Fri, 18 Mar 2016 17:08:30 +0000 (10:08 -0700)]
Exposing notify_update to apt::source
Daniele Sluijters [Thu, 17 Mar 2016 09:53:42 +0000 (10:53 +0100)]
Merge pull request #595 from danielhoherd/master
Typo: missing colon
Daniel Hoherd [Thu, 17 Mar 2016 00:58:08 +0000 (17:58 -0700)]
Typo: missing colon
Hunter Haugen [Mon, 29 Feb 2016 21:52:36 +0000 (13:52 -0800)]
Merge pull request #593 from puppetlabs/2.2.x
Mergeback 2.2.x
David Schmitt [Thu, 25 Feb 2016 13:45:59 +0000 (13:45 +0000)]
Merge pull request #592 from HelenCampbell/2.2.2
Prep for 2.2.2 Release
Helen Campbell [Thu, 25 Feb 2016 12:50:12 +0000 (12:50 +0000)]
Prep for 2.2.2 Release
Helen [Wed, 17 Feb 2016 12:13:16 +0000 (12:13 +0000)]
Merge pull request #590 from DavidS/debian-8-support
Update metadata to note Debian 8 support
David Schmitt [Wed, 17 Feb 2016 11:52:31 +0000 (11:52 +0000)]
Update metadata to note Debian 8 support
TP Honey [Tue, 16 Feb 2016 17:04:03 +0000 (17:04 +0000)]
Merge pull request #589 from DavidS/fm-4046-update-msync
(FM-4046) Update to current msync configs [
006831f ]
David Schmitt [Tue, 16 Feb 2016 15:59:57 +0000 (15:59 +0000)]
(FM-4046) Update to current msync configs [
006831f ]
This moves all copyright statements to the NOTICE file in accordance with the ASFs guidelines on applying the Apache-2.0 license.
Robin Elfrink [Fri, 12 Feb 2016 22:21:28 +0000 (23:21 +0100)]
Make apt_updates facts use /usr/bin/apt-get.
/usr/lib/update-notifier/apt-check is not available on all systems,
but /usr/bin/apt-get is.
Bryan Jen [Thu, 4 Feb 2016 19:29:15 +0000 (12:29 -0700)]
Merge pull request #582 from imphil/master
Look for correct sources.list.d file for apt::ppa
Philipp Wagner [Wed, 3 Feb 2016 16:13:46 +0000 (17:13 +0100)]
Look for correct sources.list.d file for apt::ppa
In Ubuntu 15.10 the path of the apt sources file, which is generated by
apt-add-repository, changed to include the distid. This breaks apt::ppa
idempotency, since it does not recognize the repository is already
added.
Reported on puppet-users as well:
https://groups.google.com/forum/#!topic/puppet-users/YzeMyZYUo98
Philipp Wagner [Wed, 3 Feb 2016 16:09:40 +0000 (17:09 +0100)]
Ensure PPAs in tests have valid form
"man apt-add-repository" notes: "REPOSITORY can be either a line that
can be added directly to sources.list(5), in the form ppa:<user>/<ppa-name>
for adding Personal Package Archives".
Fix the tests to always use the format ppa:<user>/<ppa-name> when adding
PPAs.
Daniele Sluijters [Tue, 2 Feb 2016 19:04:23 +0000 (20:04 +0100)]
Merge pull request #588 from werekraken/modules2873
MODULES-2873 - Avoid multiple package resource declarations
matt.cover [Tue, 2 Feb 2016 15:54:43 +0000 (08:54 -0700)]
MODULES-2873 - Avoid duplicate package resources when package_manage => true
Helen [Fri, 29 Jan 2016 19:25:06 +0000 (19:25 +0000)]
Merge pull request #587 from jbondpdx/master
MODULES-2941: add example to README
jbondpdx [Fri, 29 Jan 2016 19:11:46 +0000 (11:11 -0800)]
MODULES-2941: added more info about replacing sources.list
jbondpdx [Thu, 28 Jan 2016 19:45:35 +0000 (11:45 -0800)]
MODULES-2941: add example to README
Helen [Wed, 27 Jan 2016 16:16:25 +0000 (16:16 +0000)]
Merge pull request #585 from DavidS/fm-4049-update-msync
(FM-4049) update to modulesync_configs
David Schmitt [Mon, 25 Jan 2016 15:42:27 +0000 (15:42 +0000)]
(FM-4049) Update to current msync configs [
2c99161 ]
JT (Jonny) [Tue, 19 Jan 2016 16:09:39 +0000 (16:09 +0000)]
Merge pull request #583 from tdb/fix_ppa_pluses
Handle PPA names that contain a plus character.
Tim Bishop [Mon, 18 Jan 2016 21:47:32 +0000 (21:47 +0000)]
Handle PPA names that contain a plus character.
It looks like add-apt-repository changes pluses to underscores when
creating the sources.list.d file. So the name it creates doesn't match
what Puppet expects, and the resource keeps applying on every Puppet
run.
This works around that problem.
Bryan Jen [Wed, 6 Jan 2016 21:38:31 +0000 (14:38 -0700)]
Merge pull request #572 from twc-openstack/master-tempfile-race-condition
Fix apt_key tempfile race condition
Bryan Jen [Tue, 15 Dec 2015 17:25:01 +0000 (10:25 -0700)]
Merge pull request #578 from phervieux/15.10
Add ubuntu 15.10 support
TP Honey [Mon, 14 Dec 2015 11:27:00 +0000 (11:27 +0000)]
Merge pull request #577 from syseleven/pp-2587
fix whitespace in source.list
Andreas Mauf [Mon, 14 Dec 2015 09:20:40 +0000 (10:20 +0100)]
MODULES-2889 - remove unneeded whitespace in source.list template
Daniele Sluijters [Thu, 10 Dec 2015 22:55:07 +0000 (23:55 +0100)]
Merge pull request #575 from ryayon/master
MODULES-2861: run stages limitation added to the documentation.
Rudy YAYON [Thu, 10 Dec 2015 10:22:22 +0000 (11:22 +0100)]
MODULES-2861: run stages limitation added to the documentation
David Schmitt [Tue, 8 Dec 2015 15:09:12 +0000 (15:09 +0000)]
Merge pull request #576 from puppetlabs/2.2.x
Mergeback 2.2.x
Bryan Jen [Tue, 24 Nov 2015 19:04:29 +0000 (12:04 -0700)]
Merge pull request #573 from HelenCampbell/release2.2.1
Release 2.2.1
Helen Campbell [Mon, 23 Nov 2015 12:31:23 +0000 (12:31 +0000)]
Release 2.2.1
Clayton O'Neill [Wed, 11 Nov 2015 20:11:24 +0000 (20:11 +0000)]
Fix apt_key tempfile race condition
The Ruby Tempfile class has a finalizer that removes the file when the
GC runs. It's not predictible when the GC will run, so you have to
ensure that the instance of the class stays in scope for as long as you
need it.
Unfortunately the tempfile method is returning just the filename of the
temporary file, which means it goes out of scope when that method
returns. This allows the GC to reap it at any time after return.
In both CI and production environments we've seen this race fail,
causing apt-key add to fail a small (2-3%) amount of the time.
This changes the tempfile and source_to_file methods to return the
underlying Tempfile object, pushing it up into the caller's scope. Both
of the callers immediately use the object to get its filename and then
open the file, eliminating the race.
Tested this by adding 'GC.start; sleep(1)' immediately before the
command is run, to give the GC plenty of time to remove the tempfile if
it was going to.