review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/log

(MODULES-8648) - Fix for failures on SLES 11
Failures caused by the deprecation of `state` on SLES 11 SP4.
Warning has been placed in readme and test's have been updated to use `ctstate` instead.

commit | commitdiff | tree

David Swan [Mon, 18 Feb 2019 13:27:30 +0000 (13:27 +0000)]

(bugfix) - Readding code to set correct seluser for CentOS/RHEL 5.x
Code was removed by mistake during removal of Scientific 5 support

commit | commitdiff | tree

david22swan [Tue, 5 Feb 2019 11:03:56 +0000 (11:03 +0000)]

Merge pull request #815 from mateusz-gozdek-sociomantic/comments-espace-sequences

(MODULES-8584) Handle multiple escaped quotes in comments properly

commit | commitdiff | tree

Mateusz Gozdek [Fri, 1 Feb 2019 22:48:35 +0000 (23:48 +0100)]

(MODULES-8584) Handle multiple escaped quotes in comments properly

commit | commitdiff | tree

Paula Muir [Fri, 1 Feb 2019 16:36:39 +0000 (16:36 +0000)]

Merge pull request #814 from puppetlabs/release

Release mergeback 1.15.1

commit | commitdiff | tree

Helen [Fri, 1 Feb 2019 14:16:11 +0000 (14:16 +0000)]

Merge pull request #813 from pmcmaw/update_chagelog

(maint) - Update changelog to 1.15.1

commit | commitdiff | tree

Paula Muir [Fri, 1 Feb 2019 13:49:09 +0000 (13:49 +0000)]

(maint) - Updating CHANEGLOG version

commit | commitdiff | tree

Helen [Fri, 1 Feb 2019 13:42:09 +0000 (13:42 +0000)]

Merge pull request #812 from pmcmaw/decrease_version

(maint) - Change release version to 1.15.1

commit | commitdiff | tree

Paula Muir [Fri, 1 Feb 2019 12:03:43 +0000 (12:03 +0000)]

(maint) - Change release version to 1.15.1

commit | commitdiff | tree

david22swan [Fri, 1 Feb 2019 10:27:15 +0000 (10:27 +0000)]

Merge pull request #811 from pmcmaw/MODULES-8567

(MODULES-8567) - Release Prep 1.16.0

commit | commitdiff | tree

Paula Muir [Fri, 1 Feb 2019 09:46:59 +0000 (09:46 +0000)]

(MODULES-8567) - Release Prep 1.16.0

commit | commitdiff | tree

Eimhin Laverty [Thu, 31 Jan 2019 10:16:07 +0000 (10:16 +0000)]

Merge pull request #810 from puppetlabs/pdksync_pdksync_1.9.0-0-g7281db5

pdksync - pdksync_1.9.0-0-g7281db5

commit | commitdiff | tree

lionce [Thu, 31 Jan 2019 09:21:50 +0000 (11:21 +0200)]

pdksync_1.9.0-0-g7281db5

commit | commitdiff | tree

Paula Muir [Wed, 30 Jan 2019 16:02:36 +0000 (16:02 +0000)]

Merge pull request #809 from puppetlabs/clairecadman-patch-2

(DOC-3056) Remove mention of rules ordering

commit | commitdiff | tree

clairecadman [Wed, 30 Jan 2019 14:40:43 +0000 (14:40 +0000)]

(DOC-3056) Remove mention of rules ordering

Remove any reference that suggests the ordering number used for rules isn't restricted to the section the rule is in. This is misleading and can lead to mis-configured firewall rules.

See https://tickets.puppetlabs.com/browse/DOC-3056 for more information.

commit | commitdiff | tree

lionce [Tue, 29 Jan 2019 13:24:14 +0000 (15:24 +0200)]

Merge pull request #808 from david22swan/FM-7712

(FM-7712) - Remove Gentoo 1.0 testing/support for Firewall module

commit | commitdiff | tree

David Swan [Mon, 28 Jan 2019 15:20:53 +0000 (15:20 +0000)]

(FM-7712) - Remove Gentoo 1.0 testing/support for Firewall module

commit | commitdiff | tree

Eimhin Laverty [Wed, 23 Jan 2019 15:39:53 +0000 (15:39 +0000)]

Merge pull request #804 from alexharv074/alexharvey/further_changes_for_MODULES-2119

(MODULES-8360) Fix IPv6 bug relating to Bugzilla 1015

commit | commitdiff | tree

Alex Harvey [Sat, 12 Jan 2019 14:12:41 +0000 (01:12 +1100)]

(MODULES-8360) Fix relating to Bugzilla 1015

A fix for Bugzilla #1015 was added in
680738164865a01f554d1e1037c8d8724e39a720. However, it appears that the
bug description at https://bugzilla.netfilter.org/show_bug.cgi?id=1015
is not quite accurate, and the -p all hack is required sometimes, but
not always. I don't know exactly when it is or isn't required.

This patch changes the logic to try both.

commit | commitdiff | tree

Alex Harvey [Wed, 23 Jan 2019 11:05:50 +0000 (22:05 +1100)]

Merge branch 'master' of https://github.com/puppetlabs/puppetlabs-firewall

commit | commitdiff | tree

david22swan [Fri, 18 Jan 2019 14:18:05 +0000 (14:18 +0000)]

Merge pull request #807 from puppetlabs/release

(MODULES-8498) - Release 1.15.0

commit | commitdiff | tree

Paula Muir [Fri, 18 Jan 2019 11:04:50 +0000 (11:04 +0000)]

Merge pull request #806 from david22swan/ReleasePrep

(MODULES-8498) - 1.15.0 Release Prep

commit | commitdiff | tree

David Swan [Fri, 18 Jan 2019 09:27:01 +0000 (09:27 +0000)]

(MODULES-8498) - 1.15.0 Release Preperation

commit | commitdiff | tree

Helen [Mon, 14 Jan 2019 15:29:55 +0000 (15:29 +0000)]

Merge pull request #803 from puppetlabs/pdksync_pdksync_heads/master-0-g6814a87

pdksync - pdksync_heads/master-0-g6814a87

commit | commitdiff | tree

Alex Harvey [Sat, 12 Jan 2019 08:03:50 +0000 (19:03 +1100)]

(MODULES-2119) further tweaking to that logic

A fix for Bugzilla #1015 was added in
680738164865a01f554d1e1037c8d8724e39a720. However, it appears that the
bug description at https://bugzilla.netfilter.org/show_bug.cgi?id=1015
is not quite accurate, and the -p all hack is required sometimes, but
not always. I don't know exactly when it is or isn't required.

This patch changes the logic to try both.

commit | commitdiff | tree

David Swan [Thu, 10 Jan 2019 15:27:28 +0000 (15:27 +0000)]

pdksync_heads/master-0-g6814a87

commit | commitdiff | tree

davidmalloncares [Thu, 3 Jan 2019 16:02:57 +0000 (16:02 +0000)]

Merge pull request #802 from puppetlabs/pdksync_pdksync_heads/master-0-g9c815ea

pdksync - pdksync_heads/master-0-g9c815ea

commit | commitdiff | tree

David Swan [Thu, 3 Jan 2019 14:33:11 +0000 (14:33 +0000)]

pdksync_heads/master-0-g9c815ea

commit | commitdiff | tree

Eimhin Laverty [Thu, 20 Dec 2018 10:50:37 +0000 (10:50 +0000)]

Merge pull request #801 from puppetlabs/pdksync_FM-7655

pdksync - (FM-7655) Fix rubygems-update for ruby < 2.3

commit | commitdiff | tree

tphoney [Thu, 20 Dec 2018 10:09:31 +0000 (10:09 +0000)]

(FM-7655) Fix rubygems-update for ruby < 2.3

commit | commitdiff | tree

Paula Muir [Mon, 17 Dec 2018 15:13:00 +0000 (15:13 +0000)]

Merge pull request #799 from puppetlabs/pdksync_pdksync_heads/master-0-gbf720df

pdksync - pdksync_heads/master-0-gbf720df

commit | commitdiff | tree

Eimhin Laverty [Mon, 17 Dec 2018 11:30:24 +0000 (11:30 +0000)]

pdksync_heads/master-0-gbf720df

commit | commitdiff | tree

TP Honey [Fri, 14 Dec 2018 14:39:17 +0000 (14:39 +0000)]

Merge pull request #798 from eimlav/modules-8143

(MODULES-8143) - Add SLES 15 support

commit | commitdiff | tree

Eimhin Laverty [Thu, 13 Dec 2018 11:06:33 +0000 (11:06 +0000)]

(MODULES-8143) - Add SLES 15 support

commit | commitdiff | tree

Helen [Thu, 13 Dec 2018 10:07:34 +0000 (10:07 +0000)]

Merge pull request #796 from eimlav/modules-6340

(MODULES-6340) - Address failure when name begins with 9XXX

commit | commitdiff | tree

Eimhin Laverty [Wed, 12 Dec 2018 14:19:13 +0000 (14:19 +0000)]

commit | commitdiff | tree

Eimhin Laverty [Wed, 12 Dec 2018 14:15:59 +0000 (14:15 +0000)]

Modifed error message to be more clear

commit | commitdiff | tree

Eimhin Laverty [Tue, 11 Dec 2018 15:19:10 +0000 (15:19 +0000)]

(MODULES-6340) - Address failure when name begins with 9XXX

commit | commitdiff | tree

Helen [Thu, 29 Nov 2018 15:23:09 +0000 (15:23 +0000)]

Merge pull request #794 from mwhahaha/rhel8

Add nftables wrapper support for RHEL8

commit | commitdiff | tree

Alex Schultz [Mon, 26 Nov 2018 21:41:40 +0000 (14:41 -0700)]

Add nftables wrapper support for RHEL8

In RHEL8, iptables is replaced with nftables under the covers. In order
to allow for the firewall module to continue to function, this change
updates the redhat firewall configuration to pull in the nftables
packages.

https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8-beta/html/8.0_beta_release_notes/new-features#networking_2

commit | commitdiff | tree

david22swan [Mon, 26 Nov 2018 17:03:10 +0000 (17:03 +0000)]

Merge pull request #790 from mateusz-gozdek-sociomantic/MODULES-8214-multiple-src-dst-type

(MODULES-8214) Handle src_type and dst_type as array

commit | commitdiff | tree

Helen [Mon, 26 Nov 2018 14:33:50 +0000 (14:33 +0000)]

Merge pull request #793 from erik-frontify/fix_amazon_linux2_support

Amazon linux 2 changed its major version to 2 with the last update...

commit | commitdiff | tree

Mateusz Gozdek [Tue, 6 Nov 2018 00:16:35 +0000 (01:16 +0100)]

(MODULES-8214) Handle src_type and dst_type as array

So it can be parsed when specified mutliple times, as well as being configured.

commit | commitdiff | tree

Erik Geiger [Fri, 16 Nov 2018 18:02:35 +0000 (19:02 +0100)]

Amazon linux 2 changed its major version to 2 with the last update...

commit | commitdiff | tree

david22swan [Fri, 9 Nov 2018 17:45:34 +0000 (17:45 +0000)]

Merge pull request #789 from mateusz-gozdek-sociomantic/MODULES-7990-iptables-multiple-comments

(MODULES-7990) Merge multiple comments into one while parsing rules

commit | commitdiff | tree

Mateusz Gozdek [Mon, 5 Nov 2018 16:55:22 +0000 (17:55 +0100)]

Add test for comments without quotes

commit | commitdiff | tree

Mateusz Gozdek [Mon, 5 Nov 2018 10:53:06 +0000 (11:53 +0100)]

(MODULES-7990) Merge multiple comments into one while parsing rules

As iptables/iptables-save accepts multiple '-m comment --comment' parameters,
we should find and merge them all together to avoid generating warnings.

Since puppet resource allows you to create only single comment, this should only
affect rules, which are not managed by puppet.

commit | commitdiff | tree

Paula Muir [Wed, 7 Nov 2018 13:11:35 +0000 (13:11 +0000)]

Merge pull request #792 from puppetlabs/pdksync_pdksync_heads/master-0-gabccfb1

pdksync - pdksync_heads/master-0-gabccfb1

commit | commitdiff | tree

David Swan [Wed, 7 Nov 2018 10:21:51 +0000 (10:21 +0000)]

pdksync_heads/master-0-gabccfb1

commit | commitdiff | tree

david22swan [Wed, 7 Nov 2018 09:48:37 +0000 (09:48 +0000)]

Merge pull request #771 from syseleven/feature/add-bytecode-property

(MODULES-7681) Add support for bytecode property

commit | commitdiff | tree

Matthias Baur [Mon, 20 Aug 2018 11:38:46 +0000 (13:38 +0200)]

(MODULES-7681) Add support for bytecode property

This commit adds support for Berkeley Paket Filter iptables rules.

commit | commitdiff | tree

david22swan [Tue, 6 Nov 2018 12:00:47 +0000 (12:00 +0000)]

Merge pull request #791 from GeorgeCox/interface_regex_update

Changed regex for iniface and outiface to allow '@' in interface names

commit | commitdiff | tree

George Cox [Tue, 6 Nov 2018 09:50:10 +0000 (09:50 +0000)]

Changed regex for iniface and outiface to allow '@' in interface names

commit | commitdiff | tree

TP Honey [Mon, 29 Oct 2018 10:34:52 +0000 (10:34 +0000)]

Merge pull request #788 from cestith/patch-1

add -g flag handling in ip6tables.rb provider

commit | commitdiff | tree

Christopher E. Stith [Wed, 24 Oct 2018 00:52:27 +0000 (19:52 -0500)]

add -g flag handling in ip6tables.rb provider

In lib/puppet/provider/firewall/ip6tables.rb there is no goto: entry for the -g flag in @resource_map which leads to errors for rules using that feature.

lib/puppet/type/firewall.rb already handles this flag. It's a one-line change to recognize it. The right rules then get into the chains in my testing.

commit | commitdiff | tree

TP Honey [Tue, 23 Oct 2018 16:47:10 +0000 (17:47 +0100)]

Merge pull request #787 from pmcmaw/FM-7516

(FM-7516) - Removing Gentoo from metadata

commit | commitdiff | tree

Paula Muir [Tue, 23 Oct 2018 15:44:15 +0000 (16:44 +0100)]

(FM-7516) - Removing Gentoo from metadata

Gentoo is an entry in the metadata, removing this entry as we do not
have our test infrastructure set up to run acceptance test on this
OS. Removing from the metadata means that we will not support this OS,
however no code changes are being made therefore this OS may still be
compatible.

commit | commitdiff | tree

Paula Muir [Thu, 27 Sep 2018 16:25:23 +0000 (17:25 +0100)]

Merge pull request #785 from puppetlabs/release

(MODULES-7878) - 1.14.0 Merge Back

commit | commitdiff | tree

Eimhin Laverty [Thu, 27 Sep 2018 13:06:46 +0000 (14:06 +0100)]

Merge pull request #784 from puppetlabs/pdksync_puppet_6_release_prep

pdksync - Module Release Prep 1.14.0

commit | commitdiff | tree

Paula Muir [Thu, 27 Sep 2018 12:19:06 +0000 (13:19 +0100)]

commit | commitdiff | tree

Paula Muir [Thu, 27 Sep 2018 09:43:14 +0000 (10:43 +0100)]

Merge pull request #782 from puppetlabs/pdksync_MODULES-6805

pdksync - (MODULES-6805) metadata.json shows support for puppet 6

commit | commitdiff | tree

david22swan [Tue, 25 Sep 2018 08:25:26 +0000 (09:25 +0100)]

Merge pull request #783 from puppetlabs/pdksync_FM-7392_pdk_update

pdksync - (FM-7392) - Puppet 6 Testing Changes

commit | commitdiff | tree

Paula Muir [Mon, 24 Sep 2018 16:02:25 +0000 (17:02 +0100)]

(FM-7392) - Puppet 6 Testing Changes

commit | commitdiff | tree

tphoney [Thu, 20 Sep 2018 15:33:42 +0000 (16:33 +0100)]

(MODULES-6805) metadata.json shows support for puppet 6

commit | commitdiff | tree

TP Honey [Thu, 20 Sep 2018 15:19:29 +0000 (16:19 +0100)]

Merge pull request #780 from pmcmaw/ghcg_prep

(FM-7399) - Prepare for changelog generator

commit | commitdiff | tree

Paula Muir [Thu, 20 Sep 2018 14:44:41 +0000 (15:44 +0100)]

(FM-7399) - Prepare for changelog generator

commit | commitdiff | tree

Paula Muir [Wed, 19 Sep 2018 16:20:38 +0000 (17:20 +0100)]

Merge pull request #779 from puppetlabs/release

1.13.0 Mergeback

commit | commitdiff | tree

Paula Muir [Tue, 18 Sep 2018 13:35:49 +0000 (14:35 +0100)]

Merge pull request #778 from puppetlabs/clairecadman-patch-1

(MODULES-7804) - Minor README edits

commit | commitdiff | tree

clairecadman [Tue, 18 Sep 2018 10:33:14 +0000 (11:33 +0100)]

(firewall) Minor readme edits

The commit makes minor updates to the README

commit | commitdiff | tree

Paula Muir [Mon, 17 Sep 2018 14:28:01 +0000 (15:28 +0100)]

(MODULES-7803) - Release Prep 1.13.0

commit | commitdiff | tree

Eimhin Laverty [Fri, 31 Aug 2018 13:42:40 +0000 (14:42 +0100)]

Merge pull request #776 from puppetlabs/pdksync_pdksync-beaker4

pdksync - (MODULES-7658) use beaker4 in puppet-module-gems

commit | commitdiff | tree

tphoney [Thu, 30 Aug 2018 16:07:42 +0000 (17:07 +0100)]

(MODULES-7658) use beaker4 in puppet-module-gems

commit | commitdiff | tree

david22swan [Fri, 24 Aug 2018 08:07:43 +0000 (09:07 +0100)]

Merge pull request #775 from puppetlabs/pdksync_bumping_puppet_version

pdksync - (MODULES-7705) - Bumping stdlib dependency from < 5.0.0 to < 6.0.0

commit | commitdiff | tree

Paula Muir [Thu, 23 Aug 2018 17:18:59 +0000 (18:18 +0100)]

(MODULES-7705) - Bumping stdlib requirement to 6.0.0

commit | commitdiff | tree

Helen [Wed, 22 Aug 2018 15:54:46 +0000 (16:54 +0100)]

Merge pull request #773 from puppetlabs/pdksync_1.7.0-0-g57412ed

pdksync - Update using 1.7.0

commit | commitdiff | tree

Paula Muir [Wed, 22 Aug 2018 15:28:21 +0000 (16:28 +0100)]

commit | commitdiff | tree

Paula Muir [Wed, 22 Aug 2018 13:31:14 +0000 (14:31 +0100)]

pdksync_1.7.0-0-g57412ed

commit | commitdiff | tree

david22swan [Tue, 21 Aug 2018 15:15:46 +0000 (16:15 +0100)]

Merge pull request #772 from puppetlabs/pdksync_pdksync-beaker3

pdksync - (MODULES-7658) use beaker3 in puppet-module-gems

commit | commitdiff | tree

tphoney [Tue, 21 Aug 2018 14:27:02 +0000 (15:27 +0100)]

(MODULES-7658) use beaker3 in puppet-module-gems

commit | commitdiff | tree

Helen [Thu, 9 Aug 2018 11:01:58 +0000 (12:01 +0100)]

Merge pull request #768 from erik-frontify/amazon_linux2_support

Add support for Amazon Linux 2

commit | commitdiff | tree

Paula Muir [Thu, 9 Aug 2018 10:41:20 +0000 (11:41 +0100)]

Merge pull request #769 from eimlav/update-limitations

(MODULES-7627) - Update README Limitations section

commit | commitdiff | tree

Eimhin Laverty [Thu, 9 Aug 2018 10:03:22 +0000 (11:03 +0100)]

(MODULES-7627) - Update README Limitations section

commit | commitdiff | tree

Erik Geiger [Fri, 3 Aug 2018 14:41:29 +0000 (16:41 +0200)]

Add support for Amazon Linux 2

setting service provider explicit to systemd as pupppets default does
not work for Amazon Linux 2

commit | commitdiff | tree

Paula Muir [Mon, 30 Jul 2018 16:12:45 +0000 (17:12 +0100)]

Merge pull request #767 from david22swan/FM-7232

(FM-7232) - Update firewall to support Ubuntu 18.04

commit | commitdiff | tree

David Swan [Mon, 30 Jul 2018 15:01:59 +0000 (16:01 +0100)]

(FM-7232) - Update firewall to support Ubuntu 18.04

commit | commitdiff | tree

Helen [Thu, 21 Jun 2018 13:34:09 +0000 (14:34 +0100)]

Merge pull request #765 from david22swan/FM-7044

[FM-7044] Addition of Debian 9 support to firewall

commit | commitdiff | tree

david22swan [Wed, 20 Jun 2018 09:10:27 +0000 (10:10 +0100)]

Merge pull request #766 from alexharv074/corrections_to_readme

\bCorrections to readme

commit | commitdiff | tree

Alex Harvey [Sun, 17 Jun 2018 06:55:09 +0000 (16:55 +1000)]

(docs) Add .gitattributes

So that the language is correctly displayed as "Puppet" on GitHub.

commit | commitdiff | tree

Alex Harvey [Sun, 17 Jun 2018 06:50:28 +0000 (16:50 +1000)]

(docs) Markdown syntax updates in README.markdown

Also corrections to how to run the tests.