]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/log
puppet-modules/puppetlabs-firewall.git
10 years agoFixed firewalld package issue
Martin Mágr [Fri, 24 Oct 2014 07:37:01 +0000 (09:37 +0200)]
Fixed firewalld package issue

Firewalld package cannot be uninstalled, because other packages might be dependent
on it. This patch makes just firewalld service to stop and be disabled.

For more info please check: https://bugzilla.redhat.com/show_bug.cgi?id=1148399

10 years agoMerge pull request #423 from mhaskel/metadata_fix
Hunter Haugen [Wed, 22 Oct 2014 17:44:38 +0000 (10:44 -0700)]
Merge pull request #423 from mhaskel/metadata_fix

Invalid metadata

10 years agoInvalid metadata
Morgan Haskel [Wed, 22 Oct 2014 17:43:27 +0000 (10:43 -0700)]
Invalid metadata

10 years agoMerge pull request #422 from hunner/fix_instances
Morgan Haskel [Mon, 20 Oct 2014 21:01:29 +0000 (14:01 -0700)]
Merge pull request #422 from hunner/fix_instances

(MODULES-41) Change source for ip6tables provider

10 years ago(MODULES-41) Change source for ip6tables provider
Hunter Haugen [Mon, 20 Oct 2014 20:33:36 +0000 (13:33 -0700)]
(MODULES-41) Change source for ip6tables provider

This will allow purging of ipv6 rules

10 years agoMerge pull request #420 from mhaskel/metadata_update
Hunter Haugen [Mon, 20 Oct 2014 16:56:47 +0000 (09:56 -0700)]
Merge pull request #420 from mhaskel/metadata_update

Update to support PE3.x

10 years agoMerge pull request #419 from mhaskel/future_parser
Hunter Haugen [Mon, 20 Oct 2014 16:56:39 +0000 (09:56 -0700)]
Merge pull request #419 from mhaskel/future_parser

Fix for future parser

10 years agoUpdate to support PE3.x
Morgan Haskel [Sun, 19 Oct 2014 00:22:03 +0000 (17:22 -0700)]
Update to support PE3.x

10 years agoFix for future parser
Morgan Haskel [Sun, 19 Oct 2014 00:08:41 +0000 (17:08 -0700)]
Fix for future parser

I'm not entirely sure why this was having issues with the future parser,
but there was something funny with the pp function.

10 years agoMerge pull request #418 from mhaskel/remove_oel5
Hunter Haugen [Fri, 17 Oct 2014 21:22:22 +0000 (14:22 -0700)]
Merge pull request #418 from mhaskel/remove_oel5

Doesn't actually support OEL5

10 years agoDoesn't actually support OEL5
Morgan Haskel [Fri, 17 Oct 2014 21:15:37 +0000 (14:15 -0700)]
Doesn't actually support OEL5

There are weird interactions between the version of iptables and the
kernel on OEL5.

10 years agoMerge pull request #417 from jbondpdx/fix-readme
Morgan Haskel [Fri, 17 Oct 2014 17:26:21 +0000 (10:26 -0700)]
Merge pull request #417 from jbondpdx/fix-readme

DOCUMENT-75: cstate param in my_fw::pre example should be state

10 years agoDOCUMENT-75: cstate param in my_fw::pre example should be state
jbondpdx [Fri, 17 Oct 2014 17:20:39 +0000 (10:20 -0700)]
DOCUMENT-75: cstate param in my_fw::pre example should be state

Fixed!

10 years agoMerge pull request #416 from mhaskel/selinux_fixes
Hunter Haugen [Thu, 16 Oct 2014 23:38:29 +0000 (16:38 -0700)]
Merge pull request #416 from mhaskel/selinux_fixes

Don't do the idempotency checks with selinux

10 years agoDon't do the idempotency checks with selinux
Morgan Haskel [Thu, 16 Oct 2014 23:21:47 +0000 (16:21 -0700)]
Don't do the idempotency checks with selinux

Eventually the types should use autobefore, but until then, just don't
do the idempotency checks.

10 years agoMerge pull request #414 from mhaskel/spec_helper_fix
Hunter Haugen [Tue, 14 Oct 2014 18:56:42 +0000 (11:56 -0700)]
Merge pull request #414 from mhaskel/spec_helper_fix

Use puppet() so the module install works better

10 years agoUse puppet() so the module install works better
Morgan Haskel [Tue, 14 Oct 2014 18:53:23 +0000 (11:53 -0700)]
Use puppet() so the module install works better

This was failing on SLES10 due to path issues.

10 years agoMerge pull request #413 from mhaskel/rhel5_fixes
Travis Fields [Tue, 14 Oct 2014 03:02:26 +0000 (20:02 -0700)]
Merge pull request #413 from mhaskel/rhel5_fixes

Fix for RHEL5

10 years agoFix for RHEL5
Morgan Haskel [Mon, 13 Oct 2014 23:54:01 +0000 (16:54 -0700)]
Fix for RHEL5

iptables-save output is in a different order for RHEL5 systems.  Make
the tests check that ordering.

10 years agoMerge pull request #412 from mhaskel/resource_cmd_spec_fix
Colleen Murphy [Thu, 9 Oct 2014 23:16:56 +0000 (16:16 -0700)]
Merge pull request #412 from mhaskel/resource_cmd_spec_fix

Fix for resource_cmd_spec

10 years agoFix for resource_cmd_spec
Morgan Haskel [Thu, 9 Oct 2014 23:03:16 +0000 (19:03 -0400)]
Fix for resource_cmd_spec

Was checking for empty stderr in a few places, and also setting an
iptables rule that doesn't work on deb7 and ubuntu trusty.

10 years agoMerge pull request #410 from justinstoller/bug/master/FM-1923-fixup-hieraconf
Morgan Haskel [Mon, 29 Sep 2014 19:18:51 +0000 (14:18 -0500)]
Merge pull request #410 from justinstoller/bug/master/FM-1923-fixup-hieraconf

(FM-1923) Fix spec_helper_acceptance to run against PE

10 years ago(FM-1923) Fix spec_helper_acceptance to run against PE
Justin Stoller [Mon, 29 Sep 2014 19:16:10 +0000 (12:16 -0700)]
(FM-1923) Fix spec_helper_acceptance to run against PE

10 years agoMerge pull request #407 from hunner/redirect_validate
Travis Fields [Wed, 17 Sep 2014 16:05:24 +0000 (09:05 -0700)]
Merge pull request #407 from hunner/redirect_validate

(MODULES-1086) toports is not reqired with jump == REDIRECT

10 years ago(MODULES-1086) toports is not reqired with jump == REDIRECT
Hunter Haugen [Mon, 15 Sep 2014 23:20:09 +0000 (16:20 -0700)]
(MODULES-1086) toports is not reqired with jump == REDIRECT

From the man page for REDIRECT and --to-ports: "This specifies a
destination port or range of ports to use: without this, the destination
port is never altered."

10 years agoMerge pull request #406 from cyberious/master
Hunter Haugen [Wed, 10 Sep 2014 18:50:04 +0000 (11:50 -0700)]
Merge pull request #406 from cyberious/master

Remove puppet_module_install in favor of copy_module_to

10 years agoRemove puppet_module_install in favor of copy_module_to
Travis Fields [Wed, 10 Sep 2014 18:47:53 +0000 (11:47 -0700)]
Remove puppet_module_install in favor of copy_module_to

10 years agoMerge pull request #404 from mhaskel/spec_updates
Ashley Penney [Thu, 28 Aug 2014 21:39:52 +0000 (17:39 -0400)]
Merge pull request #404 from mhaskel/spec_updates

Update the spec_helper for consistency.

10 years agoUpdate the spec_helper for consistency.
Morgan Haskel [Thu, 28 Aug 2014 15:29:20 +0000 (11:29 -0400)]
Update the spec_helper for consistency.

10 years agoMerge pull request #374 from starstable/master
Hunter Haugen [Tue, 26 Aug 2014 19:35:56 +0000 (12:35 -0700)]
Merge pull request #374 from starstable/master

Fixed bug which arbitrarily limited iniface and outiface parameters

10 years agoMerge pull request #403 from rra/bug/iptables-persistent
Hunter Haugen [Mon, 25 Aug 2014 19:53:55 +0000 (12:53 -0700)]
Merge pull request #403 from rra/bug/iptables-persistent

Support netfilter-persistent for later versions

10 years agoSupport netfilter-persistent for later versions
Russ Allbery [Sun, 24 Aug 2014 06:09:54 +0000 (23:09 -0700)]
Support netfilter-persistent for later versions

iptables-persistent 1.0 and later is now a plugin module for
netfilter-persistent and does not have its own init script or
service file.  Instead, the save action must be run on the
netfilter-persistent service.

10 years agoMerge pull request #402 from hunner/bugfix_statprob
Hunter Haugen [Thu, 21 Aug 2014 19:51:04 +0000 (12:51 -0700)]
Merge pull request #402 from hunner/bugfix_statprob

Bugfix stat_prob -> stat_probability

10 years agoBugfix stat_prob -> stat_probability
Hunter Haugen [Thu, 21 Aug 2014 19:50:01 +0000 (12:50 -0700)]
Bugfix stat_prob -> stat_probability

I also aligned arrows and sorted the resource map

10 years agoMerge pull request #400 from hunner/feature/statistic_module_support
Hunter Haugen [Thu, 21 Aug 2014 00:33:54 +0000 (17:33 -0700)]
Merge pull request #400 from hunner/feature/statistic_module_support

Feature/statistic module support

10 years agoUpdate docs, remove feature, and rename property
Hunter Haugen [Wed, 20 Aug 2014 23:39:59 +0000 (16:39 -0700)]
Update docs, remove feature, and rename property

10 years agoAdded unit tests
Daniel Selans [Thu, 12 Jun 2014 02:57:04 +0000 (22:57 -0400)]
Added unit tests

10 years agoAdded support for statistic module
Daniel Selans [Wed, 11 Jun 2014 03:27:59 +0000 (23:27 -0400)]
Added support for statistic module

10 years agoMerge pull request #397 from jbondpdx/firewall-readme
Hunter Haugen [Tue, 19 Aug 2014 19:34:57 +0000 (12:34 -0700)]
Merge pull request #397 from jbondpdx/firewall-readme

Firewall readme

10 years agoDocs: code formatting edits on readme
jbondpdx [Fri, 15 Aug 2014 15:49:20 +0000 (08:49 -0700)]
Docs: code formatting edits on readme

Responding to comments from earlier PR to change formatting for some snippets of puppet code.

10 years agoDocs: Reference information added to firewall module readme
jbondpdx [Wed, 13 Aug 2014 18:30:37 +0000 (11:30 -0700)]
Docs: Reference information added to firewall module readme

I have added reference information to the firewall module readme. I also fixed errors introduced during squashing in my last commit.

10 years agoDocs: Reference info added to firewall
jbondpdx [Wed, 30 Jul 2014 22:34:41 +0000 (15:34 -0700)]
Docs: Reference info added to firewall

Added reference information to the firewall module readme.

10 years agoMerge pull request #395 from hunner/remove_print
Ashley Penney [Fri, 1 Aug 2014 21:56:07 +0000 (17:56 -0400)]
Merge pull request #395 from hunner/remove_print

Remove stray print

10 years agoRemove stray print
Hunter Haugen [Fri, 1 Aug 2014 21:52:17 +0000 (14:52 -0700)]
Remove stray print

10 years agoMerge pull request #394 from hunner/fix_negate
Ashley Penney [Fri, 1 Aug 2014 21:39:32 +0000 (17:39 -0400)]
Merge pull request #394 from hunner/fix_negate

(MODULES-450) Enable rule inversion

10 years ago(MODULES-450) Enable rule inversion
Hunter Haugen [Wed, 30 Jul 2014 23:32:31 +0000 (16:32 -0700)]
(MODULES-450) Enable rule inversion

iptables has many rule arguments that may be inverted by prefixing with
an exclamation mark. This commit enables inversion for most every
property currently in the firewall provider that supports inversion by
prefixing the value with a bang+space.

Array elements must have all array elements prefixed with a bang+space
otherwise a warning will be raised, as it would look confusing to negate
a single value and then have iptables negate all of them.

10 years agoMerge pull request #388 from thias/cbt
Morgan Haskel [Thu, 31 Jul 2014 17:13:35 +0000 (13:13 -0400)]
Merge pull request #388 from thias/cbt

Add cbt protocol, to be able to mitigate some DDoS attacks

10 years agoMerge pull request #337 from damjanek/master
Hunter Haugen [Sat, 26 Jul 2014 20:46:34 +0000 (13:46 -0700)]
Merge pull request #337 from damjanek/master

Add support for mac address source rules pt2

10 years agoMaking it mergable:
Damian Szeluga [Fri, 21 Mar 2014 14:12:02 +0000 (15:12 +0100)]
Making it mergable:

 * Missing type definition
 * Fix failing test
 * Acceptance testing + fix parameter match
 * Renamed mac_addr to mac_source

10 years agoAdd support for mac address source rules
Jeff '2 bits' Bachtel [Wed, 5 Mar 2014 17:32:02 +0000 (12:32 -0500)]
Add support for mac address source rules

This is necessary to parse rules generated on OpenStack Havana + Neutron + OpenVSwitch

10 years agoMerge pull request #393 from hunner/develop
Hunter Haugen [Wed, 23 Jul 2014 00:38:14 +0000 (17:38 -0700)]
Merge pull request #393 from hunner/develop

Improve support for EL7 and other related fixes

10 years agoImprove support for EL7 and other related fixes
Trey Dockendorf [Mon, 21 Jul 2014 18:55:24 +0000 (13:55 -0500)]
Improve support for EL7 and other related fixes

* Support RHEL7 by removing firewalld before installing iptables-services
* Autorequire Package[iptables-services] for Firewall and Firewallchain types
* Ensure /etc/sysconfig/iptables exists before starting Service[iptables]

10 years agoMerge branch '1.2.x'
Hunter Haugen [Wed, 23 Jul 2014 00:06:48 +0000 (17:06 -0700)]
Merge branch '1.2.x'

10 years agoMerge pull request #390 from dnaeon/master
Hunter Haugen [Tue, 22 Jul 2014 16:38:10 +0000 (09:38 -0700)]
Merge pull request #390 from dnaeon/master

Typo fix

10 years agoTypo fix
Marin Atanasov Nikolov [Thu, 17 Jul 2014 14:41:35 +0000 (17:41 +0300)]
Typo fix

10 years agoMerge pull request #389 from hunner/fix_metadata
Travis Fields [Mon, 14 Jul 2014 22:50:24 +0000 (15:50 -0700)]
Merge pull request #389 from hunner/fix_metadata

Update metadata to match checksum

10 years agoUpdate metadata to match checksum
Hunter Haugen [Mon, 14 Jul 2014 22:49:07 +0000 (15:49 -0700)]
Update metadata to match checksum

10 years agoAdd cbt protocol, to be able to mitigate some DDoS attacks
Matthias Saou [Fri, 11 Jul 2014 09:02:26 +0000 (11:02 +0200)]
Add cbt protocol, to be able to mitigate some DDoS attacks

10 years agoMerge branch '1.2.x' into master
Hunter Haugen [Wed, 9 Jul 2014 20:46:32 +0000 (13:46 -0700)]
Merge branch '1.2.x' into master

Conflicts:
CHANGELOG.md
Gemfile
Modulefile
metadata.json

10 years agoMerge pull request #386 from hunner/release_1.1.3 1.1.x 1.1.3
Ashley Penney [Tue, 8 Jul 2014 21:54:52 +0000 (17:54 -0400)]
Merge pull request #386 from hunner/release_1.1.3

Release 1.1.3

10 years agoRelease 1.1.3
Hunter Haugen [Tue, 8 Jul 2014 21:52:52 +0000 (14:52 -0700)]
Release 1.1.3

Summary
This is a supported release with test coverage enhancements.

Bugfixes
- Confine to supported kernels

10 years agoMerge pull request #385 from cmurphy/master
Ashley Penney [Thu, 3 Jul 2014 21:43:13 +0000 (17:43 -0400)]
Merge pull request #385 from cmurphy/master

Add validate and lint tasks to travis script

10 years agoAdd validate and lint tasks to travis script
Colleen Murphy [Thu, 3 Jul 2014 16:53:41 +0000 (09:53 -0700)]
Add validate and lint tasks to travis script

10 years agoMerge pull request #384 from cmurphy/master
Hunter Haugen [Mon, 30 Jun 2014 18:03:41 +0000 (11:03 -0700)]
Merge pull request #384 from cmurphy/master

Synchronize .travis.yml

10 years agoUpdate Gemfile for .travis.yml defaults
Colleen Murphy [Mon, 30 Jun 2014 17:57:51 +0000 (10:57 -0700)]
Update Gemfile for .travis.yml defaults

10 years agoSynchronize .travis.yml
Colleen Murphy [Fri, 27 Jun 2014 17:54:51 +0000 (10:54 -0700)]
Synchronize .travis.yml

10 years agoUpdate .sync.yml to support new .travis.yml configs
Colleen Murphy [Fri, 27 Jun 2014 16:31:49 +0000 (09:31 -0700)]
Update .sync.yml to support new .travis.yml configs

10 years agoMerge pull request #382 from cmurphy/master
Morgan Haskel [Thu, 26 Jun 2014 18:02:05 +0000 (14:02 -0400)]
Merge pull request #382 from cmurphy/master

Start synchronizing module files

10 years agoSync files
Colleen Murphy [Thu, 26 Jun 2014 00:23:19 +0000 (17:23 -0700)]
Sync files

10 years agoAdd configuration file for modulesync
Colleen Murphy [Thu, 26 Jun 2014 00:00:02 +0000 (17:00 -0700)]
Add configuration file for modulesync

https://github.com/puppetlabs/modulesync

10 years agoMerge pull request #379 from hunner/failure
Morgan Haskel [Fri, 13 Jun 2014 23:45:52 +0000 (19:45 -0400)]
Merge pull request #379 from hunner/failure

Add testing for unsupported platforms

10 years agoAdd testing for unsupported platforms
Hunter Haugen [Fri, 13 Jun 2014 23:29:37 +0000 (16:29 -0700)]
Add testing for unsupported platforms

10 years agoMerge branch 'MFredette'
Hunter Haugen [Wed, 11 Jun 2014 18:04:58 +0000 (11:04 -0700)]
Merge branch 'MFredette'

10 years agoUpdate README.markdown
MFredette [Thu, 5 Jun 2014 21:09:58 +0000 (14:09 -0700)]
Update README.markdown

10 years agoCopy edited version.
Michelle Fredette [Thu, 5 Jun 2014 21:04:05 +0000 (14:04 -0700)]
Copy edited version.

10 years agoFormat fixes to firewall readme.
Michelle Fredette [Thu, 5 Jun 2014 01:04:45 +0000 (18:04 -0700)]
Format fixes to firewall readme.

10 years agoUpdates to Firewall Readme for review.
Michelle Fredette [Thu, 5 Jun 2014 00:25:32 +0000 (17:25 -0700)]
Updates to Firewall Readme for review.

10 years agoMerge pull request #377 from mhaskel/beaker-rspec-pinning
Hunter Haugen [Tue, 10 Jun 2014 16:10:49 +0000 (09:10 -0700)]
Merge pull request #377 from mhaskel/beaker-rspec-pinning

Beaker rspec pinning

10 years agoRequire beaker-rspec >= 2.2
Morgan Haskel [Tue, 10 Jun 2014 15:32:00 +0000 (11:32 -0400)]
Require beaker-rspec >= 2.2

10 years agoMerge pull request #376 from apenney/pin-rspec
Travis Fields [Mon, 9 Jun 2014 15:54:11 +0000 (08:54 -0700)]
Merge pull request #376 from apenney/pin-rspec

Pin rspec

10 years agoPin rspec to 2.x.
Ashley Penney [Mon, 9 Jun 2014 15:31:16 +0000 (11:31 -0400)]
Pin rspec to 2.x.

10 years ago(type) Fixed bug which arbitrarily limited which chains iniface and outiface paramete...
Daniel Kuehn [Fri, 6 Jun 2014 15:25:14 +0000 (17:25 +0200)]
(type) Fixed bug which arbitrarily limited which chains iniface and outiface parameters are set in rules, they are allowed in all chains

10 years agoMerge pull request #369 from apenney/120-prepare-release 1.1.2
Hunter Haugen [Wed, 4 Jun 2014 18:02:17 +0000 (11:02 -0700)]
Merge pull request #369 from apenney/120-prepare-release

120 prepare release

10 years agoUpdate versions.
Ashley Penney [Wed, 4 Jun 2014 17:52:25 +0000 (13:52 -0400)]
Update versions.

10 years agoUpdate to support PE3.2 and PE3.3.
Ashley Penney [Wed, 4 Jun 2014 17:45:19 +0000 (13:45 -0400)]
Update to support PE3.2 and PE3.3.

10 years agoUpdate the CHANGELOG.
Ashley Penney [Wed, 4 Jun 2014 17:43:15 +0000 (13:43 -0400)]
Update the CHANGELOG.

10 years agoMerge pull request #368 from mhaskel/fix-test-issues
Hunter Haugen [Tue, 3 Jun 2014 19:06:02 +0000 (12:06 -0700)]
Merge pull request #368 from mhaskel/fix-test-issues

Fix test issues

10 years agoDon't check stderr
Morgan Haskel [Tue, 3 Jun 2014 19:04:52 +0000 (15:04 -0400)]
Don't check stderr

10 years agoMerge pull request #366 from lwh/fix/master/modules-11
Morgan Haskel [Mon, 2 Jun 2014 15:35:16 +0000 (11:35 -0400)]
Merge pull request #366 from lwh/fix/master/modules-11

(doc) Fix small typos in the README (MODULES-11)

10 years ago(doc) Fix small typos in the README (MODULES-11)
Luke Hollins [Mon, 2 Jun 2014 15:10:35 +0000 (11:10 -0400)]
(doc) Fix small typos in the README (MODULES-11)

For https://tickets.puppetlabs.com/browse/MODULES-11

Double "the" fixed and undo a typo fix that reverted this commit:
https://github.com/puppetlabs/puppetlabs-firewall/commit/13457a4ade45f4a46d64ceb4da9d2b9582c39fcd

10 years agoMerge pull request #364 from mhaskel/unsupported_checks
Hunter Haugen [Thu, 29 May 2014 19:46:33 +0000 (12:46 -0700)]
Merge pull request #364 from mhaskel/unsupported_checks

Unsupported checks

10 years agoFixes for UNSUPPORTED_PLATFORMS and tests.
Morgan Haskel [Thu, 29 May 2014 19:42:48 +0000 (15:42 -0400)]
Fixes for UNSUPPORTED_PLATFORMS and tests.

Tests didn't have checks to only run on supported platforms. There
was no test for unsupported platforms. Added UNSUPPORTED_PLATFORMS
to spec_helper_acceptance.

10 years agoMerge pull request #363 from hunner/fix_policy_ipsec_options
Hunter Haugen [Wed, 28 May 2014 19:05:13 +0000 (12:05 -0700)]
Merge pull request #363 from hunner/fix_policy_ipsec_options

(MODULES-796) Fix policy ipsec options

10 years agoAdd tests and fix docs/whitespace
Hunter Haugen [Wed, 28 May 2014 19:03:29 +0000 (12:03 -0700)]
Add tests and fix docs/whitespace

10 years agofixes MODULES-796
Thomas Sturm [Thu, 1 May 2014 08:20:36 +0000 (10:20 +0200)]
fixes MODULES-796
Cheat by adding quotes around policy ipsec and all following options
belonging to ipsec. Otherwise the line cannot be parsed correctly.
The list of options is taken from [1] and the output ordering was
experimentally verified with iptables-v1.4.21 on Ubuntu 14.04.

[1] http://ipset.netfilter.org/iptables-extensions.man.html

10 years agoMerge pull request #361 from mhaskel/1.2.0-prep
Ashley Penney [Wed, 21 May 2014 23:35:59 +0000 (16:35 -0700)]
Merge pull request #361 from mhaskel/1.2.0-prep

1.2.0 prep

10 years agoUpdate PE version requirement.
Morgan Haskel [Wed, 21 May 2014 23:33:49 +0000 (19:33 -0400)]
Update PE version requirement.

11 years agoMerge pull request #360 from apenney/111-release 1.1.1
Hunter Haugen [Fri, 16 May 2014 18:14:32 +0000 (14:14 -0400)]
Merge pull request #360 from apenney/111-release

Prepare a 1.1.1 release.

11 years agoPrepare a 1.1.1 release.
Ashley Penney [Fri, 16 May 2014 18:06:55 +0000 (14:06 -0400)]
Prepare a 1.1.1 release.

11 years agoMerge branch 'master' into 1.2.x
Ashley Penney [Thu, 15 May 2014 19:57:07 +0000 (15:57 -0400)]
Merge branch 'master' into 1.2.x