Assaf Muller [Wed, 11 Mar 2015 15:45:00 +0000 (11:45 -0400)]
Fix pylint issue with type VS isinstance in event_observers
New version of pylint started complaining about the unpythonic
usage of type. This patch fixes the issue. Another patch will
propose to pin the version of pylint.
Ihar Hrachyshka [Tue, 10 Mar 2015 21:57:58 +0000 (22:57 +0100)]
Added oslo.log dependency
This is needed for vendor libraries out of tree to start switching their
code to oslo.log logging interface. Hopefully, they will be able to run
against neutron core using neutron.openstack.common.log while executing
oslo_log.log.* calls.
This is needed to avoid a case when agent sees network
removal notifications on startup. Processing of those notifications
may overlap with processing of active networks and DHCP might be
disabled on some of active networks as a result.
Elena Ezhova [Thu, 19 Feb 2015 10:34:17 +0000 (13:34 +0300)]
Prevent calling waitall() inside a GreenPool's greenthread
When neutron-server is running with several api workers
sending it a termination signal (SIGTERM, SIGHUP or SIGINT)
leads to waitall() being called inside a GreenPool's greenthread.
The reason is that a wsgi server is started in a green thread
from the same green pool that is passed to the server itself
to be used for spawning client green threads.
To avoid it, it is reasonable to use different pools for spawning
a wsgi server and for its internal usage.
This is also the case for metadata agent running with several
metadata workers.
Improve performance of _get_security_group_member_ips
Use set operations instead of using list.
Currently complexity of the method is O(n^2) where n is
amount of ips (amount of VMs in the network).
When amount of VM is big (large L2 domain), this method
can significantly load the controller.
Reduce method complexity to O(n) on average.
Akihiro Motoki [Sat, 7 Feb 2015 13:22:14 +0000 (22:22 +0900)]
NEC plugin code split
- Removes main codes and unit tests of NEC plugin
- Add plugin-specific requirements.txt to the plugin dir.
- Move config to the plugin top dir
- Remove references of networking_nec from config module
because it may prevent config guide generator.
- agent command can be moved to neutron/cmd/eventlet
if some consensus has been made.
Closes-Bug: #1419396
Related to blueprint core-vendor-decomposition
Brian Haley [Thu, 19 Feb 2015 19:50:43 +0000 (14:50 -0500)]
Change linux/ip_lib code to better handle address families
The code in linux/ip_lib doesn't handle IP address families
similarly amongst all its APIs. It also doesn't consistently
handle how it passes options and arguments along to /sbin/ip
So in the spirit of re-factoring, let's try and fix that:
1. Have the code determine the IP address family from its
arguments, given that it was passed an IP address.
2. Always follow an (options, command, arguments) style.
Options need a '-' prepended and go first, followed by the
command, and finally by any arguments.
3. In cases where we can't infer an address family but need
one it is now required (e.g. listing routes).
I also cleaned-up the IpRule class to fall in line with the
other classes.
Sukhdev [Mon, 9 Mar 2015 21:45:21 +0000 (14:45 -0700)]
In Arista ML2 delete tenant without any resources
If there are no resources associated with a
tenant, it was deleted from Arista DB in
delete_xxx_precommit() methods. The sync
mechanism used to make sure that back-end is in
sync with DB.
Lately, the sync mechanism has been enhanced to
support scaled deployment. Therefore, the
delete_tenat() call now needs to be invoked from
delete_xxx_postcommit() methods instead of
delete_xxx_precommit() methods. Additionally,
when the tenant is removed from the DB, it is
removed from the back-end as well. This removes
the dependancy on the sync mechanism to take
care of this.
[Note: Sync will still do it, but, this way it
gets done right away]
Michael Smith [Tue, 24 Feb 2015 00:21:54 +0000 (16:21 -0800)]
FIP debug messages
The experimental DVR test job is seeing intermittent failures
related to FIPs. This patch will add debug log messages to the
l3-agent to help debug the failures. These logs messages will
indicate when fips have been added and the fip statuses before
they are sent to the plugin.
Mike Kolesnik [Tue, 3 Feb 2015 08:58:47 +0000 (10:58 +0200)]
Add proccess monitor to keepalived
Adding process monitor to keepalived code, so that keepalived processes
launched by the L3 agent will get monitored the same as other processes
launched by the L3 agent.
Old monitoring code was removed since it's not needed anymore.
Fix wrong log output in neutron/neutron/agent/linux/dhcp.py
When all subnets are turning off dhcp and killing the process,
this wrong log output "Killing dhcpmasq for network ..." occurs.
It should be "Killing dnsmasq for network ..."
Maru Newby [Sat, 21 Feb 2015 00:15:12 +0000 (00:15 +0000)]
Add script to copy neutron api tests from tempest
This change adds a script to automate the copying of api tests from
tempest in the style of oslo_incubator. The target path will be
neutron/tests/tempest and no manual modifications should be made to
this path until such time as neutron api test development is frozen in
tempest and development can proceed in the neutron tree. Until that
occurs, a policy of manual once-daily synchronization is suggested.
The target path includes the name 'tempest' as a clear indication that
this is not part of neutron, and that once development is allowed to
proceed, its contents should be rewritten and removed until there is
nothing left.
So long as the tests exist in both the tempest and neutron trees,
testing effort will be duplicated. The larger goal is to have the
tests in question removed from tempest as per the qa guidelines [1],
so this should be temporary.
Xu Han Peng [Fri, 6 Mar 2015 10:30:30 +0000 (18:30 +0800)]
Fix DB2 upgrade problem for Remove Hyper-V plugin
The recently added upgrade script to remove hyperv
neutron plugin breaks upgrade on DB2. This fix solves
this problme by using "1" instead of "true" in sql
when db2 is engine.
Kevin Benton [Sun, 1 Mar 2015 20:25:29 +0000 (12:25 -0800)]
Big Switch Networks code split
This commit removes all of the Big Switch Networks
code from the tree and replaces it with the import
statements required to pull in the entry points
from the new 'bsnstacklib' module.
All patches for BSN code should now be submitted
to the stackforge/networking-bigswitch project.
vijaychundury [Tue, 3 Mar 2015 13:02:02 +0000 (13:02 +0000)]
Replace IPv4 and IPv6 default addresses with constants
At various places in Neutron we are using IPv4 and IPv6 default addresses in
numeric format. This patch replaces them with constants to ensure consistency.
Update the table to reflect the fact that code decomposition
for this plugin has occured.
This patch also fixes supported extensions by vmware_nsx as
the plugin providing advanced services has been removed, and
the new plugin providing those does not yet have CI.
Change-Id: I4567ec206ac03b23d5355cd53b80544f05daef7c
Related to blueprint core-vendor-decompisition
Kyle Mestery [Thu, 5 Mar 2015 17:34:05 +0000 (17:34 +0000)]
Move Neutron Policy pages into the tree
The information from the NeutronPolicies wiki page [1] is useful. But
having it in a static wiki is less so. Moving this into the Neutron
documentation in-tree will allow for an easier maintenance of this
information.
ronak [Wed, 25 Feb 2015 22:55:18 +0000 (14:55 -0800)]
Adding DB model changes for Nuage Plugin post decomposition
Due to decomposition of plugin work initiated during K release,
nuage plugin have gone through much changes without them being
incorporated upstream. But as per the decomp spec guideline,
we need to keep migration and model definition upstream.
So adding new schema along with migration script into K release.
Add ability to run pylint check on modified files only
Change c0aa0b fused pylint with the checks done with the pep8 testenv.
This has the drawback of increasing the execution time of the command
'tox -epep8' fourfold.
This change introduces the ability to execute the pylint check on just
the list of python files affected by a specific patch. For instance,
this can be done with the following command:
tox -epep8 HEAD~1
A kind reminder is added, so that folks who end up noticing the spike of
time execution when they run tox -epep8 without posargs, can learn how
they can get their precious minutes back.
Change 17cae2c added tests that pass regardless of whatever code they
are supposed to validate. If one asked for a bad example of how not to
write/review test, change 17cae2c would be one of it.
This patch remove all the business logic pertaining to the VMware
plugin. The following modules are left in openstack/neutron:
- plugin-specific API extension declarations
- database models (and a module with constants they use)
- integration module pointing to the external repository
vijaychundury [Wed, 4 Mar 2015 13:41:14 +0000 (13:41 +0000)]
Remove references to 0.0.0.0/0 in iptable rules
Iptables removes 0.0.0.0/0 as rule source (-s) because any packet
matches the filter. Based on the discussion in the patch [1],
references to 0.0.0.0/0 are removed in the current patch.
Code Review / openstack-build / neutron-build.git / log