]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/log
Christos Papageorgiou [Thu, 24 Feb 2022 11:59:00 +0000 (13:59 +0200)]
Use fact() function for all os.distro.* facts
* On Puppet 6 facter 3.x requires lsb-release to resolve os.distro.* facts. Using $facts hash cause errors like "Evaluation Error: Operator '[]' is not applicable to an Undef Value." because os.distro is undefined causing the catalog to fail. Use fact() to identify Undef facts and throw an error to the user.
Signed-off-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
Kevin Reeuwijk [Tue, 22 Feb 2022 14:42:49 +0000 (15:42 +0100)]
Clarify this Task runs apt-get, not apt
Romain Tartière [Mon, 21 Feb 2022 14:19:25 +0000 (04:19 -1000)]
(maint) Fix resource ordering when apt-transport-https is needed (#1015)
Adds a dependency to ensure apt-transport-https is installed when the
repositories are updated.
Hugh Esco [Wed, 9 Feb 2022 11:57:55 +0000 (06:57 -0500)]
enable allow-insecure for apt::source defined types, includes new tests, documentation (#1014)
Co-authored-by: Lukas Audzevicius <97180854+LukasAud@users.noreply.github.com>
Lukas Audzevicius [Mon, 7 Feb 2022 11:26:31 +0000 (11:26 +0000)]
Merge pull request #1013 from mpdude/patch-3
Omit empty options in source.list template to fix MODULES-11174
Lukas Audzevicius [Mon, 7 Feb 2022 11:25:55 +0000 (11:25 +0000)]
Merge pull request #1012 from mpdude/patch-1
Replace `arm64` for `aarch64` in `::apt::source`
Lukas Audzevicius [Thu, 3 Feb 2022 17:01:07 +0000 (17:01 +0000)]
Merge pull request #1011 from Conzar/ppa-ubuntu-fix
Fixed reading conditions for gpg file for Ubuntu versions 21.04 and later.
Matthias Pigulla [Sun, 9 Jan 2022 22:51:55 +0000 (23:51 +0100)]
Omit empty options in source.list template to fix MODULES-11174
Empty `[name= ...]` options in a soures list lead to Apt parsing errors.
This change skips such empty options, resolving https://tickets.puppetlabs.com/browse/MODULES-11174.
Matthias Pigulla [Sun, 9 Jan 2022 22:33:03 +0000 (23:33 +0100)]
Replace `arm64` for `aarch64` in `::apt::source`
Michael Speth [Sun, 9 Jan 2022 09:32:01 +0000 (22:32 +1300)]
Fixed gpg file for Ubuntu versions 21.04 and later.
As of Ubuntu 21.04, Canotical has again changed the filename of the gpg files going back to dashes
instead of using underscores.
daianamezdrea [Mon, 18 Oct 2021 12:18:48 +0000 (15:18 +0300)]
Merge pull request #1010 from LTangaF/remove_frequency_collector
(MODULES-10763) Remove frequency collector
LTangaF [Thu, 7 Oct 2021 16:56:16 +0000 (16:56 +0000)]
(MODULES-10763) Remove frequency collector
The case logic in apt::update adequately covers the 'always' case and
the collector causes issues in acceptance testing.
daianamezdrea [Mon, 4 Oct 2021 10:12:30 +0000 (13:12 +0300)]
Merge pull request #1009 from puppetlabs/release-prep
Release prep v8.3.0
GitHub Action [Mon, 4 Oct 2021 07:41:06 +0000 (07:41 +0000)]
Release prep v8.3.0
Adrian Iurca [Thu, 23 Sep 2021 09:03:59 +0000 (12:03 +0300)]
Merge pull request #1008 from puppetlabs/pdksync_IAC-1598/main/remove_debian_8_support
pdksync - (IAC-1598) - Remove Support for Debian 8
daianamezdrea [Mon, 20 Sep 2021 11:51:07 +0000 (14:51 +0300)]
Merge pull request #1007 from maturnbull/proxy_per_host
(MODULES-11173) Add per-host overrides for apt::proxy
David Swan [Wed, 15 Sep 2021 12:43:34 +0000 (13:43 +0100)]
(IAC-1598) - Remove Support for Debian 8
daianamezdrea [Mon, 13 Sep 2021 09:38:57 +0000 (12:38 +0300)]
Merge pull request #999 from smortex/debian-frontend
(maint) Set DEBIAN_FRONTEND=noninteractive on upgrade
Romain Tartière [Mon, 6 Sep 2021 21:31:41 +0000 (11:31 -1000)]
(main) Do not prompt on configuration file update
When updating configuration file, apt by default prompt the user for the
action to perform. Since we are running in a non-interactive context,
skip these prompts:
* `--force-confdef` ensure the configuration file is replaced by a
newer version in the package if the previous package default
configuration file was not modified;
* `--force-confold` keep the configuration file as it is if it has
been modified compared to the one shipped in the previous version of the
package.
maturnbull [Mon, 23 Aug 2021 19:54:20 +0000 (20:54 +0100)]
(MODULES-11173) Add per-host overrides for apt::proxy
Add support for optional apt::proxy::perhost array to configure bypass (DIRECT) or alternative proxy for specific repository hosts.
david22swan [Wed, 25 Aug 2021 13:39:17 +0000 (14:39 +0100)]
Merge pull request #1006 from puppetlabs/release-prep
Release prep v8.2.0
daianamezdrea [Wed, 25 Aug 2021 13:25:59 +0000 (16:25 +0300)]
Merge pull request #1004 from puppetlabs/maint/main/remove_since_tag
(maint) - Correct since tag
GitHub Action [Wed, 25 Aug 2021 13:10:06 +0000 (13:10 +0000)]
Release prep v8.2.0
david22swan [Wed, 25 Aug 2021 11:38:37 +0000 (12:38 +0100)]
(maint) - Correct since tag
david22swan [Wed, 25 Aug 2021 10:41:35 +0000 (11:41 +0100)]
Merge pull request #1001 from smortex/debian11
(maint) Add support for Debian 11
david22swan [Wed, 25 Aug 2021 10:36:08 +0000 (11:36 +0100)]
Merge pull request #1000 from smortex/stdlib
(main) Allow stdlib 8.0.0
Romain Tartière [Wed, 25 Aug 2021 01:31:45 +0000 (15:31 -1000)]
(maint) Add support for Debian 11
Debian 11 was recently released. Update metadata.json to indicate that
this version is supported by the module.
Romain Tartière [Wed, 25 Aug 2021 01:28:50 +0000 (15:28 -1000)]
(main) Allow stdlib 8.0.0
We recently released stdlib 8.0.0. This module is comptatible with this
version of stdlib.
Romain Tartière [Wed, 25 Aug 2021 01:22:51 +0000 (15:22 -1000)]
(maint) Set DEBIAN_FRONTEND=noninteractive on upgrade
When upgrading Debian packages, the system sometimes what to prompt the
user about what action to perform. Since a tasks is supposed to be
non-interactive, we should disable such prompts.
This help when updating some packages, e.g. postfix.
daianamezdrea [Mon, 23 Aug 2021 11:41:05 +0000 (14:41 +0300)]
Merge pull request #996 from david22swan/maint/main/max_changelog
(maint) - Set max_issues for changelog generator to 500
David Swan [Mon, 23 Aug 2021 10:56:44 +0000 (11:56 +0100)]
(maint) - Set max_issues for changelog generator to 500
Adrian Iurca [Mon, 26 Jul 2021 15:02:34 +0000 (18:02 +0300)]
Merge pull request #994 from puppetlabs/release
Release mergeback version 8.1.0
daianamezdrea [Mon, 26 Jul 2021 14:01:01 +0000 (17:01 +0300)]
Add label for PR
daiana [Mon, 26 Jul 2021 13:55:24 +0000 (16:55 +0300)]
(maint) - Update since_tag
Auto-release [Mon, 26 Jul 2021 13:44:12 +0000 (13:44 +0000)]
Release version 8.1.0
daianamezdrea [Mon, 26 Jul 2021 13:33:46 +0000 (16:33 +0300)]
Merge pull request #993 from kenyon/source_weak_ssl
apt::source: pass the weak_ssl param to apt::key
daianamezdrea [Mon, 26 Jul 2021 12:58:09 +0000 (15:58 +0300)]
Merge pull request #991 from johanfleury/feature/add-support-for-signed-by-in-source-entries
[MODULES-9695] - Add support for signed-by in source entries
Kenyon Ralph [Wed, 21 Jul 2021 19:59:20 +0000 (12:59 -0700)]
apt::source: pass the weak_ssl param to apt::key
david22swan [Wed, 21 Jul 2021 10:06:10 +0000 (11:06 +0100)]
Merge pull request #992 from puppetlabs/pdksync_iac-1149
pdksync - (maint) - Updating Contribution Guidelines
Paula Muir [Tue, 20 Jul 2021 14:28:50 +0000 (15:28 +0100)]
(maint) Updating CONTRIBUTING guidelines
Johan Fleury [Fri, 16 Jul 2021 15:53:59 +0000 (11:53 -0400)]
Add support for signed-by in source entries
carabasdaniel [Wed, 7 Jul 2021 07:32:54 +0000 (10:32 +0300)]
Merge pull request #990 from puppetlabs/apt_keyserver
Replace sks-keyservers.net as is deprecated
daiana [Mon, 5 Jul 2021 15:45:41 +0000 (18:45 +0300)]
Replace sks-keyservers.net(deprecated) with keyserver.ubuntu.com
test
Repair changelog and history files
Michael T Lombardi (He/Him) [Mon, 7 Jun 2021 15:19:52 +0000 (10:19 -0500)]
Merge pull request #988 from puppetlabs/pdksync_pdkupdate
pdksync - (maint) PDKSync - PDK Update
Daniel Carabas [Mon, 7 Jun 2021 10:07:16 +0000 (13:07 +0300)]
(maint) pdksync - PDK Update
carabasdaniel [Tue, 11 May 2021 11:39:53 +0000 (14:39 +0300)]
Merge pull request #987 from pmcmaw/IAC-1597
(IAC-1597) Increasing MAX_RETRY_COUNT
Paula Muir [Thu, 6 May 2021 16:39:34 +0000 (17:39 +0100)]
(IAC-1597) Increasing MAX_RETRIES for Ubuntu18
daianamezdrea [Thu, 29 Apr 2021 08:25:56 +0000 (11:25 +0300)]
Merge pull request #986 from puppetlabs/pdksync_pdk_update
pdksync - (maint) Running pdk update
Paula Muir [Mon, 26 Apr 2021 20:07:50 +0000 (21:07 +0100)]
(maint) Running a pdk update to consume latest pdk-template changes
sheenaajay [Mon, 12 Apr 2021 10:26:27 +0000 (11:26 +0100)]
Merge pull request #985 from kenyon/patch-2
apt::mark: fix docs
Kenyon Ralph [Fri, 9 Apr 2021 18:47:11 +0000 (11:47 -0700)]
apt::mark: fix docs
* Add Puppet Strings summary.
* Typo fix in link to manual page.
Adrian Iurca [Mon, 5 Apr 2021 08:31:05 +0000 (11:31 +0300)]
Merge pull request #983 from puppetlabs/pdksync_releaseprepupdate
pdksync - PDK Update for auto release prep workflow
daiana [Fri, 2 Apr 2021 13:40:23 +0000 (16:40 +0300)]
Add auto-release.yml in .sync.yml
Daniel Carabas [Fri, 2 Apr 2021 11:19:34 +0000 (14:19 +0300)]
PDK Update for release prep workflow
Disha-maker [Mon, 29 Mar 2021 12:00:33 +0000 (13:00 +0100)]
Merge pull request #980 from puppetlabs/release-prep
Release prep v8.0.2
GitHub Action [Mon, 29 Mar 2021 11:58:14 +0000 (11:58 +0000)]
Release prep v8.0.2
Disha-maker [Mon, 29 Mar 2021 11:54:38 +0000 (12:54 +0100)]
Merge pull request #982 from carabasdaniel/auto_release_fix
Update auto_release.yml pdk release prep image
Daniel Carabas [Mon, 29 Mar 2021 09:44:42 +0000 (12:44 +0300)]
Update auto_release.yml pdk release prep image
Michael T Lombardi (He/Him) [Thu, 25 Mar 2021 13:00:36 +0000 (08:00 -0500)]
Merge pull request #981 from david22swan/MODULES-10971/main/aptkeyserver_fix
(MODULES-10971) - Ensure `apt::keyserver` is considered when creating a default apt:source
David Swan [Wed, 24 Mar 2021 14:39:58 +0000 (14:39 +0000)]
(MODULES-10971) - Ensure `apt::keyserver` is considered when creating a default apt:source
As it stands the source_key_defaults point towards the default `keyserver` value set within the params. This change makes it so that it will instead use the `keyserver` value set in the init, which will in turn default to the params value in none has been given.
Paula Muir [Tue, 16 Mar 2021 17:17:37 +0000 (17:17 +0000)]
Merge pull request #979 from david22swan/IAC-1497/main/translate_removal
(IAC-1497) - Removal of unsupported `translate` dependency
David Swan [Tue, 16 Mar 2021 14:11:30 +0000 (14:11 +0000)]
(IAC-1497) - Removal of unsupported `translate` dependency
Paula Muir [Mon, 15 Mar 2021 20:21:07 +0000 (20:21 +0000)]
Merge pull request #978 from puppetlabs/pdksync_pdkupdate
pdksync - PDK Update - Replace Travis and Appveyor with Github Actions
Daniel Carabas [Mon, 15 Mar 2021 16:45:22 +0000 (18:45 +0200)]
Replace Travis and Appveyor with Github Actions
Disha-maker [Mon, 15 Mar 2021 13:53:14 +0000 (13:53 +0000)]
Merge pull request #977 from puppetlabs/release-prep
Release prep v8.0.1
GitHub Action [Mon, 15 Mar 2021 09:18:49 +0000 (09:18 +0000)]
Release prep v8.0.1
Paula Muir [Mon, 8 Mar 2021 11:26:46 +0000 (11:26 +0000)]
Merge pull request #973 from moritz-makandra/main
MODULES-10956 remove redundant code in provider apt_key
daianamezdrea [Tue, 2 Mar 2021 09:39:18 +0000 (11:39 +0200)]
Merge pull request #975 from puppetlabs/release
V8.0.0 Merge Back
Auto-release [Mon, 1 Mar 2021 17:46:32 +0000 (17:46 +0000)]
Release version 8.0.0
daianamezdrea [Thu, 25 Feb 2021 16:47:51 +0000 (18:47 +0200)]
Merge pull request #974 from puppetlabs/pdksync_maint/main/perform_pdk_update
pdksync - (MAINT) PDK update for GHA workflows + Litmus updates
Ciaran McCrisken [Thu, 25 Feb 2021 16:14:49 +0000 (16:14 +0000)]
(MAINT) pdk update
Moritz Kraus [Wed, 24 Feb 2021 14:29:19 +0000 (15:29 +0100)]
MODULES-10956 remove redundant code in provider apt_key
The code in function `update_expired_key` is redundant to the logic in
the function `create`. The call to function `exist` will mark the key as
absent, in case it has expired and refres is set to true.
I debugged for hours why my keys weren't updated until I realized, that
the functionality is elsewhere.
Michael T Lombardi (He/Him) [Tue, 23 Feb 2021 01:29:53 +0000 (19:29 -0600)]
Merge pull request #972 from puppetlabs/maint/main/update_dependencies
(maint) Update major dependencies prior to release
Paula Muir [Mon, 22 Feb 2021 16:05:58 +0000 (16:05 +0000)]
(maint) Update major dependencies prior to release
daianamezdrea [Mon, 22 Feb 2021 10:19:35 +0000 (12:19 +0200)]
Merge pull request #971 from capsi-informatique/fix-typo
Fix typo in weak_ssl documentation
Paula Muir [Tue, 16 Feb 2021 15:29:35 +0000 (15:29 +0000)]
Merge pull request #969 from puppetlabs/pdksync_remove_puppet5
pdksync - Remove Puppet 5 from testing and bump minimal version to 6.0.0
Daniel Carabas [Tue, 16 Feb 2021 13:36:48 +0000 (15:36 +0200)]
pdk update
Disha-maker [Tue, 16 Feb 2021 13:27:01 +0000 (13:27 +0000)]
Merge pull request #970 from puppetlabs/release
(MAINT) Release merge back for v7.1.1 merged
David Cachau [Tue, 16 Feb 2021 13:20:21 +0000 (14:20 +0100)]
Fix typo in weak_ssl documentation
Daniel Carabas [Tue, 16 Feb 2021 07:50:56 +0000 (09:50 +0200)]
Update .sync.yml
Daniel Carabas [Mon, 15 Feb 2021 15:36:24 +0000 (17:36 +0200)]
Bump minimal puppet version to 6.0.0 in metadata.json
Daniel Carabas [Mon, 15 Feb 2021 15:20:01 +0000 (17:20 +0200)]
Remove Puppet 5 testing
Paula Muir [Mon, 15 Feb 2021 14:07:25 +0000 (14:07 +0000)]
Merge pull request #968 from Disha-maker/release
(IAC-1436) Release Prep PR version 7.7.1
Auto-release [Mon, 15 Feb 2021 13:06:46 +0000 (13:06 +0000)]
Release version 7.7.1
david22swan [Wed, 3 Feb 2021 13:08:10 +0000 (13:08 +0000)]
Merge pull request #967 from puppetlabs/pdksync_gha-updates
pdksync - Update gha templates
David Schmitt [Tue, 26 Jan 2021 18:21:04 +0000 (18:21 +0000)]
Wrap apply_manifest into RSpec context; initialise litmus earlier
This fixes the following error by exposing the necessary PuppetLitmus context:
```
An error occurred while loading ./spec/acceptance/01_apt_class_spec.rb.
Failure/Error: apply_manifest(lsb_package)
NameError:
undefined local variable or method `os' for main:Object
# ./vendor/bundle/ruby/2.5.0/gems/puppet_litmus-0.22.0/lib/puppet_litmus/puppet_helpers.rb:86:in `block in apply_manifest'
# ./vendor/bundle/ruby/2.5.0/gems/honeycomb-beeline-2.4.0/lib/honeycomb/client.rb:70:in `start_span'
# ./vendor/bundle/ruby/2.5.0/gems/puppet_litmus-0.22.0/lib/puppet_litmus/puppet_helpers.rb:41:in `apply_manifest'
# ./spec/spec_helper_acceptance_local.rb:17:in `<top (required)>'
# ./spec/spec_helper_acceptance.rb:4:in `require'
# ./spec/spec_helper_acceptance.rb:4:in `<top (required)>'
# ./spec/acceptance/01_apt_class_spec.rb:3:in `require'
# ./spec/acceptance/01_apt_class_spec.rb:3:in `<top (required)>'
```
David Schmitt [Tue, 26 Jan 2021 17:16:53 +0000 (17:16 +0000)]
(maint) Update github actions
david22swan [Mon, 25 Jan 2021 10:30:10 +0000 (10:30 +0000)]
Merge pull request #965 from puppetlabs/RE-13436
(RE-13415) Update GPG key in example
Eric Griswold [Wed, 20 Jan 2021 18:44:24 +0000 (10:44 -0800)]
(RE-13415) Update GPG key in example
Provide recently changed gpg key update in the example puppet code.
carabasdaniel [Mon, 18 Jan 2021 09:28:26 +0000 (11:28 +0200)]
Merge pull request #964 from kenyon/use-modern-os-facts
Use modern os facts
Kenyon Ralph [Sun, 20 Dec 2020 10:50:26 +0000 (02:50 -0800)]
readmes: update note about lsb-release for Puppet 7
Kenyon Ralph [Sun, 20 Dec 2020 09:19:48 +0000 (01:19 -0800)]
spec/classes/apt_backports_spec.rb: fix Mint case
Per
https://github.com/camptocamp/facterdb/blob/master/facts/3.14/linuxmint-19-x86_64.facts#L324
(assuming LinuxMint 17 used the same capitalization as newer
versions).
Kenyon Ralph [Sun, 20 Dec 2020 09:18:36 +0000 (01:18 -0800)]
examples/backports.pp: fix class usage
It's a class, not a defined type.
I missed this in https://github.com/puppetlabs/puppetlabs-apt/pull/962
Kenyon Ralph [Sun, 20 Dec 2020 09:03:15 +0000 (01:03 -0800)]
README: fix link to litmus tutorial
Kenyon Ralph [Sun, 20 Dec 2020 06:28:04 +0000 (22:28 -0800)]
spec_helper_acceptance_local.rb: improve comment about lsb-release
Kenyon Ralph [Sun, 20 Dec 2020 08:11:41 +0000 (00:11 -0800)]
add an acceptance test for apt::backports
Kenyon Ralph [Sun, 20 Dec 2020 06:31:48 +0000 (22:31 -0800)]
manifests: use modern os facts
Kenyon Ralph [Sun, 20 Dec 2020 05:14:38 +0000 (21:14 -0800)]
whitespace cleanup
sanfrancrisko [Mon, 4 Jan 2021 16:28:26 +0000 (16:28 +0000)]
Merge pull request #963 from puppetlabs/pdksync
Update to puppet-module-gems 1.0, pdk-templates and new rubocop
David Schmitt [Mon, 4 Jan 2021 11:15:15 +0000 (11:15 +0000)]
Fix check for ubuntu version