]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/log
Daniele Sluijters [Fri, 20 Mar 2015 18:15:42 +0000 (19:15 +0100)]
README: update['frequency'] is not a boolean
Daniele Sluijters [Fri, 20 Mar 2015 18:13:53 +0000 (19:13 +0100)]
README: Add highlighting for code blocks.
Morgan Haskel [Fri, 20 Mar 2015 18:12:12 +0000 (14:12 -0400)]
Fix typo
Daniele Sluijters [Fri, 20 Mar 2015 18:09:18 +0000 (19:09 +0100)]
Merge pull request #477 from mhaskel/doc_updates
Doc updates
Morgan Haskel [Fri, 20 Mar 2015 00:15:32 +0000 (17:15 -0700)]
README updates for 2.x rewrite
All classes, defines, parameters, and examples should be up to date.
Daniele Sluijters [Thu, 19 Mar 2015 09:16:15 +0000 (10:16 +0100)]
Merge pull request #472 from mhaskel/acceptance_test_fixes
Acceptance test fixes
Daniele Sluijters [Thu, 19 Mar 2015 09:14:56 +0000 (10:14 +0100)]
Merge pull request #473 from mhaskel/freq_cleanup
Remove `update['always'] = true` support
Daniele Sluijters [Thu, 19 Mar 2015 09:14:35 +0000 (10:14 +0100)]
Merge pull request #474 from mhaskel/containers_ftw
Linux open-source builds are regularly maxed out.
Morgan Haskel [Wed, 18 Mar 2015 22:51:37 +0000 (15:51 -0700)]
Linux open-source builds are regularly maxed out.
Container-based are not. Let's switch!
Morgan Haskel [Wed, 18 Mar 2015 20:52:12 +0000 (13:52 -0700)]
Remove `update['always'] = true` support
We don't really need both of `update['always'] = true` and
`update['frequency'] = 'always'`.
Morgan Haskel [Wed, 18 Mar 2015 19:56:29 +0000 (12:56 -0700)]
Make the acceptance tests work
Morgan Haskel [Wed, 18 Mar 2015 19:51:37 +0000 (12:51 -0700)]
Actually make it possible to use apt_key
The provider wasn't updated for a parameter rename.
Daniele Sluijters [Wed, 11 Mar 2015 08:21:45 +0000 (09:21 +0100)]
Merge pull request #461 from mhaskel/boo_inheritance
Inheritance of apt::params means it can't be private
Morgan Haskel [Wed, 11 Mar 2015 00:13:31 +0000 (17:13 -0700)]
Inheritance of apt::params means it can't be private
Otherwise, if another module has `class { 'apt': }` in it everything
fails, as `$caller_module_name` will be the other module name.
Morgan Haskel [Fri, 6 Mar 2015 18:08:02 +0000 (10:08 -0800)]
Merge pull request #453 from puppetlabs/daenney/location-required
apt::source: Make location required.
Daniele Sluijters [Thu, 5 Mar 2015 19:35:02 +0000 (20:35 +0100)]
apt::source: Make location mostly required.
In what universe does it make sense to create a `sources.list.d` entry
for a repository **without** specifying where this repository is?
:confounded:
:disappointed: :weary: :anguished: :scream:
Only when removing the resource should a location not be required.
Morgan Haskel [Fri, 6 Mar 2015 00:49:23 +0000 (16:49 -0800)]
Merge pull request #452 from puppetlabs/daenney/rename-trusted-source
apt::source: Rename `trusted_source`.
Daniele Sluijters [Thu, 5 Mar 2015 19:23:38 +0000 (20:23 +0100)]
apt::source: Rename `trusted_source`.
It is weird that `trusted_source` would default to `false` as that would
imply that we normally don't trust our sources. This is opposite to the
truth, by default we trust them but only if the Releases file can be
verified (meaning it is signed by a GPG key known to apt).
What we were telling apt is that it should trust this source even if the
Releases file and the repository is unsigned. This is better captured
with `allow_unsigned` and better highlights the danger of what you're
doing, installing packages from a source we cannot authenticate.
Morgan Haskel [Thu, 5 Mar 2015 19:10:20 +0000 (11:10 -0800)]
Merge pull request #451 from puppetlabs/daenney/consolidate-include
apt::source: Merge `include_*` options into hash.
Daniele Sluijters [Thu, 5 Mar 2015 16:37:51 +0000 (17:37 +0100)]
apt::source: Merge `include_*` options into hash.
This makes its behaviour similar to the `update`, `proxy` and `purge`
hashes on the main classes bringing its API more in line with the rest
of the module.
Morgan Haskel [Tue, 3 Mar 2015 17:38:29 +0000 (09:38 -0800)]
Merge pull request #450 from puppetlabs/daenney/guard-lsb-facts
apt::params: Complete $xfacts.
Daniele Sluijters [Tue, 3 Mar 2015 17:07:48 +0000 (18:07 +0100)]
apt::params: Complete $xfacts.
`$xfacts` now contains and guards all `lsb*` facts. Looking up any
`lsb*`-related fact should now always be done through `$::apt::xfacts`
to ensure that the values are always set to either the value of the fact
or undef. This avoids all sorts of kerfuffles with strict variables.
Morgan Haskel [Tue, 3 Mar 2015 16:54:27 +0000 (08:54 -0800)]
Merge pull request #449 from puppetlabs/daenney/fix-strict-vars
apt: Fix all strict variable cases.
Daniele Sluijters [Mon, 2 Mar 2015 21:40:06 +0000 (22:40 +0100)]
apt: Fix all strict variable cases.
A few of these fixes are absolutely horrendous but we have no choice as
we need to stay current- and future-parser compatible for now.
Once we can go Puppet 4 only we can use the `$facts` hash lookup instead
which will return undef/nil for things that aren't set instead of them
not being defined at all.
Morgan Haskel [Mon, 2 Mar 2015 19:53:53 +0000 (11:53 -0800)]
Merge pull request #448 from puppetlabs/daenney/kill-file-perms
apt::setting: Remove file_perms.
Daniele Sluijters [Mon, 2 Mar 2015 19:37:01 +0000 (20:37 +0100)]
apt::setting: Remove file_perms.
This was a great idea but is pretty pointless. It's also not being used
by anything and not exposed as a switch on the main class so it would
almost never affect any behaviour.
Morgan Haskel [Mon, 2 Mar 2015 18:10:37 +0000 (10:10 -0800)]
Merge pull request #447 from puppetlabs/daenney/hulk-smash-2
It's been a long time - how have you been
Daniele Sluijters [Sun, 1 Mar 2015 13:42:39 +0000 (14:42 +0100)]
apt::key: Be explicit about the keyserver.
The behaviour of passing down undef through multiple layers gets fuzzy
so for now be explicit about the keyserver.
Once Puppet 4 is out and this behaviour has been crystallised and tested
we can revisit it.
Daniele Sluijters [Sun, 1 Mar 2015 13:18:48 +0000 (14:18 +0100)]
apt::key: Rename $key to $id to match apt_key.
Daniele Sluijters [Sat, 28 Feb 2015 17:02:23 +0000 (18:02 +0100)]
apt::source: Allow passing in a complex key.
Turn `$key` into something that accepts a string or a hash of four keys
representing the different options that can be passed on to `apt::key`.
Daniele Sluijters [Sat, 28 Feb 2015 16:35:25 +0000 (17:35 +0100)]
apt(::key|_key) Remove the `key.*_` prefixes.
Remove a lot of the redundant `key_` prefixes on `apt::key` and the
`keyserver_` prefix on `apt_key`.
Daniele Sluijters [Sat, 28 Feb 2015 16:04:47 +0000 (17:04 +0100)]
apt: Add settings, keys and ppas.
* Allow any configuration of apt to be done through data bindings by
passing in hashes representing the resources.
* Switch apt::ppa to use `distid` as set in `apt::params. This makes
`apt::ppa` also work for LinuxMint.
Daniele Sluijters [Sat, 28 Feb 2015 15:48:48 +0000 (16:48 +0100)]
apt: Change how update is managed.
* Instead of having 4 options controlling purging we now have a single
hash with four possible keys.
* Include `apt::update` only _after_ we've assembled the `$_update`
hash.
Daniele Sluijters [Sat, 28 Feb 2015 15:12:47 +0000 (16:12 +0100)]
apt: Change how purging is managed.
* Instead of having 4 options controlling purging we now have a single
hash with four possible keys.
* We purge everything by default.
* `/etc/apt/preferences` is now always managed.
* Add missing `mode` to some of the files.
Morgan Haskel [Fri, 27 Feb 2015 21:09:07 +0000 (13:09 -0800)]
Merge pull request #446 from puppetlabs/daenney/apt-proxy
apt: Add proxy support on the class.
Daniele Sluijters [Fri, 27 Feb 2015 11:34:05 +0000 (12:34 +0100)]
apt: Add proxy support on the class.
Re-introduce proxy support at the class level. Needing to configure a
proxy is such a common scenario that having it on the class is a
reasonable thing. It also affects `apt::ppa`.
Change `apt::ppa` to no longer have its own `proxy` parameter but use
the proxy as configured on the main `apt` class.
Daniele Sluijters [Fri, 27 Feb 2015 11:07:56 +0000 (12:07 +0100)]
spec/(apt|ppa): Enough with all the strings.
Most options can and should be named through symbols, makes it much
easier to read too with syntax highlighting.
Daniele Sluijters [Fri, 27 Feb 2015 08:01:38 +0000 (09:01 +0100)]
Merge pull request #445 from mhaskel/updates_everywhere
Make apt::setting notify Exec['apt_update'] by default
Morgan Haskel [Thu, 26 Feb 2015 20:44:06 +0000 (12:44 -0800)]
Make apt::setting notify Exec['apt_update'] by default
Can be disabled by setting `notify_update => false`
Morgan Haskel [Thu, 26 Feb 2015 19:27:38 +0000 (11:27 -0800)]
Merge pull request #444 from puppetlabs/daenney/parse-setting-from-name
apt::setting: Parse type and name from title.
Daniele Sluijters [Thu, 26 Feb 2015 18:12:53 +0000 (19:12 +0100)]
apt::setting: Parse type and name from title.
Instead of having two additional parameters, `base_name` and
`setting_type` simply parse it from `title`.
We need to prefix most resources with `list-`, `conf-`, or `pref-` any
way to avoid duplicate resources so we might as well leverage that.
Daniele Sluijters [Thu, 26 Feb 2015 17:00:17 +0000 (18:00 +0100)]
Merge pull request #443 from mhaskel/proxy_updates
proxy_* params were removed from class apt
Daniele Sluijters [Thu, 26 Feb 2015 17:00:02 +0000 (18:00 +0100)]
Merge pull request #441 from mhaskel/use_setting
Convert to use apt::setting instead of file resource
Morgan Haskel [Tue, 24 Feb 2015 22:57:31 +0000 (14:57 -0800)]
Convert to use apt::setting instead of file resources
This adds consistency across the module
Morgan Haskel [Wed, 25 Feb 2015 01:03:50 +0000 (17:03 -0800)]
proxy_* params were removed from class apt
Add them to PPA since they were being used there, and add a placeholder
example for setting up the proxy files.
Daniele Sluijters [Wed, 25 Feb 2015 17:22:37 +0000 (18:22 +0100)]
Merge pull request #442 from mhaskel/add_base_name
Add base_name parameter to apt::setting
Daniele Sluijters [Wed, 25 Feb 2015 17:22:04 +0000 (18:22 +0100)]
Merge pull request #440 from mhaskel/fix_setting_validation
Allow priorities to be zero-padded
Morgan Haskel [Tue, 24 Feb 2015 23:51:41 +0000 (15:51 -0800)]
Add base_name parameter to apt::setting
This allows you to work around duplicate resource issues when you have
settings of different types with the same name. When the files are built
it is path/${priority}${base_name}${extension}.
Morgan Haskel [Tue, 24 Feb 2015 21:53:25 +0000 (13:53 -0800)]
Allow priorities to be zero-padded
Daniele Sluijters [Wed, 25 Feb 2015 07:45:30 +0000 (08:45 +0100)]
Merge pull request #439 from mhaskel/rspec3
Convert specs to RSpec 3.1.7 syntax with Transpec
Morgan Haskel [Wed, 25 Feb 2015 00:14:23 +0000 (16:14 -0800)]
Merge pull request #438 from puppetlabs/daenney/cant-touch-params-nanananana
apt::params: Make the class private.
Morgan Haskel [Tue, 24 Feb 2015 21:20:29 +0000 (13:20 -0800)]
Convert specs to RSpec 3.1.7 syntax with Transpec
This conversion is done by Transpec 3.0.8 with the following command:
transpec spec/classes spec/defines spec/unit
* 87 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 14 conversions
from: obj.should
to: expect(obj).to
* 7 conversions
from: == expected
to: eq(expected)
* 1 conversion
from: it { should_not ... }
to: it { is_expected.not_to ... }
For more details: https://github.com/yujinakayama/transpec#supported-conversions
Daniele Sluijters [Tue, 24 Feb 2015 20:43:36 +0000 (21:43 +0100)]
apt::params: Make the class private.
Prevent direct access to apt::params. This will ensure that any other
module cannot blindly access apt::params and get settings that have been
potentially overridden at the apt level.
Our own module still can since any class in apt has a module_name of
'apt' but that's up to us to prevent from happening.
Every setting must now be accessed by a qualified lookup into the apt
namespace.
Daniele Sluijters [Mon, 23 Feb 2015 19:21:10 +0000 (20:21 +0100)]
Merge pull request #433 from mhaskel/ppa
PPA Cleanup, pt 1
Morgan Haskel [Fri, 20 Feb 2015 22:25:53 +0000 (14:25 -0800)]
PPA Cleanup, pt 1
Make the code much cleaner, but don't make a t&p.
Daniele Sluijters [Sat, 21 Feb 2015 23:30:36 +0000 (00:30 +0100)]
Merge pull request #432 from mhaskel/source_cleanup
Cleanup for `apt::source`
Morgan Haskel [Sat, 21 Feb 2015 20:11:57 +0000 (12:11 -0800)]
Convert apt::source to use apt::setting
May as well use the define since we added it
Morgan Haskel [Thu, 19 Feb 2015 23:35:47 +0000 (15:35 -0800)]
Cleanup for `apt::source`
* Update `release` to default to `$::lsbdistcodename`
* Default `include_src` to false
* Validate more things!
* Stop redefining variables from `apt::params`
Daniele Sluijters [Sat, 21 Feb 2015 23:22:59 +0000 (00:22 +0100)]
Merge pull request #435 from mhaskel/setting_fix
Type is a reserved word in puppet 4
Daniele Sluijters [Sat, 21 Feb 2015 23:22:25 +0000 (00:22 +0100)]
Merge pull request #431 from mhaskel/local_variable_declarations
Stop redeclaring variables from params
Morgan Haskel [Fri, 20 Feb 2015 19:15:23 +0000 (11:15 -0800)]
Stop redeclaring variables from params
It really seems unnecessary.
Morgan Haskel [Sat, 21 Feb 2015 19:50:00 +0000 (11:50 -0800)]
Type is a reserved word in puppet 4
So replace `type` with `setting_type` in apt::setting
Morgan Haskel [Sat, 21 Feb 2015 19:40:05 +0000 (11:40 -0800)]
Merge pull request #428 from puppetlabs/daenney/apt-setting
apt: Add apt::setting defined type.
Daniele Sluijters [Fri, 20 Feb 2015 12:00:17 +0000 (13:00 +0100)]
apt: Add apt::setting defined type.
This is a 'base' type. It's a simple wrapper around a file which takes
`type`, `ensure`, `content`, `source` and `file_perms`. It is intended
for usage by `apt::conf`, `apt::source` and an upcoming `apt::pref`.
Daniele Sluijters [Fri, 20 Feb 2015 21:06:50 +0000 (22:06 +0100)]
Merge pull request #430 from mhaskel/fix_typo
Fix typo from #426
Daniele Sluijters [Fri, 20 Feb 2015 21:06:29 +0000 (22:06 +0100)]
Merge pull request #429 from mhaskel/remove_include_update
Remove 'include apt::update'
Morgan Haskel [Fri, 20 Feb 2015 18:55:47 +0000 (10:55 -0800)]
Fix typo from #426
Too many `$`s
Morgan Haskel [Fri, 20 Feb 2015 18:47:35 +0000 (10:47 -0800)]
Remove 'include apt::update'
It is included in `class apt`, and there are no promises about anything
working without that.
Morgan Haskel [Fri, 20 Feb 2015 00:41:27 +0000 (16:41 -0800)]
Merge pull request #426 from puppetlabs/daenney/fix-missing-param-and-naming
apt::params: Add two missing entries, use them.
Daniele Sluijters [Fri, 20 Feb 2015 00:10:45 +0000 (01:10 +0100)]
Merge pull request #427 from mhaskel/required_packages
RFC - Remove required packages
Daniele Sluijters [Thu, 19 Feb 2015 23:09:44 +0000 (00:09 +0100)]
apt::params: Add two missing entries, use them.
Morgan Haskel [Thu, 19 Feb 2015 23:39:14 +0000 (15:39 -0800)]
Remove required packages
I'm not entirely clear on the history behind this feature, and this
feels sort of hack-y. If you could explain why this is needed that would
be awesome, or if it isn't just merge this :)
Daniele Sluijters [Thu, 19 Feb 2015 18:35:50 +0000 (19:35 +0100)]
Merge pull request #424 from mhaskel/hulk_smash
Hulk smash
Morgan Haskel [Thu, 19 Feb 2015 16:26:30 +0000 (08:26 -0800)]
Fix lint issue in examples
Morgan Haskel [Wed, 18 Feb 2015 21:42:43 +0000 (13:42 -0800)]
Fix acceptance tests
Morgan Haskel [Wed, 18 Feb 2015 19:43:50 +0000 (11:43 -0800)]
Fix broken unit tests
Morgan Haskel [Sun, 15 Feb 2015 19:17:12 +0000 (11:17 -0800)]
Placeholders for needed examples
Morgan Haskel [Sun, 15 Feb 2015 19:11:58 +0000 (11:11 -0800)]
Update examples
Morgan Haskel [Sun, 15 Feb 2015 18:59:00 +0000 (10:59 -0800)]
Get rid of hold
Morgan Haskel [Sun, 15 Feb 2015 18:54:33 +0000 (10:54 -0800)]
Get rid of release
Morgan Haskel [Sun, 15 Feb 2015 18:52:57 +0000 (10:52 -0800)]
Get rid of force
Morgan Haskel [Sun, 15 Feb 2015 18:45:25 +0000 (10:45 -0800)]
get rid of builddep
Morgan Haskel [Sun, 15 Feb 2015 18:41:54 +0000 (10:41 -0800)]
Merge pull request #1 from puppet-community/daenney/remove_unattended_upgrades_remains
Remove some vars for unattended_upgrades.
Daniele Sluijters [Sun, 15 Feb 2015 18:40:42 +0000 (19:40 +0100)]
Remove some vars for unattended_upgrades.
Morgan Haskel [Sun, 15 Feb 2015 18:25:36 +0000 (10:25 -0800)]
stop including params everywhere
Morgan Haskel [Sun, 15 Feb 2015 18:22:37 +0000 (10:22 -0800)]
Remove backports and debian
Morgan Haskel [Sun, 15 Feb 2015 17:48:10 +0000 (09:48 -0800)]
move tests to examples
Morgan Haskel [Sun, 15 Feb 2015 17:46:04 +0000 (09:46 -0800)]
Get rid of unattended upgrades and cleanup unused templates
Morgan Haskel [Sun, 15 Feb 2015 17:41:20 +0000 (09:41 -0800)]
and an acceptance test
Morgan Haskel [Sun, 15 Feb 2015 17:39:17 +0000 (09:39 -0800)]
Unbreak broken tests
Morgan Haskel [Sun, 15 Feb 2015 17:09:47 +0000 (09:09 -0800)]
Starting to clean up init.pp
Daniele Sluijters [Fri, 13 Feb 2015 08:23:53 +0000 (09:23 +0100)]
Merge pull request #422 from cmurphy/lint
Ensure linter fails on lint warnings
Daniele Sluijters [Fri, 13 Feb 2015 08:23:41 +0000 (09:23 +0100)]
Merge pull request #421 from cmurphy/future
Update spec tests for future parser
Colleen Murphy [Thu, 12 Feb 2015 00:43:14 +0000 (16:43 -0800)]
Ensure linter fails on lint warnings
Colleen Murphy [Thu, 12 Feb 2015 00:38:32 +0000 (16:38 -0800)]
Update spec tests for future parser
Strings must be quoted in the future parser.
Daniele Sluijters [Fri, 6 Feb 2015 21:10:41 +0000 (22:10 +0100)]
Merge pull request #389 from stdietrich/global_header_partial
(MODULES-1200) Fix inconsistent header across files
Stefan Dietrich [Sun, 31 Aug 2014 13:46:57 +0000 (15:46 +0200)]
(MODULES-1200) Fix inconsistent header across files
Daniele Sluijters [Wed, 4 Feb 2015 22:50:37 +0000 (23:50 +0100)]
Merge pull request #416 from mkrakowitzer/add_param_documentation
(doc) Add documentation for apt::key parameters and apt::pin parameters
Hunter Haugen [Wed, 4 Feb 2015 20:04:17 +0000 (12:04 -0800)]
Merge pull request #418 from cmurphy/rspec
Pin rspec gems
Colleen Murphy [Wed, 4 Feb 2015 16:02:03 +0000 (17:02 +0100)]
Pin rspec gems