]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/log
Stefano Zanella [Fri, 27 Sep 2013 16:29:12 +0000 (18:29 +0200)]
Add Bundler byproducts to the list of ignored files.
I assume this commit is self-explanatory...
Ashley Penney [Fri, 13 Sep 2013 19:00:57 +0000 (12:00 -0700)]
Merge pull request #240 from doc75/dev_drop_policy
No firewallchain autorequire for INPUT, OUTPUT and FORWARD when table is :filter to enable DROP policy without blocking
Ashley Penney [Fri, 13 Sep 2013 18:53:50 +0000 (11:53 -0700)]
Merge pull request #208 from georgkoester/hop_limit2
Add support for IPv6 hop limiting
Ashley Penney [Fri, 13 Sep 2013 17:48:05 +0000 (10:48 -0700)]
Merge pull request #247 from edmundcraske/patch-1
Fix pre/post errors
edmundcraske [Thu, 12 Sep 2013 13:48:53 +0000 (14:48 +0100)]
Fix pre/post errors
Ashley Penney [Tue, 10 Sep 2013 20:26:06 +0000 (13:26 -0700)]
Merge pull request #242 from apenney/042-release
Prepare 0.4.2 release.
Ashley Penney [Tue, 10 Sep 2013 20:25:43 +0000 (16:25 -0400)]
Prepare 0.4.2 release.
Ashley Penney [Tue, 10 Sep 2013 20:24:18 +0000 (13:24 -0700)]
Merge pull request #241 from apenney/remove
Add a .fixtures.yml so spec_helper can manage the tests.
Ashley Penney [Tue, 10 Sep 2013 20:19:41 +0000 (16:19 -0400)]
Add a .fixtures.yml so spec_helper can manage the tests.
Guillaume Virlet [Mon, 9 Sep 2013 22:11:13 +0000 (00:11 +0200)]
ensure INPUT, OUTPUT and FORWARD firewallchain are not autorequired when table is :filter (to allow default drop policy at the end of rules)
Ashley Penney [Mon, 9 Sep 2013 21:19:10 +0000 (14:19 -0700)]
Merge pull request #233 from mediatemple/22112_better_persistence
Only workaround if we're using the old package.
Ashley Penney [Tue, 27 Aug 2013 22:15:41 +0000 (15:15 -0700)]
Merge pull request #232 from mediatemple/22090_add_redhat_operatingsystems
22090 - Use list of RedHat OSes from newer facter.
Hunter Haugen [Mon, 12 Aug 2013 22:49:46 +0000 (15:49 -0700)]
Merge pull request #234 from apenney/041-release
Release a 0.4.1.
Ashley Penney [Fri, 9 Aug 2013 17:14:42 +0000 (10:14 -0700)]
Release a 0.4.1.
Sharif Nassar [Wed, 7 Aug 2013 21:22:53 +0000 (14:22 -0700)]
Only workaround if we're using the old package.
Sharif Nassar [Tue, 6 Aug 2013 21:18:25 +0000 (14:18 -0700)]
22090 - Use list of RedHat OSes from newer facter.
Ashley Penney [Fri, 12 Jul 2013 18:48:02 +0000 (11:48 -0700)]
Merge pull request #222 from hunner/release_0.4.0
Release 0.4.0
Hunter Haugen [Thu, 11 Jul 2013 23:54:28 +0000 (16:54 -0700)]
Release 0.4.0
Raphaël Pinson [Thu, 30 May 2013 11:37:53 +0000 (13:37 +0200)]
Add support for hop limit
Georg Koester [Fri, 12 Apr 2013 07:58:09 +0000 (00:58 -0700)]
Add ipv6 fragmentation matchers and generify known_boolean handling.
Adds tests for ipv6, too.
ip6tables handles fragmentation differently. There's a special
module and a couple of matchers which are all needed to
implement a stateless firewall correctly.
known_boolean handling with etc has been generified.
The known_boolean functionality was partly tailored
to the :socket feature.
Hunter Haugen [Tue, 9 Jul 2013 22:49:43 +0000 (15:49 -0700)]
Merge pull request #219 from hunner/feature/master/add-support-for-iprange
Feature/master/add support for iprange
Hunter Haugen [Tue, 9 Jul 2013 00:05:58 +0000 (17:05 -0700)]
Add rspec-system tests for src_range/dst_range
Ashley Penney [Tue, 9 Jul 2013 15:36:52 +0000 (08:36 -0700)]
Merge pull request #220 from traylenator/SLC
Add SL and SLC cases for operatingsystem
Ashley Penney [Tue, 9 Jul 2013 15:35:15 +0000 (08:35 -0700)]
Merge pull request #217 from hunner/update_provider_specs
Update providers to use expect syntax
Steve Traylen [Tue, 9 Jul 2013 13:43:44 +0000 (15:43 +0200)]
Add SL and SLC cases for operatingsystem
Hunter Haugen [Mon, 8 Jul 2013 23:40:59 +0000 (16:40 -0700)]
Update providers to use expect syntax
The expect syntax is much better than the should syntax and ships with
RSpec 2.14. It caused a few conflicts with the mocha stubbing, so I
updated the docs to use rspec test doubles instead.
Hunter Haugen [Mon, 8 Jul 2013 23:58:26 +0000 (16:58 -0700)]
Merge pull request #218 from hunner/remove_puppet_2.6
Remove travis testing puppet 2.6
Hunter Haugen [Mon, 8 Jul 2013 23:53:43 +0000 (16:53 -0700)]
Remove travis testing puppet 2.6
Hunter Haugen [Mon, 8 Jul 2013 23:40:15 +0000 (16:40 -0700)]
Add specs for dst_range and src_range params
Lei Zhang [Fri, 5 Jul 2013 05:26:33 +0000 (14:56 +0930)]
(#215) Add support for IP range
Add support for filtering by source and destination IP range, equivalent to '-m iprange --src-range|--dst-range',
which is only allowing a specified IP range. Excluding an IP range, '! --src-range or ! --dst-range', is not supported.
Add ':src_range' and ':dst_range' to iptables.rb
lei [Fri, 5 Jul 2013 04:57:56 +0000 (14:27 +0930)]
(#215) Add support for IP range
Add support for filtering by source and destination IP range, equivalent to '-m iprange --src-range|--dst-range',
which is only allowing a specified IP range. Excluding an IP range, '! --src-range or ! --dst-range', is not supported.
Add ':src_range' and ':dst_range' to firewall.rb
Dan Carley [Sun, 16 Jun 2013 20:16:37 +0000 (21:16 +0100)]
Exclude tests for Puppet < 3.2 against ruby-head
ruby-head is currently 2.x, which Puppet only began supporting at version
3.2: http://projects.puppetlabs.com/issues/18494
This should make the "allowed failures" builds green once again.
Dan Carley [Sun, 16 Jun 2013 20:14:12 +0000 (21:14 +0100)]
Test against Puppet 3.2
Released last month.
Dan Carley [Sun, 16 Jun 2013 20:03:59 +0000 (21:03 +0100)]
Merge branch 'pr/213'
Fixes #213
Dan Carley [Sun, 16 Jun 2013 19:54:02 +0000 (20:54 +0100)]
[#213] Run puppet-lint as part of CI
Will prevent lint from being violated again in the future.
Dan Carley [Sun, 16 Jun 2013 19:51:43 +0000 (20:51 +0100)]
[#213] Improve manifest documentation
Bad me. I should have written these the first time round.
Wolf Noble [Sun, 16 Jun 2013 18:07:20 +0000 (13:07 -0500)]
Minor fixes to appease puppet-lint
Signed-off-by: Wolf Noble <wolf@wolfspyre.com>
Dan Carley [Fri, 14 Jun 2013 13:08:29 +0000 (06:08 -0700)]
Merge pull request #212 from alphagov/addrtype
Add support for --src-type and --dst-type
Nick Stenning [Fri, 14 Jun 2013 11:48:37 +0000 (12:48 +0100)]
Rename {source,destination}_type to {src,dst}_type
As suggested by @dcarley.
Nick Stenning [Fri, 14 Jun 2013 11:08:38 +0000 (12:08 +0100)]
Add support for --src-type and --dst-type
Add support for filtering by source and destination address types. Supported by
iptables only, this feature allows filtering packets by the address type (such
as whether the packet came from a local address, a broadcast address, a
multicast address, etc).
Adds the `:address_type` feature to allow a provider to declare support for
filtering on the basis of address type.
Dan Carley [Thu, 13 Jun 2013 20:25:13 +0000 (21:25 +0100)]
Merge pull request #200 from ChrisRut/fixburst
Dan Carley [Thu, 13 Jun 2013 20:10:04 +0000 (21:10 +0100)]
[#200] Add tests for --limit-burst
Both explicit (when a `:burst` parameter or `--limit-burst` argument is
present) and implicit (when neither are specified but `:limit` or `--limit`
are present and the default burst is `5`).
Chris Rutter [Tue, 11 Jun 2013 15:34:50 +0000 (11:34 -0400)]
fix for default burst value of 5
fixes #200
Ken Barber [Mon, 10 Jun 2013 12:55:06 +0000 (05:55 -0700)]
Merge pull request #204 from georgkoester/fix188
Fix #188: -f in comment leads to puppet resource firewall failing.
Ken Barber [Mon, 10 Jun 2013 10:24:52 +0000 (11:24 +0100)]
Fix minor test bug for latest puppet
Signed-off-by: Ken Barber <ken@bob.sh>
Ken Barber [Mon, 10 Jun 2013 09:41:34 +0000 (10:41 +0100)]
Release 0.3.1
Signed-off-by: Ken Barber <ken@bob.sh>
Ken Barber [Mon, 10 Jun 2013 09:29:05 +0000 (02:29 -0700)]
Merge pull request #209 from kbarber/rspec-system-puppet-2
Update tests for rspec-system-puppet 2
Ken Barber [Mon, 10 Jun 2013 08:35:34 +0000 (09:35 +0100)]
Update tests for rspec-system-puppet 2
This changes all the tests to be not only compatible with rspec-system-puppet
2, but to use some of the new syntactic sugar it provides.
Signed-off-by: Ken Barber <ken@bob.sh>
Georg Koester [Sat, 8 Jun 2013 15:15:37 +0000 (08:15 -0700)]
Fix #188: -f in comment leads to puppet resource firewall failing.
Ken Barber [Wed, 5 Jun 2013 02:09:10 +0000 (19:09 -0700)]
Merge pull request #199 from kbarber/rspec-system-15
Update rspec-system tests for rspec-system-puppet 1.5
Ken Barber [Wed, 5 Jun 2013 01:52:06 +0000 (02:52 +0100)]
Update rspec-system tests for rspec-system-puppet 1.5
Signed-off-by: Ken Barber <ken@bob.sh>
Ken Barber [Mon, 3 Jun 2013 14:05:36 +0000 (07:05 -0700)]
Merge pull request #197 from kbarber/hasstatus
Ensure all services have 'hasstatus => true' for Puppet 2.6
Ken Barber [Mon, 3 Jun 2013 13:32:31 +0000 (06:32 -0700)]
Merge pull request #192 from joejulian/116/pre-existing_rules_name_fix
Accept pre-existing rule with invalid name
Ken Barber [Mon, 3 Jun 2013 13:22:53 +0000 (14:22 +0100)]
Ensure all services have 'hasstatus => true' for Puppet 2.6
We were getting reports of idempotency issues with 2.6, due to missing
hasstatus setting.
Signed-off-by: Ken Barber <ken@bob.sh>
Joe Julian [Fri, 31 May 2013 01:59:23 +0000 (18:59 -0700)]
Fixed dumb logic error
Joe Julian [Thu, 30 May 2013 03:42:29 +0000 (20:42 -0700)]
Accept pre-existing rule with invalid name
This patch fixes up a pre-existing rule whose name does not
type-validate with a valid name (typically one without a numeric
prefix in the comment).
Fixes #116
Signed-off-by: Joe Julian <me@joejulian.name>
Ken Barber [Tue, 28 May 2013 21:12:31 +0000 (14:12 -0700)]
Merge pull request #191 from joejulian/log_level-in-wrong-order
Swap log_prefix and log_level order to match the way it's saved
Joe Julian [Tue, 28 May 2013 20:47:33 +0000 (13:47 -0700)]
Swap log_prefix and log_level order to match the way it's saved
Fixes #184
Signed-off-by: Joe Julian <me@joejulian.name>
Ken Barber [Tue, 28 May 2013 15:18:20 +0000 (08:18 -0700)]
Merge pull request #189 from joejulian/ticket/20912-split_arguments_while_maintaining_quoted_strings
(#20912) Split argments while maintaining quoted strings
Ken Barber [Tue, 28 May 2013 14:47:24 +0000 (15:47 +0100)]
Fix log test to replicate bug #182
Signed-off-by: Ken Barber <ken@bob.sh>
Joe Julian [Sat, 25 May 2013 00:47:53 +0000 (17:47 -0700)]
Accidentally deleted the conversion to -D
Joe Julian [Fri, 24 May 2013 23:38:04 +0000 (16:38 -0700)]
(#20912) Split argments while maintaining quoted strings
Github Bug: 182
Signed-off-by: Joe Julian <me@joejulian.name> (signed CLA)
Ken Barber [Thu, 23 May 2013 13:56:15 +0000 (06:56 -0700)]
Merge pull request #187 from kbarber/log_changed_name
Add more log param tests
Ken Barber [Thu, 23 May 2013 02:05:31 +0000 (03:05 +0100)]
Add more log param tests
Signed-off-by: Ken Barber <ken@bob.sh>
Ken Barber [Thu, 23 May 2013 00:49:18 +0000 (17:49 -0700)]
Merge pull request #186 from kbarber/log_level
Add extra tests for logging parameters
Ken Barber [Thu, 23 May 2013 00:32:03 +0000 (01:32 +0100)]
Add extra tests for logging parameters
Signed-off-by: Ken Barber <ken@bob.sh>
Ken Barber [Thu, 25 Apr 2013 21:51:23 +0000 (22:51 +0100)]
Clarify OS support
Signed-off-by: Ken Barber <ken@bob.sh>
Ken Barber [Thu, 25 Apr 2013 21:30:11 +0000 (14:30 -0700)]
Merge pull request #174 from cr3/0.3.0
Release 0.3.0
Marc Tardif [Thu, 25 Apr 2013 15:25:20 +0000 (11:25 -0400)]
Release 0.3.0
Ken Barber [Wed, 24 Apr 2013 22:40:06 +0000 (15:40 -0700)]
Merge pull request #173 from kbarber/171
Ensure parameter for firewall class
Ken Barber [Wed, 24 Apr 2013 22:40:06 +0000 (15:40 -0700)]
Merge pull request #173 from kbarber/171
Ensure parameter for firewall class
Ken Barber [Wed, 24 Apr 2013 22:18:25 +0000 (23:18 +0100)]
Document ensure class parameter
Signed-off-by: Ken Barber <ken@bob.sh>
Ken Barber [Wed, 24 Apr 2013 22:01:15 +0000 (23:01 +0100)]
A patch for Debian 6 for enable => true has a bug
Signed-off-by: Ken Barber <ken@bob.sh>
Ken Barber [Wed, 24 Apr 2013 21:13:48 +0000 (22:13 +0100)]
Add system tests for ensure parameter
Signed-off-by: Ken Barber <ken@bob.sh>
Marc Tardif [Wed, 24 Apr 2013 18:46:26 +0000 (14:46 -0400)]
(#171) Added ensure parameter to firewall class
This change adds the ensure parameter to the firewall class so that
the appropriate iptables service for the operating system can be
stopped. The reason for this change is to extend the class so that
it is not just limited to running the service.
The change to the manifests still made all the rspec tests pass,
so it should not introduce any regressions. More rspec tests were
also added to exercise the new code paths introduced.
This pull request fixes issue #171.
Ken Barber [Sun, 21 Apr 2013 20:57:58 +0000 (21:57 +0100)]
Bump rspec-system-puppet revision
Signed-off-by: Ken Barber <ken@bob.sh>
Ken Barber [Mon, 15 Apr 2013 02:24:21 +0000 (19:24 -0700)]
Merge pull request #167 from kbarber/socket_params_test
Socket params test
Ken Barber [Mon, 15 Apr 2013 01:33:17 +0000 (02:33 +0100)]
Socket params test
Signed-off-by: Ken Barber <ken@bob.sh>
Ken Barber [Mon, 15 Apr 2013 01:24:06 +0000 (18:24 -0700)]
Merge pull request #166 from kbarber/duplicate_existing_rules_dont_purge
Duplicate existing rules dont purge
Ken Barber [Sat, 13 Apr 2013 23:58:24 +0000 (00:58 +0100)]
Add counter to a base number for order gen
Signed-off-by: Ken Barber <ken@bob.sh>
Anastasis Andronidis [Thu, 26 Jul 2012 12:24:21 +0000 (14:24 +0200)]
(#15702) firewall duplicated rules are not removed
This fix makes sure that every rule has a different name so same rules
get deleted.
Ken Barber [Sat, 13 Apr 2013 23:30:48 +0000 (00:30 +0100)]
Add test to make sure duplicate existing rules get purged
Signed-off-by: Ken Barber <ken@bob.sh>
Ken Barber [Mon, 15 Apr 2013 00:05:11 +0000 (01:05 +0100)]
Make param test pending due to rhel5 failures
Signed-off-by: Ken Barber <ken@bob.sh>
Ken Barber [Sat, 13 Apr 2013 22:53:06 +0000 (23:53 +0100)]
Merge branch 'rspec_colour_in_jenkins'
* rspec_colour_in_jenkins:
Fix rspec colour in jenkins
Ken Barber [Sat, 13 Apr 2013 22:48:30 +0000 (23:48 +0100)]
Fix rspec colour in jenkins
Signed-off-by: Ken Barber <ken@bob.sh>
Ken Barber [Sat, 13 Apr 2013 22:41:27 +0000 (15:41 -0700)]
Merge pull request #162 from kbarber/booleans_not_idempotent
Booleans not idempotent
Georg Koester [Thu, 11 Apr 2013 16:46:07 +0000 (09:46 -0700)]
Fix boolean rules being always recognized as changed.
String and boolean types were compared.
Had to adapt the tests which checked for booleans, when in
reality strings where present.
Ken Barber [Sat, 13 Apr 2013 22:08:20 +0000 (23:08 +0100)]
Add system tests for socket property
Signed-off-by: Ken Barber <ken@bob.sh>
Ken Barber [Sat, 13 Apr 2013 20:39:06 +0000 (21:39 +0100)]
Merge branch 'add_isfragment_option2'
* add_isfragment_option2:
Add match rule for fragments.
Georg Koester [Wed, 10 Apr 2013 12:47:56 +0000 (05:47 -0700)]
Add match rule for fragments.
Via isfragment true/false property, toggles '-f'.
Same implementation as socket property, same bug
where the property is always recognized as changed.
Ken Barber [Sat, 13 Apr 2013 20:06:46 +0000 (13:06 -0700)]
Merge pull request #145 from ecbypi/ticket/20096-fedora-systemd-support
(20096) Support systemd on Fedora 15 and up
Ken Barber [Sat, 13 Apr 2013 19:40:18 +0000 (12:40 -0700)]
Merge pull request #161 from kbarber/standard_run_tests
Add tests for the recommended setup
Ken Barber [Sat, 13 Apr 2013 19:00:43 +0000 (20:00 +0100)]
Add tests for the recommended setup
Using the documented recommended setup, we test if it works with no error and
test if it is idempotent by running it again, looking for resource changes.
Signed-off-by: Ken Barber <ken@bob.sh>
Ken Barber [Sat, 13 Apr 2013 17:17:34 +0000 (10:17 -0700)]
Merge pull request #160 from kbarber/more_rspec_tests
Add more system tests: class testing in particular
Ken Barber [Sat, 13 Apr 2013 16:27:00 +0000 (17:27 +0100)]
Add more system tests: class testing in particular
Signed-off-by: Ken Barber <ken@bob.sh>
Ken Barber [Fri, 12 Apr 2013 14:58:49 +0000 (15:58 +0100)]
Merge branch 'absolute_path_to_iptables_for_tests'
* absolute_path_to_iptables_for_tests:
Add an absolute path to iptables to make system tests pass
Ken Barber [Fri, 12 Apr 2013 14:32:32 +0000 (15:32 +0100)]
Add an absolute path to iptables to make system tests pass
Signed-off-by: Ken Barber <ken@bob.sh>
Ken Barber [Fri, 12 Apr 2013 12:48:56 +0000 (13:48 +0100)]
Merge branch '20125'
* 20125:
(#20125) Add persistence support for Archlinux platform
(#20125) Use PATH to find (ip|ip6|eb)tables for chain provider
(#20125) Use PATH to find (ip|ip6)tables for (ip|ip6)tables provider
(#20125) Add archlinux firewall class and unit test
Ingmar Steen [Mon, 8 Apr 2013 12:38:27 +0000 (14:38 +0200)]
(#20125) Add persistence support for Archlinux platform
This only works with facter 1.7.0-rc1 and up because os_key isn't
properly defined in facter 1.6.18 on Archlinux (it's set to Linux).
Ingmar Steen [Mon, 8 Apr 2013 12:32:02 +0000 (14:32 +0200)]
(#20125) Use PATH to find (ip|ip6|eb)tables for chain provider