Nan Liu [Wed, 9 May 2012 18:50:43 +0000 (11:50 -0700)]
Fix dependency issues introduced with anchor.
apt::ppa and apt::builddep requires apt class. The anchor introduced for
containment of apt-get update causes a dependency loop. apt::ppa appears
to depend on apt class sources.d direcory. While apt::builddep have no
clear reason for a dependency on apt class. This change refactor both
define type, so they no longer cause a dependency loop.
Dan Bode [Tue, 8 May 2012 18:07:46 +0000 (11:07 -0700)]
Merge pull request #57 from nanliu/tb/style
Fix style related issues in module.
Branan Purvine-Riley [Tue, 8 May 2012 17:18:52 +0000 (10:18 -0700)]
Add configuration for Travis CI
Nan Liu [Tue, 8 May 2012 17:47:43 +0000 (10:47 -0700)]
Fix style related issues in module.
Dan Bode [Mon, 7 May 2012 22:49:33 +0000 (15:49 -0700)]
Merge pull request #55 from nanliu/tb/containment
(#11966) apt module containment for apt_update.
Nan Liu [Mon, 7 May 2012 22:27:53 +0000 (15:27 -0700)]
(#11966) apt module containment for apt_update.
The update to separate Exec["apt-get update ${name}"] to single exec in
apt::update class resulted in apt-get update command to be dangled.
Previously if user specified Package['package_a'] <-
Apt::Resource['source_a'], the original refactor would no longer
guarantee apt-get update is executed before the package is installed.
This patch fixes the problem using the anchor resource and ensuring the
old behaviour is maintained and user can depend on apt-get update
command being invoked if they specify dependency on any apt::*
define resource type as well as the apt class.
Nan Liu [Fri, 4 May 2012 21:08:12 +0000 (14:08 -0700)]
Merge pull request #50 from branan/14221_forge_update
(#14221) update Modulefile for new release
Branan Purvine-Riley [Fri, 4 May 2012 21:05:57 +0000 (14:05 -0700)]
(#14221) update CHANGELOG for release
Branan Purvine-Riley [Thu, 3 May 2012 21:18:51 +0000 (14:18 -0700)]
(#14221) update Modulefile for new release
Branan Purvine-Riley [Fri, 4 May 2012 20:58:43 +0000 (13:58 -0700)]
Merge pull request #53 from nanliu/tb/14321
(#14321) apt::pin resource support release.
Nan Liu [Fri, 4 May 2012 20:56:35 +0000 (13:56 -0700)]
(#14321) apt::pin resource support release.
apt::pin release should default to title, but should be able to
override. This update removes unnecessary "" around $name, and add spec
tests.
Conflicts:
spec/defines/pin_spec.rb
albac [Sat, 28 Apr 2012 00:23:48 +0000 (21:23 -0300)]
Update manifests/pin.pp
Nan Liu [Fri, 4 May 2012 20:54:22 +0000 (13:54 -0700)]
Merge pull request #54 from branan/python-software-properties-in-apt-ppa
Move Package['python-software-properties'] to apt:ppa
Thomas Broyer [Mon, 2 Apr 2012 07:00:59 +0000 (09:00 +0200)]
Move Package['python-software-properties'] to apt:ppa
Also updates the apt-update in Apt::Ppa to use $apt::params::provider
instead of aptitude.
Branan Purvine-Riley [Fri, 4 May 2012 20:37:46 +0000 (13:37 -0700)]
Merge pull request #49 from nanliu/tb/11966
(#11966) Only invoke apt-get update once.
Nan Liu [Thu, 3 May 2012 22:44:17 +0000 (15:44 -0700)]
(#11966) Change apt update to apt_update.
Based on code review change exec from apt update to apt_update.
Nan Liu [Thu, 3 May 2012 17:22:49 +0000 (10:22 -0700)]
(#11966) Update apt::ppa to use apt::update.
Change apt::ppa define type to also use the apt::update class to invoke
apt-get update once.
Nan Liu [Fri, 4 May 2012 20:35:13 +0000 (13:35 -0700)]
(#11966) Only invoke apt-get update once.
Move apt-get update exec to a seperate class to minimize the number of
apt-get updates invoked by configuration changes.
* remove apt_update exec resource in apt class.
* remove apt-get-${name} in defines.
* apt::source notify Exec['apt update'].
* Remove dependency to Exec['apt_update'].
* fix rspec-puppet tests.
Conflicts:
manifests/source.pp
Branan Purvine-Riley [Fri, 4 May 2012 20:18:05 +0000 (13:18 -0700)]
Merge pull request #52 from nanliu/tb/14308
(#14308) Add ensure=>absent for define resource.
Nan Liu [Thu, 3 May 2012 23:59:13 +0000 (16:59 -0700)]
(#14308) Add ensure=>absent for define resource.
Several apt::* define resource type does not support ensurable. This
update allows ensure=>absent to support the removal of these
configuration files.
* apt::conf
* apt::pin
* apt::source
Dan Bode [Thu, 3 May 2012 22:23:15 +0000 (15:23 -0700)]
Merge pull request #51 from nanliu/tb/14299
(#14299) Resolve Modulefile name mismatch.
Nan Liu [Thu, 3 May 2012 21:55:16 +0000 (14:55 -0700)]
(#14299) Resolve Modulefile name mismatch.
The modulefile name is puppet-apt, but the module is released to forge
under puppetlabs. This causes a dependency confusion for puppet module
tool, which has been fixed by this patch.
Previous:
$ puppet module list
~/.puppet/modules
├── puppet-apt (v0.0.2)
├── puppetlabs-mongrodb (v0.0.1)
└── puppetlabs-stdlib (v2.3.1)
Now:
$ puppet module list
~/.puppet/modules
├── puppetlabs-apt (v0.0.2)
├── puppetlabs-mongrodb (v0.0.1)
└── puppetlabs-stdlib (v2.3.1)
Dan Bode [Thu, 3 May 2012 17:20:03 +0000 (10:20 -0700)]
Merge pull request #48 from nanliu/tb/lint
Cleanup apt-module puppet-lint related issues.
Nan Liu [Thu, 3 May 2012 16:51:14 +0000 (09:51 -0700)]
Cleanup apt-module puppet-lint related issues.
Dan Bode [Thu, 3 May 2012 05:20:08 +0000 (22:20 -0700)]
Merge pull request #47 from nanliu/master
(#14138) Fix spec test for aptitude changes.
Nan Liu [Thu, 3 May 2012 04:35:13 +0000 (21:35 -0700)]
(#14138) Fix spec test for aptitude changes.
Fix spec test related to apttitude update -> apt-get update change,
Nan Liu [Thu, 3 May 2012 00:31:57 +0000 (17:31 -0700)]
Merge pull request #41 from tbroyer/install-proxy-first
Make sure we configure the proxy before doing apt-get update.
Nan Liu [Thu, 3 May 2012 00:29:31 +0000 (17:29 -0700)]
Merge pull request #44 from relud/patch-1
(#14138) Modify apt::ppa's update-apt exec to use the ${apt::params::provider} parameter.
Nan Liu [Thu, 3 May 2012 00:27:12 +0000 (17:27 -0700)]
Merge pull request #42 from ody/sync_with_pl_ops
Sync with pl ops
Dan Bode [Wed, 2 May 2012 23:08:14 +0000 (16:08 -0700)]
Merge pull request #46 from nanliu/master
(#14287) Fix apt::pin resource for rspec-puppet.
Nan Liu [Wed, 2 May 2012 23:00:27 +0000 (16:00 -0700)]
(#14287) Fix apt::pin resource for rspec-puppet.
The shorthand syntax cause rspec-puppet failure for external modules
depending on the puppet-apt module. This patch uses the require
metaparameter to avoid this issue.
Daniel Thornton [Mon, 23 Apr 2012 20:40:24 +0000 (20:40 +0000)]
(#14138) Modify apt::ppa's update-apt exec to use the ${apt::params::provider} parameter rather than explicitly calling aptitude.
Previously the update-apt exec would always use /usr/bin/aptitude, which is not necessarily present. This change makes it use ${apt::params::provider} which defaults to /usr/bin/apt-get. This also adds some consistency so that ${apt::params::provider} is used everywhere.
Cody Herriges [Thu, 12 Apr 2012 00:49:30 +0000 (17:49 -0700)]
Tests to validate apt::{conf,backports}
This patch adds the appropriate spec tests to validate the changes
introduced by
e5f2dfe. As a bonus it includes fixes to the manifests
that were discovered while writing the tests.
Cody Herriges [Wed, 11 Apr 2012 21:54:13 +0000 (14:54 -0700)]
Adds apt::{conf,backports} and variable style.
With the addition of this patch two new defines will be added; one to
manage APT configuration files (apt::conf) and one that abstracts out the
requirements needed to turn on backport repositories (apt::backports).
In addition, the patch takes the opportunity to clean up variable
definitions so they follow a consistent pattern of setting local
variables to the fully qualified value stored in the apt::params
class. Previously all variable used within a class directly addressed
the apt::params namespace when ever the variable was used. In the
pattern they now adhere to we can more easily switch the namespace
data lives in or externalize it even more using hiera.
Thomas Broyer [Fri, 30 Mar 2012 15:48:31 +0000 (17:48 +0200)]
Make sure we configure the proxy before doing apt-get update.
Matthaus Litteken [Tue, 27 Mar 2012 00:44:53 +0000 (17:44 -0700)]
Merge pull request #39 from rcoleman/0.0.2_release
Updated CHANGELOG and Modulefile for 0.0.2
Ryan Coleman [Tue, 27 Mar 2012 00:01:54 +0000 (17:01 -0700)]
Updated CHANGELOG and Modulefile for 0.0.2
This commit updates both the Modulefile and CHANGELOG for the 0.0.2
Puppet Forge release.
Cody Herriges [Mon, 26 Mar 2012 23:46:24 +0000 (16:46 -0700)]
Merge pull request #36 from rcoleman/tickets/13261/improve_smoke_tests
Tickets/13261/improve smoke tests
Ryan Coleman [Tue, 20 Mar 2012 22:52:44 +0000 (15:52 -0700)]
(#13261) Add real examples to smoke tests.
This commit modifies some smoke tests with real-world usage examples
instead of providing things like 'foo' that the module user must
replace in order to conduct a smoke test or try out example functionality.
Ryan Coleman [Tue, 20 Mar 2012 21:55:01 +0000 (14:55 -0700)]
(#13261) Add key.pp smoke test
This commit adds a smoke test for key.pp, adding a key declaration
for the puppetlabs apt source.
Ryan Coleman [Tue, 20 Mar 2012 21:52:43 +0000 (14:52 -0700)]
(#13261) Replace foo source with puppetlabs source
Prior to this commit, the source.pp test included an apt source
named foo which broke the apt-get update exec when applied on a
target system. This commit removes it in favor of the puppetlabs
apt source which is valid on all target platforms.
Ryan Coleman [Tue, 20 Mar 2012 21:18:46 +0000 (14:18 -0700)]
Ignore pkg directory.
This commit modifies .gitingore to ignore changes to the pkg directory
used when building Forge releases.
Ryan Coleman [Fri, 23 Mar 2012 23:02:26 +0000 (16:02 -0700)]
Merge pull request #37 from kbarber/ticket/master/13289
Ticket/master/13289 Style violations & rspec cleanup
Ken Barber [Wed, 21 Mar 2012 13:35:48 +0000 (13:35 +0000)]
(#13289) Fix some more style violations
Ken Barber [Wed, 21 Mar 2012 13:21:50 +0000 (13:21 +0000)]
(#13289) Change test scaffolding to use a module & manifest dir fixture path
This removes the need for depending on a global site.pp, and depending on the
checked out apt module to be called 'apt' as well.
It pulls in stdlib via sub-modules as I don't have a better way to deal with
dependencies yet. It has pinned the revision for stdlib to 2.2.1 which is the
minimum required version for apt to work.
Ken Barber [Wed, 21 Mar 2012 13:20:13 +0000 (13:20 +0000)]
(#13289) Clean up style violations and fix corresponding tests
Ken Barber [Wed, 21 Mar 2012 13:19:05 +0000 (13:19 +0000)]
(#13289) Add puppet lint tests to Rakefile
Matthaus Litteken [Thu, 15 Mar 2012 07:24:03 +0000 (00:24 -0700)]
Merge pull request #34 from pdxcat/apt_key_should_be_case_insensitive
(#13125) Apt keys should be case insensitive
William Van Hevelingen [Wed, 14 Mar 2012 22:36:33 +0000 (15:36 -0700)]
(#13125) Apt keys should be case insensitive
Previously lowercase keys would be installed every
puppet run because apt-key list returns an uppercase
key. This commit makes the comparison case insensitive.
Matthaus Litteken [Thu, 15 Mar 2012 06:33:46 +0000 (23:33 -0700)]
Merge pull request #32 from pdxcat/convert_apt__key_to_use_anchors
Convert apt::key to use anchors
Ryan Coleman [Thu, 8 Mar 2012 02:46:13 +0000 (18:46 -0800)]
Merge pull request #33 from rcoleman/tickets/13016/create_CHANGELOG
(#13016) Add a CHANGELOG since first commit
Skipping the merge review rules on this harmless commit of a changelog.
Ryan Coleman [Thu, 8 Mar 2012 02:22:50 +0000 (21:22 -0500)]
(#13016) Add a CHANGELOG since first commit
Reid Vandewiele [Wed, 7 Mar 2012 21:49:12 +0000 (13:49 -0800)]
Convert apt::key to use anchors
Previously, apt::key used a noop exec hack to do exactly what anchors were
intended to be used for. This commit removes the exec hack and achieves the
same end using Anchor resources from the puppetlabs/stdlib module.
Nan Liu [Wed, 7 Mar 2012 19:24:21 +0000 (11:24 -0800)]
Merge pull request #31 from pdxcat/fix_release_parameter_test
Modify apt::source release verification to work correctly with puppet-rspec
Reid Vandewiele [Wed, 7 Mar 2012 18:10:46 +0000 (10:10 -0800)]
Modify apt::source release parameter test
This commit modifies the release parameter test in apt::source to work
correctly within puppet-rspec for edge-case resource definitions. Previously,
the test for the $release parameter was written as
`if ! $release { fail() }`
This commit updates the test to be written as
`if $release == undef { fail() }`
Additionally, the tests for correct behavior in the presence or absence of a
$release parameter have been beefed up.
The reason for making this change relates to examples such as the following
resource definition:
apt::source { "jenkins":
location => "http://pkg.jenkins-ci.org/debian",
release => "",
repos => "binary/",
key => "
D50582E6",
key_source => "http://pkg.jenkins-ci.org/debian/jenkins-ci.org.key",
include_src => false,
}
Note that the $release parameter is given as the empty string. In practice,
this is perfectly valid and everything will work great. However, it seems that
the empty string gets interpreted by something in puppet-rspec as something
equivalent to "False", and thus when testing, the above resource definition
would fail with "Puppet::Error: lsbdistcodename fact not available: release
parameter required" even though the $release parameter has been explicitely
specified (as the empty string).
See also: https://github.com/rtyler/puppet-jenkins/issues/9
Matthaus Litteken [Thu, 1 Mar 2012 23:10:54 +0000 (15:10 -0800)]
Merge pull request #30 from rcoleman/tickets/12917/add_contributors_to_readme
(#12917) Add contributors to README
Ryan Coleman [Thu, 1 Mar 2012 23:01:01 +0000 (15:01 -0800)]
(#12917) Add contributors to README
Prior to this commit, this modules README had no list of contributors.
This commit adds such a list and corrects a typo I overlooked on the
last pull request.
Ryan Coleman [Thu, 1 Mar 2012 22:40:44 +0000 (14:40 -0800)]
Merge pull request #26 from pdxcat/ticket_12823_aptkey_defined_type
(#12823) Add apt::key defined type and modify apt::source to use it
Reviewed and tested by Ryan Coleman (ryan@puppetlabs.com)
Reid Vandewiele [Fri, 24 Feb 2012 18:10:03 +0000 (10:10 -0800)]
(#12823) Add apt::key defined type and modify apt::source to use it
Adding this defined type allows puppet to add keys to the apt keystore without
needing to add a corresponding source; it also adds the "key_source" parameter
for wget'ing keys from arbitrary URLs, and allows for keys to be explicity
removed.
apt::key allows a key to be ensured present multiple times to account for
apt::source resources that all reference the same key. However, this means
that it is possible for a given key to be defined multiple times with
differing source parameters. e.g.
apt::key { "Add key:
4BD6EC30 from Apt::Source bunny":
key => "
4BD6EC30",
key_server => "pgp.mit.edu",
}
apt::key { "Add key:
4BD6EC30 from Apt::Source rabbit":
key => "
4BD6EC30",
key_server => "keyserver.ubuntu.com",
}
The defined type will accept both definitions and will create multiple exec
resources. This was deemed preferable to the alternative (creating only one
exec resource) in that one broken definition won't hose an entire catalog. If
one definition fails to install the key because of a bad "key_server", the
next apt::key that uses the key will get it done.
Ryan Coleman [Thu, 1 Mar 2012 21:37:51 +0000 (13:37 -0800)]
Merge pull request #27 from blkperl/ticket_12809_refactor_release
(#12809) $release should use $lsbdistcodename and fall back to manual in...
Reviewed and tested by Ryan Coleman (ryan@puppetlabs.com)
William Van Hevelingen [Fri, 24 Feb 2012 22:03:51 +0000 (14:03 -0800)]
(#12809) $release should use $lsbdistcodename and fall back to manual input
This commit changes $release to default to Facter's $lsbdistcodename
and fall back to a Parse Error if $release is not set and $lsbdistcodename
does not exist. Previously $release was hardcoded to karmic.
This commit also modifies apt::ppa to use $release and sets the
files to be ensured so that they are not purged when purge_sources_list_d
is set to true.
Ryan Coleman [Fri, 24 Feb 2012 19:20:52 +0000 (11:20 -0800)]
Merge pull request #23 from haus/python_properties
Check if python-software-properties is defined before attempting to define it.
Reviewed and tested by Ryan Coleman (ryan@puppetlabs.com)
Ryan Coleman [Fri, 24 Feb 2012 19:12:39 +0000 (11:12 -0800)]
Merge pull request #22 from haus/unique_required_packages
Allow duplicate required_packages between sources
Reviewed and tested by Ryan Coleman (ryan@puppetlabs.com)
Ryan Coleman [Fri, 24 Feb 2012 18:56:55 +0000 (10:56 -0800)]
Merge pull request #24 from haus/fix_source_key_tests
Fix source specs to test all key permutations
Reviewed and tested by Ryan Coleman (ryan@puppetlabs.com)
Matthaus Litteken [Fri, 24 Feb 2012 18:29:09 +0000 (10:29 -0800)]
Merge pull request #25 from rcoleman/ticket_12522_purge_option_take_2
(#12522) Split purge option to spare sources.list
Ryan Coleman [Fri, 24 Feb 2012 17:50:11 +0000 (09:50 -0800)]
(#12522) Adjust spec test for splitting purge
Now that the purge parameter is split into two, the spec test needs
adjusted. This commit makes that adjustment.
Ryan Coleman [Fri, 24 Feb 2012 17:27:28 +0000 (09:27 -0800)]
(#12522) Split purge option to spare sources.list
Prior to this commit, when using the purge option, unmanaged entries
in both /etc/apt/sources.list and sources.list.d would be purged.
This commit splits purge into purge_sources_list and purge_sources_list_d
which handle the purging of those items separately. Brief documentation on
each added to class documentation.
Matthaus Litteken [Fri, 24 Feb 2012 06:08:39 +0000 (22:08 -0800)]
Fix source specs to test all key permutations
Previously only one should in each block was being evaluated. This moves each
should to its own block so that all values are tested. It also adds another set
of params so that all useful permutations of key, key_server, and key_content
are generated. It also replaces the previous ternary assignment for param_set
with a hash merge.
Matthaus Litteken [Fri, 24 Feb 2012 05:40:42 +0000 (21:40 -0800)]
Add test for python-software-properties package
This test adds the precondition that the python-software-packages package be
installed before the apt class is synced. If the defined function were not
called around the package resource, this test would fail with a duplicate
package resource error.
Peter Drake [Fri, 13 Jan 2012 15:40:41 +0000 (10:40 -0500)]
Check if python-software-properties is defined before attempting to define it.
Matthaus Litteken [Fri, 24 Feb 2012 05:04:57 +0000 (21:04 -0800)]
Add tests for required_packages change
This updates the tests for the apt::source defined type to use the new name for
the exec resource and the new parameter for the same exec.
Matthaus Litteken [Fri, 24 Feb 2012 05:01:20 +0000 (21:01 -0800)]
Allow duplicate $required_packages
Previously, if more than one apt::source required the same packages to be
installed it would fail with a duplicate exec resource. This adds the name of
the source resource to the exec and gives the exec a name, moving it to a
command parameter for the exec.
Matthaus Litteken [Fri, 24 Feb 2012 04:54:10 +0000 (20:54 -0800)]
Merge branch 'allow-same-key'
Matthaus Litteken [Fri, 24 Feb 2012 04:51:27 +0000 (20:51 -0800)]
(#12430) Add tests for changes to apt module
This update reflects the changes to the apt module to allow duplicate keys. It
mostly involves tests for changes to the resource names to make them unique
between defines.
Christian G. Warden [Thu, 23 Feb 2012 23:44:26 +0000 (15:44 -0800)]
Test two sources with the same key
Ryan Coleman [Thu, 23 Feb 2012 22:55:55 +0000 (14:55 -0800)]
Merge pull request #17 from blkperl/ticket_12526_apt_disable_keys
(#12526) Add ability to reverse apt { disable_keys => true }
Reviewed by Ryan Coleman (ryan@puppetlabs.com)
William Van Hevelingen [Fri, 10 Feb 2012 00:18:14 +0000 (16:18 -0800)]
(#12526) Add ability to reverse apt { disable_keys => true }
The setting `disable_keys => true` parameter in the apt module creates
/etc/apt/apt.conf.d/99unauth with the contents
"APT::Get::AllowUnauthenticated 1;". Changing `disable_keys`
does not remove this file. This patch makes it so that
`disable_keys => false` will remove /etc/apt/apt.conf.d/99unauth.
Ryan Coleman [Thu, 23 Feb 2012 22:31:45 +0000 (14:31 -0800)]
Merge pull request #20 from blkperl/ticket_12522_purge_option
(#12522) Adding purge option to apt class
Reviewed by Ryan Coleman
William Van Hevelingen [Thu, 23 Feb 2012 22:05:25 +0000 (14:05 -0800)]
Merge pull request #1 from rcoleman/ticket_12522_purge_option
Add Modulefile to puppet-apt
Ryan Coleman [Thu, 23 Feb 2012 22:01:31 +0000 (14:01 -0800)]
Add Modulefile to puppet-apt
Now that puppet-apt depends on puppetlabs-stdlib, an explicit
dependency is required. Modulefile was entirely missing. This commit
adds on.
Christian G. Warden [Tue, 14 Feb 2012 19:40:29 +0000 (11:40 -0800)]
Allow the use of the same key in multiple sources
Allow the use of the same key in multiple sources by including the name
of the source in the declaration for the exec which adds the key.
William Van Hevelingen [Wed, 8 Feb 2012 19:40:09 +0000 (11:40 -0800)]
(#12522) Adding purge option to apt class
Adds a purge option to the apt class to remove repositories
that are not managed by apt::source
Matthaus Litteken [Mon, 13 Feb 2012 18:02:50 +0000 (10:02 -0800)]
Merge pull request #18 from bodepd/apt_proxy_tests
(#12529) Add unit test for apt proxy settings
Dan Bode [Mon, 13 Feb 2012 17:58:30 +0000 (09:58 -0800)]
(#12529) Add unit test for apt proxy settings
This commit adds unit tests to validate that the
apt proxy is configured as expected when the class
parameter proxy_host is set as a class parameter for
the apt class.
Ken Barber [Wed, 8 Feb 2012 23:20:32 +0000 (15:20 -0800)]
Merge pull request #15 from bodepd/proxysupport
(#12529) Add parameter to support setting a proxy for apt
Dan Bode [Wed, 8 Feb 2012 17:40:43 +0000 (09:40 -0800)]
(#12529) Add parameter to support setting a proxy for apt
This commit adds two class parameter to apt that can be used to
specify a proxy to use with apt.
- proxy_host
- proxy_port
Dan Bode [Wed, 8 Feb 2012 17:44:38 +0000 (09:44 -0800)]
Merge pull request #14 from haus/ticket/12094_add_spec_tests
Ticket/12094 add spec tests
Matthaus Litteken [Sat, 4 Feb 2012 01:24:09 +0000 (17:24 -0800)]
(#12094) Replace chained .with_* with a hash
The hash passing to the with method is cleaner and closer to puppet code, so
all of the with_$param have been replaced with with($hash). This also
includes two minor whitspace changes to unstable.pp and source.pp.
This also replaces the ternary switch on param_set with a hash merge,
which is cleaner and will support more use cases.
Matthaus Litteken [Mon, 23 Jan 2012 21:13:17 +0000 (13:13 -0800)]
(#12094) Remove deprecated spec.opts file
Rspec no longer uses the spec.opts file, and this particular file also uses
options for rspec that are no longer honored or available, like loadby. So this
commit removes the file. Users that want to customize rspec behavior should use
a .rspec file in the repository root or in their home directory.
Matthaus Litteken [Mon, 23 Jan 2012 21:08:00 +0000 (13:08 -0800)]
(#12094) Add rspec-puppet tests for apt
This commit adds full coverage for the apt module as it currently exists. It
adds rspec-puppet tests for the defines (apt::builddep, apt::force, apt::pin,
apt::ppa, apt::source) and classes (apt, debian::testing, debian::unstable,
apt::params, apt::release).
Matthaus Litteken [Mon, 23 Jan 2012 21:05:59 +0000 (13:05 -0800)]
(#12094) Replace name with path in file resources
When the name is used with a file resource, it becomes difficult to test the
resource using rspec-puppet, as the name parameter gets aliased to path. So to
maintain consistency between tests and manifests, this replaces all name
parameters in file resources with the equivalent path parameter.
Dan Bode [Mon, 16 Jan 2012 05:47:45 +0000 (21:47 -0800)]
Merge pull request #4 from webfactory/pin_before_source
Suggested fix for #10449
Dan Bode [Sat, 14 Jan 2012 01:17:15 +0000 (17:17 -0800)]
Merge pull request #12 from haus/11953_fix_apt_force_version
(#11953) Apt::force passes $version to aptitude
Matthaus Litteken [Fri, 13 Jan 2012 23:29:47 +0000 (15:29 -0800)]
(#11953) Apt::force passes $version to aptitude
Previously, even if $version were passed to apt::force, aptitude would just
install the default version of the package available. This updates the aptitude
call to use the version string if it exists. If no version is passed, or if it
is false, no version is added to the aptitude call. This also updates the
rspec-puppet tests for the define, to reflect the changes to the exec.
Matthaus Litteken [Fri, 13 Jan 2012 23:09:45 +0000 (15:09 -0800)]
Merge pull request #11 from bodepd/11413_apt_force_query_fix
11413 apt force query fix
Dan Bode [Fri, 13 Jan 2012 20:25:42 +0000 (12:25 -0800)]
Merge pull request #8 from cwarden/source-example-improvement
include_src parameter in example; Whitespace cleanup
Dan Bode [Fri, 13 Jan 2012 19:02:42 +0000 (11:02 -0800)]
(#11413) Add spec test for apt::force to verify changes to unless
In the Previous commits, the query being done by the
apt::force install command was not strict enough and
could lead to false positives.
These queries represented by the unless parameter have been
resolved in another commit. This commit accompanies that commit
and adds basic unit tests to correspond to the changes.
Matthias Pigulla [Thu, 15 Dec 2011 14:52:21 +0000 (15:52 +0100)]
(#11413) Update dpkg query used by apt::force
This patch fixes the query used by apt::force to
determine rather or not the package is installed.
Previously, the expression was not specific enough and
could not lead to false positives in cases where a package
name is contained within another package name (puppet could be
incorrectly determined as being installed if puppet-common is
installed)
This commit resolves that by improving the query expression.
Matthaus Litteken [Wed, 4 Jan 2012 18:30:31 +0000 (10:30 -0800)]
Merge pull request #9 from bodepd/10451_fix_apt_update_refresh
10451 fix apt update refresh
Dan Bode [Wed, 4 Jan 2012 01:03:24 +0000 (17:03 -0800)]
(#10451) Add test coverage to apt::ppa
This commit adds test coverage for apt::ppa.
This test coverage is suficient to verify the
code changes that resolve the issue with
aptitude update not being called when ppas were
added (#10451).