]> review.fuel-infra Code Review - openstack-build/neutron-build.git/log
openstack-build/neutron-build.git
9 years agoMerge "Add missing tenant_id validation in RESOURCE_ATTRIBUTE_MAP"
Jenkins [Fri, 21 Aug 2015 00:48:30 +0000 (00:48 +0000)]
Merge "Add missing tenant_id validation in RESOURCE_ATTRIBUTE_MAP"

9 years agoMerge "Sync FK constraints in db models with migration scripts"
Jenkins [Fri, 21 Aug 2015 00:48:17 +0000 (00:48 +0000)]
Merge "Sync FK constraints in db models with migration scripts"

9 years agoMerge "Graceful ovs-agent restart"
Jenkins [Fri, 21 Aug 2015 00:47:55 +0000 (00:47 +0000)]
Merge "Graceful ovs-agent restart"

9 years agoMerge "Setup firewall filters only for required ports"
Jenkins [Fri, 21 Aug 2015 00:36:42 +0000 (00:36 +0000)]
Merge "Setup firewall filters only for required ports"

9 years agoMerge "Add EnvironmentDescription, pass it down"
Jenkins [Thu, 20 Aug 2015 21:34:42 +0000 (21:34 +0000)]
Merge "Add EnvironmentDescription, pass it down"

9 years agoMerge "Python 3: encode or decode i/o data of Popen.communicate()"
Jenkins [Thu, 20 Aug 2015 21:34:27 +0000 (21:34 +0000)]
Merge "Python 3: encode or decode i/o data of Popen.communicate()"

9 years agoMerge "Unskip firewall test"
Jenkins [Thu, 20 Aug 2015 18:21:34 +0000 (18:21 +0000)]
Merge "Unskip firewall test"

9 years agoMerge "Fix _ensure_default_security_group logic"
Jenkins [Thu, 20 Aug 2015 18:21:19 +0000 (18:21 +0000)]
Merge "Fix _ensure_default_security_group logic"

9 years agoMerge "Add a fullstack fake VM, basic connectivity test"
Jenkins [Thu, 20 Aug 2015 16:47:23 +0000 (16:47 +0000)]
Merge "Add a fullstack fake VM, basic connectivity test"

9 years agoMerge "Add logging to debug oslo.messaging failure"
Jenkins [Thu, 20 Aug 2015 15:48:29 +0000 (15:48 +0000)]
Merge "Add logging to debug oslo.messaging failure"

9 years agoSync FK constraints in db models with migration scripts
Jakub Libosvar [Thu, 20 Aug 2015 12:33:59 +0000 (12:33 +0000)]
Sync FK constraints in db models with migration scripts

We do have a functional test that compares Neutron's db models with
migration scripts. The comparison is based on alembic library that had a
bug which is gonna be solved in the next release [1]. Once we start
using newer alembic, functional test mentioned above will start failing
due to models and scripts are not in sync.

This patch adds needed constraints discovered by running functional test
locally with dev version of alembic.

Note: There is already a patch [2] that fixes QoS.

[1] https://bitbucket.org/zzzeek/alembic/issues/317
[2] https://review.openstack.org/#/c/214215/

Change-Id: I0d0bddb05f543365d09e592bd81759534de49367
Closes-Bug: 1486936

9 years agoAdd EnvironmentDescription, pass it down
John Schwarz [Sun, 9 Aug 2015 14:00:57 +0000 (17:00 +0300)]
Add EnvironmentDescription, pass it down

* The EnvironmentDescription class describes an entire fullstack
  environment (as opposed to the currently implemented host-only
  descriptions). This will allow future patches to signify that a test
  should set up an environment that supports tunneling, l2pop, QoS and
  more.
* Now, most fullstack fixtures (config and process ones, at least),
  expect both the EnvironmentDescription for the current test and the
  HostDescription for the 'host' the config/process is on. This allows
  for easier and most robust future changes, as now adding a new
  parameter to one of the description objects doesn't mean adding that
  argument to a number of other objects which are using it.
* Changed HostDescription's default argument of l3_agent to False, since
  adding new configurations and defualting them to True forces the
  author to go through ALL the tests and explicitly turn them on/off.
  However, defaulting new configurations to False only requires
  explicitly turning them on, which we ought to do anyway.

Change-Id: Ib2f12016ba4371bfda76c82e11d0794acc759955

9 years agoMerge "Minor typo fix"
Jenkins [Thu, 20 Aug 2015 11:03:33 +0000 (11:03 +0000)]
Merge "Minor typo fix"

9 years agoFix _ensure_default_security_group logic
Eugene Nikanorov [Sat, 18 Jul 2015 23:17:43 +0000 (03:17 +0400)]
Fix _ensure_default_security_group logic

In a case when first attempt to fetch default security group
fails and attempt to add it fails too due to a concurrent insertion,
later attempt to fetch the same default sg may fail due to
REPEATABLE READ transaction isolation level.
For this case RetryRequest should be issued to restart the
whole transaction and be able to see default group.

The patch also removes 'while True' logic as it's unsafe

Closes-Bug: #1475938
Change-Id: I20f65d3eae9421429aced1f4586cb6988ab577ff

9 years agoAdd missing tenant_id validation in RESOURCE_ATTRIBUTE_MAP
Yalei Wang [Wed, 19 Aug 2015 16:09:04 +0000 (00:09 +0800)]
Add missing tenant_id validation in RESOURCE_ATTRIBUTE_MAP

This patch will add the validation for tenant_id of 255 bytes string.

Change-Id: Iaa8f78d2b70693d3365a41834d29e0f12ad3dd36
Closes-Bug: #1486314

9 years agoGraceful ovs-agent restart
Eugene Nikanorov [Sun, 10 May 2015 23:10:29 +0000 (03:10 +0400)]
Graceful ovs-agent restart

When agent is restarted it drops all existing flows. This
breaks all networking until the flows are re-created.

This change adds an ability to drop only old flows.
Agent_uuid_stamp is added for agents. This agent_uuid_stamp is set as
cookie for flows and then flows with stale cookies are deleted during
cleanup.

Co-Authored-By: Ann Kamyshnikova<akamyshnikova@mirantis.com>
Closes-bug: #1383674

DocImpact

Change-Id: I95070d8218859d4fff1d572c1792cdf6019dd7ea

9 years agoMerge "Final decomposition of ML2 Cisco UCSM driver"
Jenkins [Thu, 20 Aug 2015 04:42:41 +0000 (04:42 +0000)]
Merge "Final decomposition of ML2 Cisco UCSM driver"

9 years agoMerge "Fix tenant access to qos policies"
Jenkins [Thu, 20 Aug 2015 02:16:57 +0000 (02:16 +0000)]
Merge "Fix tenant access to qos policies"

9 years agoMerge "DVR: fix router rescheduling on agent side"
Jenkins [Thu, 20 Aug 2015 00:03:33 +0000 (00:03 +0000)]
Merge "DVR: fix router rescheduling on agent side"

9 years agoMerge "Fix query in get_reservations_for_resources"
Jenkins [Wed, 19 Aug 2015 20:14:48 +0000 (20:14 +0000)]
Merge "Fix query in get_reservations_for_resources"

9 years agoAdd a fullstack fake VM, basic connectivity test
Assaf Muller [Fri, 12 Jun 2015 19:07:17 +0000 (15:07 -0400)]
Add a fullstack fake VM, basic connectivity test

* Full stack tests' fake VMs are represented via a namespace,
  MAC, IP address and default gateway. They're plugged to an OVS
  bridge via an OVS internal port. As opposed to the current
  fake machine class used in functional testing, this new fake
  machine also creates a Neutron port via the API and sets the
  IP and MAC according to it. It also sets additional attributes
  on the OVS port to allow the OVS agent to do its magic.
* The functional fake machine and the full stack fake machine
  should continue to share commonalities.
* The fullstack fake machine currently takes the IP address
  from the port and statically assigns it to the namespace
  device. Later when I'll add support for the DHCP agent
  in full stack testing this assignment will look for the dhcp
  attribute of the subnet and either assign the IP address
  via 'ip' or call a dhcp client.
* Added a basic L2 connectivity test between two such machines
  on the same Neutron network.
* OVSPortFixture now uses OVSInterfaceDriver to plug the port
  instead of replicate a lot of the code. I had to make a
  small change to _setup_arp_spoof_for_port since all OVS ports
  are now created with their external-ids set.

Change-Id: Ib985b7e742f58f1a6eb6fc598df3cbac31046951

9 years agoFinal decomposition of ML2 Cisco UCSM driver
Sandhya Dasu [Mon, 17 Aug 2015 10:26:53 +0000 (06:26 -0400)]
Final decomposition of ML2 Cisco UCSM driver

The ML2 Cisco UCSM driver's entry point is being switched to the
networking-cisco vendor repo. The definition of the driver's db
file and all references to it in the neutron branch are removed.

Change-Id: I75eb165f3bb78d31bece26762ca0ff47cab2b79b
Implements: blueprint: core-vendor-decomposition
Closes-bug: #1484165

9 years agoMerge "Support delegation of bind_port to networking-odl backend driver."
Jenkins [Wed, 19 Aug 2015 15:28:01 +0000 (15:28 +0000)]
Merge "Support delegation of bind_port to networking-odl backend driver."

9 years agoFix query in get_reservations_for_resources
Ann Kamyshnikova [Wed, 19 Aug 2015 11:19:11 +0000 (14:19 +0300)]
Fix query in get_reservations_for_resources

For PostgreSQL if you're using GROUP BY everything in the SELECT
list must be an aggregate SUM(...) or used in the GROUP BY.
For reference:
http://www.postgresql.org/message-id/200402271700.28133.dev@archonet.com
Closes-bug: #1486467

Change-Id: Ieb4ead5c785ff17f580bfbc58f370a491733d96d

9 years agoFix tenant access to qos policies
Miguel Angel Ajo [Tue, 18 Aug 2015 06:35:00 +0000 (08:35 +0200)]
Fix tenant access to qos policies

fix policy.json to not allow tenants to create policies or rules
by default and allow tenants attach ports and networks to policies,
please note that policy access is checked in the QoSPolicy neutron
object in such case.

Closes-Bug: #1485858

Change-Id: Ide1cd30979f99612fe89dddf3dc0e029d3f4d34a

9 years agoMerge "Update sub projects git urls"
Jenkins [Wed, 19 Aug 2015 02:01:05 +0000 (02:01 +0000)]
Merge "Update sub projects git urls"

9 years agoMerge "Stop using quota reservations on base controller"
Jenkins [Wed, 19 Aug 2015 01:26:33 +0000 (01:26 +0000)]
Merge "Stop using quota reservations on base controller"

9 years agoMerge "Final decomposition of ML2 Nexus Driver"
Jenkins [Wed, 19 Aug 2015 01:22:59 +0000 (01:22 +0000)]
Merge "Final decomposition of ML2 Nexus Driver"

9 years agoMerge "Redundant tests removed from ovs-lib unit tests:"
Jenkins [Wed, 19 Aug 2015 00:55:38 +0000 (00:55 +0000)]
Merge "Redundant tests removed from ovs-lib unit tests:"

9 years agoUpdate sub projects git urls
Cedric Brandily [Tue, 18 Aug 2015 21:56:32 +0000 (23:56 +0200)]
Update sub projects git urls

Some sub projects[1] have been moved from stackforge to openstack
namespace. This change updates their git repo urls.

[1] networking-arista/cisco/plumgrid

Change-Id: I0847c3ff9e73508420ae67b432ad1e3654d07b6a

9 years agoMerge "Updated from global requirements"
Jenkins [Tue, 18 Aug 2015 21:51:27 +0000 (21:51 +0000)]
Merge "Updated from global requirements"

9 years agoMerge "Python 3: fix test_utils"
Jenkins [Tue, 18 Aug 2015 21:00:13 +0000 (21:00 +0000)]
Merge "Python 3: fix test_utils"

9 years agoMerge "Python 3: fix neutron.tests.unit.api.test_extensions"
Jenkins [Tue, 18 Aug 2015 20:57:03 +0000 (20:57 +0000)]
Merge "Python 3: fix neutron.tests.unit.api.test_extensions"

9 years agoMerge "Fix some issues around tempest in fullstack testing doc"
Jenkins [Tue, 18 Aug 2015 20:56:51 +0000 (20:56 +0000)]
Merge "Fix some issues around tempest in fullstack testing doc"

9 years agoMerge "Remove line number of link and useless link"
Jenkins [Tue, 18 Aug 2015 20:56:38 +0000 (20:56 +0000)]
Merge "Remove line number of link and useless link"

9 years agoMerge "Disable port creation when invalid MAC address is provided"
Jenkins [Tue, 18 Aug 2015 20:56:25 +0000 (20:56 +0000)]
Merge "Disable port creation when invalid MAC address is provided"

9 years agoMerge "Fix gateway port could not retrieve for subnet"
Jenkins [Tue, 18 Aug 2015 20:51:35 +0000 (20:51 +0000)]
Merge "Fix gateway port could not retrieve for subnet"

9 years agoStop using quota reservations on base controller
Salvatore Orlando [Tue, 18 Aug 2015 17:01:50 +0000 (10:01 -0700)]
Stop using quota reservations on base controller

The reservation engine is subject to failures due to concurrency;
the switch to pymysql is likely to also have a part in observed
failures. While no gate failures have been observed so far, this
is a time bomb waiting to explode and must be addressed.

For this reason this patch acts conservatively by ensuring the
API controllers do not use anymore reservation. The code for
reservation management is preserved, and will wired again on the
controller when these issues are sorted.

The devref for neutron quotas is updated accordingly as a part
of this patch.

Related bug: #1486134

Change-Id: I2a95fef0fdf64ef8781bef99be0fdc743346c17a

9 years agoFinal decomposition of ML2 Nexus Driver
Carol Bouchard [Fri, 14 Aug 2015 17:39:45 +0000 (13:39 -0400)]
Final decomposition of ML2 Nexus Driver

This changeset removes the remaining ML2 Nexus Driver Vendor
code from the neutron repo.  It has been moved to  the
networking-cisco repo.

Change-Id: I95540f35f80ad8eba4bc3f6fa37095842e42c037
Closes-bug:  #1482366
Implements:  blueprint: core-vendor-decomposition

9 years agoMerge "Quota enforcement: python3 compatibility"
Jenkins [Tue, 18 Aug 2015 14:19:21 +0000 (14:19 +0000)]
Merge "Quota enforcement: python3 compatibility"

9 years agoDVR: fix router rescheduling on agent side
Oleg Bondarev [Tue, 7 Jul 2015 10:36:00 +0000 (13:36 +0300)]
DVR: fix router rescheduling on agent side

The patch makes L3 agent aware of possible SNAT role
rescheduling to/from it.
The gist is to compare gw_port host change.
If it was changed and agent is not on target host then
it needs to clear snat namespace if one exists. If agent
is on target host it needs to create snat namespace from
scratch if it doesn't exist.

Host field was excluded from gw_port comparison on
agent side as part of HA Router feature implementation.
This code was moved to corresponding module.

Closes-Bug: #1472205
Change-Id: I840bded9eb547df014c6fb2b4cbfe4a876b9b878

9 years agoPython 3: fix test_utils
Cyril Roelandt [Fri, 14 Aug 2015 12:40:51 +0000 (14:40 +0200)]
Python 3: fix test_utils

In Python 3, the error message returned when unpacking too many values is a bit
different from the one we see in Python 2:

Python 2:
  ValueError: too many values to unpack

Python 3:
  ValueError: too many values to unpack (expected <number of values>)

Blueprint: neutron-python3
Change-Id: Ib607a526c007567a370c521fd7e2e4f8b504b934

9 years agoMerge "doc: Improve table rendering using multi-row cells"
Jenkins [Tue, 18 Aug 2015 12:52:32 +0000 (12:52 +0000)]
Merge "doc: Improve table rendering using multi-row cells"

9 years agoMerge "Devref for quotas"
Jenkins [Tue, 18 Aug 2015 11:26:53 +0000 (11:26 +0000)]
Merge "Devref for quotas"

9 years agoAdd logging to debug oslo.messaging failure
Doug Hellmann [Fri, 14 Aug 2015 22:30:46 +0000 (22:30 +0000)]
Add logging to debug oslo.messaging failure

It looks like recent changes to oslo.messaging master are conflicting
with changes in neutron master with the way RPC services are started
when the rpc_workers value == 0.

Change-Id: Iea2197ad0ea9ceb9a2a850a9e03e53b4b39ca288

9 years agoMerge "Reservations support"
Jenkins [Tue, 18 Aug 2015 09:00:53 +0000 (09:00 +0000)]
Merge "Reservations support"

9 years agoMerge "Get rid of exception converter in db/api.py"
Jenkins [Tue, 18 Aug 2015 07:18:35 +0000 (07:18 +0000)]
Merge "Get rid of exception converter in db/api.py"

9 years agoSetup firewall filters only for required ports
Sudhakar Babu Gariganti [Fri, 7 Aug 2015 10:37:12 +0000 (16:07 +0530)]
Setup firewall filters only for required ports

We can skip trying to setup firewall filters for ports which are
having port_security_enabled as False or which are not associated
to any security group.

Closes-Bug: #1482554

Change-Id: Ie65201308d93c746fe4ef38f402ec300227b7d27

9 years agoMerge "Rename function '_update_port_down'"
Jenkins [Tue, 18 Aug 2015 06:37:54 +0000 (06:37 +0000)]
Merge "Rename function '_update_port_down'"

9 years agoUpdated from global requirements
OpenStack Proposal Bot [Tue, 18 Aug 2015 01:35:13 +0000 (01:35 +0000)]
Updated from global requirements

Change-Id: I7c2244869509221deb0cee47b215ac66eccf1f2b

9 years agoMerge "Fix .gitreview to not point at a branch"
Jenkins [Tue, 18 Aug 2015 01:29:25 +0000 (01:29 +0000)]
Merge "Fix .gitreview to not point at a branch"

9 years agoMerge "Use a conntrack zone per port in OVS"
Jenkins [Tue, 18 Aug 2015 01:23:10 +0000 (01:23 +0000)]
Merge "Use a conntrack zone per port in OVS"

9 years agoMerge "DVR: fix router rescheduling on server side"
Jenkins [Tue, 18 Aug 2015 01:21:10 +0000 (01:21 +0000)]
Merge "DVR: fix router rescheduling on server side"

9 years agoMerge "DVR: do not reschedule router for down agents on compute nodes"
Jenkins [Tue, 18 Aug 2015 01:20:34 +0000 (01:20 +0000)]
Merge "DVR: do not reschedule router for down agents on compute nodes"

9 years agoMerge "Add dashboard folder and graphite dashboard to doc"
Jenkins [Tue, 18 Aug 2015 01:15:54 +0000 (01:15 +0000)]
Merge "Add dashboard folder and graphite dashboard to doc"

9 years agoMerge "Don't fatal error during initialization for missing service providers"
Jenkins [Tue, 18 Aug 2015 01:12:22 +0000 (01:12 +0000)]
Merge "Don't fatal error during initialization for missing service providers"

9 years agoMerge "NSX: Move DB models as part of core vendor decomposition"
Jenkins [Tue, 18 Aug 2015 01:09:00 +0000 (01:09 +0000)]
Merge "NSX: Move DB models as part of core vendor decomposition"

9 years agoQuota enforcement: python3 compatibility
Salvatore Orlando [Tue, 21 Jul 2015 10:52:09 +0000 (03:52 -0700)]
Quota enforcement: python3 compatibility

This patch does a simple fix to the quota DB driver in order
to ensure its compatibility with python3 and adds the quota
enforcement unit tests to the list of those executed as a part
of the py34 test environment.

Change-Id: I9b5601632866e1fb42f860d1cca5f77b5f14f2c8
Related-blueprint: better-quotas

9 years agoDevref for quotas
Salvatore Orlando [Mon, 18 May 2015 00:43:38 +0000 (17:43 -0700)]
Devref for quotas

This patch adds developer documentation for quota management
and enforcement.

Partially-Implements blueprint better-quotas

Change-Id: Ia990484caf6f5818104109e3d28e2990b9347726

9 years agoReservations support
Salvatore Orlando [Thu, 12 Mar 2015 00:28:43 +0000 (17:28 -0700)]
Reservations support

Add the concept of resource reservation in neutron.
Usage tracking logic is also updated to support reservations.
Reservations are not however available with the now deprecated
configuration-based quota driver.

The base API controller will now use reservations to perform
quota checks rather than counting resource usage and then
invoking the limit_check routine.

The limit_check routine however has not been removed and
depreacated as a part of this patch. In order to ensure all
quota drivers expose a consistent interface, a
make_reservation method has been added to the configuration
based driver as well. This method simply performs "old-style"
limit checks by counting resource usage and then invoking
limit_check.

DocImpact

Implements blueprint better-quotas.

Change-Id: Ifea07f461def564884af5b291c8a56655a4d818b

9 years agoMerge "Break down _bind_port_if_needed in ML2"
Jenkins [Mon, 17 Aug 2015 19:51:52 +0000 (19:51 +0000)]
Merge "Break down _bind_port_if_needed in ML2"

9 years agoFix .gitreview to not point at a branch
Doug Wiegley [Mon, 17 Aug 2015 19:51:51 +0000 (13:51 -0600)]
Fix .gitreview to not point at a branch

Change-Id: I072e5867965565908bdacf3ada9855d686060fad

9 years agoDon't fatal error during initialization for missing service providers
Doug Wiegley [Mon, 17 Aug 2015 15:17:46 +0000 (09:17 -0600)]
Don't fatal error during initialization for missing service providers

Sometime during the split, code was added to fixup driver paths,
which imports service providers even for plugins which are not
in use. That, combined with neutron including default service
providers for VPN and LOADBALANCER, resulted in a really messy
mess in terms of removing VPN from the main neutron test suites.

This change stops the imports, so that if one of the services is
missing, neutron server can still start. It likely breaks the driver
path fixup, which can be fixed outside of this gate blockage.

Closes-Bug: #1483266
Change-Id: I23f9007357d8cbbae599997c244561a4e2f32ce1

9 years agoNSX: Move DB models as part of core vendor decomposition
Abhishek Raut [Mon, 10 Aug 2015 16:54:05 +0000 (09:54 -0700)]
NSX: Move DB models as part of core vendor decomposition

This patch removes the database models from neutron repo.
Also removes README, common modules and plugin module.

Change-Id: I5d5b0acf34417889c2a449f22b92fd105697d90d
Related-Blueprint: core-vendor-decomposition
Partial-bug: #1483453

9 years agoMerge "Preserve DVR FIP rule priority over Agent restarts"
Jenkins [Mon, 17 Aug 2015 18:50:08 +0000 (18:50 +0000)]
Merge "Preserve DVR FIP rule priority over Agent restarts"

9 years agoMerge "Merge remote-tracking branch 'origin/feature/qos' into merge-branch"
Jenkins [Mon, 17 Aug 2015 18:49:56 +0000 (18:49 +0000)]
Merge "Merge remote-tracking branch 'origin/feature/qos' into merge-branch"

9 years agoMerge "NSX plugin: Moving away plugin extensions"
Jenkins [Mon, 17 Aug 2015 18:49:02 +0000 (18:49 +0000)]
Merge "NSX plugin: Moving away plugin extensions"

9 years agoMerge remote-tracking branch 'origin/feature/qos' into merge-branch
Ihar Hrachyshka [Mon, 17 Aug 2015 11:05:32 +0000 (13:05 +0200)]
Merge remote-tracking branch 'origin/feature/qos' into merge-branch

Note to reviewers: gerrit diff for merge patches is very limited, and
leaving comments in global section won't scale, so please comment here:

https://etherpad.openstack.org/p/qos-merge-back-review

This merge commit introduces QoS feature into Liberty release of
Neutron.

The feature is documented in: doc/source/devref/quality_of_service.rst
included with the merge patch.

It includes:

- QoS API service plugin with QoS policy and QoS bandwidth limit
  (egress) rule support;
- core plugin mechanism to determine supported rule types, with its ML2
  implementation;
- new agent extension manager;
- QoS agent extension with pluggable backend QoS drivers (Open vSwitch
  and SR-IOV support is included).

To extend network and port core resources with qos_policy_id attribute,
a new ML2 extension driver (qos) was introduced that relies on the QoS
core resource extension (the idea is that eventually we'll get a core
resource extension manager that can be directly reused by core plugins).

Agent-server interaction is based on:

- get_device_details() method that is extended with qos_policy_id;
- a new push/pull mechanism that allows agents and servers to
  communicate using oslo.versionedobjects based objects sent on the
  wire.

The merge includes the following types of test coverage:

- unit tests;
- functional tests for OVS agent, QoS agent extension, and low level
  ovs_lib changes;
- API tests to cover port/network qos_policy_id attribute and new QoS
  resources.

The client changes can be found at:

* https://review.openstack.org/189655
* https://review.openstack.org/198277

The team also prepared fullstack test but it needs to wait for client
merge before it can pass in the gate:

* https://review.openstack.org/202492

Gerrit does not show diff for merge changes that did not result in any
conflict, so to facilitate review, rely on the following steps:

- fetch the patch locally
- git fetch origin
- git diff origin/master...

This merge also disables qos extension API tests until the service is
enabled in master gate.

Local changes apart from conflicts:
- updated down_revision for qos migration to reflect master expand head;
- disabled qos API tests with gate_hook.sh until we have it enabled in
  master gate;
- bumped oslo.versionedobjects requirement to reflect what is in
  openstack/requirements' global-requirements.txt

DocImpact
APIImpact
Partially-Implements: blueprint quantum-qos-api
Partially-Implements: blueprint ml2-qos
Partially-Implements: blueprint ml2-qos-ovs-bwlimiting
Partially-Implements: blueprint ml2-sriov-qos-with-bwlimiting
Change-Id: I92916d0e391791187e9a25ff172fb4b3504857b1

9 years agodoc: Improve table rendering using multi-row cells
YAMAMOTO Takashi [Fri, 31 Jul 2015 08:43:37 +0000 (17:43 +0900)]
doc: Improve table rendering using multi-row cells

Also, fix a nearby typo.  (nic -> nick)

Change-Id: If94b123f9b9291db1d889026de679d91645271bc

9 years agoMerge "ml2: _commit_port_binding: Don't use None to mean False"
Jenkins [Mon, 17 Aug 2015 11:46:11 +0000 (11:46 +0000)]
Merge "ml2: _commit_port_binding: Don't use None to mean False"

9 years agoMerge "Replace internal calls of create_{network, subnet, port}"
Jenkins [Mon, 17 Aug 2015 11:42:56 +0000 (11:42 +0000)]
Merge "Replace internal calls of create_{network, subnet, port}"

9 years agoRename function '_update_port_down'
shihanzhang [Wed, 12 Aug 2015 09:12:27 +0000 (17:12 +0800)]
Rename function '_update_port_down'

The function _update_port_down is renamed to _get_agent_fdb
because it generates the fdb entries which are send to
related l2 agents, but the old name is hard to understand.

Change-Id: Ibd5447311361b62a18195a958cbdeb64fc685b24

9 years agoRedundant tests removed from ovs-lib unit tests:
Madhu Mohan Nelemane [Tue, 4 Aug 2015 07:21:52 +0000 (09:21 +0200)]
Redundant tests removed from ovs-lib unit tests:

The idea here was to remove redundant unit tests.
The approach here has been that if the function being tested does not
implement any custom logic (apart from calling ovsdb), the unit test
does not help.

Refer to the bug description for more details of the specific tests
removed.

Change-Id: I35dc60bb714566c33f5cee5aab3e5b83bd0610e3
Closes-Bug: #1459811

9 years agoUnskip firewall test
armando-migliaccio [Wed, 12 Aug 2015 18:49:46 +0000 (11:49 -0700)]
Unskip firewall test

Dependent patch addresses the issue, so we no longer
need to skip the test

Related-bug: #1483875

Depends-on: I455bbe00395377509beca5ec1d54cf4f7a57152d
Depends-on: I00d99c05328268b33c6f20b1d24e7507afccb92c

Change-Id: I41b51f36c1344dce20b1b9437c175469acfafb57

9 years agoNSX plugin: Moving away plugin extensions
Roey Chen [Sun, 16 Aug 2015 13:29:26 +0000 (06:29 -0700)]
NSX plugin: Moving away plugin extensions

As part of plugin decomposition, this patch moves vmware-nsx extensions
out of the neutron repository.

Change-Id: Iff4c4781dd96b10733a98f176cf2f0f4d25cb34f
Related-Blueprint: core-vendor-decomposition
Partial-bug: #1483453

9 years agoGet rid of exception converter in db/api.py
Kevin Benton [Sun, 16 Aug 2015 09:32:39 +0000 (02:32 -0700)]
Get rid of exception converter in db/api.py

The exception converter was necessary because the exceptions the
oslo db decorator looked for before were statically defined. The
retry decorator now accepts an exception_checker argument that takes
a function to call on exceptions to determine if they should be
caught.

This patch gets rid of the converted and replaces the one use case
with the new exception_checker argument.

Closes-Bug: #1485819
Change-Id: Ic619b03737cbf51276f87c4458ecc4183424731c

9 years agoPython 3: encode or decode i/o data of Popen.communicate()
fumihiko kakuma [Wed, 22 Jul 2015 05:00:25 +0000 (14:00 +0900)]
Python 3: encode or decode i/o data of Popen.communicate()

In Python 3, input and output for Popen.communicate() is bytes type.
Therefore, encode input data and decode return data for Popen.communicate().

Change-Id: I70f009e3366f0eeda5790652ea14f3627b934664
Blueprint: neutron-python3
Closes-Bug: #1479159

9 years agoUpdated from global requirements
OpenStack Proposal Bot [Sat, 15 Aug 2015 20:50:51 +0000 (20:50 +0000)]
Updated from global requirements

Change-Id: I5fc0be8c97c21ef68174ff6b8807e05a5e1f19a4

9 years agoMerge "Remove vmware plugin from neutron (etc part)"
Jenkins [Sat, 15 Aug 2015 18:03:52 +0000 (18:03 +0000)]
Merge "Remove vmware plugin from neutron (etc part)"

9 years agoUse a conntrack zone per port in OVS
Kevin Benton [Fri, 31 Jul 2015 01:07:03 +0000 (18:07 -0700)]
Use a conntrack zone per port in OVS

Conntrack zones per network are not adequate because VMs
on the same host communicating with each other cross iptables
twice. If conntrack is sharing the same zone for each cross,
the first one can remove the connection from the table on a RST
and then the second one marks the RST as invalid.

This patch adjusts the logic to use a conntrack zone per port
instead of per network. In order to avoid interrupting upgrades
or restarts, the initial zone map is built from the existing
iptables rules so existing port->zone mappings are maintained.

Closes-Bug: #1478925
Change-Id: Ibe9e49653b2a280ea72cb95c2da64cd94c7739da

9 years agoMerge "Final decomposition of the ML2 NCS driver"
Jenkins [Sat, 15 Aug 2015 10:58:50 +0000 (10:58 +0000)]
Merge "Final decomposition of the ML2 NCS driver"

9 years agoMerge "Add lieutenants contact for kuryr"
Jenkins [Fri, 14 Aug 2015 20:01:43 +0000 (20:01 +0000)]
Merge "Add lieutenants contact for kuryr"

9 years agoMerge "lieutenants: Add Neutron infra lieutenants"
Jenkins [Fri, 14 Aug 2015 20:01:16 +0000 (20:01 +0000)]
Merge "lieutenants: Add Neutron infra lieutenants"

9 years agoMerge "Remove 'action' argument from _handle_fip_nat_rules()"
Jenkins [Fri, 14 Aug 2015 19:59:55 +0000 (19:59 +0000)]
Merge "Remove 'action' argument from _handle_fip_nat_rules()"

9 years agoMerge "Remove unneeded shebangs"
Jenkins [Fri, 14 Aug 2015 19:59:09 +0000 (19:59 +0000)]
Merge "Remove unneeded shebangs"

9 years agoFix some issues around tempest in fullstack testing doc
Matthew Treinish [Fri, 14 Aug 2015 15:41:49 +0000 (11:41 -0400)]
Fix some issues around tempest in fullstack testing doc

The why section in the fullstack testing doc gives a good explanation
of the rational behind the testing and where it fits in the testing
pyramid. However, some of the drawbacks of tempest mentioned aren't
accurate or are misleading. This commit attempts to reword that
piece to clear up any potential sources of confusion.

The difficulty in running tempest doesn't change depending on the
nature of the deployment, since tempest is an external test suite that
interacts with any deployment only through the api. The configuration
and run mechanics do not change whether your cloud is 1 or multiple
nodes. The real difficulty lies in setting up a multinode deployment.

For the failure reporting, if you can't figure out why something
failed from a tempest run it's the same for any end user of the API.
It should be treated as a bug in the project if an end user
can't figure out why something failed from logs and what gets
returned by the API. But, since the fullstack tests are a bit lower
level its not necessarily trying to catch bugs like that. This commit
attempts to reword it to make that distinction clear.

Change-Id: Ie5b01047412deb84fe1457100ecd4af48a1d7efc

9 years agoMerge "l3: not use L2 plugin _get_subnet unnecessarily"
Jenkins [Fri, 14 Aug 2015 18:31:00 +0000 (18:31 +0000)]
Merge "l3: not use L2 plugin _get_subnet unnecessarily"

9 years agoMerge "l3_db: not use L2 plugin _get_port unnecessarily"
Jenkins [Fri, 14 Aug 2015 18:23:53 +0000 (18:23 +0000)]
Merge "l3_db: not use L2 plugin _get_port unnecessarily"

9 years agoMerge "Setup reference service providers for API test runs"
Jenkins [Fri, 14 Aug 2015 17:03:44 +0000 (17:03 +0000)]
Merge "Setup reference service providers for API test runs"

9 years agoAdd lieutenants contact for kuryr
Gal Sagie [Fri, 14 Aug 2015 12:45:32 +0000 (15:45 +0300)]
Add lieutenants contact for kuryr

Change-Id: I873b88b1fab513d8a4a4ad81a0c2d3161b4cef88

9 years agoAdd dashboard folder and graphite dashboard to doc
Ryan Moats [Fri, 14 Aug 2015 13:25:17 +0000 (08:25 -0500)]
Add dashboard folder and graphite dashboard to doc

Create a dashboard folder to hold HTML files that provide
dashboard views into various parts of neutron.  This allows
the dashboards to be "living code" rather than frozen in
amber via shortened URLs.

The first dashboard example is a simple HTML file that
shows thumbnails of graphite plots of all neutron jobs
in the check pipeline.  Clicking a thumbnail brings up
the larger graphite plot page.

Change-Id: I47e7718c2aae41c8308fd331377984e47a892294
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
9 years agolieutenants: Add Neutron infra lieutenants
Kyle Mestery [Thu, 13 Aug 2015 16:33:18 +0000 (16:33 +0000)]
lieutenants: Add Neutron infra lieutenants

It's become clear we need to have a centralized contact point
(or points) for Neutron interactions with infra. Lets start out
by making that Doug and Armando for now. Note this list is
alphabetized by last name for those curious on the ordering.

Change-Id: If736dc2c6482d0c2722cf0a5049c8ee5511ed970
Signed-off-by: Kyle Mestery <mestery@mestery.com>
9 years agoDVR: do not reschedule router for down agents on compute nodes
Oleg Bondarev [Thu, 2 Jul 2015 12:47:34 +0000 (15:47 +0300)]
DVR: do not reschedule router for down agents on compute nodes

Scheduling/unscheduling of DVR routers with l3 agents in 'dvr' mode
running on a compute nodes is done according to DVR serviced ports
created/deleted on that compute nodes. It doesn't make sense to reschedule
router from l3 agent on compute node even if it's down - no other l3 agent
can handle VMs running on that compute node.

Closes-Bug: #1470889
Change-Id: Ib998b9e459dd1a9ab740fafa5d84dc3211ca0097

9 years agoReplace internal calls of create_{network, subnet, port}
Isaku Yamahata [Tue, 21 Oct 2014 02:30:32 +0000 (11:30 +0900)]
Replace internal calls of create_{network, subnet, port}

When API controller calls method create_{network, subnet, port),
it made sure that the necessary default values for attrs are filled properly
according to attr mapping.

However, internal calls to these methods do not follow the convention,
when extension codes miss these values, exceptions will be thrown.

This patch introduces helper functions to fix up arguments and replaces
the direct callers of those methods.

Co-Authored-By: gong yong sheng <gong.yongsheng@99cloud.net>
Co-Authored-By: yalei wang <yalei.wang@intel.com>
Change-Id: Ibc6ff897a1a00665a403981a218100a698eb1c33
Closes-Bug: #1383546

9 years agoMerge "Validate local_ip for OVS tunnel"
Jenkins [Fri, 14 Aug 2015 10:27:12 +0000 (10:27 +0000)]
Merge "Validate local_ip for OVS tunnel"

9 years agoml2: _commit_port_binding: Don't use None to mean False
YAMAMOTO Takashi [Fri, 14 Aug 2015 10:08:38 +0000 (19:08 +0900)]
ml2: _commit_port_binding: Don't use None to mean False

The second return value is a boolean.

Change-Id: Id5b2b00bdfcb7c81ba05b1905cd781f38e6ebad8

9 years agoMinor typo fix
Amit Saha [Fri, 14 Aug 2015 07:58:06 +0000 (13:28 +0530)]
Minor typo fix

Change-Id: Id6f50b56c9af6a1161e95a3ac0b3411d3513aa2e

9 years agoMerge "Add parent_id to _item calling from _handle_action"
Jenkins [Fri, 14 Aug 2015 03:47:15 +0000 (03:47 +0000)]
Merge "Add parent_id to _item calling from _handle_action"

9 years agoMerge "Add configurable options for HA networks"
Jenkins [Fri, 14 Aug 2015 02:03:45 +0000 (02:03 +0000)]
Merge "Add configurable options for HA networks"

9 years agoMerge "db_base_plugin_v2: Avoid creating another session"
Jenkins [Fri, 14 Aug 2015 01:59:03 +0000 (01:59 +0000)]
Merge "db_base_plugin_v2: Avoid creating another session"