]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/log
Morgan Haskel [Sun, 15 Feb 2015 17:39:17 +0000 (09:39 -0800)]
Unbreak broken tests
Morgan Haskel [Sun, 15 Feb 2015 17:09:47 +0000 (09:09 -0800)]
Starting to clean up init.pp
Daniele Sluijters [Fri, 13 Feb 2015 08:23:53 +0000 (09:23 +0100)]
Merge pull request #422 from cmurphy/lint
Ensure linter fails on lint warnings
Daniele Sluijters [Fri, 13 Feb 2015 08:23:41 +0000 (09:23 +0100)]
Merge pull request #421 from cmurphy/future
Update spec tests for future parser
Colleen Murphy [Thu, 12 Feb 2015 00:43:14 +0000 (16:43 -0800)]
Ensure linter fails on lint warnings
Colleen Murphy [Thu, 12 Feb 2015 00:38:32 +0000 (16:38 -0800)]
Update spec tests for future parser
Strings must be quoted in the future parser.
Daniele Sluijters [Fri, 6 Feb 2015 21:10:41 +0000 (22:10 +0100)]
Merge pull request #389 from stdietrich/global_header_partial
(MODULES-1200) Fix inconsistent header across files
Stefan Dietrich [Sun, 31 Aug 2014 13:46:57 +0000 (15:46 +0200)]
(MODULES-1200) Fix inconsistent header across files
Daniele Sluijters [Wed, 4 Feb 2015 22:50:37 +0000 (23:50 +0100)]
Merge pull request #416 from mkrakowitzer/add_param_documentation
(doc) Add documentation for apt::key parameters and apt::pin parameters
Hunter Haugen [Wed, 4 Feb 2015 20:04:17 +0000 (12:04 -0800)]
Merge pull request #418 from cmurphy/rspec
Pin rspec gems
Colleen Murphy [Wed, 4 Feb 2015 16:02:03 +0000 (17:02 +0100)]
Pin rspec gems
Merritt Krakowitzer [Tue, 3 Feb 2015 16:59:54 +0000 (18:59 +0200)]
(doc) Add documentation for apt::key parameters and apt::pin parameters
Add documentation for apt::key parameters and apt::pin parameters.
Fix minor spelling error
Daniele Sluijters [Fri, 30 Jan 2015 13:22:18 +0000 (14:22 +0100)]
Merge pull request #414 from phaf/fix_doc_unattended_upgrades
Documentation: Fix typo and syntax for example of apt::unattended_upgrad...
Patric Hafner [Thu, 29 Jan 2015 13:48:47 +0000 (14:48 +0100)]
Documentation: Fix typo and syntax for example of apt::unattended_upgrades
Morgan Haskel [Wed, 28 Jan 2015 16:36:01 +0000 (08:36 -0800)]
Merge pull request #398 from irconan/backports-pin
Separate apt::pin for apt::backports to allow pin by release instead of ...
Richard Connon [Sun, 14 Dec 2014 21:54:17 +0000 (21:54 +0000)]
Separate apt::pin for apt::backports to allow pin by release instead of origin
Updated tests for backports
Morgan Haskel [Mon, 26 Jan 2015 22:26:13 +0000 (14:26 -0800)]
Merge pull request #395 from udienz/master
Add Ubuntu vivid (15.04) release
tphoney [Wed, 21 Jan 2015 19:14:33 +0000 (11:14 -0800)]
Merge pull request #411 from mhaskel/trusted_fix
Trusted will be a reserved word in Puppet 4
Morgan Haskel [Wed, 21 Jan 2015 18:54:37 +0000 (10:54 -0800)]
Trusted will be a reserved word in Puppet 4
Rename the new `trusted` parameter to `trusted_source`.
Daniele Sluijters [Tue, 20 Jan 2015 21:05:44 +0000 (16:05 -0500)]
Merge pull request #407 from mkrakowitzer/
f3792625 /trusted_param
Add support for parameter trusted MODULES-1658
Merritt Krakowitzer [Tue, 20 Jan 2015 19:27:52 +0000 (21:27 +0200)]
Merge branch 'master' of https://github.com/puppetlabs/puppetlabs-apt into
f3792625 /trusted_param
Daniele Sluijters [Tue, 20 Jan 2015 17:39:46 +0000 (12:39 -0500)]
Merge pull request #403 from WolverineFan/fix_apt_updates_facts
Fix apt_has_updates fact not parsing apt-check output correctly
WolverineFan [Thu, 8 Jan 2015 05:45:43 +0000 (00:45 -0500)]
Fix apt_has_updates fact not parsing apt-check output correctly
The /usr/lib/update-notifier/apt-check script returns its output
to STDERR but a recent change to the script redirects STDERR to
/dev/null. This will cause the array to always be empty.
Combined with that problem, while we were checking for the result
being nil, we never checked for an invalid array. As a result,
the apt_has_updates was always true and the apt_updates and
apt_security_updates facts were trying to read from an empty array
and failing.
Colleen Murphy [Wed, 14 Jan 2015 16:25:47 +0000 (08:25 -0800)]
Merge pull request #409 from cyberious/MOD1661
MODULES-1661 Fix to do delete with short key not long
Travis Fields [Wed, 14 Jan 2015 07:43:13 +0000 (23:43 -0800)]
MODULES-1661 Fix to do delete with short key not long
Colleen Murphy [Wed, 14 Jan 2015 01:41:49 +0000 (17:41 -0800)]
Merge pull request #408 from cyberious/MODULES-1661
MODULES-1661 Fix issue with apt_key destroy, also added mutliple deletes
Travis Fields [Tue, 13 Jan 2015 23:54:10 +0000 (15:54 -0800)]
MODULES-1661 Fix issue with apt_key destroy, also added mutliple deletes
Merritt Krakowitzer [Tue, 13 Jan 2015 15:27:03 +0000 (17:27 +0200)]
Add support for parameter trusted
* Add support for paramater trusted, valid options are 'true' and false.
defaults to false. True sets the value to trusted=yes.
trusted=yes can be set to indicate that packages from this source are
always authenticated even if the Release file is not signed or the
signature can't be checked.
* Update documentation
Daniele Sluijters [Mon, 12 Jan 2015 19:32:52 +0000 (14:32 -0500)]
Merge pull request #404 from WolverineFan/support_40char_fingerprints
Allow full length GPG key fingerprints.
rfkrocktk [Thu, 4 Sep 2014 02:00:57 +0000 (19:00 -0700)]
Allow full length GPG key fingerprints.
Also add support for ECC and ECDSA key_types
Hunter Haugen [Fri, 9 Jan 2015 21:32:25 +0000 (13:32 -0800)]
Merge pull request #405 from petems/update_init_docs
Format documentation a little
Peter Souter [Fri, 9 Jan 2015 21:17:51 +0000 (13:17 -0800)]
Format documentation a little
Makes it a little easier to read and parse with scripts
Daniele Sluijters [Thu, 8 Jan 2015 08:14:55 +0000 (09:14 +0100)]
Merge pull request #400 from voidus/master
Allow ports that consist of 5 decimals
Simon Kohlmeyer [Fri, 26 Dec 2014 04:10:52 +0000 (05:10 +0100)]
Allow ports that consist of 5 decimals
Morgan Haskel [Mon, 29 Dec 2014 19:23:47 +0000 (11:23 -0800)]
Merge pull request #401 from cmurphy/master
Add IntelliJ files to the ignore list
Colleen Murphy [Mon, 29 Dec 2014 18:40:53 +0000 (10:40 -0800)]
Add IntelliJ files to the ignore list
Daniele Sluijters [Fri, 19 Dec 2014 19:48:40 +0000 (20:48 +0100)]
Merge pull request #394 from juniorsysadmin/apt-force-locale-fixes
(MODULES-1231) Fix apt::force locale issues
juniorsysadmin [Thu, 11 Dec 2014 02:41:01 +0000 (13:41 +1100)]
(MODULES-1231) Fix apt::force locale issues
The current $install_check variable greps for 'Installed' or
'Candidate', which means that it will give the wrong result
when a non-English locale is used. This patch ensures that the
check will work properly for non-English locales by setting the
environment parameters for the exec to LC_ALL=C LANG=C
Hunter Haugen [Fri, 12 Dec 2014 21:28:06 +0000 (13:28 -0800)]
Merge pull request #397 from mhaskel/puppet_not_shell
Use puppet() instead of shell() to install module dependencies
Morgan Haskel [Fri, 12 Dec 2014 20:53:18 +0000 (12:53 -0800)]
Use puppet() instead of shell() to install module dependencies
Mahyuddin Susanto [Thu, 11 Dec 2014 04:22:48 +0000 (11:22 +0700)]
Add Ubuntu vivid (15.04) release
Signed-off-by: Mahyuddin Susanto <udienz@gmail.com>
Morgan Haskel [Tue, 9 Dec 2014 16:20:50 +0000 (08:20 -0800)]
Merge pull request #391 from cmurphy/master
Update .travis.yml, Gemfile, Rakefile, and CONTRIBUTING.md
Colleen Murphy [Tue, 9 Dec 2014 06:52:06 +0000 (22:52 -0800)]
Add json gem
The puppet_facts gem implicitly depends on the json gem.
On Ruby 1.8.7, json is not built in. On Puppet 2.7, it is
not explicitly pulled in by the hiera gem. So we add it
here explicitly.
Colleen Murphy [Mon, 8 Dec 2014 18:23:17 +0000 (10:23 -0800)]
Update .travis.yml, Gemfile, Rakefile, and CONTRIBUTING.md
Morgan Haskel [Mon, 8 Dec 2014 18:20:05 +0000 (10:20 -0800)]
Merge pull request #390 from cmurphy/puppet_27
Define travis matrix in .sync.yml
Colleen Murphy [Sun, 7 Dec 2014 21:26:08 +0000 (13:26 -0800)]
Define travis matrix in .sync.yml
Since the other modules need to wait for a major release before
deprecating Puppet 2.7 support, this module's travis.yml is out of sync
and will need to stay that way for a while.
Morgan Haskel [Thu, 4 Dec 2014 22:42:42 +0000 (17:42 -0500)]
Merge pull request #385 from phervieux/utopic
Add utopic support
Travis Fields [Fri, 21 Nov 2014 20:05:48 +0000 (15:05 -0500)]
Merge pull request #387 from mhaskel/merge_1.6.x
Merge 1.6.x
Morgan Haskel [Fri, 21 Nov 2014 16:59:04 +0000 (11:59 -0500)]
Merge remote-tracking branch 'upstream/1.6.x' into merge_1.6.x
Conflicts:
lib/facter/apt_package_updates.rb
lib/facter/apt_security_updates.rb
lib/facter/apt_updates.rb
Morgan Haskel [Fri, 21 Nov 2014 16:52:45 +0000 (11:52 -0500)]
Merge pull request #384 from cyberious/HttpBasicAuthentication
MODULES-1119 Fixed to now have username and passwords passed in again
Daniele Sluijters [Fri, 21 Nov 2014 10:46:55 +0000 (11:46 +0100)]
Merge pull request #386 from jbondpdx/master
FM-1523: Added module summary to metadata.json
Travis Fields [Fri, 14 Nov 2014 04:25:46 +0000 (20:25 -0800)]
MODULES-1119 Fixed to now have username and passwords passed in again
jbondpdx [Thu, 20 Nov 2014 23:28:07 +0000 (15:28 -0800)]
FM-1523: Added module summary to metadata.json
Patrick Hervieux [Fri, 14 Nov 2014 13:48:09 +0000 (14:48 +0100)]
Add utopic support
Daniele Sluijters [Thu, 13 Nov 2014 18:23:07 +0000 (19:23 +0100)]
Merge pull request #376 from raoulbhatia/unattended-upgrades-oldstable
Unattended upgrades oldstable for wheezy
Colleen Murphy [Tue, 28 Oct 2014 19:37:57 +0000 (12:37 -0700)]
Merge pull request #380 from mhaskel/test
merge 1.7.x into master
Colleen Murphy [Tue, 28 Oct 2014 16:26:56 +0000 (09:26 -0700)]
Merge pull request #378 from mhaskel/1.7.0-prep
1.7.0 prep
Morgan Haskel [Mon, 27 Oct 2014 19:29:47 +0000 (15:29 -0400)]
1.7.0 prep
Colleen Murphy [Mon, 27 Oct 2014 15:54:24 +0000 (08:54 -0700)]
Merge pull request #377 from mhaskel/1.7.x-merge
Merge master back into 1.7.x
Morgan Haskel [Mon, 27 Oct 2014 14:10:52 +0000 (10:10 -0400)]
Fix tests to reflect behavior fixed on 1.7.x
The facts don't really work with 2>&1 in the case of an error, so you
want 2>/dev/null instead.
Morgan Haskel [Mon, 27 Oct 2014 13:57:46 +0000 (09:57 -0400)]
Merge remote-tracking branch 'upstream/master' into 1.7.x-merge
Conflicts:
lib/facter/apt_package_updates.rb
lib/facter/apt_security_updates.rb
lib/facter/apt_updates.rb
Travis Fields [Wed, 10 Sep 2014 17:37:07 +0000 (10:37 -0700)]
Fix issue with puppet_module_install, removed and using updated method from beaker core copy_module_to
Hunter Haugen [Fri, 15 Aug 2014 23:22:46 +0000 (16:22 -0700)]
Remove stderr from stdout
Sometimes there are lib errors on platforms with malformed packages.
This shouldn't cause the facts to completely fail.
Raoul Bhatia [Fri, 24 Oct 2014 10:59:15 +0000 (12:59 +0200)]
Fix "WARNING: case statement without a default case on line ..."
Raoul Bhatia [Fri, 24 Oct 2014 10:37:46 +0000 (12:37 +0200)]
Fix "WARNING: indentation of => is not properly aligned on line 9"
Raoul Bhatia [Fri, 24 Oct 2014 10:29:48 +0000 (12:29 +0200)]
Add "oldstable" to the default update origins for wheezy
Add "oldstable" to the default update origins to ensure
the updates keep working after wheezy+1 gets released
See unattended-upgrades 0.79.5+wheezy1 and https://bugs.debian.org/711826
Daniele Sluijters [Thu, 16 Oct 2014 08:07:25 +0000 (10:07 +0200)]
Merge pull request #375 from raphink/dev/facts_perfs
Refactor facts to improve performance.
Raphaël Pinson [Wed, 15 Oct 2014 13:44:50 +0000 (15:44 +0200)]
Refactor facts to improve performance:
* Add an apt_has_updates boolean fact
* Make other facts depend on it
Daniele Sluijters [Tue, 14 Oct 2014 11:42:59 +0000 (13:42 +0200)]
README: the facts depend on update-notifier
Daniele Sluijters [Tue, 14 Oct 2014 07:12:18 +0000 (09:12 +0200)]
Merge pull request #374 from bschlief/random_sleep
Add support for RandomSleep to 10periodic
Bryan M. Schlief [Mon, 13 Oct 2014 18:44:56 +0000 (11:44 -0700)]
Add support for RandomSleep to 10periodic
Daniele Sluijters [Thu, 9 Oct 2014 00:24:49 +0000 (17:24 -0700)]
Merge pull request #372 from jbondpdx/revised-readme
DOC-249: Revised and updated apt readme
Hunter Haugen [Wed, 8 Oct 2014 22:19:32 +0000 (15:19 -0700)]
Merge pull request #373 from mhaskel/metadata
Update pe compatibility
Morgan Haskel [Wed, 8 Oct 2014 22:18:39 +0000 (18:18 -0400)]
Update pe compatibility
jbondpdx [Wed, 8 Oct 2014 18:09:54 +0000 (11:09 -0700)]
DOC-249 Revised and updated apt readme
Revised and updated apt readme. Post-merge-conflict edition.
Colleen Murphy [Tue, 7 Oct 2014 16:37:06 +0000 (09:37 -0700)]
Merge pull request #371 from mhaskel/force-yes
add --force-yes so deb7 doesn't hang
Morgan Haskel [Mon, 6 Oct 2014 23:44:19 +0000 (19:44 -0400)]
add --force-yes so deb7 doesn't hang
Colleen Murphy [Mon, 6 Oct 2014 20:53:17 +0000 (13:53 -0700)]
Merge pull request #369 from mhaskel/future_parser
Missed one case for _kick_apt needed for strict variables
Morgan Haskel [Mon, 6 Oct 2014 20:41:14 +0000 (16:41 -0400)]
Missed one case for _kick_apt needed for strict variables
Hunter Haugen [Fri, 3 Oct 2014 23:36:21 +0000 (16:36 -0700)]
Merge pull request #368 from mhaskel/future_parser
Fix for future parser support
Morgan Haskel [Fri, 3 Oct 2014 23:30:33 +0000 (19:30 -0400)]
Fix for future parser support
Hunter Haugen [Thu, 2 Oct 2014 22:37:17 +0000 (15:37 -0700)]
Merge pull request #367 from mhaskel/deb6_apt-key_workaround
apt-key doesn't add long keys in deb6
Morgan Haskel [Thu, 2 Oct 2014 22:21:46 +0000 (17:21 -0500)]
apt-key doesn't add long keys in deb6
You can feed the command the long key, but it truncates it to add the
key. This causes issues due to the short-key collision with the
puppetlabs key. So, test with a different key on debian 6.
Hunter Haugen [Wed, 1 Oct 2014 18:55:20 +0000 (11:55 -0700)]
Merge pull request #366 from mhaskel/fix_unit_tests
We aren't truncating in the type
Morgan Haskel [Wed, 1 Oct 2014 18:46:14 +0000 (13:46 -0500)]
We aren't truncating in the type
So don't check for truncated IDs in the type test.
Hunter Haugen [Wed, 1 Oct 2014 18:43:09 +0000 (11:43 -0700)]
Merge pull request #365 from mhaskel/long_key_support
Don't truncate to short keys in the type
Morgan Haskel [Wed, 1 Oct 2014 17:55:41 +0000 (12:55 -0500)]
Don't truncate to short keys in the type
You should be able to create/delete keys using the long key to avoid
collisions, and truncating in the type makes that not work.
Morgan Haskel [Fri, 26 Sep 2014 19:01:16 +0000 (15:01 -0400)]
Merge pull request #349 from wolfspyre/apt_update_tooling
Apt update tooling
Wolf Noble [Mon, 18 Aug 2014 20:12:55 +0000 (15:12 -0500)]
- add bits for updating apt
- fix spec tests to include osfamily fact
- add spec tests to verify current default behavior unimpacted.
- manage the update-stamp file in puppet via content rather than a served file.
- update custom fact to return -1 if the file doesn't exist
- add spec test for custom fact
- refactor to use a variable vs a collector/override
- document parameters a bit more verbosely
- remove empty unconstrained fact
- Add osfamily fact to backports tests to facilitate functional tests on non-debian hosts
Daniele Sluijters [Wed, 24 Sep 2014 22:27:06 +0000 (15:27 -0700)]
Fix a test that broke with #326.
Daniele Sluijters [Wed, 24 Sep 2014 22:01:17 +0000 (15:01 -0700)]
Merge pull request #326 from dabido/master
Builddep notifies apt-get update instead of requiring it
Morgan Haskel [Wed, 24 Sep 2014 21:58:13 +0000 (14:58 -0700)]
Merge pull request #363 from martinseener/ticket/1306-apt_force_fails_if_new_package_asks_how_to_handle_changed_config_files
apt::force: Added 2 parameters for automatic configuration file handling...
Martin Seener [Fri, 5 Sep 2014 08:14:08 +0000 (10:14 +0200)]
apt::force: Added 2 parameters for automatic configuration file handling; fixes #modules-1306
when updating or installing newer packages with apt::force and you have changed previous
configuration files aptitude or apt-get will prompt what to do. You can suppress that
by pre-define the action with cfg_files parameter (new, old or unchanged and its backward
compatible if not defined). With a second optional parameter cfg_missing you can force
your provider to install missing configuration files as well.
Signed-off-by: Martin Seener <martin@seener.de>
apt::force: Changed selectors used in force.pp to case statements; refs #module-1306
Signed-off-by: Martin Seener <martin@seener.de>
apt::force: rspec: fixed the failing tests and added validate_re for cfg_files and validate_bool for cfg_missing. Also removed default values for both case statements and only allow pre-defined values or true/false. Furthermore enhanced the README refs #module-1306
Was able to fix the failing rspec tests for the patch.
Thanks to Morgan Haskel.
Signed-off-by: Martin Seener <martin@seener.de>
Despite the puppetlabs-stdlib documentation says validation_re supports 3 arguments the tests failed telling that only 2 are supported. Fixed this by removing the 3 optional argument; refs #modules-1306
Signed-off-by: Martin Seener <martin.seener@barzahlen.de>
apt::force: updated readme refs #module-1306
Signed-off-by: Martin Seener <martin@seener.de>
Travis Fields [Wed, 17 Sep 2014 16:06:38 +0000 (09:06 -0700)]
Merge pull request #362 from jbondpdx/apt-readme
MODULES-1259: added info on apt::update + edits to readme.md
jbondpdx [Tue, 16 Sep 2014 23:51:24 +0000 (16:51 -0700)]
MODULES-1259: added info on apt::update + edits to readme.md
Added apt::update information to the Readme file. Also general copy editing throughout for clarity and consistent style.
Morgan Haskel [Mon, 15 Sep 2014 21:27:27 +0000 (14:27 -0700)]
Merge pull request #360 from mhaskel/test
Merge 1.6.x into master
Morgan Haskel [Fri, 12 Sep 2014 21:24:49 +0000 (17:24 -0400)]
Merge branch '1.6.x' into test
Daniele Sluijters [Wed, 10 Sep 2014 20:25:17 +0000 (22:25 +0200)]
Merge pull request #359 from haus/ticket/master/doc_1230_update_example_keys
(DOC-1230) Update all short key examples to use the long key id
Matthaus Owens [Wed, 10 Sep 2014 20:21:07 +0000 (13:21 -0700)]
(DOC-1230) Update all short key examples to use the long key id
Morgan Haskel [Wed, 10 Sep 2014 17:44:23 +0000 (13:44 -0400)]
Merge pull request #358 from cyberious/1.6.x
Fix issue with puppet_module_install, removed and using updated method f...