]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/log
David Schmitt [Wed, 27 Nov 2019 18:31:35 +0000 (18:31 +0000)]
(maint) Update to PDK 1.14.1
David Schmitt [Mon, 25 Nov 2019 18:25:27 +0000 (18:25 +0000)]
(maint) enable simplecov for ruby codecoverage testing
David Schmitt [Thu, 21 Nov 2019 18:16:13 +0000 (18:16 +0000)]
(maint) update gitignore and pdkignore for .project file removal
David Schmitt [Thu, 21 Nov 2019 18:06:18 +0000 (18:06 +0000)]
(maint) remove obsolete gepetto .project files
David Schmitt [Thu, 21 Nov 2019 17:18:40 +0000 (17:18 +0000)]
(maint) mark .gitlab-ci.yml as deleted
David Schmitt [Thu, 21 Nov 2019 17:17:50 +0000 (17:17 +0000)]
(maint) sort and canonicalise .sync.yml
Florin Dragos [Tue, 19 Nov 2019 08:05:57 +0000 (10:05 +0200)]
Merge pull request #875 from lionce/MODULES-8413
Modules 8413 - internal chains can't be removed
Florin Dragos [Fri, 15 Nov 2019 14:28:42 +0000 (16:28 +0200)]
Merge pull request #876 from martialblog/debian-unstable
Add support for Debian Unstable
Markus Opolka [Wed, 30 Oct 2019 21:18:59 +0000 (22:18 +0100)]
Add support for Debian Unstable
- Added operatingsystemrelease unstable with netfilter service and package
- Extended rspec tests for Debian
lionce [Thu, 14 Nov 2019 15:46:17 +0000 (17:46 +0200)]
update Readme
lionce [Thu, 14 Nov 2019 15:08:21 +0000 (17:08 +0200)]
MODULES-8413 fix delete chains which is INTERNAL_CHAINS
Florin Dragos [Thu, 14 Nov 2019 13:21:14 +0000 (15:21 +0200)]
Merge pull request #874 from blackknight36/windows
Change - Avoid puppet failures on windows nodes
Michael Watters [Tue, 28 May 2019 17:30:44 +0000 (13:30 -0400)]
Change - Avoid puppet failures on windows nodes
This module will cause puppet agent runs to fail when it is included
on a windows node. Updated manifest to do nothing when running on
a windows client.
lionce [Fri, 8 Nov 2019 13:34:23 +0000 (15:34 +0200)]
Merge pull request #873 from david22swan/FM-8673
(FM-8673) - Support added for CentOS 8
David Swan [Fri, 8 Nov 2019 12:23:58 +0000 (12:23 +0000)]
(FM-8673) - Support added for CentOS 8
david22swan [Thu, 7 Nov 2019 09:17:40 +0000 (09:17 +0000)]
Merge pull request #871 from puppetlabs/pdksync_remove_ubuntu14_support
pdksync - FM-8499 - remove ubuntu14 support
lionce [Wed, 6 Nov 2019 15:45:14 +0000 (17:45 +0200)]
FM-8499 - remove ubuntu14 support
lionce [Tue, 5 Nov 2019 12:36:43 +0000 (14:36 +0200)]
Merge pull request #869 from puppetlabs/pdksync_encrypt-git
pdksync - (FM-8634) ensure encrypted communication for fixtures
lionce [Tue, 5 Nov 2019 08:30:02 +0000 (10:30 +0200)]
Merge pull request #870 from glennsarti/fix-travis
(PDK-1501) Fix acceptance stages in Travis CI
Glenn Sarti [Tue, 5 Nov 2019 05:25:11 +0000 (13:25 +0800)]
(PDK-1501) Fix acceptance stages in Travis CI
Previously the Travis CI file was brought under PDK control, however the
sync.yml did not contain the stage settings for the Litmus jobs which meant
that they did not run. This commit fixes that error and runs PDK Update again
David Schmitt [Fri, 1 Nov 2019 16:48:53 +0000 (16:48 +0000)]
(FM-8634) ensure encrypted communication for fixtures
lionce [Fri, 1 Nov 2019 10:14:50 +0000 (12:14 +0200)]
Merge pull request #867 from glennsarti/manage-travis
(PDK-1501) Allow Travis CI config to be templated
lionce [Fri, 1 Nov 2019 09:17:38 +0000 (11:17 +0200)]
Merge pull request #866 from michaeltlombardi/ticket/master/FM-8391-update-readme
(FM-8391) Update README per team practices
Glenn Sarti [Fri, 1 Nov 2019 01:20:01 +0000 (09:20 +0800)]
(PDK-1501) Allow Travis CI config to be templated
Previously the module unmanaged the Travis CI file when converted to Litmus.
This commit allows the Travis CI file to be managed.
Glenn Sarti [Fri, 1 Nov 2019 01:17:09 +0000 (09:17 +0800)]
(maint) Update for PDK templates
This commit updates the module as per PDK-Templates commit
0b5b39b
Michael T Lombardi [Thu, 31 Oct 2019 19:04:33 +0000 (14:04 -0500)]
(FM-8391) Update README per team practices
This commit updates the readme to remove the language marking litmus
as an experimental tool as well as clarifying the instructions for
running acceptance tests and noting the schedule for the IA Content
office hours.
david22swan [Fri, 25 Oct 2019 14:16:43 +0000 (15:16 +0100)]
Merge pull request #864 from michaeltlombardi/ticket/master/FM-8275-add-vagrant-provision
(FM-8275) Add vagrant provision list
cmccrisken-puppet [Thu, 24 Oct 2019 20:00:40 +0000 (21:00 +0100)]
Merge pull request #865 from puppetlabs/pdksync_pdksync-pdkgemupdate
pdksync - (maint) Override pdk gem version to master branch (PDK-1525 workaround until release)
Ciaran McCrisken [Thu, 24 Oct 2019 14:21:53 +0000 (15:21 +0100)]
Point pdk gem to head of master until PDK-1525 resolved
Michael T Lombardi [Fri, 18 Oct 2019 22:12:33 +0000 (17:12 -0500)]
(FM-8275) Add vagrant provision list
Prior to this commit the only provisioners included in
the provision lists were docker and vmpooler, neither
of which are particularly accessible to folks developing
on Windows outside of Puppet.
This commit adds a list which leverages the vagrant
provisioner.
lionce [Tue, 8 Oct 2019 14:33:40 +0000 (17:33 +0300)]
FM-8400 - add debian10 support (#862)
* FM-8356 Add support on debian 10
* fix tests for debian10
Michael T Lombardi (He/Him) [Mon, 7 Oct 2019 15:34:40 +0000 (10:34 -0500)]
Merge pull request #861 from Hexta/fix-rules-with-hyphen-wo-quotes
Fix parsing iptables rules with hyphen in comments
Artur Molchanov [Thu, 3 Oct 2019 21:09:13 +0000 (00:09 +0300)]
Fix parsing iptables rules with hyphen in comments
Fix parsing rules which have comments including a hyphen mark and no space character.
Example: 101-a-b-c.
lionce [Thu, 3 Oct 2019 12:50:14 +0000 (15:50 +0300)]
FM-8219 - Convert to litmus (#855)
* general changes for litmus
* net-ssh5_fix
* update port
* rubocop fixes and pdk update
* fixing travis
* removed tests for ct zone
carabasdaniel [Wed, 25 Sep 2019 08:45:27 +0000 (11:45 +0300)]
Merge pull request #860 from puppetlabs/release
Release merge back 2.1.0
lionce [Tue, 24 Sep 2019 10:28:12 +0000 (13:28 +0300)]
Merge pull request #859 from carabasdaniel/release_prep
MODULES-9939 Release preparation for version 2.1.0
Daniel Carabas [Tue, 24 Sep 2019 09:38:13 +0000 (12:38 +0300)]
Release preparation for version 2.1.0
TP Honey [Wed, 18 Sep 2019 14:03:12 +0000 (15:03 +0100)]
Merge pull request #858 from lionce/MODULES-9801
MODULES-9801 - fix negated physdev
lionce [Wed, 18 Sep 2019 13:22:24 +0000 (16:22 +0300)]
fix negated physdev
sheenaajay [Wed, 18 Sep 2019 09:45:04 +0000 (10:45 +0100)]
Merge pull request #857 from puppetlabs/pdksync_add_codeowners
(maint) Add a codeowners file
tphoney [Tue, 17 Sep 2019 14:50:39 +0000 (15:50 +0100)]
(maint) Add a codeowners file
sheenaajay [Mon, 9 Sep 2019 14:24:51 +0000 (15:24 +0100)]
Merge pull request #852 from rwf14f/ct-target-properties
(MODULES-6136) Add zone property of CT target.
Robert Frank [Mon, 9 Sep 2019 13:06:25 +0000 (14:06 +0100)]
Change fact variables in tests.
Robert Frank [Tue, 3 Sep 2019 13:22:32 +0000 (14:22 +0100)]
Disable tests of CT target on Oracle and Suse Linux.
Robert Frank [Thu, 29 Aug 2019 10:52:57 +0000 (11:52 +0100)]
Disable tests of CT target on RH 5/6 based systems.
Michael T Lombardi (He/Him) [Thu, 15 Aug 2019 15:40:02 +0000 (10:40 -0500)]
pdksync - MODULES-9692 - pdksync_1
.12.0-0-g55d9ae2 (#853)
pdksync - MODULES-9692 - pdksync_1
.12.0-0-g55d9ae2
sheena [Thu, 15 Aug 2019 08:25:01 +0000 (09:25 +0100)]
MODULES-9692 - pdksync_1
.12.0-0-g55d9ae2
Robert Frank [Mon, 22 Jul 2019 14:54:58 +0000 (16:54 +0200)]
(MODULES-6136) Add zone property of CT target.
Adds support for zone property of CT target.
sheenaajay [Wed, 7 Aug 2019 15:50:38 +0000 (16:50 +0100)]
Merge pull request #850 from dafydd2277/dafydd2277-doc-patch
Make the reject attribute note consistent
David Barr [Wed, 7 Aug 2019 15:10:12 +0000 (08:10 -0700)]
Reverse the changes in REFERENCE.md
As per request, I've changed firewall.rb, instead.
David Barr [Wed, 7 Aug 2019 15:08:43 +0000 (08:08 -0700)]
Make doc changes in firewall.rb
carabasdaniel [Tue, 16 Jul 2019 09:04:01 +0000 (12:04 +0300)]
Merge pull request #851 from puppetlabs/pdksync_pdksync_heads/
master-0-gb096033
pdksync - pdksync_heads/
master-0-gb096033
lionce [Tue, 16 Jul 2019 07:04:23 +0000 (10:04 +0300)]
David Barr [Wed, 19 Jun 2019 18:07:50 +0000 (11:07 -0700)]
Make the reject attribute note consistent
The `reject` attribute noted `jump => 'REJECT'`. But, the `jump` attribute notes that "for the values ACCEPT, DROP, and REJECT, you must use the generic `action` parameter." (Also, added some commas...)
Paula Muir [Mon, 10 Jun 2019 13:43:15 +0000 (14:43 +0100)]
Merge pull request #849 from puppetlabs/pdksync_pdksync_heads/
master-0-g7827fc2
pdksync - pdksync_heads/
master-0-g7827fc2
Erick Banks [Mon, 10 Jun 2019 12:34:14 +0000 (13:34 +0100)]
GeorgeCox [Mon, 3 Jun 2019 16:10:57 +0000 (17:10 +0100)]
(maint) Typo fixes (#844)
* Changed case of error message
Changed the case of the tables in the error message when defining a custom chain. The error message shows the tables in uppercase (as you'd see when using iptables directly), while the regex in lib/puppet/provider/firewallchain/iptables_chain.rb is expecting lowercase. It looks like lib/puppet/provider/firewallchain/iptables_chain.rb is expecting the default chains in uppercase so I have left those.
* Corrected typo, hyphen not yphen
sheenaajay [Mon, 20 May 2019 20:12:46 +0000 (21:12 +0100)]
Merge pull request #847 from eimlav/fm-8025
(FM-8025) Add RedHat 8 support
Eimhin Laverty [Thu, 16 May 2019 12:43:42 +0000 (13:43 +0100)]
(FM-8025) Add RedHat 8 support
RedHat 8 iptables uses an nftables backend. The `time` match extension
does not appear to be supported. As such, I have moved the test into
exceptions spec.
https://wiki.nftables.org/wiki-nftables/index.php/Supported_features_compared_to_xtables#time
sheenaajay [Thu, 16 May 2019 09:44:15 +0000 (10:44 +0100)]
Merge pull request #846 from puppetlabs/release
(MODULES-9098) Release mergeback v2.0.0
sheenaajay [Tue, 14 May 2019 14:04:55 +0000 (15:04 +0100)]
Merge pull request #845 from lionce/release_prep
MODULES-9097 release prep 2.0.0
lionce [Tue, 14 May 2019 13:35:35 +0000 (16:35 +0300)]
MODULES-9097 release prep 2.0.0
carabasdaniel [Fri, 3 May 2019 12:54:30 +0000 (05:54 -0700)]
Merge pull request #843 from lionce/MODULES-9017
(MODULES-9017) - update metadata to support current version of stdlib
lionce [Fri, 3 May 2019 11:45:01 +0000 (14:45 +0300)]
(MODULES-9017) - update metadata to support current version of stdlib
sheenaajay [Tue, 16 Apr 2019 10:09:40 +0000 (11:09 +0100)]
Merge pull request #842 from puppetlabs/pdksync_pdksync_f778803
pdksync - (maint) Update pdk-template to
f778803
Eimhin Laverty [Mon, 15 Apr 2019 09:34:13 +0000 (10:34 +0100)]
pdksync - (maint) Update pdk-template to
f778803
Eimhin Laverty [Fri, 12 Apr 2019 11:38:52 +0000 (12:38 +0100)]
Merge pull request #838 from david22swan/FM-7903
(FM-7903) - Implement Puppet Strings
David Swan [Mon, 8 Apr 2019 11:26:36 +0000 (12:26 +0100)]
(FM-7903) - Implement Puppet Strings
Lavinia Dan [Thu, 11 Apr 2019 12:53:45 +0000 (15:53 +0300)]
Merge pull request #841 from puppetlabs/pdksync_MODULES-8444
pdksync - (MODULES-8444) - Raise lower Puppet bound
David Swan [Wed, 10 Apr 2019 15:39:28 +0000 (16:39 +0100)]
(MODULES-8444) - Raise lower Puppet bound
Eimhin Laverty [Tue, 9 Apr 2019 11:52:42 +0000 (12:52 +0100)]
Merge pull request #824 from EmilienM/MODULES-8736
(MODULES-8736) IPtables support on RHEL8
Eimhin Laverty [Fri, 5 Apr 2019 08:42:45 +0000 (09:42 +0100)]
Merge pull request #837 from puppetlabs/release
Release mergeback 1.15.3
david22swan [Thu, 4 Apr 2019 13:22:59 +0000 (14:22 +0100)]
Merge pull request #836 from eimlav/modules-8849
(MODULES-8849) Release prep 1.15.3
Eimhin Laverty [Thu, 4 Apr 2019 12:52:42 +0000 (13:52 +0100)]
(MODULES-8849) Release prep 1.15.3
lionce [Thu, 4 Apr 2019 11:25:31 +0000 (14:25 +0300)]
Merge pull request #834 from eimlav/8855
(MODULES-8855) Move ipvs test to exception spec
Eimhin Laverty [Wed, 3 Apr 2019 16:30:27 +0000 (17:30 +0100)]
(MODULES-8855) Move ipvs test to exception spec
Lavinia Dan [Wed, 3 Apr 2019 12:54:21 +0000 (15:54 +0300)]
Merge pull request #833 from eimlav/modules-8842
(MODULES-8842) Fix ipvs not idempotent
Eimhin Laverty [Wed, 3 Apr 2019 11:21:34 +0000 (12:21 +0100)]
(MODULES-8842) Fix ipvs not idempotent
Emilien Macchi [Mon, 11 Mar 2019 15:37:37 +0000 (11:37 -0400)]
(MODULES-8736) IPtables support on RHEL8
In order to persist the nftables rules on RHEL8, we need the init scripts:
"Warning: Firewall[998 log all ipv4](provider=iptables): Unable to persist firewall rules:
Execution of '/usr/libexec/iptables/iptables.init save' returned 1:
Error: Could not execute posix command: No such file or directory - /usr/libexec/iptables/iptables.init",
Those are contained in the iptables-services package, so this patch aims
to add it into package_name for RHEL8.
Also, to make the IPtables-managed rules persistent at reboot, we need
to enable iptables (and ip6tables) service(s) like we did in previous
versions of RHEL ecosystem.
david22swan [Mon, 1 Apr 2019 08:17:51 +0000 (09:17 +0100)]
Merge pull request #832 from eimlav/maint-tests
(maint) Convert resource_cmd_spec to rspec-mock
Eimhin Laverty [Wed, 27 Mar 2019 16:59:53 +0000 (16:59 +0000)]
(maint) Convert resource_cmd_spec to rspec-mock
david22swan [Tue, 26 Mar 2019 14:48:17 +0000 (14:48 +0000)]
Merge pull request #831 from puppetlabs/release
(MODULES-8777) Release mergeback 1.15.2
lionce [Tue, 26 Mar 2019 10:26:26 +0000 (12:26 +0200)]
Merge pull request #829 from david22swan/ReleasePrep
(MODULES-8773) - 1.15.2 Release Prep
David Swan [Tue, 26 Mar 2019 09:39:09 +0000 (09:39 +0000)]
(MODULES-8773) - 1.15.2 Release Prep
david22swan [Mon, 25 Mar 2019 12:06:27 +0000 (12:06 +0000)]
Merge pull request #828 from eimlav/modules-8615
(MODULES-8615) Fix rules with ipvs not parsing
Eimhin Laverty [Mon, 25 Mar 2019 09:41:55 +0000 (09:41 +0000)]
(MODULES-8615) Fix rules with ipvs not parsing
Lavinia Dan [Fri, 22 Mar 2019 09:40:46 +0000 (11:40 +0200)]
Merge pull request #826 from eimlav/modules-6547
(MODULES-8547) Fix existing rules with --dport not parsing
Lavinia Dan [Fri, 22 Mar 2019 09:03:37 +0000 (11:03 +0200)]
Merge pull request #827 from david22swan/MODULES-7333
(MODULES-7333) - Change hashing method from MD5 to SHA256
David Swan [Thu, 21 Mar 2019 16:26:40 +0000 (16:26 +0000)]
(MODULES-7333) - Change hashing method from MD5 to SHA256
Lavinia Dan [Thu, 21 Mar 2019 10:26:43 +0000 (12:26 +0200)]
Merge pull request #795 from identw/master
External control for iptables-persistent
Eimhin Laverty [Wed, 20 Mar 2019 16:34:11 +0000 (16:34 +0000)]
(MODULES-8547) Fix existing rules with --dport not parsing
Dmitry Sergeev [Thu, 29 Nov 2018 09:29:09 +0000 (14:29 +0500)]
Fixed external control issue for iptables-persistent
Eimhin Laverty [Thu, 14 Mar 2019 13:02:36 +0000 (13:02 +0000)]
[WIP] (FM-7785) Additional test cleanup (#823)
move ipv6 tests into their own test files. one for happy path testing(checking parameters work), and one for exceptions or tests that check error output.
move missed ipv4 tests into appropriate test files.
david22swan [Thu, 7 Mar 2019 14:23:47 +0000 (14:23 +0000)]
Merge pull request #821 from puppetlabs/pdksync_modules-8728
pdksync - Remove .project from .gitignore
Eimhin Laverty [Thu, 7 Mar 2019 12:43:23 +0000 (12:43 +0000)]
(MODULES-8728) Remove .project from .gitignore
david22swan [Wed, 6 Mar 2019 08:50:31 +0000 (08:50 +0000)]
Merge pull request #820 from tphoney/FM-7785
(FM-7785) dont use default function in spec/acceptance
tphoney [Tue, 5 Mar 2019 16:50:54 +0000 (16:50 +0000)]
use prefix instead of include in acceptance tests
tphoney [Tue, 5 Mar 2019 09:24:29 +0000 (09:24 +0000)]
simplify ipv6 test logic and remove default calls
tphoney [Mon, 4 Mar 2019 17:33:30 +0000 (17:33 +0000)]
stop using the beaker default function
tphoney [Mon, 4 Mar 2019 15:41:11 +0000 (15:41 +0000)]
(FM-7785) remove sles10 checks from tests