]> review.fuel-infra Code Review - openstack-build/cinder-build.git/log
openstack-build/cinder-build.git
12 years agoUse event.listen() instead of deprecated listeners kwarg
unicell [Mon, 20 Aug 2012 11:34:19 +0000 (19:34 +0800)]
Use event.listen() instead of deprecated listeners kwarg

Fixes bug 1031405

The listeners kwarg is deprecated in SQLAlchemy 0.7.0. Since 0.7.3 is
the minimum required version of SQLAlchemy, use the new event.listen()
API instead.

Change-Id: I1b851e197c04b131ae96e814780b04e6dcdeeb1a

12 years agoMerge "Call driver for attach/detach_volume."
Jenkins [Fri, 17 Aug 2012 16:34:33 +0000 (16:34 +0000)]
Merge "Call driver for attach/detach_volume."

12 years agoMerge "Remove unused function"
Jenkins [Fri, 17 Aug 2012 15:35:03 +0000 (15:35 +0000)]
Merge "Remove unused function"

12 years agoCall driver for attach/detach_volume.
Cory Stone [Fri, 17 Aug 2012 14:18:52 +0000 (09:18 -0500)]
Call driver for attach/detach_volume.

The volume driver may want to know which guest is going to be
attached to a volume. The manager now calls down into the driver
on attach_volume and detach_volume.

Fixes bug 1038109.

Change-Id: I084c2d09a1871fa158312f9ba479abb474da1d28

12 years agoFix spelling typos
RongzeZhu [Fri, 17 Aug 2012 03:20:09 +0000 (11:20 +0800)]
Fix spelling typos

Fixes for:
* cinder/locale/*/LC_MESSAGES/nova.po
* cinder/locale/nova.pot
* cinder/testing/README.rst

Change-Id: Ib50432a72b2300742169ebe4c77584466be7bfba

12 years agoRemove unused function
RongzeZhu [Fri, 17 Aug 2012 02:07:05 +0000 (10:07 +0800)]
Remove unused function

'wait_creation' function in cinder.volume.api.API is unused.

Change-Id: I4062e026b3e227513321be18ee920a4e5882cbd7

12 years agoMerge "Remove unused imports"
Jenkins [Thu, 16 Aug 2012 04:58:27 +0000 (04:58 +0000)]
Merge "Remove unused imports"

12 years agoMerge "Implements bp migrate-nova-volumes-to-cinder"
Jenkins [Thu, 16 Aug 2012 04:48:41 +0000 (04:48 +0000)]
Merge "Implements bp migrate-nova-volumes-to-cinder"

12 years agoMerge "blueprint zadara-volume-driver"
Jenkins [Thu, 16 Aug 2012 04:01:24 +0000 (04:01 +0000)]
Merge "blueprint zadara-volume-driver"

12 years agoMerge "Add driver for using files on a generic NFS server as virtual block devices...
Jenkins [Thu, 16 Aug 2012 04:01:23 +0000 (04:01 +0000)]
Merge "Add driver for using files on a generic NFS server as virtual block devices Add NetApp-specific NFS virtual block driver"

12 years agoMerge "Update SolidFire volume driver"
Jenkins [Thu, 16 Aug 2012 03:23:24 +0000 (03:23 +0000)]
Merge "Update SolidFire volume driver"

12 years agoblueprint zadara-volume-driver
Vladimir Popovski [Fri, 10 Aug 2012 07:14:26 +0000 (00:14 -0700)]
blueprint zadara-volume-driver

Adds support for Zadara VPSA storage arrays as a BackEnd for Cinder

Change-Id: I8c2a163079853d4003223eb2c156cfd2ccef3129

12 years agoMerge "add ability to clone images"
Jenkins [Thu, 16 Aug 2012 01:37:28 +0000 (01:37 +0000)]
Merge "add ability to clone images"

12 years agoMerge "Add proper support for deprecation messages"
Jenkins [Thu, 16 Aug 2012 01:23:36 +0000 (01:23 +0000)]
Merge "Add proper support for deprecation messages"

12 years agoAdding the volume notifications to cinder
Craig Vyvial [Wed, 15 Aug 2012 20:50:29 +0000 (15:50 -0500)]
Adding the volume notifications to cinder

adding the volume notifications
added unit tests for notifications
added context for notify with rabbit

blueprint cinder-notifications

Change-Id: I5aef1e718eebb9a61e0670d524fcd5f438dee016

12 years agoadd ability to clone images
Josh Durgin [Tue, 14 Aug 2012 19:27:48 +0000 (12:27 -0700)]
add ability to clone images

Given the backend location from Glance, drivers can determine
whether they can clone or otherwise efficiently create a volume
from the image without downloading all the data from Glance.

For now implement cloning for the RBD driver. There's already a
Glance backend that stores images as RBD snapshots, so they're
ready to be cloned into volumes. Fall back to copying all the
data if cloning is not possible.

Change-Id: I71a8172bd22a5bbf64d4c68631630125fcc7fd34
Implements: blueprint efficient-volumes-from-images
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
12 years agoUpdate SolidFire volume driver
John Griffith [Tue, 14 Aug 2012 00:35:35 +0000 (18:35 -0600)]
Update SolidFire volume driver

Implements blueprint update-solidfire-driver

* Updates driver to reflect changes in the release version of SF API
* Modify SF naming scheme
* Implement snapshot functionality
* Implement setting qos on create via metadata
* Update/Add tests

Change-Id: I08f7aac31e9d95f971d297a19c285dfa7151b931

12 years agoMerge "add get_location method for images"
Jenkins [Wed, 15 Aug 2012 20:15:21 +0000 (20:15 +0000)]
Merge "add get_location method for images"

12 years agoAdd proper support for deprecation messages
Thierry Carrez [Wed, 8 Aug 2012 15:49:44 +0000 (17:49 +0200)]
Add proper support for deprecation messages

Add support for warning once about deprecated options. Use that in
the rootwrap options deprecation message, and move it to run_as_root
so that the deprecated message is emitted once and only if used.

Change-Id: I29e39c662b4456256f4c9397f305bfa857972c46

12 years agoRemove utils.deprecated functions.
Dan Prince [Sat, 11 Aug 2012 03:10:18 +0000 (23:10 -0400)]
Remove utils.deprecated functions.

We don't seem to use utils.deprecated at all... so lets
remove it and save ourselves 200 lines of code.

Also moves a couple misc. test cases in utils.py out of the
DeprecationTest suite and into the GenericUtilsTestCase
suite.

Change-Id: I96e93d8fa056110057c8855f2ce52c9f55cd4a9b

12 years agoMerge "Move volume size validation to api layer."
Jenkins [Wed, 15 Aug 2012 17:40:35 +0000 (17:40 +0000)]
Merge "Move volume size validation to api layer."

12 years agoMove volume size validation to api layer.
Eoghan Glynn [Wed, 15 Aug 2012 13:10:03 +0000 (14:10 +0100)]
Move volume size validation to api layer.

As per the discussion on this patch:

  ihttps://review.openstack.org/10540

Change-Id: I5d3031a08aa1e2d17b5fb233ebaec938c66fa88b

12 years agoMap internal exceptions in the nova style.
Eoghan Glynn [Wed, 15 Aug 2012 10:36:09 +0000 (10:36 +0000)]
Map internal exceptions in the nova style.

Fixes LP 1014687.

Adopt the nova idiom of internal exceptions mapped to their
corresponding HTTP reponse code in the FaultWrapper middleware,
and also inclusion of their detail message if declared safe for
external exposure.

Change-Id: I95a3c30466f6951e02f7a182545ff8db8fbecee8

12 years agoAdd driver for using files on a generic NFS server as virtual block devices
Ben Swartzlander [Mon, 13 Aug 2012 20:57:50 +0000 (16:57 -0400)]
Add driver for using files on a generic NFS server as virtual block devices
Add NetApp-specific NFS virtual block driver

blueprint nfs-files-as-virtual-block-devices
blueprint netapp-nfs-cinder-driver

Change-Id: I10ef6f3e230fcea2748152313d341db46bffce55

12 years agoImplements bp migrate-nova-volumes-to-cinder
John Griffith [Wed, 8 Aug 2012 19:33:08 +0000 (13:33 -0600)]
Implements bp migrate-nova-volumes-to-cinder

  Helper cmds to transition from nova to cinder

  Implements an import section in cinder-manage to transfer
  applicable tables from local or remote Nova database into a
  fresh Cinder database.

  Also implements optional method to copy persistent target files.

Change-Id: I2e655e26c55f1986f3b1554726cead9e73ee9bd6

12 years agoMerge "Add C-mode driver for NetApp."
Jenkins [Tue, 14 Aug 2012 20:33:53 +0000 (20:33 +0000)]
Merge "Add C-mode driver for NetApp."

12 years agoadd get_location method for images
Josh Durgin [Tue, 14 Aug 2012 19:26:19 +0000 (12:26 -0700)]
add get_location method for images

This is useful for determining whether the backend storage for the
image in Glance is the same as the storage used in a volume driver.

The direct_url is only available in the v2 images API, so add a
version parameter to each request. As more parts of the v2 API are
used, this parameter will become more useful.

Change-Id: I5ca06b6d80ffe4118f8dd381ed11283573bce71f
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
12 years agoMerge "Driver for IBM XIV storage."
Jenkins [Tue, 14 Aug 2012 17:24:38 +0000 (17:24 +0000)]
Merge "Driver for IBM XIV storage."

12 years agorbd: implement create_volume_from_snapshot
Josh Durgin [Mon, 13 Aug 2012 22:13:06 +0000 (15:13 -0700)]
rbd: implement create_volume_from_snapshot

In an upcoming release, rbd will support creating volumes from
snapshots ('cloning'). To clone a snapshot, it must first be
'protected', which means it cannot be deleted until it is unprotected.
A snapshot can only be unprotected if no clones depend on it. Thus,
translate a failure to unprotect into a SnapshotIsBusy exception.

Also check for remaining snapshots before deleting a volume,
and raise VolumeIsBusy if any exist. While we're here, tidy up
the shell arguments to be more readable.

This is backwards compatible since it does not use the new features
unless they are available in the installed version of rbd.

Change-Id: If4105e7af7ba33f09a15103b53ad675aceb2ebb4
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
12 years agoReplace deprecated client with python-glanceclient
Josh Durgin [Sun, 12 Aug 2012 09:21:00 +0000 (02:21 -0700)]
Replace deprecated client with python-glanceclient

This is a copy of the code that was merged into Nova.
python-glanceclient is required for Folsom, and for using
the v2 API.

Implementing blueprint efficient-volumes-from-images
requires this since it needs to access the v2 API.

Change-Id: Ia088517abab61e824a641d4adf616e08a53a94bc

12 years agoRemove unused imports
RongzeZhu [Tue, 14 Aug 2012 14:07:42 +0000 (22:07 +0800)]
Remove unused imports

Fixes bug #1036666

Removed unused imports found by:
find . -type f -name "*py" -exec pylint -r n {} \; | grep -E "Unused imp|^\*"

Change-Id: Iad69354dd47c2a0dfa3a23a95c1a23eb66773b8d

12 years agoMerge "Adds new volume API extensions"
Jenkins [Tue, 14 Aug 2012 13:29:46 +0000 (13:29 +0000)]
Merge "Adds new volume API extensions"

12 years agoFix check_for_export() in non-exporting drivers
Josh Durgin [Mon, 13 Aug 2012 17:42:27 +0000 (10:42 -0700)]
Fix check_for_export() in non-exporting drivers

This overrides the default check_for_export so that drivers that don't
need to export block devices on the host like Sheepdog and RBD don't
raise a NotImplemented exception when this is called.

Reported-by: Mark Moseley <moseleymark@gmail.com>
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
Change-Id: Icf72f51904e7bdc368bfaf0a91dd0433ce3b1cf6

12 years agoAdds new volume API extensions
Unmesh Gurjar [Sat, 11 Aug 2012 17:31:51 +0000 (10:31 -0700)]
Adds new volume API extensions

Adds following extensions:
1. Create volume from image
2. Copy volume to image

Added unit tests.

Implements: blueprint create-volume-from-image
Change-Id: I9c73bd3fa2fa2e0648c01ff3f4fc66f757d7bc3f

12 years agoDriver for IBM XIV storage.
Avishay Traeger [Sun, 12 Aug 2012 11:55:04 +0000 (14:55 +0300)]
Driver for IBM XIV storage.

Volume driver for IBM XIV storage systems, along with unit tests. The
driver imports the xiv_openstack_box class, which is a closed-source
proxy available separately to IBM XIV customers.

Change-Id: I3a3ec8b1d3e3adf1895b4a0bbd86993010d2e447

12 years agoMerge "Fake requests in tests should be to v1"
Jenkins [Mon, 13 Aug 2012 07:51:09 +0000 (07:51 +0000)]
Merge "Fake requests in tests should be to v1"

12 years agoFake requests in tests should be to v1
Mike Perez [Sun, 12 Aug 2012 23:20:53 +0000 (16:20 -0700)]
Fake requests in tests should be to v1

v2 does not exist, yet.

Change-Id: Id3a332c4d78c87882a7db1a8b98479a3881b0a5f

12 years agoAdd C-mode driver for NetApp.
Ben Swartzlander [Sun, 12 Aug 2012 04:43:05 +0000 (00:43 -0400)]
Add C-mode driver for NetApp.

blueprint netapp-volume-driver-cmode

Change-Id: I1eb418d05f557068bc0d4f359e19721c9c61068b

12 years agostorwize-svc: improved test coverage and fixes.
Avishay Traeger [Sun, 12 Aug 2012 08:31:26 +0000 (11:31 +0300)]
storwize-svc: improved test coverage and fixes.

Added test cases to cover more error paths, now providing 97% test
coverage of the storwize-svc driver. Some tests uncovered bugs in the
driver, which are fixed by this patch. In addition, there are some
fixes to the code included which address comments from the submission
of this driver to nova-volume and sync the two versions.

Change-Id: I7c646885a7f2b1e761725c14940f1d741996beb4

12 years agoMerge "Add iscsiadm path for qauntal."
Jenkins [Fri, 10 Aug 2012 20:34:01 +0000 (20:34 +0000)]
Merge "Add iscsiadm path for qauntal."

12 years agoMerge "Use openstack.common.notifier."
Jenkins [Fri, 10 Aug 2012 20:25:10 +0000 (20:25 +0000)]
Merge "Use openstack.common.notifier."

12 years agoUse setuptools-git.
Monty Taylor [Fri, 10 Aug 2012 15:55:48 +0000 (11:55 -0400)]
Use setuptools-git.

Change-Id: I6861a29d65b809362949f2c54197940fd0988785

12 years agoAdd iscsiadm path for qauntal.
Chuck Short [Fri, 10 Aug 2012 15:06:50 +0000 (10:06 -0500)]
Add iscsiadm path for qauntal.

Resynchronize with nova/etc/nova/rootwrap.d/nova.volumes.

Change-Id: I9737454bb2f48bbd97fe14bca163059e93ef825b
Signed-off-by: Chuck Short <chuck.short@canonical.com>
12 years agoCreate unique volumes_dir for testing.
Dan Prince [Tue, 7 Aug 2012 20:25:52 +0000 (16:25 -0400)]
Create unique volumes_dir for testing.

Updates test_volume.py so that we create a uniq volumes_dir for testing.
This avoids polluting the source tree with fake volume UUID's when running
tests.

Change-Id: I3c37083915effec0eff7c8d9bfffb9f7674fe6f5

12 years agoMerge "Straight port of the NetApp driver updates from nova-volume to cinder."
Jenkins [Thu, 9 Aug 2012 21:33:28 +0000 (21:33 +0000)]
Merge "Straight port of the NetApp driver updates from nova-volume to cinder."

12 years agoMerge "Remove redundant 'availability_zone' config options."
Jenkins [Thu, 9 Aug 2012 17:34:50 +0000 (17:34 +0000)]
Merge "Remove redundant 'availability_zone' config options."

12 years agoMerge "Admin users should be restricted from seeing all snapshots by default."
Jenkins [Thu, 9 Aug 2012 17:33:21 +0000 (17:33 +0000)]
Merge "Admin users should be restricted from seeing all snapshots by default."

12 years agoRemove redundant 'availability_zone' config options.
Zhiteng Huang [Wed, 8 Aug 2012 16:41:28 +0000 (00:41 +0800)]
Remove redundant 'availability_zone' config options.

There are two availability_zone related config options now:
  node_availability_zone and storage_availability_zone
While volume API uses node_availability_zone, the scheduler uses
the other, which causes failure in scheduler when these two options
have different values.

This patch removes 'node_availability_zone' so that end user
can specify 'availability zone' when create volumes using
Simple scheduler.

Partially implement blueprint implement-availability-zones

Change-Id: Ia2f0710908495ec64dacd2ee9bd10d7f8cd415df

12 years agoStraight port of the NetApp driver updates from nova-volume to cinder.
Ben Swartzlander [Wed, 8 Aug 2012 18:27:44 +0000 (14:27 -0400)]
Straight port of the NetApp driver updates from nova-volume to cinder.

These changes were already accepted into nova-volume, and I have only
altered the exception classes to match the new cinder classes.

blueprint netapp-volume-driver

Change-Id: I0d59db64e00bc7e93223a24dabadbcbd0b290fb9

12 years agoMerge "Deprecate root_helper in favor of rootwrap_config"
Jenkins [Tue, 7 Aug 2012 23:49:59 +0000 (23:49 +0000)]
Merge "Deprecate root_helper in favor of rootwrap_config"

12 years agoUse volume driver specific execeptions.
Ronen Kat [Mon, 6 Aug 2012 07:11:10 +0000 (10:11 +0300)]
Use volume driver specific execeptions.

Change generic use of exception.Error in the cinder/volume directory
to specific exceptions. The exceptions used in this patch are:
exception.VolumeBackendAPIException
exception.InvalidInput
exception.InvalidVolume
exceptio.VolumeAtatched
Patch includes updates to the appropriate tests as well.

Change-Id: I10407ff3f5babe64e88f445d3529269b7665ee16

12 years agoMerge "Add persistent volumes for tgtd."
Jenkins [Tue, 7 Aug 2012 04:09:00 +0000 (04:09 +0000)]
Merge "Add persistent volumes for tgtd."

12 years agoMerge "Send 'create volume from snapshot' to the proper host"
Jenkins [Tue, 7 Aug 2012 03:50:25 +0000 (03:50 +0000)]
Merge "Send 'create volume from snapshot' to the proper host"

12 years agoAdmin users should be restricted from seeing all
jakedahn [Sun, 5 Aug 2012 21:32:07 +0000 (14:32 -0700)]
Admin users should be restricted from seeing all
snapshots by default.

  * Now to view all snapshots across all tenants you need
    to include the all_tenants=1 GET param in your api request.
  * Fixes remaining issues blocking bug #967882

Change-Id: I2a8338d77badc70201bb315198183f2091df43fb

12 years agoUse openstack.common.notifier.
Chmouel Boudjnah [Mon, 6 Aug 2012 08:25:31 +0000 (10:25 +0200)]
Use openstack.common.notifier.

- Update openstack.common.log to use it (and fixes #1030078 for cinder as
  well so we can get review I9d4251b4292188c0174ebac1dcd98318df44c0e3
  working).
- Don't use openstack.common.context but our own just yet.

Change-Id: I10feda623788a3b2418cad6bf55cbdb860ba8ee7

12 years agoAdmin users should be restricted from seeing all
jakedahn [Tue, 31 Jul 2012 23:35:26 +0000 (16:35 -0700)]
Admin users should be restricted from seeing all
volumes by default.

  * Now to view all volumes across all tenants you need
    to include the all_tenants=1 GET param in your api request.
  * Fixes remaining issues blocking bug #967882

Change-Id: Ie9d74e9c09fa0c192ab6257b5fb02d65b593cbfb

12 years agoDeprecate root_helper in favor of rootwrap_config
Thierry Carrez [Fri, 3 Aug 2012 13:35:03 +0000 (15:35 +0200)]
Deprecate root_helper in favor of rootwrap_config

Align with recent changes in nova-rootwrap by marking the
root_helper option deprecated and introduce usage of the
rootwrap_config option instead. The root_helper option will still
fully be supported in Folsom, but will be removed in Grizzly.

Transition notes: you should replace:
root_helper=sudo cinder-rootwrap /etc/cinder/rootwrap.conf

by:
rootwrap_config=/etc/cinder/rootwrap.conf

Change-Id: I22a6d2bdee6ad2c5ad587ceec574cec4b2887f22

12 years agoSend 'create volume from snapshot' to the proper host
ZhuRongze [Fri, 13 Jul 2012 12:07:13 +0000 (12:07 +0000)]
Send 'create volume from snapshot' to the proper host

A simple solution for bug 1008866. When creating volume from snapshot on
multicluster, in volume it will check if snapshot_id is set. If snapshot_id
is set, make the call create volume directly to the volume host where the
snapshot resides instead of passing it through the scheduler. So snapshot can
be copy to new volume.

Change-Id: Ie9c1a77f62abc40e294b1d0c604cf885652728da

12 years agoAdd persistent volumes for tgtd.
Chuck Short [Fri, 27 Jul 2012 17:05:55 +0000 (12:05 -0500)]
Add persistent volumes for tgtd.

Currently if you restart the server running nova-volume
or restart tgt, you will loose your iscsi targets that
have been created. This is not good.

In order for iscsi targets to be persistent across
reboots or restarts, one has to have the target's configuration
information in /etc/tgt/targets.conf or /etc/tgt/conf.d.
So when tgtd is restarted then the iscsi targets will be there
as expected.

This patch will add a configuration file to $state_path/volumes
when the volume is created. The configuration file is identified by
the volume uuid. It creates a logicalunit when the volume is created
as well. The iscsi target and configuration file
will be removed once the volume has been removed as well.

In order to use this, you have to include the following in
your /etc/tgt/targets.conf

include $state_path/volumes/*

For upgrades, it will just re-create the volumes
already in the volumes table.

Fixes LP: #1011159

Change-Id: Ib74dcc1efa0332842041b4c045ca5fa85d4a32ca
Signed-off-by: Chuck Short <chuck.short@canonical.com>
12 years agoMerge "Include AUTHORS file in MANIFEST.in"
Jenkins [Wed, 1 Aug 2012 18:40:04 +0000 (18:40 +0000)]
Merge "Include AUTHORS file in MANIFEST.in"

12 years agoMerge "Scheduler-clean-up"
Jenkins [Wed, 1 Aug 2012 18:40:01 +0000 (18:40 +0000)]
Merge "Scheduler-clean-up"

12 years agoMerge "Add authors for IBM Storwize and SVC driver."
Jenkins [Wed, 1 Aug 2012 18:40:00 +0000 (18:40 +0000)]
Merge "Add authors for IBM Storwize and SVC driver."

12 years agoScheduler-clean-up
ZhuRongze [Sat, 28 Jul 2012 08:14:03 +0000 (08:14 +0000)]
Scheduler-clean-up

Some instance related functions and opts were still present in Cinder
Scheduler.

Remove the functions and opts and modify some computer related comments.

Change-Id: Ia01099e66bcbb129493870dfbf212d5e6669ebe1

12 years agoInclude AUTHORS file in MANIFEST.in
Chmouel Boudjnah [Wed, 1 Aug 2012 07:05:24 +0000 (09:05 +0200)]
Include AUTHORS file in MANIFEST.in

Change-Id: I4b2ddeaaaa5f58eafd25cba6bd613c6fe477ad4d

12 years agoMerge "Include volume_metadata with object on vol create"
Jenkins [Wed, 1 Aug 2012 05:27:11 +0000 (05:27 +0000)]
Merge "Include volume_metadata with object on vol create"

12 years agoAdd authors for IBM Storwize and SVC driver.
Avishay Traeger [Tue, 31 Jul 2012 18:47:57 +0000 (21:47 +0300)]
Add authors for IBM Storwize and SVC driver.

Change-Id: I0d48dd6ce595e6bd9801478fc0b90bcb8fdf5947
Co-authored-by: Ronen Kat <ronenkat@il.ibm.com>
12 years agoMerge "Remove unused instance_name_template flag"
Jenkins [Tue, 31 Jul 2012 16:22:25 +0000 (16:22 +0000)]
Merge "Remove unused instance_name_template flag"

12 years agoDriver for IBM Storwize and SVC storage.
Avishay Traeger [Sun, 15 Jul 2012 12:53:36 +0000 (15:53 +0300)]
Driver for IBM Storwize and SVC storage.

Volume driver for IBM Storwize and SVC storage systems, along with unit
tests and updated sample config file. The unit tests include a
Storwize/SVC management simulator to allow for testing without
controller hardware. Also added a new exception for volume drivers.

Change-Id: Id7e3e79cd6e62fac4b10937b6f1b5f6bcb7908fe

12 years agoRemove unused instance_name_template flag
ZhuRongze [Sat, 28 Jul 2012 07:28:50 +0000 (07:28 +0000)]
Remove unused instance_name_template flag

Only used in nova/db/sqlalchemy/models

Change-Id: I1029848bb639402cad30c01b51630c0ddd9dd7b8

12 years agoAllow XML payload for volume creation.
Eoghan Glynn [Mon, 30 Jul 2012 15:11:18 +0000 (16:11 +0100)]
Allow XML payload for volume creation.

Fixes cinder aspect of LP 1030330

Tolerate volume size attribute of type string as opposed to int.

Change-Id: I8d300a6c23c2e4e92187e26260ce49da35590545

12 years agoInclude volume_metadata with object on vol create
John Griffith [Sat, 28 Jul 2012 04:30:47 +0000 (22:30 -0600)]
Include volume_metadata with object on vol create

Fix for Bug 1029762

The symptom of this bug is that the response data of an
OSAPI create call always shows and empty dict for volume_metadata
regardless of what was passed in to created and actually used.

Upon the db create_volume call a reference to the volume
object is all that was being returned.  Since metadata is
specified and set, it should also be returned with the
create reference object.

This will result in the the osapi create call returning
a body with correct metdata info rather than always showing
and empty dict as it was previously.

Change-Id: I9ae9c737bd2aa5bfa14c19fe8b8b2a7a5aa4d43a

12 years agoTrim volume type representation.
Eoghan Glynn [Thu, 26 Jul 2012 16:26:55 +0000 (16:26 +0000)]
Trim volume type representation.

Fixes cinder aspect of LP 1027281.

Use view builder pattern to only include non-extraneous
volume type attributes in the representation.

Change-Id: I33f1b579fd6ed4ed98fa04e9148e91eca125213e

12 years agoMerge "Don't do PEP8 test for openstack-common code."
Jenkins [Tue, 24 Jul 2012 23:25:38 +0000 (23:25 +0000)]
Merge "Don't do PEP8 test for openstack-common code."

12 years agoMerge "Cleanup unused code in servce.py"
Jenkins [Tue, 24 Jul 2012 23:20:41 +0000 (23:20 +0000)]
Merge "Cleanup unused code in servce.py"

12 years agoPort nova-rootwrap changes to cinder-rootwrap
Thierry Carrez [Mon, 23 Jul 2012 14:21:28 +0000 (16:21 +0200)]
Port nova-rootwrap changes to cinder-rootwrap

Port recent nova-rootwrap changes to cinder-rootwrap, including:
* Move filter definition from Python module to configuration files
* Fix tests execution on Fedora (bug 1027814)
* Remove executable bit on cinder/rootwrap files

This certainly needs a matching change to devstack to pass gating.

Change-Id: I963bc7890ba285ae515ea61bbd960bd2523f9061

12 years agoDon't do PEP8 test for openstack-common code.
Zhiteng Huang [Mon, 23 Jul 2012 06:39:48 +0000 (14:39 +0800)]
Don't do PEP8 test for openstack-common code.

Pep8 test reports issue on openstack-common modules, which would
fail CI test. Pep8 test should skip openstack-common and assuming
they are problem-free code. Even it's not, bug/fix should go to
openstack-common first, then resync back to Cinder.  Therefore,
Cinder should skip pep8 test for openstack-common code.

Fix bug #1027774

Change-Id: I22c45542401022a6bad9f2320e8657f972915f69

12 years agoCleanup unused code in servce.py
Zhiteng Huang [Mon, 23 Jul 2012 03:17:26 +0000 (11:17 +0800)]
Cleanup unused code in servce.py

Remove unused code in Service() class which is meant to be used
by 'nova-compute'.

Change-Id: Iadd58914c7fb7a581f9878880908aabcfa5733d6
Signed-off-by: zhiteng.huang@intel.com
12 years agoUse openstack.common.setup.
Chmouel Boudjnah [Fri, 20 Jul 2012 12:26:18 +0000 (12:26 +0000)]
Use openstack.common.setup.

- Remove Authors and add it to .gitignore since this is now auto
  generated.

Change-Id: I513b362a0ea8aca9cf5e06807834316b46a5f430

12 years agoMerge "Remove unused fake memcache client"
Jenkins [Fri, 20 Jul 2012 16:41:01 +0000 (16:41 +0000)]
Merge "Remove unused fake memcache client"

12 years agoutils module is still being used by cinder-volume service
Mike Perez [Fri, 20 Jul 2012 15:59:40 +0000 (08:59 -0700)]
utils module is still being used by cinder-volume service

bug 1026949

Change-Id: I7327d94b5a9f35bc74e179a05976d511c6642a7a

12 years agoMerge "Use openstack.common.log for logging."
Jenkins [Fri, 20 Jul 2012 15:08:03 +0000 (15:08 +0000)]
Merge "Use openstack.common.log for logging."

12 years agoMerge "Remove unused check_snapshots_enabled"
Jenkins [Fri, 20 Jul 2012 15:06:36 +0000 (15:06 +0000)]
Merge "Remove unused check_snapshots_enabled"

12 years agoRemove unused fake memcache client
Mark McLoughlin [Tue, 17 Jul 2012 02:58:01 +0000 (03:58 +0100)]
Remove unused fake memcache client

Used by the consoleauth service and the EC2 and metadata APIs in Nova.

Change-Id: I3048d9ab7b1d30eff583e15044c5a7bf74d52a3c

12 years agoRemove unused check_snapshots_enabled
Mark McLoughlin [Tue, 17 Jul 2012 03:15:32 +0000 (04:15 +0100)]
Remove unused check_snapshots_enabled

Only used in Nova by the createImage action.

Change-Id: I114281fd553020ac96c499c18ff3e4a2a626c3b2

12 years agoUse openstack.common.log for logging.
Chmouel Boudjnah [Fri, 20 Jul 2012 10:53:41 +0000 (10:53 +0000)]
Use openstack.common.log for logging.

- We are not using openstack.common.notifier just yet so handedit
  openstack.common.log to use cinder.notifier now.

Change-Id: I9d912904c53a8ef5d90b4ab5792f5577701b6817

12 years agoDon't create volumes if an incorrect size was given
Mike Perez [Fri, 20 Jul 2012 06:35:32 +0000 (23:35 -0700)]
Don't create volumes if an incorrect size was given

bug 1006875

Change-Id: Ied4c6f6d03c0a70838e1e483d69f3ed1ec08a9b5

12 years agoMerge "Remove some unused helper scripts"
Jenkins [Thu, 19 Jul 2012 17:03:09 +0000 (17:03 +0000)]
Merge "Remove some unused helper scripts"

12 years agoMerge changes I4e00ca81,I223aca1a
Jenkins [Thu, 19 Jul 2012 16:57:18 +0000 (16:57 +0000)]
Merge changes I4e00ca81,I223aca1a

* changes:
  Remove unused get_{id,version}_from_href()
  Remove unused metadata serialization

12 years agoMerge "Remove unused OverLimitFault"
Jenkins [Thu, 19 Jul 2012 16:56:14 +0000 (16:56 +0000)]
Merge "Remove unused OverLimitFault"

12 years agoMerge "Remove unused wrap_errors decorator"
Jenkins [Thu, 19 Jul 2012 16:54:48 +0000 (16:54 +0000)]
Merge "Remove unused wrap_errors decorator"

12 years agoMerge "Remove unused raise_http_conflict_for_instance_invalid_state()"
Jenkins [Thu, 19 Jul 2012 16:53:43 +0000 (16:53 +0000)]
Merge "Remove unused raise_http_conflict_for_instance_invalid_state()"

12 years agoMerge "Remove unused enabled_apis flag"
Jenkins [Thu, 19 Jul 2012 16:52:28 +0000 (16:52 +0000)]
Merge "Remove unused enabled_apis flag"

12 years agoUse rpc from openstack-common.
Russell Bryant [Wed, 13 Jun 2012 14:48:54 +0000 (10:48 -0400)]
Use rpc from openstack-common.

Final patch for blueprint common-rpc.

This patch removes cinder.rpc in favor of the copy in openstack-common.

Change-Id: I9c2f6bdbe8cd0c44417f75284131dbf3c126d1dd

12 years agoAdd missing gettextutils from openstack-common.
Russell Bryant [Mon, 2 Jul 2012 15:30:10 +0000 (11:30 -0400)]
Add missing gettextutils from openstack-common.

This patch adds gettextutils from openstack-common to cinder.  It is used
by rpc, so some parts of rpc are broken without this patch.

Change-Id: I0830319f4e2011b87180abcc24354c935bea8d16

12 years agoUse save_and_reraise_exception() from common.
Russell Bryant [Tue, 1 May 2012 21:31:26 +0000 (17:31 -0400)]
Use save_and_reraise_exception() from common.

This patch common.excutils from openstack-common, which includes
save_and_reraise_exception().  The patch also converts the code
base to use it from there instead of cinder.utils and then removes
it from cinder.utils.

The initial motivation for this was removing another cinder dependency
from cinder.rpc so that it can eventually be moved to openstack-common.

Change-Id: I7354ca51a02aec9c709cf33f77d4abc46acc2742

12 years agoUse openstack.common.cfg.CONF.
Russell Bryant [Fri, 1 Jun 2012 18:42:32 +0000 (14:42 -0400)]
Use openstack.common.cfg.CONF.

Part of blueprint common-rpc.

This patch makes the rpc code use the global config object from
openstack-common.  Based on some recent discussions on the mailing list,
this may not be the final way configuration handling is done here, but
it is certainly better than the register_opts() hack that is removed by
this patch.

Change-Id: Id128126e0bc064a2a1c710c6bd32fb3d137dc7f6

12 years agoRemove cinder.log usage from cinder.rpc.
Russell Bryant [Sun, 27 May 2012 00:42:09 +0000 (20:42 -0400)]
Remove cinder.log usage from cinder.rpc.

Part of blueprint common-rpc.

This patch removes the usage of cinder.log from cinder.rpc.  This is
necessary before cinder.rpc can be moved to openstack-common.  The rpc
logging was not using any of the extra features provided in cinder.log as
far as I can tell, so the changes are very simple.

This is the final dependency.  After this change, the rpc code
can be moved to openstack-common without any changes.

Change-Id: I17ca4b691bb8d4f18e618632a2381dd12d31852a

12 years agoRemove cinder.context dependency from cinder.rpc
Russell Bryant [Fri, 25 May 2012 20:24:03 +0000 (16:24 -0400)]
Remove cinder.context dependency from cinder.rpc

Part of blueprint common-rpc.

This patch removes the usage of cinder.context from cinder.rpc.  Everything
needed to implement RpcContext now exists within cinder.rpc.

Change-Id: I9e6ec0d22e55d3d4f38e12e0fdd2df745da496f5

12 years agoLocalize rpc options to rpc code.
Russell Bryant [Fri, 25 May 2012 18:13:34 +0000 (14:13 -0400)]
Localize rpc options to rpc code.

Part of blueprint common-rpc.

Move rpc options from cinder.flags into cinder.rpc code.  This is necessary
before the rpc code can be moved to openstack-common.

Change-Id: I474c3660e1cbd3ab663571b1e088c84deb905e0b

12 years agoAdd version to scheduler rpc API.
Russell Bryant [Wed, 16 May 2012 20:40:05 +0000 (16:40 -0400)]
Add version to scheduler rpc API.

Part of blueprint versioned-rpc-apis.

One side effect of this change was that cinder.scheduler.api was removed
in favor of cinder.scheduler.rpcapi.  In this case, the api was just a
direct wrapper around rpc usage.  For other APIs, I've been following
the pattern that the rpcapi module provides the rpc client wrapper, and
if any other client-side logic is needed, that's where an api module is
used.

Change-Id: Ibd0292936f9afc77aeb5d040660bfa857861eed1