]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/log
Hunter Haugen [Mon, 3 Mar 2014 18:26:45 +0000 (10:26 -0800)]
Merge pull request #253 from apenney/add-metadata
Prepare metadata for supported module release.
Ashley Penney [Fri, 28 Feb 2014 15:34:08 +0000 (15:34 +0000)]
Prepare metadata for supported module release.
Ashley Penney [Mon, 3 Mar 2014 16:51:13 +0000 (11:51 -0500)]
Merge pull request #255 from laurenrother/1.4.x
Add "Release Notes/Known Bugs" to Changelog
Lauren Rother [Sat, 1 Mar 2014 16:09:09 +0000 (08:09 -0800)]
Add "Release Notes/Known Bugs" to Changelogdds "Release Notes/Known Bugs" to Changelog, updates file format to markdown, standardizes the format of previous entries
Per a request to have initial release notes that specifically listed known issues for this PE 3.2 release, and barred by time constraints from automating a pull from open issues in JIRA, this commit adds a Release Note and Known Bug section to the Changelog for the imminent 3.2 release. As it will display on the Forge, updates file type to markdown and standardizes previous entries.
Hunter Haugen [Tue, 25 Feb 2014 19:34:43 +0000 (11:34 -0800)]
Merge branch 'fix_pin_quotes' into 1.4.x
Hunter Haugen [Tue, 25 Feb 2014 19:34:12 +0000 (11:34 -0800)]
Pin quotes were removed for a Lucid bugfix
Hunter Haugen [Tue, 25 Feb 2014 19:12:40 +0000 (11:12 -0800)]
Merge branch 'missed_one' into 1.4.x
Martin Konrad [Tue, 18 Feb 2014 18:37:05 +0000 (13:37 -0500)]
Update Debian signing key for backports.
(cherry picked from commit
d5efdf0016a535068660c3dd52a1554d8880e3bc )
Hunter Haugen [Tue, 25 Feb 2014 17:58:36 +0000 (09:58 -0800)]
Merge pull request #246 from hunner/buncha_picks
Buncha picks
Daniele Sluijters [Fri, 21 Feb 2014 17:39:52 +0000 (18:39 +0100)]
README: Fix white space / mixed indents.
(cherry picked from commit
47c8def0f7acde99ddb0b1820a7a2e5a7566418d )
Daniele Sluijters [Fri, 21 Feb 2014 17:39:39 +0000 (18:39 +0100)]
README/LICENSE: Fix licensing.
Closes #152
(cherry picked from commit
08c1283437e2a7072e788f489f1de73dbc9a6c5d )
Martin Konrad [Tue, 18 Feb 2014 21:57:01 +0000 (16:57 -0500)]
Update out-of-date Debian signing key in remaining files.
(cherry picked from commit
3aa293a53fb7a2bd789ce3db35950778968079fd )
Konrad Lother [Wed, 29 Jan 2014 23:33:45 +0000 (00:33 +0100)]
changed proxy_host default value from false to undef. fixes #211
(cherry picked from commit
0207fcd19a91b4cbdb356c230ded64799a8615cd )
Daniel Lawrence [Wed, 19 Feb 2014 00:41:01 +0000 (11:41 +1100)]
Force owner and mode on ppa files
(cherry picked from commit
0bf44fc167405a6a0e6faae35f3fa4caa9ce8658 )
Matt Callaway [Tue, 18 Feb 2014 14:08:19 +0000 (08:08 -0600)]
Update pin_spec test to match quote removal.
(cherry picked from commit
d28dc494aae1f0cd2117183a54684f5095ab50cf )
Matt Callaway [Fri, 31 Jan 2014 21:56:28 +0000 (15:56 -0600)]
Remove the quotes from the origin line. This doesn't matter on Ubuntu Precise with apt 0.8, but for those of us still using Ubuntu Lucid, apt 0.7 silently ignores preferences with the quotes.
(cherry picked from commit
3922a1bdf505947bd2425378035f0edaffc385e6 )
Ashley Penney [Mon, 24 Feb 2014 22:31:16 +0000 (22:31 +0000)]
Add lsbdistid facts where appropriate.
(cherry picked from commit
4d188443bc4f7b10581fedf2180573308bb2bf7b )
Hunter Haugen [Mon, 24 Feb 2014 21:56:21 +0000 (13:56 -0800)]
Merge pull request #242 from hunner/add_unsup
Add non Debian os family unsupported test.
Hunter Haugen [Mon, 24 Feb 2014 21:52:13 +0000 (13:52 -0800)]
Add non Debian os family unsupported test.
Hunter Haugen [Fri, 21 Feb 2014 19:55:59 +0000 (11:55 -0800)]
Merge pull request #239 from hunner/fix_builddep
Use smaller build-dep package
Hunter Haugen [Fri, 21 Feb 2014 19:55:16 +0000 (11:55 -0800)]
Use smaller build-dep package
Ashley Penney [Fri, 21 Feb 2014 19:47:52 +0000 (14:47 -0500)]
Merge pull request #238 from hunner/clean_conditional
Using rspec filters works better
Hunter Haugen [Fri, 21 Feb 2014 19:45:21 +0000 (11:45 -0800)]
Using rspec filters works better
And this will make merging back to master cleaner
Hunter Haugen [Fri, 21 Feb 2014 19:32:10 +0000 (11:32 -0800)]
Merge pull request #237 from hunner/change_port
Port 8080 is a bad choice and bumps into puppetdb
Hunter Haugen [Fri, 21 Feb 2014 17:36:25 +0000 (09:36 -0800)]
Merge pull request #234 from hunner/fix_dash_tests
Missed the - for -y, but also tests were missing lsbdistid
Hunter Haugen [Fri, 21 Feb 2014 17:34:46 +0000 (09:34 -0800)]
Missed the - for -y, but also tests were missing lsbdistid
Hunter Haugen [Fri, 21 Feb 2014 07:14:14 +0000 (23:14 -0800)]
Merge pull request #231 from hunner/fix_ppa_options
Don't pass options to ppa on lucid
Hunter Haugen [Fri, 21 Feb 2014 00:43:48 +0000 (16:43 -0800)]
Don't pass options to ppa on lucid
Lucid (10.04) has `add-apt-repository` but it doesn't accept any
options. The define defaulted to `-y` but this changes that on lucid.
This was made 7 months ago, so apparently no one cares about 10.04 any
more.
Ashley Penney [Wed, 19 Feb 2014 19:52:05 +0000 (19:52 +0000)]
Make sure we handle PE properly.
Hunter Haugen [Sat, 15 Feb 2014 00:12:05 +0000 (16:12 -0800)]
Port 8080 is a bad choice and bumps into puppetdb
Hunter Haugen [Fri, 14 Feb 2014 22:49:14 +0000 (14:49 -0800)]
Merge branch 'release_1.4.1' into 1.4.x
Hunter Haugen [Fri, 14 Feb 2014 01:16:37 +0000 (17:16 -0800)]
Release 1.4.1
Summary:
This is a bugfix release.
Bugfixes:
- Fix apt::force unable to upgrade packages from releases other than its original
- Removed a few refeneces to aptitude instead of apt-get for portability
- Removed call to getparam() due to stdlib dependency
- Correct apt::source template when architecture is provided
- Retry package installs if apt is locked
- Use root to exec in apt::ppa
- Updated tests and converted acceptance tests to beaker
Hunter Haugen [Fri, 14 Feb 2014 22:34:37 +0000 (14:34 -0800)]
Enforce dependency version in tests
Hunter Haugen [Fri, 14 Feb 2014 22:34:08 +0000 (14:34 -0800)]
Add foss types to nodesets
Hunter Haugen [Fri, 14 Feb 2014 22:33:30 +0000 (14:33 -0800)]
Undo backwards-incompatible changes and features.
Undoes the parameter changes in #140 and #184
Ashley Penney [Tue, 11 Feb 2014 15:30:28 +0000 (10:30 -0500)]
Merge pull request #219 from justinstoller/gemsource
allow specifying gem source via env var
Ashley Penney [Tue, 11 Feb 2014 15:30:19 +0000 (10:30 -0500)]
Merge pull request #220 from justinstoller/puppet_lint
Use Puppet lint and ignore its warnings?
Justin Stoller [Sun, 9 Feb 2014 06:33:06 +0000 (22:33 -0800)]
put disabled checks in .puppet-lint.rc for non rake usage
Justin Stoller [Sun, 9 Feb 2014 06:28:45 +0000 (22:28 -0800)]
allow specifying gem source via env var
Justin Stoller [Sun, 9 Feb 2014 06:22:47 +0000 (22:22 -0800)]
disable lint check for single quoted variables
Previously we weren't linting, there's a number of warning but there was
only one actual error reported when linting was enabled. It was
erroring on a valid usage of a single quoted variable-like string.
To allow linting to succeed (and the warning to show themselves) I've
disable the check that is giving a false positive.
Justin Stoller [Sun, 9 Feb 2014 06:21:34 +0000 (22:21 -0800)]
include puppet-lint in the bundle and rake tasks
Hunter Haugen [Thu, 23 Jan 2014 18:03:16 +0000 (10:03 -0800)]
Merge pull request #214 from ghoneycutt/enable_travis_fast_finish
Enable fast finish in Travis
Garrett Honeycutt [Thu, 23 Jan 2014 17:47:51 +0000 (12:47 -0500)]
Enable fast finish in Travis
http://blog.travis-ci.com/2013-11-27-fast-finishing-builds/
Ashley Penney [Thu, 9 Jan 2014 23:28:20 +0000 (15:28 -0800)]
Merge pull request #208 from apenney/ppa-debian
Ensure apt::ppa fails on non-Ubuntu.
Ashley Penney [Thu, 9 Jan 2014 23:28:08 +0000 (15:28 -0800)]
Merge pull request #207 from apenney/add-params
Add additional acceptance testing.
Ashley Penney [Thu, 9 Jan 2014 23:26:32 +0000 (18:26 -0500)]
Fixes to make the tests run under Debian as well as Ubuntu.
Ashley Penney [Thu, 9 Jan 2014 19:35:17 +0000 (14:35 -0500)]
Ensure apt::ppa fails on non-Ubuntu.
Ashley Penney [Thu, 9 Jan 2014 19:26:59 +0000 (14:26 -0500)]
Improve apt::force tests and ensure cleanup happens consistently.
Ashley Penney [Tue, 7 Jan 2014 00:53:19 +0000 (19:53 -0500)]
Add additional acceptance testing.
This work adds a test for every parameter in every class/define in apt.
Ashley Penney [Mon, 6 Jan 2014 23:04:43 +0000 (15:04 -0800)]
Merge pull request #206 from apenney/beaker-rspec
Convert existing tests over to beakr-rspec.
Ashley Penney [Mon, 6 Jan 2014 22:39:48 +0000 (17:39 -0500)]
Convert existing tests over to beakr-rspec.
Ashley Penney [Mon, 6 Jan 2014 21:02:34 +0000 (13:02 -0800)]
Merge pull request #202 from tsuharesu/bug/exec_apt_ppa_as_root
Apt::ppa should exec with root
Ashley Penney [Mon, 6 Jan 2014 21:02:19 +0000 (13:02 -0800)]
Merge pull request #205 from braddeicide/master
fixed include, contained dash instead of underline.
braddeicide [Fri, 3 Jan 2014 08:23:00 +0000 (19:23 +1100)]
Change - to _
I did it to please my syntax validator, but I'm assuming it wasn't functioning as expected either.
Tsuharesu Luciel [Mon, 30 Dec 2013 18:01:56 +0000 (16:01 -0200)]
(#201) Use root to exec
User root is needed to execute this command.
If someone changes the default Exec user, apt-add-repository will fail.
Ashley Penney [Sun, 8 Dec 2013 15:43:51 +0000 (07:43 -0800)]
Merge pull request #195 from sd63/include_class-deprecated
fix deprecation warning with rspec-puppet 1.0.0 (and newer)
Ryan Tandy [Fri, 6 Dec 2013 00:40:10 +0000 (16:40 -0800)]
change include_class to contain_class in specs
include_class was deprecated starting from rspec-puppet 1.0.0.
Ashley Penney [Tue, 3 Dec 2013 22:55:06 +0000 (14:55 -0800)]
Merge pull request #186 from ghoneycutt/typos
Correct spelling typo in CHANGELOG
Ashley Penney [Tue, 3 Dec 2013 22:54:58 +0000 (14:54 -0800)]
Merge pull request #187 from ghoneycutt/style_for_class_with_no_params
Use include instead of parameterized class when no params are given.
Ashley Penney [Tue, 3 Dec 2013 22:54:25 +0000 (14:54 -0800)]
Merge pull request #188 from sd63/fix_regex_warning
escape more braces properly
Ashley Penney [Mon, 2 Dec 2013 17:13:04 +0000 (09:13 -0800)]
Merge pull request #191 from mnencia/patch-1
Update ppa.pp
Marco Nenciarini [Mon, 2 Dec 2013 12:17:00 +0000 (13:17 +0100)]
Fix the name of sources.list.d file resource in apt::ppa
Ryan Tandy [Thu, 21 Nov 2013 17:36:41 +0000 (09:36 -0800)]
escape more braces properly
Fixes a couple of rspec regex warnings.
Garrett Honeycutt [Thu, 21 Nov 2013 14:33:00 +0000 (15:33 +0100)]
Use include instead of parameterized class when no params are given.
Instead of perpetuating the use of parameterized classes, which we do
not want to do in light of Puppet v3 with Hiera integration, this change
invites people to use 'include' instead of the parameterized class
syntax when no params are present.
Garrett Honeycutt [Thu, 21 Nov 2013 14:31:31 +0000 (15:31 +0100)]
Correct spelling typo in CHANGELOG
Ashley Penney [Mon, 18 Nov 2013 22:51:45 +0000 (14:51 -0800)]
Merge pull request #184 from RsrchBoy/topic/removable-ppas
add an 'ensure' parameter to apt::ppa
Ashley Penney [Thu, 14 Nov 2013 12:53:48 +0000 (04:53 -0800)]
Merge pull request #185 from dalen/retry
Retry package installs
Erik Dalén [Thu, 14 Nov 2013 10:02:18 +0000 (11:02 +0100)]
Retry package installs
Sometimes package installs can fail to aquire the lock file, so retry
the command in that case.
Chris Weyl [Sat, 9 Nov 2013 00:50:21 +0000 (16:50 -0800)]
add an 'ensure' parameter to apt::ppa
...as sometimes we want to get rid of them. :)
We leave this a little loose; rather than simply requiring a boolean for
$ensure, we set the stage for doing an easy switch to also allowing 'purge' at
some point in the future.
Ashley Penney [Wed, 23 Oct 2013 14:13:55 +0000 (07:13 -0700)]
Merge pull request #182 from stefanvanwouw/master
apt::source templates/sources.list.erb generates invalid source line when architecture is provided.
Stefan van Wouw [Wed, 23 Oct 2013 10:29:47 +0000 (12:29 +0200)]
Fixed tests for
fe594950c5
We actually expect an extra space. The previous build failed because a test is issued for location='', which indeed results in 2 spaces between the architecture specification and the release. According to the sources.list man page a location is always required though (unlike the missing/empty location in the :default_params of the source_spec test).
Stefan van Wouw [Wed, 23 Oct 2013 09:22:33 +0000 (11:22 +0200)]
If architecture is provided, an invalid source line is generated (no space between location and architecture)
Ashley Penney [Wed, 16 Oct 2013 21:37:33 +0000 (14:37 -0700)]
Merge pull request #178 from apenney/getparam-removal
getparam() isn't available in all stdlib versions.
Ashley Penney [Wed, 16 Oct 2013 17:08:03 +0000 (13:08 -0400)]
getparam() isn't available in all stdlib versions.
There's no need for getparam() here when a regular variable works
just fine.
Ashley Penney [Tue, 15 Oct 2013 17:45:17 +0000 (10:45 -0700)]
Merge pull request #140 from hunner/apt_force
Handling of release parameter and apt provider in force manifest
Ashley Penney [Tue, 15 Oct 2013 17:44:04 +0000 (10:44 -0700)]
Merge pull request #173 from apenney/140-release
Prepare 1.4.0 release.
Ashley Penney [Mon, 14 Oct 2013 14:43:58 +0000 (07:43 -0700)]
Merge pull request #175 from lkoranda/patch-1
Fixed double-space typo
lkoranda [Mon, 14 Oct 2013 12:27:17 +0000 (14:27 +0200)]
lkoranda [Mon, 14 Oct 2013 11:22:47 +0000 (13:22 +0200)]
Fixed double-space typo
This bug has been introduced in 1.2.0 -
b3d67c8
Ashley Penney [Tue, 8 Oct 2013 18:10:08 +0000 (11:10 -0700)]
Prepare 1.4.0 release.
Ashley Penney [Tue, 8 Oct 2013 17:57:12 +0000 (10:57 -0700)]
Merge pull request #172 from apenney/fix-ppa
This work flips from onlyif to unless (mistakenly looked at the
Ashley Penney [Tue, 8 Oct 2013 17:50:30 +0000 (10:50 -0700)]
This work flips from onlyif to unless (mistakenly looked at the
wrong return code).
Ashley Penney [Fri, 4 Oct 2013 23:17:38 +0000 (16:17 -0700)]
Merge pull request #170 from apenney/metadata
FM-103: Add metadata.json to all modules.
Ashley Penney [Fri, 4 Oct 2013 19:49:01 +0000 (15:49 -0400)]
FM-103: Add metadata.json to all modules.
Ashley Penney [Wed, 2 Oct 2013 19:06:32 +0000 (12:06 -0700)]
Merge pull request #169 from apenney/fix_ppa.pp
This switches us to doing a `test -s` instead of checking for the
Ashley Penney [Wed, 2 Oct 2013 18:04:51 +0000 (14:04 -0400)]
Fix other tests to include apt appropriately.
Ashley Penney [Wed, 2 Oct 2013 17:56:06 +0000 (13:56 -0400)]
This switches us to doing a `test -s` instead of checking for the
files existence as add-apt-repository --remove leaves a 0 byte file
behind instead of deleting everything properly.
Ashley Penney [Wed, 2 Oct 2013 17:01:49 +0000 (10:01 -0700)]
Merge pull request #168 from apenney/rspec-system
Add initial rspec-system tests.
Ashley Penney [Wed, 2 Oct 2013 16:42:56 +0000 (12:42 -0400)]
Add initial rspec-system tests.
This covers:
apt::builddep
apt::key
apt::ppa
apt::source
apt
Ashley Penney [Wed, 2 Oct 2013 13:07:05 +0000 (06:07 -0700)]
Merge pull request #167 from madeddie/master
add an updates_timeout option to apt::params (PR fix)
Edwin Hermans [Wed, 2 Oct 2013 12:24:30 +0000 (14:24 +0200)]
add an updates_timeout option to apt::params (PR fix)
Hunter Haugen [Tue, 17 Sep 2013 17:25:30 +0000 (10:25 -0700)]
Merge pull request #162 from apenney/130-release
Prepare 1.3.0 release.
Ashley Penney [Tue, 17 Sep 2013 14:20:23 +0000 (10:20 -0400)]
Prepare 1.3.0 release.
Ashley Penney [Mon, 16 Sep 2013 23:18:41 +0000 (16:18 -0700)]
Merge pull request #153 from drbop/drbop_unattended_upgrades
Class for managing unattended-upgrades
Dan Carley [Mon, 16 Sep 2013 12:56:14 +0000 (13:56 +0100)]
[#153] Remove trailing whitespace from spec.
Dan Carley [Mon, 16 Sep 2013 12:45:03 +0000 (13:45 +0100)]
[#153] Install unattended configs after package
To ensure that the default configs from the package are always overwritten
within a single Puppet run.
Dan Carley [Mon, 16 Sep 2013 12:35:09 +0000 (13:35 +0100)]
[#153] Test defaults for some unattended params
For params which have any logic embedded in the template:
- origins
- blacklist
- mail_to
- dl_limit
Dan Carley [Mon, 16 Sep 2013 11:34:07 +0000 (12:34 +0100)]
[#153] Variablise file paths in unattended spec
Reduce some duplication of long file paths.
Dan Carley [Mon, 16 Sep 2013 08:06:15 +0000 (09:06 +0100)]
[#153] Convert t/f params to bools and validate
Per lint check: http://puppet-lint.com/checks/quoted_booleans/
Dan Carley [Mon, 16 Sep 2013 07:53:01 +0000 (08:53 +0100)]
[#153] Rename unattended_upgrades s/-/_/
It's preferable to use underscores rather than hyphens in class names. Refs:
- http://projects.puppetlabs.com/issues/5268
- http://docs.puppetlabs.com/puppet/3/reference/lang_reserved.html#classes-and-types