summary |
shortlog | log |
commit |
commitdiff |
review |
tree
first ⋅ prev ⋅ next
William Van Hevelingen [Wed, 14 Mar 2012 22:36:33 +0000 (15:36 -0700)]
(#13125) Apt keys should be case insensitive
Previously lowercase keys would be installed every
puppet run because apt-key list returns an uppercase
key. This commit makes the comparison case insensitive.
Matthaus Litteken [Thu, 15 Mar 2012 06:33:46 +0000 (23:33 -0700)]
Merge pull request #32 from pdxcat/convert_apt__key_to_use_anchors
Convert apt::key to use anchors
Ryan Coleman [Thu, 8 Mar 2012 02:46:13 +0000 (18:46 -0800)]
Merge pull request #33 from rcoleman/tickets/13016/create_CHANGELOG
(#13016) Add a CHANGELOG since first commit
Skipping the merge review rules on this harmless commit of a changelog.
Ryan Coleman [Thu, 8 Mar 2012 02:22:50 +0000 (21:22 -0500)]
(#13016) Add a CHANGELOG since first commit
Reid Vandewiele [Wed, 7 Mar 2012 21:49:12 +0000 (13:49 -0800)]
Convert apt::key to use anchors
Previously, apt::key used a noop exec hack to do exactly what anchors were
intended to be used for. This commit removes the exec hack and achieves the
same end using Anchor resources from the puppetlabs/stdlib module.
Nan Liu [Wed, 7 Mar 2012 19:24:21 +0000 (11:24 -0800)]
Merge pull request #31 from pdxcat/fix_release_parameter_test
Modify apt::source release verification to work correctly with puppet-rspec
Reid Vandewiele [Wed, 7 Mar 2012 18:10:46 +0000 (10:10 -0800)]
Modify apt::source release parameter test
This commit modifies the release parameter test in apt::source to work
correctly within puppet-rspec for edge-case resource definitions. Previously,
the test for the $release parameter was written as
`if ! $release { fail() }`
This commit updates the test to be written as
`if $release == undef { fail() }`
Additionally, the tests for correct behavior in the presence or absence of a
$release parameter have been beefed up.
The reason for making this change relates to examples such as the following
resource definition:
apt::source { "jenkins":
location => "http://pkg.jenkins-ci.org/debian",
release => "",
repos => "binary/",
key => "
D50582E6",
key_source => "http://pkg.jenkins-ci.org/debian/jenkins-ci.org.key",
include_src => false,
}
Note that the $release parameter is given as the empty string. In practice,
this is perfectly valid and everything will work great. However, it seems that
the empty string gets interpreted by something in puppet-rspec as something
equivalent to "False", and thus when testing, the above resource definition
would fail with "Puppet::Error: lsbdistcodename fact not available: release
parameter required" even though the $release parameter has been explicitely
specified (as the empty string).
See also: https://github.com/rtyler/puppet-jenkins/issues/9
Matthaus Litteken [Thu, 1 Mar 2012 23:10:54 +0000 (15:10 -0800)]
Merge pull request #30 from rcoleman/tickets/12917/add_contributors_to_readme
(#12917) Add contributors to README
Ryan Coleman [Thu, 1 Mar 2012 23:01:01 +0000 (15:01 -0800)]
(#12917) Add contributors to README
Prior to this commit, this modules README had no list of contributors.
This commit adds such a list and corrects a typo I overlooked on the
last pull request.
Ryan Coleman [Thu, 1 Mar 2012 22:40:44 +0000 (14:40 -0800)]
Merge pull request #26 from pdxcat/ticket_12823_aptkey_defined_type
(#12823) Add apt::key defined type and modify apt::source to use it
Reviewed and tested by Ryan Coleman (ryan@puppetlabs.com)
Reid Vandewiele [Fri, 24 Feb 2012 18:10:03 +0000 (10:10 -0800)]
(#12823) Add apt::key defined type and modify apt::source to use it
Adding this defined type allows puppet to add keys to the apt keystore without
needing to add a corresponding source; it also adds the "key_source" parameter
for wget'ing keys from arbitrary URLs, and allows for keys to be explicity
removed.
apt::key allows a key to be ensured present multiple times to account for
apt::source resources that all reference the same key. However, this means
that it is possible for a given key to be defined multiple times with
differing source parameters. e.g.
apt::key { "Add key:
4BD6EC30 from Apt::Source bunny":
key => "
4BD6EC30",
key_server => "pgp.mit.edu",
}
apt::key { "Add key:
4BD6EC30 from Apt::Source rabbit":
key => "
4BD6EC30",
key_server => "keyserver.ubuntu.com",
}
The defined type will accept both definitions and will create multiple exec
resources. This was deemed preferable to the alternative (creating only one
exec resource) in that one broken definition won't hose an entire catalog. If
one definition fails to install the key because of a bad "key_server", the
next apt::key that uses the key will get it done.
Ryan Coleman [Thu, 1 Mar 2012 21:37:51 +0000 (13:37 -0800)]
Merge pull request #27 from blkperl/ticket_12809_refactor_release
(#12809) $release should use $lsbdistcodename and fall back to manual in...
Reviewed and tested by Ryan Coleman (ryan@puppetlabs.com)
William Van Hevelingen [Fri, 24 Feb 2012 22:03:51 +0000 (14:03 -0800)]
(#12809) $release should use $lsbdistcodename and fall back to manual input
This commit changes $release to default to Facter's $lsbdistcodename
and fall back to a Parse Error if $release is not set and $lsbdistcodename
does not exist. Previously $release was hardcoded to karmic.
This commit also modifies apt::ppa to use $release and sets the
files to be ensured so that they are not purged when purge_sources_list_d
is set to true.
Ryan Coleman [Fri, 24 Feb 2012 19:20:52 +0000 (11:20 -0800)]
Merge pull request #23 from haus/python_properties
Check if python-software-properties is defined before attempting to define it.
Reviewed and tested by Ryan Coleman (ryan@puppetlabs.com)
Ryan Coleman [Fri, 24 Feb 2012 19:12:39 +0000 (11:12 -0800)]
Merge pull request #22 from haus/unique_required_packages
Allow duplicate required_packages between sources
Reviewed and tested by Ryan Coleman (ryan@puppetlabs.com)
Ryan Coleman [Fri, 24 Feb 2012 18:56:55 +0000 (10:56 -0800)]
Merge pull request #24 from haus/fix_source_key_tests
Fix source specs to test all key permutations
Reviewed and tested by Ryan Coleman (ryan@puppetlabs.com)
Matthaus Litteken [Fri, 24 Feb 2012 18:29:09 +0000 (10:29 -0800)]
Merge pull request #25 from rcoleman/ticket_12522_purge_option_take_2
(#12522) Split purge option to spare sources.list
Ryan Coleman [Fri, 24 Feb 2012 17:50:11 +0000 (09:50 -0800)]
(#12522) Adjust spec test for splitting purge
Now that the purge parameter is split into two, the spec test needs
adjusted. This commit makes that adjustment.
Ryan Coleman [Fri, 24 Feb 2012 17:27:28 +0000 (09:27 -0800)]
(#12522) Split purge option to spare sources.list
Prior to this commit, when using the purge option, unmanaged entries
in both /etc/apt/sources.list and sources.list.d would be purged.
This commit splits purge into purge_sources_list and purge_sources_list_d
which handle the purging of those items separately. Brief documentation on
each added to class documentation.
Matthaus Litteken [Fri, 24 Feb 2012 06:08:39 +0000 (22:08 -0800)]
Fix source specs to test all key permutations
Previously only one should in each block was being evaluated. This moves each
should to its own block so that all values are tested. It also adds another set
of params so that all useful permutations of key, key_server, and key_content
are generated. It also replaces the previous ternary assignment for param_set
with a hash merge.
Matthaus Litteken [Fri, 24 Feb 2012 05:40:42 +0000 (21:40 -0800)]
Add test for python-software-properties package
This test adds the precondition that the python-software-packages package be
installed before the apt class is synced. If the defined function were not
called around the package resource, this test would fail with a duplicate
package resource error.
Peter Drake [Fri, 13 Jan 2012 15:40:41 +0000 (10:40 -0500)]
Check if python-software-properties is defined before attempting to define it.
Matthaus Litteken [Fri, 24 Feb 2012 05:04:57 +0000 (21:04 -0800)]
Add tests for required_packages change
This updates the tests for the apt::source defined type to use the new name for
the exec resource and the new parameter for the same exec.
Matthaus Litteken [Fri, 24 Feb 2012 05:01:20 +0000 (21:01 -0800)]
Allow duplicate $required_packages
Previously, if more than one apt::source required the same packages to be
installed it would fail with a duplicate exec resource. This adds the name of
the source resource to the exec and gives the exec a name, moving it to a
command parameter for the exec.
Matthaus Litteken [Fri, 24 Feb 2012 04:54:10 +0000 (20:54 -0800)]
Merge branch 'allow-same-key'
Matthaus Litteken [Fri, 24 Feb 2012 04:51:27 +0000 (20:51 -0800)]
(#12430) Add tests for changes to apt module
This update reflects the changes to the apt module to allow duplicate keys. It
mostly involves tests for changes to the resource names to make them unique
between defines.
Christian G. Warden [Thu, 23 Feb 2012 23:44:26 +0000 (15:44 -0800)]
Test two sources with the same key
Ryan Coleman [Thu, 23 Feb 2012 22:55:55 +0000 (14:55 -0800)]
Merge pull request #17 from blkperl/ticket_12526_apt_disable_keys
(#12526) Add ability to reverse apt { disable_keys => true }
Reviewed by Ryan Coleman (ryan@puppetlabs.com)
William Van Hevelingen [Fri, 10 Feb 2012 00:18:14 +0000 (16:18 -0800)]
(#12526) Add ability to reverse apt { disable_keys => true }
The setting `disable_keys => true` parameter in the apt module creates
/etc/apt/apt.conf.d/99unauth with the contents
"APT::Get::AllowUnauthenticated 1;". Changing `disable_keys`
does not remove this file. This patch makes it so that
`disable_keys => false` will remove /etc/apt/apt.conf.d/99unauth.
Ryan Coleman [Thu, 23 Feb 2012 22:31:45 +0000 (14:31 -0800)]
Merge pull request #20 from blkperl/ticket_12522_purge_option
(#12522) Adding purge option to apt class
Reviewed by Ryan Coleman
William Van Hevelingen [Thu, 23 Feb 2012 22:05:25 +0000 (14:05 -0800)]
Merge pull request #1 from rcoleman/ticket_12522_purge_option
Add Modulefile to puppet-apt
Ryan Coleman [Thu, 23 Feb 2012 22:01:31 +0000 (14:01 -0800)]
Add Modulefile to puppet-apt
Now that puppet-apt depends on puppetlabs-stdlib, an explicit
dependency is required. Modulefile was entirely missing. This commit
adds on.
Christian G. Warden [Tue, 14 Feb 2012 19:40:29 +0000 (11:40 -0800)]
Allow the use of the same key in multiple sources
Allow the use of the same key in multiple sources by including the name
of the source in the declaration for the exec which adds the key.
William Van Hevelingen [Wed, 8 Feb 2012 19:40:09 +0000 (11:40 -0800)]
(#12522) Adding purge option to apt class
Adds a purge option to the apt class to remove repositories
that are not managed by apt::source
Matthaus Litteken [Mon, 13 Feb 2012 18:02:50 +0000 (10:02 -0800)]
Merge pull request #18 from bodepd/apt_proxy_tests
(#12529) Add unit test for apt proxy settings
Dan Bode [Mon, 13 Feb 2012 17:58:30 +0000 (09:58 -0800)]
(#12529) Add unit test for apt proxy settings
This commit adds unit tests to validate that the
apt proxy is configured as expected when the class
parameter proxy_host is set as a class parameter for
the apt class.
Ken Barber [Wed, 8 Feb 2012 23:20:32 +0000 (15:20 -0800)]
Merge pull request #15 from bodepd/proxysupport
(#12529) Add parameter to support setting a proxy for apt
Dan Bode [Wed, 8 Feb 2012 17:40:43 +0000 (09:40 -0800)]
(#12529) Add parameter to support setting a proxy for apt
This commit adds two class parameter to apt that can be used to
specify a proxy to use with apt.
- proxy_host
- proxy_port
Dan Bode [Wed, 8 Feb 2012 17:44:38 +0000 (09:44 -0800)]
Merge pull request #14 from haus/ticket/12094_add_spec_tests
Ticket/12094 add spec tests
Matthaus Litteken [Sat, 4 Feb 2012 01:24:09 +0000 (17:24 -0800)]
(#12094) Replace chained .with_* with a hash
The hash passing to the with method is cleaner and closer to puppet code, so
all of the with_$param have been replaced with with($hash). This also
includes two minor whitspace changes to unstable.pp and source.pp.
This also replaces the ternary switch on param_set with a hash merge,
which is cleaner and will support more use cases.
Matthaus Litteken [Mon, 23 Jan 2012 21:13:17 +0000 (13:13 -0800)]
(#12094) Remove deprecated spec.opts file
Rspec no longer uses the spec.opts file, and this particular file also uses
options for rspec that are no longer honored or available, like loadby. So this
commit removes the file. Users that want to customize rspec behavior should use
a .rspec file in the repository root or in their home directory.
Matthaus Litteken [Mon, 23 Jan 2012 21:08:00 +0000 (13:08 -0800)]
(#12094) Add rspec-puppet tests for apt
This commit adds full coverage for the apt module as it currently exists. It
adds rspec-puppet tests for the defines (apt::builddep, apt::force, apt::pin,
apt::ppa, apt::source) and classes (apt, debian::testing, debian::unstable,
apt::params, apt::release).
Matthaus Litteken [Mon, 23 Jan 2012 21:05:59 +0000 (13:05 -0800)]
(#12094) Replace name with path in file resources
When the name is used with a file resource, it becomes difficult to test the
resource using rspec-puppet, as the name parameter gets aliased to path. So to
maintain consistency between tests and manifests, this replaces all name
parameters in file resources with the equivalent path parameter.
Dan Bode [Mon, 16 Jan 2012 05:47:45 +0000 (21:47 -0800)]
Merge pull request #4 from webfactory/pin_before_source
Suggested fix for #10449
Dan Bode [Sat, 14 Jan 2012 01:17:15 +0000 (17:17 -0800)]
Merge pull request #12 from haus/11953_fix_apt_force_version
(#11953) Apt::force passes $version to aptitude
Matthaus Litteken [Fri, 13 Jan 2012 23:29:47 +0000 (15:29 -0800)]
(#11953) Apt::force passes $version to aptitude
Previously, even if $version were passed to apt::force, aptitude would just
install the default version of the package available. This updates the aptitude
call to use the version string if it exists. If no version is passed, or if it
is false, no version is added to the aptitude call. This also updates the
rspec-puppet tests for the define, to reflect the changes to the exec.
Matthaus Litteken [Fri, 13 Jan 2012 23:09:45 +0000 (15:09 -0800)]
Merge pull request #11 from bodepd/11413_apt_force_query_fix
11413 apt force query fix
Dan Bode [Fri, 13 Jan 2012 20:25:42 +0000 (12:25 -0800)]
Merge pull request #8 from cwarden/source-example-improvement
include_src parameter in example; Whitespace cleanup
Dan Bode [Fri, 13 Jan 2012 19:02:42 +0000 (11:02 -0800)]
(#11413) Add spec test for apt::force to verify changes to unless
In the Previous commits, the query being done by the
apt::force install command was not strict enough and
could lead to false positives.
These queries represented by the unless parameter have been
resolved in another commit. This commit accompanies that commit
and adds basic unit tests to correspond to the changes.
Matthias Pigulla [Thu, 15 Dec 2011 14:52:21 +0000 (15:52 +0100)]
(#11413) Update dpkg query used by apt::force
This patch fixes the query used by apt::force to
determine rather or not the package is installed.
Previously, the expression was not specific enough and
could not lead to false positives in cases where a package
name is contained within another package name (puppet could be
incorrectly determined as being installed if puppet-common is
installed)
This commit resolves that by improving the query expression.
Matthaus Litteken [Wed, 4 Jan 2012 18:30:31 +0000 (10:30 -0800)]
Merge pull request #9 from bodepd/10451_fix_apt_update_refresh
10451 fix apt update refresh
Dan Bode [Wed, 4 Jan 2012 01:03:24 +0000 (17:03 -0800)]
(#10451) Add test coverage to apt::ppa
This commit adds test coverage for apt::ppa.
This test coverage is suficient to verify the
code changes that resolve the issue with
aptitude update not being called when ppas were
added (#10451).
Christian G. Warden [Tue, 20 Dec 2011 21:45:43 +0000 (13:45 -0800)]
include_src parameter in example; Whitespace cleanup
In the apt::source example, include the include_src parameter. Clean-up
whitespace in the example to be consistent with the style guide.
Garrett Honeycutt [Tue, 20 Dec 2011 20:33:29 +0000 (12:33 -0800)]
Merge pull request #7 from cwarden/patch-1
fix typos in "repositories"
Christian G. Warden [Tue, 20 Dec 2011 20:06:24 +0000 (12:06 -0800)]
fix typos in "repositories"
Matthias Pigulla [Wed, 2 Nov 2011 14:40:10 +0000 (15:40 +0100)]
Fix (#10451) - apt::ppa fails to "apt-get update" when new PPA source is added
Matthias Pigulla [Wed, 2 Nov 2011 09:28:38 +0000 (10:28 +0100)]
Set the pin priority before adding the source (Fix #10449)
Matthaus Litteken [Fri, 26 Aug 2011 21:39:11 +0000 (14:39 -0700)]
Merge pull request #3 from rnavarro/master
Fixed the infinite ppa add bug.
Robert Navarro [Thu, 25 Aug 2011 02:52:42 +0000 (22:52 -0400)]
Refactored as per mlitteken
* https://github.com/rnavarro/puppet-apt/commit/
1af9a13c40c33e1ab8fb56f33cb9aa5e16cead0e#commitcomment-539287
Robert Navarro [Thu, 18 Aug 2011 05:37:54 +0000 (02:37 -0300)]
Added some crazy bash madness to check if the ppa is installed already. Otherwise the manifest tries to add it on every run!
Spencer Krum [Tue, 2 Aug 2011 22:08:39 +0000 (15:08 -0700)]
(#8720) Replace Apt::Ppa with Apt::Builddep
Probably a copy & paste error
Reviewed-by: Matthaus Litteken <matthaus@puppetlabs.com>
Signed-off-by: Spencer Krum <spencer@puppetlabs.com>
Monty Taylor [Sun, 24 Jul 2011 22:12:25 +0000 (18:12 -0400)]
added builddep command.
Dan Bode [Fri, 3 Jun 2011 07:20:00 +0000 (00:20 -0700)]
added the ability to specify the content of a key
Allows us to pass key_content when we specify a source.
Dan Bode [Mon, 30 May 2011 17:43:15 +0000 (10:43 -0700)]
Fixes ppa test.
Dan Bode [Mon, 30 May 2011 17:24:06 +0000 (10:24 -0700)]
reformatted whitespace to match recommended style
of 2 space indentation.
Dan Bode [Mon, 30 May 2011 17:23:34 +0000 (10:23 -0700)]
ignore swap files.
Dan Bode [Mon, 30 May 2011 17:23:18 +0000 (10:23 -0700)]
added smoke tests for module.
Dan Bode [Mon, 30 May 2011 17:22:04 +0000 (10:22 -0700)]
reformatted apt::ppa according to recommended
style.
removed require apt in favor of marking a
dependency.
converted release define into a class since
the resources are singletons.
Dan Bode [Mon, 30 May 2011 17:18:13 +0000 (10:18 -0700)]
Created a params class to hold global data.
- Removes coupling between global data and
resources from apt class.
- Makes it easier to organize things into stages.
Dan Bode [Mon, 30 May 2011 01:43:01 +0000 (18:43 -0700)]
Added two params for apt class
both of these params facilitate options that
ease the management of apt repos in dev
environments
1. disable_keys - allows repos without properly
signed keys
2. always_apt_update - refreshes via apt update
every time that puppet runs.
Jeff Wallace [Mon, 18 Apr 2011 15:36:04 +0000 (11:36 -0400)]
Update LICENSE.
Scott McLeod [Mon, 18 Apr 2011 01:43:33 +0000 (21:43 -0400)]
Support ability to add more than one PPA
Ben Godfrey [Fri, 11 Mar 2011 18:14:31 +0000 (18:14 +0000)]
Add call to apt-update after add-apt-repository in apt::ppa
Ben Godfrey [Fri, 11 Mar 2011 17:10:25 +0000 (17:10 +0000)]
Add package definition for python-software-properties
Ben Godfrey [Fri, 11 Mar 2011 17:02:50 +0000 (17:02 +0000)]
Abs paths for all commands
Ben Godfrey [Fri, 11 Mar 2011 16:42:32 +0000 (16:42 +0000)]
Merge branch 'master' of github.com:afternoon/puppet-apt
Jeff Wallace [Mon, 12 Jul 2010 14:01:43 +0000 (10:01 -0400)]
Merge branch 'master' of github.com:evolvingweb/puppet-apt
Jeff Wallace [Mon, 12 Jul 2010 14:01:43 +0000 (10:01 -0400)]
Merge branch 'master' of github.com:evolvingweb/puppet-apt
Jeff Wallace [Mon, 12 Jul 2010 14:01:08 +0000 (10:01 -0400)]
Adding LICENSE
Jeff Wallace [Thu, 6 May 2010 17:50:59 +0000 (10:50 -0700)]
Heading fix in README
Jeff Wallace [Tue, 27 Apr 2010 20:39:50 +0000 (16:39 -0400)]
Typo in README
Jeff Wallace [Tue, 27 Apr 2010 20:38:28 +0000 (16:38 -0400)]
First commit