]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/log
John Bond [Fri, 6 Oct 2017 16:31:45 +0000 (17:31 +0100)]
remove legacy functions
Hunter Haugen [Mon, 2 Oct 2017 23:17:13 +0000 (16:17 -0700)]
Merge pull request #706 from tphoney/rubocopification
Cleanup ruby code via rubocop.
tphoney [Tue, 26 Sep 2017 09:57:25 +0000 (10:57 +0100)]
Cleanup via rubocop of ruby code
Eric Putnam [Wed, 27 Sep 2017 20:21:32 +0000 (13:21 -0700)]
Merge pull request #651 from nhinds/MODULES-4265-ubuntu-security-updates
(MODULES-4265) Detect security updates from multiple sources
Nicholas Hinds [Sun, 8 Jan 2017 01:40:29 +0000 (18:40 -0700)]
(MODULES-4265) Detect security updates from multiple sources
The apt_security_updates and apt_package_security_updates facts
now detect security updates which come from more than one source
repository.
Eric Putnam [Tue, 26 Sep 2017 22:34:44 +0000 (15:34 -0700)]
Merge pull request #709 from puppetlabs/release
(MODULES-5628) 4.2.0 release merge back
Hailee Kenney [Tue, 26 Sep 2017 22:13:31 +0000 (15:13 -0700)]
Merge pull request #708 from eputnam/release
(maint) update changelog entry for support/compat clarification [skip ci]
Eric Putnam [Tue, 26 Sep 2017 22:11:08 +0000 (15:11 -0700)]
(maint) update changelog entry for support/compat clarification [skip
ci]
Hailee Kenney [Tue, 26 Sep 2017 20:31:11 +0000 (13:31 -0700)]
Merge pull request #707 from puppetlabs/jbondpdx-patch-1
minor edits to new material
Jean B [Tue, 26 Sep 2017 18:45:55 +0000 (11:45 -0700)]
minor edits to new material
TP Honey [Tue, 26 Sep 2017 09:23:47 +0000 (10:23 +0100)]
Merge pull request #657 from puppetlabs/binford2k-patch-1
This class should be private
Eric Putnam [Tue, 26 Sep 2017 02:23:02 +0000 (19:23 -0700)]
Merge pull request #705 from HAIL9000/maint/release/MODULES_5628_apt_4.2.0_release_prep
(MODULES-5628) 4.2.0 release prep
Ben Ford [Mon, 25 Sep 2017 23:34:03 +0000 (16:34 -0700)]
Update update.pp
Hailee Kenney [Mon, 25 Sep 2017 23:19:42 +0000 (16:19 -0700)]
(MODULES-5628) 4.2.0 release prep
Eric Putnam [Mon, 25 Sep 2017 22:33:08 +0000 (15:33 -0700)]
Merge pull request #704 from puppetlabs/release
(maint) Update release merge back
Helen [Mon, 25 Sep 2017 15:20:34 +0000 (16:20 +0100)]
Merge pull request #703 from tphoney/jle64-patch-1
apt_package_security_updates fact and test
tphoney [Mon, 25 Sep 2017 13:55:27 +0000 (14:55 +0100)]
adding unit tests for new fact
jle64 [Thu, 27 Jul 2017 13:37:25 +0000 (15:37 +0200)]
Add apt_package_security_updates fact
Helen [Mon, 25 Sep 2017 13:36:48 +0000 (14:36 +0100)]
Merge pull request #702 from tphoney/raoulbhatia
Switch to deb.debian.org and remove Debian 6.0
TP Honey [Mon, 25 Sep 2017 12:37:57 +0000 (13:37 +0100)]
Merge pull request #700 from deric/outdated-doc
Delete documentation for parameters that already has been removed
tphoney [Mon, 25 Sep 2017 11:18:15 +0000 (12:18 +0100)]
Switch to deb.debian.org and remove Debian 6.0
TP Honey [Mon, 25 Sep 2017 10:20:57 +0000 (11:20 +0100)]
Merge pull request #696 from trevorrea/master
Add 16.04 to list of distributions that should use software-properties-common.
TP Honey [Thu, 21 Sep 2017 16:07:55 +0000 (17:07 +0100)]
Merge pull request #701 from puppetlabs/msync_18sep17_892c4cf
(maint) modulesync
892c4cf
TP Honey [Thu, 21 Sep 2017 16:07:37 +0000 (17:07 +0100)]
Merge pull request #697 from aeber/master
fix documentation for parameter $proxy['port'] in class apt
Hailee Kenney [Mon, 18 Sep 2017 21:55:13 +0000 (14:55 -0700)]
(maint) modulesync
892c4cf
Tomas Barton [Mon, 18 Sep 2017 08:41:46 +0000 (10:41 +0200)]
Delete documentation for parameters that already has been removed
Hunter Haugen [Fri, 15 Sep 2017 18:47:42 +0000 (11:47 -0700)]
Merge pull request #698 from deric/MODULES-4686-fix
MODULES-4686: gpg keyserver import fails in Debian 9 (Stretch)
Tomas Barton [Wed, 13 Sep 2017 12:46:09 +0000 (14:46 +0200)]
fix apt-key resource syntax
Tomas Barton [Wed, 13 Sep 2017 09:16:36 +0000 (11:16 +0200)]
autorequire dirmngr package
* add Debian 9 as supported system
* move dirmngr ensure to init.pp
Tomas Barton [Mon, 11 Sep 2017 16:44:00 +0000 (18:44 +0200)]
support ubuntu
Tomas Barton [Mon, 11 Sep 2017 15:14:16 +0000 (17:14 +0200)]
ensure dirmngr is installed on Debian Stretch
Tomas Barton [Thu, 7 Sep 2017 12:18:08 +0000 (14:18 +0200)]
(MODULES-4686) fix incorrect GPG keys parsing on Debian 9
patch from Alex P (alexpr)
Anselm Eberhardt [Wed, 30 Aug 2017 09:01:43 +0000 (11:01 +0200)]
fix documentation for parameter $proxy['port'] in class apt
Documentation says 'port' should be a string. init.pp checks for type
integer.
Helen [Fri, 25 Aug 2017 14:25:05 +0000 (15:25 +0100)]
Merge pull request #665 from tigercomputing/master
Ignore subkeys in apt-key's output
Trevor Rea [Fri, 25 Aug 2017 11:33:44 +0000 (12:33 +0100)]
Add 16.04 to list of distributions that should use software-properties-common.
Helen [Mon, 21 Aug 2017 09:50:13 +0000 (10:50 +0100)]
Merge pull request #695 from pmcmaw/remove_debian6
(FM-6273) - Removing Debian 6
Paula McMaw [Mon, 21 Aug 2017 08:22:22 +0000 (09:22 +0100)]
(FM-6273) - Removing Debian 6
This is not supported any longer according to the following
documentation: https://docs.puppet.com/pe/latest/sys_req_os.html
TP Honey [Thu, 17 Aug 2017 13:11:21 +0000 (14:11 +0100)]
Merge pull request #694 from pmcmaw/rm_ubuntu
(MODULES-5501) - Remove unsupported Ubuntu
Paula McMaw [Thu, 17 Aug 2017 12:49:58 +0000 (13:49 +0100)]
(MODULES-5501) - Remove unsupported Ubuntu
Removing older version of Ubuntu that are not supported by the module.
TP Honey [Fri, 4 Aug 2017 13:07:07 +0000 (14:07 +0100)]
Merge pull request #690 from tpdownes/master
Allow user to modify loglevel of apt-get update Exec resource
TP Honey [Thu, 3 Aug 2017 10:06:28 +0000 (11:06 +0100)]
Merge pull request #693 from mauricemeyer/master
Fixed typo in "Configuring Apt from hiera example"
Maurice Meyer [Wed, 2 Aug 2017 13:25:41 +0000 (15:25 +0200)]
Fixed typo
Tom Downes [Tue, 1 Aug 2017 13:01:12 +0000 (08:01 -0500)]
Allow user to modify loglevel of apt-get update Exec resource so that its
execution goes unlogged
Hunter Haugen [Thu, 27 Jul 2017 23:09:34 +0000 (16:09 -0700)]
Merge pull request #692 from puppetlabs/maint-modsync-
915cde70e20
(maint) modulesync
915cde70e20
Glenn Sarti [Thu, 27 Jul 2017 21:53:16 +0000 (14:53 -0700)]
(maint) modulesync
915cde70e20
TP Honey [Tue, 11 Jul 2017 10:19:15 +0000 (11:19 +0100)]
Merge pull request #640 from ocadotechnology/dpkg_admin_lock
(MODULES-4118) Set dpkg option NoLocking in apt_updates fact
TP Honey [Tue, 11 Jul 2017 10:14:29 +0000 (11:14 +0100)]
Merge pull request #675 from hunner/update_changelog
(maint) Add bugfix to changelog
TP Honey [Tue, 11 Jul 2017 10:13:28 +0000 (11:13 +0100)]
Merge pull request #688 from puppetlabs/msync_modules5187
(MODULES-5187) mysnc puppet 5 and ruby 2.4
TP Honey [Tue, 11 Jul 2017 10:13:00 +0000 (11:13 +0100)]
Merge pull request #686 from hunner/bump_metadata
(MODULES-5144) Prep for puppet 5
Eric Putnam [Fri, 7 Jul 2017 18:26:18 +0000 (11:26 -0700)]
(maint) update sync.yml to not manage NOTICE
Eric Putnam [Thu, 6 Jul 2017 21:40:41 +0000 (14:40 -0700)]
(MODULES-5187) mysnc puppet 5 and ruby 2.4
Okumura Takahiro [Wed, 5 Jul 2017 08:42:20 +0000 (17:42 +0900)]
Fix broken markdown of CHANGELOG.md (#687)
* Fix broken markdown of CHANGELOG.md
Hunter Haugen [Mon, 26 Jun 2017 20:57:17 +0000 (13:57 -0700)]
(MODULES-5144) Prep for puppet 5
Ben Ford [Wed, 21 Jun 2017 15:15:51 +0000 (08:15 -0700)]
fix whitespace
TP Honey [Mon, 5 Jun 2017 09:38:59 +0000 (10:38 +0100)]
Merge pull request #684 from puppetlabs/release
Release 4.1.0 Mergeback
Hunter Haugen [Thu, 1 Jun 2017 17:37:20 +0000 (10:37 -0700)]
Merge pull request #679 from arioch/fix_typo
Hunter Haugen [Thu, 1 Jun 2017 17:36:29 +0000 (10:36 -0700)]
Merge pull request #682 from eputnam/fail_message
this failure is related to os.name, not os.release.full
Paula McMaw [Thu, 1 Jun 2017 13:21:18 +0000 (14:21 +0100)]
Merge pull request #683 from HelenCampbell/rpreppy
4.1.0 Release Prep
Helen Campbell [Thu, 1 Jun 2017 11:03:15 +0000 (12:03 +0100)]
4.1.0 Release Prep
Hunter Haugen [Wed, 31 May 2017 22:30:40 +0000 (15:30 -0700)]
Merge pull request #677 from syseleven/fix-4913
https://tickets.puppetlabs.com/browse/MODULES-4913
Prior to this commit, apt_key always sent auth basic header when source
came from http(s). This might fail for some webservers (e.g. Amazon S3)
when empty auth basic is sent.
Now apt_key only sends the auth basic header when userinfo can
be parsed from the URL.
Please backport this to 2.4.x, since this is the release before incompatibility changes are made.
Eric Putnam [Tue, 30 May 2017 15:13:13 +0000 (08:13 -0700)]
Merge pull request #681 from HelenCampbell/emptystringing
Ensure release allows empty strings
Tom Duckering [Tue, 31 Jan 2017 17:59:40 +0000 (17:59 +0000)]
Test to ensure empty string allowed for $release in apt::source
Test added to make sure when release is set to an empty string the
source file is rendered correctly.
Eric Putnam [Fri, 26 May 2017 16:51:10 +0000 (09:51 -0700)]
(maint) fix incorrect error message
this failure is related to os.name, not os.release.full
Hunter Haugen [Thu, 25 May 2017 23:07:59 +0000 (16:07 -0700)]
Merge pull request #680 from eputnam/remove_dim
this module is not able to find a value for `$keyserver` when it is
included in postgresql, as stated in the ticket. this changes the module
back to using the params.pp model. we can revisit data in modules once
LTS moves up from 4.7.0. for now, we need the compatibility.
Eric Putnam [Wed, 24 May 2017 17:34:25 +0000 (10:34 -0700)]
(MODULES-4973) rip out data in modules
this module is not able to find a value for `$keyserver` when it is
included in postgresql, as stated in the ticket. this changes the module
back to using the params.pp model. we can revisit data in modules once
LTS moves up from 4.7.0. for now, we need the compatibility.
Tom De Vylder [Thu, 18 May 2017 14:06:12 +0000 (16:06 +0200)]
Fix typo in hiera example
Helen [Wed, 17 May 2017 14:37:47 +0000 (15:37 +0100)]
Merge pull request #678 from DavidS/revert-attribution-removal
Revert removal of Evolving Web's attribution in NOTICE file
David Schmitt [Wed, 17 May 2017 14:02:22 +0000 (15:02 +0100)]
Revert removal of Evolving Web's attribution in NOTICE file
This reverts commit part of
26608d1ae2d2a3668a49357cd00dad97ce01d7cf .
Stefan Andres [Mon, 15 May 2017 08:21:50 +0000 (10:21 +0200)]
(#4913) apt_key now does not always send auth basic
Prior to this commit, apt_key always sent auth basic header when source
came from http(s). This might fail for some webservers (e.g. Amazon S3)
when empty auth basic is sent.
Now apt_key only sends the auth basic header when userinfo can
be parsed from the URL.
Erick Banks [Fri, 28 Apr 2017 18:11:27 +0000 (11:11 -0700)]
Merge pull request #676 from puppetlabs/release
4.0.0 Mergeback
Hunter Haugen [Wed, 26 Apr 2017 21:17:59 +0000 (14:17 -0700)]
(maint) Add bugfix to changelog
Hunter Haugen [Wed, 26 Apr 2017 18:34:24 +0000 (11:34 -0700)]
Merge branch 'master' into release
Hunter Haugen [Wed, 26 Apr 2017 18:30:11 +0000 (11:30 -0700)]
Merge pull request #672 from domcleal/architecture-fact
Fix architecture fact overriding unset `architecture` source option
Helen [Tue, 25 Apr 2017 15:56:26 +0000 (16:56 +0100)]
Merge pull request #674 from hunner/fix_specs
(maint) Fix for different versions
Hunter Haugen [Mon, 24 Apr 2017 19:02:04 +0000 (12:02 -0700)]
(maint) Fix for different versions
Eric Putnam [Mon, 24 Apr 2017 18:29:50 +0000 (11:29 -0700)]
Merge pull request #673 from hunner/secondRelease
Rebase of #668
Hunter Haugen [Mon, 24 Apr 2017 18:05:11 +0000 (11:05 -0700)]
(maint) bump version to 4.0.0
Hunter Haugen [Mon, 24 Apr 2017 17:20:20 +0000 (10:20 -0700)]
(maint) Unit test fixes
Helen Campbell [Tue, 4 Apr 2017 10:57:35 +0000 (11:57 +0100)]
Removal of deprecated functionality
Helen Campbell [Tue, 4 Apr 2017 09:12:18 +0000 (10:12 +0100)]
Removal of compat types and validate_legacy calls
Dominic Cleal [Mon, 24 Apr 2017 07:30:15 +0000 (08:30 +0100)]
Fix architecture fact overriding unset `architecture` source option
When the `architecture` parameter to apt::source wasn't set, the
`architecture` fact would be used instead, causing the source to always
be limited by the architecture of the host.
The EPP variable has been renamed to avoid clashing with the fact name.
Hunter Haugen [Fri, 21 Apr 2017 17:03:54 +0000 (10:03 -0700)]
Merge pull request #671 from puppetlabs/release
Release Mergeback
Hunter Haugen [Mon, 17 Apr 2017 16:52:42 +0000 (09:52 -0700)]
(maint) Clear facter before to avoid parallel pollution
Hunter Haugen [Wed, 12 Apr 2017 18:19:32 +0000 (11:19 -0700)]
(maint) Stub fact exists call with argument passed
I can't replicate what's going on, but I wonder if the stub is being
bypassed and the actual underlying debian filesystem is being hit. The
timestamps returned by the unit test are from just before the unit test
ran.
Hunter Haugen [Wed, 12 Apr 2017 03:38:37 +0000 (20:38 -0700)]
(maint) Move stubs for apt update fact
I can't reproduce this, so just a guess.
Hunter Haugen [Wed, 12 Apr 2017 02:17:05 +0000 (19:17 -0700)]
(maint) Two missed failures due to parallel specs
Eric Putnam [Wed, 12 Apr 2017 01:01:10 +0000 (18:01 -0700)]
Merge pull request #670 from hunner/fix_specs
(PUP-6856) Always define facts
Hunter Haugen [Wed, 12 Apr 2017 00:18:25 +0000 (17:18 -0700)]
(PUP-6856) Always define facts
If facts are not defined for hiera lookups, the lookup will fail instead
of falling back to common on puppet < 4.9.0
Hunter Haugen [Tue, 11 Apr 2017 22:50:45 +0000 (15:50 -0700)]
Merge pull request #667 from HelenCampbell/firstRelease
First Release prep for Puppet 4 language update
Helen Campbell [Tue, 20 Dec 2016 11:34:00 +0000 (11:34 +0000)]
Puppet 4 language update
Hailee Kenney [Fri, 7 Apr 2017 14:19:33 +0000 (15:19 +0100)]
Merge pull request #669 from puppetlabs/release
Release Mergeback
Paula McMaw [Thu, 6 Apr 2017 14:39:54 +0000 (15:39 +0100)]
Merge pull request #666 from HelenCampbell/release
2.4.0 Release Prep
Helen Campbell [Thu, 6 Apr 2017 11:13:14 +0000 (12:13 +0100)]
2.4.0 Release Prep
tiger-jmw [Wed, 5 Apr 2017 12:04:54 +0000 (13:04 +0100)]
Ignore subkeys in apt-key's output
The output of `apt-key adv --list-keys --with-colons --fingerprint --fixed-list-mode` is always a `pub` line followed by one of more `fpr` lines (for subkeys, if any). This can cause the wrong pairs of `pub` and `fpr` lines to be hashed, resulting in nonsense.
The ordering `pub`, `fpr`, `pub`, `fpr` is guaranteed by `apt-key`.
Therefore, this commit clears `fpr_line` when a `pub` line is encountered, to reset the grouping. The current code ignores subkeys anyway, so this is no more bad.
Helen [Tue, 4 Apr 2017 09:43:02 +0000 (10:43 +0100)]
Merge pull request #662 from puppetlabs/modules-4506
[msync] 786266 Implement puppet-module-gems, a45803 Remove metadata.json from locales config
Wilson McCoubrey [Wed, 29 Mar 2017 14:53:54 +0000 (15:53 +0100)]
[maint] Fix puppet-lint warnings introduced with 2.2.0 puppet-lint release
Wilson McCoubrey [Wed, 29 Mar 2017 10:46:41 +0000 (11:46 +0100)]
[msync] 786266 Implement puppet-module-gems, a45803 Remove metadata.json from locales config
Helen [Fri, 24 Mar 2017 11:34:41 +0000 (11:34 +0000)]
Merge pull request #660 from puppetlabs/modules-4528
[MODULES-4528] Replace Puppet.version.to_f version comparison from spec_helper.rb
Wilson McCoubrey [Wed, 22 Mar 2017 15:06:27 +0000 (15:06 +0000)]
[MODULES-4528] Replace Puppet.version.to_f version comparison from spec_helper.rb
Hailee Kenney [Mon, 20 Mar 2017 14:02:55 +0000 (14:02 +0000)]
Merge pull request #658 from puppetlabs/MODULES-4528
[MODULES-4528] Replace Puppet.version.to_f with Puppet::Util::Package.versioncmp