]> review.fuel-infra Code Review - openstack-build/cinder-build.git/log
openstack-build/cinder-build.git
9 years agoVMware: Remove VMDK driver for ESX server
Vipin Balachandran [Fri, 14 Aug 2015 06:15:51 +0000 (11:45 +0530)]
VMware: Remove VMDK driver for ESX server

The VMDK driver for ESX server was deprecated during
Icehouse release. Configuring Cinder to use this driver
prints a warning that the driver is deprecated and
will be removed in the Juno release.

This patch removes the deprecated VMDK driver for
ESX server.

Closes-Bug: #1494701
Change-Id: I8c0ad19cf09016c112d242f93b24c6742acaa1e8

9 years agoMerge "Updated from global requirements"
Jenkins [Mon, 21 Sep 2015 08:36:02 +0000 (08:36 +0000)]
Merge "Updated from global requirements"

9 years agoMerge "Remove the unnecassary volume_api.get(context, volume_id)"
Jenkins [Sat, 19 Sep 2015 20:05:50 +0000 (20:05 +0000)]
Merge "Remove the unnecassary volume_api.get(context, volume_id)"

9 years agoMerge "Enable certificate verification during image copy"
Jenkins [Sat, 19 Sep 2015 19:50:18 +0000 (19:50 +0000)]
Merge "Enable certificate verification during image copy"

9 years agoMerge "Correctly report multiattach in Pure drivers"
Jenkins [Sat, 19 Sep 2015 15:02:32 +0000 (15:02 +0000)]
Merge "Correctly report multiattach in Pure drivers"

9 years agoDynamically create cinder.conf.sample
Kendall Nelson [Thu, 13 Aug 2015 15:17:36 +0000 (10:17 -0500)]
Dynamically create cinder.conf.sample

As it stands, the opts.py file that is passed into
oslo-config-generator isn't being generated dynamically
and the old way of generating the cinder.conf.sample is
dependent on oslo-incubator which Cinder is trying to
move away from. oslo-config-generator works differently
than oslo-incubator so a number of changes had to be made
in order to make this switch.

This patch adds the config directory to Cinder and in it
are two files:

    -generate_cinder_opts.py that will take the
     results of a grep command to create the opts.py
     file to be passed into oslo-config-generator.

    -cinder.conf which is the new configuration for
     oslo-config-generator. The file is inside the config
     directory to be consistent with other projects.

Some changes were made to the generate_sample.sh file in
order to give the base directories and target directories
to the generate_cinder_opts.py program.

tox.ini was edited to remove the checkonly option because
all that needs to happen in check_uptodate.sh is a check to
ensure that the cinder.conf.sample is actually being
generated with no issues.

All options were removed from the check_uptodate.sh
because they were unnecessary given the new, more simple
way of generating the cinder.conf.sample.

setup.cfg was also edited in order to add information
oslo-config-generator needs to run.

Co-Authored By: Jay Bryant <jsbryant@us.ibm.com>
Co-Authored By: Jacob Gregor <jgregor@us.ibm.com>

Change-Id: I643dbe5675ae9280e204f691781e617266f570d5
Closes-Bug: 1473768
Closes-Bug: 1437904
Closes-Bug: 1381563

9 years agoUpdated from global requirements
OpenStack Proposal Bot [Fri, 18 Sep 2015 16:37:17 +0000 (16:37 +0000)]
Updated from global requirements

Change-Id: I0dbe12dc8517e72a4bf00e811ca68fb07dc822c8

9 years agoMerge "Imported Translations from Zanata"
Jenkins [Fri, 18 Sep 2015 02:13:03 +0000 (02:13 +0000)]
Merge "Imported Translations from Zanata"

9 years agoMerge "NetApp: Fix volume extend with E-Series"
Jenkins [Thu, 17 Sep 2015 21:07:37 +0000 (21:07 +0000)]
Merge "NetApp: Fix volume extend with E-Series"

9 years agoMerge "Fix netapp_enable_multiattach default for E-Series"
Jenkins [Thu, 17 Sep 2015 21:04:26 +0000 (21:04 +0000)]
Merge "Fix netapp_enable_multiattach default for E-Series"

9 years agoMerge "Attaching enhancement for EMC VNX driver"
Jenkins [Thu, 17 Sep 2015 21:02:06 +0000 (21:02 +0000)]
Merge "Attaching enhancement for EMC VNX driver"

9 years agoMerge "Fix cinder-all binary"
Jenkins [Thu, 17 Sep 2015 12:18:06 +0000 (12:18 +0000)]
Merge "Fix cinder-all binary"

9 years agoImported Translations from Zanata
OpenStack Proposal Bot [Thu, 17 Sep 2015 06:19:43 +0000 (06:19 +0000)]
Imported Translations from Zanata

For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: I438ad26c586f382ab669bea9fa2556ea0a40c189

9 years agoMerge "Fix issue of volume after host-assisted migration"
Jenkins [Thu, 17 Sep 2015 00:11:51 +0000 (00:11 +0000)]
Merge "Fix issue of volume after host-assisted migration"

9 years agoFix cinder-all binary
Ivan Kolodyazhny [Tue, 15 Sep 2015 22:01:37 +0000 (01:01 +0300)]
Fix cinder-all binary

1. Add rpc.init for cinder-api service
2. Add multi-backend support for cinder-volume service

Closes-Bug: #1496154
Change-Id: I91626bd74fc224302e131c5235030a02431a04c1

9 years agoMerge "Check for None on service's updated_at"
Jenkins [Wed, 16 Sep 2015 21:47:23 +0000 (21:47 +0000)]
Merge "Check for None on service's updated_at"

9 years agoMerge "Extra specs may not be in volume types"
Jenkins [Wed, 16 Sep 2015 20:36:11 +0000 (20:36 +0000)]
Merge "Extra specs may not be in volume types"

9 years agoMerge "Fix QoS keys not being available to scheduler"
Jenkins [Wed, 16 Sep 2015 20:34:18 +0000 (20:34 +0000)]
Merge "Fix QoS keys not being available to scheduler"

9 years agoNetApp: Fix volume extend with E-Series
Michael Price [Tue, 25 Aug 2015 22:36:44 +0000 (17:36 -0500)]
NetApp: Fix volume extend with E-Series

Thin provisioned volumes were being converted to thick provisioned
volumes by extend_volume. When thin provisioning support was added,
the extend_volume method was not updated to use the correct API
for performing the capacity expansion operation.

This patch changes the volume extension strategy when a volume is
thin provisioned to use the correct API. With a thick provisioned
volume, a clone will be created with the new capacity, and the old
volume removed, but a thin provisioned volume's capacity can simply
be expanded directly, because that is merely the capacity that the user
sees, as opposed to the backend provisioned capacity.

Closes-Bug: 1493874
Change-Id: Iec25f29381d5fba3409d1de83bf6816ae1a9ac22

9 years agoFix netapp_enable_multiattach default for E-Series
Michael Price [Wed, 2 Sep 2015 18:48:05 +0000 (13:48 -0500)]
Fix netapp_enable_multiattach default for E-Series

The E-Series driver erroneously changed the netapp_enable_multiattach
option to default to True. This option should default to False to
ensure backwards-compatibility with upgrades.

DocImpact
Closes-Bug: #1491580
Change-Id: Iafb4d80bd83c2de0a5b77178206c7f3028ac6554

9 years agoCheck for None on service's updated_at
Michal Dulko [Tue, 15 Sep 2015 13:52:57 +0000 (15:52 +0200)]
Check for None on service's updated_at

We weren't checking if service's updated_at is None when passing it to
timeutils.normalize_time which caused an exception. This commit adds
the check to cinder-manage and cinder-api (services and hosts). Also
regression unit tests are added.

Change-Id: Ia6ee28dc2cd20cece1e21d07692f47e3858d707d
Closes-Bug: 1495938

9 years agoFix issue of volume after host-assisted migration
peter_wang [Fri, 21 Aug 2015 05:33:44 +0000 (01:33 -0400)]
Fix issue of volume after host-assisted migration

In host-assisted migration, Cinder framework currently doesn't
update name_id and provider_location when the driver doesn't provide
name_id or provider_location in update_migrated_volume

This changes previous Cinder behavior which will update name_id and
provider_location anyway. Any operation against this volume will not
be successful; for example, volume deletion cannot delete it's
underlying LUN.

This fix will update name_id and provider_location if driver doesn't
return them.

Closes-Bug: #1487952
Change-Id: Ice72fc792f0ea8909c027e6df99cff9bbeef5e48

9 years agoMerge "Tests: Split VolumeTestCase into separate classes"
Jenkins [Wed, 16 Sep 2015 10:57:40 +0000 (10:57 +0000)]
Merge "Tests: Split VolumeTestCase into separate classes"

9 years agoMerge "Snapmirror targets should not be reported as pools"
Jenkins [Wed, 16 Sep 2015 10:57:29 +0000 (10:57 +0000)]
Merge "Snapmirror targets should not be reported as pools"

9 years agoMerge "Change check method for 'all_tenants'"
Jenkins [Wed, 16 Sep 2015 10:57:18 +0000 (10:57 +0000)]
Merge "Change check method for 'all_tenants'"

9 years agoMerge "Create CG needs extra specs"
Jenkins [Wed, 16 Sep 2015 10:55:09 +0000 (10:55 +0000)]
Merge "Create CG needs extra specs"

9 years agoAttaching enhancement for EMC VNX driver
Xi Yang [Wed, 9 Sep 2015 08:26:20 +0000 (04:26 -0400)]
Attaching enhancement for EMC VNX driver

Remove the lun list command after adding the lun into a storage
group. This could improve the performance of initialize connection.

Change-Id: Id49725f50cd0e7600feb2ffc98a5b1ef14bc531c
Closes-Bug: #1495806

9 years agoMerge "Local img-cache files ignored for image transfers"
Jenkins [Wed, 16 Sep 2015 05:14:05 +0000 (05:14 +0000)]
Merge "Local img-cache files ignored for image transfers"

9 years agoTests: Split VolumeTestCase into separate classes
Eric Harney [Mon, 13 Jul 2015 15:20:56 +0000 (11:20 -0400)]
Tests: Split VolumeTestCase into separate classes

Organize the large VolumeTestCase class into a few
subclasses.

Change-Id: I1538445533bc6c14668177443cbc8f676731896d

9 years agoMerge "Fix NetApp clone from glance failure"
Jenkins [Tue, 15 Sep 2015 19:26:46 +0000 (19:26 +0000)]
Merge "Fix NetApp clone from glance failure"

9 years agoLocal img-cache files ignored for image transfers
Mike Rooney [Mon, 31 Aug 2015 15:29:53 +0000 (11:29 -0400)]
Local img-cache files ignored for image transfers

The cDOT NFS driver will only attempt to use the local img-cache-*
files if the copy offload path is defined in the cinder.conf file.
This should be attempted regardless of copy-offload's configuration.

Change-Id: I29e19da7c1e083e9c76cbcea1f397deefe30b016
Closes-Bug: #1490641

9 years agoSnapmirror targets should not be reported as pools
Mike Rooney [Mon, 22 Jun 2015 17:58:12 +0000 (13:58 -0400)]
Snapmirror targets should not be reported as pools

Snapmirror targets that were being reported to the Cinder
scheduler as available pools are now no longer reported as such.

Change-Id: I04faa9d7c448b91e66192770b09db84df78a8ae1
Closes-Bug: #1468004

9 years agoChange check method for 'all_tenants'
liyuanyuan [Thu, 10 Sep 2015 05:52:00 +0000 (05:52 +0000)]
Change check method for 'all_tenants'

Replaced with calls to get_bool_param from utils,
so it supports any boolean value like the rest of the API methods.

APIImpact: The API will also allow to pass 'yes', 'no', 'y', 'n'
as valid boolean strings in addition.

Change-Id: I397b0dfb688e0e6278eac75978df28bf6f99d0a9
Closes-Bug: #1494130

9 years agoEnable certificate verification during image copy
Vipin Balachandran [Tue, 25 Aug 2015 11:36:16 +0000 (17:06 +0530)]
Enable certificate verification during image copy

The VMDK driver config options 'vmware_ca_file' and 'vmware_insecure'
are ignored while copying sparse or preallocated vmdk images to vCenter
datastores for volume creation. Therefore, the vCenter certificate is
not verified during image copy.

This patch sets appropriate parameters in the oslo.vmware API (for
copying images) call to enable vCenter certificate verification.

Closes-bug: #1493331
Change-Id: I04f6a6def9867a573258b0d37693b1824e415838

9 years agoMerge "Fix volume lookups in SolidFire template caching"
Jenkins [Tue, 15 Sep 2015 03:20:10 +0000 (03:20 +0000)]
Merge "Fix volume lookups in SolidFire template caching"

9 years agoFix NetApp clone from glance failure
Tom Barron [Thu, 10 Sep 2015 23:53:29 +0000 (19:53 -0400)]
Fix NetApp clone from glance failure

When glance and cinder are backed by the same NetApp DOT flexvol
container, exposed as an NFS share, a direct clone is attempted
of the backing files rather than a copy.  With the advent of
kilo 2015.1.1, this clone operation fails with the message:
"Image cloning unsuccessful ... need more than 2 values to unpack."

The issue here is that the clone path code is calling the parent
nfs class _is_share_eligible() method to see if there is enough
space on the destination flexvol and this method calls _get_capacity_info()
expecting a three-tuple to be returned.  However, commit
e52f304313efc695f7dd89c222041bffd53c131a deliberately changed the return
values of _get_capacity_info() within the NetApp drivers to return
a 2-tuple, based on API calls to obtain capacity information from
the NetApp storage arrays. That commit missed that this method
would also be invoked by the parent nfs class _is_share_eligible()
method, which expects a different signature.

The fix in this commit is to replace the call to the parent
_is_share_eligible() method with a more appropriate NetApp class
specific _share_has_space_for_clone() method.  This new method
uses the NetApp version of _get_capacity_info to get space information
from the arrays via NetApp apis and expects a 2-tuple to be returned
from this method.

Change-Id: Ib0c69e5ea7b32d17930fe0bdcdb9357fd4e4a244
Closes-bug: 1490845

9 years agoMerge "Fix usage of novaclient"
Jenkins [Tue, 15 Sep 2015 01:52:53 +0000 (01:52 +0000)]
Merge "Fix usage of novaclient"

9 years agoMerge "Remove driver.set_execute()"
Jenkins [Tue, 15 Sep 2015 01:50:39 +0000 (01:50 +0000)]
Merge "Remove driver.set_execute()"

9 years agoMerge "Storwize: Fix format string"
Jenkins [Mon, 14 Sep 2015 23:37:11 +0000 (23:37 +0000)]
Merge "Storwize: Fix format string"

9 years agoMerge "Fix order of arguments in assertEqual"
Jenkins [Mon, 14 Sep 2015 22:25:42 +0000 (22:25 +0000)]
Merge "Fix order of arguments in assertEqual"

9 years agoStorwize: Fix format string
Eric Harney [Mon, 14 Sep 2015 17:12:15 +0000 (13:12 -0400)]
Storwize: Fix format string

String accidentally used %{count}s instead of %(count)s.

Change-Id: Ibe54927f4847f947f3a3053150ee3593e04595ee

9 years agoFix usage of novaclient
Ivan Kolodyazhny [Fri, 11 Sep 2015 11:23:02 +0000 (14:23 +0300)]
Fix usage of novaclient

We should use 'client interface' for initialization of novaclient
instead of direct import of some specific client.

Change-Id: I51254e20151fe1d6771897e64a8d0bdf2d674d03
Closes-Bug: #1493576

9 years agoMerge "Check for empty attributes on SF volume"
Jenkins [Mon, 14 Sep 2015 16:25:55 +0000 (16:25 +0000)]
Merge "Check for empty attributes on SF volume"

9 years agoCheck for empty attributes on SF volume
John Griffith [Sun, 13 Sep 2015 14:52:53 +0000 (08:52 -0600)]
Check for empty attributes on SF volume

This should not happen, but; we should be more strict
about our dict reading/checking and always make sure
the key item actually comes back and exists.

In the case of volume['attributes'] we were always
assuming this to be present which should be "ok", but
it's better to verify if rather than assuming, so this
patch adds a simple verification step before trying to
fetch on volume['attributes'].

Change-Id: I37a134a735aaf043aed1230d57fe458bb3a60240
Closes-Bug: #1495247

9 years agoMerge "Add consistency group tests to test_volume_rpcapi"
Jenkins [Mon, 14 Sep 2015 07:14:26 +0000 (07:14 +0000)]
Merge "Add consistency group tests to test_volume_rpcapi"

9 years agoMerge "Remove empty rules from policies for API access"
Jenkins [Mon, 14 Sep 2015 06:56:15 +0000 (06:56 +0000)]
Merge "Remove empty rules from policies for API access"

9 years agoMerge "Huawei: fix multi REST-URLs bug"
Jenkins [Mon, 14 Sep 2015 06:51:55 +0000 (06:51 +0000)]
Merge "Huawei: fix multi REST-URLs bug"

9 years agoMerge "Don't rely on provider_id for resource deletion"
Jenkins [Sun, 13 Sep 2015 02:06:30 +0000 (02:06 +0000)]
Merge "Don't rely on provider_id for resource deletion"

9 years agoMerge "Retrieve volume in update_migrated_volume"
Jenkins [Sat, 12 Sep 2015 23:47:01 +0000 (23:47 +0000)]
Merge "Retrieve volume in update_migrated_volume"

9 years agoMerge "Fix Pure get pgroup volume snapshot name"
Jenkins [Sat, 12 Sep 2015 19:13:03 +0000 (19:13 +0000)]
Merge "Fix Pure get pgroup volume snapshot name"

9 years agoFix volume lookups in SolidFire template caching
John Griffith [Fri, 11 Sep 2015 19:57:32 +0000 (19:57 +0000)]
Fix volume lookups in SolidFire template caching

There's a number of issues with the SolidFire template caching
code.  There are a number of metadata items that aren't consistent
between Glance API V1 and V2, there's also some problems with how
the code is dealing with it's internal volume and just flat out
wrong account checking.

This patch focuses mainly on fixing up the account and volumeID
issues.  The _do_clone method currently expects to find the src
volume under the same account as the dest volume.  That's fine
for most cases, but doesn't work for either the SolidFire template
caching, or for the use of generic image caching in Cinder.

We fix that easily by modifying the _get_sf_volume call to have an
option to search all active volumes on the Cluster instead of just
those for a specified account.  For now we only change the clone
methods, as they're the only case where we fall into the case of
cross-ownership of volumes in the same context.

The other issue is around the cleanup/delete in the case of a
failed template-volume create.  In this case we were passing in
the Cinder UUID to a direct SolidFire API delete cmd, which
is wrong.  The direct call for the SolidFire API call requires
that the actual SolidFire ID be used.  So we leverage the modified
_get_sf_volume call here as well.

Another issue that was introduced was the introduction of
a connector object to the intialize_connection call.  We
got around this once already by just passing in a fake
connector that was actually a string.  That was fine, but
the initialize_connection routine also now checks the connector
for multi_attach, so it fails the _get call on a string.  We
fix that by just building a dict and using that instead of
a fake string.

Finally, the method of relying on the Glance metadata virt size
has been problematic, it's not set by default, it's not accurate
and it's a bit inefficient.  There have been a number of issues
with this method of size determination, so we'll dump that and
just leverage the image_utils methods directly.

Change-Id: Icfd6668389049d3d5686acdb832847aa2d2fce52
Closes-Bug: #1494830
Closes-Bug: #1494927

9 years agoDon't rely on provider_id for resource deletion
John Griffith [Fri, 11 Sep 2015 06:21:40 +0000 (06:21 +0000)]
Don't rely on provider_id for resource deletion

Provider_id info isn't necessarily reliable when dealing
with failure cases.  There are a number of cases where the
info in the Cinder database may not be updated.

This change uses the old delete routines instead of trying
to use the provider_id info.  There are ways to do both,
however it's probably not that beneficial for now.

Change-Id: Idbfd98b19f3c7f1b231ed26a2cc6c98aa2899e2a
Closes-Bug: #1494597

9 years agoMerge "Lenovo driver fix access to common opts"
Jenkins [Fri, 11 Sep 2015 22:37:41 +0000 (22:37 +0000)]
Merge "Lenovo driver fix access to common opts"

9 years agoMerge "HPMSA fix access to common options"
Jenkins [Fri, 11 Sep 2015 22:37:31 +0000 (22:37 +0000)]
Merge "HPMSA fix access to common options"

9 years agoMerge "Dothill fix options access"
Jenkins [Fri, 11 Sep 2015 22:37:21 +0000 (22:37 +0000)]
Merge "Dothill fix options access"

9 years agoMerge "LeftHand Add update_migrated_volume to drivers"
Jenkins [Fri, 11 Sep 2015 22:19:33 +0000 (22:19 +0000)]
Merge "LeftHand Add update_migrated_volume to drivers"

9 years agoFix Pure get pgroup volume snapshot name
Patrick East [Fri, 11 Sep 2015 21:12:03 +0000 (14:12 -0700)]
Fix Pure get pgroup volume snapshot name

When creating a volume from a consistency group snapshot we have to go
look up the volume level snapshot from the group. Previously we could
just directly get to the cgsnapshot model from the snapshot. After we
switched to using the snapshot objects however we cannot do that (at
least not until we have cgsnapshot objects too).

As an interim solution we did a query to the REST API on the array to
just list all of the snapshots. Unfortunately that doesn’t work on all
versions of the Purity REST API. To have a more usable solution we need
to do a db lookup to get the pgsnapshot.

It’s not ideal, and will be removed ASAP, but for now we need to at
least not regress in functionality.

Change-Id: I73a4ad5883bf33ce282b5a49aa8acba66ffcb84f
Closes-Bug: #1494934

9 years agoMerge "LVM: add the exception handling to volume copy"
Jenkins [Fri, 11 Sep 2015 21:46:52 +0000 (21:46 +0000)]
Merge "LVM: add the exception handling to volume copy"

9 years agoMerge "Hacking log format arg check"
Jenkins [Fri, 11 Sep 2015 21:25:44 +0000 (21:25 +0000)]
Merge "Hacking log format arg check"

9 years agoMerge "Add ConsistencyGroup object entries to linstack.py"
Jenkins [Fri, 11 Sep 2015 19:33:25 +0000 (19:33 +0000)]
Merge "Add ConsistencyGroup object entries to linstack.py"

9 years agoMerge "VMware: Fix invalid product name"
Jenkins [Fri, 11 Sep 2015 19:32:25 +0000 (19:32 +0000)]
Merge "VMware: Fix invalid product name"

9 years agoMerge "Fixed missing log variable types"
Jenkins [Fri, 11 Sep 2015 19:14:31 +0000 (19:14 +0000)]
Merge "Fixed missing log variable types"

9 years agoDothill fix options access
Walter A. Boring IV [Fri, 11 Sep 2015 18:32:29 +0000 (18:32 +0000)]
Dothill fix options access

This patch fixes invalid access to the options that live
in the dothill_common.  They were recently renamed from
common_opt to common_opts, but the drivers weren't updated.

Change-Id: Iff411239a079f76c874b7b11f01a21f5f7d9f12e
Partial-Bug: 1494877

9 years agoHPMSA fix access to common options
Walter A. Boring IV [Fri, 11 Sep 2015 18:37:53 +0000 (18:37 +0000)]
HPMSA fix access to common options

This patch fixes access to the options defined in
hpmsa_common.  They were recently renamed from common_opt
to common_opts, but the drivers weren't updated.

Change-Id: I381e61c8e44454f29bc6ff6f1a5a82bbc8ab9436
Partial-Bug: 1494877

9 years agoLenovo driver fix access to common opts
Walter A. Boring IV [Fri, 11 Sep 2015 18:35:19 +0000 (18:35 +0000)]
Lenovo driver fix access to common opts

This patch fixes access to the lenovo_common options.
They were recently renamed from common_opt to common_opts,
but the drivers weren't updated.

Change-Id: I63583394d58cb8fc791787df35ed04d30113fafe
Partial-Bug: 1494877

9 years agoMerge "Use version convert methods from oslo.utils"
Jenkins [Fri, 11 Sep 2015 17:12:56 +0000 (17:12 +0000)]
Merge "Use version convert methods from oslo.utils"

9 years agoMerge "Add migrate_volume to BaseVD"
Jenkins [Fri, 11 Sep 2015 17:12:46 +0000 (17:12 +0000)]
Merge "Add migrate_volume to BaseVD"

9 years agoMerge "backup init_host cleanup exception handling"
Jenkins [Fri, 11 Sep 2015 17:09:48 +0000 (17:09 +0000)]
Merge "backup init_host cleanup exception handling"

9 years agoFixed missing log variable types
Bridget McGinnis [Fri, 11 Sep 2015 04:35:05 +0000 (23:35 -0500)]
Fixed missing log variable types

There were several cases of log messages that were missing
string formatting types. This patch adds the missing types.

Change-Id: If4336dafeb455cc1edd958219b1ffdd50bb2ca05
Closes-Bug: #1494574

9 years agoVMware: Fix invalid product name
Vipin Balachandran [Thu, 13 Aug 2015 13:29:30 +0000 (18:59 +0530)]
VMware: Fix invalid product name

The VMDK driver configuration uses invalid product name "VC"
instead of "vCenter". This patch replaces "VC" with "vCenter"
in help messages and code documentation. This change is
consistent with the rest of driver documentation.

DocImpact
  Replaced "VC" with "vCenter" in driver config option help
  messages

Closes-Bug: #1494636
Change-Id: I0b93d2e25d68ea05a694e04dcf6717065f315c16

9 years agoRetrieve volume in update_migrated_volume
lisali [Sun, 6 Sep 2015 06:05:22 +0000 (06:05 +0000)]
Retrieve volume in update_migrated_volume

When transferring db volume module through RPC call, it becomes
dict objects during RPC call. The attributes/properties
of the type can't be used.
As a result, to get volume['name'] raises KeyError.

The issue is fixed by retrieving volume from db.
Using volume version object will fix everything but it is
too late in Liberty. To keep code consistency, db.get_volume
is used in the fix.

Change-Id: I5ac7f083d5b4b7490347069728eb4b938c20885c
Closes-bug: 1491210

9 years agoMerge "Fix typos in comments"
Jenkins [Fri, 11 Sep 2015 01:44:54 +0000 (01:44 +0000)]
Merge "Fix typos in comments"

9 years agoMerge "Swap the decorator order for PureFCDriver methods"
Jenkins [Fri, 11 Sep 2015 01:25:53 +0000 (01:25 +0000)]
Merge "Swap the decorator order for PureFCDriver methods"

9 years agoMerge "Add ScaleIO Cinder driver commands"
Jenkins [Thu, 10 Sep 2015 23:57:16 +0000 (23:57 +0000)]
Merge "Add ScaleIO Cinder driver commands"

9 years agoMerge "SolidFire provider_id for snapshots on init"
Jenkins [Thu, 10 Sep 2015 22:35:06 +0000 (22:35 +0000)]
Merge "SolidFire provider_id for snapshots on init"

9 years agoMerge "Fix block_device driver to behave as documented"
Jenkins [Thu, 10 Sep 2015 22:09:34 +0000 (22:09 +0000)]
Merge "Fix block_device driver to behave as documented"

9 years agoSwap the decorator order for PureFCDriver methods
Patrick East [Thu, 10 Sep 2015 20:00:27 +0000 (13:00 -0700)]
Swap the decorator order for PureFCDriver methods

Right now the debug trace decorator is logging the decorator method from
the FCZM helper and not the actual driver methods its supposed to be.

Change-Id: If658393e5e9d1b3e068fc7a200998e8033ada48f
Closes-Bug: #1494459

9 years agoAdd ScaleIO Cinder driver commands
Xing Yang [Thu, 10 Sep 2015 19:31:39 +0000 (15:31 -0400)]
Add ScaleIO Cinder driver commands

ScaleIO Cinder driver commands are currently missing from
Cinder's rootwrap filters. Since we are not using os-brick's
rootwrap filters in Liberty, these missing commands need to be
added to Cinder's rootwrap filters.

Change-Id: Ia466a722a17730fa2104fa9a4b1898c6373d10ec
Closes-Bug: #1479530

9 years agoSolidFire provider_id for snapshots on init
John Griffith [Thu, 10 Sep 2015 00:59:38 +0000 (00:59 +0000)]
SolidFire provider_id for snapshots on init

We've added the provider_id field to the database for both
volumes and snapshots.  This however couldn't be used because
there was no upgrade/migration path included for backends to
populate these fields (ie upgrade from K to L).

This patch fixes the provider_id columns for snapshots and volumes
both, and updates these fields on backend init.  This fixes the
issue of not being able to "rely" on the database entries, and it
also fixes some issues with inefficiencies in how we were deleting
resources.

Now we can just use the provider_id info from the reference passed
in on the delete calls.

Change-Id: I9de02e9d12aa23ddf4e1fbb1e0efab2c1805fdb1
Closes-Bug: #bug/1491489

9 years agoLeftHand Add update_migrated_volume to drivers
Anthony Lee [Tue, 8 Sep 2015 22:29:17 +0000 (15:29 -0700)]
LeftHand Add update_migrated_volume to drivers

The LeftHand drivers were missing the method
update_migrated_volume, which was causing the volume IDs
to no longer be accurate after a volume was migrated into
a LeftHand array.

Change-Id: I3718edc68c750856313557aebd212f64f7edc389
Closes-Bug: 1493546

9 years agoMerge "ZFSSA driver to return project 'available' space"
Jenkins [Thu, 10 Sep 2015 17:51:42 +0000 (17:51 +0000)]
Merge "ZFSSA driver to return project 'available' space"

9 years agoHuawei: fix multi REST-URLs bug
zhaohua [Wed, 19 Aug 2015 07:57:48 +0000 (15:57 +0800)]
Huawei: fix multi REST-URLs bug

Huawei driver now supports multi REST-URLs, which means users can
write more than one REST-URLs in the config file(seperated by ";")
and driver can choose the usable one to set up a connection(see
function "login" in rest_client.py of Huawei driver).

But if the chosen REST-URL has some failures, Huawei driver can
not change to another REST-URL automatically.

To resolve this, rewrite the "call" function in rest_client.py of
Huawei driver. If REST command failed to send, driver will do a
"login" process to set up another connection, and send the failed
command to a new REST-URL again.

And change REST command timeout to 52s, change login timeout to 4s,
to avoid long time waiting for failure.

Change-Id: I50701b19896941db2a57984bd26a06ab7d2a7b4b
Closes-Bug: #1486326

9 years agoMerge "Add unmanage default implementation to VolumeDriver"
Jenkins [Thu, 10 Sep 2015 06:06:06 +0000 (06:06 +0000)]
Merge "Add unmanage default implementation to VolumeDriver"

9 years agoMerge "Pass in snapshot refs for host on provider_update"
Jenkins [Thu, 10 Sep 2015 04:00:25 +0000 (04:00 +0000)]
Merge "Pass in snapshot refs for host on provider_update"

9 years agoMerge "Filter hosts with pool in snapshot_get_by_host"
Jenkins [Thu, 10 Sep 2015 03:57:54 +0000 (03:57 +0000)]
Merge "Filter hosts with pool in snapshot_get_by_host"

9 years agoMerge "Fix NetApp loop in clone of NFS backed images"
Jenkins [Thu, 10 Sep 2015 03:48:03 +0000 (03:48 +0000)]
Merge "Fix NetApp loop in clone of NFS backed images"

9 years agoLVM: add the exception handling to volume copy
Vincent Hou [Mon, 31 Aug 2015 07:14:37 +0000 (15:14 +0800)]
LVM: add the exception handling to volume copy

If the volume copy fails from one vg to another one on
the same host, the destination volume on the destination
pool should be removed.

Change-Id: I41922e197e09827582e660a6a00b86aa7044093e
Closes-Bug: #1489335

9 years agoFix NetApp loop in clone of NFS backed images
Tom Barron [Mon, 24 Aug 2015 17:21:48 +0000 (13:21 -0400)]
Fix NetApp loop in clone of NFS backed images

If there is a list of locations for glance images and an unsuitable
location is encountered when iterating through the list, current code
breaks out of the loop, failing to find later, valid locations.

Here we fix this issue by ignoring invalid locations and continuing
through the loop rather than breaking out when we find invalid locations.

Closes-bug: 1487074

Change-Id: Id2435ba633629367fa1bd8f339fc283f47eeb012

9 years agoHacking log format arg check
Derrick J. Wippler [Thu, 3 Sep 2015 17:07:19 +0000 (12:07 -0500)]
Hacking log format arg check

Added hacking check for log lines that accidently pass a tuple as the
second argument when providing format arguments.

Change-Id: Ifba23948f9fb49e9f6a1ee7e743aba0cd864c827
Closes-Bug: 1415241

9 years agobackup init_host cleanup exception handling
Tom Barron [Wed, 26 Aug 2015 20:07:00 +0000 (16:07 -0400)]
backup init_host cleanup exception handling

Current cleanup of leftover backups, volumes, and temporary
volumes and snapshots is not resilient in the face of exceptions
such as failures in detach operations.

This commit adds appropriate try/except logic to this section
of code, thereby ensuring that the backup service can start even
if exceptions are encountered when attempting to cleanup detritus
from earlier failed backup operations.

Change-Id: Ie8d2107ebd4d86dfe5664c35687e8cbe58cfad9d
Closes-bug: 1485295

9 years agoMaking opt names consistent
Kendall Nelson [Wed, 9 Sep 2015 13:21:25 +0000 (08:21 -0500)]
Making opt names consistent

Wherever there are lists of options being registered, the name of
the list needs to be plural to be consistent with all other opt lists
being registered elsewhere. This change is necessary for the dynamic
generation of cinder.sample.conf.

Co-Authored-By: Jacob Gregor <jgregor@us.ibm.com>
Change-Id: I1434a195016a2a595d0205d73a78a60cd94137f8

9 years agoFix QoS keys not being available to scheduler
Anthony Lee [Wed, 19 Aug 2015 22:48:33 +0000 (15:48 -0700)]
Fix QoS keys not being available to scheduler

There is a qos_specs property contained within the properties
passed to filters and weighers during volume placement decision
time. Currently qos_specs is always set to None even when a
QoS spec is associated with a volume type.

This patch exposes the QoS keys by placing them in the
qos_specs property. When no QoS spec is associated with a volume
the qos_specs property would still be set to None.

Change-Id: I5d5d36b56efeadd0884abc2f541ccf44b1010a2e
Closes-Bug: #1486286

9 years agoAdd ConsistencyGroup object entries to linstack.py
Michal Dulko [Wed, 9 Sep 2015 15:20:18 +0000 (17:20 +0200)]
Add ConsistencyGroup object entries to linstack.py

Change I3febb95bb2b3dd8f10da4f01ffa705e39cb20520 wasn't passing pylint
gate because of missing objects_ignore_messages entries in linstack.py.
This commits adds these entries.

Change-Id: I9e42a065d6584b445f2fed8995de32adbea7739b
Closes-Bug: 1493905

9 years agoPass in snapshot refs for host on provider_update
John Griffith [Wed, 9 Sep 2015 15:15:31 +0000 (15:15 +0000)]
Pass in snapshot refs for host on provider_update

Now that snapshot_get_by_host is fixed we can and should
pass in a list of snapshot-refs to the drivers update_provider
method (just like we do with volumes).

Change-Id: I062efd1b7ab16f3f999464d3190c204026bba5ec
Closes-Bug: #1489182

9 years agoFilter hosts with pool in snapshot_get_by_host
Ivan Kolodyazhny [Wed, 9 Sep 2015 13:59:55 +0000 (16:59 +0300)]
Filter hosts with pool in snapshot_get_by_host

Snapshots use host field from the volume record. We need to ignore pool
if it is not specified in a host param for snapshot_get_by_host method.

Also snapshot_get_by_host will return empty list if host is None or an
empty string like a volume filer does.

Change-Id: I0d9eef8675d8dada3a0b6886dbb3f5807eecee73
Closes-Bug: #1493856

9 years agoFix typos in comments
Takashi NATSUME [Wed, 9 Sep 2015 08:34:25 +0000 (17:34 +0900)]
Fix typos in comments

suported => supported
proces => process
occured => occurred
do quota reserver => Reserve a quota

Change-Id: I97f1bfae8b62655b415ef8f61dc439416458d38d

9 years agoMerge "Return a tuple from SolidFire update_provider_info"
Jenkins [Wed, 9 Sep 2015 02:20:32 +0000 (02:20 +0000)]
Merge "Return a tuple from SolidFire update_provider_info"

9 years agoMerge "Filter scheduler: Fix KeyError on invalid create request"
Jenkins [Wed, 9 Sep 2015 02:19:11 +0000 (02:19 +0000)]
Merge "Filter scheduler: Fix KeyError on invalid create request"

9 years agoFilter scheduler: Fix KeyError on invalid create request
Eric Harney [Tue, 8 Sep 2015 22:40:53 +0000 (18:40 -0400)]
Filter scheduler: Fix KeyError on invalid create request

An invalid request can generate a KeyError here rather
than the intended failure message.

Closes-Bug: #1493580

Change-Id: Ia73d8c2834e564ee14d72303001e11be2ea14900

9 years agoUpdated from global requirements
OpenStack Proposal Bot [Tue, 8 Sep 2015 22:01:48 +0000 (22:01 +0000)]
Updated from global requirements

Change-Id: I100c3680608c7448dba1da3bd839b4ff2dc17f8d