]> review.fuel-infra Code Review - openstack-build/cinder-build.git/log
openstack-build/cinder-build.git
12 years agoConvert Cinder to use openstack-common jsonutils.
Zhiteng Huang [Tue, 17 Jul 2012 07:11:26 +0000 (15:11 +0800)]
Convert Cinder to use openstack-common jsonutils.

This patch replaces json handling code in Cinder with openstack-common
jsonutils.  Also remove some unused imports.

Implement blueprint cinder-common-jsonutils

Change-Id: I28c1a095823c2f04f30c32724144297a2d67fba4
Reviewed-on: https://review.openstack.org/9912
Reviewed-by: Mark McLoughlin <markmc@redhat.com>
Reviewed-by: Vish Ishaya <vishvananda@gmail.com>
Approved: John Griffith <john.griffith@solidfire.com>
Tested-by: Jenkins
12 years agoAdd missing ack to impl_qpid.
Russell Bryant [Tue, 12 Jun 2012 21:07:18 +0000 (17:07 -0400)]
Add missing ack to impl_qpid.

Fix bug 1012374.

Johannes Erdfelt pointed out that impl_qpid wasn't acking messages that
it received.  This turned out to be a nasty oversight, resulting in
unbounded message queue growth inside of the python-qpid library.  This
fixes it.

Change-Id: I0370293807f0282e1dbdd59246f70be031e888a9
Reviewed-on: https://review.openstack.org/9908
Reviewed-by: Vish Ishaya <vishvananda@gmail.com>
Approved: John Griffith <john.griffith@solidfire.com>
Tested-by: Jenkins
12 years agoMove queue_get_for() from db to rpc.
Russell Bryant [Tue, 29 May 2012 20:35:35 +0000 (16:35 -0400)]
Move queue_get_for() from db to rpc.

Part of blueprint common-rpc.

The function queue_get_for() is a utility function used by various
consumers of the rpc API.  This function lived in the db API, but never
ended up using anything from the database.  This patch moves it into the
rpc API so that it can be used by other users of rpc once it moves into
openstack-common.

Change-Id: If92675beecff5471b416a929c161b810e3c71939
Reviewed-on: https://review.openstack.org/9906
Reviewed-by: Vish Ishaya <vishvananda@gmail.com>
Approved: John Griffith <john.griffith@solidfire.com>
Tested-by: Jenkins
12 years agoAdd base support for rpc API versioning.
Russell Bryant [Mon, 7 May 2012 18:10:29 +0000 (14:10 -0400)]
Add base support for rpc API versioning.

Part of blueprint versioned-rpc-apis.

This commit includes the base support for versioned RPC APIs.  It
introduces the RpcProxy and RpcDispatcher classes that have common code
for handling versioning on the client and server sides, respectively.

RPC APIs will be converted one at a time using this infrastructure.

Change-Id: I07bd82e9ff60c356123950e466caaffdfce79eba
Reviewed-on: https://review.openstack.org/9901
Reviewed-by: Huang Zhiteng <zhiteng.huang@intel.com>
Reviewed-by: Vish Ishaya <vishvananda@gmail.com>
Approved: John Griffith <john.griffith@solidfire.com>
Tested-by: Jenkins
12 years agoMake kombu support optional for running unit tests.
Russell Bryant [Wed, 2 May 2012 16:14:56 +0000 (12:14 -0400)]
Make kombu support optional for running unit tests.

Fix bug 838386.

Previously, the unit tests required kombu to be installed to run.  This
patch makes it so the unit tests will still complete successfully, even
if kombu is not installed.

Change-Id: I06831a37f8c857bbfd0bce1b1c3aeda7d341a589
Reviewed-on: https://review.openstack.org/9900
Reviewed-by: Vish Ishaya <vishvananda@gmail.com>
Approved: John Griffith <john.griffith@solidfire.com>
Tested-by: Jenkins
12 years agoStop using cinder.exception from cinder.rpc.
Russell Bryant [Tue, 15 May 2012 18:43:18 +0000 (14:43 -0400)]
Stop using cinder.exception from cinder.rpc.

This patch is a part of continuing to remove dependencies from cinder.rpc
on the rest of cinder.  One RPC related exception was defined in
cinder.exception, so that was moved to cinder.rpc.common where the rest of
them live.  These exceptions were changed to no longer use CinderException
as their base.  Instead, there is a new RPCException base.

One other change that should be reviewed closely is the removal of using
cinder.exception.wrap_exception() in cinder.rpc.amqp.  As far as I can tell,
this didn't actually do anything since nothing was being passed in to
wrap_exception().

Change-Id: I36ff7c05ab0467ad8506b56d561c532eadf8dff8
Reviewed-on: https://review.openstack.org/9899
Reviewed-by: Vish Ishaya <vishvananda@gmail.com>
Approved: John Griffith <john.griffith@solidfire.com>
Tested-by: Jenkins
12 years agoRemove unused synchronization decorator
Mark McLoughlin [Tue, 17 Jul 2012 03:28:02 +0000 (04:28 +0100)]
Remove unused synchronization decorator

This is only used on the compute and network side in Nova.

Change-Id: I6211c32f585b1b5ff66d1a7a5f65dd25857d76f0
Reviewed-on: https://review.openstack.org/9888
Reviewed-by: Vish Ishaya <vishvananda@gmail.com>
Approved: John Griffith <john.griffith@solidfire.com>
Tested-by: Jenkins
12 years agoRemove 'cinder-manage config convert'
Mark McLoughlin [Mon, 16 Jul 2012 20:30:15 +0000 (21:30 +0100)]
Remove 'cinder-manage config convert'

This convers the old flagfile style config files into the the
new .ini style config files. Since Cinder is new and it's first
release will only support .ini style files there's no need for
such a command.

Change-Id: Ie2f4cd8b6f5fc66547a59d39aa3d5eb896b1ddf4
Reviewed-on: https://review.openstack.org/9871
Reviewed-by: Huang Zhiteng <zhiteng.huang@intel.com>
Reviewed-by: Vish Ishaya <vishvananda@gmail.com>
Approved: John Griffith <john.griffith@solidfire.com>
Tested-by: Jenkins
12 years agoUse cfg's new behavior of reset() clearing overrides
Mark McLoughlin [Mon, 16 Jul 2012 20:10:17 +0000 (21:10 +0100)]
Use cfg's new behavior of reset() clearing overrides

Cherry-picks b858108 from Nova.

Change-Id: I5e14dea25afd5bff03a39671b2d3b85481977bec
Reviewed-on: https://review.openstack.org/9868
Reviewed-by: Huang Zhiteng <zhiteng.huang@intel.com>
Reviewed-by: Vish Ishaya <vishvananda@gmail.com>
Approved: John Griffith <john.griffith@solidfire.com>
Tested-by: Jenkins
12 years agoMerge changes Id5a0ffab,If283dd7c,I1a11e8fd
Jenkins [Thu, 19 Jul 2012 08:11:23 +0000 (08:11 +0000)]
Merge changes Id5a0ffab,If283dd7c,I1a11e8fd

* changes:
  Remove old flagfile support
  Misused and not used config options
  Pass 'cinder' project into ConfigOpts

12 years agoMerge "Convert Cinder to use openstack-common timeutils"
Jenkins [Wed, 18 Jul 2012 17:32:54 +0000 (17:32 +0000)]
Merge "Convert Cinder to use openstack-common timeutils"

12 years agoRemove old flagfile support
Ghe Rivero [Mon, 16 Jul 2012 19:31:51 +0000 (20:31 +0100)]
Remove old flagfile support

Cherry-picks 7e3e9b8 from Nova.

Change-Id: Id5a0ffabf7c6eab0bbda1b130a39a6581b26e350

12 years agoMisused and not used config options
Zhongyue Luo [Mon, 16 Jul 2012 19:37:54 +0000 (20:37 +0100)]
Misused and not used config options

Cherry picks dc9c3cb from Nova.

Fixes bug #1000071

[nova.api.sizelimit.py]
osapi_max_request_body_size: BoolOpt -> IntOpt

[nova.rpc.__init__.py]
allowed_rpc_exception_modules: IntOpt -> ListOpt

[nova.volume.driver.py]
num_shell_tries: StrOpt -> IntOpt
num_iscsi_scan_tries: StrOpt -> IntOpt

[nova.volume.driver.py]
san_thin_provision: 'true' -> True
san_is_local: 'false' -> False

Change-Id: If283dd7c4feba69c07bd483acd14f45c2659b743

12 years agoPass 'cinder' project into ConfigOpts
Rick Harris [Mon, 16 Jul 2012 19:33:45 +0000 (20:33 +0100)]
Pass 'cinder' project into ConfigOpts

Cherry-picks fb96f7d from Nova.

Change-Id: I1a11e8fd6a56b2336457f7df178c2b3c187246c3

12 years agoSync to newer openstack.common.cfg
Mark McLoughlin [Mon, 16 Jul 2012 19:48:02 +0000 (20:48 +0100)]
Sync to newer openstack.common.cfg

Cherry picks e0d891e from Nova.

Changes since last sync are:

 * New ConfigOpts.find_file() for locating conf files
 * Support for directory source of config files
 * Provide file extension when when looking for files
 * Some refactoring of the cfg cache
 * Add caching to openstack.common.cfg

Change-Id: If9852d0431093d590252bb704e934a4a56ef0263

12 years agoConvert Cinder to use openstack-common timeutils
Zhiteng Huang [Fri, 13 Jul 2012 05:58:25 +0000 (13:58 +0800)]
Convert Cinder to use openstack-common timeutils

This patch is part of effort to get Cinder to use openstack-common
package.  This part is to replace time related functions in utils.py
with 'timeutils' module.

Implement blueprint cinder-common-timeutils

Change-Id: Ic5e9e317a95a7399f0604823eec76b3642a0c1b1

12 years agoMerge "Updated HpSanISCSIDriver to use initialize/terminate methods."
Jenkins [Thu, 12 Jul 2012 20:03:42 +0000 (20:03 +0000)]
Merge "Updated HpSanISCSIDriver to use initialize/terminate methods."

12 years agoDo not duplicate nova docs in cinder
John Griffith [Thu, 12 Jul 2012 15:01:14 +0000 (09:01 -0600)]
Do not duplicate nova docs in cinder

* This modifies the index.rst file to give interim info about cinder
* We were regenerating the nova docs copied over which was bad!
* Fixes bug 1022315

Change-Id: I46531976f3e6521cec69cc13276d328d6c2d2da3

12 years agoRemove unused db api methods
John Griffith [Sat, 7 Jul 2012 00:28:53 +0000 (18:28 -0600)]
Remove unused db api methods

  * Implements cinder blueprint remove-extra-dbapi-methods
  * Related to cinder initial-db-cleanup:
      Remove db api methods associated with removed tables
  Modify/Remove tests associated with removed tables
  Remove non-existing db API calls from volume/api

Change-Id: I60e0c6ffad9c78a29d56a27a04e9ec5ebaa1f251

12 years agoCreate single initial Cinder DB migration file
John Griffith [Tue, 3 Jul 2012 22:40:15 +0000 (16:40 -0600)]
Create single initial Cinder DB migration file

 * Implements blueprint initial-db-cleanup
 * Sets initial migration
 * Removes unused tables that were brought in from nova
 * Condenses db migrations into the single initial migration/creation
 * Add explicit mysql set InnoDB in UTF8 loop
 * Folow up patches include:
 *    Remove unused db API calls
 *    Fix/Remove affected tests

Change-Id: If24b00747dbbff7037b7aca39602d5f0b1c6aa50

12 years agoUpdated HpSanISCSIDriver to use initialize/terminate methods.
Zhiteng Huang [Thu, 5 Jul 2012 07:08:34 +0000 (15:08 +0800)]
Updated HpSanISCSIDriver to use initialize/terminate methods.

This is based on Nirmal Ranganathan's patch for Nova-volume, which
added a new key 'host' for initialize/terminate volume connection
information in nova to fix bug 992729.

HpSanISCSIDriver should adopt the change in order to work properly.
Also added missing unit tests for the HpSanISCSIDriver.

Fixes bug 992729.

Change-Id: I9584811a340799161d8c9ae88b1def282380c9ad
Signed-off-by: Zhiteng Huang <zhiteng.huang@intel.com>
12 years agoPruned Authors file to active contributors (from nova-volumes).
Christopher MacGown [Wed, 4 Jul 2012 00:49:16 +0000 (17:49 -0700)]
Pruned Authors file to active contributors (from nova-volumes).

Active contributors was fetched from git blame output, for files
inside the nova/nova/volumes folder in nova.

Change-Id: I8cc63975bf1160ca76badc54fd4d51077873dfee

12 years agoMove nova-manage.rst to cinder-manage.rst.
Clark Boylan [Mon, 2 Jul 2012 21:17:31 +0000 (14:17 -0700)]
Move nova-manage.rst to cinder-manage.rst.

Cinder docs were not building because sphinx was looking for
cinder-manage.rst which did not exist. The file was simply misnamed
and renaming it to cinder-manage.rst allows the docs to build.

Change-Id: I68f4ed81230cc277a96bb34dfa172e5ce7788ac4

12 years agoAdd action extensions to support nova integration.
John Griffith [Wed, 13 Jun 2012 18:38:35 +0000 (12:38 -0600)]
Add action extensions to support nova integration.

 * Adds VolumeActions extension to support key functions
    described in blueprint volume-decoupling
 * Adds snapshot translations to APIs
 * Should be back in sync with 7992
 * blueprint compat-extensions
 * sleepsonthefloor: Moved added snapshot attributes to extension, added tests
 * sleepsonthefloor: Lock pep8==1.1 in tox.ini

Change-Id: I9c6118cd434ca8b275d2386546923f932420b975

12 years agoMerge "Revert "Add action extensions to support nova integration.""
Jenkins [Wed, 13 Jun 2012 18:23:58 +0000 (18:23 +0000)]
Merge "Revert "Add action extensions to support nova integration.""

12 years agoRevert "Add action extensions to support nova integration."
John Griffith [Wed, 13 Jun 2012 17:51:37 +0000 (17:51 +0000)]
Revert "Add action extensions to support nova integration."

This reverts commit 8d8903f466cd7d4270e46ad896817fe94c99b575

12 years agoMerge "Add action extensions to support nova integration."
Jenkins [Tue, 12 Jun 2012 04:26:40 +0000 (04:26 +0000)]
Merge "Add action extensions to support nova integration."

12 years agoFix volume['id'] from integer to string
John Griffith [Thu, 7 Jun 2012 20:38:29 +0000 (14:38 -0600)]
Fix volume['id'] from integer to string

* This is the same fix as nova bug 1010200
* Missed in volume uuid migration

Change-Id: Ib433ea6a1f247aad7fcba72680fd14e82387ed62

12 years agoAdd action extensions to support nova integration.
Anthony Young [Thu, 31 May 2012 19:03:02 +0000 (12:03 -0700)]
Add action extensions to support nova integration.

 * Adds VolumeActions extension to support key functions
   described in blueprint volume-decoupling

Change-Id: I1310c9e813c089619e8ecdf56c631d8257c0897e

12 years agoSet pep8 version to 1.1 in test_requires
John Griffith [Fri, 1 Jun 2012 16:46:14 +0000 (10:46 -0600)]
Set pep8 version to 1.1 in test_requires

* Fixes bug 1007518
* Changes in pep8 cause new failures
* Fix up the ones we found anyway

Change-Id: I5cd73a252f73893e4672a2e39b667c519423ae3f

12 years agoFix topics so that the do not collide with nova.
Anthony Young [Wed, 30 May 2012 22:24:41 +0000 (15:24 -0700)]
Fix topics so that the do not collide with nova.

 * Without this, there are issues running cinder if
   you have previously run n-vol
 * Fix pep8

Change-Id: Id56dbfd6c4f62a74cc57edcc7859753dd7e36229

12 years agoFix up coverage and jenkins test running.
Monty Taylor [Mon, 21 May 2012 18:40:18 +0000 (14:40 -0400)]
Fix up coverage and jenkins test running.

The docs job wasn't working because of an un-renamed file.
Coverage wasn't running in jenkins with the xml output file.
Remove the .cache.bundle support that we're moving away from.

Change-Id: I1140baa53dee8b14ac4d1f8549425a0fdd7a8425

12 years agoRemove instance Foreign Key in volumes table, replace with instance_uuid
John Griffith [Wed, 9 May 2012 17:02:34 +0000 (11:02 -0600)]
Remove instance Foreign Key in volumes table, replace with instance_uuid

* Remove the instance relationship and instance_id FK
* Add instance_uuuid column to volumes table

Change-Id: I54d723dcb9819731a58ec64095c54c99aa9e5dc4

12 years agoAlign the tox.ini file.
Monty Taylor [Fri, 4 May 2012 04:45:20 +0000 (21:45 -0700)]
Align the tox.ini file.

Change-Id: I0d1731f157d12bfcc1e4933dd71c49e9bda4116a

12 years agoRemoved cinder/api/openstack/compute and moved the relevant pieces under
Nirmal Ranganathan [Thu, 3 May 2012 19:54:27 +0000 (14:54 -0500)]
Removed cinder/api/openstack/compute and moved the relevant pieces under
cinder/api/openstack/volume. Fixes bug 994177.

Change-Id: I1b953a96a1d69a62ad312d381cead4cd231a3998

12 years agoInitial fork out of Nova.
Jenkins [Thu, 3 May 2012 17:48:26 +0000 (10:48 -0700)]
Initial fork out of Nova.