Zhongyue Luo [Sat, 18 May 2013 13:52:15 +0000 (21:52 +0800)]
Reference DEFAULT_SERVICETYPE OptGoup names in lowercase
To have consistent option group name format across projects,
oslo.config now normalizes all non lowercase group names to lowercase
when loading conf files.
Thus conf files are backwards compatible but option group references
in the code must now use lowercase before we update oslo.config.
This patch replaces all 'DEFAULT_SERVICETYPE' references to
'default_servicetype'
fujioka yuuichi [Tue, 14 May 2013 00:01:17 +0000 (09:01 +0900)]
fix reference to tenant id.
Administrator can create resource, even if the tenant of resource is
different from the one of authentication. For example, administrator
can operate 'quantum net-create' command with different tenant
between the authentication tenant(--os-tenant-name) and --tenant-id.
In this case, quota cannot be restricted with the resource tenant,
because it is restricted with --os-tenant-name.
Bob Kukura [Tue, 14 May 2013 21:35:08 +0000 (17:35 -0400)]
Fix linuxbridge RPC message format
The linuxbridge, openvswitch, and hyperv plugins all use the same
basic RPC interface between their plugins and L2 agents. But the
attributes describing a virtual network passed from the plugin to the
agent over this interface differed for historical reasons. The
openvswitch and hyperv plugins each pass network_type,
physical_network, and segmentation_id attributes, whereas the
linuxbridge plugin previously passed vlan_id and physical_network
attributes, using special vlan_id values to indicate flat or local
network types.
This patch changes the linuxbridge plugin to pass network_type and
segmentation_id attributes instead of the vlan_id attribute, bringing
its message formats into sync with the other plugins. RPC
compatibility is required for blueprint modular-l2 so that the ml2
plugin can work with all three existing types of L2 agent. This RPC
message format change is also required for blueprint
vxlan-linuxbridge.
Unlike the vxlan-linuxbridge patch on which it is based (see
https://review.openstack.org/#/c/26516/), this patch does not bump the
linuxbridge RPC version number, as the ml2 plugin will require all
three L2 agents to use the same RPC version. Instead, the updated
linuxbridge agent maintains compatibility with old linuxbridge plugins
by accepting either the old or new attributes. There is also a
configuration option, currently turned on by default, to enable the
updated linuxbridge plugin to pass the vlan_id attribute expected by
old linuxbridge agents along with the new attributes. These message
format compatibility mechanisms are intended to aid during upgrades,
and can eventually be removed.
Paul Michali [Fri, 10 May 2013 13:17:24 +0000 (06:17 -0700)]
Add negative UT cases for subnet/GW create/update
When force_gateway_on_subnet is configured, ensure
that a GW with IP same as subnet, and BCAST GW IP
are rejected during subnet create. For subnet update,
ensure GW outside of subnet is rejected.
This patch implements part #3 of this blueprint, according to its
specification.
It does so by allowing the view generator in the API layer to strip
off fields which do not satify authorization policies.
Also, some checks in unit tests for plugins relied on the
capability of the plugin to invoke directly the policy engine.
This checks have been removed and replaced by equivalent unit tests.
Finally, this patch required changes to most test cases for API
extensions in order to ensure the resource attribute map was
updated with the extension's attributes
Aaron Rosen [Tue, 14 May 2013 04:02:00 +0000 (21:02 -0700)]
Add missing unit test for NVP metadata_mode option
Note: I didn't squash this change in my patch that made the default
transport type configurable because this change was not in grizzly
and we do not want to backport it.
Aaron Rosen [Mon, 13 May 2013 00:25:04 +0000 (17:25 -0700)]
Allow ports to be created on networks that do not exist in NVP
If a network exists in the quantum database but not in NVP we should allow
someone to create a port on this network and set the status to ERROR. The
reason for this is if one deletes a network from NVP and when the dhcp agent
goes to create it's dhcp port on this network an error will be raised to the
agent and it will enter a constant state of resyncing.
This patch also adds a unit test for update_port() for the same situation.
Irena Berezovsky [Mon, 11 Mar 2013 10:10:15 +0000 (12:10 +0200)]
blueprint mellanox-quantum-plugin
Implements Mellanox Quantum plugin.
This plugin implements Quantum v2 APIs with support for Mellanox embedded
switch functionality as part of the VPI (Ethernet/InfiniBand) HCA.
Add ability for core plugin to implement advanced services
implements blueprint api-core-for-services
Add check for supported_extension_aliases in QuantumManager.
If core plugin supports certain service extension, then core plugin is
stored in service_plugins for the service type of this extension
so corresponding extension could set it as a controller for REST calls.
Do not require sudo/rootwrap to check for dnsmasq version
The dnsmasq version check does not need root privileges
to run as with low privs it works just fine. As a side
effect, the use of the rootwrapper was causing unit tests
to hung because the execute call in check_version was not
being stubbed out. Weirdly enough this wasn't caught in
a previous Gerrit run; there must be a passwordless sudo
lurking around somewhere in the Gerrit infrastructure.
Henry Gessau [Thu, 9 May 2013 04:28:39 +0000 (00:28 -0400)]
Create a common function for method _parse_network_vlan_ranges used
by plugins.
The _parse_network_vlan_ranges method does the same thing for the
linuxbridge, ovs, and hyperv plugins. Create a common function for
the plugins to use instead. This paves the way for improving vlan
range verification (see #1169266) in one place.
For the most part, the dhcp agent uses the root_helper setting from the [AGENT]
section of /etc/quantum/quantum.conf. However, in a couple of spots, the
root_helper setting from the [DEFAULT] section of /etc/quantum/dhcp_agent.ini
was being used.
Roman Podolyaka [Wed, 8 May 2013 15:34:51 +0000 (18:34 +0300)]
Fix usage of SQLAlchemy Query.first() method
Query.first() doesn't raise the NoResultFound exception
if no result is found but rather returns None, so wrapping
of Query.first() call into a try/except NoResultFound block
is useless.
Roman Podolyaka [Tue, 7 May 2013 18:57:53 +0000 (21:57 +0300)]
Fix usage of NexusPortBindingNotFound exception
Currently the required keyword argument (port_id)
is not passed when the exception is raised. In fact
this exception has never been raised before due to
another bug (1173131) so this change also has to
ensure it doesn't break any existing code using
functions which can possibly raise this exception.
Log a warning if dnsmasq version is below the minimum required
It has been noted that older versions of dnsmasq may have unexpected
behavior, so this patch introduces a check on dnsmasq version; if
the minimum version is not met, a warning is logged. This is less
invasive than raising an Exception and abort the dhcp agent, even
though this also seems like a perfectly acceptable behavior.
Brian Haley [Tue, 7 May 2013 15:06:29 +0000 (11:06 -0400)]
Change Daemon class to better match process command lines.
Add additional uuid argument Daemon class to help it better
match output from /proc/$id/cmdline to the correct daemon.
If there is a stale pid in the pidfile, and that process has
the same name, then it could match accidentally and not
start the daemon up properly.
Changed return values for some ensure_* functions to make them more consistent.
Now all ensure_* functions return None on failure and return the entity that was
created within the function when successful. Made changes to the unit tests to
reflect the changed return values.
Thierry Carrez [Mon, 6 May 2013 15:02:39 +0000 (17:02 +0200)]
Import recent rootwrap features in local rootwrap
Import features developed in oslo-rootwrap during the Grizzly cycle (and
recently in havana) into quantum-rootwrap. This is the first step toward
using the common oslo-rootwrap into Quantum: the goal being to make both
implementations converge, we should avoid making local changes (and push
any required change into oslo-rootwrap instead from now on).
New features include:
- Optional logging (use_syslog)
- Searching for executables in a specified binary path (exec_dirs)
- New path-based PathFilter
Those features required a refactoring in the way executables are matched
and in configuration loading.
Aaron Rosen [Tue, 7 May 2013 03:21:57 +0000 (20:21 -0700)]
Fix 500 raised on disassociate_floatingips when out of sync
If one deletes NAT rules directly from NVP and not through quantum,
an error will be raised when deleting a port that is associated with
the floating ip. This patch catches the NotFound exception and logs
it so that the port can successfully be deleted.
get_security_groups now creates default security group
If one called get_security_groups() previously the default security
group would not be created until the tenant created a network. This
exposed a bug when an admin creates a shared network and a tenant tried
to boot a vm on it without having any networks.
Log msg for load policy file only if the file is actually loaded
The Load entry was previousy in init(), whereas it should have
been in _set_rules() which is invoked only when policies are
(re)loaded from the json file.
Previously the NVP plugin would query NVP for the quantum port id that was
stored in the port as a tag in NVP. Later, a look up table was added in order
to directly look up the ID without having to go to NVP. The problem that can
arise is that if a port was created in folsom before this lookup table was
added and then deleted from NVP directly an error will be raised when calling
update_port(). This patch fixes this potential problem.
Dane LeBlanc [Wed, 10 Apr 2013 22:23:37 +0000 (18:23 -0400)]
blueprint cisco-plugin-exception-handling
Improvements to exception handling in the Cisco plugins. Changes
include:
- Added mapping of Cisco exceptions to HTTP codes
(extension to FAULT_MAP).
- Removed several unused Cisco exception definitions.
- Added several new Cisco exceptions for fault conditions.
- Added several rollbacks for various sequential operations, e.g.:
* Create port: Nexus sub-plugin fails after OVS sub-plugin success
* Create port: Nexus switch conig fails after adding binding to
Nexus binding database
* Delete port: OVS sub-plugin fails after Nexus sub-plugin success
- Delete Port: Reversed order of OVS/Nexus sub-plugin calls so that
it is done in the reverse order as is done for create port.
- Removed several empty except/raise blocks
- Delete network: Removed call to Nexus sub-plugin delete_network,
since that is a no-op.
- Removed a block of unused code in model's create_network method.
- Added several unit testcases, including patching of OVS, Cisco
and Nexus config.
- Remove CISCO_TEST configuration from cisco plugin
config .ini file.
Code Review / openstack-build / neutron-build.git / log