]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/log
Branan Purvine-Riley [Fri, 19 Oct 2012 01:28:05 +0000 (18:28 -0700)]
Improve documentation of the core apt class usage
Branan Purvine-Riley [Thu, 18 Oct 2012 23:45:15 +0000 (16:45 -0700)]
Merge pull request #83 from dalen/pin_order
(#16070) Allow optional order parameter to apt::pin
Matthaus Owens [Tue, 2 Oct 2012 17:59:23 +0000 (10:59 -0700)]
Merge pull request #89 from rcoleman/add_to_readme
Add PL Repo source to README
Ryan Coleman [Tue, 2 Oct 2012 17:55:35 +0000 (10:55 -0700)]
Add PL Repo source to README
Prior to this commit, the only information about the Puppet Labs
repository source was in the tests folder.
This commit adds example usage for apt::source to the README for
the Puppet Labs APT repository.
Erik Dalén [Tue, 21 Aug 2012 21:14:54 +0000 (23:14 +0200)]
(#16070) Allow optional order parameter to apt::pin
As the apt pinnings are parsed in ascending alphabetical order with
first match wins within a given scope it is useful to be able to specify
a ordering parameter. Then the name parameter can be kept to something
meaningful.
Dan Bode [Wed, 22 Aug 2012 13:55:00 +0000 (06:55 -0700)]
Merge pull request #84 from dalen/pin_version
(#16075) Allow pinning on version numbers
Dan Bode [Wed, 22 Aug 2012 13:47:01 +0000 (06:47 -0700)]
Merge pull request #79 from sathlan/feature/apt-force-timeout
Add a way to specify a timeout for the apt::force define.
Dan Bode [Wed, 22 Aug 2012 13:46:36 +0000 (06:46 -0700)]
Merge pull request #78 from saz/source-remove-release
remove check, if $release is empty
Dan Bode [Wed, 22 Aug 2012 13:00:39 +0000 (06:00 -0700)]
Merge pull request #82 from dalen/style
Fix style errors
Erik Dalén [Wed, 22 Aug 2012 08:11:48 +0000 (10:11 +0200)]
(#16075) Allow pinning on version numbers
This is needed to be able to produce the following pinning from
apt_preferences(5):
Package: perl
Pin: version 5.8*
Pin-Priority: 1001
Erik Dalén [Tue, 21 Aug 2012 20:55:24 +0000 (22:55 +0200)]
Fix style errors
Steffen Zieger [Tue, 3 Jul 2012 21:49:01 +0000 (23:49 +0200)]
fix check of release parameter
sathlan [Mon, 9 Jul 2012 02:24:49 +0000 (05:24 +0300)]
Add a way to specify a timeout for the apt::force define.
Branan Purvine-Riley [Tue, 3 Jul 2012 00:58:12 +0000 (17:58 -0700)]
Merge pull request #77 from jonhattan/master
«main» repository is missing from ubuntu backports.
Jonathan Araña Cruz [Fri, 29 Jun 2012 11:15:13 +0000 (13:15 +0200)]
Add «main» to Ubuntu backports repos.
Dan Bode [Wed, 13 Jun 2012 21:59:27 +0000 (14:59 -0700)]
Merge pull request #75 from ytjohn/patch-1
Without puppetlabs/stdlib, you will get "err: Could not retrieve catalog...
ytjohn [Wed, 13 Jun 2012 21:48:58 +0000 (18:48 -0300)]
Without puppetlabs/stdlib, you will get "err: Could not retrieve catalog from remote server: Error 400 on SERVER: Unknown function validate_bool"
Dan Bode [Tue, 12 Jun 2012 15:19:54 +0000 (08:19 -0700)]
Merge pull request #74 from antonlindstrom/variable-scoping
fix scoping of $lsbdistcodename in source.pp
Anton Lindström [Tue, 12 Jun 2012 07:56:19 +0000 (09:56 +0200)]
fix scoping of $lsbdistcodename in source.pp
Current unscoped variable yields deprecation warning:
warning: Dynamic lookup of $lsbdistcodename at
[..]/apt/manifests/source.pp:7 is deprecated.
Branan Purvine-Riley [Thu, 7 Jun 2012 22:19:41 +0000 (15:19 -0700)]
Merge pull request #73 from nanliu/tb/logoutput
Add logoutput on_failure for all exec resources.
Nan Liu [Thu, 7 Jun 2012 21:53:41 +0000 (14:53 -0700)]
Add logoutput on_failure for all exec resources.
We need more information to debug issues on exec failure. This change
enables logouput => on_failure.
Nan Liu [Tue, 5 Jun 2012 17:32:05 +0000 (10:32 -0700)]
Merge pull request #72 from branan/fix_modulefile_repo
Fix Modulefile for puppet-apt to puppetlabs-apt rename
Branan Purvine-Riley [Tue, 5 Jun 2012 16:50:41 +0000 (09:50 -0700)]
Fix Modulefile for puppet-apt to puppetlabs-apt rename
Dan Bode [Fri, 1 Jun 2012 00:30:59 +0000 (17:30 -0700)]
Merge pull request #70 from branan/use_spec_gem
Switch to the new puppetlabs_spec_helper gem
Branan Purvine-Riley [Tue, 29 May 2012 17:48:54 +0000 (10:48 -0700)]
Switch to the new puppetlabs_spec_helper gem
Dan Bode [Fri, 25 May 2012 23:06:55 +0000 (16:06 -0700)]
Merge pull request #68 from branan/release_0.0.4
Update Modulefile and CHANGELOG for 0.0.4
Dan Bode [Fri, 25 May 2012 23:03:40 +0000 (16:03 -0700)]
Merge pull request #69 from branan/fix_source_test
Fix the spec test for apt::source
Branan Purvine-Riley [Fri, 25 May 2012 22:32:49 +0000 (15:32 -0700)]
Fix the spec test for apt::source
the $location paramater is meant to be a deb location, so it should be
formatted as a URI.
Nan Liu [Fri, 25 May 2012 21:36:59 +0000 (14:36 -0700)]
Merge pull request #67 from branan/older_puppet_fix
Remove a trailing comma to fix older puppets
Branan Purvine-Riley [Fri, 25 May 2012 18:42:17 +0000 (11:42 -0700)]
Update Modulefile and CHANGELOG for 0.0.4
Branan Purvine-Riley [Fri, 25 May 2012 19:38:53 +0000 (12:38 -0700)]
Remove a trailing comma to fix older puppets
Branan Purvine-Riley [Fri, 25 May 2012 18:57:12 +0000 (11:57 -0700)]
Merge pull request #63 from rskvazh/master
Pin source with originator. Useful for pinning Launchpad PPA
Nan Liu [Fri, 25 May 2012 18:45:05 +0000 (11:45 -0700)]
Merge pull request #64 from branan/rakefile_clean
Update Rakefile to my latest template version
Nan Liu [Fri, 25 May 2012 18:26:47 +0000 (11:26 -0700)]
Merge pull request #65 from branan/spec_fix
Fix spec tests
Branan Purvine-Riley [Fri, 25 May 2012 18:20:46 +0000 (11:20 -0700)]
Fix spec tests
Branan Purvine-Riley [Fri, 25 May 2012 18:08:15 +0000 (11:08 -0700)]
Update Rakefile to my latest template version
* Add a 'clean' task
* Fix an issue when there are no repository fixtures
Roman Skvazh [Thu, 24 May 2012 09:46:00 +0000 (13:46 +0400)]
Add functionality to pin source with originator "release o=..."
If you need to pin certain Launchpad PPA (ppa:rskvazh/php), you may do:
apt::pin { 'my-launchpad-repo':
priority => 700,
originator =>'LP-PPA-rskvazh-php',
}
Adrien Thebo [Wed, 23 May 2012 17:56:16 +0000 (10:56 -0700)]
Merge pull request #62 from xaque208/contribute
Retroactively add Zach Leslie as a contributor
Zach Leslie [Wed, 23 May 2012 17:18:48 +0000 (10:18 -0700)]
contribute
James Turnbull [Wed, 23 May 2012 17:17:31 +0000 (10:17 -0700)]
Merge pull request #61 from xaque208/pin_origin
Pin origin
James Turnbull [Wed, 23 May 2012 17:16:49 +0000 (10:16 -0700)]
Merge pull request #60 from branan/ppa_filename
(#14657) Fix filename when there is a period in the PPA
Dan Bode [Wed, 23 May 2012 00:27:00 +0000 (17:27 -0700)]
Merge pull request #59 from branan/spec_improvements
Spec improvements
Branan Purvine-Riley [Wed, 23 May 2012 00:18:40 +0000 (17:18 -0700)]
(#14657) Fix filename when there is a period in the PPA
Branan Purvine-Riley [Tue, 22 May 2012 22:15:04 +0000 (15:15 -0700)]
Make gemfile and fixtures.yml hidden files for the sake of module tool
Branan Purvine-Riley [Tue, 22 May 2012 20:10:30 +0000 (13:10 -0700)]
add spec_prep, spec_clean, and spec_full rake tasks
These targets automate the fixtures directory using a configuration stored in
fixtures.yml. Because we can now handle the fixtures directory with a rake task,
the clone commands have been removed from the Travis config.
Branan Purvine-Riley [Tue, 22 May 2012 20:10:05 +0000 (13:10 -0700)]
fallback to the puppet modulepath if a module is missing from fixtures
Branan Purvine-Riley [Tue, 22 May 2012 20:09:10 +0000 (13:09 -0700)]
Remove recursive symlink from fixtures
Dan Bode [Tue, 22 May 2012 16:21:52 +0000 (09:21 -0700)]
Merge pull request #56 from branan/travisci
Add files for travis CI
Zach Leslie [Tue, 22 May 2012 00:06:10 +0000 (17:06 -0700)]
add .pref extension, which according to apt_preferences(5) may or may not be present, and is helpful if you are going to have an extension at all
Zach Leslie [Mon, 21 May 2012 22:56:29 +0000 (15:56 -0700)]
use variable from params and also validate the purge_preferences_d
Zach Leslie [Mon, 21 May 2012 22:51:33 +0000 (15:51 -0700)]
allow for purging preferences
Zach Leslie [Mon, 21 May 2012 22:48:00 +0000 (15:48 -0700)]
align =
Zach Leslie [Mon, 21 May 2012 22:03:30 +0000 (15:03 -0700)]
Preserve backwards compatibility
Zach Leslie [Mon, 21 May 2012 21:52:36 +0000 (14:52 -0700)]
pass ensure through so that we can remove pin prefs too
Zach Leslie [Mon, 21 May 2012 21:49:30 +0000 (14:49 -0700)]
move pin out to a template
Zach Leslie [Mon, 21 May 2012 21:19:18 +0000 (14:19 -0700)]
Add functionality to support apt pinning to more than just the release.
Write the pin preference filename as ${name} rather than ${release}, so
that we can pin more than one thing.
Change apt::source so that when pin is set, that it pins to the origin
rather than the release.
Zach Leslie [Mon, 21 May 2012 21:17:37 +0000 (14:17 -0700)]
Fixup name issue with apt::backports
The '.list' is not needed since the apt::source type handles this.
White space alignment.
Ryan Coleman [Wed, 9 May 2012 20:12:42 +0000 (13:12 -0700)]
Merge pull request #58 from nanliu/tb/ppa
Fix dependency issues introduced with anchor.
Nan Liu [Wed, 9 May 2012 19:22:28 +0000 (12:22 -0700)]
Fix apt::dep spec tests.
Some of the existing tests were not verifying anything useful. This
update replace them with more meaningful tests.
Nan Liu [Wed, 9 May 2012 18:50:43 +0000 (11:50 -0700)]
Fix dependency issues introduced with anchor.
apt::ppa and apt::builddep requires apt class. The anchor introduced for
containment of apt-get update causes a dependency loop. apt::ppa appears
to depend on apt class sources.d direcory. While apt::builddep have no
clear reason for a dependency on apt class. This change refactor both
define type, so they no longer cause a dependency loop.
Dan Bode [Tue, 8 May 2012 18:07:46 +0000 (11:07 -0700)]
Merge pull request #57 from nanliu/tb/style
Fix style related issues in module.
Branan Purvine-Riley [Tue, 8 May 2012 17:18:52 +0000 (10:18 -0700)]
Add configuration for Travis CI
Nan Liu [Tue, 8 May 2012 17:47:43 +0000 (10:47 -0700)]
Fix style related issues in module.
Dan Bode [Mon, 7 May 2012 22:49:33 +0000 (15:49 -0700)]
Merge pull request #55 from nanliu/tb/containment
(#11966) apt module containment for apt_update.
Nan Liu [Mon, 7 May 2012 22:27:53 +0000 (15:27 -0700)]
(#11966) apt module containment for apt_update.
The update to separate Exec["apt-get update ${name}"] to single exec in
apt::update class resulted in apt-get update command to be dangled.
Previously if user specified Package['package_a'] <-
Apt::Resource['source_a'], the original refactor would no longer
guarantee apt-get update is executed before the package is installed.
This patch fixes the problem using the anchor resource and ensuring the
old behaviour is maintained and user can depend on apt-get update
command being invoked if they specify dependency on any apt::*
define resource type as well as the apt class.
Nan Liu [Fri, 4 May 2012 21:08:12 +0000 (14:08 -0700)]
Merge pull request #50 from branan/14221_forge_update
(#14221) update Modulefile for new release
Branan Purvine-Riley [Fri, 4 May 2012 21:05:57 +0000 (14:05 -0700)]
(#14221) update CHANGELOG for release
Branan Purvine-Riley [Thu, 3 May 2012 21:18:51 +0000 (14:18 -0700)]
(#14221) update Modulefile for new release
Branan Purvine-Riley [Fri, 4 May 2012 20:58:43 +0000 (13:58 -0700)]
Merge pull request #53 from nanliu/tb/14321
(#14321) apt::pin resource support release.
Nan Liu [Fri, 4 May 2012 20:56:35 +0000 (13:56 -0700)]
(#14321) apt::pin resource support release.
apt::pin release should default to title, but should be able to
override. This update removes unnecessary "" around $name, and add spec
tests.
Conflicts:
spec/defines/pin_spec.rb
albac [Sat, 28 Apr 2012 00:23:48 +0000 (21:23 -0300)]
Update manifests/pin.pp
Nan Liu [Fri, 4 May 2012 20:54:22 +0000 (13:54 -0700)]
Merge pull request #54 from branan/python-software-properties-in-apt-ppa
Move Package['python-software-properties'] to apt:ppa
Thomas Broyer [Mon, 2 Apr 2012 07:00:59 +0000 (09:00 +0200)]
Move Package['python-software-properties'] to apt:ppa
Also updates the apt-update in Apt::Ppa to use $apt::params::provider
instead of aptitude.
Branan Purvine-Riley [Fri, 4 May 2012 20:37:46 +0000 (13:37 -0700)]
Merge pull request #49 from nanliu/tb/11966
(#11966) Only invoke apt-get update once.
Nan Liu [Thu, 3 May 2012 22:44:17 +0000 (15:44 -0700)]
(#11966) Change apt update to apt_update.
Based on code review change exec from apt update to apt_update.
Nan Liu [Thu, 3 May 2012 17:22:49 +0000 (10:22 -0700)]
(#11966) Update apt::ppa to use apt::update.
Change apt::ppa define type to also use the apt::update class to invoke
apt-get update once.
Nan Liu [Fri, 4 May 2012 20:35:13 +0000 (13:35 -0700)]
(#11966) Only invoke apt-get update once.
Move apt-get update exec to a seperate class to minimize the number of
apt-get updates invoked by configuration changes.
* remove apt_update exec resource in apt class.
* remove apt-get-${name} in defines.
* apt::source notify Exec['apt update'].
* Remove dependency to Exec['apt_update'].
* fix rspec-puppet tests.
Conflicts:
manifests/source.pp
Branan Purvine-Riley [Fri, 4 May 2012 20:18:05 +0000 (13:18 -0700)]
Merge pull request #52 from nanliu/tb/14308
(#14308) Add ensure=>absent for define resource.
Nan Liu [Thu, 3 May 2012 23:59:13 +0000 (16:59 -0700)]
(#14308) Add ensure=>absent for define resource.
Several apt::* define resource type does not support ensurable. This
update allows ensure=>absent to support the removal of these
configuration files.
* apt::conf
* apt::pin
* apt::source
Dan Bode [Thu, 3 May 2012 22:23:15 +0000 (15:23 -0700)]
Merge pull request #51 from nanliu/tb/14299
(#14299) Resolve Modulefile name mismatch.
Nan Liu [Thu, 3 May 2012 21:55:16 +0000 (14:55 -0700)]
(#14299) Resolve Modulefile name mismatch.
The modulefile name is puppet-apt, but the module is released to forge
under puppetlabs. This causes a dependency confusion for puppet module
tool, which has been fixed by this patch.
Previous:
$ puppet module list
~/.puppet/modules
├── puppet-apt (v0.0.2)
├── puppetlabs-mongrodb (v0.0.1)
└── puppetlabs-stdlib (v2.3.1)
Now:
$ puppet module list
~/.puppet/modules
├── puppetlabs-apt (v0.0.2)
├── puppetlabs-mongrodb (v0.0.1)
└── puppetlabs-stdlib (v2.3.1)
Dan Bode [Thu, 3 May 2012 17:20:03 +0000 (10:20 -0700)]
Merge pull request #48 from nanliu/tb/lint
Cleanup apt-module puppet-lint related issues.
Nan Liu [Thu, 3 May 2012 16:51:14 +0000 (09:51 -0700)]
Cleanup apt-module puppet-lint related issues.
Dan Bode [Thu, 3 May 2012 05:20:08 +0000 (22:20 -0700)]
Merge pull request #47 from nanliu/master
(#14138) Fix spec test for aptitude changes.
Nan Liu [Thu, 3 May 2012 04:35:13 +0000 (21:35 -0700)]
(#14138) Fix spec test for aptitude changes.
Fix spec test related to apttitude update -> apt-get update change,
Nan Liu [Thu, 3 May 2012 00:31:57 +0000 (17:31 -0700)]
Merge pull request #41 from tbroyer/install-proxy-first
Make sure we configure the proxy before doing apt-get update.
Nan Liu [Thu, 3 May 2012 00:29:31 +0000 (17:29 -0700)]
Merge pull request #44 from relud/patch-1
(#14138) Modify apt::ppa's update-apt exec to use the ${apt::params::provider} parameter.
Nan Liu [Thu, 3 May 2012 00:27:12 +0000 (17:27 -0700)]
Merge pull request #42 from ody/sync_with_pl_ops
Sync with pl ops
Dan Bode [Wed, 2 May 2012 23:08:14 +0000 (16:08 -0700)]
Merge pull request #46 from nanliu/master
(#14287) Fix apt::pin resource for rspec-puppet.
Nan Liu [Wed, 2 May 2012 23:00:27 +0000 (16:00 -0700)]
(#14287) Fix apt::pin resource for rspec-puppet.
The shorthand syntax cause rspec-puppet failure for external modules
depending on the puppet-apt module. This patch uses the require
metaparameter to avoid this issue.
Daniel Thornton [Mon, 23 Apr 2012 20:40:24 +0000 (20:40 +0000)]
(#14138) Modify apt::ppa's update-apt exec to use the ${apt::params::provider} parameter rather than explicitly calling aptitude.
Previously the update-apt exec would always use /usr/bin/aptitude, which is not necessarily present. This change makes it use ${apt::params::provider} which defaults to /usr/bin/apt-get. This also adds some consistency so that ${apt::params::provider} is used everywhere.
Cody Herriges [Thu, 12 Apr 2012 00:49:30 +0000 (17:49 -0700)]
Tests to validate apt::{conf,backports}
This patch adds the appropriate spec tests to validate the changes
introduced by
e5f2dfe . As a bonus it includes fixes to the manifests
that were discovered while writing the tests.
Cody Herriges [Wed, 11 Apr 2012 21:54:13 +0000 (14:54 -0700)]
Adds apt::{conf,backports} and variable style.
With the addition of this patch two new defines will be added; one to
manage APT configuration files (apt::conf) and one that abstracts out the
requirements needed to turn on backport repositories (apt::backports).
In addition, the patch takes the opportunity to clean up variable
definitions so they follow a consistent pattern of setting local
variables to the fully qualified value stored in the apt::params
class. Previously all variable used within a class directly addressed
the apt::params namespace when ever the variable was used. In the
pattern they now adhere to we can more easily switch the namespace
data lives in or externalize it even more using hiera.
Thomas Broyer [Fri, 30 Mar 2012 15:48:31 +0000 (17:48 +0200)]
Make sure we configure the proxy before doing apt-get update.
Matthaus Litteken [Tue, 27 Mar 2012 00:44:53 +0000 (17:44 -0700)]
Merge pull request #39 from rcoleman/0.0.2_release
Updated CHANGELOG and Modulefile for 0.0.2
Ryan Coleman [Tue, 27 Mar 2012 00:01:54 +0000 (17:01 -0700)]
Updated CHANGELOG and Modulefile for 0.0.2
This commit updates both the Modulefile and CHANGELOG for the 0.0.2
Puppet Forge release.
Cody Herriges [Mon, 26 Mar 2012 23:46:24 +0000 (16:46 -0700)]
Merge pull request #36 from rcoleman/tickets/13261/improve_smoke_tests
Tickets/13261/improve smoke tests
Ryan Coleman [Tue, 20 Mar 2012 22:52:44 +0000 (15:52 -0700)]
(#13261) Add real examples to smoke tests.
This commit modifies some smoke tests with real-world usage examples
instead of providing things like 'foo' that the module user must
replace in order to conduct a smoke test or try out example functionality.
Ryan Coleman [Tue, 20 Mar 2012 21:55:01 +0000 (14:55 -0700)]
(#13261) Add key.pp smoke test
This commit adds a smoke test for key.pp, adding a key declaration
for the puppetlabs apt source.
Ryan Coleman [Tue, 20 Mar 2012 21:52:43 +0000 (14:52 -0700)]
(#13261) Replace foo source with puppetlabs source
Prior to this commit, the source.pp test included an apt source
named foo which broke the apt-get update exec when applied on a
target system. This commit removes it in favor of the puppetlabs
apt source which is valid on all target platforms.