]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/log
Ashley Penney [Mon, 3 Feb 2014 21:23:47 +0000 (13:23 -0800)]
Merge pull request #291 from hunner/isfragment_fix
(MODULES-442) Correct boolean properties behavior
Hunter Haugen [Fri, 31 Jan 2014 21:19:27 +0000 (13:19 -0800)]
(MODULES-442) Correct boolean properties behavior
The boolean properties had a few things incorrect with them.
- Any value passed was considered `true`. This was compounded further by
the next issue.
- When the read property was false, it was set to 'nil'. This caused
`<property> => false` to not work after the previous was fixed.
Random other fixes to tests that were failing or poorly implemented are
also included
Ashley Penney [Wed, 29 Jan 2014 15:12:18 +0000 (07:12 -0800)]
Merge pull request #288 from hunner/fail_chains
(MODULES-441) Helpfully fail when modifying chains
Ashley Penney [Wed, 29 Jan 2014 15:11:29 +0000 (07:11 -0800)]
Merge pull request #287 from hunner/purge
Add purge support to firewallchain
Ashley Penney [Wed, 29 Jan 2014 15:09:52 +0000 (07:09 -0800)]
Merge pull request #286 from hunner/fix_source
(MODULES-439) Work around existing rules
Hunter Haugen [Wed, 29 Jan 2014 02:08:42 +0000 (18:08 -0800)]
(MODULES-441) Helpfully fail when modifying chains
It is not intended for chains to be modified using the firewall
resource, but it would still try and result in obscure incorrect errors.
This raises a more helpful error
Hunter Haugen [Tue, 28 Jan 2014 22:39:25 +0000 (14:39 -0800)]
Update specs and make compatible with 1.8.7
`.keep_if` is not in Ruby 1.8.7
The resource was trying to change from chain INPUT to OUTPUT which isn't
supported.
Patrick Hemmer [Sun, 5 Jan 2014 19:55:33 +0000 (14:55 -0500)]
add specs for chain purge
Patrick Hemmer [Tue, 17 Dec 2013 22:00:18 +0000 (17:00 -0500)]
add support for removing unmanaged firewall rules
Hunter Haugen [Tue, 28 Jan 2014 01:31:22 +0000 (17:31 -0800)]
(MODULES-439) Work around existing rules
The firewall resource is not intended to be used with rules that are not
also managed by puppet; the behavior when doing so was undefined. This
is an attempt to make it more defined.
The behavior is that any rule added by puppet will be inserted in its
given order in relation to the other rules managed by puppet, but ahead
of any rules not managed by puppet.
Hunter Haugen [Thu, 23 Jan 2014 19:09:59 +0000 (11:09 -0800)]
Merge pull request #285 from ghoneycutt/travis
Travis
Garrett Honeycutt [Thu, 23 Jan 2014 18:36:11 +0000 (13:36 -0500)]
Add support for Puppet v3.4.0
Garrett Honeycutt [Thu, 23 Jan 2014 18:35:06 +0000 (13:35 -0500)]
Enable fast finish in Travis
http://blog.travis-ci.com/2013-11-27-fast-finishing-builds/
Garrett Honeycutt [Thu, 23 Jan 2014 18:33:03 +0000 (13:33 -0500)]
Ensure valid YAML for .travis.yml
Ashley Penney [Thu, 23 Jan 2014 17:22:17 +0000 (09:22 -0800)]
Merge pull request #282 from apenney/add-tests
Add acceptance tests
Ashley Penney [Wed, 15 Jan 2014 18:50:10 +0000 (13:50 -0500)]
Add additional firewallchain{} tests.
Ashley Penney [Mon, 13 Jan 2014 21:20:50 +0000 (16:20 -0500)]
Add additional acceptance tests to cover all parameters.
Ashley Penney [Mon, 6 Jan 2014 18:04:34 +0000 (10:04 -0800)]
Merge pull request #280 from jeffb-bt/master
Allow --dport --sport without preceding -m
Ashley Penney [Mon, 6 Jan 2014 18:01:15 +0000 (10:01 -0800)]
Merge pull request #276 from ghoneycutt/rspec_puppet_v1
Support rspec-puppet v1.0.0
Jeff '2 bits' Bachtel [Mon, 6 Jan 2014 05:51:23 +0000 (00:51 -0500)]
Allow --dport --sport without preceding -m
Test rule added to spec
Garrett Honeycutt [Fri, 27 Dec 2013 22:39:21 +0000 (17:39 -0500)]
Support rspec-puppet v1.0.0
include_class has been replaced with contain_class.
http://bombasticmonkey.com/2013/12/05/rspec-puppet-1.0.0/
Ashley Penney [Fri, 20 Dec 2013 23:22:06 +0000 (15:22 -0800)]
Merge pull request #267 from phemmer/negation_support
Negation support
Patrick Hemmer [Fri, 20 Dec 2013 20:30:50 +0000 (15:30 -0500)]
update spec for host_to_mask to override Resolv
Ashley Penney [Fri, 20 Dec 2013 22:52:32 +0000 (14:52 -0800)]
Merge pull request #268 from phemmer/ipsec_support
add ipsec policy matching
Ashley Penney [Fri, 20 Dec 2013 22:51:59 +0000 (14:51 -0800)]
Merge pull request #271 from phemmer/fix_builtin_chains
fix handling of builtin chains
Ashley Penney [Fri, 20 Dec 2013 22:51:29 +0000 (14:51 -0800)]
Merge pull request #270 from phemmer/nat_input
allow input chain in nat table
Ashley Penney [Fri, 20 Dec 2013 22:44:28 +0000 (14:44 -0800)]
Merge pull request #273 from apenney/add-beaker-tests
Convert rspec-system tests to beaker-rspec.
Ashley Penney [Thu, 19 Dec 2013 17:25:31 +0000 (12:25 -0500)]
Convert rspec-system tests to beaker-rspec.
This work migrates the existing tests to beaker-rspec.
Patrick Hemmer [Fri, 20 Dec 2013 20:20:11 +0000 (15:20 -0500)]
update specs to allow INPUT:nat:IPv4
Patrick Hemmer [Tue, 17 Dec 2013 00:27:26 +0000 (19:27 -0500)]
fix negation handling for complex arguments
Jan Vansteenkiste [Thu, 23 Aug 2012 07:13:26 +0000 (09:13 +0200)]
Use a more generic way for parsing negated options, not only for destination and source
Jan Vansteenkiste [Thu, 23 Aug 2012 07:13:04 +0000 (09:13 +0200)]
Added a test case for /older/ alternative negation syntax
Jan Vansteenkiste [Thu, 23 Aug 2012 06:51:24 +0000 (08:51 +0200)]
Generic generating command line options for negated rules
Jan Vansteenkiste [Wed, 22 Aug 2012 21:15:06 +0000 (23:15 +0200)]
spec test fixtures should represent real use cases
Jan Vansteenkiste [Wed, 22 Aug 2012 21:11:39 +0000 (23:11 +0200)]
Fix parsing of rules and generating the command line to set the rule
Jan Vansteenkiste [Wed, 22 Aug 2012 16:00:57 +0000 (18:00 +0200)]
Fix parsing negated values
Jan Vansteenkiste [Wed, 22 Aug 2012 16:00:37 +0000 (18:00 +0200)]
Added fixtures to test parsing negated addresses
Jan Vansteenkiste [Wed, 22 Aug 2012 16:00:24 +0000 (18:00 +0200)]
Add test to see if type takes negative values
Jan Vansteenkiste [Wed, 22 Aug 2012 15:14:57 +0000 (17:14 +0200)]
Use host_to_mask so we can negate a mask. Also added documentation.
A custom provider should probably be aware that these kind of masks are possible.
Jan Vansteenkiste [Wed, 22 Aug 2012 15:11:23 +0000 (17:11 +0200)]
Added host_to_mask method and added tests for it
Patrick Hemmer [Wed, 18 Dec 2013 19:53:48 +0000 (14:53 -0500)]
fix handling of builtin chains
Patrick Hemmer [Wed, 18 Dec 2013 17:49:27 +0000 (12:49 -0500)]
allow input chain in nat table
Patrick Hemmer [Fri, 18 Jan 2013 00:33:21 +0000 (19:33 -0500)]
add ipsec policy matching
Conflicts:
lib/puppet/provider/firewall/iptables.rb
lib/puppet/type/firewall.rb
Ashley Penney [Fri, 20 Dec 2013 19:57:58 +0000 (11:57 -0800)]
Merge pull request #275 from apenney/fix-rspec
Fix rspec on Puppet 3.4/rspec 2.14.
Ashley Penney [Fri, 20 Dec 2013 19:43:22 +0000 (14:43 -0500)]
Handle the change to Puppet::Provider::Config in 3.4.
Ashley Penney [Fri, 20 Dec 2013 18:57:48 +0000 (13:57 -0500)]
Update to use modern rspec 2.14 syntax.
This updates from mocha .stubs to allow(x).to receive(x) syntax,
and tweaks the Gemfile/Rakefile too.
Ashley Penney [Wed, 16 Oct 2013 18:58:17 +0000 (11:58 -0700)]
Merge pull request #248 from senax/generate-parser-list
Generate parser list
Ashley Penney [Wed, 16 Oct 2013 18:37:54 +0000 (11:37 -0700)]
Merge pull request #257 from evaryont/master
Support conntrack stateful firewall matching
Colin Shea [Wed, 16 Oct 2013 01:37:26 +0000 (18:37 -0700)]
Support conntrack stateful firewall matching
Since Linux 3.7+ the "state" module has been removed from the kernel, leaving
only the "conntrack" module. This patch adds support for the conntrack module in
iptables by adding a new parameter to the firewall type, 'ctstate'.
Updates the README to demonstrate using the ctstate parameter instead of state
to nudge people to use it instead. This is safe as far as back to Linux kernel
2.6.18, so long as CONFIG_NF_CONNTRACK is enabled.
Ashley Penney [Fri, 4 Oct 2013 23:17:26 +0000 (16:17 -0700)]
Merge pull request #255 from apenney/metadata
FM-103: Add metadata.json to all modules.
Ashley Penney [Fri, 4 Oct 2013 22:53:16 +0000 (18:53 -0400)]
FM-103: Add metadata.json to all modules.
Ashley Penney [Wed, 2 Oct 2013 16:02:37 +0000 (09:02 -0700)]
Merge pull request #253 from stefanozanella/spec_helper_fix
Remove redundant `include` call in system spec helper.
Ashley Penney [Wed, 2 Oct 2013 15:40:45 +0000 (08:40 -0700)]
Merge pull request #252 from stefanozanella/update_gitignore
Add Bundler byproducts to the list of ignored files.
Stefano Zanella [Fri, 27 Sep 2013 16:39:13 +0000 (18:39 +0200)]
Remove redundant `include` call in system spec helper.
`rspec-system-puppet` helpers are already included few lines above the deleted
line, which by the way would have no effect anyway.
Stefano Zanella [Fri, 27 Sep 2013 16:29:12 +0000 (18:29 +0200)]
Add Bundler byproducts to the list of ignored files.
I assume this commit is self-explanatory...
Frank Ederveen [Sun, 15 Sep 2013 20:55:50 +0000 (21:55 +0100)]
added spec tests for iptables-save parser
Ashley Penney [Fri, 13 Sep 2013 19:00:57 +0000 (12:00 -0700)]
Merge pull request #240 from doc75/dev_drop_policy
No firewallchain autorequire for INPUT, OUTPUT and FORWARD when table is :filter to enable DROP policy without blocking
Ashley Penney [Fri, 13 Sep 2013 18:53:50 +0000 (11:53 -0700)]
Merge pull request #208 from georgkoester/hop_limit2
Add support for IPv6 hop limiting
Ashley Penney [Fri, 13 Sep 2013 17:48:05 +0000 (10:48 -0700)]
Merge pull request #247 from edmundcraske/patch-1
Fix pre/post errors
edmundcraske [Thu, 12 Sep 2013 13:48:53 +0000 (14:48 +0100)]
Fix pre/post errors
Ashley Penney [Tue, 10 Sep 2013 20:26:06 +0000 (13:26 -0700)]
Merge pull request #242 from apenney/042-release
Prepare 0.4.2 release.
Ashley Penney [Tue, 10 Sep 2013 20:25:43 +0000 (16:25 -0400)]
Prepare 0.4.2 release.
Ashley Penney [Tue, 10 Sep 2013 20:24:18 +0000 (13:24 -0700)]
Merge pull request #241 from apenney/remove
Add a .fixtures.yml so spec_helper can manage the tests.
Ashley Penney [Tue, 10 Sep 2013 20:19:41 +0000 (16:19 -0400)]
Add a .fixtures.yml so spec_helper can manage the tests.
Guillaume Virlet [Mon, 9 Sep 2013 22:11:13 +0000 (00:11 +0200)]
ensure INPUT, OUTPUT and FORWARD firewallchain are not autorequired when table is :filter (to allow default drop policy at the end of rules)
Ashley Penney [Mon, 9 Sep 2013 21:19:10 +0000 (14:19 -0700)]
Merge pull request #233 from mediatemple/22112_better_persistence
Only workaround if we're using the old package.
Ashley Penney [Tue, 27 Aug 2013 22:15:41 +0000 (15:15 -0700)]
Merge pull request #232 from mediatemple/22090_add_redhat_operatingsystems
22090 - Use list of RedHat OSes from newer facter.
Hunter Haugen [Mon, 12 Aug 2013 22:49:46 +0000 (15:49 -0700)]
Merge pull request #234 from apenney/041-release
Release a 0.4.1.
Ashley Penney [Fri, 9 Aug 2013 17:14:42 +0000 (10:14 -0700)]
Release a 0.4.1.
Sharif Nassar [Wed, 7 Aug 2013 21:22:53 +0000 (14:22 -0700)]
Only workaround if we're using the old package.
Sharif Nassar [Tue, 6 Aug 2013 21:18:25 +0000 (14:18 -0700)]
22090 - Use list of RedHat OSes from newer facter.
Frank Ederveen [Thu, 25 Jul 2013 12:12:42 +0000 (13:12 +0100)]
fixed minor ruby1.9 incompatibility
Frank Ederveen [Thu, 25 Jul 2013 10:26:55 +0000 (11:26 +0100)]
Generate of options to parse in the correct order from @resource_map
Ashley Penney [Fri, 12 Jul 2013 18:48:02 +0000 (11:48 -0700)]
Merge pull request #222 from hunner/release_0.4.0
Release 0.4.0
Hunter Haugen [Thu, 11 Jul 2013 23:54:28 +0000 (16:54 -0700)]
Release 0.4.0
Raphaël Pinson [Thu, 30 May 2013 11:37:53 +0000 (13:37 +0200)]
Add support for hop limit
Georg Koester [Fri, 12 Apr 2013 07:58:09 +0000 (00:58 -0700)]
Add ipv6 fragmentation matchers and generify known_boolean handling.
Adds tests for ipv6, too.
ip6tables handles fragmentation differently. There's a special
module and a couple of matchers which are all needed to
implement a stateless firewall correctly.
known_boolean handling with etc has been generified.
The known_boolean functionality was partly tailored
to the :socket feature.
Hunter Haugen [Tue, 9 Jul 2013 22:49:43 +0000 (15:49 -0700)]
Merge pull request #219 from hunner/feature/master/add-support-for-iprange
Feature/master/add support for iprange
Hunter Haugen [Tue, 9 Jul 2013 00:05:58 +0000 (17:05 -0700)]
Add rspec-system tests for src_range/dst_range
Ashley Penney [Tue, 9 Jul 2013 15:36:52 +0000 (08:36 -0700)]
Merge pull request #220 from traylenator/SLC
Add SL and SLC cases for operatingsystem
Ashley Penney [Tue, 9 Jul 2013 15:35:15 +0000 (08:35 -0700)]
Merge pull request #217 from hunner/update_provider_specs
Update providers to use expect syntax
Steve Traylen [Tue, 9 Jul 2013 13:43:44 +0000 (15:43 +0200)]
Add SL and SLC cases for operatingsystem
Hunter Haugen [Mon, 8 Jul 2013 23:40:59 +0000 (16:40 -0700)]
Update providers to use expect syntax
The expect syntax is much better than the should syntax and ships with
RSpec 2.14. It caused a few conflicts with the mocha stubbing, so I
updated the docs to use rspec test doubles instead.
Hunter Haugen [Mon, 8 Jul 2013 23:58:26 +0000 (16:58 -0700)]
Merge pull request #218 from hunner/remove_puppet_2.6
Remove travis testing puppet 2.6
Hunter Haugen [Mon, 8 Jul 2013 23:53:43 +0000 (16:53 -0700)]
Remove travis testing puppet 2.6
Hunter Haugen [Mon, 8 Jul 2013 23:40:15 +0000 (16:40 -0700)]
Add specs for dst_range and src_range params
Lei Zhang [Fri, 5 Jul 2013 05:26:33 +0000 (14:56 +0930)]
(#215) Add support for IP range
Add support for filtering by source and destination IP range, equivalent to '-m iprange --src-range|--dst-range',
which is only allowing a specified IP range. Excluding an IP range, '! --src-range or ! --dst-range', is not supported.
Add ':src_range' and ':dst_range' to iptables.rb
lei [Fri, 5 Jul 2013 04:57:56 +0000 (14:27 +0930)]
(#215) Add support for IP range
Add support for filtering by source and destination IP range, equivalent to '-m iprange --src-range|--dst-range',
which is only allowing a specified IP range. Excluding an IP range, '! --src-range or ! --dst-range', is not supported.
Add ':src_range' and ':dst_range' to firewall.rb
Dan Carley [Sun, 16 Jun 2013 20:16:37 +0000 (21:16 +0100)]
Exclude tests for Puppet < 3.2 against ruby-head
ruby-head is currently 2.x, which Puppet only began supporting at version
3.2: http://projects.puppetlabs.com/issues/18494
This should make the "allowed failures" builds green once again.
Dan Carley [Sun, 16 Jun 2013 20:14:12 +0000 (21:14 +0100)]
Test against Puppet 3.2
Released last month.
Dan Carley [Sun, 16 Jun 2013 20:03:59 +0000 (21:03 +0100)]
Merge branch 'pr/213'
Fixes #213
Dan Carley [Sun, 16 Jun 2013 19:54:02 +0000 (20:54 +0100)]
[#213] Run puppet-lint as part of CI
Will prevent lint from being violated again in the future.
Dan Carley [Sun, 16 Jun 2013 19:51:43 +0000 (20:51 +0100)]
[#213] Improve manifest documentation
Bad me. I should have written these the first time round.
Wolf Noble [Sun, 16 Jun 2013 18:07:20 +0000 (13:07 -0500)]
Minor fixes to appease puppet-lint
Signed-off-by: Wolf Noble <wolf@wolfspyre.com>
Dan Carley [Fri, 14 Jun 2013 13:08:29 +0000 (06:08 -0700)]
Merge pull request #212 from alphagov/addrtype
Add support for --src-type and --dst-type
Nick Stenning [Fri, 14 Jun 2013 11:48:37 +0000 (12:48 +0100)]
Rename {source,destination}_type to {src,dst}_type
As suggested by @dcarley.
Nick Stenning [Fri, 14 Jun 2013 11:08:38 +0000 (12:08 +0100)]
Add support for --src-type and --dst-type
Add support for filtering by source and destination address types. Supported by
iptables only, this feature allows filtering packets by the address type (such
as whether the packet came from a local address, a broadcast address, a
multicast address, etc).
Adds the `:address_type` feature to allow a provider to declare support for
filtering on the basis of address type.
Dan Carley [Thu, 13 Jun 2013 20:25:13 +0000 (21:25 +0100)]
Merge pull request #200 from ChrisRut/fixburst
Dan Carley [Thu, 13 Jun 2013 20:10:04 +0000 (21:10 +0100)]
[#200] Add tests for --limit-burst
Both explicit (when a `:burst` parameter or `--limit-burst` argument is
present) and implicit (when neither are specified but `:limit` or `--limit`
are present and the default burst is `5`).
Chris Rutter [Tue, 11 Jun 2013 15:34:50 +0000 (11:34 -0400)]
fix for default burst value of 5
fixes #200