]> review.fuel-infra Code Review - openstack-build/neutron-build.git/log
openstack-build/neutron-build.git
8 years agoIPAM: add in missing exception translations
Gary Kotton [Sun, 22 Nov 2015 14:25:47 +0000 (06:25 -0800)]
IPAM: add in missing exception translations

Adds in some missing translations.

TrivialFix

Change-Id: Ic4e1a01baa7052d3939391e731353a02ca4a70c1

8 years agoMerge "Keep reading stdout/stderr until after kill"
Jenkins [Sun, 22 Nov 2015 10:34:04 +0000 (10:34 +0000)]
Merge "Keep reading stdout/stderr until after kill"

8 years agoMerge "Switch to using neutron.common.utils:replace_file()"
Jenkins [Sat, 21 Nov 2015 20:05:22 +0000 (20:05 +0000)]
Merge "Switch to using neutron.common.utils:replace_file()"

8 years agoAdd Access Control bug tag
armando-migliaccio [Fri, 20 Nov 2015 23:06:17 +0000 (15:06 -0800)]
Add Access Control bug tag

Provide tag for bugs that affect the role based access control
and the Neutron policy layers (driven by policy.json).

Change-Id: Ia4259d53974996a83d380e778309aea2d7cb29cd

8 years agoMerge "Fix misspelled word in docstring"
Jenkins [Sat, 21 Nov 2015 01:36:33 +0000 (01:36 +0000)]
Merge "Fix misspelled word in docstring"

8 years agoMerge "Add index entry to vhost documentation"
Jenkins [Sat, 21 Nov 2015 00:09:48 +0000 (00:09 +0000)]
Merge "Add index entry to vhost documentation"

8 years agoMerge "Remove misplaced copyright attribution"
Jenkins [Fri, 20 Nov 2015 23:35:03 +0000 (23:35 +0000)]
Merge "Remove misplaced copyright attribution"

8 years agoAdd index entry to vhost documentation
armando-migliaccio [Fri, 20 Nov 2015 23:08:53 +0000 (15:08 -0800)]
Add index entry to vhost documentation

Change-Id: Ice42d1ab3456fdee73d6fa40b2cc69d961b137c8

8 years agoMerge "Reorganize and improve l3_agent functional tests"
Jenkins [Fri, 20 Nov 2015 22:21:23 +0000 (22:21 +0000)]
Merge "Reorganize and improve l3_agent functional tests"

8 years agoMerge "Add vhost-user support via ovs capabilities/datapath_type"
Jenkins [Fri, 20 Nov 2015 22:13:05 +0000 (22:13 +0000)]
Merge "Add vhost-user support via ovs capabilities/datapath_type"

8 years agoMerge "Use compare-and-swap for IpamAvailabilityRange"
Jenkins [Fri, 20 Nov 2015 22:05:59 +0000 (22:05 +0000)]
Merge "Use compare-and-swap for IpamAvailabilityRange"

8 years agoMerge "Fix use of fields argument in get_rbac_policies"
Jenkins [Fri, 20 Nov 2015 21:52:50 +0000 (21:52 +0000)]
Merge "Fix use of fields argument in get_rbac_policies"

8 years agoRemove misplaced copyright attribution
Salvatore Orlando [Fri, 20 Nov 2015 17:52:16 +0000 (09:52 -0800)]
Remove misplaced copyright attribution

the module neutron.api.extension has a copyright attribute to a user
who never contributed a line to this module. It was probably copied
over in the initial commit for the module.

This commit is probably quite pointless; however it removes a little
oddity and does no harm to anyone.

Change-Id: I985bf2cb0538a795464dfe783108f218f821d762

8 years agoFix misspelled word in docstring
Yi Zhao [Fri, 20 Nov 2015 03:16:42 +0000 (11:16 +0800)]
Fix misspelled word in docstring

This patch fixes the misspelling of dictionary several times
in docstrings.

Change-Id: I5c992c8cdbca79d8e7a28f0af5e7600614fa1e2b

8 years agoReorganize and improve l3_agent functional tests
Manjeet Singh Bhatia [Mon, 9 Nov 2015 22:03:15 +0000 (22:03 +0000)]
Reorganize and improve l3_agent functional tests

This will reorganize the l3_agent functional tests

Change-Id: I10008fd7216c8de47162657e280b7245c38f5154
Closes-Bug: #1501150

8 years agoMerge "Use SIGUSR1 to notify l3 agent of changing prefix file"
Jenkins [Fri, 20 Nov 2015 10:10:40 +0000 (10:10 +0000)]
Merge "Use SIGUSR1 to notify l3 agent of changing prefix file"

8 years agoUse compare-and-swap for IpamAvailabilityRange
Pavel Bondar [Tue, 20 Oct 2015 16:11:30 +0000 (19:11 +0300)]
Use compare-and-swap for IpamAvailabilityRange

Existing locking mechanism 'select for update' causes
deadlocks with galera multi-writers.
Replaced locking rows with compare-and-swap approach.

Compare-and-swap verifies that row is not changed by
another thread before updating/deleting it.
Filter-and-update and filter-and-delete are used.
They return count of affected rows.
If count of affected row is less than expected,
then another thread already changed our row
and RetryRequest is raised.

Change-Id: I514cae0fa43033433ec2982bcf3726e02e6692bf
Closes-Bug: #1494351

8 years agoMerge "Replace neutron-specific LengthStrOpt with StrOpt"
Jenkins [Fri, 20 Nov 2015 09:49:33 +0000 (09:49 +0000)]
Merge "Replace neutron-specific LengthStrOpt with StrOpt"

8 years agoReplace neutron-specific LengthStrOpt with StrOpt
Akihiro Motoki [Fri, 20 Nov 2015 05:08:34 +0000 (14:08 +0900)]
Replace neutron-specific LengthStrOpt with StrOpt

max_length option was added to StrOpt in oslo.config 2.7.0.
Neutron-specific LengthStrOpt is no longer required.

Change-Id: Icfecb5c8c68c942fca847e27a0c1862f18bdcdca
Closes-Bug: #1518178

8 years agoMerge "Updated from global requirements"
Jenkins [Fri, 20 Nov 2015 04:52:59 +0000 (04:52 +0000)]
Merge "Updated from global requirements"

8 years agoFix use of fields argument in get_rbac_policies
Kevin Benton [Fri, 20 Nov 2015 04:37:05 +0000 (20:37 -0800)]
Fix use of fields argument in get_rbac_policies

The 'fields' argument wasn't being passed into the _get_collection
call so the results were always coming back with all of the fields.
This adds an API test to prevent a regression.

Change-Id: Iddef9dcc7639a557a9d19dc7265f10f98e002172
Closes-Bug: #1517815

8 years agoMerge "Fix Neutron flavor framework"
Jenkins [Fri, 20 Nov 2015 01:28:50 +0000 (01:28 +0000)]
Merge "Fix Neutron flavor framework"

8 years agoMerge "Ensure l3 agent receives notification about added router"
Jenkins [Fri, 20 Nov 2015 01:23:34 +0000 (01:23 +0000)]
Merge "Ensure l3 agent receives notification about added router"

8 years agoMerge "Send 50% less debug information when executing cmd"
Jenkins [Fri, 20 Nov 2015 00:03:04 +0000 (00:03 +0000)]
Merge "Send 50% less debug information when executing cmd"

8 years agoMerge "Fix dashboard graphite URLs"
Jenkins [Thu, 19 Nov 2015 23:59:40 +0000 (23:59 +0000)]
Merge "Fix dashboard graphite URLs"

8 years agoUpdated from global requirements
OpenStack Proposal Bot [Thu, 19 Nov 2015 22:55:15 +0000 (22:55 +0000)]
Updated from global requirements

Change-Id: Ie65f1be17c1be843d4aa7c09c88edb0535dfae79

8 years agoMerge "Datapath on L2pop only for agents with tunneling-ip"
Jenkins [Thu, 19 Nov 2015 22:40:39 +0000 (22:40 +0000)]
Merge "Datapath on L2pop only for agents with tunneling-ip"

8 years agoFix dashboard graphite URLs
Ryan Moats [Thu, 19 Nov 2015 21:23:43 +0000 (15:23 -0600)]
Fix dashboard graphite URLs

The update to openstack graphite data is now storing nulls instead
of high frequency zero values. Therefore, make the following changes:

1. use stats_counts instead of stats data, as this accesses the raw
counters
2. apply transformNull to all data series so that null -> 0 is handled
correctly
3. add a global drawNullAsZero=true to handle discontinuities

Thanks to jeblair and sdague for tracking this down

Change-Id: Idebc046d7d867d80e2afe1c4b86c526f9205d3d5
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
8 years agoFix Neutron flavor framework
James Arendt [Tue, 1 Sep 2015 22:27:26 +0000 (15:27 -0700)]
Fix Neutron flavor framework

Make flavor service profile store actual driver instead of
hardcoded dummy driver.  Ensure service type on flavor persisted.

Raise ServiceProfileDriverNotFound if non-empty driver is not part
of ServiceTypeManager providers.

Raise ServiceProfileEmpty if profile has neither a driver nor
any metainfo.

Raise InvalidFlavorServiceType if invalid service type passed.

Show flavors associated with a profile, not just profiles associated
with a flavor, to ease diagnosis when ServiceProfileInUse raised.

Create method to extract provider given a flavor for use with
neutron-lbaas plus tests.

Ensure various boolean forms accepted for enabled flag.

To enable in DevStack, add to local.conf:
enable_plugin neutron https://git.openstack.org/openstack/neutron
enable_service q-flavors

Add associated unit tests. Fix tempest api test that used invalid
LOADBALANCERS service type.

Change-Id: I5c22ab655a8e2a2e586c10eae9de9b72db49755f
Implements: blueprint neutron-flavor-framework

8 years agoKeep reading stdout/stderr until after kill
John Schwarz [Wed, 14 Oct 2015 12:39:33 +0000 (15:39 +0300)]
Keep reading stdout/stderr until after kill

Currently, when calling AsyncProcess.stop(), the code stops the stdout
and stderr readers and kills the process. There exists an end case (as
described in the bug report) in which after the readers have been
stopped the sub-process will generate a substantial amount of outputs to
either fd. Since the 'subprocess' module is launched with
subprocess.PIPE as stdout/stderr, and since Linux's pipes can be filled
to the point where writing new data to them will block, this may cause a
deadlock if the sub-process has a signal handler for the signal (for
example, the process is handling SIGTERM to produce a graceful exit of
the program).

Therefore, this patch proposes to only kill the readers until AFTER
wait() returned and the process truly died. Also, relying on _kill_event
had to cease since invoking its send() method caused a logical loop back
to _kill, causing eventlet errors.

A different possible solution is closing the stdout/stderr pipes. Alas,
this may raise an exception in the sub-process ("what? No stdout?!
Crash!") and defeats the 'graceful' part of the process.

Closes-Bug: #1506021
Change-Id: I506c41c634a8d656d81a8ad7963412b834bdfa5b

8 years agoUpdated from global requirements
OpenStack Proposal Bot [Thu, 19 Nov 2015 15:57:59 +0000 (15:57 +0000)]
Updated from global requirements

Change-Id: I9f661917d8c4184aae76ba4115cd231151cf3e99

8 years agoMerge "Remove deprecated use_namespaces option"
Jenkins [Thu, 19 Nov 2015 14:45:43 +0000 (14:45 +0000)]
Merge "Remove deprecated use_namespaces option"

8 years agoMerge "Resync L3, DHCP and OVS/LB agents upon revival"
Jenkins [Thu, 19 Nov 2015 12:21:51 +0000 (12:21 +0000)]
Merge "Resync L3, DHCP and OVS/LB agents upon revival"

8 years agoSend 50% less debug information when executing cmd
John Schwarz [Thu, 12 Nov 2015 14:05:19 +0000 (16:05 +0200)]
Send 50% less debug information when executing cmd

The current code prints out the command it runs twice: once in
'create_process' or 'execute_rootwrap_daemon', and once after the
command has finished executing and a return code is returned. Since this
is synchronous, there is no need to print the command twice in a row, so
this patch deletes the latter one, leaving only the exit code to be
printed.

This patch also refactors the surrounding code to make it more readable.

Change-Id: I22289f838dbc3956a777a78c882e4d5f1e725d0e

8 years agoDatapath on L2pop only for agents with tunneling-ip
Hong Hui Xiao [Wed, 28 Oct 2015 07:28:27 +0000 (03:28 -0400)]
Datapath on L2pop only for agents with tunneling-ip

This patch is a regression issue for patch[1].

Only those agents which expose tunneling-ip will be considered in
determining data-path tunnels in deployments with l2pop ON.

[1] https://review.openstack.org/#/c/236970/

Change-Id: I7c3b911d5e7448b4e8dee15bb50df33a6e9d5cfe
Closes-Bug: #1407959

8 years agoMerge "Add a better description for notification_driver"
Jenkins [Wed, 18 Nov 2015 20:28:57 +0000 (20:28 +0000)]
Merge "Add a better description for notification_driver"

8 years agoMerge "Disable IPv6 on bridge devices in LinuxBridgeManager"
Jenkins [Wed, 18 Nov 2015 20:24:12 +0000 (20:24 +0000)]
Merge "Disable IPv6 on bridge devices in LinuxBridgeManager"

8 years agoAdd vhost-user support via ovs capabilities/datapath_type
Terry Wilson [Thu, 15 Oct 2015 23:50:40 +0000 (18:50 -0500)]
Add vhost-user support via ovs capabilities/datapath_type

Adds the ovs 'config' property which returns the contents of the
single row of the Open_vSwitch table. This gives access to certain
OVS capabilities such as datapath_types and iface_types.

Using this information in concert with the datapath_type config
option, vif details are calculated by the OVS mech driver. If
datapath_type == 'netdev' and OVS on the agent host is capable of
supporting dpdkvhostuser, then it is used.

Authored-By: Terry Wilson <twilson@redhat.com>
Co-Authored-By: Sean Mooney <sean.k.mooney@intel.com>
Closes-Bug: #1506127
Change-Id: I5047f1d1276e2f52ff02a0cba136e222779d059c

8 years agoRemove deprecated use_namespaces option
Cedric Brandily [Wed, 21 Oct 2015 18:52:40 +0000 (20:52 +0200)]
Remove deprecated use_namespaces option

The use_namespaces option has been defined as a workaround to kernels
not properly supporting namespaces. This limitation is behind us, it's
time to remove use_namespaces after its deprecation in Kilo in order to
simplify code and remove a poorly tested case (use_namespaces=False).

This change prepares for removal pullup_route method[1] which was only
used when use_namespaces=False.

[1] neutron.agent.linux.ip_lib

DocImpact
UpgradeImpact
Closes-Bug: #1508188
Related-Bug: #1435382
Depends-On: I303038eec560a6d99421140c2822aed8b518470b
Depends-On: I4feb2a15c7e1e4bfdbed2531b18b8e7d798ab3cc
Change-Id: I2fbf65df1250d9f9f1656b3964ee3b6de1ef1118

8 years agoMerge "Update networking-powervm sub-project docs"
Jenkins [Wed, 18 Nov 2015 15:56:32 +0000 (15:56 +0000)]
Merge "Update networking-powervm sub-project docs"

8 years agoMerge "Remove SysV init script for neutron-server"
Jenkins [Wed, 18 Nov 2015 15:39:24 +0000 (15:39 +0000)]
Merge "Remove SysV init script for neutron-server"

8 years agoMerge "Use get_interface_bridge instead of get_bridge_for_tap_device"
Jenkins [Wed, 18 Nov 2015 14:09:59 +0000 (14:09 +0000)]
Merge "Use get_interface_bridge instead of get_bridge_for_tap_device"

8 years agoMerge "Elaborate how priorities are assigned to blueprints"
Jenkins [Wed, 18 Nov 2015 13:59:04 +0000 (13:59 +0000)]
Merge "Elaborate how priorities are assigned to blueprints"

8 years agoResync L3, DHCP and OVS/LB agents upon revival
Eugene Nikanorov [Mon, 12 Oct 2015 09:59:01 +0000 (13:59 +0400)]
Resync L3, DHCP and OVS/LB agents upon revival

In big and busy clusters there could be a condition when
rabbitmq clustering mechanism synchronizes queues and during
this period agents connected to that instance of rabbitmq
can't communicate with the server and server considers them
dead moving resources away. After agent become active again,
it needs to cleanup state entries and synchronize its state
with neutron-server.
The solution is to make agents aware of their state from
neutron-server point of view. This is done by changing state
reports from cast to call that would return agent's status.
When agent was dead and becomes alive, it would receive special
AGENT_REVIVED status indicating that it should refresh its
local data which it would not do otherwise.

Closes-Bug: #1505166
Change-Id: Id28248f4f75821fbacf46e2c44e40f27f59172a9

8 years agoMerge "Updated from global requirements"
Jenkins [Wed, 18 Nov 2015 06:20:38 +0000 (06:20 +0000)]
Merge "Updated from global requirements"

8 years agoMerge "Add fullstack testing doc content"
Jenkins [Wed, 18 Nov 2015 01:36:26 +0000 (01:36 +0000)]
Merge "Add fullstack testing doc content"

8 years agoMerge "Firewall: fix typo"
Jenkins [Wed, 18 Nov 2015 01:07:24 +0000 (01:07 +0000)]
Merge "Firewall: fix typo"

8 years agoUpdated from global requirements
OpenStack Proposal Bot [Wed, 18 Nov 2015 00:20:10 +0000 (00:20 +0000)]
Updated from global requirements

Change-Id: I84d6a701985e25137a06299b28e306e0a65e70a4

8 years agoMerge "Add networking-infoblox sub-project"
Jenkins [Tue, 17 Nov 2015 23:09:35 +0000 (23:09 +0000)]
Merge "Add networking-infoblox sub-project"

8 years agoMerge "Fix dvr_local_router.floating_ip_added_dist failure after agent restart"
Jenkins [Tue, 17 Nov 2015 22:11:45 +0000 (22:11 +0000)]
Merge "Fix dvr_local_router.floating_ip_added_dist failure after agent restart"

8 years agoMerge "Use DEVICE_OWNER_* for 'network:*' constants"
Jenkins [Tue, 17 Nov 2015 21:18:42 +0000 (21:18 +0000)]
Merge "Use DEVICE_OWNER_* for 'network:*' constants"

8 years agoMerge "Don't add default route to HA router if there is no gateway ip"
Jenkins [Tue, 17 Nov 2015 21:07:48 +0000 (21:07 +0000)]
Merge "Don't add default route to HA router if there is no gateway ip"

8 years agoMerge "Fix the indentation issue"
Jenkins [Tue, 17 Nov 2015 18:35:07 +0000 (18:35 +0000)]
Merge "Fix the indentation issue"

8 years agoMerge "Avoid race condition for reserved DHCP ports"
Jenkins [Tue, 17 Nov 2015 18:30:10 +0000 (18:30 +0000)]
Merge "Avoid race condition for reserved DHCP ports"

8 years agoAdd networking-infoblox sub-project
John Belamaric [Thu, 12 Nov 2015 19:07:22 +0000 (14:07 -0500)]
Add networking-infoblox sub-project

Add the subproject to the documentation of affiliated
projects, and add a short description of ipam to the
functionality legend.

Add networking-infoblox Lieutenant information.

Change-Id: I0daf6068c5b78331558bc7b2bd015c456d772249

8 years agoFirewall: fix typo
Gary Kotton [Tue, 17 Nov 2015 13:14:56 +0000 (05:14 -0800)]
Firewall: fix typo

Changes devices_with_udpated_sg_members to
devices_with_updated_sg_members

TrivialFix

Change-Id: I3da9bf1fc108db9a4cbb2701b0363d92d426d7e7
Closes-bug: #1517018

8 years agoFix the indentation issue
guiyanxing [Tue, 17 Nov 2015 09:12:51 +0000 (17:12 +0800)]
Fix the indentation issue

This patch fixs the indentation issue to comply with pep8 style.

Change-Id: Ia6e70d226bfaf48b60e07acf611162dbe56ff5ec

8 years agoMerge "Remove unused delete_dvr_mac_address method"
Jenkins [Tue, 17 Nov 2015 08:45:29 +0000 (08:45 +0000)]
Merge "Remove unused delete_dvr_mac_address method"

8 years agoElaborate how priorities are assigned to blueprints
armando-migliaccio [Wed, 11 Nov 2015 21:05:46 +0000 (13:05 -0800)]
Elaborate how priorities are assigned to blueprints

Prioritizing is hard, and prioritizing in open source, let
alone Openstack, is even harder.

For this reason, this proposal attempts to clarify what priority
mean, how we prioritize in Neutron, in a way that's objective,
consistent, and reproducible. To start with, and make things slightly
simpler, we reduce the number of priority buckets we can choose from
to two: High and Low.

The way priorities are assigned is then based on a set of clearly defined
criteria: high priority work items are items that all core folks
collectively should care about because any failure in achieving tangible
result make them look bad. Low work items are great to have, but if they
slipped, it would be a shame but not the end of the world.

Keep on reading to learn more.

Change-Id: I0f4ba622eb3d8e02b0c3204967fb8eae22db09c8

8 years agoMerge "Revert "Move dhcp_lease_duration into DHCP agent config options list""
Jenkins [Tue, 17 Nov 2015 05:29:34 +0000 (05:29 +0000)]
Merge "Revert "Move dhcp_lease_duration into DHCP agent config options list""

8 years agoDon't add default route to HA router if there is no gateway ip
Hong Hui Xiao [Sun, 15 Nov 2015 09:06:45 +0000 (04:06 -0500)]
Don't add default route to HA router if there is no gateway ip

When adding an external network with no gateway ip to a HA router,
l3 agent will report exception. The exception comes from the code
of adding default route to HA router. However, if there is no
gateway ip in the external network, there is no need to add such
route.

Change-Id: I41d6a292c903758f408d3d93a64dca7adeeb5769
Closes-Bug: #1515209

8 years agoAdd a better description for notification_driver
Dongcan Ye [Mon, 16 Nov 2015 15:42:37 +0000 (23:42 +0800)]
Add a better description for notification_driver

Improve description for the notification_driver
property in neutron.conf, so users will understand
how to configure it correctly.

Change-Id: Ib5d4c4b6eea5cabf58708d8201f9ff9c883b6c97

8 years agoUse DEVICE_OWNER_* for 'network:*' constants
Gary Kotton [Sun, 15 Nov 2015 08:54:38 +0000 (00:54 -0800)]
Use DEVICE_OWNER_* for 'network:*' constants

Now that we have the constant defined, we should reuse it from other
code to avoid potential typos.

Change-Id: Id7a941c1a461264ba44893d97cc6226f092e9888

8 years agoMerge "Remove the useless l3plugin check in l3_rpc.py"
Jenkins [Tue, 17 Nov 2015 04:39:50 +0000 (04:39 +0000)]
Merge "Remove the useless l3plugin check in l3_rpc.py"

8 years agoMerge "Fix releasenotes/../unreleased.rst"
Jenkins [Tue, 17 Nov 2015 04:35:29 +0000 (04:35 +0000)]
Merge "Fix releasenotes/../unreleased.rst"

8 years agoMerge "Check missed IPSet utility using neutron-sanity-check"
Jenkins [Tue, 17 Nov 2015 02:12:03 +0000 (02:12 +0000)]
Merge "Check missed IPSet utility using neutron-sanity-check"

8 years agoMerge "Add the missing arg of RetryRequest exception in _lock_subnetpool"
Jenkins [Tue, 17 Nov 2015 02:07:50 +0000 (02:07 +0000)]
Merge "Add the missing arg of RetryRequest exception in _lock_subnetpool"

8 years agoMerge "Use admin context when requesting floating ip's router info"
Jenkins [Tue, 17 Nov 2015 02:06:50 +0000 (02:06 +0000)]
Merge "Use admin context when requesting floating ip's router info"

8 years agoMerge "Fix notification driver package"
Jenkins [Tue, 17 Nov 2015 00:36:52 +0000 (00:36 +0000)]
Merge "Fix notification driver package"

8 years agoAdd the missing arg of RetryRequest exception in _lock_subnetpool
Yalei Wang [Wed, 11 Nov 2015 15:50:20 +0000 (23:50 +0800)]
Add the missing arg of RetryRequest exception in _lock_subnetpool

RetryRequest exception defined in oslo.db need be called with a arg
which describes the inner exception. _lock_subnetpool method missed this
arg, and this patch adds it.

Change-Id: I44869c97ecd7d59d40d8793c71515067a237150b
Closes-Bug: #1506818

8 years agoUpdate networking-powervm sub-project docs
adreznec [Mon, 16 Nov 2015 21:54:30 +0000 (15:54 -0600)]
Update networking-powervm sub-project docs

Update the sub-project documentation to reflect the
rename of the neutron-powervm project to networking-powervm

Change-Id: I716760c8bb318c40fce9ec5131977a1643667a97

8 years agoRemove unused delete_dvr_mac_address method
Assaf Muller [Mon, 16 Nov 2015 20:51:10 +0000 (15:51 -0500)]
Remove unused delete_dvr_mac_address method

I looked backed to stable/kilo and stable/liberty,
I'm not sure this method was ever used, so there is
no upgrade concern either.

Change-Id: Id72ee9114a8c3f1e49314c03dbab0b15b327eb93

8 years agoAdd fullstack testing doc content
Assaf Muller [Mon, 16 Nov 2015 20:20:25 +0000 (15:20 -0500)]
Add fullstack testing doc content

* Tighten the opening paragraph
* Explain RabbitMQ 'vhosts'
* Add an example

Change-Id: Ic905afb3b5fa8674647413a8df67b5ddcadfd75f

8 years agoMerge "Fix broken references in doc"
Jenkins [Mon, 16 Nov 2015 17:45:08 +0000 (17:45 +0000)]
Merge "Fix broken references in doc"

8 years agoMerge "Switch to using neutron.common.utils:replace_file()"
Jenkins [Mon, 16 Nov 2015 13:58:19 +0000 (13:58 +0000)]
Merge "Switch to using neutron.common.utils:replace_file()"

8 years agoFix releasenotes/../unreleased.rst
Andreas Jaeger [Mon, 16 Nov 2015 13:55:46 +0000 (14:55 +0100)]
Fix releasenotes/../unreleased.rst

The title is not valid RST, remove the extra "+" and align the headings
with the length of the string.

Change-Id: I32afdcc84e51a53a63a7cacaeba271b2f7811d75

8 years agoMerge "sub_projects.rst: Update midonet functionalities"
Jenkins [Mon, 16 Nov 2015 13:53:31 +0000 (13:53 +0000)]
Merge "sub_projects.rst: Update midonet functionalities"

8 years agoAvoid race condition for reserved DHCP ports
Eugene Nikanorov [Mon, 19 Oct 2015 13:41:32 +0000 (17:41 +0400)]
Avoid race condition for reserved DHCP ports

This patch introduces mechanism similar to compare-and-swap
for updating reserved DHCP port.

This addresses a case when two DHCP agents that start nearly at
the same time are assigned to one network and there is a reserved
DHCP port in the network. Then each of agents will try to use it
because agents don't check if reserved port is still available.
Reserved DHCP port can be acquired by different agent between calls to
get_active_networks and update_port, so this patch adds a check for
this case.

Change-Id: I0277ab537ff9d3a664c03ea291b9ec2b0e784dbb
Closes-Bug: #1425402

8 years agoRevert "Move dhcp_lease_duration into DHCP agent config options list"
Kevin Benton [Mon, 16 Nov 2015 10:53:24 +0000 (10:53 +0000)]
Revert "Move dhcp_lease_duration into DHCP agent config options list"

This reverts commit 3101e2b62f0741baffc61174637486da17dd29bb.

The lease duration isn't DHCP agent specific. DHCP is a feature that
should be provided by whatever plugin is loaded and operators would
still like to set lease times for DHCP.

In the reference implementation we just consume it directly in the
agent, but that doesn't mean it's specific to the agent implementation.

Change-Id: I5efb6aa5e196d4cac5ff7c0c35be5a350401b925

8 years agoMerge "Trivial fix in ml2 conf"
Jenkins [Mon, 16 Nov 2015 09:21:39 +0000 (09:21 +0000)]
Merge "Trivial fix in ml2 conf"

8 years agosub_projects.rst: Update midonet functionalities
YAMAMOTO Takashi [Mon, 16 Nov 2015 07:21:08 +0000 (16:21 +0900)]
sub_projects.rst: Update midonet functionalities

FWaaS: Ie8283eb17c12960e0190da1bf9acc86916ca51b0
ML2: I0b0ce33edb108131e71f7a3307660810b55dbcf4
L3: Ic87c1efd34835fabebc2b98837c19b097d48dc0e

Change-Id: I10a251a8311c76c89731a1670266f9c771ccb5f7

8 years agoMerge "Remove MidonetInterfaceDriver"
Jenkins [Mon, 16 Nov 2015 08:48:12 +0000 (08:48 +0000)]
Merge "Remove MidonetInterfaceDriver"

8 years agoMerge "Fix some reST field lists in docstrings"
Jenkins [Mon, 16 Nov 2015 07:52:43 +0000 (07:52 +0000)]
Merge "Fix some reST field lists in docstrings"

8 years agoSwitch to using neutron.common.utils:replace_file()
Bogdan Tabor [Wed, 7 Oct 2015 13:49:08 +0000 (15:49 +0200)]
Switch to using neutron.common.utils:replace_file()

neutron.agent.linux.utils:replace_file() and
neutron.common.utils:replace_file() have same functionality.

This is the 1st patch in the series of 4 patches.
It modifies neutron.common.utils:replace_file(),
so it can be used by all components as a replacement
for neutron.agent.linux.utils:replace_file().
New keyword parameter 'file_mode=0o644' is added
to neutron.common.utils:replace_file().

Partial-bug: #1504477
Change-Id: Id1a7f1236786e8606c91bb9925cd9ac8e95892b3

8 years agoTrivial fix in ml2 conf
Dongcan Ye [Sun, 15 Nov 2015 15:15:30 +0000 (23:15 +0800)]
Trivial fix in ml2 conf

Fix alignment for ml2_type_gre section in ml2_conf.ini, using
two lines instead of one line.

Change-Id: I567b53e442d6393b9efc9c8b1e2d60786fbe584b

8 years agoRemove the useless l3plugin check in l3_rpc.py
Hong Hui Xiao [Sun, 15 Nov 2015 13:49:13 +0000 (08:49 -0500)]
Remove the useless l3plugin check in l3_rpc.py

Without "L3_ROUTER_NAT" in neutron's service_plugins, l3_rpc will
fail when getting l3plugin. So, remove the useless "if" block
here.

Change-Id: I56f417e5723ed40c70a186394de0bfcff696e469
Closes-Bug: #1514144

8 years agoMerge "Use DEVICE_OWNER_COMPUTE constant everywhere"
Jenkins [Sun, 15 Nov 2015 09:13:18 +0000 (09:13 +0000)]
Merge "Use DEVICE_OWNER_COMPUTE constant everywhere"

8 years agoFix some reST field lists in docstrings
Yi Zhao [Thu, 12 Nov 2015 08:38:45 +0000 (16:38 +0800)]
Fix some reST field lists in docstrings

This patch updates some docstrings to comply with the reST field
lists syntax.

Change-Id: I1b4469f3c90915cdfd6462c0517f6924b263fef6

8 years agoUse DEVICE_OWNER_COMPUTE constant everywhere
Ihar Hrachyshka [Wed, 30 Sep 2015 10:50:38 +0000 (12:50 +0200)]
Use DEVICE_OWNER_COMPUTE constant everywhere

Now that we have the constant defined, we should reuse it from other
code to avoid potential typos.

Change-Id: Iebb270be46b116df3441370dc1a6784571311aa9

8 years agoMerge "Skip bindings with agent_id=None"
Jenkins [Sat, 14 Nov 2015 16:26:29 +0000 (16:26 +0000)]
Merge "Skip bindings with agent_id=None"

8 years agoFix broken references in doc
Akihiro Motoki [Thu, 12 Nov 2015 13:57:05 +0000 (22:57 +0900)]
Fix broken references in doc

Change-Id: Iaaa8a064163500d1bd8a7249b2efcda2f10937b5

8 years agoMerge "Undeprecate force_gateway_on_subnet option"
Jenkins [Sat, 14 Nov 2015 09:22:39 +0000 (09:22 +0000)]
Merge "Undeprecate force_gateway_on_subnet option"

8 years agoSkip bindings with agent_id=None
Ann Kamyshnikova [Wed, 21 Oct 2015 14:37:34 +0000 (17:37 +0300)]
Skip bindings with agent_id=None

To avoid having extra L3HARouterAgentPortBinding with l3_agent as None,
operation of setting l3_agent should be atomic.
For this purpose, transaction was added in methods
create_ha_port_and_bind and _bind_ha_router_to_agents in change
Iaad82fe522cfd70061daecf411c924fdc11b7e41

In case if router was just created and l3 agent was not scheduled yet,
so l3_agent_id is None, l3-agent-list-hosting-router <router> will fail.
This change makes it work by skipping binding with agent_id=None.

Partial-bug: #1499647

Change-Id: I1aaf4b651f738febc26b0e1105aeabe066bca2a0

8 years agoMerge "Cleanup dhcp namespace upon dhcp setup."
Jenkins [Sat, 14 Nov 2015 00:34:21 +0000 (00:34 +0000)]
Merge "Cleanup dhcp namespace upon dhcp setup."

8 years agoMerge "Replace get_all_neutron_bridges by get_deletable_bridges"
Jenkins [Fri, 13 Nov 2015 23:56:39 +0000 (23:56 +0000)]
Merge "Replace get_all_neutron_bridges by get_deletable_bridges"

8 years agoMerge "Add transaction for setting agent_id in L3HARouterAgentPortBinding"
Jenkins [Fri, 13 Nov 2015 23:55:48 +0000 (23:55 +0000)]
Merge "Add transaction for setting agent_id in L3HARouterAgentPortBinding"

8 years agoMerge "Last sync from oslo-incubator"
Jenkins [Fri, 13 Nov 2015 23:55:33 +0000 (23:55 +0000)]
Merge "Last sync from oslo-incubator"

8 years agoMerge "Adding security-groups unittests"
Jenkins [Fri, 13 Nov 2015 22:32:41 +0000 (22:32 +0000)]
Merge "Adding security-groups unittests"

8 years agoMerge "Refactor test_server functional tests"
Jenkins [Fri, 13 Nov 2015 22:32:15 +0000 (22:32 +0000)]
Merge "Refactor test_server functional tests"

8 years agoMerge "Move dhcp_lease_duration into DHCP agent config options list"
Jenkins [Fri, 13 Nov 2015 22:31:42 +0000 (22:31 +0000)]
Merge "Move dhcp_lease_duration into DHCP agent config options list"