This patch simply changes the logic for discriminating which
extensions have already been loaded using the extension alias
rather than the module name.
This will avoid failures already observed in unit tests occurring
if two extension modules happen to have the same module file name
even if they're unrelated.
This change cannot be unit-tested as the neutron unit test
framework is currently lacking a mechanism to mock and validate
extension loading from the file system.
Carl Baldwin [Sat, 31 Jan 2015 00:27:52 +0000 (00:27 +0000)]
Don't pass the port down to the floating ip processing
This is justified by the Law of Demeter. I ran in to this while
trying to refactor the floating ip processing here [1]. The scope of
that patch can be reduced significantly with this refactor. Also, it
helps us to decouple the floating ip NAT processing from the details
of the port which is a long-term goal.
Carl Baldwin [Wed, 7 Jan 2015 19:25:41 +0000 (19:25 +0000)]
Encapsulate DVR Fip namespace
The floating ip namespace is an important concept that links a DVR
enabled L3 agent to DVR routers. The namespace is shared by all of
the dvr routers on a compute host connected to the same network. It
is managed by the dvr enabled agent. Hence, it should be known to the
agent and made available to the DVR routers as well. This calls for a
proper encapsulation of this functionality in a class which can be
accessed by both the agent and the routers.
In trying to tease floating ip functionality out of the L3 agent and
in to the new router classes, I found it very difficult to do because
the logic around the floating ip namespace has not yet been properly
encapsulated.
Carl Baldwin [Tue, 27 Jan 2015 22:34:06 +0000 (22:34 +0000)]
Move ha router functionality from the agent to ha_router
This was pretty much a mechanical change. Most of the methods passed
in ri as the first argument and so changing the way they're called was
a simple matter of replacing self with ri. In the methods themselves,
I first made sure that self was not referenced for anything that
wasn't available in the router context and then replaced ri with self.
Add requirements.txt file for OpenDaylight Mech Driver
Move the driver into its own module, but make the change
backward compatible so that we don't break the ODL driver
counterpart (which will use the new module when [1] merges).
Doug Wiegley [Wed, 28 Jan 2015 03:17:00 +0000 (20:17 -0700)]
Mechanisms to move extensions and config into service repos
- Extensions will automatically be loaded from service repos in addition
to neutron proper, but neutron proper will take precedence.
- Config entries for service repos will be read out of neutron-{service}.conf
first, and then neutron.conf. After Kilo, they will be read only from
neutron-{service}.conf.
- Service providers for drivers will be collected from all neutron conf files.
This is review 1 of 3. The second set will be in the server repos, moving
the extensions. The third will be in neutron, removing the service exts.
Sukhdev [Tue, 20 Jan 2015 18:37:33 +0000 (10:37 -0800)]
Thining Arista ML2 driver from neutron tree
Moving all the back-end drivers for the Arista
ML2 driver. The DB Models and Config is
left in the tree. Rest all is moving to
networking-arista project.
Reorganize the code to ensure a smoother transition
to a decomposed Arista ML2 driver.
Miguel Angel Ajo [Mon, 18 Aug 2014 11:00:58 +0000 (13:00 +0200)]
Implements the ProcessMonitor in the l3_agent
The ProcessMonitor class will watch over spawned external processes,
taking the administrator configured action in the case of any
of the external processes dying unexpectedly.
It covers both the neutron-ns-metadata-proxy for non-ha routers
and the IPv6 radvd external processes. Keepalived +
neutron-ns-metadata-proxy needs to be covered in a second follow up
patch when neutron-ns-metadata-proxy is handled by the l3-agent
(instead keepalived) in the ha-routers.
Moshe Levi [Sun, 11 Jan 2015 13:25:59 +0000 (15:25 +0200)]
Thin MLNX ML2 mechanism driver and agent
This commit thins the in-tree MLNX ML2 MechanismDriver and Agent. A matching
change to the stackforge/networking-mlnx project has the backend logic
there.
Ann Kamyshnikova [Fri, 12 Dec 2014 12:30:06 +0000 (15:30 +0300)]
Default security group table
This change prevents the race condition by enforcing a single default
security group via new table default_security_group. It has tenant_id
as primary key and security_group_id, which is id of default
security group. Migration that inroduces this table has sanity check that
verifies that there is no duplicate default security group in any
tenant.
This idea has come up from discussion in comments to
https://review.openstack.org/135006
Do not check twice IP allocations for auto-address subnets
For auto-address subnets such as those with SLAAC and DHCP_STATELESS
address modes it is ok to delete them even when there are active IP
allocations.
The current logic might trigger unexpected 409 errors if IP
allocations are made on these subnets concurrently with their
deletion.
This patch simply ensures the final check for active IP allocations is
not performed for this class of subnets; since all IP allocations will
be removed anyway, it does not make sense to check whether there are
allocations at all. In fact, doing this check might cause a failure
of the delete operation if an IP allocation is made concurrently.
This patch also factors out the logic for checking whether there are
IP allocations on the subnet to avoid code duplication.
Carl Baldwin [Wed, 28 Jan 2015 17:50:31 +0000 (17:50 +0000)]
Make the interface driver available to the router classes
Ultimately, it will only be the routers that need access to the
interface driver and the agent won't need to use it for anything.
However, it still makes sense for the agent to initialize it once and
pass it to each of the routers as they're created.
Multiple patches with multiple authors will be created to depend on
this addition.
Carl Baldwin [Tue, 20 Jan 2015 16:48:47 +0000 (16:48 +0000)]
Make agent config available to the router classes
Since the agent and the routers are all configured in the same config
file, the routers are going to need access to the agent's config.
This work will support multiple future patches.
Yoni Shafrir [Mon, 26 Jan 2015 07:32:55 +0000 (09:32 +0200)]
Allow 'max_l3_agents_per_router' to be set to '0'
Currently the field 'max_l3_agents_per_router' from
'neutron.conf' cannot be set to '0' even though the comments
and code indicate it is be supported. The value
means 'unlimited' agents per router is allowed on HA routers.
This patch adds a special handling for this value when validating
the config. When a value of '0' is used, the further validation
of max value is skipped.
Kyle Mestery [Mon, 26 Jan 2015 15:12:31 +0000 (15:12 +0000)]
Add abandon script from nova
This adds the abandon_old_reviews.sh from the nova repository into
Neutron. This is handy for cleaning up the neutron review queues
by abandoning stale reviews stuck in the queue with a helpful
message.
Miguel Angel Ajo [Tue, 27 Jan 2015 11:52:30 +0000 (11:52 +0000)]
Refactor the ProcessMonitor _exit_handler to ProcessMonitor
We allowed to provide an specific _exit_handler, but in
the end all the implementations are providing the same
one. So, now it's refactored back to the monitor, and
removed any YAGNI code.
Brings in VLAN underlay support for
distributed virtual router. In line with
it brings in the ability to route packets
between VLAN and VXLAN (or) VLAN and GRE
networks via distributed virtual routers.
Lucian Petrut [Mon, 26 Jan 2015 18:58:18 +0000 (20:58 +0200)]
Fixes Hyper-V agent root_helper issue
This patch I2aaa55e8e539e47427e56b4da42321cfcfcde622 introduced a
reference to the root_helper config option in the Hyper-V Neutron
agent without it being registered. For this reason,
the Hyper-V Neutron agent fails to start.
As the root helper is not used by the Hyper-V Neutron agent,
all the occurences within the agent can be safely removed.
Brian Haley [Tue, 25 Nov 2014 02:33:20 +0000 (21:33 -0500)]
Add address family to 'ip rule' calls
Without an address family, 'ip rule' won't work with IPv6
arguments because it assumes IPv4. This causes the l3-agent
to throw an error when adding a rule in DVR mode.
Also changed these functions to be more symmetrical and take the
same arguments, which required a little tweaking, but it looks
much cleaner now.
Code Review / openstack-build / neutron-build.git / log