]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/log
Travis Fields [Tue, 15 Jul 2014 16:12:52 +0000 (09:12 -0700)]
Merge pull request #331 from apenney/152-release
Prepare a 1.5.2 release.
Ashley Penney [Tue, 15 Jul 2014 15:32:58 +0000 (11:32 -0400)]
Prepare a 1.5.2 release.
Hunter Haugen [Wed, 9 Jul 2014 23:50:42 +0000 (16:50 -0700)]
Merge pull request #328 from mhaskel/1.5.1-prep
1.5.1 prep.
Morgan Haskel [Wed, 9 Jul 2014 23:34:12 +0000 (19:34 -0400)]
1.5.1 prep.
Hunter Haugen [Wed, 11 Jun 2014 17:38:36 +0000 (10:38 -0700)]
Merge pull request #312 from mhaskel/test_osx_graceful_failure
Test osx graceful failure
Morgan Haskel [Wed, 11 Jun 2014 17:31:53 +0000 (13:31 -0400)]
Add test case to ensure graceful failure on OSX.
Travis Fields [Mon, 9 Jun 2014 15:42:57 +0000 (08:42 -0700)]
Merge pull request #309 from apenney/pin-rspec
Pin rspec
Ashley Penney [Mon, 9 Jun 2014 15:29:29 +0000 (11:29 -0400)]
Pin rspec to 2.x.
Hunter Haugen [Wed, 4 Jun 2014 18:03:19 +0000 (11:03 -0700)]
Merge pull request #306 from apenney/fix-changelog
Remove claims of support.
Ashley Penney [Wed, 4 Jun 2014 17:54:22 +0000 (13:54 -0400)]
Remove claims of support.
Morgan Haskel [Wed, 21 May 2014 23:26:07 +0000 (19:26 -0400)]
Update PE version requirements.
Ashley Penney [Fri, 30 May 2014 16:46:14 +0000 (12:46 -0400)]
Merge branch '1.5.x' of https://github.com/puppetlabs/puppetlabs-apt into 1.5.x
Morgan Haskel [Thu, 29 May 2014 17:07:38 +0000 (13:07 -0400)]
Merge pull request #303 from apenney/fix-ubuntu-10-tests
Fix the tests for Ubuntu 10.04.
Ashley Penney [Wed, 21 May 2014 23:29:26 +0000 (16:29 -0700)]
Merge pull request #301 from mhaskel/1.5.0-prep
1.5.0 prep
Morgan Haskel [Wed, 21 May 2014 23:26:07 +0000 (19:26 -0400)]
Update PE version requirements.
Ashley Penney [Wed, 21 May 2014 18:19:04 +0000 (11:19 -0700)]
Merge branch '1.5.x' of https://github.com/puppetlabs/puppetlabs-apt into 1.5.x
Ashley Penney [Wed, 21 May 2014 17:39:17 +0000 (10:39 -0700)]
Merge pull request #300 from apenney/fix-tests
Block this from running on unsupported platforms.
Hunter Haugen [Tue, 20 May 2014 20:27:40 +0000 (13:27 -0700)]
Merge pull request #299 from mhaskel/1.5.0-prep
1.5.0 prep
Morgan Haskel [Tue, 20 May 2014 20:24:28 +0000 (16:24 -0400)]
Fixing lint and adding the trusty nodeset (not sure how that was missed)
Ashley Penney [Thu, 15 May 2014 18:58:49 +0000 (14:58 -0400)]
Claim PE3.3 support.
Ashley Penney [Wed, 14 May 2014 20:28:06 +0000 (16:28 -0400)]
Prepare for 1.5.0.
Ashley Penney [Wed, 14 May 2014 17:18:18 +0000 (13:18 -0400)]
Merge pull request #294 from apenney/14x-merge
14x merge
Ashley Penney [Wed, 14 May 2014 17:17:19 +0000 (13:17 -0400)]
Merge branch '1.4.x' into 14x-merge
Ashley Penney [Thu, 8 May 2014 14:44:11 +0000 (10:44 -0400)]
Merge pull request #292 from daenney/test-puppet-35
Drop testing on 3.3, add 3.5.
Daniele Sluijters [Thu, 8 May 2014 07:54:08 +0000 (09:54 +0200)]
Drop testing on 3.3, add 3.5.
Ashley Penney [Mon, 5 May 2014 15:54:52 +0000 (11:54 -0400)]
Merge pull request #290 from dpnl87/wheezy-preference-fix
Do not add bogus line to apt preference file on Debian Wheezy
Daniel Paulus [Mon, 5 May 2014 12:39:25 +0000 (14:39 +0200)]
Add dpaulus to the contributors list
Daniel Paulus [Mon, 5 May 2014 10:06:39 +0000 (12:06 +0200)]
Some code cleaning
Daniel Paulus [Mon, 5 May 2014 09:57:42 +0000 (11:57 +0200)]
Fixed acceptance spec and add debian nodeset
Daniel Paulus [Fri, 2 May 2014 22:13:17 +0000 (00:13 +0200)]
Testing if we are not touching the preference file when purge mode is off
Daniel Paulus [Fri, 2 May 2014 22:06:23 +0000 (00:06 +0200)]
Updated readme to indicate danger of setting preference purge options
Daniel Paulus [Fri, 2 May 2014 21:35:54 +0000 (23:35 +0200)]
Remove the preference file for all supported platforms when in purge mode
Daniel Paulus [Fri, 2 May 2014 15:56:06 +0000 (17:56 +0200)]
Do not add bogus line to apt preference file on Debian Wheezy
Ashley Penney [Wed, 23 Apr 2014 00:46:55 +0000 (20:46 -0400)]
Merge pull request #286 from apenney/fix-for-post-wheezy
unattended_upgrades: Fix matching security archive
Daniele Sluijters [Thu, 27 Mar 2014 12:51:08 +0000 (13:51 +0100)]
unattended_upgrades: Fix matching security archive
The default configuration we were writing for Debian was only working
for Squeeze, from Wheezy and onwards this wasn't working anymore. This
has to do with the fact that we should now be using Origins-Pattern
according to the unattended-upgrades docs. However, Ubuntu didn't
entirely get with the program yet...
This change reflects the defaults that unattended-upgrade installs on
every platform we support. In order to do so the unattended-upgrades
Debian archive for Squeeze, Wheezy, Lucid, Precise and Trusty were
downloaded and the default /etc/apt/apt.conf.d/50unattended-upgrades
checked for its content with regard to using Allow-Origins or
Origins-Pattern.
Fixes #277
Ashley Penney [Thu, 17 Apr 2014 17:00:50 +0000 (13:00 -0400)]
Merge pull request #285 from blkperl/fix_metadata
Fix metadata.json file
Ashley Penney [Mon, 3 Mar 2014 21:39:10 +0000 (21:39 +0000)]
Add back in missing fields to work around Puppet bug.
(cherry picked from commit
dc472717163d30a4463f687a577238ec2539601c )
Ashley Penney [Fri, 28 Feb 2014 15:34:08 +0000 (15:34 +0000)]
Prepare metadata for supported module release.
(cherry picked from commit
ab03a989df37df3660f0916519d0f78f7ab73a13 )
Ashley Penney [Sat, 12 Apr 2014 18:37:40 +0000 (14:37 -0400)]
Merge pull request #283 from johanfleury/master
Change proxy's configuration file to be consistent with other config files in apt.conf.d
Johan Fleury [Fri, 11 Apr 2014 06:35:25 +0000 (08:35 +0200)]
Writing proxy configuration in apt.conf.d/01proxy.
This commit changes the proxy file name to be more consistent with other files
in `apt.conf.d`. The old file (`apt.conf.d/proxy`) is removed.
Tests has been updated.
Lauren Rother [Mon, 7 Apr 2014 17:56:20 +0000 (10:56 -0700)]
Add security warning re: short keys
(cherry picked from commit
d7da1cef383663bb2ecee3d8afa612aea74219f7 )
Ashley Penney [Mon, 7 Apr 2014 18:06:47 +0000 (14:06 -0400)]
Merge pull request #282 from laurenrother/security
Add security warning re: short keys
Lauren Rother [Mon, 7 Apr 2014 17:56:20 +0000 (10:56 -0700)]
Add security warning re: short keys
Ashley Penney [Thu, 3 Apr 2014 17:59:51 +0000 (13:59 -0400)]
Merge pull request #280 from daenney/fix-pin-comments
Fix pin comments
Ashley Penney [Thu, 3 Apr 2014 17:59:15 +0000 (13:59 -0400)]
Merge pull request #281 from daenney/unattended-upgrades-squeeze-origins
unattended-upgrades: Fix origins for Squeeze.
Daniele Sluijters [Wed, 2 Apr 2014 09:17:04 +0000 (11:17 +0200)]
unattended-upgrades: Fix origins for Squeeze.
Because Squeeze is now oldstable we need to add an oldstable line too
otherwise security updates won't be picked up. This is still because we
can't match on codename.
Daniele Sluijters [Fri, 28 Mar 2014 07:49:18 +0000 (08:49 +0100)]
pin: caller_module_name is not a topscope variable
Daniele Sluijters [Fri, 28 Mar 2014 07:47:19 +0000 (08:47 +0100)]
pin: Fix the template.
In APT preferences files the only allowed comments are lines that start
with `Explanation:`, commented lines that start with a # trigger a
myriad of interesting bugs. This is considered a feature of APT.
Because we're only ever writing a single file at a time with only a #
comment at the top we were getting away with this but it shouldn't be
there in the first place.
Ashley Penney [Thu, 27 Mar 2014 16:43:27 +0000 (12:43 -0400)]
Merge pull request #279 from apenney/fix-spacing
Small patch to fix the spacing that makes lint fail.
Ashley Penney [Thu, 27 Mar 2014 16:40:36 +0000 (16:40 +0000)]
Small patch to fix the spacing that makes lint fail.
Ashley Penney [Thu, 27 Mar 2014 12:59:51 +0000 (08:59 -0400)]
Merge pull request #278 from daenney/fix-unattended-upgrades
unattended_upgrades: Fix matching security archive
Daniele Sluijters [Thu, 27 Mar 2014 12:51:08 +0000 (13:51 +0100)]
unattended_upgrades: Fix matching security archive
The default configuration we were writing for Debian was only working
for Squeeze, from Wheezy and onwards this wasn't working anymore. This
has to do with the fact that we should now be using Origins-Pattern
according to the unattended-upgrades docs. However, Ubuntu didn't
entirely get with the program yet...
This change reflects the defaults that unattended-upgrade installs on
every platform we support. In order to do so the unattended-upgrades
Debian archive for Squeeze, Wheezy, Lucid, Precise and Trusty were
downloaded and the default /etc/apt/apt.conf.d/50unattended-upgrades
checked for its content with regard to using Allow-Origins or
Origins-Pattern.
Fixes #277
Hunter Haugen [Wed, 26 Mar 2014 21:53:26 +0000 (14:53 -0700)]
Merge pull request #275 from daenney/backports-pin-priority
backports: Allow setting a custom priority.
Daniele Sluijters [Wed, 26 Mar 2014 16:13:08 +0000 (17:13 +0100)]
backports: Allow setting a custom priority.
The module used to always pin backports to a priority of 200. This
default is still retained but is now configurable.
Additionally the default is now an Integer, not a 'quoted Integer' and
the tests have been updated to reflect this. This matters for future
parser as it will now kick people if they pass in a stringified integer
as priority.
Hunter Haugen [Wed, 26 Mar 2014 18:08:14 +0000 (11:08 -0700)]
Merge pull request #276 from blkperl/fix_rake
Pin Rake to 10.1.1 in Gemfile
William Van Hevelingen [Wed, 26 Mar 2014 17:51:29 +0000 (10:51 -0700)]
Pin Rake to 10.1.1 in Gemfile
The latest Rake update requires Ruby >= 1.9. This update
fixes the failing 1.8.7 tests by pinning Rake to the last
supported version on ruby 1.8.7.
Hunter Haugen [Wed, 26 Mar 2014 16:56:49 +0000 (09:56 -0700)]
Merge pull request #274 from fdrouet/fix_typo
Fix typo in ppa.pp
Frédéric DROUET [Thu, 20 Mar 2014 22:09:07 +0000 (23:09 +0100)]
Fix typo in ppa.pp
Hunter Haugen [Mon, 17 Mar 2014 17:03:22 +0000 (10:03 -0700)]
Merge pull request #268 from daenney/apt_key-ftp-weirdness
Use File.expand_path with require.
Daniele Sluijters [Sun, 16 Mar 2014 11:44:05 +0000 (12:44 +0100)]
Use File.expand_path with require.
For some reason, even though our own tests pass with `require
puppet_x/apt_key/patch_openuri` every other module that depends on
puppetlabs-apt is now breaking in tests claiming it can't load that
module.
Somewhere along the way something is probably messing with LOADPATH
causing this to trip up. This should fix the issues for everyone.
This commit affects:
* puppetlabs/puppetlabs-apt#229
* puppetlabs/puppetlabs-postgresql#391
Hunter Haugen [Thu, 13 Mar 2014 20:53:50 +0000 (13:53 -0700)]
Merge pull request #267 from apenney/fix-typo
Fix typo
Ashley Penney [Thu, 13 Mar 2014 20:03:09 +0000 (20:03 +0000)]
Fix typo.
Group was incorrectly spelt, but because the file was absent this
should have resulted in a noop in practice.
Hunter Haugen [Fri, 7 Mar 2014 18:00:58 +0000 (10:00 -0800)]
Merge pull request #248 from electrical/fix_params_fail
Fix fail message
Ashley Penney [Fri, 7 Mar 2014 17:35:55 +0000 (12:35 -0500)]
Merge pull request #263 from daenney/remove-puppet-27
Remove testing for Puppet 2.7 compatibility.
Daniele Sluijters [Fri, 7 Mar 2014 17:32:37 +0000 (18:32 +0100)]
Remove testing for Puppet 2.7 compatibility.
With official supported modules now being a thing and having a version
of the APT module to which we will backport fixes until the next major
release it is time to say goodbye to Puppet 2.7.
So long and thanks for all the fish.
Ashley Penney [Fri, 7 Mar 2014 17:24:20 +0000 (12:24 -0500)]
Merge pull request #262 from daenney/shrink-test-matrix
Remove ancient Puppet versions from matrix.
Daniele Sluijters [Fri, 7 Mar 2014 15:10:54 +0000 (16:10 +0100)]
Remove ancient Puppet versions from matrix.
With PE 3.2 out of the door shipping with 3.4.3 I think it's time to
shrink the matrix and get rid of 3.1 and 3.2. PE 3.x customers should
just upgrade to 3.2, OS users should really be on 3.3+ by now.
Richard Pijnenburg [Fri, 7 Mar 2014 15:03:44 +0000 (16:03 +0100)]
Fail early when its not debian or ubuntu ( or debian like distro )
Hunter Haugen [Thu, 6 Mar 2014 17:52:44 +0000 (09:52 -0800)]
Merge pull request #193 from ianunruh/feature/retry-update
Added retry to update operation
Ian Unruh [Wed, 5 Mar 2014 22:01:37 +0000 (16:01 -0600)]
Updated documentation
Ian Unruh [Wed, 5 Mar 2014 21:59:21 +0000 (15:59 -0600)]
Added retry to update operation
Hunter Haugen [Wed, 5 Mar 2014 19:15:26 +0000 (11:15 -0800)]
Merge pull request #209 from pabl0/proxy
Make apt.conf.d/proxy world readable and add a newline
Hunter Haugen [Wed, 5 Mar 2014 19:06:43 +0000 (11:06 -0800)]
Merge pull request #249 from ghoneycutt/define_apt_source_in_hiera
Add ability to specify hash of apt sources in hiera
Ashley Penney [Wed, 5 Mar 2014 18:17:12 +0000 (13:17 -0500)]
Merge pull request #258 from sodabrew/patch-1
Add Ubuntu Trusty
Ashley Penney [Wed, 5 Mar 2014 18:16:38 +0000 (13:16 -0500)]
Merge pull request #259 from daenney/apt-hold
apt::hold: Add a mechanism to hold a package.
Ashley Penney [Wed, 5 Mar 2014 18:16:24 +0000 (13:16 -0500)]
Merge pull request #260 from daenney/zomg-ze-chars
pin: Replace invalid chars with _ in file names.
Daniele Sluijters [Wed, 5 Mar 2014 15:12:04 +0000 (16:12 +0100)]
pin: Replace invalid chars with _ in file names.
This needs to be merged for #259 to work.
Ashley Penney [Wed, 5 Mar 2014 17:54:02 +0000 (12:54 -0500)]
Merge pull request #230 from daenney/apt-key-defined
Rework apt::key to use apt_key.
Ashley Penney [Wed, 5 Mar 2014 17:17:55 +0000 (12:17 -0500)]
Merge pull request #261 from hunner/remove_autorelease
Remove autorelease
Hunter Haugen [Wed, 5 Mar 2014 17:14:39 +0000 (09:14 -0800)]
Remove autorelease
Daniele Sluijters [Wed, 5 Mar 2014 14:02:06 +0000 (15:02 +0100)]
Update the README about apt_key and apt::key.
Daniele Sluijters [Wed, 5 Mar 2014 09:13:42 +0000 (10:13 +0100)]
apt::hold: Add a mechanism to hold a package.
I am aware this can be done with `dpkg --set-selections`, `apt-mark`
or `ensure => 'held'` on a package resource. The changes to the README
include the full rationale for wanting another mechanism.
Aaron Stone [Tue, 4 Mar 2014 20:51:32 +0000 (12:51 -0800)]
Oneiric is available on the old-releases mirror
Aaron Stone [Tue, 4 Mar 2014 20:50:37 +0000 (12:50 -0800)]
Remove hardy, maverick, natty
They are not on the mirrors anymore.
Aaron Stone [Tue, 4 Mar 2014 20:46:27 +0000 (12:46 -0800)]
Add Ubuntu Trusty
It's in Beta now and has landed on the main mirrors.
Daniele Sluijters [Thu, 20 Feb 2014 15:18:37 +0000 (16:18 +0100)]
apt::key: Redo apt::key, make it use apt_key.
Introducing a totally rewritten and tested apt::key. This commit also
patches the spec's of apt::source because it was passing in data that
is no longer allowed by the new validation rules in apt::key.
It does its best to not touch any other specs and where we touch them
only minimally to ensure that we're not introducing breaking changes.
Hunter Haugen [Mon, 3 Mar 2014 21:59:05 +0000 (13:59 -0800)]
Merge pull request #257 from apenney/last-minute-fix-metadata
Add back in missing fields to work around Puppet bug.
Ashley Penney [Mon, 3 Mar 2014 21:39:10 +0000 (21:39 +0000)]
Add back in missing fields to work around Puppet bug.
Hunter Haugen [Mon, 3 Mar 2014 19:55:45 +0000 (11:55 -0800)]
Merge pull request #256 from apenney/supported-142
Prepare supported module 1.4.2
Ashley Penney [Mon, 3 Mar 2014 19:08:54 +0000 (19:08 +0000)]
Prepare supported module 1.4.2
Hunter Haugen [Mon, 3 Mar 2014 18:26:45 +0000 (10:26 -0800)]
Merge pull request #253 from apenney/add-metadata
Prepare metadata for supported module release.
Ashley Penney [Fri, 28 Feb 2014 15:34:08 +0000 (15:34 +0000)]
Prepare metadata for supported module release.
Ashley Penney [Mon, 3 Mar 2014 16:51:13 +0000 (11:51 -0500)]
Merge pull request #255 from laurenrother/1.4.x
Add "Release Notes/Known Bugs" to Changelog
Lauren Rother [Sat, 1 Mar 2014 16:09:09 +0000 (08:09 -0800)]
Add "Release Notes/Known Bugs" to Changelogdds "Release Notes/Known Bugs" to Changelog, updates file format to markdown, standardizes the format of previous entries
Per a request to have initial release notes that specifically listed known issues for this PE 3.2 release, and barred by time constraints from automating a pull from open issues in JIRA, this commit adds a Release Note and Known Bug section to the Changelog for the imminent 3.2 release. As it will display on the Forge, updates file type to markdown and standardizes previous entries.
Richard Pijnenburg [Thu, 27 Feb 2014 09:23:11 +0000 (10:23 +0100)]
Add spec test to test for failure
Hunter Haugen [Wed, 26 Feb 2014 22:13:57 +0000 (14:13 -0800)]
Merge branch '1.4.x'
Daniel Tremblay [Wed, 4 Dec 2013 18:05:26 +0000 (18:05 +0000)]
Add ability to specify hash of apt sources in hiera
This patch uses create_resources() to call apt::source which lets you
specify your sources in hiera.
Richard Pijnenburg [Wed, 26 Feb 2014 10:52:54 +0000 (11:52 +0100)]
Fix fail message
the fail message was including a fact that was not used in the whole case statement and caused some confusion.
Hunter Haugen [Tue, 25 Feb 2014 19:34:43 +0000 (11:34 -0800)]
Merge branch 'fix_pin_quotes' into 1.4.x
Hunter Haugen [Tue, 25 Feb 2014 19:34:12 +0000 (11:34 -0800)]
Pin quotes were removed for a Lucid bugfix