]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/log
Morgan Haskel [Tue, 24 Feb 2015 21:20:29 +0000 (13:20 -0800)]
Convert specs to RSpec 3.1.7 syntax with Transpec
This conversion is done by Transpec 3.0.8 with the following command:
transpec spec/classes spec/defines spec/unit
* 87 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 14 conversions
from: obj.should
to: expect(obj).to
* 7 conversions
from: == expected
to: eq(expected)
* 1 conversion
from: it { should_not ... }
to: it { is_expected.not_to ... }
For more details: https://github.com/yujinakayama/transpec#supported-conversions
Daniele Sluijters [Mon, 23 Feb 2015 19:21:10 +0000 (20:21 +0100)]
Merge pull request #433 from mhaskel/ppa
PPA Cleanup, pt 1
Morgan Haskel [Fri, 20 Feb 2015 22:25:53 +0000 (14:25 -0800)]
PPA Cleanup, pt 1
Make the code much cleaner, but don't make a t&p.
Daniele Sluijters [Sat, 21 Feb 2015 23:30:36 +0000 (00:30 +0100)]
Merge pull request #432 from mhaskel/source_cleanup
Cleanup for `apt::source`
Morgan Haskel [Sat, 21 Feb 2015 20:11:57 +0000 (12:11 -0800)]
Convert apt::source to use apt::setting
May as well use the define since we added it
Morgan Haskel [Thu, 19 Feb 2015 23:35:47 +0000 (15:35 -0800)]
Cleanup for `apt::source`
* Update `release` to default to `$::lsbdistcodename`
* Default `include_src` to false
* Validate more things!
* Stop redefining variables from `apt::params`
Daniele Sluijters [Sat, 21 Feb 2015 23:22:59 +0000 (00:22 +0100)]
Merge pull request #435 from mhaskel/setting_fix
Type is a reserved word in puppet 4
Daniele Sluijters [Sat, 21 Feb 2015 23:22:25 +0000 (00:22 +0100)]
Merge pull request #431 from mhaskel/local_variable_declarations
Stop redeclaring variables from params
Morgan Haskel [Fri, 20 Feb 2015 19:15:23 +0000 (11:15 -0800)]
Stop redeclaring variables from params
It really seems unnecessary.
Morgan Haskel [Sat, 21 Feb 2015 19:50:00 +0000 (11:50 -0800)]
Type is a reserved word in puppet 4
So replace `type` with `setting_type` in apt::setting
Morgan Haskel [Sat, 21 Feb 2015 19:40:05 +0000 (11:40 -0800)]
Merge pull request #428 from puppetlabs/daenney/apt-setting
apt: Add apt::setting defined type.
Daniele Sluijters [Fri, 20 Feb 2015 12:00:17 +0000 (13:00 +0100)]
apt: Add apt::setting defined type.
This is a 'base' type. It's a simple wrapper around a file which takes
`type`, `ensure`, `content`, `source` and `file_perms`. It is intended
for usage by `apt::conf`, `apt::source` and an upcoming `apt::pref`.
Daniele Sluijters [Fri, 20 Feb 2015 21:06:50 +0000 (22:06 +0100)]
Merge pull request #430 from mhaskel/fix_typo
Fix typo from #426
Daniele Sluijters [Fri, 20 Feb 2015 21:06:29 +0000 (22:06 +0100)]
Merge pull request #429 from mhaskel/remove_include_update
Remove 'include apt::update'
Morgan Haskel [Fri, 20 Feb 2015 18:55:47 +0000 (10:55 -0800)]
Fix typo from #426
Too many `$`s
Morgan Haskel [Fri, 20 Feb 2015 18:47:35 +0000 (10:47 -0800)]
Remove 'include apt::update'
It is included in `class apt`, and there are no promises about anything
working without that.
Morgan Haskel [Fri, 20 Feb 2015 00:41:27 +0000 (16:41 -0800)]
Merge pull request #426 from puppetlabs/daenney/fix-missing-param-and-naming
apt::params: Add two missing entries, use them.
Daniele Sluijters [Fri, 20 Feb 2015 00:10:45 +0000 (01:10 +0100)]
Merge pull request #427 from mhaskel/required_packages
RFC - Remove required packages
Daniele Sluijters [Thu, 19 Feb 2015 23:09:44 +0000 (00:09 +0100)]
apt::params: Add two missing entries, use them.
Morgan Haskel [Thu, 19 Feb 2015 23:39:14 +0000 (15:39 -0800)]
Remove required packages
I'm not entirely clear on the history behind this feature, and this
feels sort of hack-y. If you could explain why this is needed that would
be awesome, or if it isn't just merge this :)
Daniele Sluijters [Thu, 19 Feb 2015 18:35:50 +0000 (19:35 +0100)]
Merge pull request #424 from mhaskel/hulk_smash
Hulk smash
Morgan Haskel [Thu, 19 Feb 2015 16:26:30 +0000 (08:26 -0800)]
Fix lint issue in examples
Morgan Haskel [Wed, 18 Feb 2015 21:42:43 +0000 (13:42 -0800)]
Fix acceptance tests
Morgan Haskel [Wed, 18 Feb 2015 19:43:50 +0000 (11:43 -0800)]
Fix broken unit tests
Morgan Haskel [Sun, 15 Feb 2015 19:17:12 +0000 (11:17 -0800)]
Placeholders for needed examples
Morgan Haskel [Sun, 15 Feb 2015 19:11:58 +0000 (11:11 -0800)]
Update examples
Morgan Haskel [Sun, 15 Feb 2015 18:59:00 +0000 (10:59 -0800)]
Get rid of hold
Morgan Haskel [Sun, 15 Feb 2015 18:54:33 +0000 (10:54 -0800)]
Get rid of release
Morgan Haskel [Sun, 15 Feb 2015 18:52:57 +0000 (10:52 -0800)]
Get rid of force
Morgan Haskel [Sun, 15 Feb 2015 18:45:25 +0000 (10:45 -0800)]
get rid of builddep
Morgan Haskel [Sun, 15 Feb 2015 18:41:54 +0000 (10:41 -0800)]
Merge pull request #1 from puppet-community/daenney/remove_unattended_upgrades_remains
Remove some vars for unattended_upgrades.
Daniele Sluijters [Sun, 15 Feb 2015 18:40:42 +0000 (19:40 +0100)]
Remove some vars for unattended_upgrades.
Morgan Haskel [Sun, 15 Feb 2015 18:25:36 +0000 (10:25 -0800)]
stop including params everywhere
Morgan Haskel [Sun, 15 Feb 2015 18:22:37 +0000 (10:22 -0800)]
Remove backports and debian
Morgan Haskel [Sun, 15 Feb 2015 17:48:10 +0000 (09:48 -0800)]
move tests to examples
Morgan Haskel [Sun, 15 Feb 2015 17:46:04 +0000 (09:46 -0800)]
Get rid of unattended upgrades and cleanup unused templates
Morgan Haskel [Sun, 15 Feb 2015 17:41:20 +0000 (09:41 -0800)]
and an acceptance test
Morgan Haskel [Sun, 15 Feb 2015 17:39:17 +0000 (09:39 -0800)]
Unbreak broken tests
Morgan Haskel [Sun, 15 Feb 2015 17:09:47 +0000 (09:09 -0800)]
Starting to clean up init.pp
Daniele Sluijters [Fri, 13 Feb 2015 08:23:53 +0000 (09:23 +0100)]
Merge pull request #422 from cmurphy/lint
Ensure linter fails on lint warnings
Daniele Sluijters [Fri, 13 Feb 2015 08:23:41 +0000 (09:23 +0100)]
Merge pull request #421 from cmurphy/future
Update spec tests for future parser
Colleen Murphy [Thu, 12 Feb 2015 00:43:14 +0000 (16:43 -0800)]
Ensure linter fails on lint warnings
Colleen Murphy [Thu, 12 Feb 2015 00:38:32 +0000 (16:38 -0800)]
Update spec tests for future parser
Strings must be quoted in the future parser.
Daniele Sluijters [Fri, 6 Feb 2015 21:10:41 +0000 (22:10 +0100)]
Merge pull request #389 from stdietrich/global_header_partial
(MODULES-1200) Fix inconsistent header across files
Stefan Dietrich [Sun, 31 Aug 2014 13:46:57 +0000 (15:46 +0200)]
(MODULES-1200) Fix inconsistent header across files
Daniele Sluijters [Wed, 4 Feb 2015 22:50:37 +0000 (23:50 +0100)]
Merge pull request #416 from mkrakowitzer/add_param_documentation
(doc) Add documentation for apt::key parameters and apt::pin parameters
Hunter Haugen [Wed, 4 Feb 2015 20:04:17 +0000 (12:04 -0800)]
Merge pull request #418 from cmurphy/rspec
Pin rspec gems
Colleen Murphy [Wed, 4 Feb 2015 16:02:03 +0000 (17:02 +0100)]
Pin rspec gems
Merritt Krakowitzer [Tue, 3 Feb 2015 16:59:54 +0000 (18:59 +0200)]
(doc) Add documentation for apt::key parameters and apt::pin parameters
Add documentation for apt::key parameters and apt::pin parameters.
Fix minor spelling error
Daniele Sluijters [Fri, 30 Jan 2015 13:22:18 +0000 (14:22 +0100)]
Merge pull request #414 from phaf/fix_doc_unattended_upgrades
Documentation: Fix typo and syntax for example of apt::unattended_upgrad...
Patric Hafner [Thu, 29 Jan 2015 13:48:47 +0000 (14:48 +0100)]
Documentation: Fix typo and syntax for example of apt::unattended_upgrades
Morgan Haskel [Wed, 28 Jan 2015 16:36:01 +0000 (08:36 -0800)]
Merge pull request #398 from irconan/backports-pin
Separate apt::pin for apt::backports to allow pin by release instead of ...
Richard Connon [Sun, 14 Dec 2014 21:54:17 +0000 (21:54 +0000)]
Separate apt::pin for apt::backports to allow pin by release instead of origin
Updated tests for backports
Morgan Haskel [Mon, 26 Jan 2015 22:26:13 +0000 (14:26 -0800)]
Merge pull request #395 from udienz/master
Add Ubuntu vivid (15.04) release
tphoney [Wed, 21 Jan 2015 19:14:33 +0000 (11:14 -0800)]
Merge pull request #411 from mhaskel/trusted_fix
Trusted will be a reserved word in Puppet 4
Morgan Haskel [Wed, 21 Jan 2015 18:54:37 +0000 (10:54 -0800)]
Trusted will be a reserved word in Puppet 4
Rename the new `trusted` parameter to `trusted_source`.
Daniele Sluijters [Tue, 20 Jan 2015 21:05:44 +0000 (16:05 -0500)]
Merge pull request #407 from mkrakowitzer/
f3792625 /trusted_param
Add support for parameter trusted MODULES-1658
Merritt Krakowitzer [Tue, 20 Jan 2015 19:27:52 +0000 (21:27 +0200)]
Merge branch 'master' of https://github.com/puppetlabs/puppetlabs-apt into
f3792625 /trusted_param
Daniele Sluijters [Tue, 20 Jan 2015 17:39:46 +0000 (12:39 -0500)]
Merge pull request #403 from WolverineFan/fix_apt_updates_facts
Fix apt_has_updates fact not parsing apt-check output correctly
WolverineFan [Thu, 8 Jan 2015 05:45:43 +0000 (00:45 -0500)]
Fix apt_has_updates fact not parsing apt-check output correctly
The /usr/lib/update-notifier/apt-check script returns its output
to STDERR but a recent change to the script redirects STDERR to
/dev/null. This will cause the array to always be empty.
Combined with that problem, while we were checking for the result
being nil, we never checked for an invalid array. As a result,
the apt_has_updates was always true and the apt_updates and
apt_security_updates facts were trying to read from an empty array
and failing.
Colleen Murphy [Wed, 14 Jan 2015 16:25:47 +0000 (08:25 -0800)]
Merge pull request #409 from cyberious/MOD1661
MODULES-1661 Fix to do delete with short key not long
Travis Fields [Wed, 14 Jan 2015 07:43:13 +0000 (23:43 -0800)]
MODULES-1661 Fix to do delete with short key not long
Colleen Murphy [Wed, 14 Jan 2015 01:41:49 +0000 (17:41 -0800)]
Merge pull request #408 from cyberious/MODULES-1661
MODULES-1661 Fix issue with apt_key destroy, also added mutliple deletes
Travis Fields [Tue, 13 Jan 2015 23:54:10 +0000 (15:54 -0800)]
MODULES-1661 Fix issue with apt_key destroy, also added mutliple deletes
Merritt Krakowitzer [Tue, 13 Jan 2015 15:27:03 +0000 (17:27 +0200)]
Add support for parameter trusted
* Add support for paramater trusted, valid options are 'true' and false.
defaults to false. True sets the value to trusted=yes.
trusted=yes can be set to indicate that packages from this source are
always authenticated even if the Release file is not signed or the
signature can't be checked.
* Update documentation
Daniele Sluijters [Mon, 12 Jan 2015 19:32:52 +0000 (14:32 -0500)]
Merge pull request #404 from WolverineFan/support_40char_fingerprints
Allow full length GPG key fingerprints.
rfkrocktk [Thu, 4 Sep 2014 02:00:57 +0000 (19:00 -0700)]
Allow full length GPG key fingerprints.
Also add support for ECC and ECDSA key_types
Hunter Haugen [Fri, 9 Jan 2015 21:32:25 +0000 (13:32 -0800)]
Merge pull request #405 from petems/update_init_docs
Format documentation a little
Peter Souter [Fri, 9 Jan 2015 21:17:51 +0000 (13:17 -0800)]
Format documentation a little
Makes it a little easier to read and parse with scripts
Daniele Sluijters [Thu, 8 Jan 2015 08:14:55 +0000 (09:14 +0100)]
Merge pull request #400 from voidus/master
Allow ports that consist of 5 decimals
Simon Kohlmeyer [Fri, 26 Dec 2014 04:10:52 +0000 (05:10 +0100)]
Allow ports that consist of 5 decimals
Morgan Haskel [Mon, 29 Dec 2014 19:23:47 +0000 (11:23 -0800)]
Merge pull request #401 from cmurphy/master
Add IntelliJ files to the ignore list
Colleen Murphy [Mon, 29 Dec 2014 18:40:53 +0000 (10:40 -0800)]
Add IntelliJ files to the ignore list
Daniele Sluijters [Fri, 19 Dec 2014 19:48:40 +0000 (20:48 +0100)]
Merge pull request #394 from juniorsysadmin/apt-force-locale-fixes
(MODULES-1231) Fix apt::force locale issues
juniorsysadmin [Thu, 11 Dec 2014 02:41:01 +0000 (13:41 +1100)]
(MODULES-1231) Fix apt::force locale issues
The current $install_check variable greps for 'Installed' or
'Candidate', which means that it will give the wrong result
when a non-English locale is used. This patch ensures that the
check will work properly for non-English locales by setting the
environment parameters for the exec to LC_ALL=C LANG=C
Hunter Haugen [Fri, 12 Dec 2014 21:28:06 +0000 (13:28 -0800)]
Merge pull request #397 from mhaskel/puppet_not_shell
Use puppet() instead of shell() to install module dependencies
Morgan Haskel [Fri, 12 Dec 2014 20:53:18 +0000 (12:53 -0800)]
Use puppet() instead of shell() to install module dependencies
Mahyuddin Susanto [Thu, 11 Dec 2014 04:22:48 +0000 (11:22 +0700)]
Add Ubuntu vivid (15.04) release
Signed-off-by: Mahyuddin Susanto <udienz@gmail.com>
Morgan Haskel [Tue, 9 Dec 2014 16:20:50 +0000 (08:20 -0800)]
Merge pull request #391 from cmurphy/master
Update .travis.yml, Gemfile, Rakefile, and CONTRIBUTING.md
Colleen Murphy [Tue, 9 Dec 2014 06:52:06 +0000 (22:52 -0800)]
Add json gem
The puppet_facts gem implicitly depends on the json gem.
On Ruby 1.8.7, json is not built in. On Puppet 2.7, it is
not explicitly pulled in by the hiera gem. So we add it
here explicitly.
Colleen Murphy [Mon, 8 Dec 2014 18:23:17 +0000 (10:23 -0800)]
Update .travis.yml, Gemfile, Rakefile, and CONTRIBUTING.md
Morgan Haskel [Mon, 8 Dec 2014 18:20:05 +0000 (10:20 -0800)]
Merge pull request #390 from cmurphy/puppet_27
Define travis matrix in .sync.yml
Colleen Murphy [Sun, 7 Dec 2014 21:26:08 +0000 (13:26 -0800)]
Define travis matrix in .sync.yml
Since the other modules need to wait for a major release before
deprecating Puppet 2.7 support, this module's travis.yml is out of sync
and will need to stay that way for a while.
Morgan Haskel [Thu, 4 Dec 2014 22:42:42 +0000 (17:42 -0500)]
Merge pull request #385 from phervieux/utopic
Add utopic support
Travis Fields [Fri, 21 Nov 2014 20:05:48 +0000 (15:05 -0500)]
Merge pull request #387 from mhaskel/merge_1.6.x
Merge 1.6.x
Morgan Haskel [Fri, 21 Nov 2014 16:59:04 +0000 (11:59 -0500)]
Merge remote-tracking branch 'upstream/1.6.x' into merge_1.6.x
Conflicts:
lib/facter/apt_package_updates.rb
lib/facter/apt_security_updates.rb
lib/facter/apt_updates.rb
Morgan Haskel [Fri, 21 Nov 2014 16:52:45 +0000 (11:52 -0500)]
Merge pull request #384 from cyberious/HttpBasicAuthentication
MODULES-1119 Fixed to now have username and passwords passed in again
Daniele Sluijters [Fri, 21 Nov 2014 10:46:55 +0000 (11:46 +0100)]
Merge pull request #386 from jbondpdx/master
FM-1523: Added module summary to metadata.json
Travis Fields [Fri, 14 Nov 2014 04:25:46 +0000 (20:25 -0800)]
MODULES-1119 Fixed to now have username and passwords passed in again
jbondpdx [Thu, 20 Nov 2014 23:28:07 +0000 (15:28 -0800)]
FM-1523: Added module summary to metadata.json
Patrick Hervieux [Fri, 14 Nov 2014 13:48:09 +0000 (14:48 +0100)]
Add utopic support
Daniele Sluijters [Thu, 13 Nov 2014 18:23:07 +0000 (19:23 +0100)]
Merge pull request #376 from raoulbhatia/unattended-upgrades-oldstable
Unattended upgrades oldstable for wheezy
Colleen Murphy [Tue, 28 Oct 2014 19:37:57 +0000 (12:37 -0700)]
Merge pull request #380 from mhaskel/test
merge 1.7.x into master
Colleen Murphy [Tue, 28 Oct 2014 16:26:56 +0000 (09:26 -0700)]
Merge pull request #378 from mhaskel/1.7.0-prep
1.7.0 prep
Morgan Haskel [Mon, 27 Oct 2014 19:29:47 +0000 (15:29 -0400)]
1.7.0 prep
Colleen Murphy [Mon, 27 Oct 2014 15:54:24 +0000 (08:54 -0700)]
Merge pull request #377 from mhaskel/1.7.x-merge
Merge master back into 1.7.x
Morgan Haskel [Mon, 27 Oct 2014 14:10:52 +0000 (10:10 -0400)]
Fix tests to reflect behavior fixed on 1.7.x
The facts don't really work with 2>&1 in the case of an error, so you
want 2>/dev/null instead.
Morgan Haskel [Mon, 27 Oct 2014 13:57:46 +0000 (09:57 -0400)]
Merge remote-tracking branch 'upstream/master' into 1.7.x-merge
Conflicts:
lib/facter/apt_package_updates.rb
lib/facter/apt_security_updates.rb
lib/facter/apt_updates.rb
Travis Fields [Wed, 10 Sep 2014 17:37:07 +0000 (10:37 -0700)]
Fix issue with puppet_module_install, removed and using updated method from beaker core copy_module_to
Hunter Haugen [Fri, 15 Aug 2014 23:22:46 +0000 (16:22 -0700)]
Remove stderr from stdout
Sometimes there are lib errors on platforms with malformed packages.
This shouldn't cause the facts to completely fail.