paladox [Tue, 15 May 2018 18:56:21 +0000 (19:56 +0100)]
Remove .length from variable $pin_release in app
This causes
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Unknown function: 'length'. at /etc/puppet/environments/production/modules/apt/templates/pin.pref.epp:4:16 at /etc/puppet/environments/production/modules/apt/manifests/source.pp:92 on node xxx
Andreas Ntaflos [Mon, 30 Apr 2018 16:05:30 +0000 (18:05 +0200)]
Support managing login configurations in /etc/apt/auth.conf
APT 1.5 formally introduced support for specifying login configuration
settings (like username and password) for APT sources or proxies that
require authentication in the file `/etc/apt/auth.conf`. This file
follows a netrc-like format (like ftp or curl) and has restrictive
permissions. This is preferable to embedding login information directly
in sources.list entries (which are usually world-readable). See
https://manpages.debian.org/testing/apt/apt_auth.conf.5.en.html for
details.
This change adds a new, optional class parameter
`apt::auth_conf_entries` which expects an array of hashes (defined by a
new abstract data type `Apt::Auth_conf_entry`) that represent sets of
login configuration settings to record in `/etc/apt/auth.conf`. The
file's contents are rendered using a simple EPP template.
Bernhard Schmidt [Thu, 22 Mar 2018 14:05:05 +0000 (15:05 +0100)]
Replace UTF-8 whitespace in comment
There is an UTF-8 whitespace which blows up older puppet-lint versions. Replace with space character
./modules/apt/manifests/source.pp
/usr/lib/ruby/vendor_ruby/puppet-lint/checks.rb:23:in `split': invalid byte sequence in US-ASCII (ArgumentError)
from /usr/lib/ruby/vendor_ruby/puppet-lint/checks.rb:23:in `load_data'
from /usr/lib/ruby/vendor_ruby/puppet-lint/checks.rb:53:in `run'
from /usr/lib/ruby/vendor_ruby/puppet-lint.rb:174:in `run'
from /usr/lib/ruby/vendor_ruby/puppet-lint/bin.rb:59:in `block in run'
from /usr/lib/ruby/vendor_ruby/puppet-lint/bin.rb:56:in `each'
from /usr/lib/ruby/vendor_ruby/puppet-lint/bin.rb:56:in `run'
from /usr/bin/puppet-lint:7:in `<main>'
Detected error
Romain Tartière [Fri, 26 Jan 2018 15:18:47 +0000 (16:18 +0100)]
Do not rely on deprecated argument signature
This commit fixes the following warning in the puppet master's logs:
Jan 26 16:09:26 <daemon.warn> marvin puppet-master[68168]: The argument signature (String format, [String timezone]) is deprecated for #strfime. See #strftime documentation and Timespan type for more info
Jan 26 16:09:26 <daemon.warn> marvin puppet-master[68168]: (at /usr/local/etc/puppet/environments/production/modules/apt/manifests/update.pp:17)
Romain Tartière [Fri, 26 Jan 2018 13:32:30 +0000 (14:32 +0100)]
Fix automatic coercion warning
Explicitly cast the return value of strftime() to an Integer to avoid
spamming the puppet server log file with warning messages:
Jan 26 14:19:13 <daemon.warn> marvin puppet-master[27147]: The string '1516972753' was automatically coerced to the numerical value 1516972753 at /usr/local/etc/puppet/environments/production/modules/apt/manifests/update.pp:17:27
Jan 26 14:19:25 <daemon.warn> marvin puppet-master[27147]: The string '1516972765' was automatically coerced to the numerical value 1516972765 at /usr/local/etc/puppet/environments/production/modules/apt/manifests/update.pp:17:27
Jan 26 14:19:55 <daemon.warn> marvin puppet-master[27147]: The string '1516972795' was automatically coerced to the numerical value 1516972795 at /usr/local/etc/puppet/environments/production/modules/apt/manifests/update.pp:17:27
Jan 26 14:20:15 <daemon.warn> marvin puppet-master[27147]: The string '1516972815' was automatically coerced to the numerical value 1516972815 at /usr/local/etc/puppet/environments/production/modules/apt/manifests/update.pp:17:27
Will Meek [Thu, 9 Nov 2017 18:09:04 +0000 (18:09 +0000)]
Add a check for Puppet version to task helper
This commit will add a check for Puppet version being 5 or greater
around the task test helper. This ensures that is it not attempted
pre-task versions of puppet.
Michael Eklund [Fri, 8 Sep 2017 15:32:07 +0000 (10:32 -0500)]
https proxy bypass fix
* if http proxy is set without an https proxy apt will still attempt to
proxy those https sources, resulting in errors. This fix will allow
direct connect to the https urls, bypassing the http proxy. This is the
most simple fix for this problem, a more complex fix would be to have an
https_direct setting.
fix test for https proxy bypass
Kolbjørn Barmen [Fri, 3 Nov 2017 15:06:10 +0000 (16:06 +0100)]
Output from apt-get with actual security updates
The previous output just had debian-updates and backports, none
of which are security updates. Adjusted expected results accordingly,
using curl as an example.
Kolbjørn Barmen [Fri, 3 Nov 2017 10:14:35 +0000 (11:14 +0100)]
debian-updates is not security updates
Debian-updates are pending packages between dot-releases,
they are not security updates. When Debian has a dot-release,
for example 8.7, debian-updates is empty. Between 8.7 and 8.8,
updates packages go to debian-updates, and on 8.8, all packages
in debian-updates are moved (or replaced) by packages in the main
repo, leaving debian-updates empty again. Security updates are
managed outside of this.
Code Review / puppet-modules / puppetlabs-apt.git / log