]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/log
Hunter Haugen [Fri, 12 Dec 2014 21:28:06 +0000 (13:28 -0800)]
Merge pull request #397 from mhaskel/puppet_not_shell
Use puppet() instead of shell() to install module dependencies
Morgan Haskel [Fri, 12 Dec 2014 20:53:18 +0000 (12:53 -0800)]
Use puppet() instead of shell() to install module dependencies
Mahyuddin Susanto [Thu, 11 Dec 2014 04:22:48 +0000 (11:22 +0700)]
Add Ubuntu vivid (15.04) release
Signed-off-by: Mahyuddin Susanto <udienz@gmail.com>
Morgan Haskel [Tue, 9 Dec 2014 16:20:50 +0000 (08:20 -0800)]
Merge pull request #391 from cmurphy/master
Update .travis.yml, Gemfile, Rakefile, and CONTRIBUTING.md
Colleen Murphy [Tue, 9 Dec 2014 06:52:06 +0000 (22:52 -0800)]
Add json gem
The puppet_facts gem implicitly depends on the json gem.
On Ruby 1.8.7, json is not built in. On Puppet 2.7, it is
not explicitly pulled in by the hiera gem. So we add it
here explicitly.
Colleen Murphy [Mon, 8 Dec 2014 18:23:17 +0000 (10:23 -0800)]
Update .travis.yml, Gemfile, Rakefile, and CONTRIBUTING.md
Morgan Haskel [Mon, 8 Dec 2014 18:20:05 +0000 (10:20 -0800)]
Merge pull request #390 from cmurphy/puppet_27
Define travis matrix in .sync.yml
Colleen Murphy [Sun, 7 Dec 2014 21:26:08 +0000 (13:26 -0800)]
Define travis matrix in .sync.yml
Since the other modules need to wait for a major release before
deprecating Puppet 2.7 support, this module's travis.yml is out of sync
and will need to stay that way for a while.
Morgan Haskel [Thu, 4 Dec 2014 22:42:42 +0000 (17:42 -0500)]
Merge pull request #385 from phervieux/utopic
Add utopic support
Travis Fields [Fri, 21 Nov 2014 20:05:48 +0000 (15:05 -0500)]
Merge pull request #387 from mhaskel/merge_1.6.x
Merge 1.6.x
Morgan Haskel [Fri, 21 Nov 2014 16:59:04 +0000 (11:59 -0500)]
Merge remote-tracking branch 'upstream/1.6.x' into merge_1.6.x
Conflicts:
lib/facter/apt_package_updates.rb
lib/facter/apt_security_updates.rb
lib/facter/apt_updates.rb
Morgan Haskel [Fri, 21 Nov 2014 16:52:45 +0000 (11:52 -0500)]
Merge pull request #384 from cyberious/HttpBasicAuthentication
MODULES-1119 Fixed to now have username and passwords passed in again
Daniele Sluijters [Fri, 21 Nov 2014 10:46:55 +0000 (11:46 +0100)]
Merge pull request #386 from jbondpdx/master
FM-1523: Added module summary to metadata.json
Travis Fields [Fri, 14 Nov 2014 04:25:46 +0000 (20:25 -0800)]
MODULES-1119 Fixed to now have username and passwords passed in again
jbondpdx [Thu, 20 Nov 2014 23:28:07 +0000 (15:28 -0800)]
FM-1523: Added module summary to metadata.json
Patrick Hervieux [Fri, 14 Nov 2014 13:48:09 +0000 (14:48 +0100)]
Add utopic support
Daniele Sluijters [Thu, 13 Nov 2014 18:23:07 +0000 (19:23 +0100)]
Merge pull request #376 from raoulbhatia/unattended-upgrades-oldstable
Unattended upgrades oldstable for wheezy
Colleen Murphy [Tue, 28 Oct 2014 19:37:57 +0000 (12:37 -0700)]
Merge pull request #380 from mhaskel/test
merge 1.7.x into master
Colleen Murphy [Tue, 28 Oct 2014 16:26:56 +0000 (09:26 -0700)]
Merge pull request #378 from mhaskel/1.7.0-prep
1.7.0 prep
Morgan Haskel [Mon, 27 Oct 2014 19:29:47 +0000 (15:29 -0400)]
1.7.0 prep
Colleen Murphy [Mon, 27 Oct 2014 15:54:24 +0000 (08:54 -0700)]
Merge pull request #377 from mhaskel/1.7.x-merge
Merge master back into 1.7.x
Morgan Haskel [Mon, 27 Oct 2014 14:10:52 +0000 (10:10 -0400)]
Fix tests to reflect behavior fixed on 1.7.x
The facts don't really work with 2>&1 in the case of an error, so you
want 2>/dev/null instead.
Morgan Haskel [Mon, 27 Oct 2014 13:57:46 +0000 (09:57 -0400)]
Merge remote-tracking branch 'upstream/master' into 1.7.x-merge
Conflicts:
lib/facter/apt_package_updates.rb
lib/facter/apt_security_updates.rb
lib/facter/apt_updates.rb
Travis Fields [Wed, 10 Sep 2014 17:37:07 +0000 (10:37 -0700)]
Fix issue with puppet_module_install, removed and using updated method from beaker core copy_module_to
Hunter Haugen [Fri, 15 Aug 2014 23:22:46 +0000 (16:22 -0700)]
Remove stderr from stdout
Sometimes there are lib errors on platforms with malformed packages.
This shouldn't cause the facts to completely fail.
Raoul Bhatia [Fri, 24 Oct 2014 10:59:15 +0000 (12:59 +0200)]
Fix "WARNING: case statement without a default case on line ..."
Raoul Bhatia [Fri, 24 Oct 2014 10:37:46 +0000 (12:37 +0200)]
Fix "WARNING: indentation of => is not properly aligned on line 9"
Raoul Bhatia [Fri, 24 Oct 2014 10:29:48 +0000 (12:29 +0200)]
Add "oldstable" to the default update origins for wheezy
Add "oldstable" to the default update origins to ensure
the updates keep working after wheezy+1 gets released
See unattended-upgrades 0.79.5+wheezy1 and https://bugs.debian.org/711826
Daniele Sluijters [Thu, 16 Oct 2014 08:07:25 +0000 (10:07 +0200)]
Merge pull request #375 from raphink/dev/facts_perfs
Refactor facts to improve performance.
Raphaël Pinson [Wed, 15 Oct 2014 13:44:50 +0000 (15:44 +0200)]
Refactor facts to improve performance:
* Add an apt_has_updates boolean fact
* Make other facts depend on it
Daniele Sluijters [Tue, 14 Oct 2014 11:42:59 +0000 (13:42 +0200)]
README: the facts depend on update-notifier
Daniele Sluijters [Tue, 14 Oct 2014 07:12:18 +0000 (09:12 +0200)]
Merge pull request #374 from bschlief/random_sleep
Add support for RandomSleep to 10periodic
Bryan M. Schlief [Mon, 13 Oct 2014 18:44:56 +0000 (11:44 -0700)]
Add support for RandomSleep to 10periodic
Daniele Sluijters [Thu, 9 Oct 2014 00:24:49 +0000 (17:24 -0700)]
Merge pull request #372 from jbondpdx/revised-readme
DOC-249: Revised and updated apt readme
Hunter Haugen [Wed, 8 Oct 2014 22:19:32 +0000 (15:19 -0700)]
Merge pull request #373 from mhaskel/metadata
Update pe compatibility
Morgan Haskel [Wed, 8 Oct 2014 22:18:39 +0000 (18:18 -0400)]
Update pe compatibility
jbondpdx [Wed, 8 Oct 2014 18:09:54 +0000 (11:09 -0700)]
DOC-249 Revised and updated apt readme
Revised and updated apt readme. Post-merge-conflict edition.
Colleen Murphy [Tue, 7 Oct 2014 16:37:06 +0000 (09:37 -0700)]
Merge pull request #371 from mhaskel/force-yes
add --force-yes so deb7 doesn't hang
Morgan Haskel [Mon, 6 Oct 2014 23:44:19 +0000 (19:44 -0400)]
add --force-yes so deb7 doesn't hang
Colleen Murphy [Mon, 6 Oct 2014 20:53:17 +0000 (13:53 -0700)]
Merge pull request #369 from mhaskel/future_parser
Missed one case for _kick_apt needed for strict variables
Morgan Haskel [Mon, 6 Oct 2014 20:41:14 +0000 (16:41 -0400)]
Missed one case for _kick_apt needed for strict variables
Hunter Haugen [Fri, 3 Oct 2014 23:36:21 +0000 (16:36 -0700)]
Merge pull request #368 from mhaskel/future_parser
Fix for future parser support
Morgan Haskel [Fri, 3 Oct 2014 23:30:33 +0000 (19:30 -0400)]
Fix for future parser support
Hunter Haugen [Thu, 2 Oct 2014 22:37:17 +0000 (15:37 -0700)]
Merge pull request #367 from mhaskel/deb6_apt-key_workaround
apt-key doesn't add long keys in deb6
Morgan Haskel [Thu, 2 Oct 2014 22:21:46 +0000 (17:21 -0500)]
apt-key doesn't add long keys in deb6
You can feed the command the long key, but it truncates it to add the
key. This causes issues due to the short-key collision with the
puppetlabs key. So, test with a different key on debian 6.
Hunter Haugen [Wed, 1 Oct 2014 18:55:20 +0000 (11:55 -0700)]
Merge pull request #366 from mhaskel/fix_unit_tests
We aren't truncating in the type
Morgan Haskel [Wed, 1 Oct 2014 18:46:14 +0000 (13:46 -0500)]
We aren't truncating in the type
So don't check for truncated IDs in the type test.
Hunter Haugen [Wed, 1 Oct 2014 18:43:09 +0000 (11:43 -0700)]
Merge pull request #365 from mhaskel/long_key_support
Don't truncate to short keys in the type
Morgan Haskel [Wed, 1 Oct 2014 17:55:41 +0000 (12:55 -0500)]
Don't truncate to short keys in the type
You should be able to create/delete keys using the long key to avoid
collisions, and truncating in the type makes that not work.
Morgan Haskel [Fri, 26 Sep 2014 19:01:16 +0000 (15:01 -0400)]
Merge pull request #349 from wolfspyre/apt_update_tooling
Apt update tooling
Wolf Noble [Mon, 18 Aug 2014 20:12:55 +0000 (15:12 -0500)]
- add bits for updating apt
- fix spec tests to include osfamily fact
- add spec tests to verify current default behavior unimpacted.
- manage the update-stamp file in puppet via content rather than a served file.
- update custom fact to return -1 if the file doesn't exist
- add spec test for custom fact
- refactor to use a variable vs a collector/override
- document parameters a bit more verbosely
- remove empty unconstrained fact
- Add osfamily fact to backports tests to facilitate functional tests on non-debian hosts
Daniele Sluijters [Wed, 24 Sep 2014 22:27:06 +0000 (15:27 -0700)]
Fix a test that broke with #326.
Daniele Sluijters [Wed, 24 Sep 2014 22:01:17 +0000 (15:01 -0700)]
Merge pull request #326 from dabido/master
Builddep notifies apt-get update instead of requiring it
Morgan Haskel [Wed, 24 Sep 2014 21:58:13 +0000 (14:58 -0700)]
Merge pull request #363 from martinseener/ticket/1306-apt_force_fails_if_new_package_asks_how_to_handle_changed_config_files
apt::force: Added 2 parameters for automatic configuration file handling...
Martin Seener [Fri, 5 Sep 2014 08:14:08 +0000 (10:14 +0200)]
apt::force: Added 2 parameters for automatic configuration file handling; fixes #modules-1306
when updating or installing newer packages with apt::force and you have changed previous
configuration files aptitude or apt-get will prompt what to do. You can suppress that
by pre-define the action with cfg_files parameter (new, old or unchanged and its backward
compatible if not defined). With a second optional parameter cfg_missing you can force
your provider to install missing configuration files as well.
Signed-off-by: Martin Seener <martin@seener.de>
apt::force: Changed selectors used in force.pp to case statements; refs #module-1306
Signed-off-by: Martin Seener <martin@seener.de>
apt::force: rspec: fixed the failing tests and added validate_re for cfg_files and validate_bool for cfg_missing. Also removed default values for both case statements and only allow pre-defined values or true/false. Furthermore enhanced the README refs #module-1306
Was able to fix the failing rspec tests for the patch.
Thanks to Morgan Haskel.
Signed-off-by: Martin Seener <martin@seener.de>
Despite the puppetlabs-stdlib documentation says validation_re supports 3 arguments the tests failed telling that only 2 are supported. Fixed this by removing the 3 optional argument; refs #modules-1306
Signed-off-by: Martin Seener <martin.seener@barzahlen.de>
apt::force: updated readme refs #module-1306
Signed-off-by: Martin Seener <martin@seener.de>
Travis Fields [Wed, 17 Sep 2014 16:06:38 +0000 (09:06 -0700)]
Merge pull request #362 from jbondpdx/apt-readme
MODULES-1259: added info on apt::update + edits to readme.md
jbondpdx [Tue, 16 Sep 2014 23:51:24 +0000 (16:51 -0700)]
MODULES-1259: added info on apt::update + edits to readme.md
Added apt::update information to the Readme file. Also general copy editing throughout for clarity and consistent style.
Morgan Haskel [Mon, 15 Sep 2014 21:27:27 +0000 (14:27 -0700)]
Merge pull request #360 from mhaskel/test
Merge 1.6.x into master
Morgan Haskel [Fri, 12 Sep 2014 21:24:49 +0000 (17:24 -0400)]
Merge branch '1.6.x' into test
Daniele Sluijters [Wed, 10 Sep 2014 20:25:17 +0000 (22:25 +0200)]
Merge pull request #359 from haus/ticket/master/doc_1230_update_example_keys
(DOC-1230) Update all short key examples to use the long key id
Matthaus Owens [Wed, 10 Sep 2014 20:21:07 +0000 (13:21 -0700)]
(DOC-1230) Update all short key examples to use the long key id
Morgan Haskel [Wed, 10 Sep 2014 17:44:23 +0000 (13:44 -0400)]
Merge pull request #358 from cyberious/1.6.x
Fix issue with puppet_module_install, removed and using updated method f...
Travis Fields [Wed, 10 Sep 2014 17:37:07 +0000 (10:37 -0700)]
Fix issue with puppet_module_install, removed and using updated method from beaker core copy_module_to
Daniele Sluijters [Mon, 8 Sep 2014 09:09:24 +0000 (11:09 +0200)]
Merge pull request #357 from cmurphy/unpin-puppetlint
Unpin puppet-lint
Colleen Murphy [Sun, 7 Sep 2014 18:12:28 +0000 (11:12 -0700)]
Unpin puppet-lint
The issues associated with the 1.0.0 release of puppet-lint have been
resolved.
Daniele Sluijters [Sun, 7 Sep 2014 09:56:32 +0000 (11:56 +0200)]
Merge pull request #350 from cmurphy/master
Remove Puppet 2.7 from travis matrix
Daniele Sluijters [Sun, 7 Sep 2014 09:56:08 +0000 (11:56 +0200)]
Merge pull request #353 from Smartesting/add-support-for-linuxmint-operatingsystem
add support for LinuxMint operating system
Daniele Sluijters [Fri, 5 Sep 2014 17:23:01 +0000 (19:23 +0200)]
Merge pull request #356 from digitalmediacenter/fix_puppet_lint_errors
Fix some Puppet Lint errors
Matthias Baur [Fri, 5 Sep 2014 16:51:39 +0000 (18:51 +0200)]
Fix some Puppet Lint errors
Christophe Bliard [Fri, 29 Aug 2014 14:57:09 +0000 (16:57 +0200)]
Prefer `if/else` over `?` selector with `default`
Christophe Bliard [Fri, 29 Aug 2014 14:23:21 +0000 (16:23 +0200)]
add support for LinuxMint operating system
Ashley Penney [Thu, 28 Aug 2014 21:39:56 +0000 (17:39 -0400)]
Merge pull request #352 from mhaskel/spec_helper_updates
Only call install_* methods once
Morgan Haskel [Thu, 28 Aug 2014 15:16:09 +0000 (11:16 -0400)]
Only call install_* methods once
Colleen Murphy [Tue, 19 Aug 2014 20:45:39 +0000 (13:45 -0700)]
Pin puppet-lint to 0.3.2
Colleen Murphy [Tue, 19 Aug 2014 17:50:58 +0000 (10:50 -0700)]
Add testing on Ruby 1.8.7 with Puppet 3 to travis.yml
Colleen Murphy [Tue, 19 Aug 2014 17:17:42 +0000 (10:17 -0700)]
Remove Puppet 2.7 from travis matrix
Morgan Haskel [Fri, 15 Aug 2014 23:24:34 +0000 (19:24 -0400)]
Merge pull request #348 from hunner/patch_fact
Remove stderr from stdout
Hunter Haugen [Fri, 15 Aug 2014 23:22:46 +0000 (16:22 -0700)]
Remove stderr from stdout
Sometimes there are lib errors on platforms with malformed packages.
This shouldn't cause the facts to completely fail.
Ashley Penney [Tue, 12 Aug 2014 20:14:31 +0000 (16:14 -0400)]
Merge pull request #347 from mhaskel/hiera_fix
Don't hardcode /etc/puppet as the puppetpath.
Morgan Haskel [Tue, 12 Aug 2014 20:10:36 +0000 (16:10 -0400)]
Don't hardcode /etc/puppet as the puppetpath.
Hunter Haugen [Tue, 12 Aug 2014 18:17:57 +0000 (11:17 -0700)]
Merge pull request #346 from mhaskel/1.6_test_fixes
Clean up test failures
Morgan Haskel [Tue, 12 Aug 2014 17:39:22 +0000 (13:39 -0400)]
Clean up test failures
Ashley Penney [Tue, 12 Aug 2014 16:48:44 +0000 (12:48 -0400)]
Merge pull request #345 from mhaskel/merge_1.5.x_changes
Merge 1.5.x changes
Morgan Haskel [Tue, 12 Aug 2014 16:12:21 +0000 (12:12 -0400)]
Missed test refactoring in CHANGELOG
Morgan Haskel [Thu, 31 Jul 2014 22:11:57 +0000 (18:11 -0400)]
Cleaned up unit tests.
Morgan Haskel [Wed, 30 Jul 2014 23:54:28 +0000 (19:54 -0400)]
Cleaned up acceptance tests
A lot of the tests were testing things that really should be tested via
unit tests, so those were deleted and unit tests will be revamped to
make sure they are covering everything they need to be covering.
Conflicts:
spec/acceptance/unattended_upgrade_spec.rb
Morgan Haskel [Mon, 11 Aug 2014 19:56:32 +0000 (15:56 -0400)]
Sometimes killing apt is too aggressive.
Morgan Haskel [Fri, 8 Aug 2014 13:42:35 +0000 (09:42 -0400)]
1.5.3 prep
Colleen Murphy [Fri, 27 Jun 2014 16:27:52 +0000 (09:27 -0700)]
Update .sync.yml to support new .travis.yml configs
Colleen Murphy [Wed, 25 Jun 2014 23:33:47 +0000 (16:33 -0700)]
Add configuration file for modulesync
https://github.com/puppetlabs/modulesync
Morgan Haskel [Thu, 7 Aug 2014 18:52:17 +0000 (14:52 -0400)]
Merge branch '1.6.x' of github.com:puppetlabs/puppetlabs-apt into 1.6.x
Morgan Haskel [Fri, 25 Jul 2014 22:20:06 +0000 (18:20 -0400)]
Prep for 1.6.0 release.
Ashley Penney [Wed, 6 Aug 2014 16:25:14 +0000 (12:25 -0400)]
Merge pull request #339 from mhaskel/test_overhaul
Test overhaul
Morgan Haskel [Thu, 31 Jul 2014 22:11:57 +0000 (18:11 -0400)]
Cleaned up unit tests.
Morgan Haskel [Wed, 30 Jul 2014 23:54:28 +0000 (19:54 -0400)]
Cleaned up acceptance tests
A lot of the tests were testing things that really should be tested via
unit tests, so those were deleted and unit tests will be revamped to
make sure they are covering everything they need to be covering.
Morgan Haskel [Thu, 31 Jul 2014 16:58:20 +0000 (12:58 -0400)]
Merge pull request #333 from wilman0/master
Fix for debian/ubuntu hold and a way to add debian src only
wilman0 [Fri, 18 Jul 2014 08:51:32 +0000 (10:51 +0200)]
Update hold.pp
fix for default debian installations
all files in /etc/apt/preferences without _ will be silently ignore according to debian manpage. Addionally its not a good idea to write versionnumber in filename cause there is no way to delete this files if you increase versionumber
Update source_spec.rb
add a way to include debsrc only (useful for debian/ubuntu build server ... jenkins ect)
Update source_spec.rb
var rename
Update source.list.erb
add include_deb "switch"
Update source.pp
"include_deb" defaultvalue = true
Update hold_spec.rb
change the name of the preferences file (hold)
Update source_spec.rb
Update README.md
Doku: 'include_deb' included next to 'include_src' in examples
Update README.md
typo
Ashley Penney [Wed, 30 Jul 2014 19:09:40 +0000 (15:09 -0400)]
Merge pull request #336 from mhaskel/fix_acceptance_tests
Debian seems to have hanging apt-get and/or dpkg processes, so kill
Morgan Haskel [Wed, 30 Jul 2014 18:44:51 +0000 (14:44 -0400)]
Merge pull request #330 from dantman/master
Fix inconsistent $proxy_host handling in apt and apt::ppa.
Morgan Haskel [Wed, 30 Jul 2014 18:40:20 +0000 (14:40 -0400)]
Debian seems to have hanging apt-get and/or dpkg processes, so kill
those.