]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/log
puppet-modules/puppetlabs-firewall.git
13 years ago(#9576) Stub iptables type so it will execute on platforms other then linux.
Ken Barber [Sat, 17 Sep 2011 22:46:35 +0000 (23:46 +0100)]
(#9576) Stub iptables type so it will execute on platforms other then linux.

This change will help us target other platforms for this type. I've also
removed old helpers to align with Puppet core spec_helper. While this might
seem more invconvenient it provides more consistency with core Puppet type
testing.

13 years ago(#9576) Align spec framework with Puppet core.
Ken Barber [Sat, 17 Sep 2011 22:40:53 +0000 (23:40 +0100)]
(#9576) Align spec framework with Puppet core.

The point of this change is to align the spec testing behaviour with Puppet core
so we can get similar behaviour and less problems if we ever want to move this
type into core.

13 years agoMerge pull request #9 from bookest/patch-1
Jonathan Boyett [Mon, 29 Aug 2011 19:02:46 +0000 (12:02 -0700)]
Merge pull request #9 from bookest/patch-1

use iptables-save in the persistent rules example

13 years agouse iptables-save in the persistent rules example
Christopher Grim [Sat, 27 Aug 2011 01:52:44 +0000 (22:52 -0300)]
use iptables-save in the persistent rules example

13 years agofix provider source parameter
Jonathan Boyett [Tue, 16 Aug 2011 17:54:35 +0000 (10:54 -0700)]
fix provider source parameter

13 years agocreate ip6tables test manifest
Jonathan Boyett [Tue, 16 Aug 2011 17:06:22 +0000 (10:06 -0700)]
create ip6tables test manifest

13 years agocreate ip6tables provider
Jonathan Boyett [Tue, 16 Aug 2011 17:05:58 +0000 (10:05 -0700)]
create ip6tables provider

13 years agoadd newvalue ipv6-icmp to proto
Jonathan Boyett [Tue, 16 Aug 2011 17:05:20 +0000 (10:05 -0700)]
add newvalue ipv6-icmp to proto

13 years agoimproving rule slicing and dicing
Jonathan Boyett [Tue, 16 Aug 2011 17:04:27 +0000 (10:04 -0700)]
improving rule slicing and dicing

13 years agoconvert class variables to instance variables so we can have unique attributes for...
Jonathan Boyett [Mon, 15 Aug 2011 22:49:54 +0000 (15:49 -0700)]
convert class variables to instance variables so we can have unique attributes for each type

13 years agosmall refactor of value munging of existing rules
Jonathan Boyett [Mon, 15 Aug 2011 18:18:14 +0000 (11:18 -0700)]
small refactor of value munging of existing rules

13 years agoMerge branch 'master' of github.com:puppetlabs/puppetlabs-firewall
Jonathan Boyett [Mon, 15 Aug 2011 18:16:14 +0000 (11:16 -0700)]
Merge branch 'master' of github.com:puppetlabs/puppetlabs-firewall

13 years agoallow only a single source or destination value per resource. fixes #2
Jonathan Boyett [Mon, 15 Aug 2011 18:13:20 +0000 (11:13 -0700)]
allow only a single source or destination value per resource. fixes #2

13 years agoallow only a single source or destination value per resource. fixes #4
Jonathan Boyett [Mon, 15 Aug 2011 18:13:20 +0000 (11:13 -0700)]
allow only a single source or destination value per resource. fixes #4

13 years agofix state array in readme.pp rule
Jonathan Boyett [Mon, 15 Aug 2011 17:13:25 +0000 (10:13 -0700)]
fix state array in readme.pp rule

13 years agofix --libdir in iptables example run script
Jonathan Boyett [Mon, 15 Aug 2011 16:42:21 +0000 (09:42 -0700)]
fix --libdir in iptables example run script

13 years agoFix iptables option ordering issues (thanks to Adrian Bridgett)
Ken Barber [Mon, 8 Aug 2011 12:07:58 +0000 (14:07 +0200)]
Fix iptables option ordering issues (thanks to Adrian Bridgett)

13 years agoRemoved a bug I introduced from the last commit. 'desc' is not valid in ensure values.
Ken Barber [Sun, 17 Jul 2011 02:51:50 +0000 (04:51 +0200)]
Removed a bug I introduced from the last commit. 'desc' is not valid in ensure values.

13 years ago(#6) - added action property to type for future provider support.
Ken Barber [Sat, 16 Jul 2011 19:45:00 +0000 (21:45 +0200)]
(#6) - added action property to type for future provider support.

13 years agoApplied docs to explain putting rejects in post stage (#4). Plus some re-organisation...
Ken Barber [Sat, 16 Jul 2011 19:33:40 +0000 (21:33 +0200)]
Applied docs to explain putting rejects in post stage (#4). Plus some re-organisation of documentation to bundle property types together.

13 years agoRemoved iptables stuff, introduced features and cleaned up docs & validation.
Ken Barber [Sat, 16 Jul 2011 19:19:49 +0000 (21:19 +0200)]
Removed iptables stuff, introduced features and cleaned up docs & validation.

I've removed a lot of iptables specific stuff from the type, also
allowed any chain to be defined in :chain or :jump so we can support
user chains.

A lot of the documentation for the type has been cleaned up a little
and validation has been simplified where applicable.

This commit brings in the usage of features so we can start to introduce
more backend providers. The work is just a start for now and will
probably radically change once we have other working providers in
place.

13 years agoreplace String#lines with a String#split to ensure compatibility with Ruby 1.8.5
Jonathan Boyett [Mon, 11 Jul 2011 17:19:07 +0000 (10:19 -0700)]
replace String#lines with a String#split to ensure compatibility with Ruby 1.8.5

13 years agoensure the name parameter starts with a digit
Jonathan Boyett [Mon, 11 Jul 2011 17:18:20 +0000 (10:18 -0700)]
ensure the name parameter starts with a digit

13 years agoAdded quickstart not on how to make firewall rules persistent.
Ken Barber [Sun, 10 Jul 2011 22:42:25 +0000 (23:42 +0100)]
Added quickstart not on how to make firewall rules persistent.

13 years agouse setup methods in iptables_prov_spec
Jonathan Boyett [Tue, 28 Jun 2011 18:41:03 +0000 (11:41 -0700)]
use setup methods in iptables_prov_spec

13 years agouse setup_resource method in iptables_type_spec
Jonathan Boyett [Tue, 28 Jun 2011 18:40:43 +0000 (11:40 -0700)]
use setup_resource method in iptables_type_spec

13 years agocreate helper methods for provider, resource, and instance setup
Jonathan Boyett [Tue, 28 Jun 2011 18:39:51 +0000 (11:39 -0700)]
create helper methods for provider, resource, and instance setup

13 years agoAdd note about pluginsync for installation.
Ken Barber [Wed, 22 Jun 2011 19:16:53 +0000 (20:16 +0100)]
Add note about pluginsync for installation.

13 years agoadd masquerade sample to test manifest
Jonathan Boyett [Wed, 22 Jun 2011 17:23:52 +0000 (10:23 -0700)]
add masquerade sample to test manifest

13 years agofix outiface validation to check for postrouting chain
Jonathan Boyett [Wed, 22 Jun 2011 17:23:19 +0000 (10:23 -0700)]
fix outiface validation to check for postrouting chain

13 years agoSmall example for MASQUERADE.
Ken Barber [Mon, 20 Jun 2011 22:30:01 +0000 (23:30 +0100)]
Small example for MASQUERADE.

13 years agoFix 1 line in doc.
Ken Barber [Mon, 20 Jun 2011 22:26:49 +0000 (23:26 +0100)]
Fix 1 line in doc.

13 years agoSome initial parameter documentation for README.markdown.
Ken Barber [Mon, 20 Jun 2011 22:24:18 +0000 (23:24 +0100)]
Some initial parameter documentation for README.markdown.

13 years agoadd additional iptables provider unit tests
Jonathan Boyett [Mon, 20 Jun 2011 20:06:06 +0000 (13:06 -0700)]
add additional iptables provider unit tests

13 years agoadd instances test
Jonathan Boyett [Thu, 16 Jun 2011 22:54:07 +0000 (15:54 -0700)]
add instances test

13 years agoremove unnecessary require from type
Jonathan Boyett [Thu, 16 Jun 2011 21:50:13 +0000 (14:50 -0700)]
remove unnecessary require from type

13 years agolet icmp param accept integers in addition to strings
Jonathan Boyett [Thu, 16 Jun 2011 21:46:29 +0000 (14:46 -0700)]
let icmp param accept integers in addition to strings

13 years agoremove array length validation from dport and sport
Jonathan Boyett [Thu, 16 Jun 2011 18:59:13 +0000 (11:59 -0700)]
remove array length validation from dport and sport

13 years agomove rspec options to rakefile
Jonathan Boyett [Thu, 16 Jun 2011 18:33:14 +0000 (11:33 -0700)]
move rspec options to rakefile

13 years agoremove extra file
Jonathan Boyett [Thu, 16 Jun 2011 18:13:53 +0000 (11:13 -0700)]
remove extra file

13 years agoadd tests for remaining params
Jonathan Boyett [Thu, 16 Jun 2011 18:12:07 +0000 (11:12 -0700)]
add tests for remaining params

13 years agoadd tests for table, proto, jump, source, and destination params
Jonathan Boyett [Wed, 15 Jun 2011 22:08:33 +0000 (15:08 -0700)]
add tests for table, proto, jump, source, and destination params

13 years agoMerge branch 'master' of github.com:puppetlabs/puppetlabs-firewall
Jonathan Boyett [Wed, 15 Jun 2011 21:22:11 +0000 (14:22 -0700)]
Merge branch 'master' of github.com:puppetlabs/puppetlabs-firewall

13 years agoadd test for name, table, chain, dport, and sport parameters
Jonathan Boyett [Wed, 15 Jun 2011 21:18:58 +0000 (14:18 -0700)]
add test for name, table, chain, dport, and sport parameters

13 years agoAdded some notes about how to run tests.
Ken Barber [Wed, 15 Jun 2011 20:54:56 +0000 (22:54 +0200)]
Added some notes about how to run tests.

13 years agoadd rakefile
Jonathan Boyett [Wed, 15 Jun 2011 20:42:58 +0000 (13:42 -0700)]
add rakefile

13 years agoadd type tests
Jonathan Boyett [Wed, 15 Jun 2011 20:42:49 +0000 (13:42 -0700)]
add type tests

13 years agoadd provider tests
Jonathan Boyett [Wed, 15 Jun 2011 20:42:36 +0000 (13:42 -0700)]
add provider tests

13 years agoadd spec.opts
Jonathan Boyett [Wed, 15 Jun 2011 20:42:15 +0000 (13:42 -0700)]
add spec.opts

13 years agoadd spec_helper
Jonathan Boyett [Wed, 15 Jun 2011 20:42:01 +0000 (13:42 -0700)]
add spec_helper

13 years agoMore doc improvements.
Ken Barber [Wed, 15 Jun 2011 15:34:26 +0000 (17:34 +0200)]
More doc improvements.

13 years agoAdded some more examples and README cleanup.
Ken Barber [Wed, 15 Jun 2011 15:28:52 +0000 (17:28 +0200)]
Added some more examples and README cleanup.

13 years agoIgnore pkg/ so when we generate a forge module we don't also try to add that
Ken Barber [Wed, 15 Jun 2011 15:15:53 +0000 (17:15 +0200)]
Ignore pkg/ so when we generate a forge module we don't also try to add that
croft as well to our git repo.

13 years agoAdded LICENSE and Modulefile to complete scaffolding.
Ken Barber [Wed, 15 Jun 2011 15:15:35 +0000 (17:15 +0200)]
Added LICENSE and Modulefile to complete scaffolding.

13 years agoFirewall wasn't acknowledging new properties, only ones that were created at
Ken Barber [Wed, 15 Jun 2011 15:14:10 +0000 (17:14 +0200)]
Firewall wasn't acknowledging new properties, only ones that were created at
resource creation time. This patch fixes that by analyzing the resource_map
hash.

The proto property needs to be defaulted to 'all' when it doesn't exist as well
to stop the provider from trying to change it each time.

14 years agoremove rulenum param
Jonathan Boyett [Fri, 13 May 2011 20:40:37 +0000 (13:40 -0700)]
remove rulenum param

14 years agomunge is data to be of the same type as should
Jonathan Boyett [Fri, 13 May 2011 20:37:59 +0000 (13:37 -0700)]
munge is data to be of the same type as should

14 years agoallow arrays in dport, sport, destination, source, and state
Jonathan Boyett [Fri, 13 May 2011 20:37:30 +0000 (13:37 -0700)]
allow arrays in dport, sport, destination, source, and state

14 years agojoin arrays and use insert order to determine replacement position
Jonathan Boyett [Thu, 12 May 2011 02:07:27 +0000 (19:07 -0700)]
join arrays and use insert order to determine replacement position

14 years agouse array_matching for values which accept arrays
Jonathan Boyett [Thu, 12 May 2011 02:06:48 +0000 (19:06 -0700)]
use array_matching for values which accept arrays

14 years agofix typo
Jonathan Boyett [Wed, 11 May 2011 21:28:39 +0000 (14:28 -0700)]
fix typo

14 years agochange default forward drop to use the correct chain
Jonathan Boyett [Wed, 11 May 2011 18:45:47 +0000 (11:45 -0700)]
change default forward drop to use the correct chain

14 years agoadd missing commas to test manifest. whoops.
Jonathan Boyett [Wed, 11 May 2011 18:08:52 +0000 (11:08 -0700)]
add missing commas to test manifest. whoops.

14 years agoadd additional test rules to examples
Jonathan Boyett [Wed, 11 May 2011 18:07:29 +0000 (11:07 -0700)]
add additional test rules to examples

14 years agoconvert dports and sports to port numbers during munge
Jonathan Boyett [Wed, 11 May 2011 16:59:16 +0000 (09:59 -0700)]
convert dports and sports to port numbers during munge

14 years agooutiface requires the output chain
Jonathan Boyett [Wed, 11 May 2011 16:44:14 +0000 (09:44 -0700)]
outiface requires the output chain

14 years agoinclude Puppet::Util::Firewall to fix icmp values
Jonathan Boyett [Wed, 11 May 2011 16:37:11 +0000 (09:37 -0700)]
include Puppet::Util::Firewall to fix icmp values

14 years agocleanup flush and insert_order methods
Jonathan Boyett [Tue, 10 May 2011 22:30:46 +0000 (15:30 -0700)]
cleanup flush and insert_order methods

14 years agomk_resource_methods prevents method_missing from running. also add rulenum param
Jonathan Boyett [Tue, 10 May 2011 21:41:07 +0000 (14:41 -0700)]
mk_resource_methods prevents method_missing from running. also add rulenum param

14 years agoconvert resource[:chain] to string when checking equality and just add name to array
Jonathan Boyett [Tue, 10 May 2011 17:07:38 +0000 (10:07 -0700)]
convert resource[:chain] to string when checking equality and just add name to array

14 years agoadd examples
Jonathan Boyett [Mon, 9 May 2011 23:24:29 +0000 (16:24 -0700)]
add examples

14 years agoadd facter facts
Jonathan Boyett [Mon, 9 May 2011 23:24:18 +0000 (16:24 -0700)]
add facter facts

14 years agofix namespacing issues
Jonathan Boyett [Mon, 9 May 2011 23:23:50 +0000 (16:23 -0700)]
fix namespacing issues

14 years agoconvert unless values in validation to strings
Jonathan Boyett [Mon, 9 May 2011 23:23:26 +0000 (16:23 -0700)]
convert unless values in validation to strings

14 years agoadd iptables provider
Jonathan Boyett [Mon, 9 May 2011 23:22:32 +0000 (16:22 -0700)]
add iptables provider

14 years agofirewall type only needs to require firewall util
Jonathan Boyett [Mon, 9 May 2011 17:53:18 +0000 (10:53 -0700)]
firewall type only needs to require firewall util

14 years agoadd firewall util
Jonathan Boyett [Mon, 9 May 2011 17:52:48 +0000 (10:52 -0700)]
add firewall util

14 years agoadd ipcidr util
Jonathan Boyett [Mon, 9 May 2011 17:52:26 +0000 (10:52 -0700)]
add ipcidr util

14 years agoadd firewall type to module
Jonathan Boyett [Mon, 9 May 2011 17:31:14 +0000 (10:31 -0700)]
add firewall type to module

14 years agofix readme header
Jonathan Boyett [Mon, 9 May 2011 15:56:43 +0000 (08:56 -0700)]
fix readme header

14 years agoinitial commit
Jonathan Boyett [Mon, 9 May 2011 15:55:19 +0000 (08:55 -0700)]
initial commit