]> review.fuel-infra Code Review - openstack-build/cinder-build.git/log
openstack-build/cinder-build.git
10 years agoAdds barbican keymgr wrapper
Brianna Poulos [Wed, 2 Jul 2014 20:43:51 +0000 (16:43 -0400)]
Adds barbican keymgr wrapper

Adds a barbican keymgr wrapper to the key manager interface in
cinder.  This allows barbican to be configured as the key manager
for encryption keys in cinder.  The wrapper translates calls from
the existing key manager interface to python-barbicanclient.

There are two new configuration variables: encryption_auth_url
(the authentication URL for the encryption service) and
encryption_api_url (the api URL for the encryption service).

Change-Id: Ifd0d9b073d7f1c3c92d318c20a080b253008b50c
Implements: blueprint encryption-with-barbican
DocImpact

10 years agoMerge "Fix unit test test_import_record_with_verify"
Jenkins [Thu, 14 Aug 2014 20:21:10 +0000 (20:21 +0000)]
Merge "Fix unit test test_import_record_with_verify"

10 years agoMerge "Sync latest oslo-incubator log for debug fixes"
Jenkins [Thu, 14 Aug 2014 17:09:37 +0000 (17:09 +0000)]
Merge "Sync latest oslo-incubator log for debug fixes"

10 years agoMerge "Enable import group hacking rule"
Jenkins [Thu, 14 Aug 2014 07:59:47 +0000 (07:59 +0000)]
Merge "Enable import group hacking rule"

10 years agoMerge "VMware: Check snapshot and rename backing"
Jenkins [Thu, 14 Aug 2014 06:26:40 +0000 (06:26 +0000)]
Merge "VMware: Check snapshot and rename backing"

10 years agoEnable import group hacking rule
Zhiteng Huang [Fri, 27 Jun 2014 10:32:01 +0000 (18:32 +0800)]
Enable import group hacking rule

This change enables H305, H307 included in newly updated hacking 0.9
all violations are fixed.

H305, H307 will check if imports are grouped in stdlib, 3rd libs and
OpenStack components.

Change-Id: I612cae64982450a9be5207dbe26a2b52da49dac6

10 years agoMerge "Actually encode the SolidFire json dump result"
Jenkins [Thu, 14 Aug 2014 04:40:59 +0000 (04:40 +0000)]
Merge "Actually encode the SolidFire json dump result"

10 years agoMerge "Enable F402 checks and fix violations"
Jenkins [Thu, 14 Aug 2014 01:03:10 +0000 (01:03 +0000)]
Merge "Enable F402 checks and fix violations"

10 years agoActually encode the SolidFire json dump result
John Griffith [Wed, 13 Aug 2014 21:25:49 +0000 (15:25 -0600)]
Actually encode the SolidFire json dump result

The SolidFire driver intends to do a encode on the json data to utf-8,
unfortunatly it's not really doing anything because the syntax of the
calls is wrong.

This patch changes things to actually perform the encoding.

Change-Id: I2bc94ed1fdc1dd5f9a6371ae5f63a955f213bc15
Closes-Bug: #1355622

10 years agoSync latest oslo-incubator log for debug fixes
Jay S. Bryant [Wed, 13 Aug 2014 17:16:49 +0000 (12:16 -0500)]
Sync latest oslo-incubator log for debug fixes

This patch pulls in the changes in openstack/common/log.py that
fix the problems that popped up after we removed _() from
around LOG.debug messages.  The change in log ensures that any
text that is not of six.text_type is converted to six.text_type.

Current HEAD in OSLO:
---------------------
commit 759bd8791ec6a4b0e89f649a4179d177530e7536
Merge: 71d072f 631f880
Author: Jenkins <jenkins@review.openstack.org>
Date:   Wed Aug 13 13:37:27 2014 +0000

Merge "Set keystonemiddleware and routes.middleware to log on WARN level"
---------------------

Additional changes being merged (newest to oldest):
---------------------
759bd879 -
Merge "Set keystonemiddleware and routes.middleware to log on WARN level
71d072f1 -
Merge "Except socket.error if syslog isn't running"
37c00918 -
Add unicode coercion of logged messages to ContextFormatter
66144135 -
Correct coercion of logged message to unicode
1188d88a -
Except socket.error if syslog isn't running
ac995bec -
Fix E126 pep8 errors

Note that this change required an update to config.sample due to change
759bd879 -  Merge "Set keystonemiddleware and routes.middleware to log
on WARN level"

Change-Id: I4b849981c65300b327076d68fbf8601d46ec61f0
Closes-Bug: 1348244

10 years agoMerge "Make manage.py usable"
Jenkins [Wed, 13 Aug 2014 19:30:28 +0000 (19:30 +0000)]
Merge "Make manage.py usable"

10 years agoMerge "Fix bad indentation in netapp and san.hp volume drivers"
Jenkins [Wed, 13 Aug 2014 18:38:24 +0000 (18:38 +0000)]
Merge "Fix bad indentation in netapp and san.hp volume drivers"

10 years agoMerge "Add timer info for copy operations"
Jenkins [Wed, 13 Aug 2014 18:37:55 +0000 (18:37 +0000)]
Merge "Add timer info for copy operations"

10 years agoEnable F402 checks and fix violations
Zhiteng Huang [Wed, 30 Jul 2014 04:44:05 +0000 (12:44 +0800)]
Enable F402 checks and fix violations

This change enables F402 hacking check and fixes all violations found.

[F402] import module from line N shadowed by loop variable

Basically this rule tries to avoid loop variables using the same name as
imported module, for example:

    from cinder import volume
    ...

    for volume in volumes:
        ...

Change-Id: Ie3010616ca87fda113d452fe684e6cff3d5fd978

10 years agoVMware: Check snapshot and rename backing
Vipin Balachandran [Fri, 8 Aug 2014 05:23:02 +0000 (10:53 +0530)]
VMware: Check snapshot and rename backing

This patch adds methods for: a) checking existence of backing VM snapshots;
and b) rename backing.

Change-Id: Iede168e28d9569a5a3331479c8096c3cca5140e9
Partial-Bug: #1275682
Implements: blueprint vmdk-backup

10 years agoFix bad indentation in netapp and san.hp volume drivers
Danny Al-Gaaf [Wed, 13 Aug 2014 07:49:06 +0000 (09:49 +0200)]
Fix bad indentation in netapp and san.hp volume drivers

Closes-Bug: #1356223

Change-Id: I4e9fb3c6b3e098998f41e266b2cfc51a4af1fc65
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
10 years agoIssue one SQL statement per execute() call
Angus Lees [Wed, 13 Aug 2014 01:59:18 +0000 (11:59 +1000)]
Issue one SQL statement per execute() call

Some sqlalchemy drivers don't support multiple SQL statements in a
single execute() call.  The sqlalchemy author has confirmed that one
statement per execute() is the intended API.

Change-Id: I527780765371dcc9645a721d60ed9ac67ddde29f

10 years agoMerge "Add ProphetStor DPL Storage server volume driver for Cinder"
Jenkins [Tue, 12 Aug 2014 19:15:29 +0000 (19:15 +0000)]
Merge "Add ProphetStor DPL Storage server volume driver for Cinder"

10 years agoAdd ProphetStor DPL Storage server volume driver for Cinder
Rick Chen [Mon, 11 Aug 2014 02:55:28 +0000 (10:55 +0800)]
Add ProphetStor DPL Storage server volume driver for Cinder

ProphetStor DPL Storage server enables x86 commodity hardware as
enterprise-grade storage systems.
*[2014/07/14] Remove roll-back function.
*[2014/07/16] Add decorate fiber zone manage utils in initialize_connection and
              terminate_connection.
              Use mock instead of mox in tests.
*[2014/07/21] Update cinder volume certification report.
*[2014/07/29] Openstack continuous integration platform test.
              Retry: 27
*[2014/07/31] Rebase
*[2014/08/06] Refine code
*[2014/08/11] Rebase and enhance to support thin/thick volume
Implements: blueprint prophetstor-dpl-driver
cinder-cert-results: https://bugs.launchpad.net/cinder/+bug/1354066
Change-Id: Iced5e45362aef4286bb7f1c848ab7cb3573b5c02

10 years agoAdd timer info for copy operations
John Griffith [Thu, 7 Aug 2014 04:17:44 +0000 (22:17 -0600)]
Add timer info for copy operations

This is just an add of some useful info to monitor
how much time we spend on various operations during
clear volume and copy image_to_volume.

Change-Id: Ie9d199769e63f5a91270e3fc2e5f58766d1bd41c

10 years agoMerge "Enable Swift backup driver for auth 2.0"
Jenkins [Mon, 11 Aug 2014 22:33:32 +0000 (22:33 +0000)]
Merge "Enable Swift backup driver for auth 2.0"

10 years agoMerge "Enable H104, F841 hacking rule and fix violations"
Jenkins [Mon, 11 Aug 2014 17:43:36 +0000 (17:43 +0000)]
Merge "Enable H104, F841 hacking rule and fix violations"

10 years agoMerge "Update help strings"
Jenkins [Mon, 11 Aug 2014 16:53:07 +0000 (16:53 +0000)]
Merge "Update help strings"

10 years agoMake manage.py usable
Mathieu Gagné [Thu, 7 Aug 2014 23:21:49 +0000 (19:21 -0400)]
Make manage.py usable

It's not possible to use manage.py in its current state due to
an exception thrown by oslo.config:

  oslo.config.cfg.ArgsAlreadyParsedError:
    arguments already parsed: cannot register CLI option

This exception is a side-effect of including
cinder.openstack.common.logging in most of the migration scripts.

This change therefore suggests removing oslo.config and other imports
from manage.py to make it usable again.

It is now possible to use manage.py:

  tox -evenv -- python cinder/db/sqlalchemy/migrate_repo/manage.py \
    version_control --url=sqlite:///./cinder.db

  tox -evenv -- python cinder/db/sqlalchemy/migrate_repo/manage.py \
    upgrade --url=sqlite:///./cinder.db

Closes-bug: #1355297
Change-Id: I843cfa9a4e4758a6bc8e5c04f064e9d3107b01fa

10 years agoMerge "Do not translate debug messages"
Jenkins [Mon, 11 Aug 2014 16:08:07 +0000 (16:08 +0000)]
Merge "Do not translate debug messages"

10 years agoEnable H104, F841 hacking rule and fix violations
Zhiteng Huang [Wed, 30 Jul 2014 06:06:37 +0000 (14:06 +0800)]
Enable H104, F841 hacking rule and fix violations

This change enables hacking check H104 and F841, and fixes all
violations.

[H104]    Files with no code shouldn’t contain any license header nor
          comments, and must be left completely empty.
[F841]    local variable name is assigned to but never used

Change-Id: If7fcb737d121fd13b2b103d63f5f26dfaa79c59b

10 years agoEnable Swift backup driver for auth 2.0
Ronen Kat [Thu, 7 Aug 2014 14:00:53 +0000 (17:00 +0300)]
Enable Swift backup driver for auth 2.0

This patch adds support for Swift auth 2.0 to the cinder-backup
Swift driver.

DocImpact

Change-Id: I99585661792420e363b5259c9ed45a853a939a74
Closes-Bug: #1354801

10 years agoUpdated HACKING.rst so that it is accurate
Jay S. Bryant [Sun, 3 Aug 2014 17:46:45 +0000 (12:46 -0500)]
Updated HACKING.rst so that it is accurate

We haven't been very good at enforcing putting new hacking checks
into HACKING.rst.  This change brings the file up to date.

Change-Id: I95ef533d031d333da5615ead997b54c6506c2c2a

10 years agoMerge "Add hacking check for use of LOG.audit"
Jenkins [Sat, 9 Aug 2014 18:46:35 +0000 (18:46 +0000)]
Merge "Add hacking check for use of LOG.audit"

10 years agoUpdate help strings
Andreas Jaeger [Mon, 21 Jul 2014 19:42:14 +0000 (21:42 +0200)]
Update help strings

Fix capitalization of help strings to make help strings consistent.

Change-Id: I04341c31cbb21b01229916cef7bc8ccb199614a2

10 years agoMerge "Update ref used for notifications"
Jenkins [Sat, 9 Aug 2014 15:57:53 +0000 (15:57 +0000)]
Merge "Update ref used for notifications"

10 years agoMerge "Fix snapshot id for snapshot_destroy"
Jenkins [Sat, 9 Aug 2014 15:57:45 +0000 (15:57 +0000)]
Merge "Fix snapshot id for snapshot_destroy"

10 years agoAdd hacking check for use of LOG.audit
Jay S. Bryant [Fri, 1 Aug 2014 20:43:51 +0000 (15:43 -0500)]
Add hacking check for use of LOG.audit

Commit 4dc37abc removes the few instances of LOG.audit that
were in Cinder.  Given that the plan is to remove LOG.audit messages
from OpenStack, I am adding this hacking check to ensure that such
messages do not sneak their way back into Cinder.

Unit tests are included with this change.

Change-Id: Icc416a68f958f60260f1c55af0d8605c95913bf1

10 years agoMerge "Imported Translations from Transifex"
Jenkins [Sat, 9 Aug 2014 15:05:17 +0000 (15:05 +0000)]
Merge "Imported Translations from Transifex"

10 years agoMerge "Use oslo.i18n"
Jenkins [Sat, 9 Aug 2014 15:04:13 +0000 (15:04 +0000)]
Merge "Use oslo.i18n"

10 years agoImported Translations from Transifex
OpenStack Proposal Bot [Sat, 9 Aug 2014 06:08:19 +0000 (06:08 +0000)]
Imported Translations from Transifex

Change-Id: I39d60d1cc7d6c37455852de24356e3e262da8a86

10 years agoMerge "VMware: Volume from non-streamOptimized image"
Jenkins [Sat, 9 Aug 2014 02:30:37 +0000 (02:30 +0000)]
Merge "VMware: Volume from non-streamOptimized image"

10 years agoMerge "Enable checks for E711, E712 and E713"
Jenkins [Sat, 9 Aug 2014 01:07:45 +0000 (01:07 +0000)]
Merge "Enable checks for E711, E712 and E713"

10 years agoMerge "Add CHAP support for 3PAR ISCSI"
Jenkins [Sat, 9 Aug 2014 00:48:49 +0000 (00:48 +0000)]
Merge "Add CHAP support for 3PAR ISCSI"

10 years agoMerge "EMC: Fix minor issue in VNX driver and unit tests"
Jenkins [Sat, 9 Aug 2014 00:26:05 +0000 (00:26 +0000)]
Merge "EMC: Fix minor issue in VNX driver and unit tests"

10 years agoUse oslo.i18n
James Carey [Thu, 7 Aug 2014 04:45:39 +0000 (04:45 +0000)]
Use oslo.i18n

oslo.i18n provides the i18n function that were provided by
oslo-incubator's gettextutils module.

Change-Id: I1f361a8321fb02f03b4f3f3e2ef688fcf19514a3

10 years agoMerge "Improve regex for _ import hacking check"
Jenkins [Fri, 8 Aug 2014 19:15:46 +0000 (19:15 +0000)]
Merge "Improve regex for _ import hacking check"

10 years agoAdd CHAP support for 3PAR ISCSI
Anthony Lee [Tue, 22 Jul 2014 18:40:21 +0000 (11:40 -0700)]
Add CHAP support for 3PAR ISCSI

Adds CHAP support to 3PAR ISCSI.  Volume metadata will store
CHAP credentials to allow volumes to be attached to hosts on
a 3PAR backend.  Credentials are generated when the first volume
is attached.  Subsequent volumes lookup the CHAP credentials
from an existing volume already attached to the host.

Implements: blueprint add-chap-support-3par-iscsi
DocImpact

Change-Id: I45d77c4243339e8fc76969042634c6c45899fbae

10 years agoMerge "Fixing LeftHand live migration error"
Jenkins [Fri, 8 Aug 2014 11:11:56 +0000 (11:11 +0000)]
Merge "Fixing LeftHand live migration error"

10 years agoEMC: Fix minor issue in VNX driver and unit tests
Jeegn Chen [Fri, 8 Aug 2014 08:27:38 +0000 (16:27 +0800)]
EMC: Fix minor issue in VNX driver and unit tests

There were some minor issues in initial commit of VNX Direct Driver
Juno Update (https://review.openstack.org/#/c/104413/), such as typo,
unclear config option help message and missing period.

This change fix these issues.

Change-Id: I82bac9695c8138cff858013b3affeb0557dfcc02
Closes-Bug: #1354272

10 years agoMerge "VMware:Disk type conversion during clone backing"
Jenkins [Fri, 8 Aug 2014 10:52:06 +0000 (10:52 +0000)]
Merge "VMware:Disk type conversion during clone backing"

10 years agoMerge "VMware:Support for attaching disk to backing"
Jenkins [Fri, 8 Aug 2014 10:51:57 +0000 (10:51 +0000)]
Merge "VMware:Support for attaching disk to backing"

10 years agoDo not translate debug messages
Thang Pham [Thu, 7 Aug 2014 21:41:11 +0000 (17:41 -0400)]
Do not translate debug messages

LOG.debug messages do not need to be translated. The rdb driver
has a couple of debug messages that are translated. This patch
removes those debug translations.

Also, logging exception.ImageUnacceptable can contain non-ascii
characters. This patch fixes this by using six.text_type to
properly translate the exception.

Change-Id: I4ed36173f42b7bf487463f148ae94bd061f6bebb

10 years agoMerge "General cleanup of unused objects"
Jenkins [Fri, 8 Aug 2014 01:08:18 +0000 (01:08 +0000)]
Merge "General cleanup of unused objects"

10 years agoMerge "RPC client lazy initialization"
Jenkins [Thu, 7 Aug 2014 21:48:46 +0000 (21:48 +0000)]
Merge "RPC client lazy initialization"

10 years agoFixing LeftHand live migration error
Anthony Lee [Thu, 7 Aug 2014 20:58:34 +0000 (13:58 -0700)]
Fixing LeftHand live migration error

Fixed a bug in the LeftHand driver that was causing an error to occur during
live migration of an instance that is attached to a volume. The solution was
to make sure server access is only requested for a volume if the iSCSI
session doesn't already have access enabled on the LeftHand backend.

Change-Id: I41046beb66f2a6138659ec3e4d1d3f37b37859b8
Closes-Bug: 1311350

10 years agoImprove regex for _ import hacking check
Jay S. Bryant [Sat, 2 Aug 2014 23:06:38 +0000 (18:06 -0500)]
Improve regex for _ import hacking check

Commit 3e2b1117 added a check to make sure that the _
function was being explicitly imported so that translation would
work properly.

I have discovered that those regexes/code would not work in some cases.
Particularly if the import line imported multiple things from
gettextutils or i18n.  Also the check being used to find lines using
the _ function was not right.

This commit fixes the issues and adds appropriate tests.  It also
adds the hacking check to HACKING.rst which should have been done the
first time around.

Change-Id: I7227bb0051836e537bff2f0f97662c06452d5af6

10 years agoGeneral cleanup of unused objects
Wu Wenxiang [Sun, 2 Mar 2014 14:20:49 +0000 (22:20 +0800)]
General cleanup of unused objects

* Remove unused function fake_get_remote_image_service
* Remove unused local function fake_execute2
* stub_out_key_pair_funcs() does nothing, remove it.
* Removed usage of enumerate()

Closes-Bug: #1286714
Closes-Bug: #1286712
Closes-Bug: #1286742
Closes-Bug: #1286809
Change-Id: I76413c886f6903df2adcf4a4ceb8990486a2ff2f

10 years agoMerge "EMC VNX Direct Driver Update for Juno"
Jenkins [Thu, 7 Aug 2014 08:51:51 +0000 (08:51 +0000)]
Merge "EMC VNX Direct Driver Update for Juno"

10 years agoMerge "Change the exception type for Storwize/SVC driver"
Jenkins [Thu, 7 Aug 2014 02:06:08 +0000 (02:06 +0000)]
Merge "Change the exception type for Storwize/SVC driver"

10 years agoMerge "Use auth_token from keystonemiddleware"
Jenkins [Thu, 7 Aug 2014 01:16:43 +0000 (01:16 +0000)]
Merge "Use auth_token from keystonemiddleware"

10 years agoMerge "Add retry_on_deadlock to db update methods"
Jenkins [Wed, 6 Aug 2014 23:48:58 +0000 (23:48 +0000)]
Merge "Add retry_on_deadlock to db update methods"

10 years agoRPC client lazy initialization
Ivan Kolodyazhny [Wed, 6 Aug 2014 10:58:43 +0000 (13:58 +0300)]
RPC client lazy initialization

All *Command classes are instantiating for each cinder-manage command
execution. RPC client should be initialized for VolumeCommands usage.
Some custom RPC clients (oslo.messaging backends) could init RPC
connection after client initialization so it is no need to create RPC
client for every cinder-manage command invoke.

Related-Bug: #1348787
Change-Id: I7b3388dded6eeec972d9949538e1608c3a538734

10 years agoFix snapshot id for snapshot_destroy
Xing Yang [Sun, 3 Aug 2014 13:33:28 +0000 (09:33 -0400)]
Fix snapshot id for snapshot_destroy

The id passed to snapshot_destroy should be snapshot['id'],
not volume['id'].

CCLA SCHEDULE B SUBMISSION

Change-Id: I1d84f1d596ebf014c0e3ea4202902ff515b3172a
Closes-Bug: 1351997

10 years agoUse auth_token from keystonemiddleware
Brant Knudson [Tue, 24 Jun 2014 21:32:54 +0000 (16:32 -0500)]
Use auth_token from keystonemiddleware

auth_token middleware in python-keystoneclient is deprecated and has
been moved to the keystonemiddleware repo.

Closes-Bug: #1342274
Change-Id: I1aadbe24db63eb2507b088cd53886d7f2e192cab

10 years agoMerge "Fix error log level in restore-backup routine"
Jenkins [Wed, 6 Aug 2014 01:51:22 +0000 (01:51 +0000)]
Merge "Fix error log level in restore-backup routine"

10 years agoMerge "Change 3PAR delete message when volume is busy"
Jenkins [Tue, 5 Aug 2014 19:13:42 +0000 (19:13 +0000)]
Merge "Change 3PAR delete message when volume is busy"

10 years agoFix error log level in restore-backup routine
ling-yun [Mon, 7 Jul 2014 08:51:24 +0000 (16:51 +0800)]
Fix error log level in restore-backup routine

When doing backup-restore operation, it needs volume's size is not less
than backup's size.
But in backup-restore routine, when volume's size is bigger than backup's
size, it logs the the info of volume's size and backup's size to warn
level, which I think it should log the info to info level.
This bug fix it.

Change-Id: Ic7210e3b018053be7a6f567cd0a7b20d51d403b8
Closes-Bug: #1338481

10 years agoAdd retry_on_deadlock to db update methods
John Griffith [Fri, 1 Aug 2014 23:10:55 +0000 (17:10 -0600)]
Add retry_on_deadlock to db update methods

There's some known races that have been addressed in
Nova via a retry_on_deadlock deocrator.  Some known
cases in Cinder exist as well when dealing with updates
to quotas and reservations_expire.

This patch introduces the decorator to Cinder and hits
the methods known to be susceptible to deadlock as well
as some others that seem as though they'd fall into the
same category.

Leverages work that's already been done in Nova

Co-Authored-By: Vish Ishaya <vishvananda@gmail.com>
Change-Id: Ic807f4f8a333e4d5477f86e41eea40191637087c
Partial-bug: #1350466

10 years agoFix unit test test_import_record_with_verify
Marc Koderer [Thu, 31 Jul 2014 08:10:17 +0000 (10:10 +0200)]
Fix unit test test_import_record_with_verify

The test case test_import_record_with_verify is intended to call a
backup service class with a defined verify function. This verify
function wasn't overloaded by the fake service.

Change-Id: Ib5738e9c463856dd71a47717b7abb8dff785b3b1
Closes-bug: #1350699

10 years agoMerge "Add note that some checks are disabled on purpose"
Jenkins [Tue, 5 Aug 2014 07:54:31 +0000 (07:54 +0000)]
Merge "Add note that some checks are disabled on purpose"

10 years agoChange the exception type for Storwize/SVC driver
Li Min Liu [Tue, 5 Aug 2014 03:39:09 +0000 (11:39 +0800)]
Change the exception type for Storwize/SVC driver

When create a volume from snapshot or clone a volume,
Storwize/SVC require the same size for the source volume
and target, if not, will raise VolumeDriverException.

For this case, InvalidInput is more appropriate.

Change-Id: I4383c2eb8758077b3029b862dd8b6f982e1850a7

10 years agoMerge "Fixes migrate_volume_completion"
Jenkins [Tue, 5 Aug 2014 00:54:58 +0000 (00:54 +0000)]
Merge "Fixes migrate_volume_completion"

10 years agoMerge "Introduce iSCSI driver for Pure Storage FlashArray"
Jenkins [Mon, 4 Aug 2014 23:14:21 +0000 (23:14 +0000)]
Merge "Introduce iSCSI driver for Pure Storage FlashArray"

10 years agoMerge "Bump oslo.rootwrap to 1.3.0.0a1 for Cinder"
Jenkins [Mon, 4 Aug 2014 22:20:34 +0000 (22:20 +0000)]
Merge "Bump oslo.rootwrap to 1.3.0.0a1 for Cinder"

10 years agoMerge "Storwize/SVC can not get the right host"
Jenkins [Mon, 4 Aug 2014 08:03:42 +0000 (08:03 +0000)]
Merge "Storwize/SVC can not get the right host"

10 years agoMerge "Avoid OSError in get_blkdev_major_minor with network filesystems"
Jenkins [Sun, 3 Aug 2014 22:21:18 +0000 (22:21 +0000)]
Merge "Avoid OSError in get_blkdev_major_minor with network filesystems"

10 years agoMerge "Add return of updated object on update from DB"
Jenkins [Sun, 3 Aug 2014 22:17:59 +0000 (22:17 +0000)]
Merge "Add return of updated object on update from DB"

10 years agoMerge "Move generate_password into volume utils"
Jenkins [Sun, 3 Aug 2014 22:10:37 +0000 (22:10 +0000)]
Merge "Move generate_password into volume utils"

10 years agoMerge "Move SSHPool into ssh_utils.py"
Jenkins [Sun, 3 Aug 2014 21:30:18 +0000 (21:30 +0000)]
Merge "Move SSHPool into ssh_utils.py"

10 years agoMerge "Fix solidfire accept_transfer"
Jenkins [Sat, 2 Aug 2014 05:50:58 +0000 (05:50 +0000)]
Merge "Fix solidfire accept_transfer"

10 years agoMerge "Change logging level AUDIT to INFO"
Jenkins [Sat, 2 Aug 2014 00:36:51 +0000 (00:36 +0000)]
Merge "Change logging level AUDIT to INFO"

10 years agoMerge "fixing the iSER transport protocol when using LVMISERDriver"
Jenkins [Sat, 2 Aug 2014 00:35:56 +0000 (00:35 +0000)]
Merge "fixing the iSER transport protocol when using LVMISERDriver"

10 years agoMerge "Further cleanup of reservations index"
Jenkins [Fri, 1 Aug 2014 22:22:31 +0000 (22:22 +0000)]
Merge "Further cleanup of reservations index"

10 years agoChange logging level AUDIT to INFO
Christian Berendt [Tue, 1 Jul 2014 09:34:08 +0000 (11:34 +0200)]
Change logging level AUDIT to INFO

According to the latest revision of the logging guidelines message
of type AUDIT should be moved to INFO.

The latest revision is available at https://review.openstack.org/#/c/91446/
at the moment.

Change-Id: I2d86fa634f6424b0bb862319b9ae40d3f3b1ec7a

10 years agoFix solidfire accept_transfer
Zhiteng Huang [Fri, 1 Aug 2014 17:50:47 +0000 (01:50 +0800)]
Fix solidfire accept_transfer

Previous fix has a mistake which makes the situation worse.  This change
fix volume['project_id'] and volume['user_id'] and adds unit test for
accept_transfer.

Closes-bug: # 1349475

Change-Id: I7b2bcefa4c8d173689cc63ee5aa9e00397c7f8ca

10 years agoVMware: Volume from non-streamOptimized image
Vipin Balachandran [Sun, 29 Jun 2014 13:32:20 +0000 (19:02 +0530)]
VMware: Volume from non-streamOptimized image

Volume creation from non-streamOptimized images (preallocated/thin/sparse)
has following problems:

1) Sparse vmdk image is not converted to appropriate virtual disk type
   suitable for attaching to a nova instance.
2) The adapter type in image meta-data is ignored while creating volumes.
3) The vmware:vmdk_type extra_spec property is ignored.
4) Virtual disk extent operation is called with a wrong parameter which
   might result in unwanted disk provisioning type conversion.

This patch fixes the first 3 problems using the following workflow:

a) Create a disk-less backing.
b) Create a virtual disk (single flat extent) from the non-streamOptimized
   image
c) Attach the virtual disk to the backing
d) Clone the backing (if needed) to perform disk provisioning type conversion

Closes-Bug: #1287176
Closes-Bug: #1287185
Closes-Bug: #1284284
Change-Id: Ib7e9fae81d69d2fe490a4b603337f3d5cee1138c

10 years agoEnable checks for E711, E712 and E713
Christian Berendt [Fri, 1 Aug 2014 11:10:20 +0000 (13:10 +0200)]
Enable checks for E711, E712 and E713

* E711 comparison to None should be 'if cond is None:'
* E712 comparison to True should be 'if cond is True:' or 'if cond:'
* E713 test for membership should be 'not in'

Change-Id: I1481209a85fa6db0343d0111e2b19d9fab4538a7

10 years agoAdd note that some checks are disabled on purpose
Christian Berendt [Thu, 31 Jul 2014 08:17:54 +0000 (10:17 +0200)]
Add note that some checks are disabled on purpose

Change-Id: I9a2daf57a8bb73e292d99f5177c310d75061cc13

10 years agoVMware:Disk type conversion during clone backing
Vipin Balachandran [Thu, 10 Jul 2014 06:55:49 +0000 (12:25 +0530)]
VMware:Disk type conversion during clone backing

This patch adds support for converting virtual disk provisioning
type during clone backing operation. Currently volume creation from
preallocated/sparse image doesn't honour the disk type property in
the volume extra spec. The workflow to address this issue requires
disk provisioning type conversion during clone.

Partial-Bug: #1287176
Partial-Bug: #1287185

Change-Id: Ie493768445b838d3e9447edb76d9845e972bc7c3

10 years agoVMware:Support for attaching disk to backing
Vipin Balachandran [Sun, 29 Jun 2014 13:30:04 +0000 (19:00 +0530)]
VMware:Support for attaching disk to backing

This change adds support for attaching a virtual disk to an existing
backing VM. Currently volume creation from preallocated/sparse image doesn't
honour the disk type in the volume extra spec and adapter type in the image
meta-data. The workflow to address these issues requires the above mentioned
method. This change also sets the disk size of backing to at least 1MB which
is the minimum required by VIM APIs.

Closes-Bug: #1340315
Partial-Bug: #1284284
Partial-Bug: #1287185
Partial-Bug: #1287176

Change-Id: Icdb1f26d5c8eaa42408a14c57c7394d96dda078f

10 years agoChange 3PAR delete message when volume is busy
Walter A. Boring IV [Wed, 30 Jul 2014 21:20:46 +0000 (14:20 -0700)]
Change 3PAR delete message when volume is busy

This patch traps for when a volume is busy at
delete time.   It then logs a more useful message
and raises a VolumeIsBusy exception.

Change-Id: I689c1a5ff5e2d4c748a98615f5610a029a027e35
Closes-Bug: 1349636

10 years agoMerge "Skip incompatible test on OSX"
Jenkins [Thu, 31 Jul 2014 07:01:01 +0000 (07:01 +0000)]
Merge "Skip incompatible test on OSX"

10 years agoMerge "Change corrupted spelling mistakes"
Jenkins [Wed, 30 Jul 2014 21:32:01 +0000 (21:32 +0000)]
Merge "Change corrupted spelling mistakes"

10 years agoMove generate_password into volume utils
Eric Harney [Fri, 25 Jul 2014 20:52:56 +0000 (16:52 -0400)]
Move generate_password into volume utils

This is only used in places where volume/utils is
relevant, and moving it there reduces the amount of
code that has to load the python Crypto library.

Closes-Bug: #1348787

Change-Id: Id74fdd2d6f12f0196055deb1b0dd610677caff0f

10 years agoMove SSHPool into ssh_utils.py
Eric Harney [Fri, 25 Jul 2014 19:59:40 +0000 (15:59 -0400)]
Move SSHPool into ssh_utils.py

utils.py is loaded by almost everything, but SSH
code and imports (paramiko) are only needed by certain
drivers.

Split this into a separate file to reduce overhead (and
things that can break) for commands like cinder-manage.

Partial-Bug: #1348787

Change-Id: I46896f2bd1fd0de2aedde8e87e255398e5bc3171

10 years agoFixes migrate_volume_completion
git-harry [Sat, 19 Jul 2014 10:25:29 +0000 (11:25 +0100)]
Fixes migrate_volume_completion

The following issues are addressed:

The source volume is never deleted when a migration is done because
status_update was assumed to always be a dict.

Unattached volumes are set to in-use when retyped.

In-use migrated volumes are left in status attaching.

Change-Id: Ib5034679a5f469ba53e6280a47e8c94d633cf911
Partial-Bug: 1316079

10 years agoChange corrupted spelling mistakes
sanuptpm [Tue, 29 Jul 2014 14:55:19 +0000 (20:25 +0530)]
Change corrupted spelling mistakes

Change-Id: I62b4d94d135fa620fac071a5196957c11bb03b77

10 years agoEMC VNX Direct Driver Update for Juno
Jeegn Chen [Thu, 3 Jul 2014 01:59:16 +0000 (09:59 +0800)]
EMC VNX Direct Driver Update for Juno

VNX Direct Driver has been contributed to Icehouse release.
This patch refactors driver and adds the following new features

* Array-based Backend Support
* FC Basic Support
* Target Port Selection for MPIO
* Initiator Auto Registration
* Storage Group Auto Deletion
* Multiple Authentication Type Support
* Storage-Assisted Volume Migration
* SP Toggle for HA
* Security File Support
* Advance LUN Features
    # Compression Support
    # Deduplication Support
    # FAST VP Support
    # FAST Cache Support
* Storage-assisted Retype
* External Volume Management
* Read-only Volume
* FC Auto Zoning

Certificate Test Results
    https://bugs.launchpad.net/cinder/+bug/1336640

CCLA SCHEDULE B SUBMISSION

Change-Id: Ib7edaefa5eceb8e8c01ec0ce0dcdada7eaa9dd08
Implements: blueprint emc-vnx-direct-driver-juno-update

10 years agoStorwize/SVC can not get the right host
Li Min Liu [Tue, 29 Jul 2014 06:03:40 +0000 (14:03 +0800)]
Storwize/SVC can not get the right host

When only config FC host, Storwize/SVC driver can not get the host
by remote WWPNs except the first one.

Filter 'iscsi_name' and 'WWPN' from host information, if not configure
iSCSI port, only return the first WWPN.

Change-Id: I27852e49f5dfb3a94eed08bea0e5d81a9d7aef9c
Closes-Bug: #1343142

10 years agoSkip incompatible test on OSX
John Griffith [Wed, 30 Jul 2014 02:20:31 +0000 (20:20 -0600)]
Skip incompatible test on OSX

Can't seem to get the test:
cinder.tests.test_volume.VolumeTestCase.test_delete_no_dev_fails
to run right, tried macports and homebrew versions of fileutils
but still get makedir failures. Give up and just detect if OSX
and skip.

Change-Id: Ic2f7603cf2960e2fbaac9fce677461f60ded541d

10 years agoMerge "Fix glance metadata SQL query performance"
Jenkins [Tue, 29 Jul 2014 20:48:43 +0000 (20:48 +0000)]
Merge "Fix glance metadata SQL query performance"

10 years agoMerge "Remove cinder-rpc-zmq-receiver"
Jenkins [Tue, 29 Jul 2014 19:22:32 +0000 (19:22 +0000)]
Merge "Remove cinder-rpc-zmq-receiver"

10 years agoMerge "Add storageHost content to volume messages."
Jenkins [Tue, 29 Jul 2014 18:38:49 +0000 (18:38 +0000)]
Merge "Add storageHost content to volume messages."

10 years agoMerge "HP 3PAR retype implementation"
Jenkins [Tue, 29 Jul 2014 18:38:27 +0000 (18:38 +0000)]
Merge "HP 3PAR retype implementation"