From: Marcus Furlong <furlongm@gmail.com>
Date: Tue, 6 Sep 2016 12:44:22 +0000 (+1000)
Subject: fix broken join that stops polling service from starting
X-Git-Tag: 9.4.0~4^2
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=ff327ffa3a9c5a712cea73654fc1e07ac97de105;p=puppet-modules%2Fpuppet-ceilometer.git

fix broken join that stops polling service from starting

Closes-Bug: 1620449

Change-Id: Ice57bcf767d243729a08af790c1597972dd9cb5c
---

diff --git a/manifests/agent/polling.pp b/manifests/agent/polling.pp
index ab5f02e..e2d786c 100644
--- a/manifests/agent/polling.pp
+++ b/manifests/agent/polling.pp
@@ -79,7 +79,7 @@ class ceilometer::agent::polling (
   }
 
   $namespaces = [$central_namespace_name, $compute_namespace_name, $ipmi_namespace_name]
-  $namespaces_real = inline_template('<%= @namespaces.find_all {|x| x !~ /^undef/ }.join "," %>')
+  $namespaces_real = inline_template('<%= @namespaces.select { |x| x and x !~ /^undef/ }.compact.join "," %>')
 
   package { 'ceilometer-polling':
     ensure => $package_ensure,
diff --git a/spec/classes/ceilometer_agent_polling_spec.rb b/spec/classes/ceilometer_agent_polling_spec.rb
index 5dda814..3280a17 100644
--- a/spec/classes/ceilometer_agent_polling_spec.rb
+++ b/spec/classes/ceilometer_agent_polling_spec.rb
@@ -48,7 +48,7 @@ describe 'ceilometer::agent::polling' do
       )
     end
 
-    it 'configures central agent' do
+    it 'configures polling namespaces' do
       is_expected.to contain_ceilometer_config('DEFAULT/polling_namespaces').with_value('central,compute,ipmi')
     end
 
@@ -77,6 +77,18 @@ describe 'ceilometer::agent::polling' do
       end
     end
 
+    context 'with central and ipmi polling namespaces disabled' do
+      before do
+        params.merge!({
+          :central_namespace => false,
+          :ipmi_namespace    => false })
+      end
+
+      it 'configures compute polling namespace' do
+        is_expected.to contain_ceilometer_config('DEFAULT/polling_namespaces').with_value('compute')
+      end
+    end
+
     context 'with disabled service managing' do
       before do
         params.merge!({