From: Dan Wendlandt <dan@nicira.com>
Date: Sun, 9 Sep 2012 05:18:39 +0000 (-0700)
Subject: Give better error to client on server 500 error
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=fde632fc5cc95d5abceb0493d2cbdcf274c11043;p=openstack-build%2Fneutron-build.git

Give better error to client on server 500 error

bug 1048109

Change-Id: Iaaa187a7868ee6227315b9c3354b424fe7c42508
---

diff --git a/quantum/api/v2/resource.py b/quantum/api/v2/resource.py
index adf574e90..560ac52e9 100644
--- a/quantum/api/v2/resource.py
+++ b/quantum/api/v2/resource.py
@@ -109,7 +109,10 @@ def Resource(controller, faults=None, deserializers=None, serializers=None):
         except Exception as e:
             # NOTE(jkoelker) Everyting else is 500
             LOG.exception('%s failed' % action)
-            body = serializer({'QuantumError': str(e)})
+            # Do not expose details of 500 error to clients.
+            msg = _('Request Failed: internal server error while '
+                    'processing your request.')
+            body = serializer({'QuantumError': msg})
             kwargs = {'body': body, 'content_type': content_type}
             raise webob.exc.HTTPInternalServerError(**kwargs)