From: John Griffith <john.griffith@solidfire.com>
Date: Mon, 14 Jul 2014 23:10:18 +0000 (-0600)
Subject: Mock out time.sleep in storwize unit tests
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=f9ae768811fda1a1ac0c1d40b74bb73c416dae52;p=openstack-build%2Fcinder-build.git

Mock out time.sleep in storwize unit tests

The Storwize driver has issues that required them
to add a sleep 1 on init of the driver.

No big deal, but causes unit tests to take a very long
time waiting for the "time.sleep(1)" on every single
unit test that calls init.

This patch just mocks out the time.sleep so we don't have
to do the silly waiting in unit tests.

Change-Id: I10fc3d00252a7e7b90085cb308fb9c6c7e1f5ea7
---

diff --git a/cinder/tests/test_storwize_svc.py b/cinder/tests/test_storwize_svc.py
index 375594a09..6ac732c12 100644
--- a/cinder/tests/test_storwize_svc.py
+++ b/cinder/tests/test_storwize_svc.py
@@ -21,6 +21,7 @@ Tests for the IBM Storwize family and SVC volume driver.
 import mock
 import random
 import re
+import time
 
 from cinder import context
 from cinder import exception
@@ -1455,7 +1456,8 @@ class StorwizeSVCFakeDriver(storwize_svc.StorwizeSVCDriver):
 
 
 class StorwizeSVCDriverTestCase(test.TestCase):
-    def setUp(self):
+    @mock.patch.object(time, 'sleep')
+    def setUp(self, mock_sleep):
         super(StorwizeSVCDriverTestCase, self).setUp()
         self.USESIM = True
         if self.USESIM: