From: Wilson McCoubrey <wilson@puppet.com>
Date: Thu, 16 Mar 2017 11:35:57 +0000 (+0000)
Subject: [MODULES-4528] Replace Puppet.version.to_f with Puppet::Util::Package.versioncmp
X-Git-Tag: 1.9.0~8^2~1
X-Git-Url: https://review.fuel-infra.org/gitweb?a=commitdiff_plain;h=f36be9de1751c502583f12b05bab226e6ee36bef;p=puppet-modules%2Fpuppetlabs-firewall.git

[MODULES-4528] Replace Puppet.version.to_f with Puppet::Util::Package.versioncmp
---

diff --git a/lib/puppet/type/firewall.rb b/lib/puppet/type/firewall.rb
index 2493447..2fa4609 100644
--- a/lib/puppet/type/firewall.rb
+++ b/lib/puppet/type/firewall.rb
@@ -1555,7 +1555,7 @@ Puppet::Type.newtype(:firewall) do
   end
 
   # autobefore is only provided since puppet 4.0
-  if Puppet.version.to_f >= 4.0
+  if Puppet::Util::Package.versioncmp(Puppet.version, '4.0') >= 0
     # On RHEL 7 this needs to be threaded correctly to manage SE Linux permissions after persisting the rules
     autobefore(:file) do
       [ '/etc/sysconfig/iptables', '/etc/sysconfig/ip6tables' ]